Re: [PATCH v9 07/11] media: i2c: ov772x: Support frame interval handling

Hi Jacopo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.16-rc2 next-20180220] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v3 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

On Wed, Feb 14, 2018 at 6:04 PM, Laurent Pinchart wrote: > The internal LVDS encoders now have their own DT bindings. Before > switching the driver infrastructure to those new bindings, implement > backward-compatibility through live DT patching. > >

Re: [PATCH v9 03/11] media: platform: Add Renesas CEU driver

Hi Jacopo, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.16-rc2 next-20180220] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v9 07/11] media: i2c: ov772x: Support frame interval handling

Hi Jacopo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.16-rc2 next-20180220] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[RFC PATCH] media: i2c: ov772x: ov772x_frame_intervals[] can be static

Fixes: 42b7d5be5f1f ("media: i2c: ov772x: Support frame interval handling") Signed-off-by: Fengguang Wu --- ov772x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c index eba71d97..0d8ce2a

Re: [PATCH] serial: sh-sci: prevent lockup on full TTY buffers

Hi Uli, On Fri, Feb 16, 2018 at 3:27 PM, Ulrich Hecht wrote: > On Thu, Feb 15, 2018 at 2:12 PM, Wolfram Sang wrote: >>> This can be prevented by doing a dummy read of the RX data register. >> >> Just so I understand the issue correctly: We are

Re: [PATCH] serial: sh-sci: prevent lockup on full TTY buffers

Hi Greg, On Fri, Feb 16, 2018 at 7:44 PM, Greg KH wrote: > On Thu, Feb 15, 2018 at 01:02:27PM +0100, Ulrich Hecht wrote: >> When the TTY buffers fill up to the configured maximum, a system lockup >> occurs: >> >> [ 598.820128] INFO: rcu_preempt detected stalls on CPUs/tasks: >>

RE: [PATCH] serial: sh-sci: prevent lockup on full TTY buffers

Hi, > From: Ulrich Hecht, Sent: Thursday, February 15, 2018 9:02 PM > > When the TTY buffers fill up to the configured maximum, a system lockup > occurs: > > [ 598.820128] INFO: rcu_preempt detected stalls on CPUs/tasks: > [ 598.825796] 0-...!: (1 GPs behind) idle=5a6/2/0 softirq=1974/1974

Re: [PATCH 1/2] ARM: shmobile: Factor out complex condition

Hi Marek, On Sat, Feb 17, 2018 at 12:46 PM, Marek Vasut wrote: > On 02/17/2018 09:18 AM, Wolfram Sang wrote: >>> -if ((client->addr == 0x58 && !strcmp(client->name, "da9063")) || >>> -(client->addr == 0x68 && !strcmp(client->name, "da9210")) || >>> -

Re: [PATCH v2 4/5] arm64: dts: renesas: initial Condor board device tree

Hi Sergei, On Fri, Feb 16, 2018 at 7:35 PM, Sergei Shtylyov wrote: > Add the initial device tree for the R8A77980 SoC based Condor board. > The board has 1 debug serial port (SCIF0); include support for it, so > that the serial console can work. > > Based on

Re: [PATCH] sh_eth: simplify sh_eth_check_reset()

On Sun, Feb 18, 2018 at 4:21 PM, Sergei Shtylyov wrote: > The *while* loop in this function can be turned into a normal *for* loop. > And getting rid of the single return point saves us a few more LoCs... > > Signed-off-by: Sergei Shtylyov

Re: [PATCH v2 4/5] arm64: dts: renesas: initial Condor board device tree

On Mon, Feb 19, 2018 at 11:34:41AM +0300, Sergei Shtylyov wrote: > Hello! > > On 2/19/2018 11:30 AM, Geert Uytterhoeven wrote: > > > > Add the initial device tree for the R8A77980 SoC based Condor board. > > > The board has 1 debug serial port (SCIF0); include support for it, so > > > that the

Re: [PATCH 2/2] ARM: shmobile: porter: enable R-Car Gen2 regulator quirk

On Sat, Feb 17, 2018 at 3:06 AM, Marek Vasut wrote: > Porter needs the regulator quirk, just like the other boards, > the DA9063 and DA9210 IRQ line is connected to CPU IRQ2 . But > unlike the other boards, the DA9063 is at 0x5a on Porter. > > Signed-off-by: Marek Vasut

Re: [PATCH 0/3] pinctrl: sh-pfc: r8a7795,6: Fix pin assignment definitions

On Fri, Feb 16, 2018 at 03:25:01PM +0100, Ulrich Hecht wrote: > Hi! > > This series contains fixes to the PFC register definitions for r8a7795 and > r8a7796 from the BSP that are not upstream yet. > As far as I could tell, these changes check out with the Gen3 datasheet > revision 0.80. Agreed.

Re: [PATCH] clk: fix false-positive Wmaybe-uninitialized warning

Hi Arnd, On Fri, Feb 16, 2018 at 4:27 PM, Arnd Bergmann wrote: > When we build this driver with on x86-32, gcc produces a false-positive > warning: > > drivers/clk/renesas/clk-sh73a0.c: In function 'sh73a0_cpg_clocks_init': > drivers/clk/renesas/clk-sh73a0.c:155:10: error:

Re: [PATCH v2 3/5] arm64: dts: renesas: r8a77980: add EtherAVB support

On Fri, Feb 16, 2018 at 7:32 PM, Sergei Shtylyov wrote: > Define the generic R8A77980 part of the EtherAVB device node. > > Based on the original (and large) patch by Vladimir Barinov. > > Signed-off-by: Vladimir Barinov >

Re: [PATCH 0/3] pinctrl: sh-pfc: add HDMI pins

On Fri, Feb 16, 2018 at 03:25:39PM +0100, Ulrich Hecht wrote: > Hi! > > Straight from the BSP, HDMI pins for r8a7795{,-es1} and r8a7796. Magic > numbers verified according to "pinfunction" document revisions 0.54 (M3-W) > and 0.553 (H3). Reviewed-by: Simon Horman

Re: [PATCH 2/2] ARM: shmobile: porter: enable R-Car Gen2 regulator quirk

On 02/19/2018 09:42 AM, Geert Uytterhoeven wrote: > On Sat, Feb 17, 2018 at 3:06 AM, Marek Vasut wrote: >> Porter needs the regulator quirk, just like the other boards, >> the DA9063 and DA9210 IRQ line is connected to CPU IRQ2 . But >> unlike the other boards, the DA9063

Re: [PATCH] soc: renesas: r8a77970-sysc: fix power area parents

On Mon, Feb 19, 2018 at 09:38:15AM +0100, Geert Uytterhoeven wrote: > On Fri, Feb 16, 2018 at 9:09 PM, Sergei Shtylyov > wrote: > > According to the figure 9.2(b) of the R-Car Series, 3rd Generation User’s > > Manual: Hardware Rev. 0.80 the A2IRn and A2SCn

Re: [PATCH v2 4/5] arm64: dts: renesas: initial Condor board device tree

Hello! On 2/19/2018 11:30 AM, Geert Uytterhoeven wrote: Add the initial device tree for the R8A77980 SoC based Condor board. The board has 1 debug serial port (SCIF0); include support for it, so that the serial console can work. Based on the original (and large) patch by Vladimir Barinov.

Re: [PATCH v2 0/5] Add R8A77980/Condor board support

On Fri, Feb 16, 2018 at 09:25:30PM +0300, Sergei Shtylyov wrote: > Hello! > > Here's the set of 11 patches against Simon Horman's 'renesas.git' repo's > 'renesas-devel-20180216-v4.16-rc1' tag. I'm adding the device tree support > for the R8A77980-based Condor board (note that NFS root would only

Re: [PATCH] soc: renesas: r8a77970-sysc: fix power area parents

On Fri, Feb 16, 2018 at 9:09 PM, Sergei Shtylyov wrote: > According to the figure 9.2(b) of the R-Car Series, 3rd Generation User’s > Manual: Hardware Rev. 0.80 the A2IRn and A2SCn power areas in R8A77970 have > the A3IR area as a parent, thus the SYSC driver

Re: [PATCH 0/3] pinctrl: sh-pfc: add TMU pins

On Fri, Feb 16, 2018 at 03:26:08PM +0100, Ulrich Hecht wrote: > Hi! > > Straight from the BSP, TMU pins for r8a7795{,-es1} and r8a7796. Magic > numbers verified according to "pinfunction" document revisions 0.54 (M3-W) > and 0.553 (H3). Reviewed-by: Simon Horman

Re: [PATCH 1/2] ARM: shmobile: Factor out complex condition

On Sat, Feb 17, 2018 at 03:06:41AM +0100, Marek Vasut wrote: > Pull the complex condition in regulator_quirk_notify() into > regulator_quirk_check(). Moreover, do not hard-code the I2C > address, but rather use the one in da9xxx_msgs[]. > > Signed-off-by: Marek Vasut

Re: [PATCH 01/15] Documentation: devicetree: R-Car M3-N SoC DT bindings

On Sun, Feb 18, 2018 at 08:52:13PM -0600, Rob Herring wrote: > On Wed, Feb 14, 2018 at 11:01:53AM +0100, Simon Horman wrote: > > On Tue, Feb 13, 2018 at 10:45:48AM +0100, Jacopo Mondi wrote: > > > Add device tree bindings documentation for Renesas R-Car M3-N (r8a77965) > > > SoC. > > > > > >

[PATCH 00/02] ARM: dts: silk: Add EEPROM and GPIO keys

ARM: dts: silk: Add EEPROM and GPIO keys [PATCH 01/02] ARM: dts: silk: Add r1ex24002 EEPROM to DT [PATCH 02/02] ARM: dts: silk: Add GPIO keys to DT This series updates the DTS for the R-Car E2-based Silk board to support an EEPROM connected via I2C and GPIO based tactile switches. Based on the

[PATCH 02/02] ARM: dts: silk: Add GPIO keys to DT

From: Magnus Damm Extend the Silk board support to include SW3, SW4, SW6 and SW12. They are all connected via GPIO lines and handled by the gpio-keys driver. Signed-off-by: Magnus Damm --- arch/arm/boot/dts/r8a7794-silk.dts | 55

[PATCH 01/02] ARM: dts: silk: Add r1ex24002 EEPROM to DT

From: Magnus Damm Extend the Silk board support to include U14 which is an I2C based EEPROM hooked up to the I2C1 bus. Signed-off-by: Magnus Damm --- arch/arm/boot/dts/r8a7794-silk.dts |6 ++ 1 file changed, 6 insertions(+) ---

[PATCH/RFC v3] arm64: r8a77965 Salvator-X SoC/board support prototype

Here's V3 of prototype support for the r8a77965 Salvator-X. This version is based on "renesas-drivers-2018-02-13-v4.16-rc1". By up-porting this patch I am able to track which part of M3-N support that yet to be merged in mainline. If all goes well then new versions of this patch will reduce in

[PATCH] ARM: dts: marzen: Add SDHI0 VCCQ Regulator

From: Magnus Damm Add support for the on-board voltage regulator hooked up to GPIO3_20 on r8a7779 Marzen. The board schematics describes the regulator as U4 TPS2110A. Input wise, U4 has D0 fixed to ground, D1 tied to GPIO3_20 while IN1 is fixed to 3.3V and IN2 is

Re: [PATCH v2 4/5] arm64: dts: renesas: r8a77970: add the LVDS instance

On Thu, Feb 08, 2018 at 07:05:53PM +0300, Sergei Shtylyov wrote: > Hello! > > On 02/08/2018 06:47 PM, Niklas Söderlund wrote: > > > Add the LVDS device to r8a77970.dtsi in a disabled state. Also connect > > the it to the LVDS output of the DU. While at it align the endpoint name > > of the du to

Re: [PATCH 0/2] arm64: dts: renesas: Update OPPs to support CA53 dfs

On Mon, Jan 29, 2018 at 07:21:19PM +0100, Simon Horman wrote: > Describe frequencies, other than the default for CA53 cores. This is a > pre-requisite for using providing alternative frequencies for use with > CPUFreq with these cores. > > CPUFreq requires Z and Z2 clock support to function. >

[PATCH v9 00/11] Renesas Capture Engine Unit (CEU) V4L2 driver

Hello, finally I addressed Laurent's comment on ov772x frame rate handling, which I almost forgot about :) Also, Sergei reported that the ceu node name should be generic, so I changed it to "ceu: camera@e821". All patches but the trivial [11/11] one are now reviewed/acked. Hope this is

[PATCH v9 02/11] include: media: Add Renesas CEU driver interface

Add renesas-ceu header file. Do not remove the existing sh_mobile_ceu.h one as long as the original driver does not go away. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil

[PATCH v9 01/11] dt-bindings: media: Add Renesas CEU bindings

Add bindings documentation for Renesas Capture Engine Unit (CEU). Signed-off-by: Jacopo Mondi Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil ---

Re: [PATCH] sh_eth: simplify sh_eth_check_reset()

From: Sergei Shtylyov Date: Sun, 18 Feb 2018 18:21:05 +0300 > The *while* loop in this function can be turned into a normal *for* loop. > And getting rid of the single return point saves us a few more LoCs... > > Signed-off-by: Sergei Shtylyov

[PATCH v9 06/11] media: i2c: ov772x: Remove soc_camera dependencies

Remove soc_camera framework dependencies from ov772x sensor driver. - Handle clock and gpios - Register async subdevice - Remove soc_camera specific g/s_mbus_config operations - Change image format colorspace from JPEG to SRGB as the two use the same colorspace information but JPEG makes

[PATCH v9 05/11] media: i2c: Copy ov772x soc_camera sensor driver

Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi

[PATCH v9 09/11] media: i2c: tw9910: Remove soc_camera dependencies

Remove soc_camera framework dependencies from tw9910 sensor driver. - Handle clock and gpios - Register async subdevice - Remove soc_camera specific g/s_mbus_config operations - Add kernel doc to driver interface header file - Adjust build system This commit does not remove the original

[PATCH v9 07/11] media: i2c: ov772x: Support frame interval handling

Add support to ov772x driver for frame intervals handling and enumeration. Tested with 10MHz and 24MHz input clock at VGA and QVGA resolutions for 10, 15 and 30 frame per second rates. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart

[renesas:soc-for-v4.17 6/6] drivers/soc/renesas/r8a77980-sysc.c:12:10: fatal error: dt-bindings/power/r8a77980-sysc.h: No such file or directory

tree: https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git soc-for-v4.17 head: 8b49a80541c565d5d8482f15350ab861f60455a1 commit: 8b49a80541c565d5d8482f15350ab861f60455a1 [6/6] soc: renesas: rcar-sysc: add R8A77980 support config: i386-allmodconfig (attached as .config) compiler:

[PATCH v9 03/11] media: platform: Add Renesas CEU driver

Add driver for Renesas Capture Engine Unit (CEU). The CEU interface supports capturing 'data' (YUV422) and 'images' (NV[12|21|16|61]). This driver aims to replace the soc_camera-based sh_mobile_ceu one. Tested with ov7670 camera sensor, providing YUYV_2X8 data on Renesas RZ platform GR-Peach.

[PATCH v9 04/11] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

Add Capture Engine Unit (CEU) node to device tree. Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil ---

Re: [renesas:soc-for-v4.17 6/6] drivers/soc/renesas/r8a77980-sysc.c:12:10: fatal error: dt-bindings/power/r8a77980-sysc.h: No such file or directory

On Tue, Feb 20, 2018 at 12:02:58AM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git > soc-for-v4.17 > head: 8b49a80541c565d5d8482f15350ab861f60455a1 > commit: 8b49a80541c565d5d8482f15350ab861f60455a1 [6/6] soc: renesas: > rcar-sysc:

[PATCH] arm64: dts: r8a77965-salvator-xs: Add support for Salvator-XS with R-Car M3-N

From: Takeshi Kihara Add initial support for the Renesas Salvator-XS (Salvator-X 2nd version) development board equipped with an R-Car M3-N SiP. Most features are enabled through the shared salvator-xs.dtsi board description. The memory configuration is specific

Re: [renesas:soc-for-v4.17 6/6] drivers/soc/renesas/r8a77980-sysc.c:12:10: fatal error: dt-bindings/power/r8a77980-sysc.h: No such file or directory

Hi Simon, On Mon, Feb 19, 2018 at 6:47 PM, Simon Horman wrote: > On Tue, Feb 20, 2018 at 12:02:58AM +0800, kbuild test robot wrote: >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git >> soc-for-v4.17 >> head:

[PATCH v2] arm64: dts: renesas: Add support for Salvator-XS with R-Car M3-N

From: Takeshi Kihara Add initial support for the Renesas Salvator-XS (Salvator-X 2nd version) development board equipped with an R-Car M3-N SiP. Most features are enabled through the shared salvator-xs.dtsi board description. The memory configuration is specific

[PATCH v9 11/11] media: i2c: ov7670: Fully set mbus frame fmt

The sensor driver sets mbus format colorspace information and sizes, but not ycbcr encoding, quantization and xfer function. When supplied with an badly initialized mbus frame format structure, those fields need to be set explicitly not to leave them uninitialized. This is tested by

[PATCH v9 08/11] media: i2c: Copy tw9910 soc_camera sensor driver

Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi

[PATCH v9 10/11] arch: sh: migor: Use new renesas-ceu camera driver

Migo-R platform uses sh_mobile_ceu camera driver, which is now being replaced by a proper V4L2 camera driver named 'renesas-ceu'. Move Migo-R platform to use the v4l2 renesas-ceu camera driver interface and get rid of soc_camera defined components used to register sensor drivers and of platform

Re: [PATCH v2 4/5] arm64: dts: renesas: initial Condor board device tree

On 02/19/2018 12:12 PM, Simon Horman wrote: Add the initial device tree for the R8A77980 SoC based Condor board. The board has 1 debug serial port (SCIF0); include support for it, so that the serial console can work. Based on the original (and large) patch by Vladimir

Re: [PATCH v9 11/11] media: i2c: ov7670: Fully set mbus frame fmt

Hi Jacopo, Thank you for the patch. On Monday, 19 February 2018 18:59:44 EET Jacopo Mondi wrote: > The sensor driver sets mbus format colorspace information and sizes, > but not ycbcr encoding, quantization and xfer function. When supplied > with an badly initialized mbus frame format structure,

Re: [renesas:soc-for-v4.17 6/6] drivers/soc/renesas/r8a77980-sysc.c:12:10: fatal error: dt-bindings/power/r8a77980-sysc.h: No such file or directory

On Mon, Feb 19, 2018 at 06:49:50PM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Mon, Feb 19, 2018 at 6:47 PM, Simon Horman wrote: > > On Tue, Feb 20, 2018 at 12:02:58AM +0800, kbuild test robot wrote: > >> tree:

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

Hi Hans, Thanks for your feedback. [snip] > > >>> Can you then fix v4l2-compliance to stop testing colorspace > > >>> against 0xff > > >>> ? > > >> > > >> For now I can simply relax this test for subdevs with sources and sinks. > > > > > > You also need to relax it for video nodes with MC