Re: [PATCH] arm64: dts: renesas: r8a7795: Add missing SYS-DMAC2 dmas

2018-03-09 Thread Niklas Söderlund
Hi Geert, Thanks for your patch. On 2018-03-08 15:10:05 +0100, Geert Uytterhoeven wrote: > On R-Car H3, on-chip peripheral modules that can make use of DMA are > wired to either SYS-DMAC0 only, or to both SYS-DMAC1 and SYS-DMAC2. > > Add the missing DMA properties pointing to SYS-DMAC2 for

[PATCH 05/11] media: vsp1: Clean up DLM objects on error

2018-03-09 Thread Kieran Bingham
If there is an error allocating a display list within a DLM object the existing display lists are not free'd, and neither is the DL body pool. Use the existing vsp1_dlm_destroy() function to clean up on error. Signed-off-by: Kieran Bingham ---

[PATCH 07/11] media: vsp1: Use header display lists for all WPF outputs linked to the DU

2018-03-09 Thread Kieran Bingham
Header mode display lists are now supported on all WPF outputs. To support extended headers and auto-fld capabilities for interlaced mode handling only header mode display lists can be used. Disable the headerless display list configuration, and remove the dead code. Signed-off-by: Kieran

[GIT PULL FOR renesas-drivers] vsp1/du/interlaced/v1

2018-03-09 Thread Kieran Bingham
Hi Geert, Please consider including this branch in renesas-drivers. -- Regards Kieran The following changes since commit 397eb3811ec096d0ceefa1dbea2d0ae68feb0587: media: vsp1: Move video configuration to a cached dlb (2018-03-07 21:19:29 +) are available in the git repository at:

[PATCH 02/11] media: vsp1: use kernel __packed for structures

2018-03-09 Thread Kieran Bingham
The kernel provides a __packed definition to abstract away from the compiler specific attributes tag. Convert all packed structures in VSP1 to use it. Signed-off-by: Kieran Bingham --- drivers/media/platform/vsp1/vsp1_dl.c | 6 +++--- 1 file changed, 3

[PATCH 00/11] R-Car DU Interlaced support through VSP1

2018-03-09 Thread Kieran Bingham
The Gen3 R-Car DU devices make use of the VSP to handle frame processing. In this series we implement support for handling interlaced pipelines by using the auto-fld feature of the VSP hardware. The implementation is preceded by some cleanup work and refactoring, through patches 1 to 6. These

[PATCH 06/11] media: vsp1: Provide VSP1 feature helper macro

2018-03-09 Thread Kieran Bingham
The VSP1 devices define their specific capabilities through features marked in their device info structure. Various parts of the code read this info structure to infer if the features are available. Wrap this into a more readable vsp1_feature(vsp1, f) macro to ensure that usage is consistent

[PATCH 01/11] media: vsp1: drm: Fix minor grammar error

2018-03-09 Thread Kieran Bingham
The pixel format is 'unsupported'. Fix the small debug message which incorrectly declares this. Signed-off-by: Kieran Bingham --- drivers/media/platform/vsp1/vsp1_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/4] pinctrl: sh-pfc: r8a7796: Add VIN4, VIN5 pins, groups and functions

2018-03-09 Thread Geert Uytterhoeven
Hi Niklas, On Fri, Mar 9, 2018 at 10:58 PM, Niklas Söderlund wrote: > On 2018-03-09 13:33:03 +0100, Geert Uytterhoeven wrote: >> P.S. Apparently R-Car Gen2 and Gen3 also support 8-bit YCbCr input data >> on the DATA8-15 pins, for which we don't have pin groups

[PATCH 03/11] media: vsp1: Rename dl_child to dl_next

2018-03-09 Thread Kieran Bingham
Both vsp1_dl_list_commit() and __vsp1_dl_list_put() walk the display list chain referencing the nodes as children, when in reality they are siblings. Update the terminology to 'dl_next' to be consistent with the vsp1_video_pipeline_run() usage. Signed-off-by: Kieran Bingham

Re: [PATCH 1/4] pinctrl: sh-pfc: r8a7796: Add VIN4, VIN5 pins, groups and functions

2018-03-09 Thread Niklas Söderlund
Hi Geert, On 2018-03-09 13:33:03 +0100, Geert Uytterhoeven wrote: > Hi Uli, > > On Mon, Feb 26, 2018 at 11:18 AM, Geert Uytterhoeven > wrote: > > On Mon, Feb 26, 2018 at 10:21 AM, Geert Uytterhoeven > > wrote: > >> On Mon, Feb 26, 2018 at 10:02 AM,

[PATCH 08/11] media: vsp1: Add support for extended display list headers

2018-03-09 Thread Kieran Bingham
Extended display list headers allow pre and post command lists to be executed by the VSP pipeline. This provides the base support for features such as AUTO_FLD (for interlaced support) and AUTO_DISP (for supporting continuous camera preview pipelines. Signed-off-by: Kieran Bingham

[PATCH 11/11] drm: rcar-du: Support interlaced video output through vsp1

2018-03-09 Thread Kieran Bingham
Use the newly exposed VSP1 interface to enable interlaced frame support through the VSP1 lif pipelines. Signed-off-by: Kieran Bingham --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 1 + drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 3 +++ 2 files changed, 4

[PATCH 10/11] media: vsp1: Support Interlaced display pipelines

2018-03-09 Thread Kieran Bingham
Calculate the top and bottom fields for the interlaced frames and utilise the extended display list command feature to implement the auto-field operations. This allows the DU to update the VSP2 registers dynamically based upon the currently processing field. Signed-off-by: Kieran Bingham

[PATCH 09/11] media: vsp1: Provide support for extended command pools

2018-03-09 Thread Kieran Bingham
VSPD and VSP-DL devices can provide extended display lists supporting extended command display list objects. These extended commands require their own dma memory areas for a header and body specific to the command type. Implement a command pool to allocate all necessary memory in a single DMA

[PATCH 04/11] media: vsp1: Remove unused display list structure field

2018-03-09 Thread Kieran Bingham
The vsp1 reference in the vsp1_dl_body structure is not used. Remove it. Signed-off-by: Kieran Bingham --- drivers/media/platform/vsp1/vsp1_dl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_dl.c

[PATCH 2/3] rcar-vin: allocate a scratch buffer at stream start

2018-03-09 Thread Niklas Söderlund
Before starting capturing allocate a scratch buffer which can be used by the driver to give to the hardware if no buffers are available from userspace. The buffer is not used in this patch but prepares for future refactoring where the scratch buffer can be used to avoid the need to fallback on

[PATCH 3/3] rcar-vin: use scratch buffer and always run in continuous mode

2018-03-09 Thread Niklas Söderlund
Instead of switching capture mode depending on how many buffers are available use a scratch buffer and always run in continuous mode. By using a scratch buffer the responsiveness of the capture loop is increased as it can keep running even if there are no buffers available from userspace. As soon

[PATCH 0/3] rcar-vin: always run in continues mode

2018-03-09 Thread Niklas Söderlund
Hi, This series reworks the R-Car VIN driver to only run using its continues capture mode. This improves performance a lot when userspace struggles to keep up and queue buffers as fast as the VIN driver consumes them. The solution to always be able to run in continues is to introduce a

[PATCH 1/3] rcar-vin: remove duplicated check of state in irq handler

2018-03-09 Thread Niklas Söderlund
This is an error from when the driver where converted from soc-camera. There is absolutely no gain to check the state variable two times to be extra sure if the hardware is stopped. Signed-off-by: Niklas Söderlund ---

Re: [PATCH 1/4] pinctrl: sh-pfc: r8a7796: Add VIN4, VIN5 pins, groups and functions

2018-03-09 Thread Niklas Söderlund
Hi Geert, On 2018-03-09 23:24:37 +0100, Geert Uytterhoeven wrote: > Hi Niklas, > > On Fri, Mar 9, 2018 at 10:58 PM, Niklas Söderlund > wrote: > > On 2018-03-09 13:33:03 +0100, Geert Uytterhoeven wrote: > >> P.S. Apparently R-Car Gen2 and Gen3 also support 8-bit

Re: [PATCH v2 0/3] drm: Add LVDS decoder bridge

2018-03-09 Thread Archit Taneja
Hi, On Friday 09 March 2018 07:21 PM, Jacopo Mondi wrote: Hello, after some discussion on the proposed bindings for generic lvds decoder and Thine THC63LVD1024, I decided to drop the THC63 specific part and just live with a transparent decoder that does not support any configuration from

[PATCH] pwm: rcar: fix a condition to prevent mismatch value setting to duty

2018-03-09 Thread Yoshihiro Shimoda
From: Ryo Kodama This patch fixes an issue that is possible to set mismatch value to duty for R-Car PWM if we input the following commands: # cd /sys/class/pwm// # echo 0 > export # cd pwm0 # echo 30 > period # echo 30 > duty_cycle # echo 0 > duty_cycle # cat

[PATCH 0/3] Add R8A77980/Condor PFC support

2018-03-09 Thread Sergei Shtylyov
Hello! Here's the set of 3 patches against Simon Horman's 'renesas.git' repo's 'renesas-devel-20180308-v4.16-rc4' tag. We're adding the R8A77980 PFC node and then describing the pins for SCIF0 and EtherAVB devices declared earlier. These patches depend on the R8A77980 PFC support in order to

Re: [PATCH v2 2/2] pinctrl: sh-pfc: add R8A77980 PFC support

2018-03-09 Thread Geert Uytterhoeven
Hi Sergei, On Thu, Mar 8, 2018 at 8:14 PM, Sergei Shtylyov wrote: > Add the PFC support for the R8A77980 SoC including pin groups for some > on-chip devices such as AVB, CAN-FD, GETHER, [H]SCIF, I2C, INTC-EX, MMC, > MSIOF, PWM, and VIN... > > Based on the

[PATCH] dt-bindings: pwm: renesas,pwm-rcar: add bindings for R-Car M3N support

2018-03-09 Thread Yoshihiro Shimoda
This patch adds bindings for R-Car M3N. No driver update is needed. Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 0/2] pwm: rcar: Add suspend/resume support and cleanup for runtime_pm

2018-03-09 Thread Yoshihiro Shimoda
This patch set improves power management for Renesas PWM driver. Hien Dang (1): pwm: rcar: Use PM Runtime to control module clock Yoshihiro Shimoda (1): pwm: rcar: add suspend/resume support drivers/pwm/pwm-rcar.c | 35 +-- 1 file changed, 29 insertions(+),

[PATCH 1/2] pwm: rcar: Use PM Runtime to control module clock

2018-03-09 Thread Yoshihiro Shimoda
From: Hien Dang Runtime PM API (pm_runtime_get_sync/pm_runtime_put) should be used to control module clock instead of clk_prepare_enable and clk_disable_unprepare. Signed-off-by: Hien Dang Signed-off-by: Yoshihiro Shimoda

[PATCH 2/2] pwm: rcar: add suspend/resume support

2018-03-09 Thread Yoshihiro Shimoda
This patch adds suspend/resume support for Renesas PWM driver. Signed-off-by: Yoshihiro Shimoda --- drivers/pwm/pwm-rcar.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/pwm/pwm-rcar.c b/drivers/pwm/pwm-rcar.c index

[PATCH 3/3] arm64: dts: renesas: condor: add EtherAVB pins

2018-03-09 Thread Sergei Shtylyov
Add the (previously omitted) EtherAVB pin data to the Condor board's device tree. Signed-off-by: Sergei Shtylyov --- arch/arm64/boot/dts/renesas/r8a77980-condor.dts |8 1 file changed, 8 insertions(+) Index:

[PATCH 1/3] arm64: dts: renesas: r8a77980: add PFC support

2018-03-09 Thread Sergei Shtylyov
Define the generic R8A77980 part of the PFC device node. Signed-off-by: Sergei Shtylyov --- arch/arm64/boot/dts/renesas/r8a77980.dtsi |5 + 1 file changed, 5 insertions(+) Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi

[PATCH 2/3] arm64: dts: renesas: condor: add SCIF0 pins

2018-03-09 Thread Sergei Shtylyov
Add the (previously omitted) SCIF0 pin data to the Condor board's device tree. Signed-off-by: Sergei Shtylyov --- arch/arm64/boot/dts/renesas/r8a77980-condor.dts | 15 +++ 1 file changed, 15 insertions(+) Index:

Re: [PATCH 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder

2018-03-09 Thread Andrzej Hajda
On 08.03.2018 16:24, Jacopo Mondi wrote: > Document Thine THC63LVD1024 LVDS decoder. > > Signed-off-by: Jacopo Mondi > --- > .../bindings/display/bridge/thine,thc63lvd1024.txt | 59 > ++ > 1 file changed, 59 insertions(+) > create mode 100644 >

Re: [PATCH 3/3] arm64: dts: renesas: Add LVDS decoder to R-Car V3M Eagle

2018-03-09 Thread Sergei Shtylyov
Hello! On 3/8/2018 6:24 PM, Jacopo Mondi wrote: The R-Car V3M Eagle board includes a transparent LVDS decoder, connected to the on-chip LVDS encoder output on one side and to HDMI encoder ADV7511w on the other one. As the decoder does not need any configuration it has been so-far omitted from

Re: [PATCH] dt-bindings: media: rcar_vin: Use status "okay"

2018-03-09 Thread Niklas Söderlund
Hi Geert, Thanks for your patch. On 2018-03-09 10:34:40 +0100, Geert Uytterhoeven wrote: > According to the Devicetree Specification, "ok" is not a valid status. > > Fixes: 47c71bd61b772cd7 ("[media] rcar_vin: add devicetree support") > Signed-off-by: Geert Uytterhoeven

Re: [PATCH 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder

2018-03-09 Thread jacopo mondi
Hi Geert, On Fri, Mar 09, 2018 at 10:22:39AM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Fri, Mar 9, 2018 at 10:04 AM, jacopo mondi wrote: > > On Fri, Mar 09, 2018 at 09:10:55AM +0100, Geert Uytterhoeven wrote: > >> On Thu, Mar 8, 2018 at 4:24 PM, Jacopo Mondi

Re: [PATCH 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder

2018-03-09 Thread jacopo mondi
Hi Andrzej, On Fri, Mar 09, 2018 at 09:01:24AM +0100, Andrzej Hajda wrote: > On 08.03.2018 16:24, Jacopo Mondi wrote: > > Document Thine THC63LVD1024 LVDS decoder. > > > > Signed-off-by: Jacopo Mondi > > --- > > .../bindings/display/bridge/thine,thc63lvd1024.txt | 59

Re: [PATCH 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder

2018-03-09 Thread jacopo mondi
Hi Geert, thanks for review On Fri, Mar 09, 2018 at 09:10:55AM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Thu, Mar 8, 2018 at 4:24 PM, Jacopo Mondi > wrote: > > Document Thine THC63LVD1024 LVDS decoder. > > > > Signed-off-by: Jacopo Mondi

Re: [PATCH 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder

2018-03-09 Thread Geert Uytterhoeven
Hi Jacopo, On Thu, Mar 8, 2018 at 4:24 PM, Jacopo Mondi wrote: > Document Thine THC63LVD1024 LVDS decoder. > > Signed-off-by: Jacopo Mondi Thanks for your patch! > --- /dev/null > +++

Re: [PATCH 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder

2018-03-09 Thread Geert Uytterhoeven
Hi Jacopo, On Fri, Mar 9, 2018 at 10:04 AM, jacopo mondi wrote: > On Fri, Mar 09, 2018 at 09:10:55AM +0100, Geert Uytterhoeven wrote: >> On Thu, Mar 8, 2018 at 4:24 PM, Jacopo Mondi >> wrote: >> > Document Thine THC63LVD1024 LVDS decoder. >> > >> >

[PATCH] dt-bindings: media: rcar_vin: Use status "okay"

2018-03-09 Thread Geert Uytterhoeven
According to the Devicetree Specification, "ok" is not a valid status. Fixes: 47c71bd61b772cd7 ("[media] rcar_vin: add devicetree support") Signed-off-by: Geert Uytterhoeven --- For the checkpatch TODO list? https://www.devicetree.org/

Re: [PATCH v12 11/33] rcar-vin: set a default field to fallback on

2018-03-09 Thread Niklas Söderlund
Hi Hans, Thanks for your feedback. On 2018-03-09 17:28:39 +0100, Hans Verkuil wrote: > On 09/03/18 17:17, Niklas Söderlund wrote: > > Hi Hans, > > > > Thanks for your feedback, I don't think I can appreciate how happy I'm > > that you reviewed this patch-set, Thank you! > > You're welcome! >

Re: [PATCH v12 11/33] rcar-vin: set a default field to fallback on

2018-03-09 Thread Hans Verkuil
On 09/03/18 18:07, Niklas Söderlund wrote: > Hi Hans, > > Thanks for your feedback. > > On 2018-03-09 17:28:39 +0100, Hans Verkuil wrote: >> On 09/03/18 17:17, Niklas Söderlund wrote: >>> Hi Hans, >>> >>> Thanks for your feedback, I don't think I can appreciate how happy I'm >>> that you

Re: [PATCH 1/4] pinctrl: sh-pfc: r8a7796: Add VIN4, VIN5 pins, groups and functions

2018-03-09 Thread Geert Uytterhoeven
Hi Uli, On Mon, Feb 26, 2018 at 11:18 AM, Geert Uytterhoeven wrote: > On Mon, Feb 26, 2018 at 10:21 AM, Geert Uytterhoeven > wrote: >> On Mon, Feb 26, 2018 at 10:02 AM, Ulrich Hecht >> wrote: >>> On Tue, Feb 20, 2018

Re: [PATCH 3/3] arm64: dts: renesas: condor: add EtherAVB pins

2018-03-09 Thread Geert Uytterhoeven
Hi Sergei, On Fri, Mar 9, 2018 at 1:09 PM, Sergei Shtylyov wrote: > Add the (previously omitted) EtherAVB pin data to the Condor board's > device tree. > > Signed-off-by: Sergei Shtylyov According to the Condor schematics,

Re: [PATCH 1/3] arm64: dts: renesas: r8a77980: add PFC support

2018-03-09 Thread Geert Uytterhoeven
On Fri, Mar 9, 2018 at 1:06 PM, Sergei Shtylyov wrote: > Define the generic R8A77980 part of the PFC device node. > > Signed-off-by: Sergei Shtylyov > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi > +++

Re: [PATCH] dt-bindings: pwm: renesas,pwm-rcar: add bindings for R-Car M3N support

2018-03-09 Thread Geert Uytterhoeven
On Fri, Mar 9, 2018 at 12:53 PM, Yoshihiro Shimoda wrote: > This patch adds bindings for R-Car M3N. No driver update is needed. > > Signed-off-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven

Re: [PATCH 2/2] pwm: rcar: add suspend/resume support

2018-03-09 Thread Geert Uytterhoeven
Hi Shimoda-san, On Fri, Mar 9, 2018 at 12:54 PM, Yoshihiro Shimoda wrote: > This patch adds suspend/resume support for Renesas PWM driver. > > Signed-off-by: Yoshihiro Shimoda Thanks for your patch! > ---

Re: [PATCH 1/2] pwm: rcar: Use PM Runtime to control module clock

2018-03-09 Thread Geert Uytterhoeven
On Fri, Mar 9, 2018 at 12:54 PM, Yoshihiro Shimoda wrote: > From: Hien Dang > > Runtime PM API (pm_runtime_get_sync/pm_runtime_put) should be used > to control module clock instead of clk_prepare_enable and > clk_disable_unprepare. > >

[PATCH v2 1/3] dt-bindings: display: bridge: Document LVDS to parallel decoder

2018-03-09 Thread Jacopo Mondi
Document transparent LVDS to CMOS/TTL decoder that do not require any configuration. Signed-off-by: Jacopo Mondi --- .../bindings/display/bridge/lvds-decoder.txt | 42 ++ 1 file changed, 42 insertions(+) create mode 100644

Re: [PATCH 2/3] arm64: dts: renesas: condor: add SCIF0 pins

2018-03-09 Thread Geert Uytterhoeven
Hi Sergei, On Fri, Mar 9, 2018 at 1:07 PM, Sergei Shtylyov wrote: > Add the (previously omitted) SCIF0 pin data to the Condor board's > device tree. > > Signed-off-by: Sergei Shtylyov Reviewed-by: Geert Uytterhoeven

Re: [GIT PULL FOR renesas-drivers] VSP1 dynamic BRU/BRS allocation

2018-03-09 Thread Geert Uytterhoeven
Hi Laurent, On Wed, Mar 7, 2018 at 8:45 PM, Laurent Pinchart wrote: > The following changes since commit 15ea2df9143729a2b722d4ca2b52cfa14a819d8e: > > media: ov2685: mark PM functions as __maybe_unused (2018-02-26 10:38:56 > -0500) > > are available in the

[PATCH v2 2/3] drm: bridge: Add LVDS decoder driver

2018-03-09 Thread Jacopo Mondi
Add transparent LVDS decoder driver. A transparent LVDS decoder is a DRM bridge device that does not require any configuration and converts LVDS input to digital CMOS/TTL parallel data output. Signed-off-by: Jacopo Mondi --- drivers/gpu/drm/bridge/Kconfig|

[PATCH v2 0/3] drm: Add LVDS decoder bridge

2018-03-09 Thread Jacopo Mondi
Hello, after some discussion on the proposed bindings for generic lvds decoder and Thine THC63LVD1024, I decided to drop the THC63 specific part and just live with a transparent decoder that does not support any configuration from DT. Dropping THC63 support to avoid discussion on how to better

[PATCH v2 3/3] arm64: dts: renesas: Add LVDS decoder to R-Car V3M Eagle

2018-03-09 Thread Jacopo Mondi
The R-Car V3M Eagle board includes a transparent LVDS decoder, connected to the on-chip LVDS encoder output on one side and to HDMI encoder ADV7511w on the other one. As the decoder does not need any configuration it has been so-far omitted from DTS. Now that a driver for transparent LVDS decoder

Re: [PATCH v12 11/33] rcar-vin: set a default field to fallback on

2018-03-09 Thread Hans Verkuil
On 07/03/18 23:04, Niklas Söderlund wrote: > If the field is not supported by the driver it should not try to keep > the current field. Instead it should set it to a default fallback. Since > trying a format should always result in the same state regardless of the > current state of the device. >

Re: [PATCH v12 13/33] rcar-vin: update bytesperline and sizeimage calculation

2018-03-09 Thread Hans Verkuil
On 07/03/18 23:04, Niklas Söderlund wrote: > Remove over complicated logic to calculate the value for bytesperline > and sizeimage that was carried over from the soc_camera port. There is > no need to find the max value of bytesperline and sizeimage from > user-space as they are set to 0 before

Re: [PATCH v12 15/33] rcar-vin: break out format alignment and checking

2018-03-09 Thread Hans Verkuil
On 07/03/18 23:04, Niklas Söderlund wrote: > Part of the format alignment and checking can be shared with the Gen3 > format handling. Break that part out to a separate function. > > Signed-off-by: Niklas Söderlund Reviewed-by: Hans Verkuil

Re: [PATCH v12 23/33] rcar-vin: force default colorspace for media centric mode

2018-03-09 Thread Hans Verkuil
On 07/03/18 23:05, Niklas Söderlund wrote: > The V4L2 specification clearly documents the colorspace fields as being > set by drivers for capture devices. Using the values supplied by > userspace thus wouldn't comply with the API. Until the API is updated to > allow for userspace to set these Hans

Re: [PATCH v12 32/33] rcar-vin: enable support for r8a7796

2018-03-09 Thread Hans Verkuil
On 07/03/18 23:05, Niklas Söderlund wrote: > Add the SoC specific information for Renesas r8a7796. > > Signed-off-by: Niklas Söderlund > Reviewed-by: Laurent Pinchart Reviewed-by: Hans Verkuil

Re: [PATCH v12 31/33] rcar-vin: enable support for r8a7795

2018-03-09 Thread Hans Verkuil
On 07/03/18 23:05, Niklas Söderlund wrote: > Add the SoC specific information for Renesas r8a7795 ES1.x and ES2.0. > > Signed-off-by: Niklas Söderlund > Reviewed-by: Laurent Pinchart Reviewed-by: Hans Verkuil

Re: [PATCH v2 3/3] arm64: dts: renesas: Add LVDS decoder to R-Car V3M Eagle

2018-03-09 Thread Simon Horman
On Fri, Mar 09, 2018 at 02:51:40PM +0100, Jacopo Mondi wrote: > The R-Car V3M Eagle board includes a transparent LVDS decoder, connected > to the on-chip LVDS encoder output on one side and to HDMI encoder > ADV7511w on the other one. > > As the decoder does not need any configuration it has been

Re: [PATCH v12 06/33] rcar-vin: move subdevice handling to async callbacks

2018-03-09 Thread Hans Verkuil
On 07/03/18 23:04, Niklas Söderlund wrote: > In preparation for Gen3 support move the subdevice initialization and > clean up from rvin_v4l2_{register,unregister}() directly to the async > callbacks. This simplifies the addition of Gen3 support as the > rvin_v4l2_register() can be shared for both

Re: [PATCH v12 14/33] rcar-vin: align pixelformat check

2018-03-09 Thread Hans Verkuil
On 07/03/18 23:04, Niklas Söderlund wrote: > If the pixelformat is not supported it should not fail but be set to > something that works. While we are at it move the two different > checks of the pixelformat to the same statement. > > Signed-off-by: Niklas Söderlund

Re: [PATCH v12 17/33] rcar-vin: cache video standard

2018-03-09 Thread Hans Verkuil
On 07/03/18 23:04, Niklas Söderlund wrote: > At stream on time the driver should not query the subdevice for which > standard are used. Instead it should be cached when userspace sets the > standard and used at stream on time. > > Signed-off-by: Niklas Söderlund

Re: [PATCH v12 25/33] rcar-vin: add group allocator functions

2018-03-09 Thread Hans Verkuil
On 07/03/18 23:05, Niklas Söderlund wrote: > In media controller mode all VIN instances needs to be part of the same > media graph. There is also a need for each VIN instance to know about > and in some cases be able to communicate with other VIN instances. > > Add an allocator framework where

Re: [PATCH] dt-bindings: pwm: renesas,pwm-rcar: add bindings for R-Car M3N support

2018-03-09 Thread Simon Horman
On Fri, Mar 09, 2018 at 08:53:17PM +0900, Yoshihiro Shimoda wrote: > This patch adds bindings for R-Car M3N. No driver update is needed. > > Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman

Re: [PATCH v12 12/33] rcar-vin: fix handling of single field frames (top, bottom and alternate fields)

2018-03-09 Thread Hans Verkuil
On 07/03/18 23:04, Niklas Söderlund wrote: > There was never proper support in the VIN driver to deliver ALTERNATING > field format to user-space, remove this field option. The problem is > that ALTERNATING field order requires the sequence numbers of buffers > returned to userspace to reflect if

Re: [PATCH v12 16/33] rcar-vin: simplify how formats are set and reset

2018-03-09 Thread Hans Verkuil
On 07/03/18 23:04, Niklas Söderlund wrote: > With the recent cleanup of the format code to prepare for Gen3 it's > possible to simplify the Gen2 format code path as well. Clean up the > process by defining two functions to handle the set format and reset of > format when the standard is changed. >

Re: [PATCH v12 20/33] rcar-vin: add function to manipulate Gen3 chsel value

2018-03-09 Thread Hans Verkuil
On 07/03/18 23:04, Niklas Söderlund wrote: > On Gen3 the CSI-2 routing is controlled by the VnCSI_IFMD register. One > feature of this register is that it's only present in the VIN0 and VIN4 > instances. The register in VIN0 controls the routing for VIN0-3 and the > register in VIN4 controls

Re: [PATCH v12 27/33] rcar-vin: add chsel information to rvin_info

2018-03-09 Thread Hans Verkuil
On 07/03/18 23:05, Niklas Söderlund wrote: > Each Gen3 SoC has a limited set of predefined routing possibilities for > which CSI-2 device and channel can be routed to which VIN instance. > Prepare to store this information in the struct rvin_info. > > Signed-off-by: Niklas Söderlund

Re: [PATCH v12 26/33] rcar-vin: change name of video device

2018-03-09 Thread Hans Verkuil
On 07/03/18 23:05, Niklas Söderlund wrote: > The rcar-vin driver needs to be part of a media controller to support > Gen3. Give each VIN instance a unique name so it can be referenced from > userspace. > > Signed-off-by: Niklas Söderlund > Reviewed-by:

Re: [PATCH v12 29/33] rcar-vin: add link notify for Gen3

2018-03-09 Thread Hans Verkuil
On 07/03/18 23:05, Niklas Söderlund wrote: > Add the ability to process media device link change requests. Link > enabling is a bit complicated on Gen3, whether or not it's possible to > enable a link depends on what other links already are enabled. On Gen3 > the 8 VINs are split into two

Re: [PATCH v12 30/33] rcar-vin: extend {start,stop}_streaming to work with media controller

2018-03-09 Thread Hans Verkuil
On 07/03/18 23:05, Niklas Söderlund wrote: > The procedure to start or stop streaming using the non-MC single > subdevice and the MC graph and multiple subdevices are quite different. > Create a new function to abstract which method is used based on which > mode the driver is running in and add

Re: [PATCH v12 33/33] rcar-vin: enable support for r8a77970

2018-03-09 Thread Hans Verkuil
On 07/03/18 23:05, Niklas Söderlund wrote: > Add the SoC specific information for Renesas r8a77970. > > Signed-off-by: Niklas Söderlund > Reviewed-by: Laurent Pinchart Reviewed-by: Hans Verkuil

Re: [PATCH 3/3] arm64: dts: renesas: condor: add EtherAVB pins

2018-03-09 Thread Sergei Shtylyov
Hello! On 03/09/2018 03:44 PM, Geert Uytterhoeven wrote: >> Add the (previously omitted) EtherAVB pin data to the Condor board's >> device tree. >> >> Signed-off-by: Sergei Shtylyov > > According to the Condor schematics, the KSZ9031RNXVB is wired to >

Re: [PATCH v2 3/3] arm64: dts: renesas: Add LVDS decoder to R-Car V3M Eagle

2018-03-09 Thread Sergei Shtylyov
On 03/09/2018 04:51 PM, Jacopo Mondi wrote: > The R-Car V3M Eagle board includes a transparent LVDS decoder, connected > to the on-chip LVDS encoder output on one side and to HDMI encoder > ADV7511w on the other one. > > As the decoder does not need any configuration it has been so-far > omitted

Re: [PATCH v12 11/33] rcar-vin: set a default field to fallback on

2018-03-09 Thread Niklas Söderlund
Hi Hans, Thanks for your feedback, I don't think I can appreciate how happy I'm that you reviewed this patch-set, Thank you! On 2018-03-09 16:25:23 +0100, Hans Verkuil wrote: > On 07/03/18 23:04, Niklas Söderlund wrote: > > If the field is not supported by the driver it should not try to keep >

Re: [PATCH v12 11/33] rcar-vin: set a default field to fallback on

2018-03-09 Thread Hans Verkuil
On 09/03/18 17:17, Niklas Söderlund wrote: > Hi Hans, > > Thanks for your feedback, I don't think I can appreciate how happy I'm > that you reviewed this patch-set, Thank you! You're welcome! > > On 2018-03-09 16:25:23 +0100, Hans Verkuil wrote: >> On 07/03/18 23:04, Niklas Söderlund wrote: