Hi Laurent,
On 16/11/17 01:33, Laurent Pinchart wrote:
> Device unplug being asynchronous, it naturally races with operations
> performed by userspace through ioctls or other file operations on video
> device nodes.
>
> This leads to potential access to freed memory or to other resources
> during
iklas Söderlund
Reviewed-by: Hans Verkuil
Regards,
Hans
> ---
> drivers/media/platform/rcar-vin/rcar-vin.h | 25 +
> 1 file changed, 25 insertions(+)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-vin.h
> b/drivers/media/pla
d the best routing configuration to try and accommodate
> as many links as possible. When it's not possible to enable a new link
> due to hardware constrains the link_notifier callback will return
> -EMLINK.
>
> Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
Re
e it's safe to switch the master off and
> the new routing will still be in effect.
>
> Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
Regards,
Hans
> ---
> drivers/media/platform/rcar-vin/rcar-dma.c | 25 +
> drivers/media/plat
g in and add logic to start the MC graph.
>
> Signed-off-by: Niklas Söderlund
One tiny typo in a comment, see below. After fixing that you can add my:
Reviewed-by: Hans Verkuil
Regards,
Hans
> ---
> drivers/media/platform/rcar-vin/rcar-dma.c | 113
>
On 11/11/17 01:38, Niklas Söderlund wrote:
> The driver registers the video device from the async complete callback
> and unregistered in the async unbind callback. This creates problems if
> if the subdevice is bound, unbound and later rebound. The second time
"unbound and later rebound": that's
iver is based on a prototype by Koji Matsuoka in the Renesas BSP.
>
> Signed-off-by: Niklas Söderlund
I found one small typo (see below). After fixing that you can add my:
Reviewed-by: Hans Verkuil
I would like to see another Ack before merging this (Sakari?).
Regards,
Hans
Hi Niklas,
On 11/16/2017 01:27 AM, Laurent Pinchart wrote:
> Hi Niklas,
>
> On Thursday, 16 November 2017 01:34:33 EET Niklas Söderlund wrote:
>> On 2017-11-16 00:49:07 +0200, Laurent Pinchart wrote:
>>> The rvin_dev data structure contains driver private data for an instance
>>> of the VIN. It i
On 11/29/2017 08:43 PM, Niklas Söderlund wrote:
> The functions to initialize and cleanup the hardware and video device
> where poorly named from the start. Rename them to better describe there
> intended function.
>
> Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkui
hecking that the video device is registered.
>
> Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
Regards,
Hans
> ---
> drivers/media/platform/rcar-vin/rcar-core.c | 2 ++
> drivers/media/platform/rcar-vin/rcar-v4l2.c | 3 +++
> 2 files changed, 5 insertion
e shared for both Gen2 and Gen3 while direct
> subdevice control are only used on Gen2.
>
> While moving this code drop a large comment which is copied from the
> framework documentation and fold rvin_mbus_supported() into its only
> caller.
>
> Signed-off-by: Niklas Söde
On 11/29/2017 08:43 PM, Niklas Söderlund wrote:
> Add the SoC specific information for Renesas r8a77970.
>
> Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
Regards,
Hans
> ---
> .../devicetree/bindings/media/rcar_vin.txt | 1 +
> drivers/media
llback of this notifier is called it register all
register -> registers
> video devices and creates the media controller links between all
> entities.
>
> Signed-off-by: Niklas Söderlund
With that small change and the fix for the issue you found in rvin_group_init():
Reviewed-by: H
On 12/04/2017 02:34 PM, Niklas Söderlund wrote:
> Hi Hans,
>
> On 2017-12-04 10:05:35 +0100, Hans Verkuil wrote:
>> Hi Niklas,
>>
>> On 11/16/2017 01:27 AM, Laurent Pinchart wrote:
>>> Hi Niklas,
>>>
>>> On Thursday, 16 November 2017 01:34:3
itialized video device node name by adding a
>> check in rvin_v4l2_unregister() to identify that the video device is
>> registered.
>>
>> Signed-off-by: Niklas Söderlund
>> Reviewed-by: Kieran Bingham
>> Reviewed-by: Hans Verkuil
>> ---
>> drivers/media/platform
Hi Laurent,
>> +static const struct v4l2_ioctl_ops rvin_mc_ioctl_ops = {
>> +.vidioc_querycap= rvin_querycap,
>> +.vidioc_try_fmt_vid_cap = rvin_mc_try_fmt_vid_cap,
>> +.vidioc_g_fmt_vid_cap = rvin_g_fmt_vid_cap,
>> +.vidioc_s_fmt_vid_cap
On 15/11/17 11:55, Jacopo Mondi wrote:
> Add driver for Renesas Capture Engine Unit (CEU).
>
> The CEU interface supports capturing 'data' (YUV422) and 'images'
> (NV[12|21|16|61]).
>
> This driver aims to replace the soc_camera based sh_mobile_ceu one.
>
> Tested with ov7670 camera sensor, prov
On 15/11/17 11:56, Jacopo Mondi wrote:
> Copy the soc_camera based driver in v4l2 sensor driver directory.
> This commit just copies the original file without modifying it.
>
> Signed-off-by: Jacopo Mondi
> ---
> drivers/media/i2c/ov772x.c | 1124
>
>
On 15/11/17 11:56, Jacopo Mondi wrote:
> Remove soc_camera framework dependencies from tw9910 sensor driver.
> - Handle clock directly
> - Register async subdevice
> - Add platform specific enable/disable functions
> - Adjust build system
>
> This commit does not remove the original soc_camera bas
Niklas,
Did you look at this? If I should take it, can you Ack it? If you are
going to squash or add it to our of your own patch series, then let me
know and I can remove it from my todo queue.
Regards,
Hans
On 05/12/17 21:41, Jacopo Mondi wrote:
> When rcar-csi interface is not connect
On 01/08/2018 04:32 PM, Niklas Söderlund wrote:
> Hi,
>
> Thanks for your patch.
>
> On 2018-01-08 17:13:53 +0200, Sakari Ailus wrote:
>> Hi Kieran,
>>
>> On Mon, Jan 08, 2018 at 02:45:49PM +, Kieran Bingham wrote:
>>> The v4l2_mbus_fmt width and height corresponds directly with the
>>> v4l2_
On 01/08/2018 05:11 PM, Niklas Söderlund wrote:
> On 2018-01-08 16:48:35 +0100, Hans Verkuil wrote:
>> On 01/08/2018 04:32 PM, Niklas Söderlund wrote:
>>> Hi,
>>>
>>> Thanks for your patch.
>>>
>>> On 2018-01-08 17:13:53 +0200, Sakari Ailus wr
iver")
> Reviewed-by: Niklas Söderlund
> Signed-off-by: Kieran Bingham
Reviewed-by: Hans Verkuil
Regards,
Hans
> ---
> v2:
> - switch conditional to check the fmt->field, removing the need for
>the comment.
>
> drivers/media/i2c/adv748x/adv748x-hdmi.
as is provided for the v4l2_pix_format
> which is explicit on the matter, and by matching the terminology of
> 'image height' rather than the misleading 'frame height'.
>
> Signed-off-by: Kieran Bingham
Reviewed-by: Hans Verkuil
Regards,
Hans
Hi Jacopo,
Sorry for the late review, but here is finally is.
BTW, can you provide the v4l2-compliance output (ideally with the -f option)
in the cover letter for v6?
On 01/12/2018 03:04 PM, Jacopo Mondi wrote:
> Add driver for Renesas Capture Engine Unit (CEU).
>
> The CEU interface supports c
next commit.
>
> Signed-off-by: Jacopo Mondi
> Acked-by: Laurent Pinchart
Acked-by: Hans Verkuil
Regards,
Hans
next commit.
>
> Signed-off-by: Jacopo Mondi
> Acked-by: Laurent Pinchart
Acked-by: Hans Verkuil
Regards,
Hans
On 01/12/2018 03:04 PM, Jacopo Mondi wrote:
> Add renesas-ceu header file.
>
> Do not remove the existing sh_mobile_ceu.h one as long as the original
> driver does not go away.
>
> Signed-off-by: Jacopo Mondi
> Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
R
On 01/12/2018 03:04 PM, Jacopo Mondi wrote:
> Add bindings documentation for Renesas Capture Engine Unit (CEU).
>
> Signed-off-by: Jacopo Mondi
> Reviewed-by: Rob Herring
> Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
Regards,
Hans
> ---
> .../devi
On 01/12/2018 03:04 PM, Jacopo Mondi wrote:
> Add Capture Engine Unit (CEU) node to device tree.
>
> Signed-off-by: Jacopo Mondi
> Reviewed-by: Geert Uytterhoeven
> Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
Regards,
Hans
> ---
> arch/arm/boot/d
On 01/12/2018 03:04 PM, Jacopo Mondi wrote:
> Remove soc_camera framework dependencies from ov772x sensor driver.
> - Handle clock and gpios
> - Register async subdevice
> - Remove soc_camera specific g/s_mbus_config operations
> - Change image format colorspace from JPEG to SRGB as the two use the
gt; - Adjust build system
>
> This commit does not remove the original soc_camera based driver as long
> as other platforms depends on soc_camera-based CEU driver.
>
> Signed-off-by: Jacopo Mondi
> Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
Regards,
Hans
membocks APIs,
> and need to be declared as dma_coherent during machine initialization to
> remove that architecture specific part from CEU driver.
>
> Signed-off-by: Jacopo Mondi
> Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
Regards,
Hans
gt;
> This commit does not remove the original soc_camera based driver as long
> as other platforms depends on soc_camera-based CEU driver.
>
> Signed-off-by: Jacopo Mondi
> Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
Regards,
Hans
On 01/19/18 11:24, Hans Verkuil wrote:
> On 01/16/18 22:44, Jacopo Mondi wrote:
>> Remove soc_camera framework dependencies from ov772x sensor driver.
>> - Handle clock and gpios
>> - Register async subdevice
>> - Remove soc_camera specific g/s_mbus_config operatio
Some more comments:
On 01/16/18 22:44, Jacopo Mondi wrote:
> Add driver for Renesas Capture Engine Unit (CEU).
>
> The CEU interface supports capturing 'data' (YUV422) and 'images'
> (NV[12|21|16|61]).
>
> This driver aims to replace the soc_camera-based sh_mobile_ceu one.
>
> Tested with ov767
Hi Jacopo,
On 01/16/18 22:44, Jacopo Mondi wrote:
> Hello,
>new version of CEU after Hans' review.
>
> Added his Acked-by to most patches and closed review comments.
> Running v4l2-compliance, I noticed a new failure introduced by the way I now
> calculate the plane sizes in set/try_fmt.
>
>
On 01/19/18 12:19, Sakari Ailus wrote:
> Hi Hans,
>
> On Fri, Jan 19, 2018 at 11:47:33AM +0100, Hans Verkuil wrote:
>> On 01/19/18 11:24, Hans Verkuil wrote:
>>> On 01/16/18 22:44, Jacopo Mondi wrote:
>>>> Remove soc_camera framework dependencies from ov772x se
On 01/19/18 13:20, Laurent Pinchart wrote:
> Hi Hans,
>
> On Friday, 19 January 2018 13:20:19 EET Hans Verkuil wrote:
>> On 01/16/18 22:44, Jacopo Mondi wrote:
>>> Add driver for Renesas Capture Engine Unit (CEU).
>>>
>>> The CEU interface supports capt
On 21/01/18 10:31, jacopo mondi wrote:
> Hello Hans, Laurent, Sakari,
>
> On Fri, Jan 19, 2018 at 02:23:21PM +0200, Laurent Pinchart wrote:
>> Hello,
>>
>> On Friday, 19 January 2018 13:19:18 EET Sakari Ailus wrote:
>>> On Fri, Jan 19, 2018 at 11:47:33AM +010
On 21/01/18 10:53, jacopo mondi wrote:
> Hi Hans,
>
> On Fri, Jan 19, 2018 at 12:20:19PM +0100, Hans Verkuil wrote:
>> static int ov7670_g_parm(struct v4l2_subdev *sd, struct v4l2_streamparm
>> *parms)
>> {
>> struct v4l2_captureparm *cp = &p
On 21/01/18 11:21, Hans Verkuil wrote:
> On 21/01/18 10:53, jacopo mondi wrote:
>> Hi Hans,
>>
>> On Fri, Jan 19, 2018 at 12:20:19PM +0100, Hans Verkuil wrote:
>>> static int ov7670_g_parm(struct v4l2_subdev *sd, struct v4l2_streamparm
>>> *parms)
>&g
On 22/01/18 01:52, Laurent Pinchart wrote:
> Hi Hans,
>
> On Friday, 19 January 2018 14:25:39 EET Hans Verkuil wrote:
>> On 01/19/18 13:20, Laurent Pinchart wrote:
>>> On Friday, 19 January 2018 13:20:19 EET Hans Verkuil wrote:
>>>> On 01/16/18 22:44, Jaco
On 21/01/18 18:29, jacopo mondi wrote:
> Hi Hans,
>
> On Sun, Jan 21, 2018 at 11:23:12AM +0100, Hans Verkuil wrote:
>> On 21/01/18 11:21, Hans Verkuil wrote:
>>> On 21/01/18 10:53, jacopo mondi wrote:
>>>> Hi Hans,
>>>>
>>>>
On 21/01/18 18:49, jacopo mondi wrote:
> Hi Hans,
>
> On Fri, Jan 19, 2018 at 12:26:09PM +0100, Hans Verkuil wrote:
>> Hi Jacopo,
>>
>> On 01/16/18 22:44, Jacopo Mondi wrote:
>>> Hello,
>>>new version of CEU after Hans' review.
>>&g
hat they DO support, or they will return -EINVAL. If memory serves
the spec requires the first option, so anything unknown will just be replaced.
And anyway, this raises the question of why you do this for the colorspace
but not for all the other enums in the V4L2 API.
It all seems rather pointle
On 15/02/18 12:08, Laurent Pinchart wrote:
> Hi Hans,
>
> On Thursday, 15 February 2018 12:57:44 EET Hans Verkuil wrote:
>> On 14/02/18 16:16, Laurent Pinchart wrote:
>>> On Wednesday, 14 February 2018 12:36:43 EET Niklas Söderlund wrote:
>>>> There is no way
On 15/02/18 13:06, Laurent Pinchart wrote:
> Hi Hans,
>
> On Thursday, 15 February 2018 13:56:44 EET Hans Verkuil wrote:
>> On 15/02/18 12:08, Laurent Pinchart wrote:
>>> On Thursday, 15 February 2018 12:57:44 EET Hans Verkuil wrote:
>>>> On 14/02/18 16:
On 15/02/18 13:32, Hans Verkuil wrote:
> On 15/02/18 13:06, Laurent Pinchart wrote:
>> Hi Hans,
>>
>> On Thursday, 15 February 2018 13:56:44 EET Hans Verkuil wrote:
>>> On 15/02/18 12:08, Laurent Pinchart wrote:
>>>> On Thursday, 15 February 2018 12:57:44
Hi Niklas,
On 02/19/2018 11:28 PM, Niklas Söderlund wrote:
> Hi Hans,
>
> Thanks for your feedback.
>
> [snip]
>
>> Can you then fix v4l2-compliance to stop testing colorspace
>> against 0xff
>> ?
>
> For now I can simply relax this test for subdevs with sources and sinks.
On 02/19/18 17:59, Jacopo Mondi wrote:
> Add driver for Renesas Capture Engine Unit (CEU).
>
> The CEU interface supports capturing 'data' (YUV422) and 'images'
> (NV[12|21|16|61]).
>
> This driver aims to replace the soc_camera-based sh_mobile_ceu one.
>
> Tested with ov7670 camera sensor, prov
; +
> + ret = v4l2_async_register_subdev(&priv->subdev);
> + if (ret)
> + goto error_gpio_put;
> +
> + return 0;
> +
> +error_gpio_put:
> + if (priv->pwdn_gpio)
> + gpiod_put(priv->pwdn_gpio);
> +error_clk_put:
&g
v4l2_subdev *sd,
> struct v4l2_subdev_pad_config *cfg,
> struct v4l2_subdev_mbus_code_enum *code)
> @@ -1055,14 +1229,17 @@ static int ov772x_enum_mbus_code(struct v4l2_subdev
> *sd,
> }
>
> static const struct v4l2_subdev_video_ops ov772x_subdev_vid
On 02/21/18 13:29, Laurent Pinchart wrote:
> Hi Hans,
>
> On Wednesday, 21 February 2018 14:03:24 EET Hans Verkuil wrote:
>> On 02/19/18 17:59, Jacopo Mondi wrote:
>>> Add driver for Renesas Capture Engine Unit (CEU).
>>>
>>> The CEU interface supp
-aligned them, since I
> was at there to add enum_frame_interval operation
Ah, sorry. I missed that. Never mind then :-)
Hans
>
>> Anyway, after taking care of the memsets and these four ops you can add
>> my:
>>
>> Acked-by: Hans Verkuil
>
> Thanks
>j
>
On 02/21/2018 04:47 PM, jacopo mondi wrote:
> Hello again,
>
> On Tue, Feb 20, 2018 at 09:58:57AM +0100, jacopo mondi wrote:
>> Hi Laurent,
>>
>> On Mon, Feb 19, 2018 at 09:19:32PM +0200, Laurent Pinchart wrote:
>>> Hi Jacopo,
>>>
>>> Thank you for the patch.
>>>
>>> On Monday, 19 February 2018 18
On 02/21/2018 09:16 PM, Laurent Pinchart wrote:
> Hi Hans,
>
> On Tuesday, 20 February 2018 10:37:22 EET Hans Verkuil wrote:
>> On 02/19/2018 11:28 PM, Niklas Söderlund wrote:
>>> Hi Hans,
>>>
>>> Thanks for your feedback.
>>>
>>>
On 02/21/2018 10:01 PM, Sakari Ailus wrote:
> Hi Laurent and Hans,
>
> On Wed, Feb 21, 2018 at 10:16:25PM +0200, Laurent Pinchart wrote:
>> No, I'm sorry, for MC-based drivers this isn't correct. The media entity
>> that
>> symbolizes the DMA engine indeed has a sink pad, but it's a video node,
On 02/21/18 18:47, Jacopo Mondi wrote:
> Add driver for Renesas Capture Engine Unit (CEU).
>
> The CEU interface supports capturing 'data' (YUV422) and 'images'
> (NV[12|21|16|61]).
>
> This driver aims to replace the soc_camera-based sh_mobile_ceu one.
>
> Tested with ov7670 camera sensor, prov
Hi Ramesh,
A few little nitpicks:
On 02/07/2017 04:02 PM, Ramesh Shanmugasundaram wrote:
> This patch adds driver support for the MAX2175 chip. This is Maxim
> Integrated's RF to Bits tuner front end chip designed for software-defined
> radio solutions. This driver exposes the tuner as a sub-devi
On 02/07/2017 04:02 PM, Ramesh Shanmugasundaram wrote:
> Hi Media, DT maintainers, All,
>
> This patch set contains two drivers
> - Renesas R-Car Digital Radio Interface (DRIF) driver
> - Maxim's MAX2175 RF to Bits tuner driver
>
> These patches were based on top of media-tree repo
> commit: 47
Hi Niklas,
One general remark: in many commit logs you mistype 'subdeivce'. Can you
fix that for the v2?
On 01/31/2017 04:40 PM, Niklas Söderlund wrote:
> Hi,
>
> This series address issues with the R-Car Gen2 VIN driver. The most
> serious issue is the OPS when unbind and rebinding the i2c dri
On 02/13/2017 04:31 PM, Laurent Pinchart wrote:
> Hi Hans,
>
> On Monday 13 Feb 2017 15:19:13 Hans Verkuil wrote:
>> Hi Niklas,
>>
>> One general remark: in many commit logs you mistype 'subdeivce'. Can you
>> fix that for the v2?
>>
>>
On 02/13/2017 06:47 PM, Niklas Söderlund wrote:
> Hi Hans,
>
> Thanks for your feedback.
>
> On 2017-02-13 15:19:13 +0100, Hans Verkuil wrote:
>> Hi Niklas,
>>
>> One general remark: in many commit logs you mistype 'subdeivce'. Can you
>> fix that
Hi Laurent,
Here is my review:
On 28/02/17 16:03, Laurent Pinchart wrote:
V4L2 exposes parameters that influence buffers sizes through the format
ioctls (VIDIOC_G_FMT, VIDIOC_TRY_FMT and VIDIO_S_FMT). Other parameters
S_SELECTION should be mentioned here as well (more about that later).
not
On 02/03/17 16:37, Sakari Ailus wrote:
Hi Laurent,
On Tue, Feb 28, 2017 at 05:03:19PM +0200, Laurent Pinchart wrote:
V4L2 exposes parameters that influence buffers sizes through the format
ioctls (VIDIOC_G_FMT, VIDIOC_TRY_FMT and VIDIO_S_FMT). Other parameters
not part of the format structure m
On 04/03/17 15:37, Sakari Ailus wrote:
Hi Hans (and Laurent).
On Sat, Mar 04, 2017 at 11:53:45AM +0100, Hans Verkuil wrote:
Hi Laurent,
Here is my review:
On 28/02/17 16:03, Laurent Pinchart wrote:
V4L2 exposes parameters that influence buffers sizes through the format
ioctls (VIDIOC_G_FMT
On 05/03/17 15:35, Laurent Pinchart wrote:
Hi Hans,
On Saturday 04 Mar 2017 11:53:45 Hans Verkuil wrote:
On 28/02/17 16:03, Laurent Pinchart wrote:
V4L2 exposes parameters that influence buffers sizes through the format
ioctls (VIDIOC_G_FMT, VIDIOC_TRY_FMT and VIDIO_S_FMT). Other parameters
On 05/03/17 22:36, Laurent Pinchart wrote:
V4L2 exposes parameters that influence buffers sizes through the format
ioctls (VIDIOC_G_FMT, VIDIOC_TRY_FMT, VIDIOC_S_FMT, and possibly
VIDIOC_G_SELECTION and VIDIOC_S_SELECTION). Other parameters not part of
the format structure may also influence buff
On 06/03/17 11:35, Laurent Pinchart wrote:
Hi Hans,
On Monday 06 Mar 2017 11:04:50 Hans Verkuil wrote:
On 05/03/17 22:36, Laurent Pinchart wrote:
V4L2 exposes parameters that influence buffers sizes through the format
ioctls (VIDIOC_G_FMT, VIDIOC_TRY_FMT, VIDIOC_S_FMT, and possibly
the buffer size or
layout, because of the need to synchronize buffers with the formats and
controls. Otherwise there would be no way to interpret the content of a
buffer correctly.
Signed-off-by: Laurent Pinchart
Acked-by: Sakari Ailus
Acked-by: Hans Verkuil
Thanks!
Hans
---
Changes
Hi Sergei,
Sorry for the long wait before I got around to reviewing this, but here
are (finally!) my review comments.
On 03/09/17 21:08, Sergei Shtylyov wrote:
> From: Konstantin Kozhevnikov
>
> The image renderer, or the distortion correction engine, is a drawing
> processor with a simple inst
On 03/16/17 19:59, Sergei Shtylyov wrote:
> Add support for the image renderer light SRAM extended 3 (IMR-LSX3) found
> only in the R-Car V2H (R8A7792) SoC. It differs from IMR-LX4 in that it
> supports only planar video formats but can use the video capture data for
> the textures.
>
> Signed-o
metadata capture capability and format description.
>>
>> Signed-off-by: Laurent Pinchart
>> Tested-by: Guennadi Liakhovetski
>> Acked-by: Sakari Ailus
>> Acked-by: Hans Verkuil
>> ---
>> Documentation/media/uapi/v4l/buffer.rst
On 05/02/17 15:26, Ramesh Shanmugasundaram wrote:
> This patch adds driver support for the MAX2175 chip. This is Maxim
> Integrated's RF to Bits tuner front end chip designed for software-defined
> radio solutions. This driver exposes the tuner as a sub-device instance
> with standard and custom co
Hi Ramesh,
Looks good. I replied to patch 3/7 requesting a small change, but otherwise
I'm OK.
The only thing missing is an Ack from Rob for patch 6/7 (R-car DRIF bindings).
Once I have that + an updated patch 3/7 I can make a pull request for this.
Regards,
Hans
On 05/02/17 15:26, Ra
Hi Niklas,
On 05/24/2017 02:15 AM, Niklas Söderlund wrote:
From: Niklas Söderlund
The driver registers the video device from the async complete callback
and unregistered in the async unbind callback. This creates problems if
if the subdevice is bound, unbound and later rebound. The second time
On 05/29/2017 08:52 AM, Hans Verkuil wrote:
Hi Niklas,
On 05/24/2017 02:15 AM, Niklas Söderlund wrote:
From: Niklas Söderlund
The driver registers the video device from the async complete callback
and unregistered in the async unbind callback. This creates problems if
if the subdevice is
On 05/29/2017 09:49 AM, Niklas Söderlund wrote:
Hi Hans,
Thanks for taking the time to look at this :-)
On 2017-05-29 08:56:31 +0200, Hans Verkuil wrote:
On 05/29/2017 08:52 AM, Hans Verkuil wrote:
Hi Niklas,
On 05/24/2017 02:15 AM, Niklas Söderlund wrote:
From: Niklas Söderlund
The
On 05/19/2017 03:07 PM, Ulrich Hecht wrote:
Hi!
This is a by-the-datasheet implementation of analog and digital video input
on the Gose board.
This revision adds new bindings that distinguish between ADV7180 variants
with three and six input ports. There are numerous variants of this chip,
but
On 05/24/2017 02:07 AM, Niklas Söderlund wrote:
From: Niklas Söderlund
Add a check for v4l2_dev to v4l2_async_notifier_register() as to fail as
early as possible since this will fail later in v4l2_async_test_notify().
Signed-off-by: Niklas Söderlund
Acked-by: Hans Verkuil
Thanks
rom -> from the
+ */
+void v4l2_async_subnotifier_unregister(struct v4l2_async_notifier *notifier);
+
+/**
* v4l2_async_notifier_unregister - unregisters a subdevice asynchronous
notifier
*
* @notifier: pointer to &struct v4l2_async_notifier
Nice work! After fixing the typos you can add my:
Acked-by: Hans Verkuil
I'd like to have another Ack from Sakari or Laurent before merging this, though.
Regards,
Hans
On 05/24/2017 02:09 AM, Niklas Söderlund wrote:
From: Niklas Söderlund
This is a wrapper around the media entity pad_from_fwnode operation.
Signed-off-by: Niklas Söderlund
---
drivers/media/media-entity.c | 39 +++
include/media/media-entity.h | 22 +
On 05/24/2017 02:13 AM, Niklas Söderlund wrote:
From: Niklas Söderlund
A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver
supports the rcar-vin driver on R-Car Gen3 SoCs where separate CSI-2
hardware blocks are connected between the video sources and the video
grabbers (VIN).
Driv
Any progress on this?
There where a bunch of comments, but I haven't seen anything since.
Regards,
Hans
Hi Ramesh,
Can you post a patch on top of this series adding entries for these two
drivers to the MAINTAINERS file?
That's missing in this series.
Thanks!
Hans
On 06/09/2017 05:07 PM, Ramesh Shanmugasundaram wrote:
Hi Mauro, Hans,
This patch set contains two drivers
- Renesas R-Ca
On 06/12/2017 03:26 PM, Ramesh Shanmugasundaram wrote:
This patch adds driver support for the MAX2175 chip. This is Maxim
Integrated's RF to Bits tuner front end chip designed for software-defined
radio solutions. This driver exposes the tuner as a sub-device instance
with standard and custom con
On 06/15/17 10:24, Laurent Pinchart wrote:
> The WPF vertical flip is only supported on Gen3 SoCs on the VSP2-I.
> Don't enable it on other VSP2 instances.
>
> Signed-off-by: Laurent Pinchart
Should this go to older kernels as well? Or is that not needed?
Regards,
Hans
> ---
> driver
subdevice attach and detach */
shuld -> should
Actually, I'd say 'shall' instead of 'should'.
After that trivial change you can add my:
Reviewed-by: Hans Verkuil
Regards,
Hans
On 07/03/18 23:04, Niklas Söderlund wrote:
> If the field is not supported by the driver it should not try to keep
> the current field. Instead it should set it to a default fallback. Since
> trying a format should always result in the same state regardless of the
> current state of the device.
>
o reflect if fields where dropped or not,
where -> were
With that tiny typo fixed you can add my:
Reviewed-by: Hans Verkuil
Regards,
Hans
> something which is not possible with the VIN drivers capture logic.
>
> The VIN driver can still capture from a video source wh
to 0 before the max_t() operation.
>
> Signed-off-by: Niklas Söderlund
> Reviewed-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
Thanks!
Hans
> ---
> drivers/media/platform/rcar-vin/rcar-v4l2.c | 10 ++
> 1 file changed, 2 insertions(+), 8 deletions(-)
&
viewed-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
Regards,
Hans
> ---
> drivers/media/platform/rcar-vin/rcar-v4l2.c | 14 +++---
> 1 file changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c
> b/drivers/media/p
On 07/03/18 23:04, Niklas Söderlund wrote:
> Part of the format alignment and checking can be shared with the Gen3
> format handling. Break that part out to a separate function.
>
> Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
Hans
> ---
> drivers/m
andard is changed.
>
> While at it replace the driver local struct rvin_source_fmt with a
> struct v4l2_rect as all it's used for is keep track of the source
> dimensions.
>
> Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
Regards,
Hans
>
> ---
On 07/03/18 23:04, Niklas Söderlund wrote:
> At stream on time the driver should not query the subdevice for which
> standard are used. Instead it should be cached when userspace sets the
> standard and used at stream on time.
>
> Signed-off-by: Niklas Söderlund
Reviewed-b
to set these Hans wants the fields to be set by the
> driver to fixed values.
>
> Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
Regards,
Hans
> ---
> drivers/media/platform/rcar-vin/rcar-v4l2.c | 21 +++--
> 1 file changed, 19 insertions
e it's safe to switch the master off and
> the new routing will still be in effect.
>
> Signed-off-by: Niklas Söderlund
> Reviewed-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
Regards,
Hans
> ---
> drivers/media/platform/rcar-vin/rcar-dma.c | 38
> +++
framework where the first VIN instance to be probed
> creates a shared data structure and registers a media device.
> Consecutive VINs insert themself into the global group.
>
> Signed-off-by: Niklas Söderlund
> Reviewed-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
Regards,
On 07/03/18 23:05, Niklas Söderlund wrote:
> The rcar-vin driver needs to be part of a media controller to support
> Gen3. Give each VIN instance a unique name so it can be referenced from
> userspace.
>
> Signed-off-by: Niklas Söderlund
> Reviewed-by: Laurent Pinchart
1 - 100 of 274 matches
Mail list logo
