RE: [PATCH] pwm: Avoid deadlock warning when removing PWM device

2019-03-13 Thread Yoshihiro Shimoda
Hi Thierry, > From: Thierry Reding, Sent: Tuesday, March 12, 2019 9:46 PM > On Tue, Mar 12, 2019 at 12:16:34PM +0900, Yoshihiro Shimoda wrote: > > @@ -368,10 +370,12 @@ int pwmchip_remove(struct pwm_chip *chip) > > > > free_pwms(chip); > > > > - pwmchip_sysfs_unexport(chip); > > - > > out:

Re: [PATCH] pwm: Avoid deadlock warning when removing PWM device

2019-03-12 Thread Thierry Reding
On Tue, Mar 12, 2019 at 12:16:34PM +0900, Yoshihiro Shimoda wrote: > From: Phong Hoang > > This patch fixes deadlock warning if removing PWM device > when CONFIG_PROVE_LOCKING is enabled. > > This issue can be reproceduced by the following steps on > the R-Car H3 Salvator-X board if the backligh

Re: [PATCH] pwm: Avoid deadlock warning when removing PWM device

2019-03-12 Thread Geert Uytterhoeven
Hi Thierry, On Tue, Mar 12, 2019 at 12:55 PM Thierry Reding wrote: > On Tue, Mar 12, 2019 at 12:16:34PM +0900, Yoshihiro Shimoda wrote: > > From: Phong Hoang > > > > This patch fixes deadlock warning if removing PWM device > > when CONFIG_PROVE_LOCKING is enabled. > > > > This issue can be repro

Re: [PATCH] pwm: Avoid deadlock warning when removing PWM device

2019-03-12 Thread Thierry Reding
On Tue, Mar 12, 2019 at 12:16:34PM +0900, Yoshihiro Shimoda wrote: > From: Phong Hoang > > This patch fixes deadlock warning if removing PWM device > when CONFIG_PROVE_LOCKING is enabled. > > This issue can be reproceduced by the following steps on > the R-Car H3 Salvator-X board if the backligh

Re: [PATCH] pwm: Avoid deadlock warning when removing PWM device

2019-03-12 Thread Thierry Reding
On Tue, Mar 12, 2019 at 10:54:33AM +0100, Uwe Kleine-König wrote: > On Tue, Mar 12, 2019 at 10:49:59AM +0100, Geert Uytterhoeven wrote: > > Hi Uwe, > > > > On Tue, Mar 12, 2019 at 10:23 AM Uwe Kleine-König > > wrote: > > > On Tue, Mar 12, 2019 at 12:16:34PM +0900, Yoshihiro Shimoda wrote: > > > >

Re: [PATCH] pwm: Avoid deadlock warning when removing PWM device

2019-03-12 Thread Uwe Kleine-König
On Tue, Mar 12, 2019 at 10:49:59AM +0100, Geert Uytterhoeven wrote: > Hi Uwe, > > On Tue, Mar 12, 2019 at 10:23 AM Uwe Kleine-König > wrote: > > On Tue, Mar 12, 2019 at 12:16:34PM +0900, Yoshihiro Shimoda wrote: > > > diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c > > > index 1581f6a..2fdd6

Re: [PATCH] pwm: Avoid deadlock warning when removing PWM device

2019-03-12 Thread Geert Uytterhoeven
Hi Uwe, On Tue, Mar 12, 2019 at 10:23 AM Uwe Kleine-König wrote: > On Tue, Mar 12, 2019 at 12:16:34PM +0900, Yoshihiro Shimoda wrote: > > diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c > > index 1581f6a..2fdd6611 100644 > > --- a/drivers/pwm/core.c > > +++ b/drivers/pwm/core.c > > @@ -368,

Re: [PATCH] pwm: Avoid deadlock warning when removing PWM device

2019-03-12 Thread Uwe Kleine-König
On Tue, Mar 12, 2019 at 12:16:34PM +0900, Yoshihiro Shimoda wrote: > diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c > index 1581f6a..2fdd6611 100644 > --- a/drivers/pwm/core.c > +++ b/drivers/pwm/core.c > @@ -311,10 +311,12 @@ int pwmchip_add_with_polarity(struct pwm_chip *chip, > if (I

Re: [PATCH] pwm: Avoid deadlock warning when removing PWM device

2019-03-12 Thread Geert Uytterhoeven
Hi Shimoda-san, On Tue, Mar 12, 2019 at 4:17 AM Yoshihiro Shimoda wrote: > From: Phong Hoang > > This patch fixes deadlock warning if removing PWM device > when CONFIG_PROVE_LOCKING is enabled. > > This issue can be reproceduced by the following steps on > the R-Car H3 Salvator-X board if the ba

[PATCH] pwm: Avoid deadlock warning when removing PWM device

2019-03-11 Thread Yoshihiro Shimoda
From: Phong Hoang This patch fixes deadlock warning if removing PWM device when CONFIG_PROVE_LOCKING is enabled. This issue can be reproceduced by the following steps on the R-Car H3 Salvator-X board if the backlight is disabled: # cd /sys/class/pwm/pwmchip0 # echo 0 > export # ls device e