RE: [PATCH 2/3] phy: renesas: rcar-gen3-usb2: Add support for R7S9210

2018-11-19 Thread Chris Brandt
Hi Shimodaさん From: Yoshihiro Shimoda Sent: Monday, November 19, 2018 3:58 AM > And I read Figure 32.1 of the RZ/A2 documentation and I wonder if we need > to release > USBCTR.PLL_RST even if we use USB peripheral mode. I will ask the RZ/A2 design team to confirm. If this setting is required, I

RE: [PATCH 2/3] phy: renesas: rcar-gen3-usb2: Add support for R7S9210

2018-11-19 Thread Yoshihiro Shimoda
Hi Chris-san, > From: Chris Brandt, Sent: Thursday, November 15, 2018 9:34 PM > > Hi Shimodaさん > > > From: Yoshihiro Shimoda > > Sent: Thursday, November 15, 2018 4:20 AM > > > > Host does NOT work: > > > //else > > > // /* No otg, so default to host mode */ > > > //

RE: [PATCH 2/3] phy: renesas: rcar-gen3-usb2: Add support for R7S9210

2018-11-15 Thread Chris Brandt
Hi Shimodaさん > From: Yoshihiro Shimoda > Sent: Thursday, November 15, 2018 4:20 AM > > Host does NOT work: > > //else > > // /* No otg, so default to host mode */ > > // writel(0x, usb2_base + USB2_COMMCTRL); > > I got it. However, I have a concern how to set the

RE: [PATCH 2/3] phy: renesas: rcar-gen3-usb2: Add support for R7S9210

2018-11-15 Thread Yoshihiro Shimoda
Hi Chris-san, > From: Chris Brandt, Sent: Wednesday, November 14, 2018 10:03 PM > > Hi Shimoda-san, > > > From: Yoshihiro Shimoda > > Sent: Wednesday, November 14, 2018 7:24 AM > > > > > config PHY_RCAR_GEN3_USB2 > > > > > tristate "Renesas R-Car generation 3 USB 2.0 PHY driver" > > > >

RE: [PATCH 2/3] phy: renesas: rcar-gen3-usb2: Add support for R7S9210

2018-11-14 Thread Chris Brandt
Hi Shimoda-san, > From: Yoshihiro Shimoda > Sent: Wednesday, November 14, 2018 7:24 AM > > > > config PHY_RCAR_GEN3_USB2 > > > > tristate "Renesas R-Car generation 3 USB 2.0 PHY driver" > > > > depends on ARCH_RENESAS > > > > - depends on EXTCON > > > > + depends on

RE: [PATCH 2/3] phy: renesas: rcar-gen3-usb2: Add support for R7S9210

2018-11-14 Thread Yoshihiro Shimoda
Hi Chris-san, > From: Chris Brandt, Sent: Wednesday, November 14, 2018 8:18 PM > > Hi Shimoda-san, > > > From: Yoshihiro Shimoda > > Sent: Wednesday, November 14, 2018 5:50 AM > > > config PHY_RCAR_GEN3_USB2 > > > tristate "Renesas R-Car generation 3 USB 2.0 PHY driver" > > > depends on

RE: [PATCH 2/3] phy: renesas: rcar-gen3-usb2: Add support for R7S9210

2018-11-14 Thread Chris Brandt
Hi Shimoda-san, > From: Yoshihiro Shimoda > Sent: Wednesday, November 14, 2018 5:50 AM > > config PHY_RCAR_GEN3_USB2 > > tristate "Renesas R-Car generation 3 USB 2.0 PHY driver" > > depends on ARCH_RENESAS > > - depends on EXTCON > > + depends on EXTCON || ARCH_R7S9210 > > Does this

RE: [PATCH 2/3] phy: renesas: rcar-gen3-usb2: Add support for R7S9210

2018-11-14 Thread Yoshihiro Shimoda
Hi Chris-san, Thank you for the patch! > From: Chris Brandt, Sent: Thursday, November 8, 2018 2:36 AM > > The RZ/A2 has the same USB2 host controller as R-Car Gen3 with only some > minor differences. > > Signed-off-by: Chris Brandt > --- > drivers/phy/renesas/Kconfig | 2 +- >