Re: [PATCH 2/2] arm64: dts: renesas: r8a77995: Fix VSP registers range
Hi Geert,
On Friday, 8 June 2018 14:53:28 EEST Geert Uytterhoeven wrote:
> On Fri, Jun 8, 2018 at 1:18 PM Laurent Pinchart wrote:
> > The R8A77995 VSP and FCP nodes have overlapping register ranges, as the
> > SoC integrates the FCP devices in the memory range usually used by the
> > VSP LUT and CLUT, which are not present. Fix this by shortening the VSP
> > registers range to 0x5000.
>
> According to datasheet rev. 1.00, the CLUT is present on R-Car D3, the
> LUT is not.
That was a typo, the commit message should have mentioned CLU, not CLUT. I've
sent a v2 that fixes this and covers the H3 and M3* SoCs.
> > Fixes: 295952a183d3 ("arm64: dts: renesas: r8a77995: add VSP instances")
> > Reported-by: Simon Horman
> > Reported-by: Geert Uytterhoeven
> > Signed-off-by: Laurent Pinchart
> >
>
> Apart from my comment above:
> Reviewed-by: Geert Uytterhoeven
--
Regards,
Laurent Pinchart
Re: [PATCH 2/2] arm64: dts: renesas: r8a77995: Fix VSP registers range
Hi Laurent,
Thanks for your patch!
On Fri, Jun 8, 2018 at 1:18 PM Laurent Pinchart
wrote:
> The R8A77995 VSP and FCP nodes have overlapping register ranges, as the
> SoC integrates the FCP devices in the memory range usually used by the
> VSP LUT and CLUT, which are not present. Fix this by shortening the VSP
> registers range to 0x5000.
According to datasheet rev. 1.00, the CLUT is present on R-Car D3, the
LUT is not.
> Fixes: 295952a183d3 ("arm64: dts: renesas: r8a77995: add VSP instances")
> Reported-by: Simon Horman
> Reported-by: Geert Uytterhoeven
> Signed-off-by: Laurent Pinchart
Apart from my comment above:
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
