Re: [PATCH 3/4] [SCSI] ufs: Add AMBA glue driver to ufshcd

2012-07-10 Thread vinayak holikatti
On Mon, Jul 2, 2012 at 8:50 PM, Arnd Bergmann wrote: > On Monday 02 July 2012, Vinayak Holikatti wrote: >> +static struct amba_id ufshcd_amba_ids[] = { >> + { >> + /* Fake id for Primecell.*/ >> + .id = 0x00041FF0, >> + .mask = 0x000f, >> +

Re: [PATCH 2/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2012-07-10 Thread vinayak holikatti
On Mon, Jul 2, 2012 at 8:57 PM, Arnd Bergmann wrote: > On Monday 02 July 2012, Vinayak Holikatti wrote: >> +static struct platform_driver ufshcd_pltfrm_driver = { >> + .probe = ufshcd_pltfrm_probe, >> + .remove = __devexit_p(ufshcd_pltfrm_remove), >> +#ifdef CONFIG_PM >> + .susp

Re: [PATCH 1/4] [SCSI] ufs: Separate PCI glue driver for ufshcd

2012-07-10 Thread vinayak holikatti
On Mon, Jul 2, 2012 at 8:47 PM, Arnd Bergmann wrote: > On Monday 02 July 2012, Vinayak Holikatti wrote: >> >> This patch separates PCI and core UFS host controller driver. >> In the current implementation PCI specific code is with ufshcd.c. >> To provide way for adding multiple bus glue driver, th

Re: [PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-10 Thread Thomas Abraham
On 10 July 2012 22:27, Mark Brown wrote: > On Tue, Jul 10, 2012 at 10:22:31PM +0530, Thomas Abraham wrote: > >> In non-dt case, the platform code supplying the gpio number (slave >> select line) is responsible for requesting the gpio during the >> machine_init call. So the gpio request is not call

Re: [PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-10 Thread Mark Brown
On Tue, Jul 10, 2012 at 10:22:31PM +0530, Thomas Abraham wrote: > In non-dt case, the platform code supplying the gpio number (slave > select line) is responsible for requesting the gpio during the > machine_init call. So the gpio request is not called in the driver for > that gpio. In dt case, th

Re: [PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-10 Thread Thomas Abraham
On 10 July 2012 20:08, Mark Brown wrote: > On Tue, Jul 10, 2012 at 07:57:38PM +0530, Thomas Abraham wrote: >> The set_level callback in the controller data, which is used to configure >> the slave select line, cannot be supported when migrating the driver to >> device tree based discovery. Since a

Re: [PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-10 Thread Mark Brown
On Tue, Jul 10, 2012 at 07:57:38PM +0530, Thomas Abraham wrote: > The set_level callback in the controller data, which is used to configure > the slave select line, cannot be supported when migrating the driver to > device tree based discovery. Since all the platforms currently use gpio > as the sl

[PATCH v4 6/6] spi: s3c64xx: add device tree support

2012-07-10 Thread Thomas Abraham
Add support for device based discovery. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh Acked-by: Grant Likely --- .../devicetree/bindings/spi/spi-samsung.txt| 113 drivers/spi/spi-s3c64xx.c | 277 +--- 2 files changed, 358 in

[PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-10 Thread Thomas Abraham
The set_level callback in the controller data, which is used to configure the slave select line, cannot be supported when migrating the driver to device tree based discovery. Since all the platforms currently use gpio as the slave select line, this callback can be removed from the controller data a

[PATCH v4 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-07-10 Thread Thomas Abraham
With the spi controller hardware configuration moved into the driver data, there are no more default hardware configuration data that is passed through platform data. Accordingly, the s3c64xx_spi{0|1|2}_set_platdata functions are adapted to these changes. Signed-off-by: Thomas Abraham Acked-by: J

[PATCH v4 3/6] ARM: Samsung: Remove pdev pointer parameter from spi gpio setup functions

2012-07-10 Thread Thomas Abraham
The platform data pointer that is passed to the spi gpio setup functions is not used. Hence, this paremeter is removed from all the spi gpio setup functions. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh --- arch/arm/mach-exynos/setup-spi.c |8 +++- arch/arm/ma

[PATCH v4 2/6] spi: s3c64xx: move controller information into driver data

2012-07-10 Thread Thomas Abraham
Platform data is used to specify controller hardware specific information such as the tx/rx fifo level mask and bit offset of rx fifo level. Such information is not suitable to be supplied from device tree. Instead, it can be moved into the driver data and removed from platform data. Signed-off-by

[PATCH v4 1/6] spi: s3c64xx: remove unused S3C64XX_SPI_ST_TRLCNTZ macro

2012-07-10 Thread Thomas Abraham
The macro S3C64XX_SPI_ST_TRLCNTZ is not used and hence it is removed. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh Acked-by: Grant Likely --- drivers/spi/spi-s3c64xx.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi

[PATCH v4 0/6] spi: s3c64xx: add support for device tree

2012-07-10 Thread Thomas Abraham
Changes since v3: - Fixed the build breakage after applying 3rd patch in this series (which had dependency on the 6th patch). This was reported by Doug Anderson. Changes since v2: - Removed renaming of platform device name at runtime - Includes other minor fixes suggested by Olof, Grant, Kukjin

Re: [GIT PULL] Samsung board-1 for v3.6

2012-07-10 Thread Arnd Bergmann
On Tuesday 10 July 2012, Kukjin Kim wrote: > Kukjin Kim , Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. > > The following changes since commit cfaf025112d3856637ff34a767ef785ef5cf2ca9: > > Linux 3.5-rc2 (2012-06-08 18:40:09 -0700) > > are available in the git

Re: [GIT PULL] Samsung devel-dma ops for v3.6

2012-07-10 Thread Arnd Bergmann
On Tuesday 10 July 2012, Kukjin Kim wrote: > Hi Arnd, Olof, > > Here is updating DMA common operation for Samsung SoCs. > > Since some DMA client driver such as spi needs to change the configuration > after dma_request() so this branch adds dma_config() can configure DMA > transmit option which i

Re: [GIT PULL] Samsung cleanup-1 for v3.6

2012-07-10 Thread Arnd Bergmann
On Tuesday 10 July 2012, Kukjin Kim wrote: > arch/arm/mach-exynos/common.c | 25 -- > arch/arm/mach-exynos/include/mach/spi-clocks.h | 16 > arch/arm/mach-exynos/mach-nuri.c|1 - > arch/arm/mach-exynos/mach-origen.c |1 - > arch/

[PATCH] ARM: S3C64XX: Don't specify an irq_base for WM1192-EV1 board

2012-07-10 Thread Mark Brown
None of the GPIO IRQs are connected so there is no reason to specify a base. Signed-off-by: Mark Brown --- arch/arm/mach-s3c64xx/mach-smdk6410.c |1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-s3c64xx/mach-smdk6410.c b/arch/arm/mach-s3c64xx/mach-smdk6410.c index df3103d..0fe