[PATCH] MFD: SEC: Fix reg_offset for interrupt registers

2012-10-17 Thread Inderpal Singh
reg_offset is offset of the status/mask registers. Now, since status_base and mask_base are pointing to corresponding first registers, reg_offset should start from 0 otheriwse regmap_add_irq_chip will fail during probe. Signed-off-by: Inderpal Singh inderpal.si...@linaro.org --- It is based on

Re: [PATCH] spi: s3c64xx: use clk_prepare_enable and clk_disable_unprepare

2012-10-17 Thread Mark Brown
On Wed, Oct 03, 2012 at 08:30:12AM +0900, Thomas Abraham wrote: Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare calls as required by common clock framework. Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a

RE: [PATCH v2 v2 v2 8/8] spi/s3c64xx: use correct dma_transfer_direction type

2012-10-17 Thread Kukjin Kim
Arnd Bergmann wrote: There is a subtle difference between dma_transfer_direction and dma_data_direction: the former is used by the dmaengine framework, while the latter is used by the dma-mapping API. Although the purpose is comparable, the actual values are different and must not be mixed.

RE: [PATCH] ARM: SAMSUNG: Add naming of s3c64xx-spi devices

2012-10-17 Thread Kukjin Kim
José Miguel Gonçalves wrote: On 15-10-2012 15:58, Sylwester Nawrocki wrote: Hi Heiko, On 10/02/2012 02:43 PM, Heiko Stübner wrote: Commit a5238e360b71 (spi: s3c64xx: move controller information into driver data) introduced separate device names for the different subtypes of the

Re: [PATCH 3/3] mmc: sdhci-s3c: Add clk_(enable/disable) in runtime suspend/resume

2012-10-17 Thread Heiko Stübner
Hi, Am Freitag, 14. September 2012, 11:08:51 schrieb Chander Kashyap: Perform clock disable/enable in runtime suspend/resume. Signed-off-by: Chander Kashyap chander.kash...@linaro.org It seems this patch breaks my S3C2416 based machine with 3.7-rc1. I'm not yet sure why, but the only

RE: [PATCH] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-10-17 Thread Kukjin Kim
Praveen Paneri wrote: platform_set_drvdata() required for driver's remove function, so adding it back. From v6: Added TODO for phy bindings with controller Dropped platform_set_drvdata() from driver probe This driver uses usb_phy interface to interact with s3c-hsotg. Supports phy_init

RE: [PATCH v3 1/6] dts: exynos: add device tree support for exynos5 hdmi

2012-10-17 Thread Kukjin Kim
Rahul Sharma wrote: This patch adds support for device tree based discovery for exynos5 hdmi. Hdmi node is also renamed with exynos5-hdmi. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- .../devicetree/bindings/drm/exynos/hdmi.txt| 22

RE: [PATCH v3 2/6] dts: exynos: add device tree support for exynos5 mixer

2012-10-17 Thread Kukjin Kim
Rahul Sharma wrote: This patch adds support for device tree based discovery for exynos5 mixer. Mixer node is also renamed with exynos5-mixer. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- .../devicetree/bindings/drm/exynos/mixer.txt | 15 +++

RE: [PATCH v3 0/6] arm: exynos: add dt based support for exynos5 hdmi

2012-10-17 Thread Kukjin Kim
Rahul Sharma wrote: Mr. Park, Looks good to me. Shall I divide the patch-set into two groups and re-post them? No, you don't need to divide this series. It should be OK to be sent to upstream via Samsung tree. But see my small comments on your patch before that. BTW, I'm not sure about

[PATCH V4 0/4] [SCSI] ufs: Adds glue drivers to ufshcd

2012-10-17 Thread Vinayak Holikatti
This patch set adds following features - Seggregate PCI specific code in ufshcd.c and corrected copyright - Adds PCI glue driver ufshcd-pci.c and ufshcd.c become core module - Adds Platform glue driver ufshcd-pltfrm.c - Update correct transfer size in Command UPIU Vinayak Holikatti (4):

[PATCH V4 1/4] [SCSI] drivers/scsi/ufs: Seggregate PCI Specific Code

2012-10-17 Thread Vinayak Holikatti
This patch seggregates the PCI specific code in ufshcd.c to make it ready for splitting into core ufs driver and PCI glue driver. Also copyright header modification to remove extra warranty disclaim. Reviewed-by: Arnd Bergmann a...@arndb.de Reviewed-by: Namjae Jeon linkinj...@gmail.com

[PATCH V4 2/4] [SCSI] drivers/scsi/ufs: Separate PCI code into glue driver

2012-10-17 Thread Vinayak Holikatti
This patch separates PCI code from ufshcd.c and makes it as a core driver module and adds a new file ufshcd-pci.c as PCI glue driver. Reviewed-by: Arnd Bergmann a...@arndb.de Reviewed-by: Namjae Jeon linkinj...@gmail.com Signed-off-by: Vinayak Holikatti vinholika...@gmail.com Signed-off-by:

[PATCH V4 4/4] [SCSI] ufs: Correct the expected data transfer size

2012-10-17 Thread Vinayak Holikatti
This patch corrects the expected data transfer size of the command UPIU. The current implementation of cmd-transfersize is wrong as it probably equal to sector size. With this implementation the transfer size is updated correctly Reported-by: KOBAYASHI Yoshitake yoshitake.kobaya...@toshiba.co.jp

[PATCH V4 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2012-10-17 Thread Vinayak Holikatti
This patch adds Platform glue driver for ufshcd. Reviewed-by: Arnd Bergmann a...@arndb.de Reviewed-by: Namjae Jeon linkinj...@gmail.com Signed-off-by: Vinayak Holikatti vinholika...@gmail.com Signed-off-by: Santosh Yaraganavi santos...@gmail.com --- drivers/scsi/ufs/Kconfig | 11 ++

Re: [PATCH] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-10-17 Thread Praveen Paneri
Hi, On Wed, Oct 17, 2012 at 4:30 PM, Kukjin Kim kgene@samsung.com wrote: Praveen Paneri wrote: platform_set_drvdata() required for driver's remove function, so adding it back. From v6: Added TODO for phy bindings with controller Dropped platform_set_drvdata() from driver probe This

Re: [PATCH v2 v2 v2 8/8] spi/s3c64xx: use correct dma_transfer_direction type

2012-10-17 Thread Arnd Bergmann
On Wednesday 17 October 2012, Kukjin Kim wrote: BTW, don't we need following accordingly? diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 1a81c90..a0bb55e 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1067,11 +1067,11 @@ static int

Re: [PATCH 1/8] [media] s5p-fimc: Use clk_prepare_enable and clk_disable_unprepare

2012-10-17 Thread Sylwester Nawrocki
Hi Sachin, On 10/17/2012 01:11 PM, Sachin Kamat wrote: Replace clk_enable/clk_disable with clk_prepare_enable/clk_disable_unprepare as required by the common clock framework. I think this statement is misleading. In my understanding it is not the common clock framework requirement to use

Re: [PATCH 1/8] [media] s5p-fimc: Use clk_prepare_enable and clk_disable_unprepare

2012-10-17 Thread Sachin Kamat
Hi Sylwester, Thanks for the review. On 17 October 2012 20:03, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hi Sachin, On 10/17/2012 01:11 PM, Sachin Kamat wrote: Replace clk_enable/clk_disable with clk_prepare_enable/clk_disable_unprepare as required by the common clock framework.

Re: [PATCH 1/8] [media] s5p-fimc: Use clk_prepare_enable and clk_disable_unprepare

2012-10-17 Thread Sylwester Nawrocki
On 10/17/2012 05:35 PM, Sachin Kamat wrote: Most of the s5p-* drivers have already added support for clk_(un)prepare. Thus most of your changes in this patch are not needed. I seem to have only missed fimc-mdevice.c, other modules are already reworked I did not find these changes in your

Re: [PATCH] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-10-17 Thread Russell King - ARM Linux
On Wed, Oct 17, 2012 at 08:00:00PM +0900, Kukjin Kim wrote: +static int samsung_usbphy_get_refclk_freq(struct samsung_usbphy *sphy) +{ + struct clk *ref_clk; + int refclk_freq = 0; + + ref_clk = clk_get(sphy-dev, xusbxti); + if (IS_ERR(ref_clk)) { IS_ERR_OR_NULL(ref_clk)?

IS_ERR_OR_NULL - please STOP telling people to use this on a whim

2012-10-17 Thread Russell King - ARM Linux
People, This is not aimed at anyone specifically - but it is aimed at everyone who reviews patches to make them aware of this issue, and to modify their behaviour. I'm geting sick and tired of telling people about this. I've just floated the idea of removing IS_ERR_OR_NULL from the kernel tree

Re: IS_ERR_OR_NULL - please STOP telling people to use this on a whim

2012-10-17 Thread Phil Carmody
On 17/10/12 20:41 +0100, Russell King - ARM Linux wrote: People, This is not aimed at anyone specifically - but it is aimed at everyone who reviews patches to make them aware of this issue, and to modify their behaviour. I'm geting sick and tired of telling people about this. I've just

Re: IS_ERR_OR_NULL - please STOP telling people to use this on a whim

2012-10-17 Thread Russell King - ARM Linux
On Wed, Oct 17, 2012 at 11:28:48PM +0300, Phil Carmody wrote: So, what to do? It can and has been used sensibly, so I don't think removing it is the best option. Well, the first thing that needs to be done is a full review of every user and fixes applied. The second thing is that we need eyes

Re: [PATCH 3/3] mmc: sdhci-s3c: Add clk_(enable/disable) in runtime suspend/resume

2012-10-17 Thread Jaehoon Chung
Hi Heiko, Sorry, i didn't check this patch with s3c2416. (i didn't have the s3c2416 board.) If you have a problem, i think good that revert this patch for fixing your problem. Also, i will check and share the result. Best Regards, Jaehoon Chung On 10/17/2012 06:15 PM, Heiko Stübner wrote: Hi,