Re: [PATCH v3] mmc: dw_mmc: let device core setup the default pin configuration

2013-04-09 Thread Thomas Abraham
On 8 April 2013 17:49, Seungwon Jeon tgih@samsung.com wrote: On Friday, April 05, 2013, Thomas Abraham wrote: With device core now able to setup the default pin configuration, the pin configuration code based on the deprecated Samsung specific gpio bindings is removed. Signed-off-by:

Re: [PATCH v3] mmc: dw_mmc: let device core setup the default pin configuration

2013-04-09 Thread Thomas Abraham
On 8 April 2013 21:38, Doug Anderson diand...@google.com wrote: Thomas, Since I commented on previous versions of this patch, I would have loved to have been CCed on this new version. ;) Hi Doug, Sorry for missing out on CC'ing you in the v3 patch. It just slipped my mind. On Fri, Apr 5,

Re: [PATCH 1/6] pinctrl: samsung: Protect bank registers with a spinlock

2013-04-09 Thread Linus Walleij
On Mon, Mar 18, 2013 at 10:31 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Certain pin control registers can be accessed from different contexts, i.e. pinctrl, gpio and irq functions. This makes the locking provided by pin control core insufficient. This patch adds necessary locking using a

Re: [PATCH 2/6] pinctrl: samsung: Include pinctrl-exynos driver data conditionally

2013-04-09 Thread Linus Walleij
On Mon, Mar 18, 2013 at 10:38 PM, Tomasz Figa tomasz.f...@gmail.com wrote: On Monday 18 of March 2013 22:31:51 Tomasz Figa wrote: Since pinctrl-samsung is a common part of the pin control support for several Samsung SoCs, it can be compiled without Exynos support enabled. This patch surrounds

Re: [PATCH 3/6] pinctrl: samsung: Split pin bank description into two structures

2013-04-09 Thread Linus Walleij
On Mon, Mar 18, 2013 at 10:31 PM, Tomasz Figa tomasz.f...@gmail.com wrote: This patch splits pin bank description into two structures, one describing bank type (currently only bitfield widths), which can be shared across multiple banks and second containing bank-specific parameters including

Re: [PATCH 4/6] pinctrl: samsung: Remove hardcoded register offsets

2013-04-09 Thread Linus Walleij
On Mon, Mar 18, 2013 at 10:31 PM, Tomasz Figa tomasz.f...@gmail.com wrote: This patch replaces statically hardcoded register offsets of Exynos SoCs with an array of register offsets in samsung_pin_bank_type struct. Thanks to this change, support for SoCs with other set and order of registers

Re: [PATCH 5/6] pinctrl: samsung: Handle banks with two configuration registers

2013-04-09 Thread Linus Walleij
On Mon, Mar 18, 2013 at 10:31 PM, Tomasz Figa tomasz.f...@gmail.com wrote: This patch adds support for banks that have more than one function configuration registers, e.g. some of the banks of S3C64xx SoCs. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com Patch applied. Yours, Linus Walleij

Re: [PATCH 6/6] pinctrl: Add pinctrl-s3c64xx driver

2013-04-09 Thread Linus Walleij
On Mon, Mar 18, 2013 at 10:31 PM, Tomasz Figa tomasz.f...@gmail.com wrote: This patch adds pinctrl-s3c64xx driver which implements pin control interface for Samsung S3C64xx SoCs. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com Yes it's long over due that we fix up the S3C family, thanks a

Re: [PATCH 1/3] pinctrl: exynos5440: fix probe failure due to missing pin-list in config nodes

2013-04-09 Thread Linus Walleij
On Tue, Mar 26, 2013 at 4:12 PM, Kukjin Kim kgene@samsung.com wrote: From: Thomas Abraham thomas...@samsung.com The property 'samsung,exynos5440-pins' is optional in configuration nodes which are included in the Exynos5440 pin-controller device node. Fix the incorrect failure in driver

Re: [PATCH 2/3] pinctrl: exynos5440: add gpio interrupt support

2013-04-09 Thread Linus Walleij
On Tue, Mar 26, 2013 at 4:12 PM, Kukjin Kim kgene@samsung.com wrote: From: Thomas Abraham thomas...@samsung.com Exynos5440 supports gpio interrupts on gpios 16 to 23. The eight interrupt lines originating from the pin-controller are connected to the gic. Add irq-chip support for

Re: [PATCH 3/3] ARM: dts: list the interrupts generated by pin-controller on Exynos5440

2013-04-09 Thread Linus Walleij
On Tue, Mar 26, 2013 at 4:12 PM, Kukjin Kim kgene@samsung.com wrote: From: Thomas Abraham thomas...@samsung.com Exynos5440 pin-controller generates eight interrupts to support gpio interrupts. List those interrupt numbers in the pin-controller node. Signed-off-by: Thomas Abraham

[PATCH] usb: ehci-s5p: fix: Fix null pointer dereferencing

2013-04-09 Thread Vivek Gautam
7edb3da makes ehci-s5p as a separate driver. But, it raised an issue with its driver data. Now that 's5p_ehci_hcd' doesn't maintain pointer to 'usb_hcd' and s5p_ehci is nothing but a pointer to hcd-priv; add hcd to the driver data rather than s5p_ehci. This fixes issues with null pointer

Re: [PATCH] i2c: s3c2410: Add SMBus emulation for block read

2013-04-09 Thread Wolfram Sang
On Tue, Mar 26, 2013 at 07:59:56PM +0530, Prasanna Kumar wrote: From: Jaemin Yoo jmin@samsung.com SMBus read and write are supported by the emulation layer of i2c framework if the controller doesn't have SMBus features. I2C_M_RECV_LEN flag is used to let i2c drivers know rx length is

[PATCH RFC] rtc: rtc-s3c: use clk_prepare_enable and clk_disable_unprepare

2013-04-09 Thread Vivek Gautam
Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare calls as required by common clock framework, to get rid of WARN_ON on prepare_count. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- This fixes the warnings in the boot log coming out of enabling the common clock

Re: [PATCH RFC] rtc: rtc-s3c: use clk_prepare_enable and clk_disable_unprepare

2013-04-09 Thread Sylwester Nawrocki
On 04/09/2013 11:45 AM, Vivek Gautam wrote: Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare calls as required by common clock framework, to get rid of WARN_ON on prepare_count. Hmm, do you think warnings like below are any better that WARN_ON() on wrong clock's

Re: [PATCH] usb: ehci-s5p: fix: Fix null pointer dereferencing

2013-04-09 Thread Arnd Bergmann
On Tuesday 09 April 2013, Vivek Gautam wrote: 7edb3da makes ehci-s5p as a separate driver. But, it raised an issue with its driver data. Now that 's5p_ehci_hcd' doesn't maintain pointer to 'usb_hcd' and s5p_ehci is nothing but a pointer to hcd-priv; add hcd to the driver data rather than

RE: [GIT PULL 10/10] devel-samsung for v3.10

2013-04-09 Thread Kukjin Kim
Sylwester Nawrocki wrote: [...] Sylwester Nawrocki (2): ARM: SAMSUNG: Export MIPI CSIS/DSIM PHY control functions This one was supposed to be a fix for 3.8-rc IIRC. But anyway the whole If so, this should be sent to stable 3.8 tree, but I'm not sure this is really bug fix. file this

RE: [PATCH] ARM: EXYNOS: no more support non-DT for EXYNOS SoCs

2013-04-09 Thread Kukjin Kim
Kukjin Kim wrote: As we discussed in mailing list, non-DT for EXYNOS SoCs will not be supported from v3.10. This patch removes regarding files for non-DT including board files. Signed-off-by: Kukjin Kim kgene@samsung.com --- arch/arm/configs/exynos4_defconfig | 68 --

Re: [PATCH] ARM: EXYNOS: no more support non-DT for EXYNOS SoCs

2013-04-09 Thread Arnd Bergmann
On Tuesday 09 April 2013, Kukjin Kim wrote: One more, as you know, we cannot support all features non-DT did only with DT exynos. But I think, if required, some of them can be kept in samsung tree temporarily. Which are the features that are going to be missing? Is it possible to add the ones

Re: [GIT PULL 10/10] devel-samsung for v3.10

2013-04-09 Thread Sylwester Nawrocki
On 04/09/2013 01:20 PM, Kukjin Kim wrote: Sylwester Nawrocki wrote: [...] Sylwester Nawrocki (2): ARM: SAMSUNG: Export MIPI CSIS/DSIM PHY control functions This one was supposed to be a fix for 3.8-rc IIRC. But anyway the whole If so, this should be sent to stable 3.8 tree, but I'm

Re: [PATCH] i2c: s3c2410: Add SMBus emulation for block read

2013-04-09 Thread Uwe Kleine-König
Hello, On Tue, Mar 26, 2013 at 07:59:56PM +0530, Prasanna Kumar wrote: diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index 17c5c37..e4ab9ea 100644 --- a/drivers/i2c/busses/i2c-s3c2410.c +++ b/drivers/i2c/busses/i2c-s3c2410.c @@ -309,6 +309,12 @@ static

Re: [PATCH] usb: ehci-s5p: fix: Fix null pointer dereferencing

2013-04-09 Thread Sergei Shtylyov
Hello. On 09-04-2013 13:21, Vivek Gautam wrote: 7edb3da makes ehci-s5p as a separate driver. But, Please also provide the summary line of that commit in parens. it raised an issue with its driver data. Now that 's5p_ehci_hcd' doesn't maintain pointer to 'usb_hcd' and s5p_ehci is nothing

Re: [PATCH RFC] rtc: rtc-s3c: use clk_prepare_enable and clk_disable_unprepare

2013-04-09 Thread Vivek Gautam
Hi Sylwester, On Tue, Apr 9, 2013 at 3:39 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 04/09/2013 11:45 AM, Vivek Gautam wrote: Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare calls as required by common clock framework, to get rid of WARN_ON on

Re: [PATCH] usb: ehci-s5p: fix: Fix null pointer dereferencing

2013-04-09 Thread Vivek Gautam
Hi, On Tue, Apr 9, 2013 at 6:01 PM, Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: Hello. On 09-04-2013 13:21, Vivek Gautam wrote: 7edb3da makes ehci-s5p as a separate driver. But, Please also provide the summary line of that commit in parens. Sure, will add the commit

[PATCH v2] usb: ehci-s5p: fix: Fix null pointer dereferencing

2013-04-09 Thread Vivek Gautam
7edb3da: (USB: EHCI: make ehci-s5p a separate driver) raised an issue with ehci-s5p's driver data. Now that 's5p_ehci_hcd' doesn't maintain pointer to 'usb_hcd' and s5p_ehci is nothing but a pointer to hcd-priv; add hcd to the driver data rather than s5p_ehci. This fixes issues with null pointer

Re: [PATCH RFC] rtc: rtc-s3c: use clk_prepare_enable and clk_disable_unprepare

2013-04-09 Thread Vivek Gautam
Hi Sylwester, On Tue, Apr 9, 2013 at 6:21 PM, Vivek Gautam gautamvivek1...@gmail.com wrote: Hi Sylwester, On Tue, Apr 9, 2013 at 3:39 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 04/09/2013 11:45 AM, Vivek Gautam wrote: Convert clk_enable/clk_disable to

Re: [GIT PULL 01/10] cleanup-samsung for v3.10

2013-04-09 Thread Arnd Bergmann
On Monday 08 April 2013, Kukjin Kim wrote: The following changes since commit a937538b868b8369b98967929045f1df54234323: Linux 3.9-rc3 (2013-03-17 15:59:32 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git

Re: [PATCH RFC] rtc: rtc-s3c: use clk_prepare_enable and clk_disable_unprepare

2013-04-09 Thread Sylwester Nawrocki
On 04/09/2013 03:34 PM, Vivek Gautam wrote: Aah !! actually missed a similar patch from Thomas Abraham :( doing the same as suggested by you. Its available at: http://patchwork.ozlabs.org/patch/188687/ There's a change required in the above mentioned patch, so possibly Thomas can go ahead

Re: [PATCH RFC] rtc: rtc-s3c: use clk_prepare_enable and clk_disable_unprepare

2013-04-09 Thread Vivek Gautam
On Tue, Apr 9, 2013 at 7:29 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 04/09/2013 03:34 PM, Vivek Gautam wrote: Aah !! actually missed a similar patch from Thomas Abraham :( doing the same as suggested by you. Its available at: http://patchwork.ozlabs.org/patch/188687/

[PATCH] rtc: rtc-s3c: use clk_prepare_enable and clk_disable_unprepare

2013-04-09 Thread Vivek Gautam
From: Thomas Abraham thomas.abra...@linaro.org Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare calls as required by common clock framework. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- The v1 of this

Re: [GIT PULL 06/10] 2nd pinctrl-exynos for v3.10

2013-04-09 Thread Kukjin Kim
On 04/09/13 03:19, Kukjin Kim wrote: The following changes since commit 97916777d6904e24b86eac77da58ef7cb09d539d: ARM: EXYNOS: skip wakeup interrupt registration for exynos5250 if pinctrl is enabled (2013-03-05 20:59:12 +0900) are available in the git repository at:

Re: [PATCH 3/3] ARM: dts: list the interrupts generated by pin-controller on Exynos5440

2013-04-09 Thread Kukjin Kim
On 04/09/13 17:24, Linus Walleij wrote: On Tue, Mar 26, 2013 at 4:12 PM, Kukjin Kimkgene@samsung.com wrote: From: Thomas Abrahamthomas...@samsung.com Exynos5440 pin-controller generates eight interrupts to support gpio interrupts. List those interrupt numbers in the pin-controller node.

Re: [PATCH] ARM: S3C24XX: Fix interrupt pending register offset of the EINT controller

2013-04-09 Thread Kukjin Kim
On 04/09/13 05:25, Heiko Stübner wrote: Am Montag, 8. April 2013, 21:53:07 schrieb Sylwester Nawrocki: The external pending interrupt register address (EINTPEND) offset is 0xa8, not 0x08. Without this patch the external interrupts are not properly acknowledged, which may lead to an interrupt

[PATCH RESEND] ARM: EXYNOS: no more support non-DT for EXYNOS SoCs

2013-04-09 Thread kgene . kim
From: Kukjin Kim kgene@samsung.com As we discussed in mailing list, non-DT for EXYNOS SoCs will not be supported from v3.10. This patch removes regarding files for non-DT including board files. Signed-off-by: Kukjin Kim kgene@samsung.com --- Recreated as per Arnd's suggestion with using

Re: [PATCH] ARM: EXYNOS: no more support non-DT for EXYNOS SoCs

2013-04-09 Thread Kukjin Kim
On 04/09/13 20:48, Arnd Bergmann wrote: On Tuesday 09 April 2013, Kukjin Kim wrote: One more, as you know, we cannot support all features non-DT did only with DT exynos. But I think, if required, some of them can be kept in samsung tree temporarily. Which are the features that are going to be

[GIT PULL] Samsung fixes-2 for v3.9

2013-04-09 Thread Kukjin Kim
The following changes since commit 31880c37c11e28cb81c70757e38392b42e695dc6: Linux 3.9-rc6 (2013-04-07 20:49:54 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git tags/samsung-fixes-for-v3.9 for you to fetch changes up to

Re: [GIT PULL] Samsung fixes-2 for v3.9

2013-04-09 Thread Arnd Bergmann
On Tuesday 09 April 2013, Kukjin Kim wrote: The following changes since commit 31880c37c11e28cb81c70757e38392b42e695dc6: Linux 3.9-rc6 (2013-04-07 20:49:54 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git

[GIT PULL v2 10/10] devel-samsung for v3.10

2013-04-09 Thread Kukjin Kim
Hi Arnd, Olof Note, this is re-sending because of missed including fixes in previous pull-request [10/10]. Thanks. - Kukjin The following changes since commit 6dbe51c251a327e012439c4772097a13df43c5b8: Linux 3.9-rc1 (2013-03-03 15:11:05 -0800) are available in the git repository at:

Re: [GIT PULL 10/10] devel-samsung for v3.10

2013-04-09 Thread Kukjin Kim
On 04/09/13 21:09, Sylwester Nawrocki wrote: On 04/09/2013 01:20 PM, Kukjin Kim wrote: Sylwester Nawrocki wrote: [...] Sylwester Nawrocki (2): ARM: SAMSUNG: Export MIPI CSIS/DSIM PHY control functions This one was supposed to be a fix for 3.8-rc IIRC. But anyway the whole If so, this

Re: [GIT PULL] Samsung fixes-2 for v3.9

2013-04-09 Thread Arnd Bergmann
On Tuesday 09 April 2013, Kukjin Kim wrote: The following changes since commit 31880c37c11e28cb81c70757e38392b42e695dc6: Sylwester Nawrocki (2): ARM: S3C24XX: Correct NR_IRQS definition for s3c2440 ARM: S3C24XX:

Re: [GIT PULL 02/10] 2nd irq-s3c24xx for v3.10

2013-04-09 Thread Arnd Bergmann
On Monday 08 April 2013, Kukjin Kim wrote: s3c24xx irq cleanup and move into drivers/irqchip I had a little trouble applying this because of the interface change to CLOCKSOURCE_OF_DECLARE. This is the rather complex merge I did. Please check that it still works. Arnd commit

Re: [GIT PULL 02/10] 2nd irq-s3c24xx for v3.10

2013-04-09 Thread Arnd Bergmann
On Tuesday 09 April 2013, Arnd Bergmann wrote: On Monday 08 April 2013, Kukjin Kim wrote: s3c24xx irq cleanup and move into drivers/irqchip I had a little trouble applying this because of the interface change to CLOCKSOURCE_OF_DECLARE. This is the rather complex merge I did. Please check

Re: [GIT PULL 04/10] clk-exynos for v3.10

2013-04-09 Thread Arnd Bergmann
On Monday 08 April 2013, Kukjin Kim wrote: The following changes since commit 07961ac7c0ee8b546658717034fe692fd12eefa9: Linux 3.9-rc5 (2013-03-31 15:12:43 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git

Re: [GIT PULL 05/10] dt-exynos for v3.10

2013-04-09 Thread Arnd Bergmann
On Monday 08 April 2013, Kukjin Kim wrote: The following changes since commit da821eb7d42935b0f7056d98c75fd1150f6636f4: Merge commit 'v3.9-rc5' into next/clk-exynos (2013-04-09 01:10:13 +0900) are available in the git repository at:

Re: [GIT PULL 09/10] 2nd timer-samsung for v3.10

2013-04-09 Thread Arnd Bergmann
On Monday 08 April 2013, Kukjin Kim wrote: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git tags/timer-samsung-for-v3.10 for you to fetch changes up to 536504309c3c2da5a755263c7179ffe1b2e5b3dd: ARM: SAMSUNG: change GENERIC_GPIO to ARCH_REQUIRE_GPIOLIB

Re: [GIT PULL 07/10] pmu-exynos for v3.10

2013-04-09 Thread Arnd Bergmann
On Monday 08 April 2013, Kukjin Kim wrote: The following changes since commit da821eb7d42935b0f7056d98c75fd1150f6636f4: Merge commit 'v3.9-rc5' into next/clk-exynos (2013-04-09 01:10:13 +0900) are available in the git repository at:

Re: [GIT PULL 08/10] secure-exynos for v3.10

2013-04-09 Thread Arnd Bergmann
On Monday 08 April 2013, Kukjin Kim wrote: The following changes since commit da821eb7d42935b0f7056d98c75fd1150f6636f4: Merge commit 'v3.9-rc5' into next/clk-exynos (2013-04-09 01:10:13 +0900) are available in the git repository at:

Re: [GIT PULL v2 10/10] devel-samsung for v3.10

2013-04-09 Thread Arnd Bergmann
On Tuesday 09 April 2013, Kukjin Kim wrote: Note, this is re-sending because of missed including fixes in previous pull-request [10/10]. Thanks. - Kukjin The following changes since commit 6dbe51c251a327e012439c4772097a13df43c5b8: Linux 3.9-rc1 (2013-03-03 15:11:05 -0800) are

Re: [GIT PULL 0/10] Samsung stuff for v3.10

2013-04-09 Thread Arnd Bergmann
On Monday 08 April 2013, Kukjin Kim wrote: Hi Arnd, Olof This is 2nd pull-request for Samsung stuff for v3.10. If any problems, please kindly let me know. I managed to pull them all in, aside from the 6/10, since you asked us to defer that one. There were a lot more small mistakes, and I

Re: [GIT PULL 08/10] secure-exynos for v3.10

2013-04-09 Thread Rob Herring
On Mon, Apr 8, 2013 at 1:19 PM, Kukjin Kim kgene@samsung.com wrote: The following changes since commit da821eb7d42935b0f7056d98c75fd1150f6636f4: Merge commit 'v3.9-rc5' into next/clk-exynos (2013-04-09 01:10:13 +0900) are available in the git repository at:

[PATCH] thermal: exynos: fix handling of invalid frequency table entries

2013-04-09 Thread Andrew Bresticker
Similar to the error described in thermal: cpu_cooling: fix handling of invalid frequency table entries, exynos_get_frequency_level() will enter an infinite loop if any CPU frequency table entries are invalid. This patch fixes the handling of invalid frequency entries so that there is no infinite

Re: [PATCH v4] mmc: dw_mmc: let device core setup the default pin configuration

2013-04-09 Thread Doug Anderson
Thomas, On Mon, Apr 8, 2013 at 10:59 PM, Thomas Abraham thomas.abra...@linaro.org wrote: @@ -2002,7 +1994,7 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id) if (ret) { dev_err(host-dev, failed to

[PATCH] pinctrl: Add pinctrl-s3c24xx driver

2013-04-09 Thread Heiko Stübner
The s3c24xx pins follow a similar pattern as the other Samsung SoCs and can therefore reuse the already introduced infrastructure. The s3c24xx SoCs have one design oddity in that the first 4 external interrupts do not reside in the eint pending register but in the main interrupt controller

Re: [PATCH] thermal: exynos: fix handling of invalid frequency table entries

2013-04-09 Thread Zhang Rui
Hi, Andrew, can you please verify commit fc35b35cbe24ef021ea9acfba21e54da958df747 commit 57df8106932b57427df1eaaa13871857f75b1194 at http://git.kernel.org/cgit/linux/kernel/git/rzhang/linux.git/log/?h=thermal fixes the problem for you? thanks, rui On Tue, 2013-04-09 at 14:59 -0700, Andrew

Re: [GIT PULL 04/10] clk-exynos for v3.10

2013-04-09 Thread Sachin Kamat
On 10 April 2013 02:01, Arnd Bergmann a...@arndb.de wrote: On Monday 08 April 2013, Kukjin Kim wrote: The following changes since commit 07961ac7c0ee8b546658717034fe692fd12eefa9: Linux 3.9-rc5 (2013-03-31 15:12:43 -0700) are available in the git repository at: