Re: [RFC PATCH v8 10/10] arm: zx_defconfig: remove CONFIG_MMC_DW_IDMAC

2015-10-28 Thread Jaehoon Chung
Hi, All. Is there any other opinion about this patch? Best Regards, Jaehoon Chung On 09/16/2015 03:43 PM, Shawn Lin wrote: > DesignWare MMC Controller's transfer mode should be decided > at runtime instead of compile-time. So we remove this config > option and read dw_mmc's register

Re: [RFC PATCH v8 09/10] arm: multi_v7_defconfig: remove CONFIG_MMC_DW_IDMAC

2015-10-28 Thread Jaehoon Chung
Hi, All. Is there any other opinion about this patch? Best Regards, Jaehoon Chung On 09/16/2015 03:43 PM, Shawn Lin wrote: > DesignWare MMC Controller's transfer mode should be decided > at runtime instead of compile-time. So we remove this config > option and read dw_mmc's register

[PATCHv2] ARM: dts: change the compatible from exynos5250 to exynos5420 for mshc

2015-10-22 Thread Jaehoon Chung
for mshc. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- Changelog v2: - Drop "mmc: dw_mmc: exynos: Add the exynos3250 compatible" patch. - Describe commit-message more detailedly than before. - Change to exynos5420, not add new compatible (exynos3

Re: [PATCH 1/2] mmc: dw_mmc: exynos: Add the exynos3250 compatible

2015-10-21 Thread Jaehoon Chung
On 10/22/2015 12:51 PM, Krzysztof Kozlowski wrote: > On 22.10.2015 11:54, Jaehoon Chung wrote: >> Hi, Krzysztof. >> >> On 10/22/2015 09:06 AM, Krzysztof Kozlowski wrote: >>> On 21.10.2015 15:39, Jaehoon Chung wrote: >>>> To check more exactly, add the exyn

Re: [PATCH 1/2] mmc: dw_mmc: exynos: Add the exynos3250 compatible

2015-10-21 Thread Jaehoon Chung
Hi, Krzysztof. On 10/22/2015 09:06 AM, Krzysztof Kozlowski wrote: > On 21.10.2015 15:39, Jaehoon Chung wrote: >> To check more exactly, add the exynos3250 compatible. >> Not use exynos5250 compatibility. > > Hi, > > I can't find any difference between old and

[PATCH 2/2] ARM: dts: change the compatible from exynos5250 to exynos3250

2015-10-21 Thread Jaehoon Chung
To use more excatly, change compatible from exynos5250 to exynos3250. Exynos3250 and exnos5250 are some difference. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- arch/arm/boot/dts/exynos3250.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/ar

[PATCH 1/2] mmc: dw_mmc: exynos: Add the exynos3250 compatible

2015-10-21 Thread Jaehoon Chung
To check more exactly, add the exynos3250 compatible. Not use exynos5250 compatibility. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt | 2 ++ drivers/mmc/host/dw_mmc-exynos.c | 7 +++ 2 files c

Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support

2015-10-21 Thread Jaehoon Chung
-- >>>>> [4.001477] mmc_host mmc1: Bus speed (slot 0) = 5000Hz (slot >>>>> req 5000Hz, actual 5000HZ div = 0) >>>>> [4.001604] mmc1: new ultra high speed DDR50 SDHC card at address >>>&g

Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support

2015-10-13 Thread Jaehoon Chung
described the overview. Mobile storage host supports these specification: - Secure Digital memory (SD memory version 3.0) - Secure Digital I/O SDIO (SDIO version 3.0) - etc... SD3.0 is supported UHS-I mode. If user manual of exynos5422 is mentioned this specification, it should be

Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support

2015-10-12 Thread Jaehoon Chung
4.630237] mmc_host mmc1: Bus speed (slot 0) = 1Hz (slot > req 1Hz, actual 1HZ div = 0) > [4.639820] mmc1: new ultra high speed SDR50 SDHC card at address > [4.646266] mmcblk0: mmc1: SL32G 29.7 GiB > [4.650293] IRQ56 no longer affine to CPU7 > [4.650581] CPU7: shutdown > [4.658293] mmcblk0: p1 p2 > > Note: Their is need to reset the PMIC > S2MPS11_REG_L13CTRL/S2MPS11_REG_L19CTRL registers > to support this feature consistently on every reboot. I don't understand...why needs to reset? I know it needs to switch the voltage, doesn't it? Best Regards, Jaehoon Chung > > -Anand Moon > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card

2015-10-12 Thread Jaehoon Chung
rds"). Why? There is no explanation in >>> the commit message about this. >> >> I don't remember to send the patch relevant to this. Hmm... >> Well, Is this patch really signed-off by me? >> >> Best Regards, >> >> Jaehoon Chung >>> >>

Re: [PATCH 2/3] ARM: dts: use vmmc-supply of emmc/sd for exynos5422-odroidxu3

2015-10-12 Thread Jaehoon Chung
;>>>>>> samsung,dw-mshc-ddr-timing = <0 2>; >>>>>>>> +vmmc-supply = <_reg>; >>>>>>>> +vqmmc-supply = <_reg>; >>>>>>> >>>>>>> It looks wrong. LDO13 is used in one place

Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support

2015-10-12 Thread Jaehoon Chung
On 10/12/2015 10:16 PM, Krzysztof Kozlowski wrote: > W dniu 12.10.2015 o 22:04, Jaehoon Chung pisze: >> On 10/12/2015 09:42 PM, Krzysztof Kozlowski wrote: >>> W dniu 12.10.2015 o 19:46, Anand Moon pisze: >>>> Hi Krzysztof, >>>> >>>> On 12 Oct

Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card

2015-10-11 Thread Jaehoon Chung
Hi, On 10/12/2015 01:29 PM, Krzysztof Kozlowski wrote: > On 12.10.2015 00:46, Anand Moon wrote: >> From: Jaehoon Chung <jh80.ch...@samsung.com> >> >> To detect sd-card use the cd-gpio method. >> It can decrease the interrupt for detecting sd-card. >> &

Re: [RFC PATCH v8 0/10] Add external dma support for Synopsys MSHC

2015-10-04 Thread Jaehoon Chung
Hi, Shawn. On 10/02/2015 06:49 PM, Shawn Lin wrote: > On 2015/10/1 17:14, Jaehoon Chung wrote: >> Dear, All. >> >> I will apply patch 01-03 at my repository on today. >> But i don't know better how i do about other patches relevant to config file. >> > > Th

Re: [RFC PATCH v8 0/10] Add external dma support for Synopsys MSHC

2015-10-01 Thread Jaehoon Chung
Dear, All. I will apply patch 01-03 at my repository on today. But i don't know better how i do about other patches relevant to config file. Best Regards, Jaehoon Chung On 09/16/2015 03:40 PM, Shawn Lin wrote: > Synopsys DesignWare mobile storage host controller supports three >

Re: [RFC PATCH v7 01/10] mmc: dw_mmc: Add external dma interface support

2015-09-15 Thread Jaehoon Chung
goto no_dma; > } > > /* Determine which DMA interface to use */ > -#ifdef CONFIG_MMC_DW_IDMAC > - host->dma_ops = _mci_idmac_ops; > - dev_info(host->dev, "Using internal DMA controller.\n"); > -#endif > + if (trans_mo

Re: [PATCH] ARM: dts: use vqmmc-supply of emmc/sd for exynos4412-odroid-common

2015-08-27 Thread Jaehoon Chung
On 08/27/2015 09:26 PM, Krzysztof Kozlowski wrote: W dniu 27.08.2015 o 18:29, Jaehoon Chung pisze: Currently vmmc's property is wrong. If it needs to control two supplies, then it has to use vmmc/vqmmc-supply. (Card supply power and I/O Line supply Power.) Signed-off-by: Jaehoon Chung jh80

[PATCH] ARM: dts: use vqmmc-supply of emmc/sd for exynos4412-odroid-common

2015-08-27 Thread Jaehoon Chung
Currently vmmc's property is wrong. If it needs to control two supplies, then it has to use vmmc/vqmmc-supply. (Card supply power and I/O Line supply Power.) Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com --- arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 7 --- 1 file changed, 4

Re: [RFC PATCH v6 1/9] mmc: dw_mmc: Add external dma interface support

2015-08-21 Thread Jaehoon Chung
On 08/21/2015 03:30 PM, Shawn Lin wrote: On 2015/8/21 14:27, Jaehoon Chung wrote: Hi, Shawn. Is this based on Ulf's repository? no, it's based on https://github.com/jh80chung/dw-mmc.git tags/dw-mmc-for-ulf-v4.2 :) Oh..I will rebase to Ulf's next branch on this weekend. Then could you

Re: [RFC PATCH v6 1/9] mmc: dw_mmc: Add external dma interface support

2015-08-21 Thread Jaehoon Chung
On 08/21/2015 04:27 PM, Shawn Lin wrote: On 2015/8/21 14:35, Jaehoon Chung wrote: On 08/21/2015 03:30 PM, Shawn Lin wrote: On 2015/8/21 14:27, Jaehoon Chung wrote: Hi, Shawn. Is this based on Ulf's repository? no, it's based on https://github.com/jh80chung/dw-mmc.git tags/dw-mmc-for-ulf

Re: [RFC PATCH v6 1/9] mmc: dw_mmc: Add external dma interface support

2015-08-21 Thread Jaehoon Chung
*/ + struct dw_mci_dma_slave *dms; + /* Registers's physical base address */ + void*phy_regs; + struct dw_mci_dma_data *dma_data; -#endif + On ulf's repository, this point should be conflicted. Best Regards, Jaehoon Chung u32

Re: [RFC PATCH v4 0/9]

2015-08-06 Thread Jaehoon Chung
Hi, Shawn. I remembered that Krzysztof has mentioned Fix the title of cover letter. Your cover letter's title is nothing.. [RFC PATCH v4 0/9] ?? [RFC PATCH v4 0/9] your title... Best Regards, Jaehoon Chung On 08/06/2015 03:44 PM, Shawn Lin wrote: Add external dma support for Synopsys MSHC

Re: [RFC PATCH v4 0/9]

2015-08-06 Thread Jaehoon Chung
On 08/06/2015 04:31 PM, Shawn Lin wrote: 在 2015/8/6 15:08, Jaehoon Chung 写道: Hi, Shawn. I remembered that Krzysztof has mentioned Fix the title of cover letter. Your cover letter's title is nothing.. [RFC PATCH v4 0/9] ?? [RFC PATCH v4 0/9] your title... Sorry, I forgot it, and will fix

Re: [PATCH 1/1] ARM: dts: Add HS400 support for exynos5422-odroidxu3

2015-04-07 Thread Jaehoon Chung
Hi, Markus. I have also tested on Odroid-xu3 board. Acked-by: Jaehoon Chung jh80.ch...@samsung.com Best Regards, Jaehoon Chung On 04/08/2015 12:33 AM, Markus Reichl wrote: Hi, the base patch in [0] has been applied now. My patch was meanwhile Tested-by: Anand Moon linux.am

Re: [PATCH ulf.hansson-mmc] mmc: dw_mmc: exynos: dw_mci_exynos_prepare_hs400_tuning() can be static

2015-03-05 Thread Jaehoon Chung
Hi, Sorry for missing warning, and Thanks for pointing out. Best Regards, Jaehoon Chung On 03/05/2015 07:02 PM, kbuild test robot wrote: Signed-off-by: Fengguang Wu fengguang...@intel.com --- dw_mmc-exynos.c |2 +- dw_mmc.c|2 +- 2 files changed, 2 insertions(+), 2

Re: [PATCH V5 1/2] mmc: dw_mmc: exynos: Support eMMC's HS400 mode

2015-02-24 Thread Jaehoon Chung
Hi, Alim. Tested-by: Jaehoon Chung jh80.ch...@samsung.com Acked-by: Jaehoon Chung jh80.ch...@samsung.com I will include this patch into my tree, and i will request pull to Ulf. Thanks! Best Regards, Jaehoon Chung On 01/29/2015 11:41 AM, Alim Akhtar wrote: From: Seungwon Jeon tgih

Re: [PATCH V5 2/2] ARM: dts: Add HS400 support for exynos5420 and exynos5800

2015-02-24 Thread Jaehoon Chung
Hi, Alim. Acked-by: Jaehoon Chung jh80.ch...@samsung.com Best Regards, Jaehoon Chung On 01/29/2015 11:41 AM, Alim Akhtar wrote: From: Seungwon Jeon tgih@samsung.com HS400 timing values are added for SMDK5420, exynos5420-peach-pit and exynos5800-peach-pi boards. This also adds RCLK

Re: [PATCH v5 0/2] mmc: dw_mmc: exynos: Add HS400 support

2015-02-05 Thread Jaehoon Chung
Hi, Vivek. On 02/06/2015 02:52 PM, Vivek Gautam wrote: Hi Jaehoon, On Fri, Feb 6, 2015 at 6:48 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, Alim. On my board, this patch isn't working fine. So when i complete to test on my board(exynos5), i will reply with comments. Sorry

Re: [PATCH v5 0/2] mmc: dw_mmc: exynos: Add HS400 support

2015-02-05 Thread Jaehoon Chung
Hi, Alim. On my board, this patch isn't working fine. So when i complete to test on my board(exynos5), i will reply with comments. Sorry for late testing. Best Regards, Jaehoon Chung On 01/29/2015 11:41 AM, Alim Akhtar wrote: This adds HS400 mode support for exynos dw_mmc host controller

Re: [PATCH 1/2] mmc: dw_mmc-exynos: add support for controlling emmc reset pin

2015-01-27 Thread Jaehoon Chung
. But i think it can be called at reboot time. (it needs to implement codes.) how about? Best Regards, Jaehoon Chung Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- .../devicetree/bindings/mmc/exynos-dw-mshc.txt | 6 +++ drivers/mmc/host/dw_mmc-exynos.c

Re: [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420

2015-01-25 Thread Jaehoon Chung
file In that case I completely agree that it should be defined in the .dtsi but that is not what the commit message said though :-) I will resend the patch with obvious commit message. Thanks for review. Best Regards, Jaehoon Chung Best regards, Javier -- To unsubscribe from this list

[PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420

2015-01-23 Thread Jaehoon Chung
Add sd0_rst node to exynos5420-pinctrl.dtsi. (It's used on odroid-xu3 board) Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com --- arch/arm/boot/dts/exynos5420-pinctrl.dtsi |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot

Re: [PATCH v4 2/2] ARM: dts: Add HS400 support for exynos5420 and exynos5800

2015-01-21 Thread Jaehoon Chung
Hi. On 01/21/2015 11:12 PM, Alim Akhtar wrote: Hi Jaehoon On Wed, Jan 21, 2015 at 4:32 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, If you want to enable the hs400 mode, need to add mmc-hs400-1_8v or mmc-hs400-1_2v. But this patch didn't add them. do you have any other plan

Re: [PATCH v4 2/2] ARM: dts: Add HS400 support for exynos5420 and exynos5800

2015-01-20 Thread Jaehoon Chung
; }; + sd0_rclk: sd0-rclk { I know it used to sd0_rdqs, not sd0_rclk. Change name. Best Regards, Jaehoon Chung + samsung,pins = gpc0-7; + samsung,pin-function = 2; + samsung,pin-pud = 1; + samsung,pin-drv = 3

Re: [PATCH v4 1/2] mmc: dw_mmc: exynos: Support eMMC's HS400 mode

2015-01-20 Thread Jaehoon Chung
to 1? Best Regards, Jaehoon Chung host-priv = priv; return 0; } @@ -285,7 +388,7 @@ static inline void dw_mci_exynos_set_clksmpl(struct dw_mci *host, u8 sample) clksel = mci_readl(host, CLKSEL64); else clksel = mci_readl(host, CLKSEL

Re: [PATCH v4 0/2] mmc: dw_mmc: exynos: Add HS400 support

2015-01-14 Thread Jaehoon Chung
platform which supports emmc5.0 I will test this patch on exynos5/7 board. Best Regards, Jaehoon Chung Changes in V4: * drop the idea of changing existing binding for ciu_div as per [1] * addressed comments from Jaehoon Chung [2] [1] http://www.spinics.net/lists/linux-samsung-soc

Re: [PATCH v3 2/4] mmc: dw_mmc: exynos: support eMMC's HS400 mode

2015-01-07 Thread Jaehoon Chung
this bit and comment..where? + +/* Delay Line Control defines */ +#define DQS_CTRL_RD_DELAY(x, y) (((x) ~0x3FF) | ((y) 0x3FF)) I'm not understanding this define... clear and set? Best Regards, Jaehoon Chung +#define DQS_CTRL_GET_RD_DELAY(x) ((x) 0x3FF) + /* Protector

Re: [PATCH] mmc: dw_mmc: exynos: Add support for exynos7

2014-11-11 Thread Jaehoon Chung
Hi, Alim. I have also tested this patch with my board. It's working fine. Looks good to me. Dear, Ulf. Could you merge this patch at your repository? Acked-by: Jaehoon Chung jh80.ch...@samsung.com Best Regards, Jaehoon Chung On 11/11/2014 11:14 PM, Alim Akhtar wrote: Hi Jaehoon, As 64bit

Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board

2014-10-07 Thread Jaehoon Chung
? Is arndale-octa board the same circuit with peach? If it's same, I think Doug's comment is right. But if card-detect pis is used with other power, we don't need to consider the VDDQ_MMC2 power domain. It needs more information and checks its schematic. Best Regards, Jaehoon Chung -Doug

Re: [PATCH V2 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-09-29 Thread Jaehoon Chung
and card's value? Could you share the value? Best Regards, Jaehoon Chung Without the patch: [ 10.866926] mmc_host mmc1: Bus speed (slot 0) = 5000Hz (slot req 5000Hz, actual 5000HZ div = 0) [ 10.866977] mmc1: new high speed SDHC card at address 1234 [ 10.868730] mmcblk1

Re: [PATCH] mmc: dw_mmc: exynos: Add support for exynos7

2014-08-29 Thread Jaehoon Chung
offset on exynos7. If support the 64bit, dw-mmc.c need to modify.(according to v2.70, some offset is changed for 64-bit address) But i didn't see any patches at mailing. Do you have the plan which send patch of dw-mmc.c? Best Regards, Jaehoon Chung Signed-off-by: Abhilash Kesavan a.kesa

Re: [PATCH V2 3/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-08-28 Thread Jaehoon Chung
On 08/28/2014 12:49 AM, Doug Anderson wrote: Jaehoon, On Tue, Aug 26, 2014 at 9:47 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: Doug, On 08/27/2014 01:14 PM, Doug Anderson wrote: Jaehoon, On Tue, Aug 26, 2014 at 8:48 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, Doug, On 08

Re: [PATCHv10 0/5] ARM: remove the sub-node and deprecate supports-highspeed property for dwmmc.

2014-08-26 Thread Jaehoon Chung
by other mmc developers and maintainers. At first time, I had also suggested same opinion with yours. Refer to below.. https://patchwork.kernel.org/patch/4276481/ Best Regards, Jaehoon Chung Pavel -- To unsubscribe from

Re: [PATCH V2 3/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-08-26 Thread Jaehoon Chung
Hi, Doug, On 08/26/2014 12:25 AM, Doug Anderson wrote: Jaehoon, On Mon, Aug 25, 2014 at 1:50 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: On 08/25/2014 05:13 PM, Ulf Hansson wrote: On 22 August 2014 20:27, Sonny Rao sonny...@chromium.org wrote: On Fri, Aug 22, 2014 at 8:31 AM, Ulf

Re: [PATCH V2 3/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-08-26 Thread Jaehoon Chung
fine with the slot-gpio API. Best Regards, Jaehoon Chung The voltage domain of the card detect pin on the SoC is vqmmc, right? That means that you won't be able to read the pin without turning on vqmmc. Even if you could read the pin without turning on vqmmc, the pullup on this line

Re: [PATCH V2 3/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-08-26 Thread Jaehoon Chung
Doug, On 08/27/2014 01:14 PM, Doug Anderson wrote: Jaehoon, On Tue, Aug 26, 2014 at 8:48 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, Doug, On 08/26/2014 12:25 AM, Doug Anderson wrote: Jaehoon, On Mon, Aug 25, 2014 at 1:50 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: On 08

Re: [PATCH V2 3/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-08-25 Thread Jaehoon Chung
with Ulf's opinion. Best Regards, Jaehoon Chung Kind regards Uffe -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv10 0/5] ARM: remove the sub-node and deprecate supports-highspeed property for dwmmc.

2014-08-25 Thread Jaehoon Chung
On 08/25/2014 08:21 PM, Pavel Machek wrote: On Thu 2014-08-07 16:37:57, Jaehoon Chung wrote: Since used the mmc_of_parse(), didn't parse the sub-node. So we can remove the sub-node, because almost SoC used the only one card per a host. And supports-highspeed can be replaced with cap-mmc/sd

Re: [PATCHv10 0/5] ARM: remove the sub-node and deprecate supports-highspeed property for dwmmc.

2014-08-25 Thread Jaehoon Chung
On 08/25/2014 08:37 PM, Pavel Machek wrote: On Mon 2014-08-25 20:28:21, Jaehoon Chung wrote: On 08/25/2014 08:21 PM, Pavel Machek wrote: On Thu 2014-08-07 16:37:57, Jaehoon Chung wrote: Since used the mmc_of_parse(), didn't parse the sub-node. So we can remove the sub-node, because almost SoC

Re: [PATCHv10 0/5] ARM: remove the sub-node and deprecate supports-highspeed property for dwmmc.

2014-08-25 Thread Jaehoon Chung
On 08/25/2014 09:09 PM, Jaehoon Chung wrote: On 08/25/2014 08:37 PM, Pavel Machek wrote: On Mon 2014-08-25 20:28:21, Jaehoon Chung wrote: On 08/25/2014 08:21 PM, Pavel Machek wrote: On Thu 2014-08-07 16:37:57, Jaehoon Chung wrote: Since used the mmc_of_parse(), didn't parse the sub-node. So

Re: [PATCH V2 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-08-25 Thread Jaehoon Chung
) { Can't use the regulator_is_enabled() instead of slot-host-vqmmc_enabled? Best Regards, Jaehoon Chung + ret = regulator_enable(mmc-supply.vqmmc); + if (ret 0) + dev_err(slot-host-dev

Re: [PATCHv10 3/5] ARM: dts: exynos: unuse the slot-node and deprecate the supports-highspeed for dw-mmc

2014-08-18 Thread Jaehoon Chung
Hi, Kukjin. Socfpga and Rockchip were queued into each SoC tree. I want to know whether this patch is queued or not into Samsung-Soc tree. Do you have any other plan for this patch? Best Regards, Jaehoon Chung On 08/07/2014 04:38 PM, Jaehoon Chung wrote: dw-mmc controller can support multiple

Re: [PATCHv10 3/5] ARM: dts: exynos: unuse the slot-node and deprecate the supports-highspeed for dw-mmc

2014-08-18 Thread Jaehoon Chung
Hi, Kukjin On 08/19/2014 01:54 AM, Kukjin Kim wrote: On 08/18/14 09:10, Andreas Färber wrote: Hi Jaehoon, Am 18.08.2014 14:23, schrieb Jaehoon Chung: Socfpga and Rockchip were queued into each SoC tree. I want to know whether this patch is queued or not into Samsung-Soc tree. Do you have

Re: [PATCH v2] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-08-13 Thread Jaehoon Chung
apply this one now, too? Do you want me to repost? It's good that it will be merged with it. Best Regards, Jaehoon Chung -Doug -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http

[PATCHv10 0/5] ARM: remove the sub-node and deprecate supports-highspeed property for dwmmc.

2014-08-07 Thread Jaehoon Chung
. - Use the slot-host-quirks instead of brq-quirks. - Add tested-by and reviewd-by. Changelog V2: - Add the mmc: dw_mmc: replace disable-wp from slot's quirks to host's quirk Jaehoon Chung (5): mmc: dw_mmc: Slot quirk disable-wp is deprecated. mmc: dw_mmc: modify the dt-binding

[PATCHv10 1/5] mmc: dw_mmc: Slot quirk disable-wp is deprecated.

2014-08-07 Thread Jaehoon Chung
Slot quirks disable-wp is deprecated. Instead, use the host quirk disable-wp. (Because the slot-node is removed in dt-file.) Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Tested-by: Sachin Kamat sachin.ka...@samsung.com Acked-by: Seungwon Jeon tgih@samsung.com Reviewed-by: Doug Anderson

[PATCHv10 2/5] mmc: dw_mmc: modify the dt-binding for removing slot-node and supports-highspeed

2014-08-07 Thread Jaehoon Chung
Almost all SoCs use one slot per host controller. (Even if controller can support the multiple slot, Recommend to use one slot per host controller.) Don't use the slot-node and deprecate the supports-highspeed property. Instead, use the cap-mmc/sd-highspeed. Signed-off-by: Jaehoon Chung jh80.ch

[PATCHv10 4/5] ARM: dts: socfpga: unuse the slot-node and deprecate the supports-highspeed for dw-mmc

2014-08-07 Thread Jaehoon Chung
-by: Jaehoon Chung jh80.ch...@samsung.com Reviewed-by: Tushar Behera trbli...@gmail.com Reviewed-by: Ulf Hansson ulf.hans...@linaro.org Acked-by: Seungwon Jeon tgih@samsung.com Acked-by: Dinh Nguyen dingu...@altera.com --- arch/arm/boot/dts/socfpga_arria5.dtsi |9 +++-- arch/arm/boot/dts

[PATCHv10 5/5] ARM: dts: rockchip: unuse the slot-node and deprecate the supports-highspeed for dw-mmc

2014-08-07 Thread Jaehoon Chung
-by: Jaehoon Chung jh80.ch...@samsung.com Reviewed-by: Tushar Behera trbli...@gmail.com Reviewed-by: Ulf Hansson ulf.hans...@linaro.org Reviewed-by: Heiko Stuebner he...@sntech.de Acked-by: Seungwon Jeon tgih@samsung.com --- arch/arm/boot/dts/rk3066a-bqcurie2.dts | 15 --- arch/arm/boot/dts

[PATCHv10 3/5] ARM: dts: exynos: unuse the slot-node and deprecate the supports-highspeed for dw-mmc

2014-08-07 Thread Jaehoon Chung
-by: Jaehoon Chung jh80.ch...@samsung.com Reviewed-by: Tushar Behera trbli...@gmail.com Reviewed-by: Ulf Hansson ulf.hans...@linaro.org Tested-by: Sachin Kamat sachin.ka...@samsung.com --- arch/arm/boot/dts/exynos4412-odroid-common.dtsi |8 ++-- arch/arm/boot/dts/exynos4412-origen.dts |8

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-08-07 Thread Jaehoon Chung
Hi, I remembered that this patch was pushed at Ulf's tree. Since dw_mci_idmac_reset() is located into #if CONFIG_MMC_DW_IDMAC, it occurred the compiler error. And it seems that didn't need to use IS_ENABLED() at there. Acked-by: Jaehoon Chung jh80.ch...@samsung.com Best Regards, Jaehoon Chung

Re: [PATCHv9 1/5] mmc: dw_mmc: Slot quirk disable-wp is deprecated.

2014-07-31 Thread Jaehoon Chung
about? And I want to know who can apply this patch-set(#3~#5). Best Regards, Jaehoon Chung On 08/01/2014 03:36 AM, Kukjin Kim wrote: On 08/01/14 01:02, Doug Anderson wrote: Jaehoon On Wed, Jul 30, 2014 at 10:35 PM, Jaehoon Chungjh80.ch...@samsung.com wrote: Slot quirks disable-wp

[PATCHv8 2/5] ARM: dts: exynos: unuse the slot-node and deprecated the supports-highspeed for dw-mmc

2014-07-30 Thread Jaehoon Chung
dw-mmc controller can support multiple slots. But, there are no use-cases anywhere. So we don't need to support the slot-node for dw-mmc controller. And supports-highspeed property in dw-mmc is deprecated. supports-highspeed property can be replaced to cap-sd/mmc-highspeed. Signed-off-by: Jaehoon

[PATCHv8 3/5] ARM: dts: socfpga: unuse the slot-node and deprecated the supports-highspeed for dw-mmc

2014-07-30 Thread Jaehoon Chung
dw-mmc controller can support multiple slots. But, there are no use-cases anywhere. So we don't need to support the slot-node for dw-mmc controller. And supports-highspeed property in dw-mmc is deprecated. supports-highspeed property can be replaced to cap-sd/mmc-highspeed. Signed-off-by: Jaehoon

[PATCHv8 5/5] mmc: dw_mmc: replace disable-wp from slot's quirk to host's quirk

2014-07-30 Thread Jaehoon Chung
Replaced the disable-wp into host's quirks. (Because the slot-node is removed at dt-file.) Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Tested-by: Sachin Kamat sachin.ka...@samsung.com Acked-by: Seungwon Jeon tgih@samsung.com --- drivers/mmc/host/dw_mmc.c |8 +++- include

[PATCHv8 4/5] ARM: dts: rockchip: unuse the slot-node and deprecated the supports-highspeed for dw-mmc

2014-07-30 Thread Jaehoon Chung
dw-mmc controller can support multiple slots. But, there are no use-cases anywhere. So we don't need to support the slot-node for dw-mmc controller. And supports-highspeed property in dw-mmc is deprecated. supports-highspeed property can be replaced to cap-sd/mmc-highspeed. Signed-off-by: Jaehoon

[PATCHv8 0/5] ARM: remove the sub-node and deprecate supports-highspeed property for dwmmc.

2014-07-30 Thread Jaehoon Chung
quirk Jaehoon Chung (5): mmc: dw_mmc: modify the dt-binding for removing slot-node and supports-highspeed ARM: dts: exynos: unuse the slot-node and deprecated the supports-highspeed for dw-mmc ARM: dts: socfpga: unuse the slot-node and deprecated the supports-highspeed for dw-mmc

[PATCHv8 1/5] mmc: dw_mmc: modify the dt-binding for removing slot-node and supports-highspeed

2014-07-30 Thread Jaehoon Chung
Almost SoCs use one slot per host controller. (Even if controller can support the multiple slot, Recommend to use one slot per host controller.) Don't use the slot-node and deprecate the supports-highspeed property. Instead, use the cap-mmc/sd-highspeed. Signed-off-by: Jaehoon Chung jh80.ch

[PATCHv9 5/5] ARM: dts: rockchip: unuse the slot-node and deprecate the supports-highspeed for dw-mmc

2014-07-30 Thread Jaehoon Chung
-by: Jaehoon Chung jh80.ch...@samsung.com Reviewed-by: Tushar Behera trbli...@gmail.com Reviewed-by: Ulf Hansson ulf.hans...@linaro.org Reviewed-by: Heiko Stuebner he...@sntech.de Acked-by: Seungwon Jeon tgih@samsung.com --- arch/arm/boot/dts/rk3066a-bqcurie2.dts | 16 1 file changed

[PATCHv9 4/5] ARM: dts: socfpga: unuse the slot-node and deprecate the supports-highspeed for dw-mmc

2014-07-30 Thread Jaehoon Chung
-by: Jaehoon Chung jh80.ch...@samsung.com Reviewed-by: Tushar Behera trbli...@gmail.com Reviewed-by: Ulf Hansson ulf.hans...@linaro.org Acked-by: Seungwon Jeon tgih@samsung.com Acked-by: Dinh Nguyen dingu...@altera.com --- arch/arm/boot/dts/socfpga_arria5.dtsi |9 +++-- arch/arm/boot/dts

[PATCHv9 3/5] ARM: dts: exynos: unuse the slot-node and deprecate the supports-highspeed for dw-mmc

2014-07-30 Thread Jaehoon Chung
-by: Jaehoon Chung jh80.ch...@samsung.com Reviewed-by: Tushar Behera trbli...@gmail.com Reviewed-by: Ulf Hansson ulf.hans...@linaro.org Tested-by: Sachin Kamat sachin.ka...@samsung.com Acked-by: Seungwon Jeon tgih@samsung.com Acked-by: Kukjin Kim kgene@samsung.com --- arch/arm/boot/dts/exynos4412

[PATCHv9 1/5] mmc: dw_mmc: Slot quirk disable-wp is deprecated.

2014-07-30 Thread Jaehoon Chung
Slot quirks disable-wp is deprecated. Instead, use the host quirk disable-wp. (Because the slot-node is removed in dt-file.) Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Tested-by: Sachin Kamat sachin.ka...@samsung.com Acked-by: Seungwon Jeon tgih@samsung.com --- drivers/mmc/host

[PATCHv9 0/5] ARM: remove the sub-node and deprecate supports-highspeed property for dwmmc.

2014-07-30 Thread Jaehoon Chung
-by and reviewd-by. Changelog V2: - Add the mmc: dw_mmc: replace disable-wp from slot's quirks to host's quirk Jaehoon Chung (5): mmc: dw_mmc: Slot quirk disable-wp is deprecated. mmc: dw_mmc: modify the dt-binding for removing slot-node and supports-highspeed ARM: dts: exynos

Re: [PATCHv7 5/5] mmc: dw_mmc: replace disable-wp from slot's quirk to host's quirk

2014-07-29 Thread Jaehoon Chung
Hi, Doug. Thanks for review. On 07/30/2014 03:01 AM, Doug Anderson wrote: Jaehoon, On Sun, Jul 27, 2014 at 7:29 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: Replaced the disable-wp into host's quirks. (Because the slot-node is removed at dt-file.) Signed-off-by: Jaehoon Chung jh80.ch

Re: [PATCHv6 1/5] mmc: dw_mmc: modify the dt-binding for removing slot-node and supports-highspeed

2014-07-27 Thread Jaehoon Chung
Hi, Andreas, On 07/25/2014 09:11 PM, Andreas Färber wrote: Hi Jaehoon, Am 25.07.2014 03:11, schrieb Jaehoon Chung: Almost Soc is used the slot per a host. Something's very wrong with this sentence. What are you trying to say? Almost all SoCs use one slot only per host controller device

[PATCHv7 3/5] ARM: dts: socfpga: unuse the slot-node and deprecated the supports-highspeed for dw-mmc

2014-07-27 Thread Jaehoon Chung
dw-mmc controller can support multiple slots. But, there are no use-cases anywhere. So we don't need to support the slot-node for dw-mmc controller. And supports-highspeed property in dw-mmc is deprecated. supports-highspeed property can be replaced to cap-sd/mmc-highspeed. Signed-off-by: Jaehoon

[PATCHv7 4/5] ARM: dts: rockchip: unuse the slot-node and deprecated the supports-highspeed for dw-mmc

2014-07-27 Thread Jaehoon Chung
dw-mmc controller can support multiple slots. But, there are no use-cases anywhere. So we don't need to support the slot-node for dw-mmc controller. And supports-highspeed property in dw-mmc is deprecated. supports-highspeed property can be replaced to cap-sd/mmc-highspeed. Signed-off-by: Jaehoon

[PATCHv7 1/5] mmc: dw_mmc: modify the dt-binding for removing slot-node and supports-highspeed

2014-07-27 Thread Jaehoon Chung
Almost SoCs use one slot per host controller. (Even if controller can support the multiple slot, Recommend to use one slot per host controller.) Don't use the slot-node and deprecate the supports-highspeed property. Instead, use the cap-mmc/sd-highspeed. Signed-off-by: Jaehoon Chung jh80.ch

[PATCHv7 0/5] ARM: remove the sub-node and deprecate supports-highspeed property for dwmmc.

2014-07-27 Thread Jaehoon Chung
. - Use the slot-host-quirks instead of brq-quirks. - Add tested-by and reviewd-by. Changelog V2: - Add the mmc: dw_mmc: replace disable-wp from slot's quirks to host's quirk Jaehoon Chung (5): mmc: dw_mmc: modify the dt-binding for removing slot-node and supports-highspeed

[PATCHv7 2/5] ARM: dts: exynos: unuse the slot-node and deprecated the supports-highspeed for dw-mmc

2014-07-27 Thread Jaehoon Chung
dw-mmc controller can support multiple slots. But, there are no use-cases anywhere. So we don't need to support the slot-node for dw-mmc controller. And supports-highspeed property in dw-mmc is deprecated. supports-highspeed property can be replaced to cap-sd/mmc-highspeed. Signed-off-by: Jaehoon

[PATCHv7 5/5] mmc: dw_mmc: replace disable-wp from slot's quirk to host's quirk

2014-07-27 Thread Jaehoon Chung
Replaced the disable-wp into host's quirks. (Because the slot-node is removed at dt-file.) Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Tested-by: Sachin Kamat sachin.ka...@samsung.com Acked-by: Seungwon Jeon tgih@samsung.com --- drivers/mmc/host/dw_mmc.c | 12 +--- include

[PATCHv6 0/5] remove the sub-node and deprecated

2014-07-24 Thread Jaehoon Chung
-by and reviewd-by. Changelog V2: - Add the mmc: dw_mmc: replace disable-wp from slot's quirks to host's quirk Jaehoon Chung (5): mmc: dw_mmc: modify the dt-binding for removing slot-node and supports-highspeed ARM: dts: exynos: unuse the slot-node and deprecated the supports

[PATCHv6 1/5] mmc: dw_mmc: modify the dt-binding for removing slot-node and supports-highspeed

2014-07-24 Thread Jaehoon Chung
Almost Soc is used the slot per a host. Don't use the slot-node and deprecated the supports-highsped property. Instead, use the cap-mmc/sd-highspeed. Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Reviewed-by: Tushar Behera trbli...@gmail.com Reviewed-by: Ulf Hansson ulf.hans...@linaro.org

[PATCHv6 2/5] ARM: dts: exynos: unuse the slot-node and deprecated the supports-highspeed for dw-mmc

2014-07-24 Thread Jaehoon Chung
dw-mmc controller can support multiple slots. But, there are no use-cases anywhere. So we don't need to support the slot-node for dw-mmc controller. And supports-highspeed property in dw-mmc is deprecated. supports-highspeed property can be replaced to cap-sd/mmc-highspeed. Signed-off-by: Jaehoon

[PATCHv6 4/5] ARM: dts: rockchip: unuse the slot-node and deprecated the supports-highspeed for dw-mmc

2014-07-24 Thread Jaehoon Chung
dw-mmc controller can support multiple slots. But, there are no use-cases anywhere. So we don't need to support the slot-node for dw-mmc controller. And supports-highspeed property in dw-mmc is deprecated. supports-highspeed property can be replaced to cap-sd/mmc-highspeed. Signed-off-by: Jaehoon

[PATCHv6 5/5] mmc: dw_mmc: replace disable-wp from slot's quirk to host's quirk

2014-07-24 Thread Jaehoon Chung
Replaced the disable-wp into host's quirks. (Because the slot-node is removed at dt-file.) Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Tested-by: Sachin Kamat sachin.ka...@samsung.com Acked-by: Seungwon Jeon tgih@samsung.com --- drivers/mmc/host/dw_mmc.c | 12 +--- include

[PATCHv6 3/5] ARM: dts: socfpga: unuse the slot-node and deprecated the supports-highspeed for dw-mmc

2014-07-24 Thread Jaehoon Chung
dw-mmc controller can support multiple slots. But, there are no use-cases anywhere. So we don't need to support the slot-node for dw-mmc controller. And supports-highspeed property in dw-mmc is deprecated. supports-highspeed property can be replaced to cap-sd/mmc-highspeed. Signed-off-by: Jaehoon

Re: sdhci_s3c_consider_clock scheduling while atomic - clk_round_rate

2014-07-15 Thread Jaehoon Chung
also degraded the performance since add the overhead. I'm using clkgate-delay = 3 ~ 10. Anyway, we need to fix this. I will consider this. Best Regards, Jaehoon Chung On 06/25/2014 12:52 AM, Tomasz Figa wrote: Hi Daniel, [adding Ulf, Chris and Mike to the discussion] On 24.06.2014 11:48

Re: [PATCH 1/6] mmc: sdhci-s3c: Fix local I/O clock gating

2014-07-14 Thread Jaehoon Chung
Looks good to me. Acked-by: Jaehoon Chung jh80.ch...@samsung.com On 06/24/2014 10:57 PM, Tomasz Figa wrote: For internal card detection mechanism it is required that the local I/O clock is always running. However while current implementation accounts for this, it does so incorrectly leading

Re: [PATCHv5] mmc: dw_mmc: change to use recommended reset procedure

2014-07-13 Thread Jaehoon Chung
On 07/12/2014 05:53 AM, Sonny Rao wrote: This patch changes the fifo reset code to follow the reset procedure outlined in the documentation of Synopsys Mobile storage host databook. Signed-off-by: Sonny Rao sonny...@chromium.org Signed-off-by: Yuvaraj Kumar C D yuvaraj...@samsung.com ---

[PATCHv3 3/5] ARM: dts: socfpga: unuse the slot-node and deprecated the supports-highspeed for dw-mmc

2014-07-10 Thread Jaehoon Chung
dw-mmc controller can support multiple slots. But, there are no use-cases anywhere. So we don't need to support the slot-node for dw-mmc controller. And supports-highspeed property in dw-mmc is deprecated. supports-highspeed property can be replaced to cap-sd/mmc-highspeed. Signed-off-by: Jaehoon

[PATCHv3 4/5] ARM: dts: rockchip: unuse the slot-node and deprecated the supports-highspeed for dw-mmc

2014-07-10 Thread Jaehoon Chung
dw-mmc controller can support multiple slots. But, there are no use-cases anywhere. So we don't need to support the slot-node for dw-mmc controller. And supports-highspeed property in dw-mmc is deprecated. supports-highspeed property can be replaced to cap-sd/mmc-highspeed. Signed-off-by: Jaehoon

[PATCHv3 2/5] ARM: dts: exynos: unuse the slot-node and deprecated the supports-highspeed for dw-mmc

2014-07-10 Thread Jaehoon Chung
dw-mmc controller can support multiple slots. But, there are no use-cases anywhere. So we don't need to support the slot-node for dw-mmc controller. And supports-highspeed property in dw-mmc is deprecated. supports-highspeed property can be replaced to cap-sd/mmc-highspeed. Signed-off-by: Jaehoon

[PATCHv3 5/5] mmc: dw_mmc: replace disable-wp from slot's quirk to host's quirk

2014-07-10 Thread Jaehoon Chung
Replaced the disable-wp into host's quirks. (Because the slot-node is removed at dt-file.) Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com --- drivers/mmc/host/dw_mmc.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc

[PATCHv3 0/5] ARM: remove the sub-node and deprecated supports-highspeed property for dwmmc.

2014-07-10 Thread Jaehoon Chung
-host-quirks instead of brq-quirks. - Add tested-by and reviewd-by. Changelog V2: - Add the mmc: dw_mmc: replace disable-wp from slot's quirks to host's quirk Jaehoon Chung (5): mmc: dw_mmc: modify the dt-binding for removing slot-node and supports-highspeed ARM: dts: exynos

Re: [PATCHv3 5/5] mmc: dw_mmc: replace disable-wp from slot's quirk to host's quirk

2014-07-10 Thread Jaehoon Chung
Hi, Ulf. On 07/10/2014 06:15 PM, Ulf Hansson wrote: On 10 July 2014 09:08, Jaehoon Chung jh80.ch...@samsung.com wrote: Replaced the disable-wp into host's quirks. (Because the slot-node is removed at dt-file.) Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Hi Jaehoon, I plan

[PATCHv4 1/5] mmc: dw_mmc: modify the dt-binding for removing slot-node and supports-highspeed

2014-07-10 Thread Jaehoon Chung
Almost Soc is used the slot per a host. Don't use the slot-node and deprecated the supports-highsped property. Instead, use the cap-mmc/sd-highspeed. Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Reviewed-by: Tushar Behera trbli...@gmail.com Reviewed-by: Ulf Hansson ulf.hans...@linaro.org

[PATCHv4 0/5] ARM: remove the sub-node and deprecated supports-highspeed property for dwmmc.

2014-07-10 Thread Jaehoon Chung
the wrong bus-width value. - Use the slot-host-quirks instead of brq-quirks. - Add tested-by and reviewd-by. Changelog V2: - Add the mmc: dw_mmc: replace disable-wp from slot's quirks to host's quirk Jaehoon Chung (5): mmc: dw_mmc: modify the dt-binding for removing slot

[PATCHv4 3/5] ARM: dts: socfpga: unuse the slot-node and deprecated the supports-highspeed for dw-mmc

2014-07-10 Thread Jaehoon Chung
dw-mmc controller can support multiple slots. But, there are no use-cases anywhere. So we don't need to support the slot-node for dw-mmc controller. And supports-highspeed property in dw-mmc is deprecated. supports-highspeed property can be replaced to cap-sd/mmc-highspeed. Signed-off-by: Jaehoon

  1   2   3   >