Re: [PATCH] Asoc: Samsung: I2S: Add support for runtime S2R

2013-01-30 Thread Mark Brown
On Wed, Jan 30, 2013 at 05:41:04PM +0530, R. Chandrasekar wrote: From: R. Chandrasekar rcse...@samsung.com This patch adds runtime suspend to resume support for I2S. I2S clk is disabled at suspend and enabled at resume. Applied, thanks. Please use subject lines appropriate to the subsystem

Re: [PATCH V6 04/10] spi: s3c64xx: Modify SPI driver to use generic DMA DT support

2013-01-28 Thread Mark Brown
On Fri, Jan 18, 2013 at 05:17:03PM +0530, Padmavathi Venna wrote: This patch modifies the SPI driver to use generic dma dt bindings support. This passes all the required arguments to dma dev request functon which in turn calls the dma_request_slave_channel or dma__ request_channel based on DT

Re: [PATCH V6 03/10] ARM: SAMSUNG: Make dma request compatible to generic dma bindings.

2013-01-28 Thread Mark Brown
On Fri, Jan 18, 2013 at 05:17:02PM +0530, Padmavathi Venna wrote: This patch make the dma dev request operation compatible for both DT and non-DT cases. It takes the all the arguments required for dma_request_slave_channel and dma_request_channel. If the driver is initiated via DT or non-DT

Re: [PATCH V6 07/10] ASoC: SMDK: WM8994: Add device tree support for machine file

2013-01-28 Thread Mark Brown
On Fri, Jan 18, 2013 at 05:17:06PM +0530, Padmavathi Venna wrote: +Samsung SMDK audio complex This is just for SMDKs with WM8994. I'll apply but please send a followup patch to clarify this - it'll be a different binding for others like the older boards using WM8580 and WM9713. +

Re: [PATCH V6 08/10] ARM: dts: Modify SPI nodes according generic DMA DT bindings

2013-01-28 Thread Mark Brown
On Fri, Jan 18, 2013 at 05:17:07PM +0530, Padmavathi Venna wrote: This patch removes custom way of adding spi dma channels and adds according to new generic DMA DT bindings. Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH V6 09/10] ASoC: Samsung: Update Kconfig for I2S,SPDIF and PCM audio

2013-01-28 Thread Mark Brown
On Fri, Jan 18, 2013 at 05:17:08PM +0530, Padmavathi Venna wrote: Update Kconfig file to enable I2S,PCM audio for wm8994 and spdif on all samsung platforms. Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH V6 10/10] dmaengine: Fix compilation error in non-DT case

2013-01-26 Thread Mark Brown
On Fri, Jan 18, 2013 at 05:17:09PM +0530, Padmavathi Venna wrote: Signed-off-by: Padmavathi Venna padm...@samsung.com This should be sent separately to Vinod for merge into v3.8, it's not obviously related to the rest of the series and is a bug fix. signature.asc Description: Digital signature

Re: [PATCH 1/2] i2c-core: Add gpio based bus arbitration implementation

2013-01-25 Thread Mark Brown
On Thu, Jan 24, 2013 at 12:39:48PM +0100, Wolfram Sang wrote: On Thu, Jan 24, 2013 at 07:18:47PM +0800, Mark Brown wrote: A read is typically implemented as a write of the register address followed by a read of the value, usually with the ability to free the bus in between. If two devices

Re: [PATCH] Asoc: Samsung: Add I2S S/W RST in startup function

2013-01-25 Thread Mark Brown
On Thu, Jan 24, 2013 at 06:05:31PM +0530, R. Chandrasekar wrote: From: Padmavathi Venna padm...@samsung.com I2S module need to be reset after S2R. Keeping the S/W rst control part in resume didn't help in playing audio after resume. So this patch adds S/W RST control part in startup function

Re: [PATCH] Asoc: Samsung: Add support for I2S runtime S2R

2013-01-25 Thread Mark Brown
On Thu, Jan 24, 2013 at 06:05:30PM +0530, R. Chandrasekar wrote: From: R. Chandrasekar rcse...@samsung.com This patch adds runtime suspend to resume support for I2S. Signed-off-by: Padmavathi Venna padm...@samsung.com Signed-off-by: R. Chandrasekar rcse...@samsung.com This is good but

Re: [PATCH 1/2] i2c-core: Add gpio based bus arbitration implementation

2013-01-24 Thread Mark Brown
On Thu, Jan 24, 2013 at 12:13:29PM +0100, Wolfram Sang wrote: On Sat, Dec 15, 2012 at 11:21:36PM +0900, Mark Brown wrote: also get things like read operations which appear as multiple transactions on the I2C bus so require something higher level than what multi-master provides. I don't

Re: [PATCH V6 01/10] ASoC: Samsung: Rename samsung i2s secondary device name

2013-01-23 Thread Mark Brown
On Fri, Jan 18, 2013 at 05:17:00PM +0530, Padmavathi Venna wrote: All Samsung SoCs has max 3 i2s controllers. So the i2s secondary fifo interface device id was named as samsung-i2s.4. Renaming this to samsung-i2s-sec to support device tree in i2s driver. Applied, thanks. signature.asc

[PATCH] ARM: S3C64XX: Fix up IRQ mapping for balblair on Cragganmore

2013-01-13 Thread Mark Brown
From: Dimitris Papastamos d...@opensource.wolfsonmicro.com We are using S3C_EINT(4) instead of S3C_EINT(5). Signed-off-by: Dimitris Papastamos d...@opensource.wolfsonmicro.com Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Cc: sta...@vger.kernel.org --- arch/arm/mach-s3c64xx/mach

Re: [RFC PATCH 5/7] ARM: s3c64xx: Add board file for boot using Device Tree

2013-01-10 Thread Mark Brown
On Thu, Jan 10, 2013 at 12:41:47AM +0100, Tomasz Figa wrote: + * The following lookup table is used to override device names when devices + * are registered from device tree. This is temporarily added to enable + * device tree support addition for the Exynos4 architecture. Cut'n'paste.

Re: [RFC PATCH 1/7] ARM: common: vic: Parse interrupt and resume masks from device tree

2013-01-10 Thread Mark Brown
On Thu, Jan 10, 2013 at 12:41:43AM +0100, Tomasz Figa wrote: +- interrupt-mask : Bit mask of valid interrupt sources (defaults to all valid) +- wakeup-mask : Bit mask of interrupt sources that can wake up the system + (defaults to all allowed) Should this really be configured in the VIC

Re: [RFC PATCH 3/7] ARM: s3c64xx: Add support for OF-based VIC initialization

2013-01-10 Thread Mark Brown
On Thu, Jan 10, 2013 at 12:41:45AM +0100, Tomasz Figa wrote: This patch modifies IRQ initialization code of S3C64xx to support Device Tree-based initialization of VICs. Reviewed-by: Mark Brown broo...@opensource.wolfsonmicro.com signature.asc Description: Digital signature

Re: [RFC PATCH 1/7] ARM: common: vic: Parse interrupt and resume masks from device tree

2013-01-10 Thread Mark Brown
On Thu, Jan 10, 2013 at 12:10:38PM +0100, Tomasz Figa wrote: This is not the runtime interrupt/wakeup mask, but a global mask of available interrupt/wakeup lines on particular platform, which still have to be configured and enabled appropriately by user. Ah, OK. Reviewed-by: Mark Brown

Re: [PATCH v4 14/19] ARM: remove unneeded vic.h includes

2013-01-04 Thread Mark Brown
On Thu, Jan 03, 2013 at 11:54:23AM -0600, Rob Herring wrote: From: Rob Herring rob.herr...@calxeda.com Numerous includes of asm/hardware/vic.h aren't needed, so remove them. Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com signature.asc Description: Digital signature

[PATCH] spi/s3c64xx: Complain if we fail to set a transfer speed

2013-01-04 Thread Mark Brown
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- drivers/spi/spi-s3c64xx.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index ad93231..6495352 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c

Re: [PATCH V5 2/2] ASoC: SAMSUNG: Add DT support for i2s

2012-12-27 Thread Mark Brown
On Wed, Dec 26, 2012 at 04:21:58PM +0530, Padma Venkat wrote: Hi, On Mon, Dec 24, 2012 at 9:33 AM, Padma Venkat padma@gmail.com wrote: Hi, You should always delete irrelevant text from mails, it makes it much easier for people to find whatever content you've added. I agree with using

Re: [PATCH V5 2/2] ASoC: SAMSUNG: Add DT support for i2s

2012-12-19 Thread Mark Brown
On Wed, Dec 19, 2012 at 01:24:14PM +, Grant Likely wrote: On Thu, 13 Dec 2012 16:12:53 +0530, Padmavathi Venna padm...@samsung.com wrote: +- compatible : samsung,samsung-i2s Isn't that kind of redundant? :-) The format of the compatible strings should be vendor,part-number-i2s.

Re: [PATCH 1/2] i2c-core: Add gpio based bus arbitration implementation

2012-12-19 Thread Mark Brown
On Wed, Dec 19, 2012 at 12:32:01PM +, Grant Likely wrote: I'm not convinced on the design of this protocol. It won't scale beyond 2 bus masters and it seems very specific to the design of a specific piece of hardware. I don't think it is mature enough to bake into the I ought to point out

Re: [PATCH 1/2] i2c-core: Add gpio based bus arbitration implementation

2012-12-15 Thread Mark Brown
On Fri, Dec 14, 2012 at 09:06:49AM -0700, Stephen Warren wrote: On 12/13/2012 10:50 PM, Naveen Krishna Chatradhi wrote: +The first should be an output, and is used to claim the I2C bus, +the second should be an input, and signals that the other side (Client) +wants to claim the bus. This

Re: [PATCH V4 0/2] Add DT support for i2s

2012-12-10 Thread Mark Brown
On Mon, Dec 10, 2012 at 04:30:50PM +0530, Padma Venkat wrote: Could you please explain me in more detail about single DT link automatically expanded into two DAI links. How this can be done? The device tree should only represent the single physical link that exists and the handling of the

Re: [PATCH 1/4] regulator: s5m8767: Fix to work when platform registers less regulators

2012-12-10 Thread Mark Brown
On Mon, Dec 10, 2012 at 06:19:39PM +0530, Amit Daniel Kachhap wrote: Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 2/4] regulator: s5m8767: Fix to read the first DVS register.

2012-12-10 Thread Mark Brown
On Mon, Dec 10, 2012 at 06:19:40PM +0530, Amit Daniel Kachhap wrote: This patch modifies the DVS register read function to select correct DVS1 register. This change is required because the GPIO select pin is 000 in unintialized state and hence selects the DVS1 register. Applied, thanks. -- To

Re: [PATCH 3/4] regulator: s5m8767: Fix to work even if no DVS gpio present

2012-12-10 Thread Mark Brown
On Mon, Dec 10, 2012 at 06:19:41PM +0530, Amit Daniel Kachhap wrote: Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH V4 0/2] Add DT support for i2s

2012-12-08 Thread Mark Brown
On Sat, Dec 08, 2012 at 10:07:54AM +0530, Padma Venkat wrote: Samsung i2s driver registers the platform device twice one for the samsung-i2s.0,1 or 2 and two for samsung-i2s.4(which actually doesn't represent any H/W peripheral). The max number of I2S blocks on any Samsung SoC are 3, the

Re: [PATCH RESEND V2 1/2] ASoC: Samsung: Do not register samsung audio dma device as pdev

2012-12-07 Thread Mark Brown
On Fri, Dec 07, 2012 at 01:59:21PM +0530, Padmavathi Venna wrote: Previously, the ASoC 'platform' (PCM/DMA) object was instantiated via a platform_device. This didn't represent the hardware well, since there was no separate hardware associated with this platform_device; it was a virtual device

Re: [PATCH V2 1/2] ASoC: Samsung: Do not register samsung audio dma device as pdev

2012-12-06 Thread Mark Brown
On Thu, Dec 06, 2012 at 09:20:36AM +0530, Padmavathi Venna wrote: Previously, the ASoC 'platform' (PCM/DMA) object was instantiated via a platform_device. This didn't represent the hardware well, since there was no separate hardware associated with this platform_device; it was a virtual device

Re: [PATCH V4 0/2] Add DT support for i2s

2012-12-05 Thread Mark Brown
On Thu, Dec 06, 2012 at 09:31:40AM +0530, Padma Venkat wrote: On Wed, Nov 28, 2012 at 4:17 PM, Padmavathi Venna padm...@samsung.com wrote: Padmavathi Venna (2): ASoC: Samsung: Get I2S src_clk from clock alias id. ASoC: SAMSUNG: Add DT support for i2s Any comments on DT support for

Re: [PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation

2012-12-01 Thread Mark Brown
On Thu, Nov 29, 2012 at 10:14:58PM -0800, Olof Johansson wrote: On Thu, Nov 29, 2012 at 6:13 PM, Simon Glass s...@chromium.org wrote: It was originally done separately but I think it was felt that this was overly complex. Olof can you please comment on this? it is indeed not controller

Re: [PATCH 1/2] ASoC: Samsung: WM8994: Add basic device tree support for machine file

2012-12-01 Thread Mark Brown
On Sat, Dec 01, 2012 at 03:37:26PM +0530, Padmavathi Venna wrote: Add the basic device tree based lookup. Signed-off-by: Padmavathi Venna padm...@samsung.com --- sound/soc/samsung/smdk_wm8994.c | 23 +++ Any new device tree bindings need binding documentation. Your

Re: [PATCH] ARM: SAMSUNG: Fix build of I2S driver

2012-12-01 Thread Mark Brown
On Fri, Nov 30, 2012 at 08:00:10PM +0900, Kukjin Kim wrote: Mark, I'm holding on Padma's changes for Samsung audio. If any updates about this from your side? Is it ok to send current next/audio-samsung in my tree to upstream for v3.8? They didn't seem to have broken anything in -next for

Re: [PATCH 2/2] ASoC: Samsung: Do not register samsung audio dma device as pdev

2012-12-01 Thread Mark Brown
On Sat, Dec 01, 2012 at 03:37:27PM +0530, Padmavathi Venna wrote: sound/soc/samsung/dma.c | 24 ++-- sound/soc/samsung/dma.h |3 +++ sound/soc/samsung/i2s.c |3 +++ sound/soc/samsung/smdk_wm8994.c |7 +-- 4 files changed, 17

Re: [PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation

2012-11-29 Thread Mark Brown
On Thu, Nov 29, 2012 at 10:35:35AM +0530, Naveen Krishna Chatradhi wrote: The arbitrator is a general purpose function which uses two GPIOs to communicate with another device to claim/release a bus. We use it to arbitrate an i2c port between the AP and the EC. Should this not be layerd on top

Re: [GIT PULL] ASoC: Samsung: Updates for v3.8

2012-11-28 Thread Mark Brown
On Wed, Nov 28, 2012 at 11:21:31AM +0530, Padma Venkat wrote: On Wed, Nov 28, 2012 at 10:55 AM, Sangbeom Kim sbki...@samsung.com wrote: The requirement for an alias is also very odd, where does that come from? I don't know that Which one is odd. Please let me know. Having them at all is

Re: [PATCH V4 1/2] ASoC: Samsung: Get I2S src_clk from clock alias id.

2012-11-28 Thread Mark Brown
On Wed, Nov 28, 2012 at 04:17:48PM +0530, Padmavathi Venna wrote: As the I2S src clks are registered with clkdev using generic connection id, driver can get the clk name using generic id. So the variable representing the array of rclk src clks is deleted. Applied, thanks. signature.asc

Re: [PATCH] regulator: add device tree support for max8997

2012-11-27 Thread Mark Brown
On Tue, Nov 27, 2012 at 02:04:32PM +0530, Thomas Abraham wrote: Add device tree based discovery support for max8997. Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH 3/3] regulator: add device tree support for max8997

2012-11-26 Thread Mark Brown
On Sat, Nov 24, 2012 at 11:46:51PM +0530, Thomas Abraham wrote: The max8997 driver is mainlined. I actually meant to say that, this v6 version of dt support patch for max8997, is similar in functionality to the v5 version of this patch. I did prepare this patch based on your latest for-next

Re: [PATCH 3/3] regulator: add device tree support for max8997

2012-11-26 Thread Mark Brown
On Mon, Nov 26, 2012 at 07:16:04PM +0530, Thomas Abraham wrote: and this patch applied cleanly. Could you please let me know if there is anything I need to be doing differently for this. Hrm, try applying it on the relevant topic branch. Your comments about rebasing on top of MFD changes did

Re: [PATCH 3/3] regulator: add device tree support for max8997

2012-11-26 Thread Mark Brown
On Mon, Nov 26, 2012 at 08:13:23PM +0530, Thomas Abraham wrote: I tried applying this patch on the max8997 branch in your regulator tree. But this patch does not apply cleanly on that branch because commits 5eb9f2b96381 (regulator: remove use of __devexit_p), a5023574d120 (regulator: remove

Re: [RFC PATCH] ASoC: Samsung: Register the audio platform device

2012-11-26 Thread Mark Brown
On Mon, Nov 26, 2012 at 08:15:12PM +0530, Padma Venkat wrote: On Wed, Nov 14, 2012 at 5:39 PM, Padmavathi Venna padm...@samsung.com wrote: +module_init(smdk_audio_init); +module_exit(smdk_audio_exit); Ping. Any comments on this patch? Don't send contentless pings and delete irrelevant

[PATCH] ARM: SAMSUNG: Fix build of I2S driver

2012-11-26 Thread Mark Brown
should not be being made independently of removal of the uses of the field since it will cause build failures in any tree where it has been merged but the removals have not been merged. Currently the removal of the users in the ASoC driver has not been merged. Signed-off-by: Mark Brown broo

[PATCH] ARM: S3C64XX: Add registration of WM2200 Bells device on Cragganmore

2012-11-26 Thread Mark Brown
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- arch/arm/mach-s3c64xx/mach-crag6410.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-s3c64xx/mach-crag6410.c b/arch/arm/mach-s3c64xx/mach-crag6410.c index 2abe95d..c06bcfa 100644

Re: [PATCH] ARM: SAMSUNG: Fix build of I2S driver

2012-11-26 Thread Mark Brown
On Tue, Nov 27, 2012 at 09:33:43AM +0900, Kukjin Kim wrote: I checked Samsung audio driver stuff just now. If you don't mind, I will drop the patch 48a2050d (ARM: SAMSUNG: Delete the unnecessary variable) instead of applying this. That works just as well for me, thanks. Padma, as I said in

Re: [PATCH 1/3] regulator: max8997: reorder buck1/2/5 dvs setup code

2012-11-24 Thread Mark Brown
On Fri, Nov 23, 2012 at 01:33:13PM +0530, Thomas Abraham wrote: The BUCKxDVSx register programming is now moved prior to setting up of the gpio based dvs mode. This will ensure that all the BUCKxDVSx registers are programmed with appropriate voltage values before the gpio based dvs mode is

Re: [PATCH 2/3] regulator: max8997: limit the number of dvs registers programmed in non-dvs mode

2012-11-24 Thread Mark Brown
On Fri, Nov 23, 2012 at 01:33:14PM +0530, Thomas Abraham wrote: In case the gpio based volatage selection mode is not used for either of buck 1/2/5, then only the BUCKxDVS1 register need to be programmed. So determine whether dvs mode is used and limit the loop count appropriately. Applied,

Re: [PATCH 3/3] regulator: add device tree support for max8997

2012-11-24 Thread Mark Brown
On Fri, Nov 23, 2012 at 01:33:15PM +0530, Thomas Abraham wrote: This v6 patch is rebased to the latest max8997 driver code and there are no functional changes from v5. That doesn't seem to be in mainline yet so the patch won't apply. signature.asc Description: Digital signature

Re: [PATCH V3 0/5] Avoid passing clks through platform data

2012-11-23 Thread Mark Brown
On Fri, Nov 23, 2012 at 04:40:59PM +0530, Padma Venkat wrote: cc'ing Mark Brown. On Tue, Nov 6, 2012 at 10:18 AM, Padmavathi Venna padm...@samsung.com wrote: Changes since v2: - Rebased on 3.7-rc3 Please don't do this, send the patches non-quoted. signature.asc Description

Re: [PATCH 2/2] i2c: s3c2410: Get the i2c bus number from alias id

2012-11-20 Thread Mark Brown
On Tue, Nov 20, 2012 at 02:27:04PM -0800, Doug Anderson wrote: From: Padmavathi Venna padm...@samsung.com Get the i2c bus number that the device is connected to using the alias id. This makes debugging / grokking of kernel messages much easier. This doesn't look like a s3c2410 specific

Re: [PATCH 340/493] arm: remove use of __devinitdata

2012-11-19 Thread Mark Brown
On Mon, Nov 19, 2012 at 01:24:49PM -0500, Bill Pemberton wrote: CONFIG_HOTPLUG is going away as an option so __devinitdata is no longer needed. Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com signature.asc Description: Digital signature

Re: [PATCH 3/4] i2c-s3c2410: use exponential back off while polling for bus idle

2012-11-19 Thread Mark Brown
On Thu, Nov 15, 2012 at 05:43:32PM +0530, Naveen Krishna Chatradhi wrote: + iicstat = readl(i2c-regs + S3C2410_IICSTAT); + delay = 1; + while ((iicstat S3C2410_IICSTAT_START) +ktime_us_delta(now, start) S3C2410_IDLE_TIMEOUT) { + usleep_range(delay, 2 *

Re: Forward: [PATCH 146/493] ASoC: remove use of __devexit_p

2012-11-19 Thread Mark Brown
On Tue, Nov 20, 2012 at 07:21:36AM +0100, Takashi Iwai wrote: Yet another one for ASoC. Date: Mon, 19 Nov 2012 13:21:35 -0500 From: Bill Pemberton wf...@virginia.edu To: gre...@linuxfoundation.org Cc: Jaroslav Kysela pe...@perex.cz, Takashi Iwai ti...@suse.de, M R Swami Reddy

Re: [PATCH 123/493] watchdog: remove use of __devexit_p

2012-11-19 Thread Mark Brown
On Mon, Nov 19, 2012 at 01:21:12PM -0500, Bill Pemberton wrote: CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer needed. Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com signature.asc Description: Digital signature

Re: [PATCH 152/493] watchdog: remove use of __devinit

2012-11-19 Thread Mark Brown
On Mon, Nov 19, 2012 at 01:21:41PM -0500, Bill Pemberton wrote: CONFIG_HOTPLUG is going away as an option so __devinit is no longer needed. Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com signature.asc Description: Digital signature

Re: [PATCH 230/493] input: remove use of __devinit

2012-11-19 Thread Mark Brown
On Mon, Nov 19, 2012 at 01:22:59PM -0500, Bill Pemberton wrote: CONFIG_HOTPLUG is going away as an option so __devinit is no longer needed. Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com signature.asc Description: Digital signature

Re: [PATCH 270/493] arm: remove use of __devinit

2012-11-19 Thread Mark Brown
On Mon, Nov 19, 2012 at 01:23:39PM -0500, Bill Pemberton wrote: CONFIG_HOTPLUG is going away as an option so __devinit is no longer needed. Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com signature.asc Description: Digital signature

Re: [PATCH 408/493] input: remove use of __devexit

2012-11-19 Thread Mark Brown
On Mon, Nov 19, 2012 at 01:25:57PM -0500, Bill Pemberton wrote: CONFIG_HOTPLUG is going away as an option so __devexit is no longer needed. Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com signature.asc Description: Digital signature

Re: [PATCH 435/493] watchdog: remove use of __devexit

2012-11-19 Thread Mark Brown
On Mon, Nov 19, 2012 at 01:26:24PM -0500, Bill Pemberton wrote: CONFIG_HOTPLUG is going away as an option so __devexit is no longer needed. Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com signature.asc Description: Digital signature

Re: [PATCH] spi: s3c64xx: Add fix for crash in spi suspend/resume

2012-11-07 Thread Mark Brown
On Wed, Nov 07, 2012 at 11:40:12AM +0530, Naveen Krishna Chatradhi wrote: From: Abhilash Kesavan a.kesa...@samsung.com The SPI driver makes a gpio_request during initialization. The requested gpios need to be populated as part of the s3c64xx_spi_driver_data so that they can be released

Re: [PATCH 2/2] i2c-s3c2410: Convert to devm_request_and_ioremap()

2012-11-06 Thread Mark Brown
On Mon, Nov 05, 2012 at 05:21:03PM +0530, Shubhrajyoti Datta wrote: On Mon, Nov 5, 2012 at 2:03 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: A small code saving and less error handling to worry about. Looks good. request irq could be devm_* also. Not an objection though

[PATCH 2/2] i2c-s3c2410: Convert to devm_request_and_ioremap()

2012-11-05 Thread Mark Brown
A small code saving and less error handling to worry about. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- drivers/i2c/busses/i2c-s3c2410.c | 35 +++ 1 file changed, 7 insertions(+), 28 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410

[PATCH 1/2] i2c-s3c2410: Refactor ifdefs for PM_SLEEP

2012-11-05 Thread Mark Brown
Use the PM_SLEEP ifdef for system suspend and resume. This is partly in preparation for adding runtime operations and partly because a user may in theory choose to enable runtime suspend but not system suspend. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Reviewed

Re: [PATCH v2] ARM: S3C64XX: Fix up IRQ mapping for balblair on Cragganmore

2012-11-02 Thread Mark Brown
On Fri, Nov 02, 2012 at 01:04:14PM +, Dimitris Papastamos wrote: We are using S3C_EINT(4) instead of S3C_EINT(5). Reviwed-by: Mark Brown broo...@opensource.wolfsonmicro.com signature.asc Description: Digital signature

Re: [PATCH] spi: s3c64xx: use clk_prepare_enable and clk_disable_unprepare

2012-10-17 Thread Mark Brown
On Wed, Oct 03, 2012 at 08:30:12AM +0900, Thomas Abraham wrote: Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare calls as required by common clock framework. Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a

Re: [PATCH V6 2/2] video: drm: exynos: Add device tree support

2012-09-25 Thread Mark Brown
On Wed, Sep 26, 2012 at 12:03:44AM +0900, Inki Dae wrote: 2012/9/25 Laurent Pinchart laurent.pinch...@ideasonboard.com: Aren't DT bindings considered as an ABI, and required to be supported more or less forever ? If you merge this DT binding you'll have to keep supporting it. That's

Re: [PATCH] spi: s3c64xx: Don't free controller_data on non-dt platforms

2012-09-22 Thread Mark Brown
On Thu, Sep 13, 2012 at 04:31:30PM +0200, Sylwester Nawrocki wrote: When s3c64xx-spi is instantiated from device tree an instance of struct s3c64xx_spi_csinfo is dynamically allocated in the driver. Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc

Re: [PATCH] ASoC: SAMSUNG: Add SND_SOC_DAIFMT_CONT option for snd_soc_set_fmt()

2012-09-05 Thread Mark Brown
On Mon, Sep 03, 2012 at 11:10:03AM +0900, Sangsu Park wrote: On Sun, Aug 31, 2012 at 2:43 AM +0900, Mark Brown wrote: On Wed, Aug 29, 2012 at 08:06:32PM +0900, Sangsu Park wrote: Please check your mailer configuration, it looks like it's reformatting all the text with much longer line

Re: [PATCH] ASoC: SAMSUNG: Add SND_SOC_DAIFMT_CONT option for snd_soc_set_fmt()

2012-08-30 Thread Mark Brown
On Wed, Aug 29, 2012 at 08:06:32PM +0900, Sangsu Park wrote: Please check your mailer configuration, it looks like it's reformatting all the text with much longer line widths. On Sun, Aug 26, 2012 at 05:45:54PM +0900, Mark Brown wrote: a whole lot of sense on the slave side, it's related

Re: [RESUBMIT PATCH] ASoC: SAMSUNG: Change Kconfig to support all SAMSUNG ASoC

2012-08-28 Thread Mark Brown
On Tue, Aug 28, 2012 at 05:55:49PM +0900, Sangsu Park wrote: All SAMSUNG ASoC needs SND_SOC_SAMSUNG configuration. This patch change Kconfig to support all SAMSUNG ASoC. Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to

Re: ASoC: SAMSUNG: Change Kconfig to support all EXYNOSs

2012-08-27 Thread Mark Brown
On Sun, Aug 26, 2012 at 05:04:37PM +0900, �ڻ��� wrote: All EXYNOSs use SND_SOC_SAMSUNG configuration. This patch change Kconfig to support all EXYNOSs like EXYNOS4 and EXYNOS5. git can't figure out how to apply your patch due to your character set: fatal: cannot convert from ks_c_5601-1987

Re: [PATCH] spi/s3c64xx: Drop extra calls to spi_master_get in suspend/remove functions

2012-08-27 Thread Mark Brown
On Thu, Aug 16, 2012 at 08:14:25PM -0700, Guenter Roeck wrote: Suspend and resume functions call spi_master_get() without matching spi_master_put(). The extra references are unnecessary and cause subsequent module unload attempts to fail. Drop the calls. Applied, thanks. -- To unsubscribe from

Re: [PATCH] ASoC: SAMSUNG: Add SND_SOC_DAIFMT_CONT option for snd_soc_set_fmt()

2012-08-27 Thread Mark Brown
On Sun, Aug 26, 2012 at 05:45:54PM +0900, �ڻ��� wrote: SND_SOC_DAIFMT_CONT option is now needed because of below commit: ASoC: Allow DAI formats to be specified in the dai_link Clearly it's not a direct consequence of this commit, that just introduces a new optional facility which...

Re: [PATCH 1/2] ARM: S3C64XX: Update configuration for WM5102 module on Cragganmore

2012-08-23 Thread Mark Brown
On Thu, Aug 23, 2012 at 06:45:19PM +0900, Kukjin Kim wrote: Yeah, actually SoC defconfig in mainline doesn't cover _real_ requirements for (mass) product. But I think, it's time we need to sort out the defconfigs so that we could use them efficiently on product. BTW, if enabling board in

Re: [PATCH 14/14] drivers/spi/spi-s3c24xx.c: fix error return code

2012-08-22 Thread Mark Brown
On Wed, Aug 22, 2012 at 06:38:36PM +0900, Kukjin Kim wrote: Julia Lawall wrote: Signed-off-by: Julia Lawall julia.law...@lip6.fr Acked-by: Kukjin Kim kgene@samsung.com (Cc'ed Mark Brown who is handling spi for a moment) Please resend the patch to me so I can apply

Re: [PATCH 14/14] drivers/spi/spi-s3c24xx.c: fix error return code

2012-08-22 Thread Mark Brown
On Wed, Aug 22, 2012 at 01:42:47PM +0200, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr Initialize return variable before exiting on an error path. Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH 1/2] ARM: S3C64XX: Update configuration for WM5102 module on Cragganmore

2012-08-10 Thread Mark Brown
On Fri, Aug 10, 2012 at 01:56:23PM +0900, Kukjin Kim wrote: Probably, this patch needs following? If you're ok, I will fix build error by above when I apply. Yes, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to

Re: [PATCH] ASoC: Samsung: Fix build error

2012-08-10 Thread Mark Brown
On Wed, Aug 08, 2012 at 11:34:43AM +0530, Sachin Kamat wrote: Fixes the following build error: In file included from arch/arm/mach-exynos/include/mach/dma.h:24:0, from arch/arm/plat-samsung/include/plat/dma-ops.h:17, Applied, thanks. -- To unsubscribe from this list: send the

[PATCH 1/2] ARM: S3C64XX: Update configuration for WM5102 module on Cragganmore

2012-08-09 Thread Mark Brown
SPI is also connected on the board, use that instead of I2C as it's much faster. Also define platform data now the core driver is in mainline. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- arch/arm/mach-s3c64xx/mach-crag6410-module.c | 35 ++ 1 file

[PATCH 2/2] ARM: S3C64XX: Register audio platform devices for Bells on Cragganmore

2012-08-09 Thread Mark Brown
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- arch/arm/mach-s3c64xx/mach-crag6410.c | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/mach-s3c64xx/mach-crag6410.c b/arch/arm/mach-s3c64xx/mach-crag6410.c index ab8dbbe4..4103ed3 100644 --- a/arch/arm

Re: [PATCH] ASoC: Samsung: Fix build error

2012-08-08 Thread Mark Brown
On Wed, Aug 08, 2012 at 11:34:43AM +0530, Sachin Kamat wrote: Fixes the following build error: In file included from arch/arm/mach-exynos/include/mach/dma.h:24:0, from arch/arm/plat-samsung/include/plat/dma-ops.h:17, from

Re: [PATCH 2/2] spi/s3c64xx: Expand S3C64XX_SPI_{DE,}ACT macros at call sites

2012-07-17 Thread Mark Brown
On Tue, Jul 17, 2012 at 08:52:20AM +0900, Kukjin Kim wrote: So may I take then send this series via samsung tree? Because for samsung spi dt, the file has been touched in samsung tree so it helps to avoid bad conflicts. May as well, yes. signature.asc Description: Digital signature

[PATCH] ARM: S3C64XX: Clean up after SPI driver platform data updates

2012-07-17 Thread Mark Brown
Commit 1c20c2 (spi: s3c64xx: Remove the 'set_level' callback from controller data) didn't update all the users, breaking the build. Fix that. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- arch/arm/mach-s3c64xx/mach-crag6410-module.c |1 - 1 file changed, 1 deletion

Re: [PATCH] i2c-s3c2410: Convert to devm_request_and_ioremap()

2012-07-13 Thread Mark Brown
On Fri, Jul 13, 2012 at 10:37:12AM +0200, Wolfram Sang wrote: On Mon, Jul 09, 2012 at 02:58:10PM +0100, Mark Brown wrote: The devm_ versions of the API aren't exported there yet and there's a bug fix pending too but Russell and Mike have ignored the patches thus far. I'd rather wait

Re: [PATCH 1/2] ASoC: Convert S3C24XX I2S driver to gpiolib API

2012-07-13 Thread Mark Brown
On Thu, Jul 12, 2012 at 08:09:09PM +0200, Sylwester Nawrocki wrote: Thanks, would that be Takashi Iwai and Jaroslav Kysela then ? I just want to get it right this time... Or perhaps could you take care of them ? As with everything else look in MAINTAINERS, so me for ASoC. signature.asc

Re: [PATCH v5 0/6] spi: s3c64xx: add support for device tree

2012-07-12 Thread Mark Brown
On Thu, Jul 12, 2012 at 06:11:05PM +0900, Kukjin Kim wrote: And Mark, this touches various samsung stuff in arch/arm/ so if you're ok, I'd like to pick this up in samsung tree. We don't want to see conflicts... Well, simple conflicts aren't that big a deal... However, Thomas mentioned that in

Re: [PATCH v5 0/6] spi: s3c64xx: add support for device tree

2012-07-12 Thread Mark Brown
On Thu, Jul 12, 2012 at 07:13:37PM +0530, Thomas Abraham wrote: On 12 July 2012 18:32, Mark Brown broo...@opensource.wolfsonmicro.com wrote: Well, simple conflicts aren't that big a deal... However, Thomas mentioned that in order to test this he merged the SPI tree into your tree so

Re: [PATCH 1/2] ASoC: Convert S3C24XX I2S driver to gpiolib API

2012-07-12 Thread Mark Brown
On Thu, Jul 12, 2012 at 03:56:36PM +0200, Sylwester Nawrocki wrote: These are the only two patches (out of 15) that are now needed to remove some obsolete s3c2410_gpio_* API. 1/2 was tested on Micro2440 board and 2/2 is an identical change which wasn't tested on a real H/W since I don't have

Re: [PATCH v5 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-11 Thread Mark Brown
On Wed, Jul 11, 2012 at 04:45:59PM +0530, Thomas Abraham wrote: The set_level callback in the controller data, which is used to configure the slave select line, cannot be supported when migrating the driver to device tree based discovery. Since all the platforms currently use gpio as the slave

Re: [PATCH v5 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-11 Thread Mark Brown
On Wed, Jul 11, 2012 at 05:51:13PM +0530, Thomas Abraham wrote: Based on your comments to add the gpio request, only two patches 5/6 and 6/6 in this series have changed since. I have cc'ed you in the other 4 patches as well. If you do not have those patches, please let me know, I will repost

Re: [PATCH v5 0/6] spi: s3c64xx: add support for device tree

2012-07-11 Thread Mark Brown
On Wed, Jul 11, 2012 at 09:10:59PM +0530, Thomas Abraham wrote: Changes since v4: - Includes the missing gpio request for slave select line gpio as suggested by Mark Brown. These looked OK (and have had quite a bit of review already so we're probably at the stage where incremental fixes

[PATCH] ARM: S3C64XX: Don't specify an irq_base for WM1192-EV1 board

2012-07-10 Thread Mark Brown
None of the GPIO IRQs are connected so there is no reason to specify a base. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- arch/arm/mach-s3c64xx/mach-smdk6410.c |1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-s3c64xx/mach-smdk6410.c b/arch/arm/mach

Re: [PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-10 Thread Mark Brown
On Tue, Jul 10, 2012 at 07:57:38PM +0530, Thomas Abraham wrote: The set_level callback in the controller data, which is used to configure the slave select line, cannot be supported when migrating the driver to device tree based discovery. Since all the platforms currently use gpio as the slave

Re: [PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-10 Thread Mark Brown
On Tue, Jul 10, 2012 at 10:22:31PM +0530, Thomas Abraham wrote: In non-dt case, the platform code supplying the gpio number (slave select line) is responsible for requesting the gpio during the machine_init call. So the gpio request is not called in the driver for that gpio. In dt case, the

Re: [PATCH] i2c-s3c2410: Convert to devm_request_and_ioremap()

2012-07-09 Thread Mark Brown
On Mon, Jul 09, 2012 at 03:52:29PM +0200, Wolfram Sang wrote: On Thu, Jun 28, 2012 at 01:55:38PM +0100, Mark Brown wrote: A small code saving and less error handling to worry about. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com What about devm for the clocks, too

Re: [PATCH 1/2] spi/s3c64xx: Convert to devm_request_and_ioremap()

2012-07-05 Thread Mark Brown
On Thu, Jul 05, 2012 at 10:41:04AM +0200, Sylwester Nawrocki wrote: It doesn't seem right. Why is is the check for valid sdd-regs removed ? This should have rather been: Mostly just because the structure of the code is a bit error prone when making quick updates with the if statement

[PATCH] spi/s3c64xx: Convert to devm_request_and_ioremap()

2012-07-05 Thread Mark Brown
Saves some error handling and a small amount of code. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Acked-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-s3c64xx.c | 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/drivers/spi

[PATCH] ARM: SAMSUNG: Introduce Kconfig variable for Samsung custom clk API

2012-07-04 Thread Mark Brown
a flag day to convert the entire family of devices over. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- arch/arm/plat-samsung/Kconfig |4 arch/arm/plat-samsung/Makefile |4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm/plat-samsung

[PATCH 2/2] spi/s3c64xx: Expand S3C64XX_SPI_{DE,}ACT macros at call sites

2012-07-04 Thread Mark Brown
They have very few users and they're both just doing a single register write so the advantage of having the macro is a bit limited. An inline function might make sense but it's as easy to just do the writes directly. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Acked-by: Linus

<    3   4   5   6   7   8   9   10   11   12   >