RE: [PATCH] ARM: EXYNOS: Avoid early use of of_machine_is_compatible()

2012-11-30 Thread Kukjin Kim
Olof Johansson wrote: On Wed, Nov 28, 2012 at 8:16 AM, Doug Anderson diand...@chromium.org wrote: Olof / Kukjin, [...] I really don't like splitting an if/else with an ifdef like this, it's fragile code and can be hard to follow. Agree. Definitely, same here ;-) There's

Re: [PATCH] ARM: EXYNOS: Avoid early use of of_machine_is_compatible()

2012-11-28 Thread Doug Anderson
Olof / Kukjin, On Tue, Nov 27, 2012 at 10:05 PM, Olof Johansson o...@lixom.net wrote: On Wed, Nov 28, 2012 at 02:23:09PM +0900, Kukjin Kim wrote: Olof Johansson wrote: On Tue, Nov 27, 2012 at 2:27 PM, Kukjin Kim kgene@samsung.com wrote: On 11/28/12 07:11, Olof Johansson wrote:

Re: [PATCH] ARM: EXYNOS: Avoid early use of of_machine_is_compatible()

2012-11-28 Thread Olof Johansson
On Wed, Nov 28, 2012 at 8:16 AM, Doug Anderson diand...@chromium.org wrote: Olof / Kukjin, On Tue, Nov 27, 2012 at 10:05 PM, Olof Johansson o...@lixom.net wrote: On Wed, Nov 28, 2012 at 02:23:09PM +0900, Kukjin Kim wrote: Olof Johansson wrote: On Tue, Nov 27, 2012 at 2:27 PM, Kukjin Kim

[PATCH] ARM: EXYNOS: Avoid early use of of_machine_is_compatible()

2012-11-27 Thread Doug Anderson
The recent commit ARM: EXYNOS: add support for EXYNOS5440 SoC broke support for exynos5250 because of_machine_is_compatible() was used too early in the boot process. It also probably meant that the exynos5440 failed to use the proper iotable. Switch to use of_flat_dt_is_compatible() in both of

Re: [PATCH] ARM: EXYNOS: Avoid early use of of_machine_is_compatible()

2012-11-27 Thread Olof Johansson
On Tue, Nov 27, 2012 at 11:53 AM, Doug Anderson diand...@chromium.org wrote: The recent commit ARM: EXYNOS: add support for EXYNOS5440 SoC broke support for exynos5250 because of_machine_is_compatible() was used too early in the boot process. It also probably meant that the exynos5440 failed

Re: [PATCH] ARM: EXYNOS: Avoid early use of of_machine_is_compatible()

2012-11-27 Thread Kukjin Kim
On 11/28/12 07:11, Olof Johansson wrote: On Tue, Nov 27, 2012 at 11:53 AM, Doug Andersondiand...@chromium.org wrote: The recent commit ARM: EXYNOS: add support for EXYNOS5440 SoC broke support for exynos5250 because of_machine_is_compatible() was used too early in the boot process. It also

Re: [PATCH] ARM: EXYNOS: Avoid early use of of_machine_is_compatible()

2012-11-27 Thread Olof Johansson
On Tue, Nov 27, 2012 at 2:27 PM, Kukjin Kim kgene@samsung.com wrote: On 11/28/12 07:11, Olof Johansson wrote: On Tue, Nov 27, 2012 at 11:53 AM, Doug Andersondiand...@chromium.org wrote: The recent commit ARM: EXYNOS: add support for EXYNOS5440 SoC broke support for exynos5250 because

RE: [PATCH] ARM: EXYNOS: Avoid early use of of_machine_is_compatible()

2012-11-27 Thread Kukjin Kim
Olof Johansson wrote: On Tue, Nov 27, 2012 at 2:27 PM, Kukjin Kim kgene@samsung.com wrote: On 11/28/12 07:11, Olof Johansson wrote: On Tue, Nov 27, 2012 at 11:53 AM, Doug Andersondiand...@chromium.org wrote: The recent commit ARM: EXYNOS: add support for EXYNOS5440 SoC broke

Re: [PATCH] ARM: EXYNOS: Avoid early use of of_machine_is_compatible()

2012-11-27 Thread Olof Johansson
On Wed, Nov 28, 2012 at 02:23:09PM +0900, Kukjin Kim wrote: Olof Johansson wrote: On Tue, Nov 27, 2012 at 2:27 PM, Kukjin Kim kgene@samsung.com wrote: On 11/28/12 07:11, Olof Johansson wrote: On Tue, Nov 27, 2012 at 11:53 AM, Doug Andersondiand...@chromium.org wrote: