On 11/30/2010 07:18 AM, Kukjin Kim wrote:
Vasily Khoruzhick wrote:
Currently the {set,get}_pull callbacks of the s3c24xx_gpiocfg_default
structure
are initalized via s3c_gpio_{get,set}pull_1up. This results in a linker
error when compiling kernel for s3c2442:
On Tuesday 30 November 2010 13:53:43 Lars-Peter Clausen wrote:
Hmm...how about s3c_gpio_setpull_1updown(...)?
And actually, not used 3rd argument, pull now.
I prefer follwoing.
You need the 4th arguemnt, because the s3c2440 only supports pullups and
the s3c2442 only supports pulldowns.
On 11/30/2010 01:01 PM, Vasily Khoruzhick wrote:
On Tuesday 30 November 2010 13:53:43 Lars-Peter Clausen wrote:
Hmm...how about s3c_gpio_setpull_1updown(...)?
And actually, not used 3rd argument, pull now.
I prefer follwoing.
You need the 4th arguemnt, because the s3c2440 only supports
On Tuesday 30 November 2010 15:12:37 Lars-Peter Clausen wrote:
Hi
While this might work for setting the pullup, what to you want to return in
get_pull?
Some custom value like S3C_GPIO_PULL_ENABLED?
The reason why s3c24xx_gpiocfg_default needs to have {get,set}_pull set at
compile time
On 11/30/2010 03:33 PM, Vasily Khoruzhick wrote:
On Tuesday 30 November 2010 15:12:37 Lars-Peter Clausen wrote:
Hi
While this might work for setting the pullup, what to you want to return in
get_pull?
Some custom value like S3C_GPIO_PULL_ENABLED?
Well, or we could use a custom setter and
On Tuesday 30 November 2010 16:53:09 Lars-Peter Clausen wrote:
Both the cpu init code and the machine init code are run at arch_initcall.
Yeah, you're right.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More
Lars-Peter Clausen wrote:
-#ifdef CONFIG_S3C_GPIO_PULL_UP
-int s3c_gpio_setpull_1up(struct s3c_gpio_chip *chip,
- unsigned int off, s3c_gpio_pull_t pull)
+#if defined(CONFIG_S3C_GPIO_PULL_UP) ||
defined(CONFIG_S3C_GPIO_PULL_DOWN)
+static int
Currently the {set,get}_pull callbacks of the s3c24xx_gpiocfg_default structure
are initalized via s3c_gpio_{get,set}pull_1up. This results in a linker
error when compiling kernel for s3c2442:
arch/arm/plat-s3c24xx/built-in.o:(.data+0x13f4): undefined reference to
`s3c_gpio_getpull_1up'
