RE: [PATCH] ARM: S3C2443: SPI clock channel setup is fixed

2012-11-22 Thread Kukjin Kim
Alexander Varnin > > I also want to point, that irq resource in arch/arm/plat-samsung/devs.c > for s3c2410-spi driver on S3C2443 points to wrong IRQ (SPI0 instead of Sounds that you cannot use platform_device in plat-samsung/devs.c for SPI on S3C2443. Yes, could be... > SPI1). I've solved it wi

Re: [PATCH] ARM: S3C2443: SPI clock channel setup is fixed

2012-11-22 Thread Alexander Varnin
22.11.2012 12:22, Kukjin Kim пишет: SPI1). I've solved it with board specific code, but it is not most correct way, i think. Hmm, if provided platform_device is in plat-samsung/devs.c cannot support, we can do as you said temporarily but we know it's wrong way because the value depends on SoC

Re: [PATCH] ARM: S3C2443: SPI clock channel setup is fixed

2012-11-22 Thread Alexander Varnin
I also want to point, that irq resource in arch/arm/plat-samsung/devs.c for s3c2410-spi driver on S3C2443 points to wrong IRQ (SPI0 instead of SPI1). I've solved it with board specific code, but it is not most correct way, i think. 20.11.2012 15:46, Kukjin Kim пишет: Alexander Varnin wrote:

RE: [PATCH] ARM: S3C2443: SPI clock channel setup is fixed

2012-11-20 Thread Kukjin Kim
Alexander Varnin wrote: > > Actually, SPI channel 0 on 2443 is mapped to HS SPI controller, > and to enable s3c2410-spi controller, we should power on channel > 1 in PCLKCON. There is no channel 0 SPI on s3c2443, so delete its > clock. > > Signed-off-by: Alexander Varnin > Reviewed-by: Heiko Stu

Re: [PATCH] ARM: S3C2443: SPI clock channel setup is fixed

2012-11-19 Thread Heiko Stübner
Am Montag, 19. November 2012, 15:33:57 schrieb Alexander Varnin: > Actually, SPI channel 0 on 2443 is mapped to HS SPI controller, > and to enable s3c2410-spi controller, we should power on channel > 1 in PCLKCON. There is no channel 0 SPI on s3c2443, so delete its > clock. > > Signed-off-by: Alex