RE: [PATCH 3/4] MFC: Add MFC 5.1 V4L2 driver

2010-10-21 Thread Kamil Debski
Hi, I commented as belows, And you missed one important things 'cause there were my comments in the very long email which is strongly fixed in the reset seq. Yes, thanks for your suggestion. [] +#define READL(offset) readl(dev-regs_base + (offset)) +#define

RE: [PATCH 3/4] MFC: Add MFC 5.1 V4L2 driver

2010-10-20 Thread Kamil Debski
Hi, Kamil This is second feedback about the HW op related code. (s5p_mfc_opr.c s5p_mfc.c) Hi, Peter Thanks for the comments. I have replied to them below. I would be grateful if you could cut out non relevant parts of the code in your replies. It was difficult to find your comments in such a

RE: [PATCH 3/4] MFC: Add MFC 5.1 V4L2 driver

2010-10-20 Thread Kamil Debski
Thank you for your reply about my comments. Refer to as below. Hi, I don't know if this is necessary. MFC_NUM_CONTEXTS can be fixed at the maximum number allowed by MFC hw: 16. I highly doubt someone will open that many contexts. Increasing this number will not significantly increase

RE: [PATCH 3/4] MFC: Add MFC 5.1 V4L2 driver

2010-10-14 Thread Jaeryul Oh
Thank you for your reply about my comments. Refer to as below. k.deb...@samsung.com wrote: Hi, Peter. I have some first comments about this code. and Generally, Making patch set separately will be more helpful to everyone. Thank you for your comments. k.deb...@samsung.com wrote: