[PATCH] usb: gadget: s3c2410: fix clk resource leak and update

2013-05-11 Thread Libo Chen
From: Libo Chen libo.c...@huawei.com currently, when clk_get(NULL,usb-device) fail, it does not disable put usb_bus_clock. It is incorrect. this patch use new interface devm_xxx instead of xxx then we no need to care about cleanup resource in err case that is boring and reduce code size.

[PATCH 1/2] ARM: dts: add DP clock reference to exynos5250 device tree

2013-05-11 Thread Jingoo Han
The transition to common clock happened; however, DP (Display Port) clock node was not added. Thus, DP (Display Port) clock node should be added to the device tree. Signed-off-by: Jingoo Han jg1@samsung.com --- Tested on Exynos5250 arch/arm/boot/dts/exynos5250.dtsi |2 ++ 1 files

[PATCH 2/2] ARM: dts: Document DP clock in samsung,exynos5-dp binding

2013-05-11 Thread Jingoo Han
The exynos5-dp node needs a clock specified using the common clock framework. Signed-off-by: Jingoo Han jg1@samsung.com --- Tested on Exynos5250 .../devicetree/bindings/video/exynos_dp.txt|6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git

[PATCH] ARM: dts: add pin state information for DP HPD support to Exynos5250

2013-05-11 Thread Jingoo Han
Add pin state information for DP HPD support that requires pin configuration support using pinctrl interface. Signed-off-by: Jingoo Han jg1@samsung.com --- Tested on Exynos5250 arch/arm/boot/dts/exynos5250-pinctrl.dtsi |7 +++ arch/arm/boot/dts/exynos5250-smdk5250.dts |3 +++ 2

Re: [PATCH V2 1/3] clk: samsung: register audio subsystem clocks using common clock framework

2013-05-11 Thread Padma Venkat
Hi Tomasz, On Fri, May 10, 2013 at 5:51 AM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Padmavathi, I managed to review the patch a bit more thoroughly and I had few more comments. You can find them inline. Thanks for the review. On Tuesday 07 of May 2013 12:13:34 Padmavathi Venna wrote:

Re: [PATCH] usb: gadget: s3c2410: fix clk resource leak and update

2013-05-11 Thread Tomasz Figa
Hi Libo, On Saturday 11 of May 2013 14:28:15 Libo Chen wrote: From: Libo Chen libo.c...@huawei.com The patch subject is slightly misleading. It suggests that the patch only changes clock handling, but in fact the biggest part of the patch is conversion to devm_ helpers. I think following

Re: [PATCH] usb: gadget: s3c2410: fix clk resource leak and update

2013-05-11 Thread Libo Chen
于 2013-5-11 18:15, Tomasz Figa 写道: Hi Libo, On Saturday 11 of May 2013 14:28:15 Libo Chen wrote: From: Libo Chenlibo.c...@huawei.com The patch subject is slightly misleading. It suggests that the patch only changes clock handling, but in fact the biggest part of the patch is conversion to

[RFC 0/4] ARM: S3C24XX: add dmaengine based dma-driver

2013-05-11 Thread Heiko Stübner
This series tries to provide a basic dmaengine driver for the s3c24xx SoCs. The driver currently has some limitations, in that it does not support the earlier s3c24xx socs, that cannot use every channel, but have special channel requirements for specific slave-targets. Another limitation is,

[RFC 1/4] ARM: S3C24XX: number the dma clocks

2013-05-11 Thread Heiko Stübner
Each dma channel has its own clock. The upcoming dma driver wants to handle these itself and therefore needs to be able to get the correct clock for a channel. Therefore rename the dma clocks to dma.X for s3c2412, s3c2416 and s3c2443. This does not change the behaviour for the old dma driver at

[RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs

2013-05-11 Thread Heiko Stübner
This adds a new driver to support the s3c24xx dma using the dmaengine and make the old one in mach-s3c24xx obsolete in the long run. Conceptually the s3c24xx-dma feels like a distant relative of the pl08x with numerous virtual channels being mapped to a lot less physical ones. The driver

[RFC 4/4] ARM: SAMSUNG: set s3c24xx_dma_filter for s3c64xx-spi0 device

2013-05-11 Thread Heiko Stübner
The spi-s3c64xx device is also used on the s3c2416 and s3c2443 SoCs. The driver also already uses only generic dma-engine operations. Therefore add another elif to set the s3c24xx filter. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-samsung/devs.c |5 - 1 files

Re: [PATCH V2 1/3] clk: samsung: register audio subsystem clocks using common clock framework

2013-05-11 Thread Sylwester Nawrocki
Hi, On 05/11/2013 12:13 PM, Padma Venkat wrote: +CLK_OF_DECLARE(exynos4210_audss_clk, samsung,exynos4210-audss-clock, + samsung_audss_clk_init); +CLK_OF_DECLARE(exynos5250_audss_clk, samsung,exynos5250-audss-clock, + samsung_audss_clk_init); Also if both

Re: [PATCH v5] pinctrl: Add pinctrl-s3c24xx driver

2013-05-11 Thread Heiko Stübner
Am Freitag, 10. Mai 2013, 02:32:05 schrieb Kukjin Kim: Heiko Stübner wrote: The s3c24xx pins follow a similar pattern as the other Samsung SoCs and can therefore reuse the already introduced infrastructure. The s3c24xx SoCs have one design oddity in that the first 4 external interrupts

RE: [PATCH v5] pinctrl: Add pinctrl-s3c24xx driver

2013-05-11 Thread Kukjin Kim
Heiko Stübner wrote: Am Freitag, 10. Mai 2013, 02:32:05 schrieb Kukjin Kim: Heiko Stübner wrote: The s3c24xx pins follow a similar pattern as the other Samsung SoCs and can therefore reuse the already introduced infrastructure. The s3c24xx SoCs have one design oddity in that the

Re: [PATCH 2/2] ARM: dts: Document DP clock in samsung,exynos5-dp binding

2013-05-11 Thread Doug Anderson
Jingoo, On Sat, May 11, 2013 at 12:43 AM, Jingoo Han jg1@samsung.com wrote: The exynos5-dp node needs a clock specified using the common clock framework. Signed-off-by: Jingoo Han jg1@samsung.com --- Tested on Exynos5250 .../devicetree/bindings/video/exynos_dp.txt|6