Re: [PATCH v2 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-12 Thread Inki Dae
On 2015년 06월 12일 18:05, Marek Szyprowski wrote: Hello, On 2015-06-11 17:04, Inki Dae wrote: On 2015년 06월 03일 17:26, Marek Szyprowski wrote: One should not do any assumptions on the stare of the fimd hardware during driver initialization, so to properly reset fimd before enabling IOMMU, one

[PATCH v3 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-12 Thread Marek Szyprowski
One should not do any assumptions on the stare of the fimd hardware during driver initialization, so to properly reset fimd before enabling IOMMU, one should ensure that all power domains and clocks are really enabled. This patch adds pm_runtime and clocks management in the fimd_clear_channel()

[PATCH v3 (alternative) 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-12 Thread Marek Szyprowski
One should not do any assumptions on the stare of the fimd hardware during driver initialization, so to properly reset fimd before enabling IOMMU, one should ensure that all power domains and clocks are really enabled. This patch adds pm_runtime and clocks management in the fimd_clear_channel()

Re: [PATCH 2/3] ARM: dts: fix the clock-frequency of rinato board's panel

2015-06-12 Thread Krzysztof Kozlowski
2015-06-12 18:27 GMT+09:00 Hyungwon Hwang human.hw...@samsung.com: On Fri, 12 Jun 2015 18:23:18 +0900 Krzysztof Kozlowski k.kozlow...@samsung.com wrote: 2015-06-12 18:03 GMT+09:00 Hyungwon Hwang human.hw...@samsung.com: Because of recent update, proper clock-frequency becomes mandatory for

[PATCH v2 3/3] drm/exynos: initialize VIDCON0 when fimd is disabled

2015-06-12 Thread Joonyoung Shim
When the fimd is disabled by fimd_disable(), enabled overlay layers also are disabled. If clocks for fimd are enabled by fimd_enable() on this case, it can lead IOMMU page fault. The reason is that VIDCON0_ENVID and VIDCON0_ENVID_F bits of VIDCON0 register are set still even though fimd is

Re: [PATCH v2 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-12 Thread Marek Szyprowski
Hello, On 2015-06-11 17:04, Inki Dae wrote: On 2015년 06월 03일 17:26, Marek Szyprowski wrote: One should not do any assumptions on the stare of the fimd hardware during driver initialization, so to properly reset fimd before enabling IOMMU, one should ensure that all power domains and clocks are

Re: [PATCH 1/3] ARM: dts: Add the reference node for syscon to mipi phy for Exynos3250

2015-06-12 Thread Krzysztof Kozlowski
2015-06-12 18:03 GMT+09:00 Hyungwon Hwang human.hw...@samsung.com: Exynos mipi phy driver needs syscon node to be probed successfully. Signed-off-by: Hyungwon Hwang human.hw...@samsung.com --- arch/arm/boot/dts/exynos3250.dtsi | 1 + 1 file changed, 1 insertion(+) Thanks for the patch but

Re: [PATCH 2/3] ARM: dts: fix the clock-frequency of rinato board's panel

2015-06-12 Thread Krzysztof Kozlowski
2015-06-12 18:03 GMT+09:00 Hyungwon Hwang human.hw...@samsung.com: Because of recent update, proper clock-frequency becomes mandatory for validating the mode of panel. This clock-frequency must be set appropriately for getting required frame rate. Signed-off-by: Hyungwon Hwang

[PATCH 2/3] ARM: dts: fix the clock-frequency of rinato board's panel

2015-06-12 Thread Hyungwon Hwang
Because of recent update, proper clock-frequency becomes mandatory for validating the mode of panel. This clock-frequency must be set appropriately for getting required frame rate. Signed-off-by: Hyungwon Hwang human.hw...@samsung.com --- arch/arm/boot/dts/exynos3250-rinato.dts | 2 +- 1 file

Re: [PATCH 2/3] ARM: dts: fix the clock-frequency of rinato board's panel

2015-06-12 Thread Hyungwon Hwang
On Fri, 12 Jun 2015 18:23:18 +0900 Krzysztof Kozlowski k.kozlow...@samsung.com wrote: 2015-06-12 18:03 GMT+09:00 Hyungwon Hwang human.hw...@samsung.com: Because of recent update, proper clock-frequency becomes mandatory for validating the mode of panel. This clock-frequency must be set

[PATCH v2 2/3] drm/exynos: remove chained calls to enable

2015-06-12 Thread Joonyoung Shim
With atomic modesetting all the control for CRTC, Planes, Encoders and Connectors should come from DRM core, so the driver is not allowed to enable or disable planes from inside the crtc_enable()/disable() call. But it needs to disable planes with crtc_disable in exynos driver internally. Because

[PATCH v2 1/3] drm/exynos: remove to call mixer_wait_for_vblank

2015-06-12 Thread Joonyoung Shim
The reason waiting vblank is to be power gated and disabled clocks after dma operation is completed. The dma operation is stopped already before be power gated and clocks are disabled when mixer is disabled by commit 381be025ac1a6(drm/exynos: stop mixer before gating clocks during poweroff). Don't

[PATCH 1/3] ARM: dts: Add the reference node for syscon to mipi phy for Exynos3250

2015-06-12 Thread Hyungwon Hwang
Exynos mipi phy driver needs syscon node to be probed successfully. Signed-off-by: Hyungwon Hwang human.hw...@samsung.com --- arch/arm/boot/dts/exynos3250.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index

Re: [PATCH 01/15] ARM: kill off set_irq_flags usage

2015-06-12 Thread Krzysztof Kozlowski
On 10.06.2015 03:26, Rob Herring wrote: set_irq_flags is ARM specific with custom flags which have genirq equivalents. Convert drivers to use the genirq interfaces directly, so we can kill off set_irq_flags. The translation of flags is as follows: IRQF_VALID - !IRQ_NOREQUEST IRQF_PROBE -

Re: [PATCH 00/21] On-demand device registration

2015-06-12 Thread Linus Walleij
On Thu, Jun 11, 2015 at 6:40 PM, Alexander Holler hol...@ahsoftware.de wrote: Am 11.06.2015 um 14:30 schrieb Linus Walleij: Certainly it is possible to create deadlocks in this scenario, but the scope is not to create an ubreakable system. IAnd what happens if you run into a deadlock? Do you

Re: [PATCH v10 00/17] drm/exynos: atomic modesetting support

2015-06-12 Thread Joonyoung Shim
On 06/11/2015 11:01 PM, Gustavo Padovan wrote: Hi Joonyoung, 2015-06-11 Joonyoung Shim jy0922.s...@samsung.com: On 06/10/2015 10:36 PM, Gustavo Padovan wrote: Hi Marek, 2015-06-10 Marek Szyprowski m.szyprow...@samsung.com: Hello, On 2015-06-01 17:04, Gustavo Padovan wrote: From:

Re: [PATCH v2 1/1] irqchip: exynos-combiner: Save IRQ enable set on suspend

2015-06-12 Thread Javier Martinez Canillas
Hello Sudeep, On 06/12/2015 01:54 PM, Sudeep Holla wrote: On 12/06/15 12:27, Javier Martinez Canillas wrote: Hello Sudeep, Thanks a lot for the feedback. On 06/12/2015 12:10 PM, Sudeep Holla wrote: On 12/06/15 06:43, Javier Martinez Canillas wrote: The Exynos interrupt combiner IP

Re: [PATCH v2 1/1] irqchip: exynos-combiner: Save IRQ enable set on suspend

2015-06-12 Thread Krzysztof Kozlowski
On 12.06.2015 19:10, Sudeep Holla wrote: On 12/06/15 06:43, Javier Martinez Canillas wrote: The Exynos interrupt combiner IP loses its state when the SoC enters into a low power state during a Suspend-to-RAM. This means that if a IRQ is used as a source, the interrupts for the devices are

Re: [PATCH 00/21] On-demand device registration

2015-06-12 Thread Alexander Holler
Am 12.06.2015 um 13:19 schrieb Alexander Holler: Am 12.06.2015 um 09:25 schrieb Linus Walleij: On Thu, Jun 11, 2015 at 6:40 PM, Alexander Holler hol...@ahsoftware.de wrote: Am 11.06.2015 um 14:30 schrieb Linus Walleij: Certainly it is possible to create deadlocks in this scenario, but the

Re: exynos4412: Audio dies after one day on kernel 4.0

2015-06-12 Thread Vinod Koul
On Wed, Jun 10, 2015 at 05:22:07PM +0900, Krzysztof Kozlowski wrote: I can now say for sure that the commits 88987d2c75 and aee4d1fac8 are the cause for the problem. Audio was working now for 7 days. +CC Vinod Gabriel, I sent a patch which should fix the issue. Could you give it a

Re: [PATCH v2 1/1] irqchip: exynos-combiner: Save IRQ enable set on suspend

2015-06-12 Thread Sudeep Holla
On 12/06/15 11:42, Krzysztof Kozlowski wrote: On 12.06.2015 19:10, Sudeep Holla wrote: On 12/06/15 06:43, Javier Martinez Canillas wrote: The Exynos interrupt combiner IP loses its state when the SoC enters into a low power state during a Suspend-to-RAM. This means that if a IRQ is used as

Boot hangs after Starting kernel... message [odroid u3]

2015-06-12 Thread Thomas-Karl Pietrowski
Hello everyone, I'm just trying to get my kernel built for my Odroid U3, but no matter whether I use 4.0.x or the latest code from arm-soc repository 4.1.0-rc3, it ends at this message during boot: ### U-Boot 2015.07-rc1-00408-g012681b (May 30 2015 - 17:49:11 +) CPU:

Re: [PATCH v3 (alternative) 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-12 Thread Inki Dae
On 2015년 06월 12일 18:07, Marek Szyprowski wrote: One should not do any assumptions on the stare of the fimd hardware during driver initialization, so to properly reset fimd before enabling IOMMU, one should ensure that all power domains and clocks are really enabled. This patch adds pm_runtime

Re: [PATCH v3 (alternative) 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-12 Thread Marek Szyprowski
Hello, On 2015-06-12 14:10, Inki Dae wrote: On 2015년 06월 12일 18:07, Marek Szyprowski wrote: One should not do any assumptions on the stare of the fimd hardware during driver initialization, so to properly reset fimd before enabling IOMMU, one should ensure that all power domains and clocks are

[PATCH v2] ARM: dts: fix the clock-frequency of rinato board's panel

2015-06-12 Thread Hyungwon Hwang
After the commit abc0b1447d4974963548777a5ba4a4457c82c426 (drm: Perform basic sanity checks on probed modes), proper clock-frequency becomes mandatory for validating the mode of panel. The display does not work if there is no mode validated. Also, this clock-frequency must be set appropriately for

Re: [PATCH 00/21] On-demand device registration

2015-06-12 Thread Alexander Holler
Am 12.06.2015 um 09:25 schrieb Linus Walleij: On Thu, Jun 11, 2015 at 6:40 PM, Alexander Holler hol...@ahsoftware.de wrote: Am 11.06.2015 um 14:30 schrieb Linus Walleij: Certainly it is possible to create deadlocks in this scenario, but the scope is not to create an ubreakable system. IAnd

Re: [PATCH v2 1/1] irqchip: exynos-combiner: Save IRQ enable set on suspend

2015-06-12 Thread Javier Martinez Canillas
Hello Sudeep, Thanks a lot for the feedback. On 06/12/2015 12:10 PM, Sudeep Holla wrote: On 12/06/15 06:43, Javier Martinez Canillas wrote: The Exynos interrupt combiner IP loses its state when the SoC enters into a low power state during a Suspend-to-RAM. This means that if a IRQ is

Re: [PATCH v2 1/1] irqchip: exynos-combiner: Save IRQ enable set on suspend

2015-06-12 Thread Sudeep Holla
On 12/06/15 06:43, Javier Martinez Canillas wrote: The Exynos interrupt combiner IP loses its state when the SoC enters into a low power state during a Suspend-to-RAM. This means that if a IRQ is used as a source, the interrupts for the devices are disabled when the system is resumed from a

Re: [PATCH v2 1/1] irqchip: exynos-combiner: Save IRQ enable set on suspend

2015-06-12 Thread Sudeep Holla
On 12/06/15 12:27, Javier Martinez Canillas wrote: Hello Sudeep, Thanks a lot for the feedback. On 06/12/2015 12:10 PM, Sudeep Holla wrote: On 12/06/15 06:43, Javier Martinez Canillas wrote: The Exynos interrupt combiner IP loses its state when the SoC enters into a low power state

Re: Boot hangs after Starting kernel... message [odroid u3]

2015-06-12 Thread Marek Szyprowski
Hello, On 2015-06-12 14:00, Thomas-Karl Pietrowski wrote: Hello everyone, I'm just trying to get my kernel built for my Odroid U3, but no matter whether I use 4.0.x or the latest code from arm-soc repository 4.1.0-rc3, it ends at this message during boot: ### U-Boot

Re: exynos4412: Audio dies after one day on kernel 4.0

2015-06-12 Thread gabriel
On 06/10/2015 10:22 AM, Krzysztof Kozlowski wrote: 2015-06-09 20:25 GMT+09:00 gabr...@unseen.is: On 06/03/2015 02:05 AM, Krzysztof Kozlowski wrote: On 03.06.2015 04:51, gabr...@unseen.is wrote: On 05/31/2015 08:47 AM, Krzysztof Kozlowski wrote: 2015-05-31 2:32 GMT+09:00 gabr...@unseen.is:

Re: [PATCH v2 1/1] irqchip: exynos-combiner: Save IRQ enable set on suspend

2015-06-12 Thread Doug Anderson
Hi, On Fri, Jun 12, 2015 at 12:36 PM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: registers are lost assuming the combiner was powered down, even the status register will be lost and you will not know exactly the wakeup reason right ? Good question, I didn't find in the

Re: [PATCH v2 1/1] irqchip: exynos-combiner: Save IRQ enable set on suspend

2015-06-12 Thread Javier Martinez Canillas
Hello Sudeep, On 06/12/2015 02:57 PM, Javier Martinez Canillas wrote: On 06/12/2015 01:54 PM, Sudeep Holla wrote: [snip] registers are lost assuming the combiner was powered down, even the status register will be lost and you will not know exactly the wakeup reason right ? Good

Re: exynos4412: Audio dies after one day on kernel 4.0

2015-06-12 Thread Krzysztof Kozlowski
W dniu 13.06.2015 o 06:48, gabr...@unseen.is pisze: On 06/10/2015 10:22 AM, Krzysztof Kozlowski wrote: 2015-06-09 20:25 GMT+09:00 gabr...@unseen.is: On 06/03/2015 02:05 AM, Krzysztof Kozlowski wrote: On 03.06.2015 04:51, gabr...@unseen.is wrote: On 05/31/2015 08:47 AM, Krzysztof Kozlowski

Re: [PATCH 4/9] tests/exynos: clean struct connector

2015-06-12 Thread Emil Velikov
On 10 June 2015 at 14:42, Tobias Jakobi tjak...@math.uni-bielefeld.de wrote: Remove all unused struct members. Mentioning if they were used at some point in the past will be great. Thanks Emil Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- tests/exynos/exynos_fimg2d_test.c

Re: [PATCH 8/9] tests/exynos: remove connector_find_plane

2015-06-12 Thread Emil Velikov
On 10 June 2015 at 14:42, Tobias Jakobi tjak...@math.uni-bielefeld.de wrote: No test uses DRM planes at the moment so this function is never called. Similar to the other patch - mention if this been used previously. I'm assuming that the exynos guys might have some work stashed which depends on

Re: [PATCH 1/9] exynos: fimg2d: fix return codes

2015-06-12 Thread Tobias Jakobi
Hello Emil, Emil Velikov wrote: On 10 June 2015 at 14:42, Tobias Jakobi tjak...@math.uni-bielefeld.de wrote: Even if flushing the command buffer doesn't succeed, the G2D calls would still return zero. Fix this by just passing the flush return code. Signed-off-by: Tobias Jakobi

Re: [PATCH 4/9] tests/exynos: clean struct connector

2015-06-12 Thread Tobias Jakobi
Hello Emil, Emil Velikov wrote: On 10 June 2015 at 14:42, Tobias Jakobi tjak...@math.uni-bielefeld.de wrote: Remove all unused struct members. Mentioning if they were used at some point in the past will be great. OK, I'll take a look at git history but AFAIK it is not. With best wishes,

Re: [PATCH 6/9] tests/exynos: remove struct fimg2d_test_case

2015-06-12 Thread Tobias Jakobi
Hello Emil, Emil Velikov wrote: On 10 June 2015 at 14:42, Tobias Jakobi tjak...@math.uni-bielefeld.de wrote: It doesn't make sense to keep this structure, since we can just call all tests directly. Seems like it was designed in mind of having another test case. Perhaps the exynos guys

Re: [PATCH 01/15] ARM: kill off set_irq_flags usage

2015-06-12 Thread Hans Ulli Kroll
On Fri, 12 Jun 2015, Rob Herring wrote: On Fri, Jun 12, 2015 at 9:05 AM, Hans Ulli Kroll ulli.kr...@googlemail.com wrote: On Tue, 9 Jun 2015, Rob Herring wrote: set_irq_flags is ARM specific with custom flags which have genirq equivalents. Convert drivers to use the genirq

Re: [PATCH v3 (alternative) 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-12 Thread Inki Dae
On 2015년 06월 12일 21:10, Inki Dae wrote: On 2015년 06월 12일 18:07, Marek Szyprowski wrote: One should not do any assumptions on the stare of the fimd hardware during driver initialization, so to properly reset fimd before enabling IOMMU, one should ensure that all power domains and clocks are

Re: [PATCH 1/9] exynos: fimg2d: fix return codes

2015-06-12 Thread Emil Velikov
On 10 June 2015 at 14:42, Tobias Jakobi tjak...@math.uni-bielefeld.de wrote: Even if flushing the command buffer doesn't succeed, the G2D calls would still return zero. Fix this by just passing the flush return code. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de ---

Re: Feedback on hardware support for Odroid U3

2015-06-12 Thread Thomas-Karl Pietrowski
Am Freitag, 12. Juni 2015, 17:46:11 schrieb Mateusz Krawczuk: Could you send your config and log using gist.github.com, because pastebin.com is forbidden by company IT. Mateusz Krawczuk Samsung RD Institute Poland W dniu 12.06.2015 o 15:53, Thomas Pietrowski pisze: Hello again,

[PATCH] drm/exynos: fimd: fix page fault issue with iommu

2015-06-12 Thread Inki Dae
This patch resolves page fault issue with iommu and atomic feature when modetest test application is terminated. ENWIN_F field of WINCONx register enables or disable a dma channel to each hardware overlay - the value of the field will be updated to real register after vsync. So this patch makes

Feedback on hardware support for Odroid U3

2015-06-12 Thread Thomas Pietrowski
Hello again, first after fixing my booting problems I now get different warnings after boot. - config: http://pastebin.com/MHUu51pF - log: http://pastebin.com/9YMgMmFL - repo: arm-soc I read the last days that you are still working on the clk drivers, so as these warnings appear to be related to

[PATCH v2 6/9] tests/exynos: remove struct fimg2d_test_case

2015-06-12 Thread Tobias Jakobi
It doesn't make sense to keep this structure, since we can just call all tests directly. An inspection of the git history shows that no code ever used this abstraction in the past. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- tests/exynos/exynos_fimg2d_test.c | 42

[PATCH v2 5/9] tests/exynos: remove unused define

2015-06-12 Thread Tobias Jakobi
It doesn't make sense to limit the number of test cases anyway. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- tests/exynos/exynos_fimg2d_test.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/exynos/exynos_fimg2d_test.c b/tests/exynos/exynos_fimg2d_test.c index

[PATCH v2 7/9] tests/exynos: simplify drm_set_crtc

2015-06-12 Thread Tobias Jakobi
We can just return 'ret' here, the goto serves no purpose. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- tests/exynos/exynos_fimg2d_test.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tests/exynos/exynos_fimg2d_test.c

[PATCH v2 8/9] tests/exynos: remove connector_find_plane

2015-06-12 Thread Tobias Jakobi
No test uses DRM planes at the moment so this function is never called. Inspection of the git history shows that DRM planes were also never used in these tests in the past. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- tests/exynos/exynos_fimg2d_test.c | 31

[PATCH v2 9/9] tests/exynos: handle G2D_IMGBUF_COLOR in switch statements

2015-06-12 Thread Tobias Jakobi
This fixes a compiler warning about missing handling of enum values in the switch statements. Also remove the silent mapping to G2D_IMGBUF_GEM when an unknown buffer type is encountered. We have full control about the type here, and if it's unknown then we obviously have a bug in the code.

[PATCH v2 2/9] tests/exynos: replace return by break

2015-06-12 Thread Tobias Jakobi
The 'usage' function already does exit(0), so that this 'return -EINVAL' is never called. Just put a break there to avoid confusion. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- tests/exynos/exynos_fimg2d_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 0/9] drm/exynos: cleanups and small fixes for libdrm

2015-06-12 Thread Tobias Jakobi
Hello, I've split off the Exynos specific bits, so this is just some cleanups and small fixes. Everything can be reviewed without knowledge about the Exynos platform. My hope is that I can get at least some of the patches from my last series upstream. With best wishes, Tobias Changes in v2:

[PATCH v2 1/9] exynos: fimg2d: fix return codes

2015-06-12 Thread Tobias Jakobi
Even if flushing the command buffer doesn't succeed, the G2D calls would still return zero. Fix this by just passing the flush return code. In fact error handling currently ignores the fact that g2d_add_cmd() can fail. This is going to be handled in a later patch. Signed-off-by: Tobias Jakobi

[PATCH v2 3/9] exynos/fimg2d: simplify g2d_fini()

2015-06-12 Thread Tobias Jakobi
free()ing a nullptr is a noop, so remove the check. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c index 5ea42e6..24a06d0 100644 ---