Re: [PATCH V5 5/5] ARM: exynos: Enable l2 configuration through device tree

2012-01-04 Thread Amit Kachhap
On 5 January 2012 10:06, Olof Johansson wrote: > On Wed, Jan 4, 2012 at 8:25 PM, Amit Daniel Kachhap > wrote: >> This patch enables calling generic l2 setup functions if device tree is used. >> >> Signed-off-by: Amit Daniel Kachhap >> --- >>  arch/arm/mach-exynos/common.c |   14 -- >

Re: [lm-sensors] [RFC PATCH 2/3] thermal: exynos4: Register the tmu sensor with the thermal interface layer

2012-01-04 Thread Donggeun Kim
Actually, the TMU driver is closely related to thermal layer. I think it's okay to move it to the thermal. Thanks. -Donggeun On 2012년 01월 04일 19:14, Amit Kachhap wrote: > Hi Guenter, > > The main idea of this work is to leave the current userspace based > notification scheme and add the kernel b

Re: [PATCH V5 5/5] ARM: exynos: Enable l2 configuration through device tree

2012-01-04 Thread Olof Johansson
On Wed, Jan 4, 2012 at 8:25 PM, Amit Daniel Kachhap wrote: > This patch enables calling generic l2 setup functions if device tree is used. > > Signed-off-by: Amit Daniel Kachhap > --- >  arch/arm/mach-exynos/common.c |   14 -- >  1 files changed, 12 insertions(+), 2 deletions(-) > > d

[PATCH V5 5/5] ARM: exynos: Enable l2 configuration through device tree

2012-01-04 Thread Amit Daniel Kachhap
This patch enables calling generic l2 setup functions if device tree is used. Signed-off-by: Amit Daniel Kachhap --- arch/arm/mach-exynos/common.c | 14 -- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c

[PATCH V5 4/5] ARM: exynos: remove useless code to save/restore L2

2012-01-04 Thread Amit Daniel Kachhap
Following the merge of CPU PM notifiers and L2 resume code, this patch removes useless code to save and restore L2 registers. This is now automatically covered by suspend calls which integrated CPU PM notifiers and new sleep code that allows to resume L2 before MMU is turned on. Signed-off-by: Lo

[PATCH V5 3/5] ARM: exynos: save L2 settings during bootup

2012-01-04 Thread Amit Daniel Kachhap
This patch adds code to save L2 register configuration at boot, and later used to resume L2 before MMU is enabled in suspend and cpuidle resume paths. Signed-off-by: Lorenzo Pieralisi Signed-off-by: Amit Daniel Kachhap --- arch/arm/mach-exynos/common.c | 42 ++-

[PATCH V5 2/5] ARM: s5p: add L2 early resume code

2012-01-04 Thread Amit Daniel Kachhap
This patch adds code to resume L2 before MMU is enabled in suspend and cpuidle resume paths. s3c_cpu_resume is moved to the data section with appropriate comments. Signed-off-by: Lorenzo Pieralisi Signed-off-by: Amit Daniel Kachhap --- arch/arm/plat-s5p/sleep.S | 44 ++

[PATCH V5 1/5] ARM: exynos: Add support AFTR mode on EXYNOS4210

2012-01-04 Thread Amit Daniel Kachhap
This patch adds support AFTR(ARM OFF TOP RUNNING) mode in cpuidle driver. L2 cache keeps their data in this mode. This patch ports the code to the latest interfaces to save/restore CPU state inclusive of CPU PM notifiers, l2 resume and cpu_suspend/resume. Signed-off-by: Jaecheol Lee Signed-off-by

[PATCH V5 0/5] ARM: exynos: Add l2 retention mode cpuidle state

2012-01-04 Thread Amit Daniel Kachhap
Changes since V4: *Rebased the patchset against for-next of samsung kernel tree. *Added Tushar suggestion of putting a check if L2 cache dt node not found. *Added Inder suggestion of removing the BUG_ON check in cpuidle driver. Changes since V3: *Implemented Russell feedback and moved sleep magic

Re: [PATCH V4 0/5] ARM: exynos: Add l2 retention mode cpuidle state

2012-01-04 Thread Amit Kachhap
On 3 January 2012 18:52, Kukjin Kim wrote: > amit kachhap wrote: >> >> Hi Mr kim, >> >> All the comments have been addressed for the Exynos cpu idle patchset. >> The updated patchset was posted about one month back and there have >> been no further comments on the patchset since then. >> >> As thi

Re: [PATCH] mmc: dw_mmc: Clear the DDR mode for non-DDR

2012-01-04 Thread Chris Ball
Hi, On Tue, Jan 03 2012, Will Newton wrote: > On Mon, Jan 2, 2012 at 7:00 AM, Seungwon Jeon wrote: >> UHS_REG should be cleared for non-DDR mode. But currently there is >> no way to clear DDR mode, if it is already set once. This patch adds >> clearing DDR mode for non-DDD mode. >> >> Signed-off-

RE: [PATCH] rtc-s3c: Fix breakage introduced by S3C2443/S3C2416 support

2012-01-04 Thread Kukjin Kim
Heiko Stübner wrote: > > Commits 7006ee4f (rtc-s3c: make room for more variants in devicetree block) > and 6c0a2365 (rtc-s3c: add variants for S3C2443 and S3C2416) > introduced build-failures with enabled CONFIG_USE_OF option. > > This patch fixes missing "," in s3c_rtc_dt_match and wrong handlin

RE: [PATCH 2/4] rtc-s3c: make room for more variants in devicetree block

2012-01-04 Thread Kukjin Kim
Heiko Stübner wrote: > > Hi Kgene, > > Am Mittwoch, 4. Januar 2012, 12:51:41 schrieb Heiko Stübner: > > Hi Sylwester, > > > > Am Mittwoch, 4. Januar 2012, 11:43:45 schrieb Sylwester Nawrocki: > > > Hello, > > > > > > On 12/21/2011 10:16 AM, Heiko Stübner wrote: > > > > Use the data field of of_d

Re: [PATCH 1/4] ARM: SAMSUNG: cleanup of rtc register definitions

2012-01-04 Thread Russell King - ARM Linux
On Wed, Jan 04, 2012 at 03:15:44PM +0100, Heiko Stübner wrote: > regs-rtc.h uses a mixture of tabs and spaces and also (x< to format bits. So, before adding new stuff clean up the formatting > and also add spaces to the bit definitions (i.e. (x << y) ) Ok, so this is just a formatting change - and

Re: [PATCH v8 0/2] ommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2012-01-04 Thread Russell King - ARM Linux
On Wed, Jan 04, 2012 at 04:01:01PM +0100, Joerg Roedel wrote: > On Tue, Jan 03, 2012 at 09:55:27AM +, Russell King - ARM Linux wrote: > > It comes through when I stick it in my tree because of a month of asking > > for help to fix something and getting zero response from the maintainers. > > >

RE: [linux-pm] [lm-sensors] [RFC PATCH 2/3] thermal: exynos4: Register the tmu sensor with the thermal interface layer

2012-01-04 Thread Guenter Roeck
On Wed, 2012-01-04 at 05:23 -0500, R, Durgadoss wrote: > Hi Amit Daniel, > > > Hi Guenter, > > > > The main idea of this work is to leave the current userspace based > > notification scheme and add the kernel based cooling scheme on top of > > it. Anyway, It is a good idea to move the file hwmon/

Re: [PATCH 6/6] mmc: sdhci-s3c: Add device tree support

2012-01-04 Thread Sylwester Nawrocki
Hi Kgene, Thomas On 11/08/2011 04:23 PM, Thomas Abraham wrote: > Hi Grant, > > On 8 November 2011 02:47, Grant Likely wrote: >> On Thu, Nov 03, 2011 at 02:06:03AM +0530, Thomas Abraham wrote: >>> Add device tree based discovery support for Samsung's sdhci controller >>> >>> Cc: Ben Dooks >>> Si

Re: [PATCH v8 0/2] ommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2012-01-04 Thread Joerg Roedel
On Tue, Jan 03, 2012 at 09:55:27AM +, Russell King - ARM Linux wrote: > On Mon, Jan 02, 2012 at 04:58:20PM +0100, Joerg Roedel wrote: > > On Tue, Jan 03, 2012 at 12:21:30AM +0900, KyongHo Cho wrote: > > > > I still get > > > > > > > >  LD      .tmp_vmlinux1 > > > > /data/cross/gcc-4.6.0-nolibc/

[PATCH 4/4] ARM: S3C2443/S3C2416: add s3c_rtc_setname and rename rtc devices

2012-01-04 Thread Heiko Stübner
As the S3C24xx SoCs use the same rtc device a renaming capability like in the adc driver is necessary. This patch adds a s3c_rtc_setname function and names the rtc devices for S3C2443 and S3C2416 accordingly. Signed-off-by: Heiko Stuebner Signed-off-by: Kukjin Kim --- arch/arm/mach-s3c2416/s3c

[PATCH 3/4] rtc-s3c: add variants for S3C2443 and S3C2416

2012-01-04 Thread Heiko Stübner
Especially the TICNT registers are different from the two rtc types that currently exists. Signed-off-by: Heiko Stuebner Acked-by: Alessandro Zummo Signed-off-by: Kukjin Kim --- arch/arm/plat-samsung/include/plat/regs-rtc.h | 17 ++ drivers/rtc/rtc-s3c.c | 4

[PATCH 2/4] rtc-s3c: make room for more variants in devicetree block

2012-01-04 Thread Heiko Stübner
Use the data field of of_device_id to hold the type for s3c_cpu_type. Signed-off-by: Heiko Stuebner Reviewed-by: Thomas Abraham Acked-by: Alessandro Zummo Signed-off-by: Kukjin Kim --- drivers/rtc/rtc-s3c.c | 31 ++- 1 files changed, 22 insertions(+), 9 deletions

[PATCH 1/4] ARM: SAMSUNG: cleanup of rtc register definitions

2012-01-04 Thread Heiko Stübner
regs-rtc.h uses a mixture of tabs and spaces and also (x< Signed-off-by: Kukjin Kim --- arch/arm/plat-samsung/include/plat/regs-rtc.h | 78 ++--- 1 files changed, 32 insertions(+), 46 deletions(-) diff --git a/arch/arm/plat-samsung/include/plat/regs-rtc.h b/arch/arm/plat-s

[PATCH v4 0/4] Implement RTC support for S3C2443/S3C2416/S3C2450

2012-01-04 Thread Heiko Stübner
Similar to the ADC the RTC of S3C2443 and S3C2416/2450 has some slight variances when compared to the existing types. This series adds support for those SoCs. As with the ADC patches, these changes where tested on S3C2416 hardware. The S3C2443 quirks are a subset of those and are done according t

[PATCH] rtc-s3c: Fix breakage introduced by S3C2443/S3C2416 support

2012-01-04 Thread Heiko Stübner
Commits 7006ee4f (rtc-s3c: make room for more variants in devicetree block) and 6c0a2365 (rtc-s3c: add variants for S3C2443 and S3C2416) introduced build-failures with enabled CONFIG_USE_OF option. This patch fixes missing "," in s3c_rtc_dt_match and wrong handling of the of_device_id.data propert

Re: [PATCH 2/4] rtc-s3c: make room for more variants in devicetree block

2012-01-04 Thread Heiko Stübner
Hi Kgene, Am Mittwoch, 4. Januar 2012, 12:51:41 schrieb Heiko Stübner: > Hi Sylwester, > > Am Mittwoch, 4. Januar 2012, 11:43:45 schrieb Sylwester Nawrocki: > > Hello, > > > > On 12/21/2011 10:16 AM, Heiko Stübner wrote: > > > Use the data field of of_device_id to hold the type for > > > s3c_cpu

Re: [PATCH 2/4] rtc-s3c: make room for more variants in devicetree block

2012-01-04 Thread Heiko Stübner
Hi Sylwester, Am Mittwoch, 4. Januar 2012, 11:43:45 schrieb Sylwester Nawrocki: > Hello, > > On 12/21/2011 10:16 AM, Heiko Stübner wrote: > > Use the data field of of_device_id to hold the type for > > s3c_cpu_type. > > > > Signed-off-by: Heiko Stuebner > > Reviewed-by: Thomas Abraham > > ---

Re: [PATCH 2/4] rtc-s3c: make room for more variants in devicetree block

2012-01-04 Thread Sylwester Nawrocki
Hello, On 12/21/2011 10:16 AM, Heiko Stübner wrote: > Use the data field of of_device_id to hold the type for > s3c_cpu_type. > > Signed-off-by: Heiko Stuebner > Reviewed-by: Thomas Abraham > --- > drivers/rtc/rtc-s3c.c | 31 ++- > 1 files changed, 22 insertions(+

RE: [linux-pm] [lm-sensors] [RFC PATCH 2/3] thermal: exynos4: Register the tmu sensor with the thermal interface layer

2012-01-04 Thread R, Durgadoss
Hi Amit Daniel, > Hi Guenter, > > The main idea of this work is to leave the current userspace based > notification scheme and add the kernel based cooling scheme on top of > it. Anyway, It is a good idea to move the file hwmon/exynos4_tmu.c as But, What I feel is, kernel based cooling scheme wi

Re: [lm-sensors] [RFC PATCH 2/3] thermal: exynos4: Register the tmu sensor with the thermal interface layer

2012-01-04 Thread Amit Kachhap
Hi Guenter, The main idea of this work is to leave the current userspace based notification scheme and add the kernel based cooling scheme on top of it. Anyway, It is a good idea to move the file hwmon/exynos4_tmu.c as this creates 2 hwmon entries. Adding CC: Donggeun Kim to know his opinion. Tha