RE: [PATCH V5 00/15] To use DMA generic APIs for Samsung DMA

2011-08-11 Thread Kukjin Kim
your slave-dma tree also for same reason. git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git #next/topic-dma-pl330 Or if you want to make some branch for it in your tree, please let me know so that I can merge it in my tree also. Thanks. Best regards, Kgene. -- Ku

RE: [PATCH 2/4] ARM: S5P: add support for tv device

2011-08-11 Thread Kukjin Kim
O, > + .flags = IORESOURCE_IRQ, > + } > +}; > + > +struct platform_device s5p_device_sdo = { > + .name = "s5p-sdo", > + .id = -1, > + .num_resources = ARRAY_SIZE(s5p_sdo_resources), > + .resource = s5p_s

RE: [PATCH 1/4] ARM: Samsung: add i2c hdmiphy controller definitions

2011-08-11 Thread Kukjin Kim
ed, I will do it. > + > +#define S5P_IIC_HDMIPHY_BUS_NUM (8) Same as above. (snip) Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH] ARM: Exynos4: enable frame buffer on Universal C210 board

2011-08-11 Thread Kukjin Kim
versal_touchkey_init(); > i2c_register_board_info(I2C_GPIO_BUS_12, i2c_gpio12_devs, > ARRAY_SIZE(i2c_gpio12_devs)); > @@ -758,6 +791,7 @@ static void __init universal_machine_init(void) > /* Last */ > platform_add_devices(universal_devices, > ARRAY_SIZE(univer

RE: [PATCH] ARM: Exynos4: enable frame buffer on Nuri board

2011-08-11 Thread Kukjin Kim
2,12 +1173,15 @@ static void __init nuri_machine_init(void) > i2c9_devs[I2C9_MAX17042].irq = gpio_to_irq(EXYNOS4_GPX2(3)); > i2c_register_board_info(9, i2c9_devs, ARRAY_SIZE(i2c9_devs)); > > + s5p_fimd0_set_platdata(&nuri_fb_pdata); > + > nuri_ehci_ini

RE: [PATCH] ARM: Samsung: fix watchdog reset issue with clk_get()

2011-08-11 Thread Kukjin Kim
deletions(-) > (snip) > +void s3c_wdt_reset_init(void) +void __init s3c_wdt_reset_init(void) (snip) > +extern void s3c_wdt_reset_init(void); +extern void __init s3c_wdt_reset_init(void); (snip) Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, S

RE: [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations

2011-08-11 Thread Kukjin Kim
tation/gpio.txt > > Signed-off-by: Russell King Acked-by: Kukjin Kim on following Samsung stuff... As a note, there were duplicated e-mail address Grant and Nicolas in Cc ;) I just pushed 'reply all' :) Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Developme

RE: [PATCH 12/13] ARM: gpio: consolidate gpio_to_irq

2011-08-11 Thread Kukjin Kim
hich do not use the standard definition. > > Signed-off-by: Russell King Acked-by: Kukjin Kim on following Samsung stuff :) Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. > --- > arch/arm/include/asm/gp

RE: [PATCH 13/13] ARM: gpio: make trivial GPIOLIB implementation the default

2011-08-11 Thread Kukjin Kim
ething extra if you need to. This should > encourage the use of the trivial default implementation. > > As an additional bonus, several gpio.h header files become empty. > > Signed-off-by: Russell King Looks good to me :) Acked-by: Kukjin Kim on following Samsung stuff...

RE: [PATCH] ARM: EXYNOS4: Update config file of NURI to enable RTC

2011-08-12 Thread Kukjin Kim
4210 > select S3C_DEV_WDT > + select S3C_DEV_RTC > select S3C_DEV_HSMMC > select S3C_DEV_HSMMC2 > select S3C_DEV_HSMMC3 > -- > 1.7.0.4 Applied, thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronic

RE: [PATCH] ARM: EXYNOS4: Fix wrong devname to support clkdev

2011-08-12 Thread Kukjin Kim
= "ac97", > - .id = -1, > + .devname= "samsung-ac97", > .enable = exynos4_clk_ip_peril_ctrl, > .ctrlbit= (1 << 27), > }, { > -- > 1.7.1 OK, applied. Thanks. Best regard

RE: [PATCH] ARM: EXYNOS4: Enable MFC on Samsung SMDKV310

2011-08-12 Thread Kukjin Kim
+270,5 @@ MACHINE_START(SMDKV310, "SMDKV310") > .map_io = smdkv310_map_io, > .init_machine = smdkv310_machine_init, > .timer = &exynos4_timer, > + .reserve= &smdkv310_reserve, > MACHINE_END > -- > 1.7.4.1 OK, ap

RE: [RFC][PATCH] serial: samsung: Use single interrupt handler for s3c64xx and higher SoC's

2011-08-12 Thread Kukjin Kim
as the changes > are generic). This is a bulky patch but it will split into smaller patches > if the approach is acceptable. > Hi Thomas, Hmm, could you please test this on other boards before split? And I need to check whether this is available on s3c24xx SoCs or not... Thanks. Be

RE: [PATCH] ARM: EXYNOS4: Fix the IRQ definitions for MIPI CSIS device

2011-08-12 Thread Kukjin Kim
al GIC" > > Would be good to also cite that commit's ID for gitweb. > Yes, I think so :) Sylwester, This is required now so I added commit id when I applied. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics C

RE: [PATCH 0/2] Fixes for S5PV210 PM

2011-08-12 Thread Kukjin Kim
6 -- > arch/arm/mach-s5pv210/Makefile |2 +- > arch/arm/mach-s5pv210/pm.c |2 +- > 3 files changed, 2 insertions(+), 8 deletions(-) > > -- > 1.7.4.1 Looks ok, applied. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Sam

RE: [PATCH] ARM: S3C64XX: Fix build break in PM debug

2011-08-12 Thread Kukjin Kim
t; 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-s3c64xx/pm.c b/arch/arm/mach-s3c64xx/pm.c > index 8bad643..055e285 100644 > --- a/arch/arm/mach-s3c64xx/pm.c > +++ b/arch/arm/mach-s3c64xx/pm.c > @@ -16,6 +16,7 @@ > #include > #include

RE: [PATCH 0/2] Chained irq fixes

2011-08-12 Thread Kukjin Kim
|6 ++ > 2 files changed, 13 insertions(+), 0 deletions(-) > > -- > 1.7.1.569.g6f426 OK, applied. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "uns

RE: [PATCH V5 00/15] To use DMA generic APIs for Samsung DMA

2011-08-12 Thread Kukjin Kim
Koul, Vinod wrote: > > On Thu, 2011-08-11 at 16:26 +0900, Kukjin Kim wrote: > > Koul, Vinod wrote: > > > > > > On Thu, 2011-08-04 at 18:53 +0200, Linus Walleij wrote: > > > > On Wed, Jul 27, 2011 at 7:31 AM, Boojin Kim > wrote: > > > >

RE: [PATCH] ARM: EXYNOS4: Increase reset delay for USB HOST PHY

2011-08-18 Thread Kukjin Kim
); > - udelay(50); > + udelay(80); > > clk_disable(otg_clk); > clk_put(otg_clk); > -- > 1.7.1 OK, will apply. But I'm not sure why extra time is required on current kernel not on old kernel... Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer,

RE: [PATCH] ARM: S3C64XX: Remove un-used code

2011-08-18 Thread Kukjin Kim
= "pwm-backlight", > - .dev= { > - .parent = &s3c_device_timer[1].dev, > - .platform_data = &smdk6410_backlight_data, > - }, > -}; > - > static struct map_desc smdk6410_iodesc[] = {}; > > static struct platform_devi

RE: [PATCH 0/2] Remove hw_addr dma leftovers from S3C24xx machs

2011-08-18 Thread Kukjin Kim
| 17 - > arch/arm/mach-s3c2443/dma.c | 27 -- > arch/arm/plat-samsung/include/plat/dma-s3c24xx.h |6 - > 5 files changed, 0 insertions(+), 82 deletions(-) > > -- > 1.7.5.4 Good :) Applied, thanks. Best regards,

RE: [PATCH V5 00/15] To use DMA generic APIs for Samsung DMA

2011-08-18 Thread Kukjin Kim
Koul, Vinod wrote: > > On Sat, 2011-08-13 at 13:11 +0900, Kukjin Kim wrote: > > Koul, Vinod wrote: > > > > > > On Thu, 2011-08-11 at 16:26 +0900, Kukjin Kim wrote: > > > > Koul, Vinod wrote: > > > > > > > > > > On Thu, 20

RE: [PATCH] ARM: SAMSUNG: Consolidate common function to set SDHCI plat data

2011-08-18 Thread Kukjin Kim
#include > +#include > > void __init *s3c_set_platdata(void *pd, size_t pdsize, > struct platform_device *pdev) > @@ -35,3 +36,24 @@ void __init *s3c_set_platdata(void *pd, size_t pdsize, > pdev->dev.platform_data = npd; > return np

RE: [PATCH 1/2] ARM: Samsung: Add chained enrty/exit call to timer interrupt handler

2011-08-18 Thread Kukjin Kim
> + chained_irq_enter(chip, desc); > generic_handle_irq((int)desc->irq_data.handler_data); > + chained_irq_exit(chip, desc); > } > > /* We assume the IRQ_TIMER0..IRQ_TIMER4 range is continuous. */ > -- > 1.7.1.569.g6f426 OK, applied. Thanks. Best regards, Kgen

RE: [PATCH] ARM: S5P64X0: Add the devname for DMA clock

2011-08-18 Thread Kukjin Kim
l330", > .parent = &clk_hclk_low.clk, > .enable = s5p64x0_hclk0_ctrl, > .ctrlbit= (1 << 12), > -- > 1.7.1 OK, will apply. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development

RE: [PATCH 0/3] ARM: Samsung: use dma-pl330 device name for clock

2011-08-18 Thread Kukjin Kim
ged, 6 insertions(+), 6 deletions(-) > > -- > 1.7.5.1 OK, will apply. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc

RE: [PATCH] ARM: S3C64XX: Remove un-used code

2011-08-18 Thread Kukjin Kim
ame purpose. > > Ideally your commit log should make this clear - it looks like you're > just deleting unreferenced code. Yes, I agree with your opinion...It was difficult to know why it is un-used code when I applied that. OK, I will amend its commit log in my tree to clear. Thanks

RE: [GIT PULL] Samsung S5P for v3.1 merge window

2011-08-18 Thread Kukjin Kim
Tushar Behera wrote: > > Hi Arnd, > > On Thursday 21 July 2011 03:21 PM, Kukjin Kim wrote: > > Hi Arnd > > > > Please pull Samsung S5P updates from: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git > > for-arm-soc >

RE: [PATCH] ARM:EXYNOS4: Add the missing clock of EXYNOS4210 to remove leakage power

2011-08-18 Thread Kukjin Kim
clocks in boot loader. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org

RE: [PATCH v3] ARM: Samsung: fix watchdog reset issue with clk_get()

2011-08-19 Thread Kukjin Kim
scripts/checksyscalls.sh CHK include/generated/compile.h KSYM.tmp_kallsyms1.S AS .tmp_kallsyms1.o LD .tmp_vmlinux2 KSYM.tmp_kallsyms2.S AS .tmp_kallsyms2.o LD vmlinux SYSMAP System.map SYSMAP .tmp_System.map Inconsistent kallsyms data This is a bug - please report about it Tr

RE: [PATCH] ARM: SAMSUNG: TSADC: Remove unnecessary duplication of plat_data

2011-08-19 Thread Kukjin Kim
/arm/plat-samsung/dev-ts.c b/arch/arm/plat-samsung/dev-ts.c > index 82543f0..5f3d46a 100644 > --- a/arch/arm/plat-samsung/dev-ts.c > +++ b/arch/arm/plat-samsung/dev-ts.c > @@ -43,8 +43,17 @@ struct platform_device s3c_device_ts = { > .resource = s3c_ts_resource, > }

RE: [PATCH] ARM: S5P: fix bug in spdif_clk_get_rate

2011-08-19 Thread Kukjin Kim
INVAL; > > - rate = pclk->ops->get_rate(clk); > + rate = pclk->ops->get_rate(pclk); > clk_put(pclk); > > return rate; > -- > 1.7.2.3 Yes, applied. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development

[PATCH] ARM: EXYNOS4: Remove useless codes on NURI board

2011-08-19 Thread Kukjin Kim
The 'nuri_cm_devices' is defined but not used. Cc: Kyungmin Park Signed-off-by: Kukjin Kim --- arch/arm/mach-exynos4/mach-nuri.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/arch/arm/mach-exynos4/mach-nuri.c b/arch/arm/mach-exynos4/mach-nuri.c ind

[PATCH] ARM: EXYNOS4: Turn the mach-smdkc210.c into mach-smdv310.c

2011-08-19 Thread Kukjin Kim
Since the components on SMDKC210 are similar with SMDKV310 even though its memory is different. So we can support the SMDKC210 and SMDKV310 on mach-smdkv310.c, one machine file. Signed-off-by: Kukjin Kim --- arch/arm/mach-exynos4/Kconfig | 17 +-- arch/arm/mach-exynos4/Makefile

RE: [PATCH] ARM: EXYNOS4: Remove useless codes on NURI board

2011-08-19 Thread Kukjin Kim
Kyungmin Park wrote: > > Maybe charger manager codes are not merged. it's used for charger managers. > OK, if this is required on charger manager, will drop this. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co.,

RE: [PATCH] ARM: EXYNOS4: Add usb ehci device to the SMDKC210

2011-08-19 Thread Kukjin Kim
static void __init smdkc210_machine_init(void) > samsung_bl_set(&smdkc210_bl_gpio_info, &smdkc210_bl_data); > s5p_fimd0_set_platdata(&smdkc210_lcd0_pdata); > > + smdkc210_ehci_init(); > + clk_xusbxti.rate = 2400; > + > platform_add_devices(smdkc2

RE: [PATCH 0/5] S5P64X0 PM Support

2011-08-19 Thread Kukjin Kim
e mode 100644 arch/arm/mach-s3c64xx/sleep.S > create mode 100644 arch/arm/mach-s5p64x0/include/mach/pm-core.h > create mode 100644 arch/arm/mach-s5p64x0/irq-pm.c > create mode 100644 arch/arm/mach-s5p64x0/pm.c > delete mode 100644 arch/arm/mach-s5pv210/sleep.S > create mode 10

RE: [PATCH v4 0/4] Updated s5p-tv platform definitions

2011-08-19 Thread Kukjin Kim
arch/arm/mach-s5pv210/include/mach/i2c-hdmiphy.h > create mode 100644 arch/arm/plat-s5p/dev-i2c-hdmiphy.c > create mode 100644 arch/arm/plat-s5p/dev-tv.c > create mode 100644 arch/arm/plat-samsung/include/plat/tv-core.h > > -- > 1.7.6 Hi Tomasz, Initially, looks ok, let me re

RE: [PATCH] ARM: EXYNOS4: ADD USB EHCI device to SMDKV310

2011-08-19 Thread Kukjin Kim
0_devices)); > s5p_device_mfc.dev.parent = &exynos4_device_pd[PD_MFC].dev; > } > -- > 1.7.4.1 (Cc'ed Jingoo Han) Well, this is same with Jingoo's patch on smdkc210 which has been submitted at 12th Aug. I requested to him to re-work this on smdkv310 on his patch ju

RE: [PATCH 0/4] ARM: EXYNOS4: Support generic Power domain framework for EXYNOS4210

2011-08-19 Thread Kukjin Kim
t; create mode 100644 arch/arm/mach-exynos4/pm-runtime.c > delete mode 100644 arch/arm/plat-samsung/include/plat/pd.h > delete mode 100644 arch/arm/plat-samsung/pd.c Hi Chanwoo, Basically looks ok. I will review this in detail in the next week. Then if no problems, will apply. Thanks. Best

RE: [PATCH v3] ARM: Samsung: fix watchdog reset issue with clk_get()

2011-08-19 Thread Kukjin Kim
Marek Szyprowski wrote: > > Hello, > > On Friday, August 19, 2011 3:06 PM Kukjin Kim wrote: > > > Marek Szyprowski wrote: > > > > > > clkdev framework uses global mutex to protect clock tree, so it is not > > > possible to call clk_get() in inte

[GIT PULL] Samsung Fixes for v3.1-rc3

2011-08-19 Thread Kukjin Kim
...@kernel.org soon. If any problems, please let me know. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. The following changes since commit 93ee7a9340d64f20295aacc3fb6a22b759323280: Linux 3.1-rc2 (2011-08-14 15:09:08

[PATCH 0/4] ARM: SAMSUNG: Add support CPU ID and Rev. at runtime

2011-08-19 Thread Kukjin Kim
This patch adds support handling of CPU ID and varialble silicon revision at runtime. [PATCH 1/4] ARM: SAMSUNG: Add support for detecting CPU at runtime [PATCH 2/4] ARM: S5P64X0: Use cpu_is_s5p64x0() to distinguish cpu at runtime [PATCH 3/4] ARM: SAMSUNG: Add support for handling of cpu revision [

[PATCH 2/4] ARM: S5P64X0: Use cpu_is_s5p64x0() to distinguish cpu at runtime

2011-08-19 Thread Kukjin Kim
Signed-off-by: Kukjin Kim --- arch/arm/mach-s5p64x0/dev-spi.c |8 +++- arch/arm/mach-s5p64x0/dma.c |7 ++- arch/arm/mach-s5p64x0/gpiolib.c |7 ++- arch/arm/mach-s5p64x0/irq-eint.c |3 ++- 4 files changed, 9 insertions(+), 16 deletions(-) diff --git a/arch/arm

[PATCH 3/4] ARM: SAMSUNG: Add support for handling of cpu revision

2011-08-19 Thread Kukjin Kim
This patch adds plat-samsung/cpu.c for detecting of cpu id and silicon revision. This patch was originally from Changhwan Youn Acked-by: Changhwan Youn Cc: Ben Dooks Signed-off-by: Kukjin Kim --- arch/arm/mach-s3c64xx/cpu.c | 10 + arch/arm/plat-s3c24xx/cpu.c

[PATCH 4/4] ARM: EXYNOS4: Use samsung_rev() to distinguish silicon revision

2011-08-19 Thread Kukjin Kim
This patch uses samsung_rev() to support variable silicon revision of EXYNOS4210 so that can support for EXYNOS4210 REV0, REV1.0 and REV1.1. Note: Need to change timer setting on REV0. Acked-by: Changhwan Youn Signed-off-by: Kukjin Kim --- arch/arm/mach-exynos4/cpu.c | 28

[PATCH 1/4] ARM: SAMSUNG: Add support for detecting CPU at runtime

2011-08-19 Thread Kukjin Kim
The cpu_is_[name]() can be used to distinguish cpu at runtime. This patch was originally from Changhwan Youn Acked-by: Changhwan Youn Cc: Ben Dooks Signed-off-by: Kukjin Kim --- arch/arm/mach-s3c64xx/cpu.c | 18 +++ arch/arm/plat-s3c24xx/cpu.c |8

RE: [PATCH 1/4] ARM: SAMSUNG: Add support for detecting CPU at runtime

2011-08-22 Thread Kukjin Kim
Russell King - ARM Linux wrote: > > On Sat, Aug 20, 2011 at 02:05:56PM +0900, Kukjin Kim wrote: > > The cpu_is_[name]() can be used to distinguish cpu at runtime. > > This really should be soc_is_xxx(). The CPU is stuff like ARM920, ARM926, > Cortex-A9 etc. The So

[PATCH V2 1/4] ARM: SAMSUNG: Add support for detecting CPU at runtime

2011-08-22 Thread Kukjin Kim
The soc_is_[name]() can be used to distinguish cpu at runtime. This patch was originally from Changhwan Youn Acked-by: Changhwan Youn Cc: Ben Dooks Signed-off-by: Kukjin Kim --- Changes since v1: - soc_is_xxx() is used instead of cpu_is_xxx() arch/arm/mach-s3c64xx/cpu.c | 18

[PATCH V2 2/4] ARM: S5P64X0: Use soc_is_s5p64x0() to distinguish cpu at runtime

2011-08-22 Thread Kukjin Kim
Signed-off-by: Kukjin Kim --- Changes since v1: - soc_is_s5p64x0() is used instead of cpu_is_s5p64x0() arch/arm/mach-s5p64x0/dev-spi.c |8 +++- arch/arm/mach-s5p64x0/dma.c |7 ++- arch/arm/mach-s5p64x0/gpiolib.c |7 ++- arch/arm/mach-s5p64x0/irq-eint.c |3

RE: [PATCH 1/4] S3C2443: Move i2s clock definitions to common code

2011-08-22 Thread Kukjin Kim
st time) > and it didn't report anything. > Hmm...as a note, happened following with checkpatch.pl :( ERROR: need consistent spacing around '*' (ctx:WxV) #35: FILE: arch/arm/mach-s3c2416/clock.c:57: + .sources = (struct clk *[]) {

RE: [PATCH] ARM: S5P: Remove duplicate kdiv calculation

2011-08-23 Thread Kukjin Kim
kdiv = pll_con1 & PLL4650C_KDIV_MASK; > -- > 1.7.0 Yes, OK. Applied, thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc

RE: [PATCH] ARM: EXYNOS4: Fix wrong pll type for vpll

2011-08-23 Thread Kukjin Kim
.0 Hi, OK, will apply. But would be helpful understanding if you could add git message in detail like following... "The PLL4650C is used for VPLL on EXYNOS4 so should be fixed"...I will add this when apply. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Deve

[PATCH] ARM: EXYNOS4: Fix return type of local_timer_setup()

2011-08-24 Thread Kukjin Kim
According to commmit af90f10d ("ARM: 6759/1: smp: Select local timers vs broadcast timer support"), the return type of local_timer_setup() should be int instead of void. Reported-by: Changhwan Youn Signed-off-by: Kukjin Kim --- arch/arm/mach-exynos4/mct.c |4 +++- 1 files

RE: [PATCH 3/4] ARM: SAMSUNG: Add support for handling of cpu revision

2011-08-24 Thread Kukjin Kim
Kukjin Kim wrote: > > This patch adds plat-samsung/cpu.c for detecting of cpu id and > silicon revision. > > This patch was originally from Changhwan Youn > > Acked-by: Changhwan Youn > Cc: Ben Dooks > Signed-off-by: Kukjin Kim > --- (snip) > +void

RE: [PATCH 4/4] ARM: EXYNOS4: Use samsung_rev() to distinguish silicon revision

2011-08-24 Thread Kukjin Kim
Kukjin Kim wrote: > > This patch uses samsung_rev() to support variable silicon revision of > EXYNOS4210 so that can support for EXYNOS4210 REV0, REV1.0 and REV1.1. > > Note: Need to change timer setting on REV0. > > Acked-by: Changhwan Youn > Signed-off-by:

[PATCH 5/5] tty: Add support serial for EXYNOS4212 SoC

2011-08-24 Thread Kukjin Kim
According to add support EXYNOS4212 SoC, we need to enable SERIAL_S5PV210 on EXYNOS4212. Cc: Alan Cox Cc: Greg Kroah-Hartman Signed-off-by: Kukjin Kim --- drivers/tty/serial/Kconfig |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/Kconfig b

[PATCH 4/5] ARM: EXYNOS4: Add support SMDK4212 Board

2011-08-24 Thread Kukjin Kim
This patch adds mach-smdk4212.c to support SMDK4212 board. Now it can support HSMMCs, I2Cs, RTC, WDT and Keypad. Other features will be supported next time. Signed-off-by: Kukjin Kim --- arch/arm/mach-exynos4/Kconfig | 25 +++ arch/arm/mach-exynos4/Makefile|2 + arch/arm

[PATCH 1/5] ARM: EXYNOS4: Add support new EXYNOS4212 SoC

2011-08-24 Thread Kukjin Kim
This patch adds Samsung EXYNOS4212 SoC support. The EXYNOS4212 integrates a ARM Cortex A9 multi-core. Signed-off-by: Kukjin Kim --- arch/arm/mach-exynos4/Kconfig|5 + arch/arm/mach-exynos4/Makefile |6 -- arch/arm/mach-exynos4/cpu.c |6

[PATCH 2/5] ARM: EXYNOS4: Add support clock for EXYNOS4212

2011-08-24 Thread Kukjin Kim
This patch splits EXYNOS4 clock code to EXYNOS4 common, EXYNOS4210 and EXYNOS4212 for supporting new EXYNOS4212 SoC with one kernel image. Of course, this patch adds some clock codes for EXYNOS4212 SoC. Signed-off-by: Kukjin Kim --- arch/arm/mach-exynos4/clock-exynos4210.c | 101

[PATCH 3/5] ARM: EXYNOS4: Add support PM for EXYNOS4212

2011-08-24 Thread Kukjin Kim
From: Jonghwan Choi This patch moves regarding clock stuff of PM into clock file to support PM on EXYNOS4210 and EXYNOS4212 with one single kernel image. Because some clock registers are different on each SoCs. Signed-off-by: Jonghwan Choi Signed-off-by: Kukjin Kim --- arch/arm/mach-exynos4

[PATCH 0/5] ARM: EXYNOS4: Add support new EXYNOS4212 SoC

2011-08-24 Thread Kukjin Kim
This patch adds support new EXYNOS4212 SoC and SMDK4212 Board. [PATCH 1/5] ARM: EXYNOS4: Add support new EXYNOS4212 SoC [PATCH 2/5] ARM: EXYNOS4: Add support clock for EXYNOS4212 [PATCH 3/5] ARM: EXYNOS4: Add support PM for EXYNOS4212 [PATCH 4/5] ARM: EXYNOS4: Add support SMDK4212 Board [PATCH 5/5

RE: [PATCH 3/5] ARM: EXYNOS4: Add support PM for EXYNOS4212

2011-08-25 Thread Kukjin Kim
MyungJoo Ham wrote: > > On Wed, Aug 24, 2011 at 10:25 PM, Kukjin Kim wrote: > > From: Jonghwan Choi > > > > This patch moves regarding clock stuff of PM into clock > > file to support PM on EXYNOS4210 and EXYNOS4212 with one > > single kernel ima

[PATCH] ARM: EXYNOS4: Fix routing timer interrupt to offline CPU

2011-08-25 Thread Kukjin Kim
atch fixes routing timer interrupt to offline CPU. Reported-by: Changhwan Youn Signed-off-by: Kukjin Kim --- Hi Russell and all, I'm not sure it's safe to call set_cpu_online() here... arch/arm/mach-exynos4/platsmp.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff -

RE: [GIT PULL] Samsung Fixes for v3.1-rc3

2011-08-25 Thread Kukjin Kim
Kukjin Kim wrote: > > Hi Arnd, > > This is pull request for Samsung fixes for v3.1-rc3. > > Please pull Samsung fixes from: > git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git > samsung-fixes > > These things are for _real_ fixing. > &

RE: [PATCH 2/5] ARM: SAMSUNG: Make the sleep code common for S3C64XX and newer SoCs

2011-08-25 Thread Kukjin Kim
_GPIO > +#define S3C64XX_VA_GPIO (0x0) Please let me know why this is needed here. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsun

[PATCH] ARM: SAMSUNG: Move map header file into plat-samsung

2011-08-30 Thread Kukjin Kim
This is required to work consolidation Samsung platform. Cc: Ben Dooks Signed-off-by: Kukjin Kim --- arch/arm/mach-s3c2410/include/mach/map.h | 52 +- arch/arm/mach-s3c64xx/include/mach/map.h |9 +-- arch/arm/plat-s3c24xx/include/plat/map.h | 100

[PATCH 0/7] gpio/samsung: Add support Samsung GPIO with gpio-samsung.c

2011-08-30 Thread Kukjin Kim
This patch merges existing many Samsung GPIO drivers into the one drivers/gpio/gpio-samsung.c. [PATCH 1/7 (RE-SEND)] gpio/s3c24xx: move gpio driver into drivers/gpio/ [PATCH 2/7 (RE-SEND)] gpio/s3c64xx: move gpio driver into drivers/gpio/ [PATCH 3/7 (RE-SEND)] gpio/s5p64x0: move gpio driver into d

[PATCH 7/7] ARM: SAMSUNG: Remove useless Samsung GPIO related CONFIGs

2011-08-30 Thread Kukjin Kim
Cc: Ben Dooks Signed-off-by: Kukjin Kim --- arch/arm/Kconfig |3 --- arch/arm/mach-s3c2410/Kconfig |1 - arch/arm/mach-s3c2416/Kconfig |1 - arch/arm/mach-s3c2440/Kconfig |2 -- arch/arm/mach-s3c2443/Kconfig |1 - arch/arm/plat-s3c24xx/Kconfig |1 - arch/arm

[PATCH 3/7 (RE-SEND)] gpio/s5p64x0: move gpio driver into drivers/gpio/

2011-08-30 Thread Kukjin Kim
Cc: Grant Likely Signed-off-by: Kukjin Kim --- arch/arm/mach-s5p64x0/Makefile |2 +- drivers/gpio/Kconfig |4 drivers/gpio/Makefile |1 + .../gpiolib.c => drivers/gpio/gpio-s5p64x0.c |

[PATCH 2/7 (RE-SEND)] gpio/s3c64xx: move gpio driver into drivers/gpio/

2011-08-30 Thread Kukjin Kim
Cc: Ben Dooks Cc: Grant Likely Signed-off-by: Kukjin Kim --- arch/arm/mach-s3c64xx/Makefile |1 - drivers/gpio/Kconfig |4 drivers/gpio/Makefile |1 + .../gpiolib.c => drivers/gpio/gpio-s3c64x

[PATCH 1/7 (RE-SEND)] gpio/s3c24xx: move gpio driver into drivers/gpio/

2011-08-30 Thread Kukjin Kim
Cc: Ben Dooks Cc: Grant Likely Signed-off-by: Kukjin Kim --- arch/arm/mach-s3c2410/Kconfig |6 -- arch/arm/mach-s3c2410/Makefile |1 - arch/arm/mach-s3c2412/Kconfig |1 - arch/arm/mach-s3c2412/Makefile

[PATCH 6/7] ARM: SAMSUNG: Update the name of regarding Samsung GPIO

2011-08-30 Thread Kukjin Kim
time. Cc: Ben Dooks Signed-off-by: Kukjin Kim --- arch/arm/mach-exynos4/include/mach/pm-core.h |2 +- arch/arm/mach-s3c2410/include/mach/gpio-fns.h | 99 +--- arch/arm/mach-s3c2410/include/mach/gpio-track.h|6 +- arch/arm/mach-s3c2410/include/mach/pm-core.h

RE: [PATCH 3/5] ARM: EXYNOS4: Add support PM for EXYNOS4212

2011-08-30 Thread Kukjin Kim
Rafael J. Wysocki wrote: > > On Friday, August 26, 2011, Kukjin Kim wrote: > > MyungJoo Ham wrote: > > > > > > On Wed, Aug 24, 2011 at 10:25 PM, Kukjin Kim > > wrote: > > > > From: Jonghwan Choi > > > > > > > > This patch

RE: [PATCH] ARM: EXYNOS4: Add usb ehci device to the SMDKC210

2011-08-30 Thread Kukjin Kim
static void __init smdkc210_machine_init(void) > samsung_bl_set(&smdkc210_bl_gpio_info, &smdkc210_bl_data); > s5p_fimd0_set_platdata(&smdkc210_lcd0_pdata); > > + smdkc210_ehci_init(); > + clk_xusbxti.rate = 2400; > + > platform_add_devices(

RE: [PATCH] ARM: EXYNOS4: Add USB EHCI device to Origen

2011-08-30 Thread Kukjin Kim
_set_platdata(&origen_hsmmc2_pdata); > + > + origen_ehci_init(); > + clk_xusbxti.rate = 2400; > + > platform_add_devices(origen_devices, ARRAY_SIZE(origen_devices)); > } > > -- > 1.7.4.1 OK, will apply with re-ordering as per my comments. Thanks.

RE: [PATCH 2/3] ARM: EXYNOS4: Add support for secondary MMC port on ORIGEN

2011-08-30 Thread Kukjin Kim
> platform_add_devices(origen_devices, ARRAY_SIZE(origen_devices)); > } > > -- > 1.7.4.1 OK, will apply. If you don't mind, I will add comments the reason of the ordering when I apply this. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Develo

RE: [PATCH 1/3] ARM: EXYNOS4: Fix sdhci card detection for ORIGEN

2011-08-30 Thread Kukjin Kim
= EXYNOS4_GPK2(2), > - .ext_cd_gpio_invert = 1, > + .cd_type= S3C_SDHCI_CD_INTERNAL, > .clk_type = S3C_SDHCI_CLK_DIV_EXTERNAL, > }; > > -- > 1.7.4.1 OK, will apply. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Eng

RE: [PATCH] ARM: EXYNOS4: Add FIMC device on Origen board

2011-08-30 Thread Kukjin Kim
en_hsmmc2_pdata > __initdata = { > }; > > static struct platform_device *origen_devices[] __initdata = { > + &s5p_device_fimc0, > + &s5p_device_fimc1, > + &s5p_device_fimc2, > + &s5p_device_fimc3, > &s3c_device_hsmmc2, > &s3c_dev

RE: [PATCH 1/1] ARM: EXYNOS4: Add PWM backlight support on Origen

2011-08-30 Thread Kukjin Kim
_platdata(&origen_hsmmc2_pdata); > platform_add_devices(origen_devices, ARRAY_SIZE(origen_devices)); > + > + samsung_bl_set(&origen_bl_gpio_info, &origen_bl_data); > } > > MACHINE_START(ORIGEN, "ORIGEN") > -- > 1.7.4.1 OK, will apply. Thanks. Bes

RE: [PATCH 3/3] ARM: EXYNOS4: Add support for 8-bit bus width in SDHCI for ORIGEN

2011-08-30 Thread Kukjin Kim
gt; -- > 1.7.4.1 Hi Tushar, I wonder the bus width of SDHCI controller can be changed manually on ORIGEN like SMDK board. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line

RE: [PATCH] ARM: EXYNOS4: iommu: Add IOMMU API and moved to drivers/iommu

2011-08-30 Thread Kukjin Kim
ble, please make it look as a single patch set about regarding patches to prevent missing something important. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. > diff --git a/arch/arm/mach-exynos4/include/mach/sysm

RE: [PATCH] ARM: EXYNOS4: Enable system MMU support on Origen

2011-08-30 Thread Kukjin Kim
gt; static void __init origen_map_io(void) > -- > 1.7.4.1 Hi Sachin, Hmm, do you _really_ use this feature on ORIGEN board now? As I know, the EXYNOS System MMU driver will be changed like a form of omap and msm soon maybe it's within 1 or 2 weeks. So if this is not required on ORIGEN

RE: [PATCH 1/2] ARM: EXYNOS4: Code cleanup and remove extra functions.

2011-08-30 Thread Kukjin Kim
HOST_PHY_ENABLE, > + writel(readl(S5P_USBHOST_PHY_CONTROL) & > ~S5P_USBHOST_PHY_ENABLE, > S5P_USBHOST_PHY_CONTROL); > > - clk_disable(otg_clk); > - clk_put(otg_clk); > - > - return 0; > -} > - > -int s5p_usb_phy_i

RE: [PATCH 2/2] ARM: EXYNOS4: Add USB PHY initialization for device

2011-08-30 Thread Kukjin Kim
t; - clk_put(otg_clk); > + clk_put(usbhost_clk); > return err; > } > > @@ -117,10 +162,18 @@ int s5p_usb_phy_exit(struct platform_device *pdev, int > type) > writel(readl(S5P_USBHOST_PHY_CONT

RE: [PATCH] ARM: S3C24XX: remove unused gpio codes

2011-08-30 Thread Kukjin Kim
Kukjin Kim wrote: > > Cc: Ben Dooks > Signed-off-by: Kukjin Kim > --- > arch/arm/mach-s3c2400/gpio.c | 42 > arch/arm/mach-s3c2410/gpio.c | 72 -- > arch/arm/mach-

RE: [PATCH] mmc: core: eMMC4.5 Add the timeout for switch

2011-08-31 Thread Kukjin Kim
/* R/W */ > @@ -293,6 +296,7 @@ struct _mmc_csd { > #define EXT_CSD_SEC_ERASE_MULT 230 /* RO */ > #define EXT_CSD_SEC_FEATURE_SUPPORT 231 /* RO */ > #define EXT_CSD_TRIM_MULT232 /* RO */ > +#define EXT_CSD_CMD6_TIME248 /* RO

RE: [PATCH 1/2] mmc: sdhci-s3c: add default controller configuration

2011-09-04 Thread Kukjin Kim
< 25 * 100) > + ctrl |= (S3C_SDHCI_CTRL3_FCSEL3 | > S3C_SDHCI_CTRL3_FCSEL2); > + writel(ctrl, host->ioaddr + S3C_SDHCI_CONTROL3); > } > > /** > -- Basically, it's good to move common codes and to remove that. But I'm not sure we don't _

RE: [PATCH 2/2] arm: samsung: remove sdhci default configuration setup platform helper

2011-09-04 Thread Kukjin Kim
_setup_sdhci_cfg_card; > #endif > } > > @@ -341,17 +293,11 @@ static inline void s5pv210_default_sdhci3(void) { } > #ifdef CONFIG_EXYNOS4_SETUP_SDHCI > extern char *exynos4_hsmmc_clksrcs[4]; > > -extern void exynos4_setup_sdhci_cfg_card(struct platform_device *dev, >

RE: [PATCH v2 6/6] ARM: EXYNOS4: Limit usage of pl330 device instance to non-dt build

2011-09-04 Thread Kukjin Kim
S4_DEV_DMA)+= dma.o Do we need _really_ EXYNOS4_DEV_DMA here? How about to use like following? +obj-$(!CONFIG_OF) += dma.o If any problems, let me know. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. &

RE: [PATCH 0/6] Add device tree support for PL330 dma controller driver

2011-09-04 Thread Kukjin Kim
this to go thru slave-dma > tree or somewhere else. > I will need acks on 3, 5 and 6th patch to carry them. > Looks good to me on 3 and 5th patch, I think, 6th patch is needed to update, please refer to my comments on there. Acked-by: Kukjin Kim As you know, Boojin Kim submitted 8th

RE: [PATCH] ARM: S5P64X0: Fix mask value for S5P64X0 CPU IDs

2011-09-05 Thread Kukjin Kim
100_CPU_MASK 0xF000 > -- > 1.7.2.3 Yes, you're right. But in this case, 0xF000 is better than 0x7FFF. If any problems with above value, please let me know. Will apply, thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team,

RE: [PATCH 3/3] ARM: EXYNOS4: Add support for 8-bit bus width in SDHCI for ORIGEN

2011-09-05 Thread Kukjin Kim
Tushar Behera wrote: > > On Wednesday 31 August 2011 06:31 AM, Kukjin Kim wrote: > > Tushar Behera wrote: > >> > >> Platform data for SDHCI controller on ORIGEN board is missing the > >> support for 8-bit bus width. The platform data is extended i

RE: [PATCH v3] ARM: Samsung: fix watchdog reset issue with clk_get()

2011-09-05 Thread Kukjin Kim
- clk_enable(wdtclk); > - } else > - printk(KERN_WARNING "%s: warning: cannot get watchdog > clock\n", __func__); > + if (s3c2410_wdtclk) > + clk_enable(s3c2410_wdtclk); > > /* put initial values into count and data

RE: [PATCH v4 0/4] Updated s5p-tv platform definitions

2011-09-05 Thread Kukjin Kim
arch/arm/mach-s5pv210/include/mach/i2c-hdmiphy.h > create mode 100644 arch/arm/plat-s5p/dev-i2c-hdmiphy.c > create mode 100644 arch/arm/plat-s5p/dev-tv.c > create mode 100644 arch/arm/plat-samsung/include/plat/tv-core.h > > -- > 1.7.6 Looks ok to me, will apply. Thanks. Best reg

RE: [PATCH 2/5] ARM: SAMSUNG: Make the sleep code common for S3C64XX and newer SoCs

2011-09-06 Thread Kukjin Kim
Abhilash Kesavan wrote: > > Hi Mr Kim, > > Thanks for your comments. Please find my reply below: > > Regards, > Abhilash > > On Fri, Aug 26, 2011 at 7:10 AM, Kukjin Kim wrote: > > Abhilash Kesavan wrote: > >> > >> The sleep code for S5P

RE: [PATCH 3/5] ARM: S5P64X0: Add pm save/restore functions for GPIO banks

2011-09-06 Thread Kukjin Kim
int nr_chips) > { > - for (; nr_chips > 0; nr_chips--, chip++) > + for (; nr_chips > 0; nr_chips--, chip++) { > + chip->pm = __gpio_pm(&s3c_gpio_pm_2bit); > s3c_gpiolib_add(chip); > + } > } > -- > 1.7.4.1 Hi Abhilash, Since submitte

RE: [PATCH 4/5] ARM: S5P64X0: Fix incorrect serial clock name

2011-09-06 Thread Kukjin Kim
ow", > + .name = "pclk", According to data sheet, should be pclk_low. Or if required for serial driver, uclk1 can be used here. > .divisor= 1, > .min_baud = 0, > .max_baud = 0, > -- >

RE: [PATCH 5/5] ARM: S5P64X0: Add Power Management support

2011-09-06 Thread Kukjin Kim
mode configuration */ > + tmp = __raw_readl(S5P64X0_SLEEP_CFG); > + tmp &= ~(S5P64X0_SLEEP_CFG_OSC_EN); > + __raw_writel(tmp, S5P64X0_SLEEP_CFG); > + > + tmp = __raw_readl(S5P64X0_PWR_CFG); > + tmp &= ~(S5P64X0_PWRCFG_CFG_WFI_MASK); > + tmp |=

RE: [PATCH] ARM: EXYNOS4: ADD USB EHCI device to SMDKV310

2011-09-07 Thread Kukjin Kim
Kukjin Kim wrote: > > Sachin Kamat wrote: > > > > Signed-off-by: Bhuvana Kakunoori > > Signed-off-by: Pankaj Dubey > > Signed-off-by: Sachin Kamat > > --- > > arch/arm/mach-exynos4/Kconfig |2 ++ > > arch/arm/mach-exynos4/mach

  1   2   3   4   5   6   7   8   9   10   >