Re: [PATCH v2 3/4] gpio: exynos4: skip gpiolib registration if pinctrl driver is used

2012-08-21 Thread Thomas Abraham
On 21 August 2012 17:35, Linus Walleij wrote: > On Wed, Aug 15, 2012 at 9:57 PM, Thomas Abraham > wrote: > >> Pinctrl driver, when enabled, registers all the gpio pins and hence the >> registration of gpio pins by this driver can be skipped. >> >> Acked-by:

Re: [PATCH v2 2/4] pinctrl: add exynos4210 specific extensions for samsung pinctrl driver

2012-08-21 Thread Thomas Abraham
On 21 August 2012 17:32, Linus Walleij wrote: > On Wed, Aug 15, 2012 at 9:57 PM, Thomas Abraham > wrote: > >> Add information about the Exynos4210 pin banks and driver data which is >> used by the Samsung pinctrl driver. In addition to this, the support for >> externa

Re: [PATCH v2 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-08-21 Thread Thomas Abraham
Hi Linus, Thanks for your time to review the Samsung pinctrl driver patches. I have inlined the reply to your comments. On 21 August 2012 16:55, Linus Walleij wrote: > On Wed, Aug 15, 2012 at 9:57 PM, Thomas Abraham > wrote: > >> Add a new device tree enabled pinctrl and gpi

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Thomas Abraham
On 21 August 2012 21:31, Rob Herring wrote: > On 08/21/2012 10:18 AM, Chris Ball wrote: >> Hi, >> >> On Tue, Aug 21 2012, Rob Herring wrote: cd-gpios and cd-external can be present on the same node. if broken-cd is present, it must be the only one of these nodes used. >>> >>> I don't se

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Thomas Abraham
On 21 August 2012 20:33, Rob Herring wrote: > On 08/21/2012 09:48 AM, Chris Ball wrote: >> Hi, adding Shawn and Wolfram, > > snip... > >> Rob Herring said: >>> This makes the most sense to me. However, I prefer broken-cd over >>> cd-internal. The binding should add properties for exceptions, not S

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Thomas Abraham
On 21 August 2012 17:26, Chris Ball wrote: > Hi, > > On Tue, Aug 21 2012, Thomas Abraham wrote: >> I am trying to have a way to represent a gpio line as card detect line >> that is not connected to the card-detect pad of the mmc controller but >> instead used as a gp

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Thomas Abraham
On 21 August 2012 16:31, Arnd Bergmann wrote: > > On Tuesday 21 August 2012, Thomas Abraham wrote: > > diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt > > b/Documentation/devicetree/bindings/mmc/mmc.txt > > index 8a6811f..1aa527a 100644 > > --- a/Documen

[PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Thomas Abraham
'broken-cd' binding lets mmc controller device node to indicate that the card detect line is broken. Signed-off-by: Thomas Abraham --- The 'broken-cd' DT binding for MMC controllers is picked up from the OLPC project git repo and was originally conceived by Chris Ba

[PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Thomas Abraham
'broken-cd' binding lets mmc controller device node to indicate that the card detect line is broken. Signed-off-by: Thomas Abraham --- The 'broken-cd' DT binding for MMC controllers is picked up from the OLPC project git repo and was originally conceived by Chris Ba

Re: [PATCH 1/2] ARM: dts: Add pinctrl node entries for Samsung Exynos4210 SoC

2012-08-16 Thread Thomas Abraham
ains generic for all the possible combinations of pin banks and SoC's. Thanks, Thomas. > > -- > Matt Sealey > Product Development Analyst, Genesi USA, Inc. > > > On Wed, Aug 15, 2012 at 3:10 PM, Thomas Abraham > wrote: >> Add pinctrl driver nodes for the thre

Re: [PATCH v6 5/6] ARM: exynos: add thermal sensor driver platform data support

2012-08-16 Thread Thomas Abraham
; --- > drivers/thermal/exynos_thermal.c | 111 > +- > 1 files changed, 110 insertions(+), 1 deletions(-) Reviewed-by: Thomas Abraham Few minor comments inline below. > > diff --git a/drivers/thermal/exynos_thermal.c > b/drivers/thermal/exynos_thermal.c > i

Re: [PATCH] mmc: sdhci-s3c: Add device tree support

2012-08-16 Thread Thomas Abraham
On 16 August 2012 22:22, Chris Ball wrote: > Hi Thomas, > > On Thu, Aug 16 2012, Thomas Abraham wrote: >> +Optional Board Specific Properties: >> +- One of the following properties for card detect type. >> + - samsung,sdhci-cd-internal: Card detect line from the card s

[PATCH] ARM: dts: use generic mmc properties for Samsung Exynos4210 sdhci nodes

2012-08-16 Thread Thomas Abraham
ff-by: Thomas Abraham --- arch/arm/boot/dts/exynos4210-origen.dts | 10 -- arch/arm/boot/dts/exynos4210-smdkv310.dts |5 ++--- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts index 0c

Re: [PATCH] mmc: sdhci-s3c: Add device tree support

2012-08-16 Thread Thomas Abraham
On 16 August 2012 21:59, Chris Ball wrote: > Hi, > > On Thu, Aug 16 2012, Thomas Abraham wrote: >> Add device tree based discovery support for Samsung's sdhci controller >> >> Cc: Ben Dooks >> Cc: Kukjin Kim >> Cc: Chris Ball >> Signed-

[PATCH] mmc: sdhci-s3c: Add device tree support

2012-08-16 Thread Thomas Abraham
Add device tree based discovery support for Samsung's sdhci controller Cc: Ben Dooks Cc: Kukjin Kim Cc: Chris Ball Signed-off-by: Thomas Abraham --- Changes since v3: The patch series that adds device tree support for Samsung sdhci controller had six patches in total, of which, the

Re: [PATCH] mmc: sdhci-s3c: Add device tree support

2012-08-16 Thread Thomas Abraham
Hi Chris, Thanks for your review. On 16 August 2012 21:17, Chris Ball wrote: > Hi Thomas, > > On Thu, Aug 16 2012, Thomas Abraham wrote: >> Add device tree based discovery support for Samsung's sdhci controller >> >> Cc: Ben Dooks >> Cc: Kukjin Kim >&

[PATCH] mmc: sdhci-s3c: Add device tree support

2012-08-16 Thread Thomas Abraham
Add device tree based discovery support for Samsung's sdhci controller Cc: Ben Dooks Cc: Kukjin Kim Cc: Chris Ball Signed-off-by: Thomas Abraham --- drivers/mmc/host/sdhci-s3c.c | 146 -- 1 files changed, 140 insertions(+), 6 deletions(-) diff

Re: [PATCH] ARM: EXYNOS: Add MFC device tree support

2012-08-16 Thread Thomas Abraham
void s5p_mfc_reserve_mem(phys_addr_t rbase, unsigned int rsize, > + phys_addr_t lbase, unsigned int lsize) { > + > + if (memblock_remove(lbase, lsize)) { > + pr_err("Failed to reserve bank1 memory for MFC device\n"); > + WAR

Re: Unbalanced calls to spi_master_get in coldfire-qspi and s3c64xx SPI master drivers

2012-08-16 Thread Thomas Abraham
On 14 August 2012 03:14, Guenter Roeck wrote: > Hi all, > > looking through SPI master drivers, I noticed that the following drivers call > spi_master_get() in their suspend and resume functions. Yet, there is no > matching call to spi_master_put(), meaning the reference count will increase > with

[PATCH 1/2] ARM: dts: Add pinctrl node entries for Samsung Exynos4210 SoC

2012-08-15 Thread Thomas Abraham
Add pinctrl driver nodes for the three instances of pin controllers in Samsung Exynos4210 SoC and add the pin group nodes available in the each of those three instances. Cc: Kukjin Kim Signed-off-by: Thomas Abraham --- arch/arm/boot/dts/exynos4210-pinctrl.dtsi | 457

[PATCH 0/2] Enable pinctrl driver support for Exynos4210 based platforms

2012-08-15 Thread Thomas Abraham
coverage of pinctrl driver is extended device drivers used on Exynos4210 platforms, additional pin group nodes can be added as required. Thomas Abraham (2): ARM: dts: Add pinctrl node entries for Samsung Exynos4210 SoC ARM: EXYNOS: Enable PINCTRL config option for Exynos4 device tree enabled

[PATCH 2/2] ARM: EXYNOS: Enable PINCTRL config option for Exynos4 device tree enabled platform

2012-08-15 Thread Thomas Abraham
This enables support for Samsung and Exynos4 pinctrl driver for device tree enabled Exynos4 platforms. Cc: Kukjin Kim Signed-off-by: Thomas Abraham --- arch/arm/mach-exynos/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm

[PATCH v2 2/4] pinctrl: add exynos4210 specific extensions for samsung pinctrl driver

2012-08-15 Thread Thomas Abraham
: Thomas Abraham --- drivers/pinctrl/Kconfig |7 + drivers/pinctrl/Makefile |1 + drivers/pinctrl/pinctrl-exynos.c | 555 ++ drivers/pinctrl/pinctrl-exynos.h | 213 +++ 4 files changed, 776 insertions(+), 0 deletions

[PATCH v2 4/4] ARM: EXYNOS: skip wakeup interrupt setup if pinctrl driver is used

2012-08-15 Thread Thomas Abraham
Pinctrl driver includes support for configuring the external wakeup interrupts. On exynos platforms that use pinctrl driver, the setup of wakeup interrupts in the exynos platform code can be skipped. Cc: Kukjin Kim Signed-off-by: Thomas Abraham --- arch/arm/mach-exynos/common.c | 26

[PATCH v2 3/4] gpio: exynos4: skip gpiolib registration if pinctrl driver is used

2012-08-15 Thread Thomas Abraham
Pinctrl driver, when enabled, registers all the gpio pins and hence the registration of gpio pins by this driver can be skipped. Acked-by: Grant Likely Acked-by: Linus Walleij Signed-off-by: Thomas Abraham --- drivers/gpio/gpio-samsung.c | 21 + 1 files changed, 21

[PATCH v2 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-08-15 Thread Thomas Abraham
nformation about the pins, pin groups, pin functions and gpio chips, which are SoC specific, are parsed from device tree node. Cc: Linus Walleij Cc: Kukjin Kim Signed-off-by: Thomas Abraham --- .../bindings/pinctrl/samsung-pinctrl.txt | 176 drivers/pinct

[PATCH v2 0/4] pinctrl: add support for samsung pinctrl driver

2012-08-15 Thread Thomas Abraham
p the gpio pin registrations if pinctrl driver support is found to be enabled. The fourth patch skips the external wakeup interrupt configuration process in the Exynos4 platform code if the external wakeup interrupt support is provided by the pin-control driver. Thomas Abraham (4): pinctrl

Re: 회신: 회신: [PATCH] ODROID-X: hkdk4412: Add new hardware based on Exynos4412

2012-08-06 Thread Thomas Abraham
On 7 August 2012 07:58, Olof Johansson wrote: > Hi, > > On Mon, Aug 6, 2012 at 7:05 PM, Dongjin Kim > wrote: >> Hello, >> >> I am trying to understand what I have to do for device tree. >> >> In order to create dts file for ODROID-X hardware, it seems I may need dts >> file of EXYNOS4412 SoC. >>

Re: [PATCH] ODROID-X: hkdk4412: Add new hardware based on Exynos4412

2012-08-06 Thread Thomas Abraham
On 6 August 2012 19:40, Dongjin Kim wrote: > The HKDK4412 is the CPU module developed by Hardkernel which is based on > Exynos 4412. mach_hkdk4412.c is to run on ODROID-X hardware and Machine ID > (4289) is registered. > > Change-Id: I3af02808c03b9acea916c310390a4904ad92d761 > Signed-off-by: Dong

Re: [PATCH v3 2/2] ARM: EXYNOS: Add Gscaler device from DT

2012-08-01 Thread Thomas Abraham
On 1 August 2012 12:10, Kukjin Kim wrote: > Shaik Ameer Basha wrote: [...] >> +* Samsung Exynos5 Gscaler device >> + >> +Gscaler is used for scaling and color space conversion on EXYNOS5 SoCs. >> + >> +Required properties: >> +- compatible: should be "samsung,exynos5250-gsc" > > IMO, should be "

Re: [PATCH v3 6/6] mmc: dw_mmc: add samsung exynos5250 specific extentions

2012-07-22 Thread Thomas Abraham
On 20 July 2012 16:08, Seungwon Jeon wrote: > July 20, 2012, Thomas Abraham wrote: >> On 19 July 2012 09:21, Seungwon Jeon wrote: [...] >> >> +static unsigned long exynos5250_dwmmc_caps[4] = { >> >> + MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR | >&

Re: [PATCH v3 0/6] mmc: dw_mmc: add support for device tree based instantiation

2012-07-19 Thread Thomas Abraham
r Exynos SoC's for now. Splitting into different files will need to defined new callbacks which I fell is not really required. Thanks, Thomas. > > Best Regards, > Jaehoon Chung > > On 07/12/2012 09:54 PM, Thomas Abraham wrote: >> This patch series adds device tree suppor

Re: [PATCH v3 6/6] mmc: dw_mmc: add samsung exynos5250 specific extentions

2012-07-19 Thread Thomas Abraham
On 19 July 2012 09:21, Seungwon Jeon wrote: > Hi, > > This version does not seems to consider previous reviews fully. > Could you check the comments below? I did try to address all the comments. I will check again and resubmit if I have missed anything. > > July 12, 2012, Tho

[PATCH 3/9] mmc: dw_mmc: lookup for optional biu and ciu clocks

2012-07-17 Thread Thomas Abraham
Some platforms allow for clock gating and control of bus interface unit clock and card interface unit clock. Add support for clock lookup of optional biu and ciu clocks for clock gating and clock speed determination. Signed-off-by: Abhilash Kesavan Signed-off-by: Thomas Abraham --- drivers/mmc

[PATCH 5/9] mmc: dw_mmc: add device tree support

2012-07-17 Thread Thomas Abraham
Add device tree based discovery support. Signed-off-by: Thomas Abraham --- .../devicetree/bindings/mmc/synposis-dw-mshc.txt | 99 ++ drivers/mmc/host/dw_mmc-pltfm.c| 23 +++ drivers/mmc/host/dw_mmc.c | 201 +++- drivers

Re: [PATCH v3 5/6] mmc: dw_mmc: add device tree support

2012-07-17 Thread Thomas Abraham
On 16 July 2012 09:53, Chris Ball wrote: > Hi, > > On Thu, Jul 12 2012, Thomas Abraham wrote: >> diff --git a/Documentation/devicetree/bindings/mmc/synposis-dw-mshc.txt >> b/Documentation/devicetree/bindings/mmc/synposis-dw-mshc.txt >> new file mode 100644 >> i

Re: [PATCH v3 5/6] mmc: dw_mmc: add device tree support

2012-07-17 Thread Thomas Abraham
On 16 July 2012 09:45, Girish K S wrote: > On 12 July 2012 18:24, Thomas Abraham wrote: [...] >> >> +#ifdef CONFIG_OF >> +static struct dw_mci_drv_data synopsis_drv_data = { >> + .ctrl_type = DW_MCI_TYPE_SYNOPSIS, >> +}; >> + >> +static

Re: [PATCH v5 6/6] spi: s3c64xx: add device tree support

2012-07-13 Thread Thomas Abraham
On 13 July 2012 19:12, Kukjin Kim wrote: > Thomas Abraham wrote: >> >> On 13 July 2012 16:58, Kukjin Kim wrote: >> > Thomas Abraham wrote: >> >> >> >> On 13 July 2012 04:08, Kukjin Kim wrote: >> >> > Thomas, the DMACH_DT_PROP is a

Re: [PATCH v5 6/6] spi: s3c64xx: add device tree support

2012-07-13 Thread Thomas Abraham
On 13 July 2012 16:58, Kukjin Kim wrote: > Thomas Abraham wrote: >> >> On 13 July 2012 04:08, Kukjin Kim wrote: >> > Thomas, the DMACH_DT_PROP is available only on pl330 now. So seems occur >> > following build error with s3c6400_defconfig. >> > &

[PATCH v2] ARM: Exynos: Add device tree node for Exynos4 interrupt combiner controller

2012-07-12 Thread Thomas Abraham
Add node for Exynos4 interrupt combiner controller. Signed-off-by: Thomas Abraham --- arch/arm/boot/dts/exynos4210.dtsi | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi index a1dd2ee

Re: [PATCH] ARM: Exynos: Add device tree node for Exynos4 interrupt combiner controller

2012-07-12 Thread Thomas Abraham
On 12 July 2012 14:40, Kukjin Kim wrote: > Thomas Abraham wrote: >> >> Add node for Exynos4 interrupt combiner controller. >> >> Signed-off-by: Thomas Abraham >> --- >> arch/arm/boot/dts/exynos4210.dtsi | 11 +++ >> 1 files changed, 11 ins

Re: [PATCH v5 6/6] spi: s3c64xx: add device tree support

2012-07-12 Thread Thomas Abraham
On 13 July 2012 04:08, Kukjin Kim wrote: > Thomas, the DMACH_DT_PROP is available only on pl330 now. So seems occur > following build error with s3c6400_defconfig. > > drivers/spi/spi-s3c64xx.c: In function 's3c64xx_spi_get_dmares': > drivers/spi/spi-s3c64xx.c:1098: error: 'DMACH_DT_PROP' undeclar

Re: [PATCH v5 0/6] spi: s3c64xx: add support for device tree

2012-07-12 Thread Thomas Abraham
On 12 July 2012 18:32, Mark Brown wrote: > On Thu, Jul 12, 2012 at 06:11:05PM +0900, Kukjin Kim wrote: > >> And Mark, this touches various samsung stuff in arch/arm/ so if you're ok, >> I'd like to pick this up in samsung tree. We don't want to see conflicts... > > Well, simple conflicts aren't th

[PATCH v2 3/3] ARM: dts: Add nodes for dw_mmc controllers for Samsung Exynos5250 platforms

2012-07-12 Thread Thomas Abraham
Add device nodes for the four instances of dw_mmc controllers in Exynos5250 and enable instance 0 and 2 for the smdk5250 board. Signed-off-by: Thomas Abraham --- arch/arm/boot/dts/exynos5250-smdk5250.dts | 58 + arch/arm/boot/dts/exynos5250.dtsi | 32

[PATCH v2 2/3] ARM: Exynos5: Add AUXDATA support for MSHC controllers

2012-07-12 Thread Thomas Abraham
Add entries if MSHC controllers in AUXDATA table for correct device name initialization. Signed-off-by: Abhilash Kesavan Signed-off-by: Thomas Abraham --- arch/arm/mach-exynos/include/mach/map.h |1 + arch/arm/mach-exynos/mach-exynos5-dt.c |8 2 files changed, 9 insertions

[PATCH v2 1/3] ARM: Samsung: Add support for MSHC controller clocks

2012-07-12 Thread Thomas Abraham
Add clock instances for bus interface unit clock and card interface unit clock of the all four MSHC controller instances. Signed-off-by: Abhilash Kesavan Signed-off-by: Thomas Abraham --- arch/arm/mach-exynos/clock-exynos5.c | 45 -- 1 files changed, 16

ARM: Exynos5: Enable support for DW-MMC controllers

2012-07-12 Thread Thomas Abraham
This patch set enables device tree based support for the four dw-mmc controllers on Samsung's Exynos5250 SoC. Thomas Abraham (3): ARM: Samsung: Add support for MSHC controller clocks ARM: Exynos5: Add AUXDATA support for MSHC controllers ARM: dts: Add nodes for dw_mmc controller

[PATCH v3 2/6] mmc: dw_mmc: allow probe to succeed even if one slot is initialized

2012-07-12 Thread Thomas Abraham
Instead of aborting the probe in case a slot initialization fails, allow initialization of as many slots as possible. If there are atleast one instance of slot that is successfully initialized, allow the driver probe to succeed. Signed-off-by: Thomas Abraham --- drivers/mmc/host/dw_mmc.c | 23

[PATCH v3 3/6] mmc: dw_mmc: lookup for optional biu and ciu clocks

2012-07-12 Thread Thomas Abraham
Some platforms allow for clock gating and control of bus interface unit clock and card interface unit clock. Add support for clock lookup of optional biu and ciu clocks for clock gating and clock speed determination. Signed-off-by: Abhilash Kesavan Signed-off-by: Thomas Abraham --- drivers/mmc

[PATCH v3 5/6] mmc: dw_mmc: add device tree support

2012-07-12 Thread Thomas Abraham
Add device tree based discovery support. Signed-off-by: Thomas Abraham --- .../devicetree/bindings/mmc/synposis-dw-mshc.txt | 108 +++ drivers/mmc/host/dw_mmc-pltfm.c| 24 +++ drivers/mmc/host/dw_mmc.c | 201

[PATCH v3 6/6] mmc: dw_mmc: add samsung exynos5250 specific extentions

2012-07-12 Thread Thomas Abraham
extenstions. Signed-off-by: Abhilash Kesavan Signed-off-by: Thomas Abraham --- .../devicetree/bindings/mmc/synposis-dw-mshc.txt | 38 ++- drivers/mmc/host/dw_mmc-pltfm.c| 15 +++ drivers/mmc/host/dw_mmc.c | 40

[PATCH v3 4/6] mmc: dw_mmc: add quirk to indicate missing write protect line

2012-07-12 Thread Thomas Abraham
with device tree support enabled, such platform callbacks cannot be supported. Add a new quirk for notifying the driver about the missing write protect line so the driver can assume that the card write protection is disabled. Signed-off-by: Thomas Abraham Acked-by: Will Newton --- drivers/mmc

[PATCH v3 1/6] mmc: dw_mmc: convert copy of struct device in struct dw_mci to a reference

2012-07-12 Thread Thomas Abraham
dw_mci' is then incorrect. Fix this by converting the copy of 'struct device' in 'struct dw_mci' to a reference. Signed-off-by: Thomas Abraham --- drivers/mmc/host/dw_mmc-pci.c |2 +- drivers/mmc/host/dw_mmc-pltfm.c |2 +- drivers/mmc/host/dw_mmc.c | 56 +++

[PATCH v3 0/6] mmc: dw_mmc: add support for device tree based instantiation

2012-07-12 Thread Thomas Abraham
sixth patch add Samsung Exynos5250 specific extentions to the driver. This patchset is based on Samsung kernel tree's for-next branch with the mmc tree's mmc-next branch merged. Thomas Abraham (6): mmc: dw_mmc: convert copy of struct device in struct dw_mci to a reference mmc: dw_

Re: [PATCH v5 0/6] spi: s3c64xx: add support for device tree

2012-07-12 Thread Thomas Abraham
On 11 July 2012 23:30, Thomas Abraham wrote: > On 11 July 2012 23:19, Mark Brown wrote: >> On Wed, Jul 11, 2012 at 09:10:59PM +0530, Thomas Abraham wrote: >>> Changes since v4: >>> - Includes the missing gpio request for slave select line gpio as suggested >>>

[PATCH] ARM: Exynos: Add device tree node for Exynos4 interrupt combiner controller

2012-07-11 Thread Thomas Abraham
Add node for Exynos4 interrupt combiner controller. Signed-off-by: Thomas Abraham --- arch/arm/boot/dts/exynos4210.dtsi | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi index a1dd2ee

Re: [PATCH v5 0/6] spi: s3c64xx: add support for device tree

2012-07-11 Thread Thomas Abraham
On 11 July 2012 23:19, Mark Brown wrote: > On Wed, Jul 11, 2012 at 09:10:59PM +0530, Thomas Abraham wrote: >> Changes since v4: >> - Includes the missing gpio request for slave select line gpio as suggested >> by Mark Brown. > > These looked OK (and have had quite

Re: [PATCH v5 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-11 Thread Thomas Abraham
On 11 July 2012 19:01, Mark Brown wrote: > On Wed, Jul 11, 2012 at 05:51:13PM +0530, Thomas Abraham wrote: > >> Based on your comments to add the gpio request, only two patches 5/6 >> and 6/6 in this series have changed since. I have cc'ed you in the >> other 4 patche

[PATCH v5 6/6] spi: s3c64xx: add device tree support

2012-07-11 Thread Thomas Abraham
Add support for device based discovery. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh Acked-by: Grant Likely --- .../devicetree/bindings/spi/spi-samsung.txt| 113 drivers/spi/spi-s3c64xx.c | 305 +--- 2 files changed, 378

[PATCH v5 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-11 Thread Thomas Abraham
and replaced with call to gpio_set_value in the driver. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh Acked-by: Grant Likely --- arch/arm/plat-samsung/include/plat/s3c64xx-spi.h |2 - drivers/spi/spi-s3c64xx.c| 31 ++--- 2 files changed

[PATCH v5 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-07-11 Thread Thomas Abraham
With the spi controller hardware configuration moved into the driver data, there are no more default hardware configuration data that is passed through platform data. Accordingly, the s3c64xx_spi{0|1|2}_set_platdata functions are adapted to these changes. Signed-off-by: Thomas Abraham Acked-by

[PATCH v5 3/6] ARM: Samsung: Remove pdev pointer parameter from spi gpio setup functions

2012-07-11 Thread Thomas Abraham
The platform data pointer that is passed to the spi gpio setup functions is not used. Hence, this parameter is removed from all the spi gpio setup functions. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh --- arch/arm/mach-exynos/setup-spi.c |8 +++- arch/arm

[PATCH v5 2/6] spi: s3c64xx: move controller information into driver data

2012-07-11 Thread Thomas Abraham
-by: Thomas Abraham Acked-by: Jaswinder Singh Acked-by: Grant Likely --- arch/arm/mach-exynos/clock-exynos4.c | 18 ++-- arch/arm/mach-exynos/setup-spi.c | 25 arch/arm/mach-s3c24xx/clock-s3c2416.c|3 +- arch/arm/mach-s3c24xx/clock-s3c2443.c

[PATCH v5 1/6] spi: s3c64xx: remove unused S3C64XX_SPI_ST_TRLCNTZ macro

2012-07-11 Thread Thomas Abraham
The macro S3C64XX_SPI_ST_TRLCNTZ is not used and hence it is removed. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh Acked-by: Grant Likely --- drivers/spi/spi-s3c64xx.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers

[PATCH v5 0/6] spi: s3c64xx: add support for device tree

2012-07-11 Thread Thomas Abraham
Changes since v4: - Includes the missing gpio request for slave select line gpio as suggested by Mark Brown. Changes since v3: - Fixed the build breakage after applying 3rd patch in this series (which had dependency on the 6th patch). This was reported by Doug Anderson. Changes since v2: - Re

Re: [PATCH v5 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-11 Thread Thomas Abraham
On 11 July 2012 17:17, Mark Brown wrote: > On Wed, Jul 11, 2012 at 04:45:59PM +0530, Thomas Abraham wrote: >> The set_level callback in the controller data, which is used to configure >> the slave select line, cannot be supported when migrating the driver to >> device tree b

[PATCH v5 6/6] spi: s3c64xx: add device tree support

2012-07-11 Thread Thomas Abraham
Add support for device based discovery. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh Acked-by: Grant Likely --- .../devicetree/bindings/spi/spi-samsung.txt| 113 +++ drivers/spi/spi-s3c64xx.c | 306 +--- 2 files changed, 379

[PATCH v5 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-11 Thread Thomas Abraham
and replaced with call to gpio_set_value in the driver. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh Acked-by: Grant Likely --- arch/arm/plat-samsung/include/plat/s3c64xx-spi.h |2 - drivers/spi/spi-s3c64xx.c| 30 ++--- 2 files changed

Re: [PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-10 Thread Thomas Abraham
On 10 July 2012 22:27, Mark Brown wrote: > On Tue, Jul 10, 2012 at 10:22:31PM +0530, Thomas Abraham wrote: > >> In non-dt case, the platform code supplying the gpio number (slave >> select line) is responsible for requesting the gpio during the >> machine_init call. So

Re: [PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-10 Thread Thomas Abraham
On 10 July 2012 20:08, Mark Brown wrote: > On Tue, Jul 10, 2012 at 07:57:38PM +0530, Thomas Abraham wrote: >> The set_level callback in the controller data, which is used to configure >> the slave select line, cannot be supported when migrating the driver to >> device tree b

[PATCH v4 6/6] spi: s3c64xx: add device tree support

2012-07-10 Thread Thomas Abraham
Add support for device based discovery. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh Acked-by: Grant Likely --- .../devicetree/bindings/spi/spi-samsung.txt| 113 drivers/spi/spi-s3c64xx.c | 277 +--- 2 files changed, 358

[PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-10 Thread Thomas Abraham
and replaced with call to gpio_set_value in the driver. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh Acked-by: Grant Likely --- arch/arm/plat-samsung/include/plat/s3c64xx-spi.h |2 -- drivers/spi/spi-s3c64xx.c| 11 ++- 2 files changed, 6

[PATCH v4 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-07-10 Thread Thomas Abraham
With the spi controller hardware configuration moved into the driver data, there are no more default hardware configuration data that is passed through platform data. Accordingly, the s3c64xx_spi{0|1|2}_set_platdata functions are adapted to these changes. Signed-off-by: Thomas Abraham Acked-by

[PATCH v4 3/6] ARM: Samsung: Remove pdev pointer parameter from spi gpio setup functions

2012-07-10 Thread Thomas Abraham
The platform data pointer that is passed to the spi gpio setup functions is not used. Hence, this paremeter is removed from all the spi gpio setup functions. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh --- arch/arm/mach-exynos/setup-spi.c |8 +++- arch/arm

[PATCH v4 2/6] spi: s3c64xx: move controller information into driver data

2012-07-10 Thread Thomas Abraham
-by: Thomas Abraham Acked-by: Jaswinder Singh Acked-by: Grant Likely --- arch/arm/mach-exynos/clock-exynos4.c | 18 ++-- arch/arm/mach-exynos/setup-spi.c | 25 arch/arm/mach-s3c24xx/clock-s3c2416.c|3 +- arch/arm/mach-s3c24xx/clock-s3c2443.c

[PATCH v4 1/6] spi: s3c64xx: remove unused S3C64XX_SPI_ST_TRLCNTZ macro

2012-07-10 Thread Thomas Abraham
The macro S3C64XX_SPI_ST_TRLCNTZ is not used and hence it is removed. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh Acked-by: Grant Likely --- drivers/spi/spi-s3c64xx.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers

[PATCH v4 0/6] spi: s3c64xx: add support for device tree

2012-07-10 Thread Thomas Abraham
ested for Exynos4210 and Exynos5250 with onboard spi nor flash device. The patch series (6 patches) that add board/platform specific support has no changes since the v2 version. This series is available at: http://lists.infradead.org/pipermail/linux-arm-kernel/2012-May/100812.html Thomas Abrah

Re: [PATCH] ARM: EXYNOS: add FIMD1 support for EXYNOS5

2012-06-04 Thread Thomas Abraham
Dear Mr. Han, On 4 June 2012 16:11, Jingoo Han wrote: > This patch adds platform device s5p_device_fimd1 for EXYNOS FIMD1. > EXYNOS has two FIMDs(FIMD0, FIMD1). Some definitions used to enable > EXYNOS FIMD1 are added. > > This patch also adds resource definitions for EXYNOS5 FIMD1. > FIMD1 clock

Re: [PATCH 05/20] ARM: EXYNOS: Redefine IRQ_MCT_L0,1 definition

2012-06-04 Thread Thomas Abraham
Dear Mr. Park, On 27 May 2012 06:59, Kyungmin Park wrote: > Hi, > > On Tue, May 1, 2012 at 4:14 AM, Thomas Abraham > wrote: >> From: Changhwan Youn >> >> Redefine IRQ_MCT_L0,1 irq definition as it is changed in rev1 of EXYNOS5. >> >> Signed-off-by

[PATCH] ARM: S3C64XX: Add a new dma request id for device tree based dma channel lookup

2012-06-03 Thread Thomas Abraham
dma wrappper operations. Signed-off-by: Thomas Abraham --- arch/arm/mach-s3c64xx/include/mach/dma.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s3c64xx/include/mach/dma.h b/arch/arm/mach-s3c64xx/include/mach/dma.h index fe1a98c..57b1ff4 100644 --- a/arch/a

[PATCH v2 5/6] ARM: dts: Add nodes for spi controllers for Samsung Exynos4 platforms

2012-06-03 Thread Thomas Abraham
Add device nodes for the three instances of spi controllers in Exynos4 platforms. Enable instance spi 2 for smdkv310 board and disable all spi instances for origen board. Signed-off-by: Thomas Abraham --- arch/arm/boot/dts/exynos4210-origen.dts | 12 + arch/arm/boot/dts/exynos4210

[PATCH v2 6/6] ARM: dts: Add nodes for spi controllers for Samsung Exynos5 platforms

2012-06-03 Thread Thomas Abraham
Add device nodes for the three instances of spi controllers in Exynos5 platforms and enable instance spi 1 for smdk5250 board. Signed-off-by: Thomas Abraham --- arch/arm/boot/dts/exynos5250-smdk5250.dts | 38 + arch/arm/boot/dts/exynos5250.dtsi | 36

[PATCH v2 4/6] ARM: Exynos5: Enable platform support for SPI controllers

2012-06-03 Thread Thomas Abraham
Add the platform bits which are required to support SPI controllers. Signed-off-by: Thomas Abraham --- arch/arm/mach-exynos/include/mach/map.h |3 +++ arch/arm/mach-exynos/mach-exynos5-dt.c |6 ++ 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos

[PATCH v2 3/6] ARM: Exynos4: Enable platform support for SPI controllers

2012-06-03 Thread Thomas Abraham
Add the platform bits which are required to support SPI controllers. Signed-off-by: Thomas Abraham --- arch/arm/mach-exynos/include/mach/irqs.h |4 arch/arm/mach-exynos/mach-exynos4-dt.c |6 ++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach

[PATCH v2 2/6] ARM: Exynos5: Add spi clock support

2012-06-03 Thread Thomas Abraham
Add support for clock instances for each spi controller. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh --- arch/arm/mach-exynos/clock-exynos5.c | 98 ++ 1 files changed, 98 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos/clock

[PATCH v2 1/6] ARM: Exynos4: Fix the incorrect hierarchy of spi controller bus clock

2012-06-03 Thread Thomas Abraham
sclk_spi clock. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh --- arch/arm/mach-exynos/clock-exynos4.c | 48 - 1 files changed, 40 insertions(+), 8 deletions(-) diff --git a/arch/arm/mach-exynos/clock-exynos4.c b/arch/arm/mach-exynos/clock-exynos4.c index

[PATCH v2 0/6] ARM: Exynos: Enable SPI platform support for Exynos4 and Exynos5

2012-06-03 Thread Thomas Abraham
Changes since v1: - Minor fixes based on comments from Olof, Kukjin and Padma. - Rebased to Linux 3.5-rc1 This patch set enables device tree based platform support for the three spi controllers on Samsung's Exynos4 and Exynos5 SoC's. Thomas Abraham (6): ARM: Exynos4: Fix the

[PATCH v3 6/6] spi: s3c64xx: add device tree support

2012-06-03 Thread Thomas Abraham
Add support for device based discovery. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh Acked-by: Grant Likely --- .../devicetree/bindings/spi/spi-samsung.txt| 113 drivers/spi/spi-s3c64xx.c | 279 +--- 2 files changed, 359

[PATCH v3 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-06-03 Thread Thomas Abraham
and replaced with call to gpio_set_value in the driver. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh Acked-by: Grant Likely --- arch/arm/plat-samsung/include/plat/s3c64xx-spi.h |2 -- drivers/spi/spi-s3c64xx.c|8 2 files changed, 4 insertions

[PATCH v3 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-06-03 Thread Thomas Abraham
With the spi controller hardware configuration moved into the driver data, there are no more default hardware configuration data that is passed through platform data. Accordingly, the s3c64xx_spi{0|1|2}_set_platdata functions are adapted to these changes. Signed-off-by: Thomas Abraham Acked-by

[PATCH v3 3/6] ARM: Samsung: Remove pdev pointer paremeter from spi gpio setup functions

2012-06-03 Thread Thomas Abraham
The platform data pointer that is passed to the spi gpio setup functions is not used. Hence, this paremeter is removed from all the spi gpio setup functions. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh --- arch/arm/mach-exynos/setup-spi.c |8 +++- arch/arm

[PATCH v3 2/6] spi: s3c64xx: move controller information into driver data

2012-06-03 Thread Thomas Abraham
-by: Thomas Abraham Acked-by: Jaswinder Singh Acked-by: Grant Likely --- arch/arm/mach-exynos/clock-exynos4.c | 18 ++-- arch/arm/mach-exynos/setup-spi.c | 25 arch/arm/mach-s3c24xx/clock-s3c2416.c|3 +- arch/arm/mach-s3c24xx/clock-s3c2443.c

[PATCH v3 1/6] spi: s3c64xx: remove unused S3C64XX_SPI_ST_TRLCNTZ macro

2012-06-03 Thread Thomas Abraham
The macro S3C64XX_SPI_ST_TRLCNTZ is not used and hence it is removed. Signed-off-by: Thomas Abraham Acked-by: Jaswinder Singh Acked-by: Grant Likely --- drivers/spi/spi-s3c64xx.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers

[PATCH v3 0/6] spi: s3c64xx: add support for device tree

2012-06-03 Thread Thomas Abraham
Singh . This patch series adds device tree based discovery support for Samsung's s3c64xx compatible spi controller. This is mainly tested for Exynos4210 and Exynos5250 with onboard spi nor flash device. Thomas Abraham (6): spi: s3c64xx: remove unused S3C64XX_SPI_ST_TRLCNTZ macro spi: s3

Re: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-06-03 Thread Thomas Abraham
On 1 June 2012 18:09, Mark Brown wrote: > On Fri, Jun 01, 2012 at 10:47:44AM +0800, Thomas Abraham wrote: > >> 1. There is one instance of 'struct platform_device' for each of the >> spi controller instances (0/1/2) named "s3c64xx-spi" (in >> arch/arm/

[PATCH] gpio: samsung: fix typo in name of exynos5 gpio chip list

2012-06-03 Thread Thomas Abraham
Commit 30b842889eea ("Merge tag 'soc2' of git://git.kernel.org/pub/scm/ linux/kernel/git/arm/arm-soc) introduced a typo in the name of the list of gpio chips for Exynos5 gpio controller. Fix this typo. Signed-off-by: Thomas Abraham --- drivers/gpio/gpio-samsung.c |2 +- 1 f

Re: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-31 Thread Thomas Abraham
On 31 May 2012 19:36, Mark Brown wrote: > On Thu, May 31, 2012 at 10:05:42AM +0800, Thomas Abraham wrote: >> On 30 May 2012 18:13, Mark Brown wrote: > >> > No there isn't.  You've got things like s3c64xx_device_spi0 in >> > arch/arm/plat-samsung/devs.c

Re: [PATCH 0/3] pinctrl: add support for samsung pinctrl driver

2012-05-31 Thread Thomas Abraham
On 1 June 2012 09:40, Linus Walleij wrote: > On Thu, May 24, 2012 at 7:47 AM, Thomas Abraham > wrote: > >> Note that, the Samsung pinctrl driver is usable only on device tree enabled >> Samsung platforms. Legacy platforms would still continue to use the older >> gpiol

Re: [PATCH 1/3] pinctrl: add samsung pinctrl and gpiolib driver

2012-05-31 Thread Thomas Abraham
On 1 June 2012 09:36, Linus Walleij wrote: > On Thu, May 24, 2012 at 7:47 AM, Thomas Abraham > wrote: > >> diff --git a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt >> b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt > > It would be n

Re: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-30 Thread Thomas Abraham
On 30 May 2012 18:13, Mark Brown wrote: > On Wed, May 30, 2012 at 06:05:31PM +0800, Thomas Abraham wrote: >> On 30 May 2012 17:34, Mark Brown wrote: > >> > Right, and there's no problem at all with using the name.  The thing is >> > that there's no n

<    2   3   4   5   6   7   8   9   10   11   >