Re: [PATCH v2 1/5] clk: samsung: add common clock framework support for Samsung platforms

2012-10-30 Thread Tomasz Figa
conclusions from discussing this patch series with Tomasz F. Yes, as I said, I'm definitely for the single clock provider approach (aka imx-like approach). Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-04 Thread Tomasz Figa
not contain my fixes for S3C6410. Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] ARM: EXYNOS: Make s3c_device_i2c0 always use id 0

2012-11-07 Thread Tomasz Figa
. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-s3c64xx/clock.c | 4 arch/arm/plat-samsung/devs.c | 4 2 files changed, 8 deletions(-) diff --git a/arch/arm/mach-s3c64xx/clock.c b/arch/arm/mach-s3c64xx/clock.c index

[PATCH] ARM: EXYNOS: origen: Add missing USB regulators

2012-11-07 Thread Tomasz Figa
This patch adds missing USB OTG regulators needed for s3c-hsotg driver to work on Origen board. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/mach-origen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch

Re: [PATCH] ARM: EXYNOS: origen: Add missing USB regulators

2012-11-07 Thread Tomasz Figa
On Wednesday 07 of November 2012 14:01:19 Tomasz Figa wrote: This patch adds missing USB OTG regulators needed for s3c-hsotg driver to work on Origen board. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/mach

Re: [PATCH] ARM: dts: exynos4: Add support for Exynos4x12 SoCs

2012-11-07 Thread Tomasz Figa
Hi Kgene, On Wednesday 07 of November 2012 11:26:42 Kukjin Kim wrote: Kukjin Kim wrote: Tomasz Figa wrote: This patch adds device tree sources for Exynos4x12 SoC series (currently Exynos4212 and Exynos4412) and enables mach-exynos4-dt to support these SoCs. Signed-off

Re: [PATCH] ARM: Exynos5250: Enabling dwc3-exynos driver

2012-11-07 Thread Tomasz Figa
), but I'm not sure if there is a strict convention here. Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2] ARM: EXYNOS: origen: Add missing USB regulators

2012-11-08 Thread Tomasz Figa
This patch adds missing USB OTG regulators needed for s3c-hsotg driver to work on Origen board. Confirmed with schematics of and tested on Origen board. Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/mach-origen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH 1/2] ARM: S3C64XX: Remove duplicated camera clock

2012-11-10 Thread Tomasz Figa
, - .ctrlbit= S3C_CLKCON_SCLK_CAM, - }, { .name = sclk_jpeg, .enable = s3c64xx_sclk_ctrl, .ctrlbit= S3C_CLKCON_SCLK_JPEG, Reviewed-by: Tomasz Figa tomasz.f...@gmail.com Best regards, Tomasz Figa

Re: [PATCH 2/2] ARM: S3C64XX: Staticly define parent clock of camera clock

2012-11-10 Thread Tomasz Figa
= clkset_camif, }, { .clk= { .name = sclk_mfc, Reviewed-by: Tomasz Figa tomasz.f...@gmail.com Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH v3 4/6] ARM: EXYNOS: Add support for Exynos secure firmware

2012-11-12 Thread Tomasz Figa
of it, it may be better to just add a callback like set_boot_addr(cpu, addr), which would set boot address of given CPU without exporting address of its boot register outside firmware code. Are you OK with this kind of approach? Best regards, -- Tomasz Figa Samsung Poland RD Center SW Solution Development

Re: [PATCH v3 0/6] ARM: EXYNOS: Add secure firmware support

2012-11-12 Thread Tomasz Figa
of code _without_ _any_ documentation. That means people will interpret it differently, and it'll get used differently from platform to platform. Let's have some documentation on this. Right, I will include documentation in next version of this patchset. Best regards, -- Tomasz Figa Samsung

Re: [PATCH] ARM: dts: add board dts file for Exynos4412 based SMDK board

2012-11-12 Thread Tomasz Figa
Hi Thomas, On Saturday 03 of November 2012 20:19:32 Thomas Abraham wrote: Add a minimal board dts file for Samsung Exynos4412 based SMDK board. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org --- This patch depends the on the following patch posted by Tomasz Figa. ARM: dts: exynos4

[PATCH] ARM: dts: exynos4210-trats: Remove broken-voltage property from sdhci node

2012-11-13 Thread Tomasz Figa
The broken voltage property has been replaced with auto detection based on voltages available on vmmc voltage regulator, so there is no use for it now. This patch removes the now unused property from Trats Device Tree sources. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin

[PATCH] i2c: i2c-s3c2410: Add support for pinctrl

2012-11-13 Thread Tomasz Figa
This patch adds support for pin configuration using pinctrl subsystem to the i2c-s3c2410 driver. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/i2c/samsung-i2c.txt | 20 drivers/i2c

[PATCH v3 2/4] ARM: EXYNOS: pm_domain: Fix power domain name initialization

2012-11-13 Thread Tomasz Figa
This patch adds initialization of name field in generic power domain struct. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/pm_domains.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm

[PATCH v3 3/4] ARM: EXYNOS: pm_domain: Bind devices to power domains using DT

2012-11-13 Thread Tomasz Figa
after unbinding a driver from it. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../bindings/arm/exynos/power_domain.txt | 13 +++- arch/arm/mach-exynos/pm_domains.c | 82 ++ 2 files changed, 94

[PATCH v3 4/4] ARM: dts: exynos4: Set up power domains

2012-11-13 Thread Tomasz Figa
This patch adds device tree nodes for power domains available on Exynos 4 SoCs. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4.dtsi| 30 ++ arch/arm/boot/dts/exynos4210.dtsi | 5

Re: [PATCH v3 0/4] ARM: EXYNOS: Power domain DT support extension

2012-11-13 Thread Tomasz Figa
Hi, On Tuesday 13 of November 2012 13:51:51 Tomasz Figa wrote: This patch series fixes two issues with existing DT support for Exynos power domains and extends it with the ability of binding devices to domains, basically making it possible to use power domains with DT. Based on for-next

[PATCH v3 RESEND 0/4] ARM: EXYNOS: Power domain DT support extension

2012-11-13 Thread Tomasz Figa
of Kgene's tree. Changes since v1: - Added samsung, prefix to power-domain property. - Added power domain nodes to Exynos4 device tree sources. Tomasz Figa (4): ARM: EXYNOS: pm_domain: Detect domain state on registration from DT ARM: EXYNOS: pm_domain: Fix power domain name initialization ARM

[PATCH v3 2/4] ARM: EXYNOS: pm_domain: Fix power domain name initialization

2012-11-13 Thread Tomasz Figa
This patch adds initialization of name field in generic power domain struct. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/pm_domains.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm

[PATCH v3 3/4] ARM: EXYNOS: pm_domain: Bind devices to power domains using DT

2012-11-13 Thread Tomasz Figa
after unbinding a driver from it. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../bindings/arm/exynos/power_domain.txt | 13 +++- arch/arm/mach-exynos/pm_domains.c | 82 ++ 2 files changed, 94

Re: [PATCH v3 01/11] clk: samsung: add common clock framework helper functions for Samsung platforms

2012-11-14 Thread Tomasz Figa
[] __initdata + +extern void __iomem *reg_base; Where is it used? The name suggests that it should rather be static. -- Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v3 03/11] clk: exynos4: register clocks using common clock framework

2012-11-14 Thread Tomasz Figa
registering these clocks. Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 05/11] ARM: dts: add exynos4 clock controller nodes

2012-11-14 Thread Tomasz Figa
? + reg = 0x1003 0x2; + #clock-cells = 1; + }; + pinctrl_0: pinctrl@1140 { compatible = samsung,pinctrl-exynos4x12; reg = 0x1140 0x1000; Otherwise looks fine. Best regards, Tomasz Figa -- To unsubscribe from

Re: [PATCH v3 04/11] ARM: Exynos4: Migrate clock support to common clock framework

2012-11-14 Thread Tomasz Figa
(); + } + } +#endif + I don't like the idea of initializing the clocks from timer initialization. What about some platforms where MCT isn't used? It is also far from being elegant. Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung

Re: [PATCH v3 07/11] ARM: Exynos4: allow legacy board support to specify xxti and xusbxti clock speed

2012-11-14 Thread Tomasz Figa
unrelated code. IMHO any clock registration should be done from code in drivers/clk/samsung. Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v3 01/11] clk: samsung: add common clock framework helper functions for Samsung platforms

2012-11-15 Thread Tomasz Figa
On Thursday 15 of November 2012 14:03:12 Thomas Abraham wrote: Hi Tomasz, Thanks for reviewing these patches! On 15 November 2012 04:42, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Thomas, Looks mostly good, but I have some minor comments inline. On Thursday 15 of November 2012

Re: [PATCH v3 04/11] ARM: Exynos4: Migrate clock support to common clock framework

2012-11-15 Thread Tomasz Figa
On Thursday 15 of November 2012 14:43:21 Thomas Abraham wrote: On 15 November 2012 05:01, Tomasz Figa tomasz.f...@gmail.com wrote: On Thursday 15 of November 2012 03:37:26 Thomas Abraham wrote: Remove Samsung specific clock support in Exynos4 and migrate to use common clock framework

Re: [PATCH] ARM: dts: add board dts file for Exynos4412 based SMDK board

2012-11-16 Thread Tomasz Figa
On Thursday 15 of November 2012 13:48:55 Thomas Abraham wrote: Hi Tomasz, Thanks for your comments. On 12 November 2012 19:37, Tomasz Figa t.f...@samsung.com wrote: Hi Thomas, On Saturday 03 of November 2012 20:19:32 Thomas Abraham wrote: Add a minimal board dts file for Samsung

Re: [PATCH] ARM: dts: add board dts file for Exynos4412 based SMDK board

2012-11-16 Thread Tomasz Figa
On Friday 16 of November 2012 18:03:15 Thomas Abraham wrote: On 16 November 2012 16:41, Tomasz Figa t.f...@samsung.com wrote: On Thursday 15 of November 2012 13:48:55 Thomas Abraham wrote: Hi Tomasz, Thanks for your comments. On 12 November 2012 19:37, Tomasz Figa t.f...@samsung.com

[PATCH v2 0/2] mmc: host: sdhci-s3c: Add support for pinctrl interface

2012-11-16 Thread Tomasz Figa
of incorrect merge Tomasz Figa (2): mmc: host: sdhci-s3c: Use devm_gpio_request to request GPIOs mmc: host: sdhci-s3c: Add support for pinctrl .../devicetree/bindings/mmc/samsung-sdhci.txt | 20 ++--- drivers/mmc/host/sdhci-s3c.c | 52 -- 2 files

[PATCH v2 1/2] mmc: host: sdhci-s3c: Use devm_gpio_request to request GPIOs

2012-11-16 Thread Tomasz Figa
to use devm_gpio_request to free requested pins automatically after unbinding the driver. Signed-off-by: Tomasz Figa t.f...@samsung.com --- drivers/mmc/host/sdhci-s3c.c | 40 +--- 1 file changed, 9 insertions(+), 31 deletions(-) diff --git a/drivers/mmc/host

[PATCH v2 2/2] mmc: host: sdhci-s3c: Add support for pinctrl

2012-11-16 Thread Tomasz Figa
This patch adds support for pin configuration using pinctrl subsystem to the sdhci-s3c driver. Signed-off-by: Tomasz Figa t.f...@samsung.com --- .../devicetree/bindings/mmc/samsung-sdhci.txt| 20 +--- drivers/mmc/host/sdhci-s3c.c | 12

Re: [PATCH] ARM: dts: add board dts file for Exynos4412 based SMDK board

2012-11-16 Thread Tomasz Figa
On Friday 16 of November 2012 18:47:54 Thomas Abraham wrote: On 16 November 2012 18:28, Tomasz Figa t.f...@samsung.com wrote: On Friday 16 of November 2012 18:03:15 Thomas Abraham wrote: On 16 November 2012 16:41, Tomasz Figa t.f...@samsung.com wrote: On Thursday 15 of November 2012 13:48

[PATCH 0/5] ARM: dts: exynos4210-trats: Device tree extension

2012-11-19 Thread Tomasz Figa
Tomasz Figa (5): ARM: dts: exynos4210-trats: Update for pinctrl-samsung driver ARM: dts: exynos4210-trats: Add nodes for GPIO keys available on Trats ARM: dts: exynos4210-trats: Add node for i2c3 bus ARM: dts: exynos4210-trats: Add node for touchscreen voltage regulator ARM: dts

[PATCH 1/5] ARM: dts: exynos4210-trats: Update for pinctrl-samsung driver

2012-11-19 Thread Tomasz Figa
This patch updates all parts of Trats dts related to pin configuration to use new GPIO and pinctrl bindings, instead of (now unsupported on Exynos4) legacy gpio-samsung bindings. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm

[PATCH 2/5] ARM: dts: exynos4210-trats: Add nodes for GPIO keys available on Trats

2012-11-19 Thread Tomasz Figa
This patch extends dts file of Samsung Trats board to add support for available GPIO keys using gpio-keys driver. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4210-trats.dts | 33

[PATCH 3/5] ARM: dts: exynos4210-trats: Add node for i2c3 bus

2012-11-19 Thread Tomasz Figa
This patch adds device tree node for i2c3 bus to device tree source of Samsung Trats board. This bus is used by mms114 touchscreen controller, for which support will be added in separate patch. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com

[PATCH 4/5] ARM: dts: exynos4210-trats: Add node for touchscreen voltage regulator

2012-11-19 Thread Tomasz Figa
This patch adds device tree node for a fixed voltage regulator used for touchscreen on Samsung Trats board. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4210-trats.dts | 9 + 1 file changed, 9 insertions

[PATCH 5/5] ARM: dts: exynos4210-trats: Add node for touchscreen

2012-11-19 Thread Tomasz Figa
This patch adds a device tree node for the Melfas MMS114-controlled touchscreen present on Samsung Trats board. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4210-trats.dts | 11 +++ 1 file changed, 11

[PATCH 0/4] ARM: dts: exynos4210-origen: Device tree fixes

2012-11-19 Thread Tomasz Figa
is added Tested on Origen board. Depends on: [PATCH v2 0/2] mmc: host: sdhci-s3c: Add support for pinctrl interface Tomasz Figa (4): ARM: dts: exynos4210-origen: Split memory sections ARM: dts: exynos4210-origen: Update for pinctrl-samsung driver ARM: dts: exynos4210-origen: Update sdhci nodes

[PATCH 1/4] ARM: dts: exynos4210-origen: Split memory sections

2012-11-19 Thread Tomasz Figa
This patch changes memory configuration defined in dts file of Origen board from single 1 GiB section into four 256 MiB sections to match section size limit. Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/boot/dts/exynos4210-origen.dts | 5 - 1 file changed, 4 insertions(+), 1

[PATCH 2/4] ARM: dts: exynos4210-origen: Update for pinctrl-samsung driver

2012-11-19 Thread Tomasz Figa
This patch updates all parts of Origen dts related to pin configuration to use new GPIO and pinctrl bindings, instead of (now unsupported on Exynos4) legacy gpio-samsung bindings. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm

[PATCH 3/4] ARM: dts: exynos4210-origen: Update sdhci nodes for current bindings

2012-11-19 Thread Tomasz Figa
This patch modifies sdhci nodes present in Origen device tree source to use current generic mmc bindings. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4210-origen.dts | 8 ++-- 1 file changed, 2 insertions

[PATCH 4/4] ARM: dts: exynos4210-origen: Add vmmc fixed voltage regulator

2012-11-19 Thread Tomasz Figa
This patch adds fixed voltage vmmc regulator to dts file of Origen board. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4210-origen.dts | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm

[PATCH] ARM: dts: exynos4: Use drive strength 3 for SD pins

2012-11-19 Thread Tomasz Figa
This patch modifies pin control groups of SD pins on Exynos4210 and Exynos4x12 to use drive strength 3, which corresponds to S5P_GPIO_DRVSTR_LV4 in legacy non-DT code. This is needed at least on Origen board for sdhci2 to work. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off

Re: [PATCH 0/4] ARM: dts: exynos4210-origen: Device tree fixes

2012-11-21 Thread Tomasz Figa
Hi Kgene, On Monday 19 of November 2012 15:46:32 Tomasz Figa wrote: This patch series fixes device tree support for Origen board: - memory is defined using sections of maximum allowed size - any pin configuration is modified to use pinctrl - invalid properties in sdhci nodes are replaced

Re: [PATCH] ARM: dts: exynos4: Use drive strength 3 for SD pins

2012-11-21 Thread Tomasz Figa
Hi Kgene, On Tuesday 20 of November 2012 20:10:25 Kukjin Kim wrote: Tomasz Figa wrote: Hi Kgene, On Tuesday 20 of November 2012 18:18:44 Kukjin Kim wrote: Tomasz Figa wrote: This patch modifies pin control groups of SD pins on Exynos4210 and Exynos4x12 to use drive strength

Re: [PATCH v3 RESEND 0/4] ARM: EXYNOS: Power domain DT support extension

2012-11-21 Thread Tomasz Figa
Hi Kgene, On Tuesday 13 of November 2012 14:08:23 Tomasz Figa wrote: This patch series fixes two issues with existing DT support for Exynos power domains and extends it with the ability of binding devices to domains, basically making it possible to use power domains with DT. Based

Re: [PATCH v2 0/2] mmc: host: sdhci-s3c: Add support for pinctrl interface

2012-11-21 Thread Tomasz Figa
Hi, On Friday 16 of November 2012 15:28:15 Tomasz Figa wrote: This series intends to add support for pin configuration using pin control interface. First patch cleans up GPIO requesting and freeing in the driver to simplify adding pin control support. Second patch adds pin control

Re: [PATCH] cpufreq: exynos: Broadcast frequency change notifications for all cores

2012-11-21 Thread Tomasz Figa
On Tuesday 13 of November 2012 10:26:12 Tomasz Figa wrote: On Exynos SoCs all cores share the same frequency setting, so changing frequency of one core will affect rest of cores. This patch modifies the exynos-cpufreq driver to inform cpufreq core about this behavior and broadcast frequency

Re: [PATCH v8 3/3] ARM: EXYNOS: Enabling samsung-usbphy driver for EXYNOS4210

2012-11-21 Thread Tomasz Figa
. Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v8 1/2] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-11-21 Thread Tomasz Figa
on Exynos SoCs, but on S3C64xx it's USB PHY mask. Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v8 2/2] usb: s3c-hsotg: Adding phy driver support

2012-11-21 Thread Tomasz Figa
; + } nitpick: The hsotg-plat = plat; assignment can be made without the else statement as well. Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v8 1/3] ARM: S3C64XX: Removing old phy setup code

2012-11-21 Thread Tomasz Figa
it breaks USB gadget on s3c64xx until patch 2 gets applied. I suggest you to add usb phy support to s3c64xx first and then remove the old code. Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH v8 2/3] ARM: S3C64XX: Enabling samsung-usbphy driver

2012-11-21 Thread Tomasz Figa
be CONFIG_SAMSUNG_USBPHY not CONFIG_ARCH_S3C64XX and in case of CONFIG_SAMSUNG_USBPHY disabled a dummy inline samsung_usphy_set_pdata should be defined in the header? Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH v3 0/6] ARM: EXYNOS: Add secure firmware support

2012-11-22 Thread Tomasz Figa
Hi Kgene, On Thursday 22 of November 2012 15:52:14 Kukjin Kim wrote: Tomasz Figa wrote: On Monday 12 of November 2012 09:55:30 Russell King - ARM Linux wrote: On Mon, Nov 12, 2012 at 04:39:28PM +0900, Kukjin Kim wrote: (+ Russell King) I think there's still an amount of work

[PATCH] ARM: EXYNOS: Add support for secondary CPU bring-up on Exynos4412

2012-11-22 Thread Tomasz Figa
Exynos4412 uses different information register for each core. This patch adjusts the bring-up code to take that into account. Signed-off-by: Tomasz Figa t.f...@samsung.com Reviewed-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/platsmp.c | 30

[PATCH v4 1/5] ARM: Add interface for registering and calling firmware-specific operations

2012-11-22 Thread Tomasz Figa
); } Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Tomasz Figa t.f...@samsung.com --- Documentation/arm/firmware.txt | 88 + arch/arm/common/Makefile| 2 + arch/arm/common/firmware.c | 18 + arch/arm/include

[PATCH v4 4/5] ARM: EXYNOS: Add IO mapping for non-secure SYSRAM.

2012-11-22 Thread Tomasz Figa
On TrustZone-enabled boards the non-secure SYSRAM is used for secondary CPU bring-up, so add a mapping for it. Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/common.c| 35

[PATCH v4 0/5] ARM: EXYNOS: Add secure firmware support

2012-11-22 Thread Tomasz Figa
://thread.gmane.org/gmane.linux.kernel.samsung-soc/12583/focus=12820 ) - Changed return types of all operations to int - Defined all operations to return 0 on success, -ENOSYS when not implemented or appropriate error code on error Tomasz Figa (5): ARM: Add interface for registering and calling firmware

[PATCH v4 5/5] ARM: EXYNOS: Add secure firmware support to secondary CPU bring-up

2012-11-22 Thread Tomasz Figa
Boards using secure firmware must use different CPU boot registers and call secure firmware to boot the CPU. Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/platsmp.c | 32 +++- 1 file

[PATCH v4 2/5] ARM: EXYNOS: Add support for secure monitor calls

2012-11-22 Thread Tomasz Figa
Some boards use secure monitor calls to communicate with secure firmware. This patch adds exynos_smc function which uses smc assembly instruction to do secure monitor calls. Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach

[PATCH v4 3/5] ARM: EXYNOS: Add support for Exynos secure firmware

2012-11-22 Thread Tomasz Figa
; reg = 0x0203F000 0x1000; }; /* ... */ }; Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Tomasz Figa t.f...@samsung.com --- .../devicetree/bindings/arm/samsung-boards.txt | 10 arch/arm/mach-exynos/Makefile

Re: [PATCH 0/3] regulator: max8997: minor updates and device tree support

2012-11-23 Thread Tomasz Figa
-regulator.txt -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html For whole series: Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards

Re: [PATCH] S3C24XX: add clockevent/clocksource support

2012-11-25 Thread Tomasz Figa
to samsung-time (and correct any platforms using it currently) 2) Add samsung-time support for s3c24xx 3) Add samsung-time support for s3c64xx What do you think? Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH v2 2/2] mmc: host: sdhci-s3c: Add support for pinctrl

2012-11-25 Thread Tomasz Figa
version with this comment addressed. Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v8 1/2] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-11-28 Thread Tomasz Figa
. Yes! I am aware of it. The fact that this ( MASK or ISOLATION) has always been part of the PMU, pmu_isolation seems quite generic that way. Though you can suggest a better name. What do you think about set_isolation(int on) or power_isolation(int on)? Best regards, -- Tomasz Figa Samsung

Re: [PATCH v8 2/2] usb: s3c-hsotg: Adding phy driver support

2012-11-28 Thread Tomasz Figa
, -- Tomasz Figa Samsung Poland RD Center SW Solution Development, Linux Platform -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 0/5] ARM: EXYNOS: Add secure firmware support

2012-11-28 Thread Tomasz Figa
Hi, On Saturday 24 of November 2012 11:21:03 Kukjin Kim wrote: Tomasz Figa wrote: Some Exynos-based boards are running with secure firmware running in TrustZone secure world, which changes the way some things have to be initialized. This series adds support for specifying firmware

Re: [PATCH 0/3] pinctrl: exynos: add support for Samsung's Exynos5250

2012-12-14 Thread Tomasz Figa
/majordomo-info.html Looks good. For the whole series: Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards, -- Tomasz Figa Samsung Poland RD Center SW Solution Development, Linux Platform -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message

Re: [PATCH] gpio: samsung: remove exynos_gpio_cfg

2012-12-14 Thread Tomasz Figa
making the legacy GPIO support useless, I think there is no need to extend it. Instead existing boards should be made to use the pinctrl driver. Best regards, -- Tomasz Figa Samsung Poland RD Center SW Solution Development, Linux Platform -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 4/4] ODROID-X: dts: Add mshc node for ODROID-X board

2012-12-17 Thread Tomasz Figa
control bindings must be used. Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/3] ARM: EXYNOS5: save CLK_TOP_SRC3 register before powergating

2012-12-20 Thread tomasz . figa
configuration registers from power domain code looks really ugly... Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: dts: fix split memory bank for SSDK5440

2012-12-20 Thread Tomasz Figa
arch (e.g. ARCH_EXYNOS). What's the actual bug caused by this? The description is vague. The kernel panics early on NULL pointer dereference in memory initialization. Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message

Re: [PATCH] ARM: dts: fix split memory bank for SSDK5440

2012-12-20 Thread Tomasz Figa
assume there was a reason for it. However I am not an expert in memory management, so please correct me if I am wrong. Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 3/3] ARM: EXYNOS5: save CLK_TOP_SRC3 register before powergating

2012-12-27 Thread Tomasz Figa
, -- Tomasz Figa Samsung Poland RD Center SW Solution Development, Linux Platform -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/3] ARM: EXYNOS5: save CLK_TOP_SRC3 register before powergating

2012-12-27 Thread Tomasz Figa
, -- Tomasz Figa Samsung Poland RD Center SW Solution Development, Linux Platform -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Early kernel hang with big DTB appended

2013-01-03 Thread Tomasz Figa
), cr=10c53c7d CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing instruction cache I tested on two Exynos-based boards (exynos4210-trats and one internal exynos4412-based board) and same happens on both. Do you have any ideas? Best regards, -- Tomasz Figa Samsung Poland RD Center SW

Re: Early kernel hang with big DTB appended

2013-01-04 Thread Tomasz Figa
Hi Nicolas, Thanks for your reply. On Thursday 03 of January 2013 21:48:05 Nicolas Pitre wrote: On Thu, 3 Jan 2013, Tomasz Figa wrote: Hi, I'm observing strange behavior when booting 3.8-rc1 and -rc2 with appended DTB. The kernel hangs very early when the DTB is bigger than some

Re: Early kernel hang with big DTB appended

2013-01-04 Thread Tomasz Figa
Hi Bryan, Thanks for your reply. On Thursday 03 of January 2013 13:40:43 Bryan Evenson wrote: -Original Message- From: linux-arm-kernel-boun...@lists.infradead.org [mailto:linux-arm- kernel-boun...@lists.infradead.org] On Behalf Of Tomasz Figa Sent: Thursday, January 03, 2013 10

Re: [PATCH 1/5 v2] Rename s5p-time to samsung-time

2013-01-08 Thread Tomasz Figa
(partly based on my historical work on this platform) and would be nice to have hrtime support already there, especially when all left is to just merge it. Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

[RFC PATCH 0/7] Initial Device Tree support for S3C64xx

2013-01-09 Thread Tomasz Figa
in future, hopefully with help of all S3C64xx board maintainers. Tomasz Figa (7): ARM: common: vic: Parse interrupt and resume masks from device tree ARM: common: vic: Fix invalid first IRQ number in OF-based registration ARM: s3c64xx: Add support for OF-based VIC initialization ARM: s3c64xx

[RFC PATCH 1/7] ARM: common: vic: Parse interrupt and resume masks from device tree

2013-01-09 Thread Tomasz Figa
This patch extends vic_of_init to parse valid interrupt sources and resume sources masks from device tree. If mask values are not specified in device tree, all sources are assumed to be valid, as before this patch. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- Documentation/devicetree

[RFC PATCH 2/7] ARM: common: vic: Fix invalid first IRQ number in OF-based registration

2013-01-09 Thread Tomasz Figa
numbers. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- arch/arm/common/vic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/common/vic.c b/arch/arm/common/vic.c index c2889da..8001994 100644 --- a/arch/arm/common/vic.c +++ b/arch/arm/common/vic.c @@ -421,9

[RFC PATCH 3/7] ARM: s3c64xx: Add support for OF-based VIC initialization

2013-01-09 Thread Tomasz Figa
This patch modifies IRQ initialization code of S3C64xx to support Device Tree-based initialization of VICs. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- arch/arm/mach-s3c64xx/common.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach

[RFC PATCH 4/7] ARM: s3c64xx: Fix build error with CONFIG_S3C_DEV_FB disabled

2013-01-09 Thread Tomasz Figa
If there is no board selecting CONFIG_S3C_DEV_FB enabled, build will fail on arch/arm/mach-s3c64xx/pm.c, where s3c_device_fb is referenced. This patch adds ifdef guard around the code making it compile only when CONFIG_S3C_DEV_FB is enabled. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com

[RFC PATCH 6/7] ARM: dts: Add basic dts include files for Samsung S3C64xx SoCs

2013-01-09 Thread Tomasz Figa
This patch adds basic device tree definitions for Samsung S3C64xx SoCs. Since all the SoCs in the series are very similar, the files are created hierarchically - one file for the whole series and then separate files for particular SoCs including the common one. Signed-off-by: Tomasz Figa

Re: [PATCH 0/5 v3] S3C / S5PC100: add clockevent/clocksource support

2013-01-09 Thread Tomasz Figa
create mode 100644 arch/arm/plat-samsung/include/plat/samsung-time.h rename arch/arm/plat-samsung/{s5p-time.c = samsung-time.c} (68%) delete mode 100644 arch/arm/plat-samsung/time.c The whole series looks good to me. Reviewed-by: Tomasz Figa tomasz.f...@gmail.com Also I tested

Re: [RFC PATCH 4/7] ARM: s3c64xx: Fix build error with CONFIG_S3C_DEV_FB disabled

2013-01-09 Thread Tomasz Figa
Hi Kukjin, On Wednesday 09 of January 2013 16:15:23 Kukjin Kim wrote: Tomasz Figa wrote: If there is no board selecting CONFIG_S3C_DEV_FB enabled, build will fail on arch/arm/mach-s3c64xx/pm.c, where s3c_device_fb is referenced. This patch adds ifdef guard around the code making

[PATCH] ARM: s3c64xx: cpuidle: Fix missing header error with CONFIG_CPU_IDLE enabled

2013-01-09 Thread Tomasz Figa
with proper header location. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- arch/arm/mach-s3c64xx/cpuidle.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/mach-s3c64xx/cpuidle.c b/arch/arm/mach-s3c64xx/cpuidle.c index e3e455b..50c66fe 100644 --- a/arch/arm/mach-s3c64xx

Re: [RFC PATCH 5/7] ARM: s3c64xx: Add board file for boot using Device Tree

2013-01-10 Thread Tomasz Figa
Hi Mark, On Thursday 10 of January 2013 10:52:22 Mark Brown wrote: On Thu, Jan 10, 2013 at 12:41:47AM +0100, Tomasz Figa wrote: + * The following lookup table is used to override device names when devices + * are registered from device tree. This is temporarily added to enable + * device

Re: [RFC PATCH 1/7] ARM: common: vic: Parse interrupt and resume masks from device tree

2013-01-10 Thread Tomasz Figa
On Thursday 10 of January 2013 11:03:14 Mark Brown wrote: On Thu, Jan 10, 2013 at 12:41:43AM +0100, Tomasz Figa wrote: +- interrupt-mask : Bit mask of valid interrupt sources (defaults to all valid) +- wakeup-mask : Bit mask of interrupt sources that can wake up the system + (defaults

[PATCH 0/6] Initial Device Tree support for S3C64xx

2013-01-12 Thread Tomasz Figa
, and (very) basic device tree source for FriendlyARM Mini6410 board. Current support is very limited and allows only basic bootup with UART and SDHCI, but should be fine as a start and will be extended in future, hopefully with help of S3C64xx board maintainers. Tomasz Figa (6): ARM: common: vic

[PATCH 1/6] ARM: common: vic: Parse interrupt and resume masks from device tree

2013-01-12 Thread Tomasz Figa
This patch extends vic_of_init to parse valid interrupt sources and resume sources masks from device tree. If mask values are not specified in device tree, all sources are assumed to be valid, as before this patch. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- Documentation/devicetree

[PATCH 2/6] ARM: common: vic: Fix invalid first IRQ number in OF-based registration

2013-01-12 Thread Tomasz Figa
numbers. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- arch/arm/common/vic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/common/vic.c b/arch/arm/common/vic.c index c2889da..8001994 100644 --- a/arch/arm/common/vic.c +++ b/arch/arm/common/vic.c @@ -421,9

[PATCH 3/6] ARM: s3c64xx: Add support for OF-based VIC initialization

2013-01-12 Thread Tomasz Figa
This patch modifies IRQ initialization code of S3C64xx to support Device Tree-based initialization of VICs. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- arch/arm/mach-s3c64xx/common.c | 16 arch/arm/mach-s3c64xx/common.h | 4 2 files changed, 20 insertions(+) diff

[PATCH 4/6] ARM: s3c64xx: Add board file for boot using Device Tree

2013-01-12 Thread Tomasz Figa
This patch adds board file that will be used to boot S3C64xx-based boards using Device Tree. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- arch/arm/mach-s3c64xx/Kconfig | 13 + arch/arm/mach-s3c64xx/Makefile | 1 + arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c | 84

[PATCH 5/6] ARM: dts: Add basic dts include files for Samsung S3C64xx SoCs

2013-01-12 Thread Tomasz Figa
This patch adds basic device tree definitions for Samsung S3C64xx SoCs. Since all the SoCs in the series are very similar, the files are created hierarchically - one file for the whole series and then separate files for particular SoCs including the common one. Signed-off-by: Tomasz Figa

<    1   2   3   4   5   6   7   8   9   10   >