[PATCH 32/69] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option

2015-12-18 Thread Daniel Lezcano
Let the platform's Kconfig to select the clock instead of having a reverse dependency from the driver to the platform options. Add the COMPILE_TEST option for the compilation test coverage. Due to the non portable 'delay' code, this driver is only compilable on ARM. Signed-off-by: Daniel Lezcano

Re: [PATCH 0/3] cpuidle: avoid module usage in non-modular code

2015-12-14 Thread Daniel Lezcano
-by: Daniel Lezcano <daniel.lezc...@linaro.org> -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/>

Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option

2015-11-03 Thread Daniel Lezcano
On 11/03/2015 01:59 AM, Krzysztof Kozlowski wrote: On 03.11.2015 09:30, Krzysztof Kozlowski wrote: On 02.11.2015 21:56, Daniel Lezcano wrote: Let the platform's Kconfig to select the clock instead of having a reverse dependency from the driver to the platform options. Selecting user-visible

Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option

2015-11-03 Thread Daniel Lezcano
On 11/03/2015 11:02 AM, Arnd Bergmann wrote: On Tuesday 03 November 2015 09:40:02 Daniel Lezcano wrote: On 11/03/2015 01:59 AM, Krzysztof Kozlowski wrote: On 03.11.2015 09:30, Krzysztof Kozlowski wrote: On 02.11.2015 21:56, Daniel Lezcano wrote: Let the platform's Kconfig to select the clock

Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option

2015-11-03 Thread Daniel Lezcano
On 11/03/2015 01:01 PM, Krzysztof Kozlowski wrote: Anyway the patch worked fine and with explanation I can only confirm: Great ! Thanks Krzysztof for testing. -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro:

[PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option

2015-11-02 Thread Daniel Lezcano
Let the platform's Kconfig to select the clock instead of having a reverse dependency from the driver to the platform options. Add the COMPILE_TEST option for the compilation test coverage. Due to the non portable 'delay' code, this driver is only compilable on ARM. Signed-off-by: Daniel Lezcano

[PATCH 6/9] clocksource/drivers/exynos_mct: Use container_of() instead of this_cpu_ptr()

2015-10-19 Thread Daniel Lezcano
9000c0ldr r0, [r0, #192] ; 0xc0 4ac: ebdbbl 420 4b0: e3a0mov r0, #0 4b4: e8bd8010pop {r4, pc} Also, for me size of exynos_mct.o decreased from 84588 bytes to 83956. Signed-off-by: Alexey Klimov <alexey.kli...@linaro.org> Signed-of

Re: [RFC PATCH] clocksource: exynos_mct: use container_of() instead of this_cpu_ptr()

2015-09-15 Thread Daniel Lezcano
On 09/04/2015 01:49 AM, Alexey Klimov wrote: Since evt structure is embedded in per-CPU mevt structure it's definitely faster to use container_of() to get access to mevt if we have evt (for example as incoming function argument) instead of more expensive approach with this_cpu_ptr(_mct_tick).

Re: CPUIdle for Exynos5422 Odroid-XU3/XU4 boards.

2015-08-20 Thread Daniel Lezcano
On 08/20/2015 08:15 PM, Anand Moon wrote: Hi Daniel, On 20 August 2015 at 21:40, Daniel Lezcano daniel.lezc...@free.fr wrote: On 08/20/2015 12:54 PM, Anand Moon wrote: Hello Krzysztof/Kukjim, CPUIdle seen to be not working for Exynos5422 Odroid boards. Is their any way this feature

Re: CPUIdle for Exynos5422 Odroid-XU3/XU4 boards.

2015-08-20 Thread Daniel Lezcano
On 08/20/2015 12:54 PM, Anand Moon wrote: Hello Krzysztof/Kukjim, CPUIdle seen to be not working for Exynos5422 Odroid boards. Is their any way this feature will be implemented in the future. Yeah a good willing to fix the bl1. More than one year asking for that ! nooo way !! Your answer

[PATCH 51/74] clockevents/drivers/exynos_mct: Migrate to new 'set-state' interface

2015-08-10 Thread Daniel Lezcano
: ONESHOT_STOPPED. Cc: Kukjin Kim kgene@samsung.com Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- drivers/clocksource/exynos_mct.c | 85 +++- 1 file changed, 40 insertions(+), 45 deletions(-) diff --git

[PATCH 08/74] clockevents/drivers/exynos_mct: Remove unneeded container_of()

2015-08-10 Thread Daniel Lezcano
klimov.li...@gmail.com Acked-by: Stephen Boyd sb...@codeaurora.org Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/clocksource/exynos_mct.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

Re: [RESEND PATCH v3] clocksource: exynos_mct: fix for sleeping in atomic ctx handling cpu hotplug notif.

2015-06-29 Thread Daniel Lezcano
On 06/29/2015 11:24 AM, Thomas Gleixner wrote: On Mon, 29 Jun 2015, Daniel Lezcano wrote: On 06/26/2015 03:23 PM, Damian Eppel wrote: This is to fix an issue of sleeping in atomic context when processing hotplug notifications in Exynos MCT(Multi-Core Timer). The issue was reproducible

Re: [RESEND PATCH v3] clocksource: exynos_mct: fix for sleeping in atomic ctx handling cpu hotplug notif.

2015-06-29 Thread Daniel Lezcano
On 06/26/2015 03:23 PM, Damian Eppel wrote: This is to fix an issue of sleeping in atomic context when processing hotplug notifications in Exynos MCT(Multi-Core Timer). The issue was reproducible on Exynos 3250 (Rinato board) and Exynos 5420 (Arndale Octa board). Whilst testing cpu hotplug

Re: [PATCH] clocksource: exynos_mct: remove unneeded container_of()

2015-06-29 Thread Daniel Lezcano
On 06/21/2015 10:41 PM, Alexey Klimov wrote: Patch removes unneeded container_of() macro in exynos4_local_timer_setup(). Instead let's pass mevt pointer to setup and stop functions from exynos4_mct_cpu_notify() and let them get evt pointer. Tested on odroid-xu3. Signed-off-by: Alexey Klimov

[PATCH 02/11] clocksource/drivers/exynos_mct: Change exynos4_mct_tick_clear return type to void

2015-06-02 Thread Daniel Lezcano
From: Krzysztof Kozlowski k.kozlow...@samsung.com Return value of exynos4_mct_tick_clear() was never checked so it can be safely changed to void. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- drivers/clocksource

[PATCH 04/11] clocksource/drivers/exynos_mct: Remove old platform mct_init()

2015-06-02 Thread Daniel Lezcano
From: Krzysztof Kozlowski k.kozlow...@samsung.com Since commit 228e3023eb04 (Merge tag 'mct-exynos-for-v3.10' of ...) the mct_init() was superseded by mct_init_dt() and is not referenced anywhere. Remove it. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Daniel Lezcano

[PATCH 03/11] clocksource/drivers/exynos_mct: Staticize struct clocksource

2015-06-02 Thread Daniel Lezcano
From: Krzysztof Kozlowski k.kozlow...@samsung.com The struct clocksource 'mct_frc' is not exported and used outside so make it static. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- drivers/clocksource/exynos_mct.c | 2

Re: [PATCH v2] clocksource: exynos_mct: fix for sleeping in atomic ctx handling cpu hotplug notif.

2015-05-27 Thread Daniel Lezcano
On 05/25/2015 05:24 PM, Damian Eppel wrote: On Mon, 2015-05-11 at 13:18 +0200, Daniel Lezcano wrote: [ ... ] The code sounds very complex for what it is supposed to do. Perhaps I am missing something but you have more or less the same functionality than the smp_twd timers and these ones

Re: PROBLEM: BUG appearing when trying to allocate interrupt on Exynos MCT after CPU hotplug

2015-01-31 Thread Daniel Lezcano
On 01/31/2015 02:08 AM, Stephen Boyd wrote: Kept meaning to get back to this thread. Have you resolved it? On 10/29/14 03:38, Marcin Jabrzyk wrote: So I've tried this patch, it resolves one problem but introduces also new ones. As expected the BUG warning is not showing after applying this

Re: [RESEND PATCH v3] clocksource: exynos_mct: Add the support for Exynos 64bit SoC

2015-01-14 Thread Daniel Lezcano
using MCT on 64bit exynos is usefulness for Power Management and I need to talk to relevant guys in office again. If anything, I'll let you know. I will wait for your answer before digging more the patch. Thanks -- Daniel Cc: Daniel Lezcano daniel.lezc...@linaro.org Cc: Thomas Gleixner t

Re: [PATCH] cpuidle: add MAINTAINERS entry for ARM Exynos cpuidle driver

2014-12-03 Thread Daniel Lezcano
/MAINTAINERS 2014-12-02 15:56:52.792997513 +0100 @@ -2701,6 +2701,16 @@ T: git git://git.kernel.org/pub/scm/linu S:Maintained F:drivers/cpuidle/cpuidle-big_little.c +CPUIDLE DRIVER - ARM EXYNOS +M: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com +M: Daniel Lezcano

Re: [PATCH] clocksource: exynos_mct: fix exynos4_mct_write

2014-12-02 Thread Daniel Lezcano
On 11/29/2014 11:18 PM, Kukjin Kim wrote: Tobias Jakobi wrote: EXYNOS4_MCT_L_MASK is defined as 0xff00, so applying this bitmask produces a number outside the range 0x00 to 0xff, which always results in execution of the default switch statement. Obviously this is wrong and git history

Re: [PATCH 2/2] cpuidle: exynos: add coupled cpuidle support for Exynos4210

2014-11-12 Thread Daniel Lezcano
On 11/12/2014 04:13 PM, Bartlomiej Zolnierkiewicz wrote: Hi Bartlomiej, [ cut ] - using arch_send_wakeup_ipi_mask() instead of dsb_sev() (this matches CPU hotplug code in arch/arm/mach-exynos/platsmp.c) I am curious. You experienced very rare hangs after running the tests a few

Re: [PATCH 2/2] cpuidle: exynos: add coupled cpuidle support for Exynos4210

2014-11-09 Thread Daniel Lezcano
based on earlier cpuidle-exynos4210 driver from Daniel Lezcano: http://www.spinics.net/lists/linux-samsung-soc/msg28134.html Changes from Daniel's code include: - porting code to current kernels - fixing it to work on my setup (by using S5P_INFORM register instead of S5P_VA_SYSRAM one on Revison

Re: [PATCH v3] ARM: dts: add CPU nodes for Exynos4 SoCs

2014-09-25 Thread Daniel Lezcano
On 09/25/2014 10:17 AM, Lorenzo Pieralisi wrote: [CC'ed Daniel to make him aware this patch goes through your tree] Thanks for the head up. I was about to send the PR to Rafael. [ ... ] That's great, now my Exynos CPUidle DT patch should be rebased on top of this patch so that thanks to the

Re: [PATCH v3] ARM: dts: add CPU nodes for Exynos4 SoCs

2014-09-25 Thread Daniel Lezcano
On 09/25/2014 11:36 AM, Lorenzo Pieralisi wrote: On Thu, Sep 25, 2014 at 10:02:05AM +0100, Daniel Lezcano wrote: On 09/25/2014 10:17 AM, Lorenzo Pieralisi wrote: [CC'ed Daniel to make him aware this patch goes through your tree] Thanks for the head up. I was about to send the PR to Rafael

Re: [PATCH] Exynos4: cpuidle: support dual CPUs with AFTR state

2014-08-14 Thread Daniel Lezcano
On 08/14/2014 12:55 PM, Bartlomiej Zolnierkiewicz wrote: Hi, On Monday, July 21, 2014 01:06:32 PM Daniel Lezcano wrote: On 07/16/2014 07:34 PM, Bartlomiej Zolnierkiewicz wrote: Hi, On Friday, May 30, 2014 03:53:09 PM Bartlomiej Zolnierkiewicz wrote: Hi, On Friday, May 30, 2014 01:34:45

Re: [PATCH v2 1/3] ARM: EXYNOS: Fix build with PM_SLEEP=n and ARM_EXYNOS_CPUIDLE=n

2014-08-12 Thread Daniel Lezcano
On 08/12/2014 05:11 PM, Bartlomiej Zolnierkiewicz wrote: Fix building of exynos_defconfig with disabled CONFIG_PM_SLEEP by adding checking whether Exynos cpuidle support is enabled before accessing exynos_enter_aftr. The build error message: arch/arm/mach-exynos/built-in.o:(.data+0x74):

Re: [PATCH v3 0/4] ARM: EXYNOS: cpuidle: fix AFTR mode on boards with secure firmware enabled

2014-08-05 Thread Daniel Lezcano
On 08/05/2014 02:04 PM, Bartlomiej Zolnierkiewicz wrote: Hi Daniel, On Monday, July 28, 2014 09:43:02 AM Daniel Lezcano wrote: On 07/09/2014 07:17 PM, Bartlomiej Zolnierkiewicz wrote: Hi, This patch series adds support for AFTR idle mode on boards with secure firmware enabled and allows

Re: [PATCH v5 0/5] ARM: EXYNOS: cpuidle: fix AFTR mode on boards with secure firmware enabled

2014-08-05 Thread Daniel Lezcano
] Firmware-assisted suspend/resume of Exynos SoCs (http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg32991.html) [with rejects fixed in patch #2] - addressed review comments from Tomasz Figa and Daniel Lezcano Changes since v1: - synced against next-20140602 - added missing Acked

Re: [PATCH v5 0/5] ARM: EXYNOS: cpuidle: fix AFTR mode on boards with secure firmware enabled

2014-08-05 Thread Daniel Lezcano
://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg32991.html) [with rejects fixed in patch #2] - addressed review comments from Tomasz Figa and Daniel Lezcano Changes since v1: - synced against next-20140602 - added missing Acked-by-s Best regards, -- Bartlomiej Zolnierkiewicz

Re: [PATCH v5 1/3] ARM: EXYNOS: Move code from hotplug.c to platsmp.c

2014-08-05 Thread Daniel Lezcano
On 08/05/2014 12:43 PM, Krzysztof Kozlowski wrote: Cleanup a little the SMP/hotplug code for Exynos by: 1. Moving completely all functions from hotplug.c into the platsmp.c; 2. Deleting the hotplug.c file. After recent cleanups (e.g. 75ad2ab28f0f ARM: EXYNOS: use v7_exit_coherency_flush macro

Re: [PATCH v5 0/5] ARM: EXYNOS: cpuidle: fix AFTR mode on boards with secure firmware enabled

2014-08-05 Thread Daniel Lezcano
On 08/05/2014 04:26 PM, Krzysztof Kozlowski wrote: On 05.08.2014 16:03, Daniel Lezcano wrote: On 08/05/2014 03:34 PM, Bartlomiej Zolnierkiewicz wrote: Hi, This patch series adds support for AFTR idle mode on boards with secure firmware enabled and allows EXYNOS cpuidle driver usage

Re: [PATCH v3 0/4] ARM: EXYNOS: cpuidle: fix AFTR mode on boards with secure firmware enabled

2014-07-30 Thread Daniel Lezcano
/linux-samsung-soc@vger.kernel.org/msg32991.html (with rejects fixed in patch #2) - addressed review comments from Tomasz Figa and Daniel Lezcano Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics Bartlomiej Zolnierkiewicz (4): ARM: EXYNOS: PM: replace

Re: [PATCH v3 0/4] ARM: EXYNOS: cpuidle: fix AFTR mode on boards with secure firmware enabled

2014-07-28 Thread Daniel Lezcano
(with rejects fixed in patch #2) - addressed review comments from Tomasz Figa and Daniel Lezcano Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics Bartlomiej Zolnierkiewicz (4): ARM: EXYNOS: PM: replace EXYNOS_BOOT_VECTOR_* macros by static inlines ARM

Re: [GIT PULL 4/5] Samsung exynos_mct update for v3.17

2014-07-23 Thread Daniel Lezcano
On 07/23/2014 01:33 AM, Kukjin Kim wrote: On 07/23/14 02:32, Daniel Lezcano wrote: On 07/22/2014 12:59 PM, Kukjin Kim wrote: Daniel Lezcano wrote: On 07/20/2014 12:06 AM, Olof Johansson wrote: On Sat, Jul 19, 2014 at 09:52:52AM +0900, Kukjin Kim wrote: Note that this is also based on 3.16

Re: [GIT PULL 4/5] Samsung exynos_mct update for v3.17

2014-07-22 Thread Daniel Lezcano
On 07/22/2014 12:59 PM, Kukjin Kim wrote: Daniel Lezcano wrote: On 07/20/2014 12:06 AM, Olof Johansson wrote: On Sat, Jul 19, 2014 at 09:52:52AM +0900, Kukjin Kim wrote: Note that this is also based on 3.16-rc5 because of dependency with previous samsung fixes including exynos_mct already

Re: [GIT PULL 4/5] Samsung exynos_mct update for v3.17

2014-07-21 Thread Daniel Lezcano
on exynos 64-bit system instead of current MCT. - use readl_relaxed/writel_relaxed to consistently use the proper functions in exynos_mct. There's no reason for these to go through arm-soc, is there? They should go through the clocksource tree (Daniel Lezcano / Thomas Gleixner). They also lack

Re: [PATCH 1/3] cpuidle: exynos: Allow to use the driver without AFTR

2014-07-21 Thread Daniel Lezcano
On 07/21/2014 10:36 AM, Krzysztof Kozlowski wrote: Allow the driver to be used when AFTR enter function is not provided (device platform data is NULL). This actually does not give any special energy-saving benefits but allows to track the idle time of each core. Additionally it is a safe way to

Re: [PATCH] Exynos4: cpuidle: support dual CPUs with AFTR state

2014-07-21 Thread Daniel Lezcano
On 07/16/2014 07:34 PM, Bartlomiej Zolnierkiewicz wrote: Hi, On Friday, May 30, 2014 03:53:09 PM Bartlomiej Zolnierkiewicz wrote: Hi, On Friday, May 30, 2014 01:34:45 PM Tomasz Figa wrote: Hi Daniel, On 30.05.2014 11:30, Daniel Lezcano wrote: On 04/24/2014 07:42 PM, Tomasz Figa wrote

Re: [PATCH] cpuidle: big.LITTLE: add MCPM dependency

2014-07-14 Thread Daniel Lezcano
' This adds an explicit dependency to CONFIG_MCPM to avoid that case. Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Chander Kashyap chander.kash...@linaro.org Cc: Tomasz Figa t.f...@samsung.com Cc: Daniel Lezcano daniel.lezc...@linaro.org --- I believe the broken commit is only present in the samsung

Re: Enabling 8 cores on 5420

2014-06-23 Thread Daniel Lezcano
Is there something I missed ? Thanks ! -- Daniel On Mon, Jun 23, 2014 at 2:32 AM, Andreas Färber afaer...@suse.de wrote: Am 30.05.2014 11:25, schrieb Daniel Lezcano: Hi all, I am trying an upstream kernel + some patches to enable ethernet on arndale octa. Unfortunately, only 4 cores boot up. The other

Re: [PATCH v2] clocksource: exynos_mct: Fix ftrace

2014-06-20 Thread Daniel Lezcano
On 06/19/2014 07:08 PM, Doug Anderson wrote: In (93bfb76 clocksource: exynos_mct: register sched_clock callback) we supported using the MCT as a scheduler clock. Hi Thomas, is it possible you update the tip/timers/core so I can get visibility on the above patch to apply this one ? Thanks

Re: [PATCH] clocksource: exynos-mct: Register the timer for stable udelay

2014-06-19 Thread Daniel Lezcano
On 06/19/2014 01:17 AM, Doug Anderson wrote: Amit, Thanks for posting! On Wed, Jun 18, 2014 at 4:31 AM, Amit Daniel Kachhap amit.dan...@samsung.com wrote: This patch register the exynos mct clocksource as the current timer as it has constant clock rate. This will generate correct udelay for

Re: [PATCH v2] clocksource: exynos-mct: Register the timer for stable udelay

2014-06-19 Thread Daniel Lezcano
On 06/19/2014 10:39 AM, Amit Daniel Kachhap wrote: This patch register the exynos mct clocksource as the current timer as it has constant clock rate. This will generate correct udelay for the exynos platform and avoid using unnecessary calibrated jiffies. This change has been tested on

Re: [PATCH v2] clocksource: exynos-mct: Register the timer for stable udelay

2014-06-19 Thread Daniel Lezcano
On 06/19/2014 12:21 PM, amit daniel kachhap wrote: On Thu, Jun 19, 2014 at 2:41 PM, Daniel Lezcano daniel.lezc...@linaro.org wrote: On 06/19/2014 10:39 AM, Amit Daniel Kachhap wrote: This patch register the exynos mct clocksource as the current timer as it has constant clock rate

Re: [PATCH] clocksource: exynos-mct: Register the timer for stable udelay

2014-06-19 Thread Daniel Lezcano
On 06/19/2014 05:49 PM, Doug Anderson wrote: Daniel, On Thu, Jun 19, 2014 at 2:07 AM, Daniel Lezcano daniel.lezc...@linaro.org wrote: On 06/19/2014 01:17 AM, Doug Anderson wrote: Amit, Thanks for posting! On Wed, Jun 18, 2014 at 4:31 AM, Amit Daniel Kachhap amit.dan...@samsung.com wrote

Re: [PATCH 1/3] clocksource: exynos_mct: Fix ftrace

2014-06-17 Thread Daniel Lezcano
On 06/04/2014 07:30 PM, Doug Anderson wrote: In (93bfb76 clocksource: exynos_mct: register sched_clock callback) we supported using the MCT as a scheduler clock. We properly marked exynos4_read_sched_clock() as notrace. However, we then went and called another function that _wasn't_ notrace.

Re: [PATCH 1/3] clocksource: exynos_mct: Fix ftrace

2014-06-16 Thread Daniel Lezcano
On 06/16/2014 06:40 AM, Doug Anderson wrote: Daniel, On Sun, Jun 15, 2014 at 2:18 PM, Daniel Lezcano daniel.lezc...@linaro.org wrote: On 06/04/2014 07:30 PM, Doug Anderson wrote: In (93bfb76 clocksource: exynos_mct: register sched_clock callback) we supported using the MCT as a scheduler

Re: [PATCH 1/3] clocksource: exynos_mct: Fix ftrace

2014-06-15 Thread Daniel Lezcano
On 06/04/2014 07:30 PM, Doug Anderson wrote: In (93bfb76 clocksource: exynos_mct: register sched_clock callback) we supported using the MCT as a scheduler clock. We properly marked exynos4_read_sched_clock() as notrace. However, we then went and called another function that _wasn't_ notrace.

Re: [PATCH] Exynos4: cpuidle: support dual CPUs with AFTR state

2014-06-13 Thread Daniel Lezcano
On 06/11/2014 10:50 AM, Krzysztof Kozlowski wrote: On pią, 2014-04-04 at 11:48 +0200, Daniel Lezcano wrote: The following driver is for exynos4210. I did not yet finished the other boards, so I created a specific driver for 4210 which could be merged later. The driver is based on Colin

Re: [PATCH 6/7] ARM: EXYNOS: PM: fix register setup on EXYNOS4x12 for AFTR mode code

2014-06-02 Thread Daniel Lezcano
On 06/02/2014 02:08 PM, Bartlomiej Zolnierkiewicz wrote: Hi, On Friday, May 16, 2014 11:03:11 AM Daniel Lezcano wrote: On 05/05/2014 12:57 PM, Bartlomiej Zolnierkiewicz wrote: Add S5P_CENTRAL_SEQ_OPTION register setup for EXYNOS4x12 to AFTR mode code. Without this setup AFTR mode doesn't

Re: [PATCH v2 4/7] ARM: EXYNOS: PM: replace EXYNOS_BOOT_VECTOR_* macros by static inlines

2014-06-02 Thread Daniel Lezcano
b.zolnier...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-exynos/pm.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/arch/arm/mach-exynos/pm.c b/arch/arm

Re: [PATCH v2 7/7] ARM: EXYNOS: cpuidle: add secure firmware support to AFTR mode code

2014-06-02 Thread Daniel Lezcano
On 06/02/2014 02:35 PM, Bartlomiej Zolnierkiewicz wrote: * Use do_idle firmware method instead of cpu_do_idle() on boards with secure firmware enabled. * Use sysram_ns_base_addr + 0x24 address for exynos_boot_vector_addr() and sysram_ns_base_addr + 0x20 one for exynos_boot_vector_flag()

Enabling 8 cores on 5420

2014-05-30 Thread Daniel Lezcano
Hi all, I am trying an upstream kernel + some patches to enable ethernet on arndale octa. Unfortunately, only 4 cores boot up. The other ones fail to boot. [12.179453] CPU6: failed to come online [13.189479] CPU7: failed to come online [14.199479] CPU4: failed to come online [15.209743]

Re: [PATCH] Exynos4: cpuidle: support dual CPUs with AFTR state

2014-05-30 Thread Daniel Lezcano
On 04/24/2014 07:42 PM, Tomasz Figa wrote: Hi Daniel, Please see my comments inline. Btw. Please fix your e-mail composer to properly wrap your messages around 7xth column, as otherwise they're hard to read. On 04.04.2014 11:48, Daniel Lezcano wrote: The following driver is for exynos4210. I

Re: Enabling 8 cores on 5420

2014-05-30 Thread Daniel Lezcano
On 05/30/2014 03:33 PM, Andreas Färber wrote: Hi, Am 30.05.2014 11:25, schrieb Daniel Lezcano: I am trying an upstream kernel + some patches to enable ethernet on arndale octa. Unfortunately, only 4 cores boot up. The other ones fail to boot. [12.179453] CPU6: failed to come online

Re: [PATCH v6 1/6] driver: cpuidle-big-little: add of_device_id structure

2014-05-28 Thread Daniel Lezcano
the compatible strings of SoC's using this driver. Signed-off-by: Chander Kashyap chander.kash...@linaro.org Signed-off-by: Chander Kashyap k.chan...@samsung.com Acked-by: Daniel Lezcano daniel.lezc...@linaro.org --- drivers/cpuidle/cpuidle-big_little.c | 11 ++- 1 file changed

Re: [PATCH v6 0/6] add cpuidle support for Exynos5420

2014-05-28 Thread Daniel Lezcano
On 05/28/2014 06:35 AM, Kukjin Kim wrote: Chander Kashyap wrote: On 26 May 2014 15:59, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Chander, On 16.05.2014 10:03, Chander Kashyap wrote: Exynos5420 is a big-little Soc from Samsung. It has 4 A15 and 4 A7 cores. This patchset adds cpuidle

Re: [PATCH v6 3/6] cpuidle: config: Add ARCH_EXYNOS entry to select cpuidle-big-little driver

2014-05-28 Thread Daniel Lezcano
...@samsung.com Acked-by: Daniel Lezcano daniel.lezc...@linaro.org --- Changes in v4: 1. Typo fixed from SOC_EXYNOS5420 to ARCH_EXYNOS 2. Commit message updated Changes in v3: None Changes in v2: 1. Changed config macro from SOC_EXYNOS5420 to ARCH_EXYNOS drivers/cpuidle

[PATCH] ARM: exynos: Fix kernel panic when unplugging CPU1 on 4210

2014-05-24 Thread Daniel Lezcano
sysram_base_addr non-static, declared it in common.h and used in pm.c instead of S5P_VA_SYSRAM. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Suggested-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/common.h |1 + arch/arm/mach-exynos/platsmp.c |2 +- arch/arm/mach-exynos/pm.c

Re: [PATCH] ARM: exynos: Fix kernel panic when unplugging CPU1 on 4210

2014-05-24 Thread Daniel Lezcano
On 05/24/2014 07:24 PM, Daniel Lezcano wrote: A look at the code reveals use of S5P_VA_SYSRAM macro, in case of certain SoC revisions, which is not valid any longer, after SYSRAM started to be mapped dynamically. The new dynamic mapping is stored in sysram_base_addr variable, which is declared

Re: [PATCH V5 00/20] ARM: exynos: cpuidle: Move the driver to drivers/cpuidle

2014-05-23 Thread Daniel Lezcano
On 05/22/2014 08:35 PM, Kukjin Kim wrote: On 04/26/14 20:05, Kukjin Kim wrote: Tomasz Figa wrote: On 14.04.2014 11:01, Daniel Lezcano wrote: Hi Kukjin, I believe I addressed all the comments. Is it possible to take this patchset for next ? Sure ;-) +1. Also when applying you might

Re: [PATCH V5 00/20] ARM: exynos: cpuidle: Move the driver to drivers/cpuidle

2014-05-22 Thread Daniel Lezcano
On 05/22/2014 08:35 PM, Kukjin Kim wrote: On 04/26/14 20:05, Kukjin Kim wrote: Tomasz Figa wrote: On 14.04.2014 11:01, Daniel Lezcano wrote: Hi Kukjin, I believe I addressed all the comments. Is it possible to take this patchset for next ? Sure ;-) +1. Also when applying you might

Re: [PATCH V5 18/20] ARM: exynos: cpuidle: Pass the AFTR callback to the platform_data

2014-05-21 Thread Daniel Lezcano
On 05/15/2014 10:40 PM, Kukjin Kim wrote: [ ... ] Exynos cpuidle is not a device on the SoC, so I don't think there is any way to represent it in DT. The only thing I could see this is matching root node with a central SoC driver that instantiates specific subdevices, such as cpufreq and

Re: [PATCH V5 18/20] ARM: exynos: cpuidle: Pass the AFTR callback to the platform_data

2014-05-21 Thread Daniel Lezcano
On 05/21/2014 10:10 AM, Arnd Bergmann wrote: On Wednesday 21 May 2014 09:15:34 Daniel Lezcano wrote: On 05/15/2014 10:40 PM, Kukjin Kim wrote: [ ... ] Exynos cpuidle is not a device on the SoC, so I don't think there is any way to represent it in DT. The only thing I could see

Re: [PATCH 4/7] ARM: EXYNOS: PM: replace EXYNOS_BOOT_VECTOR_* macros by static inlines

2014-05-16 Thread Daniel Lezcano
b.zolnier...@samsung.com Acked-by: Daniel Lezcano daniel.lezc...@linaro.org -- http://www.linaro.org/ Linaro.org │ Open source software for ARM SoCs Follow Linaro: http://www.facebook.com/pages/Linaro Facebook | http://twitter.com/#!/linaroorg Twitter | http://www.linaro.org/linaro-blog/ Blog

Re: [PATCH 6/7] ARM: EXYNOS: PM: fix register setup on EXYNOS4x12 for AFTR mode code

2014-05-16 Thread Daniel Lezcano
On 05/05/2014 12:57 PM, Bartlomiej Zolnierkiewicz wrote: Add S5P_CENTRAL_SEQ_OPTION register setup for EXYNOS4x12 to AFTR mode code. Without this setup AFTR mode doesn't show any benefit over WFI one. When this setup is applied AFTR mode reduces power consumption by ~12% (as measured on Trats2

Re: [PATCH v5 0/6] add cpuidle support for Exynos5420

2014-05-14 Thread Daniel Lezcano
On 05/14/2014 10:03 AM, Chander Kashyap wrote: Exynos5420 is a big-little Soc from Samsung. It has 4 A15 and 4 A7 cores. This patchset adds cpuidle support for Exynos5420 SoC based on generic big.little cpuidle driver. Hi Chander, just a side question. I am not succeeding to have both

Re: [PATCH V5 18/20] ARM: exynos: cpuidle: Pass the AFTR callback to the platform_data

2014-05-12 Thread Daniel Lezcano
On 05/09/2014 02:02 PM, Tomasz Figa wrote: Hi Arnd, On 09.05.2014 12:56, Arnd Bergmann wrote: On Friday 11 April 2014, Daniel Lezcano wrote: No more dependency on the arch code. The platform_data field is used to set the PM callback as the other cpuidle drivers. Signed-off-by: Daniel Lezcano

Re: [PATCH] ARM: exynos: register sched_clock callback

2014-05-02 Thread Daniel Lezcano
On 04/24/2014 11:21 AM, Vincent Guittot wrote: Use the clocksource mct-frc for sched_clock Signed-off-by: Vincent Guittot vincent.guit...@linaro.org Acked-by: Daniel Lezcano daniel.lezc...@linaro.org [ ... ] -- http://www.linaro.org/ Linaro.org │ Open source software for ARM SoCs Follow

Re: [PATCH] Exynos4: cpuidle: support dual CPUs with AFTR state

2014-04-25 Thread Daniel Lezcano
, Daniel Lezcano wrote: The following driver is for exynos4210. I did not yet finished the other boards, so I created a specific driver for 4210 which could be merged later. The driver is based on Colin Cross's driver found at: https://android.googlesource.com/kernel/exynos

Re: [PATCH 0/2] Add generic cpu power control functions for exynos

2014-04-24 Thread Daniel Lezcano
Hi Abhilash and Leela, FYI I think you are working on similar patches. On 04/24/2014 11:31 AM, Leela Krishna Amudala wrote: This patchset adds the generic cpu power control functions for exynos based SoCs to power up/down and to know the status of the cpu. Note: This series has been rebased

Re: [PATCH 3/4] exynos: cpuidle: do not allow cpuidle registration for Exynos5420

2014-04-22 Thread Daniel Lezcano
...@samsung.com --- Acked-by: Daniel Lezcano daniel.lezc...@linaro.org but will conflict with: http://www.spinics.net/lists/arm-kernel/msg319862.html arch/arm/mach-exynos/cpuidle.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos

Re: [PATCH 2/4] driver: cpuidle: cpuidle-big-little: init driver for Exynos5420

2014-04-22 Thread Daniel Lezcano
to platform_driver but until that: Acked-by: Daniel Lezcano daniel.lezc...@linaro.org drivers/cpuidle/cpuidle-big_little.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c index b45fc62..d0fac53 100644

Re: [PATCH 1/4] cpuidle: config: Add SOC_EXYNOS5420 entry to select cpuidle-big-little driver

2014-04-22 Thread Daniel Lezcano
On 04/21/2014 01:49 PM, Chander Kashyap wrote: Exynos5420 is a big-little SoC from Samsung. It has 4 A15 and 4 A7 cores. In order to use generic cpuidle-big-little driver, this patch adds Exynos5420 specific check to initialize generic cpuidle driver. Signed-off-by: Chander Kashyap

Re: [PATCH 4/4] mcpm: exynos: populate suspend and powered_up callbacks

2014-04-22 Thread Daniel Lezcano
On 04/21/2014 01:49 PM, Chander Kashyap wrote: In order to support cpuidle through mcpm, suspend and powered-up callbacks are required in mcpm platform code. Hence populate the same callbacks. Signed-off-by: Chander Kashyap chander.kash...@linaro.org Signed-off-by: Chander Kashyap

Re: [PATCH 2/4] driver: cpuidle: cpuidle-big-little: init driver for Exynos5420

2014-04-22 Thread Daniel Lezcano
On 04/21/2014 01:49 PM, Chander Kashyap wrote: Add samsung,exynos5420 compatible string to initialize generic big-little cpuidle driver for Exynos5420. Signed-off-by: Chander Kashyap chander.kash...@linaro.org Signed-off-by: Chander Kashyap k.chan...@samsung.org ---

Re: [PATCH] ARM: EXYNOS: cpu hotplug: use v7_exit_coherency_flush macro for cache disabling

2014-04-22 Thread Daniel Lezcano
On 04/22/2014 04:18 PM, Leela Krishna Amudala wrote: Remove the duplicated code for cache disabling and use v7_exit_coherency_flush macro to do the same job. Hi Leela, thanks for this patch! It would be nice if you can describe why those macros can be replaced by the generic

Re: [PATCH 1/3] clocksource: exynos_mct: Fix stall after CPU hotplugging

2014-04-15 Thread Daniel Lezcano
On 04/15/2014 11:34 AM, Krzysztof Kozlowski wrote: On pią, 2014-03-28 at 14:06 +0100, Krzysztof Kozlowski wrote: Fix stall after hotplugging CPU1. Affected are SoCs where Multi Core Timer interrupts are shared (SPI), e.g. Exynos 4210. The stall was a result of starting the CPU1 local timer not

Re: [PATCH] Exynos4: cpuidle: support dual CPUs with AFTR state

2014-04-15 Thread Daniel Lezcano
headers. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-exynos/common.c| 11 +- drivers/cpuidle/Kconfig.arm |8 ++ drivers/cpuidle/Makefile |1 + drivers/cpuidle/cpuidle-exynos4210.c | 226 ++ 4 files

Re: [PATCH] Exynos4: cpuidle: support dual CPUs with AFTR state

2014-04-15 Thread Daniel Lezcano
time than the one when we have to unplug CPU1 in order to let CPU0 to reach the AFTR state. This patch is a RFC because, we have to find a way to remove the macros definitions and cpu powerdown function without pulling the arch dependent headers. Signed-off-by: Daniel Lezcano daniel.lezc

Re: [PATCH V5 00/20] ARM: exynos: cpuidle: Move the driver to drivers/cpuidle

2014-04-14 Thread Daniel Lezcano
Hi Kukjin, I believe I addressed all the comments. Is it possible to take this patchset for next ? Regards -- Daniel On 04/11/2014 12:39 PM, Daniel Lezcano wrote: Changelog: V5: * Removed patch : Move clock setup to pm.c * Added patch : Move arm core power down

Re: [PATCH V4 10/20] ARM: exynos: cpuidle: Move clock setup to pm.c

2014-04-11 Thread Daniel Lezcano
On 04/10/2014 05:34 PM, Tomasz Figa wrote: On 10.04.2014 16:23, Daniel Lezcano wrote: On 04/10/2014 03:57 PM, Tomasz Figa wrote: Hi Daniel, On 10.04.2014 11:55, Daniel Lezcano wrote: One more step is moving the clock ratio setting at idle time in pm.c The macro names have been changed

Re: [PATCH V4 10/20] ARM: exynos: cpuidle: Move clock setup to pm.c

2014-04-11 Thread Daniel Lezcano
On 04/11/2014 10:49 AM, Tomasz Figa wrote: On 11.04.2014 10:30, Daniel Lezcano wrote: On 04/10/2014 05:34 PM, Tomasz Figa wrote: On 10.04.2014 16:23, Daniel Lezcano wrote: On 04/10/2014 03:57 PM, Tomasz Figa wrote: Hi Daniel, On 10.04.2014 11:55, Daniel Lezcano wrote: One more step

[PATCH V5 17/20] ARM: exynos: cpuidle: Move S5P_CHECK_SLEEP into pm.c

2014-04-11 Thread Daniel Lezcano
This macro is only used there. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-exynos/pm.c |3 ++- arch/arm/mach-exynos/regs-pmu.h |2 -- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-exynos/pm.c b/arch/arm/mach-exynos/pm.c

[PATCH V5 15/20] ARM: exynos: cpuidle: Move the AFTR state function into pm.c

2014-04-11 Thread Daniel Lezcano
In order to remove depedency on pm code, let's move the 'exynos_enter_aftr' function into the pm.c file as well as the other helper functions. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-exynos/common.h |1 + arch/arm/mach-exynos/cpuidle.c | 29

[PATCH V5 09/20] ARM: exynos: cpuidle: Move scu_enable in the cpu_pm notifier

2014-04-11 Thread Daniel Lezcano
We make the cpuidle code less arch dependent. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Viresh Kumar viresh.ku...@linaro.org Reviewed-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/cpuidle.c

[PATCH V5 12/20] ARM: exynos: cpuidle: Encapsulate boot vector code into a function

2014-04-11 Thread Daniel Lezcano
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-exynos/cpuidle.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c index 169db74..f66ee4d 100644 --- a/arch/arm/mach-exynos

[PATCH V5 13/20] ARM: exynos: cpuidle: Disable cpuidle for 5440

2014-04-11 Thread Daniel Lezcano
drawback is the statistic via sysfs on this state which is lost but it is meaningless and it could be retrieved from the ftrace easily. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Tomasz Figa t.f...@samsung.com Acked-by: Amit Kucheria amit.kuche...@linaro.org --- arch/arm/mach

[PATCH V5 20/20] ARM: exynos: cpuidle: Move the driver to drivers/cpuidle directory

2014-04-11 Thread Daniel Lezcano
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Viresh Kumar viresh.ku...@linaro.org Reviewed-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/Makefile |1 - drivers/cpuidle

[PATCH V5 08/20] ARM: exynos: cpuidle: Use the cpu_pm notifier

2014-04-11 Thread Daniel Lezcano
Use the cpu_pm_enter/exit notifier to group some pm code inside the pm file. The save and restore code is duplicated across pm.c and cpuidle.c. By using the cpu_pm notifier, we can factor out the routine. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Viresh Kumar viresh.ku

[PATCH V5 10/20] ARM: exynos: cpuidle: Remove ifdef for scu_enable

2014-04-11 Thread Daniel Lezcano
The scu_enable function is already a noop in the scu's header file is CONFIG_SMP=n, so no need to use these macros in the code. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Viresh Kumar viresh.ku...@linaro.org Reviewed-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com

[PATCH V5 06/20] ARM: exynos: cpuidle: Move some code inside the idle_finisher

2014-04-11 Thread Daniel Lezcano
Move the code around to differentiate different section of code and prepare it to be factored out in the next patches. The call order changed but hat doesn't have a side effect because they are independent. The important call is cpu_do_idle() which must be done the last. Signed-off-by: Daniel

[PATCH V5 19/20] ARM: exynos: cpuidle: Cleanup all unneeded headers from cpuidle.c

2014-04-11 Thread Daniel Lezcano
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-exynos/cpuidle.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c index 1d1222e..1d09ebd 100644 --- a/arch/arm/mach-exynos/cpuidle.c +++ b/arch

[PATCH V5 16/20] ARM: exynos: cpuidle: Move the power sequence call in the cpu_pm notifier

2014-04-11 Thread Daniel Lezcano
The code to initiate and exit the powerdown sequence is the same in pm.c and cpuidle.c. Let's split the common part in the pm.c and reuse it from the cpu_pm notifier. That is one more step forward to make the cpuidle driver arch indenpendant. Signed-off-by: Daniel Lezcano daniel.lezc

[PATCH V5 07/20] ARM: exynos: cpuidle: Fix S5P_WAKEUP_STAT call

2014-04-11 Thread Daniel Lezcano
This function should be called only when the powerdown sequence fails. Even if the current code does not hurt, by moving this line, we have the same code than the one in pm.c. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Viresh Kumar viresh.ku...@linaro.org Reviewed

[PATCH V5 14/20] ARM: exynos: cpuidle: Encapsulate the AFTR code into a function

2014-04-11 Thread Daniel Lezcano
Let's encapsulate the AFTR state specific call into a single function. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-exynos/cpuidle.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos

[PATCH V5 11/20] ARM: exynos: cpuidle: Pass wakeup mask parameter to function

2014-04-11 Thread Daniel Lezcano
Pass the wakeup mask to 'exynos_set_wakeupmask' as this function could be used for different idle states with different mask. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-exynos/cpuidle.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

  1   2   3   >