Re: [PATCH] ARM: dts: remove display power domain for exynos5420

2014-07-14 Thread Rahul Sharma
Hi Kukjin, Please consider this patch for your branch. This patch is important for Display for Exynos5 boards. Regards, Rahul Sharma. On 9 July 2014 17:00, Rahul Sharma rahul.sha...@samsung.com wrote: Hi Tomasz, On 8 July 2014 21:04, Tomasz Figa t.f...@samsung.com wrote: Hi Rahul

Re: [PATCH] ARM: dts: remove display power domain for exynos5420

2014-07-09 Thread Rahul Sharma
Hi Tomasz, On 8 July 2014 21:04, Tomasz Figa t.f...@samsung.com wrote: Hi Rahul, On 07.07.2014 15:37, Rahul Sharma wrote: Hi Andrej, Inki, On 18 June 2014 12:06, Rahul Sharma rahul.sha...@samsung.com wrote: Hi Andrej, On 18 June 2014 11:46, Andrzej Hajda a.ha...@samsung.com wrote: On 06

Re: [RFC] drm/exynos: abort commit when framebuffer is removed from plane

2014-07-08 Thread Rahul Sharma
Hi Inki, What do you think about the following fix? I need your inputs for this. Regards, Rahul Sharma On 19 June 2014 20:43, Rahul Sharma rahul.sha...@samsung.com wrote: This situation arises when userspace remove the frambuffer object and call setmode ioctl. drm_mode_rmfb

Re: [PATCH] ARM: dts: remove display power domain for exynos5420

2014-07-07 Thread Rahul Sharma
Hi Andrej, Inki, On 18 June 2014 12:06, Rahul Sharma rahul.sha...@samsung.com wrote: Hi Andrej, On 18 June 2014 11:46, Andrzej Hajda a.ha...@samsung.com wrote: On 06/17/2014 07:49 AM, Rahul Sharma wrote: Hi All, Please review this patch. Regards, Rahul Sharma On 9 June 2014 16:58

Re: [PATCH 1/3] drm/exynos: Control DISP1BLK system register in FIMD

2014-06-26 Thread Rahul Sharma
, + .sysreg_disp1blk_offset = 0x210, offset should be defined as Macros in reg file. }; static struct fimd_driver_data exynos5_fimd_driver_data = { .timing_base = 0x2, .has_shadowcon = 1, + .sysreg_disp1blk_offset = 0x214, }; Same as above. Rest looks fine to me. Regards, Rahul

Re: [PATCH] ARM: dts: add hdmi regulators for exynos5800 based peach-pi board

2014-06-26 Thread Rahul Sharma
On 26 June 2014 13:11, Javier Martinez Canillas jav...@dowhile0.org wrote: Hello Rahul, On Thu, Jun 26, 2014 at 7:26 AM, Rahul Sharma rahul.sha...@samsung.com wrote: Adding regulators for HDMI for exynos5800 based Peach-pi board. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com

[PATCH v2] ARM: dts: add hdmi regulators for exynos5800 based peach-pi board

2014-06-26 Thread Rahul Sharma
Adding regulators for HDMI for Peach-pi board. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- v2: 1) Add blank line before hdmi regulators. Based on Kukjin's for-next branch. Depends on: 1) PMIC addition to Peach-pi

Re: [PATCH 3/5 v2] drm/exynos: allow mulitple layer updates per vsync for mixer

2014-06-25 Thread Rahul Sharma
Thanks Inki, One more thing. mixer_layer_update is only called on for mixer version; MXR_VER_16_0_33_0, MXR_VER_128_0_0_184. This condition should have taken care of Exynos4 scenarios. What you say? Regards, Rahul Sharma. On 24 June 2014 20:20, Inki Dae inki@samsung.com wrote: 2014-06-24

Re: [PATCH] clk/exynos5250: fix bit number for tv sysmmu clock

2014-06-25 Thread Rahul Sharma
Hi Kukjin, Please take this fix in your tree. Regards, Rahul Sharma On 19 June 2014 11:35, Sachin Kamat sachin.ka...@samsung.com wrote: On Thu, Jun 19, 2014 at 11:17 AM, Rahul Sharma rahul.sha...@samsung.com wrote: Change bit from 2 to 9 for tv (mixer) sysmmu clock. Signed-off-by: Rahul

Re: [PATCH] clk/exynos5250: fix bit number for tv sysmmu clock

2014-06-25 Thread Rahul Sharma
Sure Tomasz, Kukjin. Thanks for the update. Regards. On 25 June 2014 16:56, Kukjin Kim kgene@samsung.com wrote: Tomasz Figa wrote: Hi Rahul, On 25.06.2014 13:22, Rahul Sharma wrote: Hi Kukjin, Please take this fix in your tree. This is a patch for Samsung clock drivers, so I'll

[PATCH] ARM: dts: add hdmi regulators for exynos5800 based peach-pi board

2014-06-25 Thread Rahul Sharma
Adding regulators for HDMI for exynos5800 based Peach-pi board. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- Based on Kukjin's for-next branch. Depends on: 1) PMIC addition to Peach-pi: http://www.spinics.net/lists/linux-samsung-soc/msg33166.html 2) tps65090 addition to Peach-pi

Re: [PATCH V4 00/10] drm: exynos: few patches to enhance bridge chip support

2014-06-23 Thread Rahul Sharma
: Tested-by: Rahul Sharma rahul.sha...@samsung.com Regards, Rahul Sharma. On 20 June 2014 21:21, Inki Dae inki@samsung.com wrote: 2014-06-20 17:06 GMT+09:00 Ajay kumar ajayn...@gmail.com: ping. I will have a review soon but I'm afraid that I cannot have a test yet because I have no any

Re: [PATCH V4 00/10] drm: exynos: few patches to enhance bridge chip support

2014-06-23 Thread Rahul Sharma
Hi Tomasz, On 23 June 2014 20:08, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Rahul, On 23.06.2014 15:58, Rahul Sharma wrote: Hi Ajay, Inki, I tested this series for Exynos5420 based peach-pit board, Exynos5800 based Peach-pi board and Exynos5250 based Snow board. I verified

[PATCH 4/5 v2] drm/exynos: soft reset mixer before reconfigure after power-on

2014-06-22 Thread Rahul Sharma
Mixer soft reset is a recommended step before reconfiguring the mixer after power on. Mixer looses the previous state of DMAs if soft reset. This is the recommendation from the hardware team. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- drivers/gpu/drm/exynos/exynos_mixer.c |2

[PATCH 5/5 v2] drm/exynos: enable vsync interrupt while waiting for vblank

2014-06-22 Thread Rahul Sharma
mixer_wait_for_vblank function expects that the upcoming vsync interrupt handler routine will clear the wait_vsync_event atomic variable. For this to happen, interrupts should be enabled and disabled properly. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- drivers/gpu/drm/exynos

[PATCH 3/5 v2] drm/exynos: allow mulitple layer updates per vsync for mixer

2014-06-22 Thread Rahul Sharma
Allowing only one layer update per vsync can cause issues while there are update available for both layers. There is a good amount of possibility to loose updates if we allow single update per vsync. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- drivers/gpu/drm/exynos/exynos_mixer.c

[PATCH 1/5 v2] drm/exynos: set power state variable after enabling clocks and power

2014-06-22 Thread Rahul Sharma
with device power enabled. Similar logic for poweroff sequence. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- drivers/gpu/drm/exynos/exynos_mixer.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers

[PATCH 0/5 v2] drm/exynos: fix for misc issues related to exynos mixer

2014-06-22 Thread Rahul Sharma
Fixes for various issues which are to Power On/Off sequence, Layer update, waiting for vblank in exynos mixer driver. v2: 1) Repalce mixer_enable_vblank with drm_vblank_get. This series is based on exynos-drm-fixes branch in Inki dae's tree. Rahul Sharma (5): drm/exynos: set power state

[PATCH 2/5 v2] drm/exynos: stop mixer before gating clocks during poweroff

2014-06-22 Thread Rahul Sharma
Mixer should be power gated only after it is gracefully stopped. The recommended sequence is to Stop the mixer and wait till it enters to IDLE state before gating the clocks and power to the mixer. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- drivers/gpu/drm/exynos/exynos_mixer.c

[PATCH v2] drm/exynos: defer hdmi probe when fail to get regulators

2014-06-22 Thread Rahul Sharma
HDMI probe proceeds with dummy regulators when the regulators are not provided in DT node or regulator provider has not get probed or failed to register the regulators. This patch modify hdmi driver to defer the probe in case the regulators are not available. Signed-off-by: Rahul Sharma

Re: [PATCH 5/5] drm/exynos: enable vsync interrupt while waiting for vblank

2014-06-20 Thread Rahul Sharma
Hi All, On 18 June 2014 17:04, Rahul Sharma rahul.sha...@samsung.com wrote: mixer_wait_for_vblank function expects that the upcoming vsync interrupt handler routine will clear the wait_vsync_event atomic variable. For this to happen, interrupts should be enabled and disabled properly

[RFC] drm/exynos: abort commit when framebuffer is removed from plane

2014-06-19 Thread Rahul Sharma
. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- This works fine but I am not confident on the correctness of the solution. drivers/gpu/drm/exynos/exynos_drm_crtc.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos

Re: [PATCH] ARM: dts: remove display power domain for exynos5420

2014-06-18 Thread Rahul Sharma
Hi Andrej, On 18 June 2014 11:46, Andrzej Hajda a.ha...@samsung.com wrote: On 06/17/2014 07:49 AM, Rahul Sharma wrote: Hi All, Please review this patch. Regards, Rahul Sharma On 9 June 2014 16:58, Rahul Sharma rahul.sha...@samsung.com wrote: Display domain is removed due to instability

[PATCH 0/5] drm/exynos: fix for misc issues related to exynos mixer

2014-06-18 Thread Rahul Sharma
Fixes for various issues which are to Power On/Off sequence, Layer update, waiting for vblank in exynos mixer driver. This series is based on exynos-drm-fixes branch in Inki dae's tree. Rahul Sharma (5): drm/exynos: set power state variable after enabling clocks and power drm/exynos: stop

[PATCH 1/5] drm/exynos: set power state variable after enabling clocks and power

2014-06-18 Thread Rahul Sharma
with device power enabled. Similar logic for poweroff sequence. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- drivers/gpu/drm/exynos/exynos_mixer.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers

[PATCH 2/5] drm/exynos: stop mixer before gating clocks during poweroff

2014-06-18 Thread Rahul Sharma
Mixer should be power gated only after it is gracefully stopped. The recommended sequence is to Stop the mixer and wait till it enters to IDLE state before gating the clocks and power to the mixer. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- drivers/gpu/drm/exynos/exynos_mixer.c

[PATCH 3/5] drm/exynos: allow mulitple layer updates per vsync for mixer

2014-06-18 Thread Rahul Sharma
Allowing only one layer update per vsync can cause issues while there are update available for both layers. There is a good amount of possibility to loose updates if we allow single update per vsync. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- drivers/gpu/drm/exynos/exynos_mixer.c

[PATCH 4/5] drm/exynos: soft reset mixer before reconfigure after power-on

2014-06-18 Thread Rahul Sharma
Mixer soft reset is a recommended step before reconfiguring the mixer after power on. Mixer looses the previous state of DMAs if soft reset. This is the recommendation from the hardware team. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- drivers/gpu/drm/exynos/exynos_mixer.c |2

[PATCH 5/5] drm/exynos: enable vsync interrupt while waiting for vblank

2014-06-18 Thread Rahul Sharma
mixer_wait_for_vblank function expects that the upcoming vsync interrupt handler routine will clear the wait_vsync_event atomic variable. For this to happen, interrupts should be enabled and disabled properly. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- drivers/gpu/drm/exynos

[PATCH] drm/exynos: defer hdmi probe when fail to get regulators

2014-06-18 Thread Rahul Sharma
HDMI probe proceeds with dummy regulators when the regulators are not provided in DT node or regulator provider has not get probed or failed to register the regulators. This patch modify hdmi driver to defer the probe in case the regulators are not available. Signed-off-by: Rahul Sharma

[PATCH] ARM: dts: add hdmi regulators for exynos5420 based peach-pit board

2014-06-18 Thread Rahul Sharma
Adding regulators for hdmi for peach-pit board. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- Based on for-next branch in Kukjin's tree. Dependent on: 1) PMIC DT patch at http://www.gossamer-threads.com/lists/linux/kernel/1945703 2) tps65090 DT patch at https://lkml.org/lkml/2014/6/13

Re: [PATCH] drm/exynos: defer hdmi probe when fail to get regulators

2014-06-18 Thread Rahul Sharma
Thanks Inki, On 19 June 2014 09:34, Inki Dae inki@samsung.com wrote: On 2014년 06월 18일 22:42, Rahul Sharma wrote: HDMI probe proceeds with dummy regulators when the regulators are not provided in DT node or regulator provider has not get probed or failed to register the regulators

[PATCH] clk/exynos5250: fix bit number for tv sysmmu clock

2014-06-18 Thread Rahul Sharma
Change bit from 2 to 9 for tv (mixer) sysmmu clock. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- Based on Kukjin's for-next branch. drivers/clk/samsung/clk-exynos5250.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/samsung/clk-exynos5250.c b

Re: [PATCH] ARM: dts: remove display power domain for exynos5420

2014-06-16 Thread Rahul Sharma
Hi All, Please review this patch. Regards, Rahul Sharma On 9 June 2014 16:58, Rahul Sharma rahul.sha...@samsung.com wrote: Display domain is removed due to instability issues. Explaining the problem below: exynos_init_late triggers the pm_genpd_poweroff_unused which powers off the unused

Re: linux-next on Chromebook2: DRM failing to allocate

2014-06-10 Thread Rahul Sharma
EC and Tps DT patches to get regulators up in kernel. Those are not posted yet. I will send these patches to you. Regards, Rahul sharma. Kevin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH] ARM: dts: remove display power domain for exynos5420

2014-06-09 Thread Rahul Sharma
Power Domain Disable fail notification. Increasing the Timeout also didn't help. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- based on Kukjin's for-next branch. arch/arm/boot/dts/exynos5420.dtsi |6 -- 1 file changed, 6 deletions(-) diff --git a/arch/arm/boot/dts/exynos5420

Re: [PATCH] drm/exynos: remove hardware overlays disable from fimd probe

2014-06-02 Thread Rahul Sharma
On 2 June 2014 14:41, Andrzej Hajda a.ha...@samsung.com wrote: Hi Rahul, On 05/28/2014 08:11 AM, Rahul Sharma wrote: System hangs when FIMD registers are accessed to disable hardware overlays. This is because of the clocks which are not enabled before register access. 'Hardware overlay

[PATCH] drm/exynos: remove hardware overlays disable from fimd probe

2014-05-28 Thread Rahul Sharma
System hangs when FIMD registers are accessed to disable hardware overlays. This is because of the clocks which are not enabled before register access. 'Hardware overlay disable' is cleaned from the FIMD probe. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- Based on exynos-drm-next

Re: [PATCH v5] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-28 Thread Rahul Sharma
, Rahul Sharma. On 27 May 2014 18:28, Inki Dae inki@samsung.com wrote: On 2014년 05월 27일 18:55, Rahul Sharma wrote: Gentle Reminder On 26 May 2014 14:21, Rahul Sharma rahul.sha...@samsung.com wrote: Hi Daniel, On 26 May 2014 13:11, Daniel Kurtz djku...@chromium.org wrote: On Mon, May 26

Re: [PATCH v5] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-27 Thread Rahul Sharma
Gentle Reminder On 26 May 2014 14:21, Rahul Sharma rahul.sha...@samsung.com wrote: Hi Daniel, On 26 May 2014 13:11, Daniel Kurtz djku...@chromium.org wrote: On Mon, May 26, 2014 at 2:59 PM, Rahul Sharma rahul.sha...@samsung.com wrote: Hi Inki, Please review this patch. [snip

Re: [PATCH v5] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-26 Thread Rahul Sharma
Hi Inki, Please review this patch. Regards, Rahul Sharma On 23 May 2014 17:17, Rahul Sharma rahul.sha...@samsung.com wrote: From: Rahul Sharma rahul.sha...@samsung.com Fimd probe is accessing fimd Registers without enabling the fimd gate clocks. If FIMD clocks are kept disabled in Uboot

Re: [PATCH v5] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-26 Thread Rahul Sharma
Hi Daniel, On 26 May 2014 13:11, Daniel Kurtz djku...@chromium.org wrote: On Mon, May 26, 2014 at 2:59 PM, Rahul Sharma rahul.sha...@samsung.com wrote: Hi Inki, Please review this patch. [snip] + + ret = clk_prepare_enable(ctx-lcd_clk); Hi Rahul, Can you explain why exactly

Re: [PATCH v4] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-23 Thread Rahul Sharma
, to wake up display pm domain. You are right. I have added pm runtime get sync and put sync. Regards, Rahul Sharma. Regards Andrzej } -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

[PATCH v5] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-23 Thread Rahul Sharma
From: Rahul Sharma rahul.sha...@samsung.com Fimd probe is accessing fimd Registers without enabling the fimd gate clocks. If FIMD clocks are kept disabled in Uboot or disbaled during kernel boottime, the system hangs during boottime. This issue got surfaced when verifying with sysmmu enabled

Re: [PATCH] drm/exynos: allocate non-contigous buffers when iommu is enabled

2014-05-22 Thread Rahul Sharma
Thanks Sachin. On 22 May 2014 11:38, Sachin Kamat sachin.ka...@linaro.org wrote: Hi Rahul, On 7 May 2014 17:21, Rahul Sharma rahul.sha...@samsung.com wrote: From: Rahul Sharma rahul.sha...@samsung.com Allow to allocate non-contigous buffers when iommu is enabled. Currently, it tries

[PATCH v2] drm:exynos: allocate non-contigous buffer when iommu is enabled

2014-05-22 Thread Rahul Sharma
From: Rahul Sharma rahul.sha...@samsung.com Allow to allocate non-contigous buffers when iommu is enabled. Currently, it tries to allocates contigous buffer which consistently fail for large buffers and then fall back to non contigous. Apart from being slow, this implementation is also very noisy

Re: [PATCH] drm/exynos: use 4WORD dma burst length for small fbs

2014-05-22 Thread Rahul Sharma
On 22 May 2014 12:25, Inki Dae inki@samsung.com wrote: On 2014년 05월 22일 13:36, Rahul Sharma wrote: Hi Inki, On 21 May 2014 16:43, Inki Dae inki@samsung.com wrote: Hi Rahul, On 2014년 05월 07일 20:25, Rahul Sharma wrote: From: Rahul Sharma rahul.sha...@samsung.com In case of exynos

Re: [PATCH V2] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-22 Thread Rahul Sharma
On 22 May 2014 13:33, Thierry Reding thierry.red...@gmail.com wrote: On Thu, May 22, 2014 at 12:06:16PM +0530, Rahul Sharma wrote: On 22 May 2014 11:51, Sachin Kamat sachin.ka...@linaro.org wrote: Hi Rahul, [snip] + clk_prepare_enable(ctx-bus_clk); Probably a check for its

[PATCH v3] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-22 Thread Rahul Sharma
before accessing sysmmu regs and then disables. Later fimd probe tries to read the register without enabling the clock which is wrong and hangs the system. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 17 - 1 file changed, 16

Re: [PATCH 5/7] drm/exynos: add hdmiphy power on/off sequence

2014-05-22 Thread Rahul Sharma
Hi Inki, Please review this patch. Regards, Rahul Sharma On 3 April 2014 20:41, Rahul Sharma rahul.sha...@samsung.com wrote: From: Shirish S s.shir...@samsung.com This patch implements the power on/off sequence of HDMI PHY in exynos5420 and exynos5250 as provided by the hardware team

Re: [PATCH] drm/exynos: fix nested calls to lock mutex in drm resume

2014-05-22 Thread Rahul Sharma
Hi Inki, This is another one which has not got reviewed. Please review. Regards, Rahul Sharma On 30 April 2014 19:11, Rahul Sharma rahul.sha...@samsung.com wrote: From: Rahul Sharma rahul.sha...@samsung.com While testing S2R on exynos board, system is hanging and rebooting due to nested

Re: [PATCH] drm/exynos: fix nested calls to lock mutex in drm resume

2014-05-22 Thread Rahul Sharma
On 22 May 2014 23:26, Sachin Kamat sachin.ka...@linaro.org wrote: Hi Rahul, On 22 May 2014 19:46, Rahul Sharma rahul.sha...@samsung.com wrote: Hi Inki, This is another one which has not got reviewed. Please review. Inki has applied a similar patch from Takashi [1]. Thanks Sachin, Good

[PATCH v4] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-22 Thread Rahul Sharma
From: Rahul Sharma rahul.sha...@samsung.com Fimd probe is accessing fimd Registers without enabling the fimd gate clocks. If FIMD clocks are kept disabled in Uboot or disbaled during kernel boottime, the system hangs during boottime. This issue got surfaced when verifying with sysmmu enabled

Re: [PATCH v2] drm/exynos: use regmap interface to set hdmiphy control bit in pmu

2014-05-21 Thread Rahul Sharma
Hi Inki, Tomasz, Any comment on this patch? Regards, Rahul Sharma On 20 May 2014 10:36, Rahul Sharma rahul.sha...@samsung.com wrote: Exynos drm hdmi driver used to get dummy hdmiphy clock to control the PMU bit for hdmiphy. This bit needs to be set before setting any resolution to hdmi

[PATCH] ARM: dts: move dp hpd gpio pin to pinctrl_0 for exynos5420 peach_pit

2014-05-21 Thread Rahul Sharma
DP Hpd Gpio pin which is gpx2-6 in Exynos 5420 based peach board, belongs to Pinctrl_0. It has moved to pinctrl_0 from pinctrl_3. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- Based on Kukjin's for-next branch. arch/arm/boot/dts/exynos5420-peach-pit.dts | 14 +++--- 1 file

Re: [PATCH] drm/exynos: use 4WORD dma burst length for small fbs

2014-05-21 Thread Rahul Sharma
Hi Inki, On 21 May 2014 16:43, Inki Dae inki@samsung.com wrote: Hi Rahul, On 2014년 05월 07일 20:25, Rahul Sharma wrote: From: Rahul Sharma rahul.sha...@samsung.com In case of exynos, setting dma-burst to 16Word causes permanent tearing for very small buffers, e.g. cursor buffer. Burst

[PATCH V2] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-21 Thread Rahul Sharma
From: Rahul Sharma rahul.sha...@samsung.com Fimd probe is accessing fimd Registers without enabling the fimd gate clocks. If FIMD clocks are kept disabled in Uboot or disbaled during kernel boottime, the system hangs during boottime. This issue got surfaced when verifying with sysmmu enabled

Re: [PATCH] drm/exynos: allocate non-contigous buffers when iommu is enabled

2014-05-21 Thread Rahul Sharma
Hi Inki, The below fix doesn't affect the FB dev buffer allocation. IMO the scenario where u-boot allocates the buffer is not disturbed. Please review the implementation. Regards, Rahul Sharma. On 7 May 2014 17:21, Rahul Sharma rahul.sha...@samsung.com wrote: From: Rahul Sharma rahul.sha

Re: [PATCH v3 0/4] ARM: dts: enable display for peach-pit and snow boards

2014-05-20 Thread Rahul Sharma
On 20 May 2014 10:41, Rahul Sharma rahul.sha...@samsung.com wrote: Thanks Kukjin, I have changed it in my environment now. Kukjin, dp_hpd_gpio got accidentally merged to pinctrl_3 in your for-next branch. It should be in pinctrl_0. /*/ }; dp_hpd_gpio

[PATCH 0/2] ARM: dts: add pmu syscon handle to exynos hdmi nodes

2014-05-20 Thread Rahul Sharma
Add PMU syscon handle to HDMI dt node for controlling PHY Enable/Disable bit. Patch is dependent for following patch for approval on DT Bindings: http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg31106.html It is based on Kukjin's for-next branch. Rahul Sharma (2): ARM: dts

[PATCH 2/2] ARM: dts: add pmu syscon handle to exynos5420 hdmi

2014-05-20 Thread Rahul Sharma
Add PMU syscon handle to HDMI dt node for controlling PHY Enable/Disable bit. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- arch/arm/boot/dts/exynos5420.dtsi |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi

[PATCH 1/2] ARM: dts: add pmu syscon handle to exynos5250 hdmi

2014-05-20 Thread Rahul Sharma
Add PMU syscon handle to HDMI dt node for controlling PHY Enable/Disable bit. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- arch/arm/boot/dts/exynos5250.dtsi |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-19 Thread Rahul Sharma
On 16 May 2014 20:19, Tomasz Figa t.f...@samsung.com wrote: On 16.05.2014 16:30, Rahul Sharma wrote: On 16 May 2014 16:20, Tomasz Figa t.f...@samsung.com wrote: On 16.05.2014 12:35, Rahul Sharma wrote: On 16 May 2014 15:12, Rahul Sharma rahul.sha...@samsung.com wrote: On 16 May 2014 03:14

Re: [PATCH 2/5] drm/exynos: use regmap interface to set hdmiphy control bit in pmu

2014-05-19 Thread Rahul Sharma
On 11 April 2014 07:22, Rahul Sharma r.sh.o...@gmail.com wrote: Thanks Tomasz, This patch is not longer required after rebasing to Tomasz Stanislawski's Simple Phy patches. Hi All, We had further discussion on the Simple Phy Driver at http://www.spinics.net/lists/linux-samsung-soc/msg31100

[PATCH v2] drm/exynos: use regmap interface to set hdmiphy control bit in pmu

2014-05-19 Thread Rahul Sharma
driver is modified to control the phy enable bit inside PMU using regmap interfaces. Devicetree binding document for hdmi is also updated. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- V2: 1) Squashed hdmiphy clock cleanup patch. 2) Addressed comments related to indentation, using

Re: [PATCH v3 0/4] ARM: dts: enable display for peach-pit and snow boards

2014-05-19 Thread Rahul Sharma
Thanks Kukjin, I have changed it in my environment now. Regards, Rahul Sharma. On 19 May 2014 21:10, Kukjin Kim kgene@samsung.com wrote: On 05/09/14 19:09, Rahul Sharma wrote: From: Rahul Sharmarahul.sha...@samsung.com Probably, should be Rahul Sharma rahul.sharma@... Please make

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-19 Thread Rahul Sharma
On 19 May 2014 16:24, Tomasz Figa tomasz.f...@gmail.com wrote: On 19.05.2014 09:10, Rahul Sharma wrote: On 16 May 2014 20:19, Tomasz Figa t.f...@samsung.com wrote: On 16.05.2014 16:30, Rahul Sharma wrote: On 16 May 2014 16:20, Tomasz Figa t.f...@samsung.com wrote: On 16.05.2014 12:35, Rahul

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-16 Thread Rahul Sharma
On 16 May 2014 03:14, Tomasz Figa tomasz.f...@gmail.com wrote: On 15.05.2014 06:01, Rahul Sharma wrote: Thanks Tomasz, On 15 May 2014 01:31, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Rahul, Tomasz, [snip] + simplephys: simple-phys@1004 { + compatible = samsung

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-16 Thread Rahul Sharma
On 16 May 2014 15:12, Rahul Sharma rahul.sha...@samsung.com wrote: On 16 May 2014 03:14, Tomasz Figa tomasz.f...@gmail.com wrote: On 15.05.2014 06:01, Rahul Sharma wrote: [snip] the PHY provider. Please correct me if I got you wrong. You want somthing like this: pmu_system_controller

Re: [PATCH 2/2] ARM: dts: enable fimd for exynos5800 based peach-pi board

2014-05-16 Thread Rahul Sharma
Gentle Ping On 13 May 2014 08:53, Rahul Sharma rahul.sha...@samsung.com wrote: Thanks Jingoo Han. Hi Kukjin, Please consider both of these series for your tree. 1) http://www.spinics.net/lists/arm-kernel/msg329697.html 2) http://www.spinics.net/lists/arm-kernel/msg330291.html Regards

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-16 Thread Rahul Sharma
On 16 May 2014 16:20, Tomasz Figa t.f...@samsung.com wrote: On 16.05.2014 12:35, Rahul Sharma wrote: On 16 May 2014 15:12, Rahul Sharma rahul.sha...@samsung.com wrote: On 16 May 2014 03:14, Tomasz Figa tomasz.f...@gmail.com wrote: On 15.05.2014 06:01, Rahul Sharma wrote: [snip] the PHY

Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-16 Thread Rahul Sharma
On 16 May 2014 16:22, Tomasz Figa t.f...@samsung.com wrote: Hi Rahul, On 16.05.2014 12:39, Rahul Sharma wrote: [snip] + gate-lock = clkout_lock; + + mux-reg = reg + EXYNOS_PMU_DEBUG_REG; + mux-mask = EXYNOS_CLKOUT_MUX_MASK; + mux-shift = EXYNOS_CLKOUT_MUX_SHIFT

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-15 Thread Rahul Sharma
On 15 May 2014 13:12, Thierry Reding thierry.red...@gmail.com wrote: On Thu, May 15, 2014 at 10:49:37AM +0530, Rahul Sharma wrote: Hi Thierry, On 15 May 2014 03:44, Thierry Reding thierry.red...@gmail.com wrote: On Thu, May 15, 2014 at 12:47:21AM +0530, Rahul Sharma wrote: [...] +#define

Re: [PATCH v4 5/5] ARM: dts: enable hdmi for exynos5800 based peach-pi board

2014-05-15 Thread Rahul Sharma
On 15 May 2014 01:27, Tomasz Figa tomasz.f...@gmail.com wrote: On 14.05.2014 21:56, Tomasz Figa wrote: Hi Rahul, On 14.05.2014 04:46, Rahul Sharma wrote: From: Rahul Sharma rahul.sha...@samsung.com Enable hdmi for peach-pi board. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com

[PATCH v4 0/3] phy: Add exynos-simple-phy driver

2014-05-15 Thread Rahul Sharma
From: Rahul Sharma rahul.sha...@samsung.com Changelog: v4: * Rename files to follow phy-exynos-simple names. * Rename Macros to this convention PHY_EXYNOS_SIMPLE_. * Added list of phy specifier values to documentation file. * Removed of_match_ptr from driver

[PATCH v4 1/3] phy: Add exynos-simple-phy driver

2014-05-15 Thread Rahul Sharma
From: Tomasz Stanislawski t.stanisl...@samsung.com Add exynos-simple-phy driver to support a single register PHY interfaces present on Exynos4 SoC. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- .../devicetree/bindings/phy

[PATCH v4 2/3] drm: exynos: hdmi: use hdmiphy as PHY

2014-05-15 Thread Rahul Sharma
-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- drivers/gpu/drm/exynos/exynos_hdmi.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c

[PATCH v4 3/3] s5p-tv: hdmi: use hdmiphy as PHY

2014-05-15 Thread Rahul Sharma
-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- drivers/media/platform/s5p-tv/hdmi_drv.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/s5p-tv/hdmi_drv.c b/drivers/media/platform/s5p

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-15 Thread Rahul Sharma
Hi, On 15 May 2014 19:01, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: Hi, On Thursday, May 15, 2014 12:47:21 AM Rahul Sharma wrote: From: Tomasz Stanislawski t.stanisl...@samsung.com Add exynos-simple-phy driver to support a single register PHY interfaces present on Exynos4

Re: [PATCH 1/4] clk: samsung: out: Add infrastructure to register CLKOUT

2014-05-15 Thread Rahul Sharma
clock provider with iomap, is relatively cleaner approach till CCF is not ready with regmap based reg access for clock registers. Experts!! please comment. Regards, Rahul Sharma. On 12 May 2014 10:16, Tushar Behera tushar.beh...@linaro.org wrote: On 05/10/2014 09:21 AM, Pankaj Dubey wrote

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-15 Thread Rahul Sharma
On 15 May 2014 19:11, Kishon Vijay Abraham I kis...@ti.com wrote: On Thursday 15 May 2014 07:05 PM, Rahul Sharma wrote: Hi, On 15 May 2014 19:01, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: Hi, On Thursday, May 15, 2014 12:47:21 AM Rahul Sharma wrote: From: Tomasz

Re: [PATCH 1/4] clk: samsung: out: Add infrastructure to register CLKOUT

2014-05-15 Thread Rahul Sharma
On 15 May 2014 19:37, Tomasz Figa t.f...@samsung.com wrote: Hi Rahul, Tushar, On 15.05.2014 15:44, Rahul Sharma wrote: Hi Tushar, Basically you are adding a new clock-type for Clkout. IMO clkout is not a special hardware. Existing clock types can be reused to support clkout. I see 3 major

[PATCH v5 0/5] ARM: dts: enable hdmi for exynos5 based peach and snow boards

2014-05-15 Thread Rahul Sharma
From: Rahul Sharma rahul.sha...@samsung.com Enable hdmi for exynos5250 based snow board, exynos5420 based peach pit board and 5800 based peach-pi board. V5: 1) Moved hdmi_hpd_irq pin back to board files. 2) Replaced 0 with GPIO_ACTIVE_HIGH while adding gpio property to HDMI node. V4: 1) Removed

[PATCH v5 1/4] ARM: dts: enable hdmi for exynos5250 based snow board

2014-05-15 Thread Rahul Sharma
From: Rahul Sharma rahul.sha...@samsung.com Enable support for HDMI for exynos5250 based Snow board. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- arch/arm/boot/dts/exynos5250-cros-common.dtsi |6 +- arch/arm/boot/dts/exynos5250-snow.dts | 14 ++ 2 files

[PATCH v5 2/4] ARM: dts: change to correct compatible string for exynos5420 hdmi

2014-05-15 Thread Rahul Sharma
From: Rahul Sharma rahul.sha...@samsung.com Replace compatible string for HDMI node in Exynos5420. Since latest restructring in Drm hdmi driver, it is agreed to use a seperate compatible string for Exynos5420 HDMI IP siince it uses APB mapped Phy. Signed-off-by: Rahul Sharma rahul.sha

[PATCH v5 3/4] ARM: dts: enable hdmi for exynos5420 based peach-pit board

2014-05-15 Thread Rahul Sharma
From: Rahul Sharma rahul.sha...@samsung.com Enable hdmi for exynos5420 based peach-pit board. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- arch/arm/boot/dts/exynos5420-peach-pit.dts | 22 ++ arch/arm/boot/dts/exynos5420.dtsi |5 + 2 files

[PATCH v5 4/4] ARM: dts: enable hdmi for exynos5800 based peach-pi board

2014-05-15 Thread Rahul Sharma
From: Rahul Sharma rahul.sha...@samsung.com Enable hdmi for peach-pi board. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- arch/arm/boot/dts/exynos5800-peach-pi.dts | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts

[PATCH v3 2/3] drm: exynos: hdmi: use hdmiphy as PHY

2014-05-14 Thread Rahul Sharma
-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- drivers/gpu/drm/exynos/exynos_hdmi.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c

[PATCH v3 0/3] phy: Add exynos-simple-phy driver

2014-05-14 Thread Rahul Sharma
From: Rahul Sharma rahul.sha...@samsung.com Hi All, This series has been originally proposed by Tomasz Stanislawski. With his permission, I have addressed the following review comments in V3. Changelog: v3: * Implement lazy-init of PHYs. * Use MACROs instead of numbers

[PATCH v3 3/3] s5p-tv: hdmi: use hdmiphy as PHY

2014-05-14 Thread Rahul Sharma
-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- drivers/media/platform/s5p-tv/hdmi_drv.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/s5p-tv/hdmi_drv.c b/drivers/media/platform/s5p

[PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-14 Thread Rahul Sharma
From: Tomasz Stanislawski t.stanisl...@samsung.com Add exynos-simple-phy driver to support a single register PHY interfaces present on Exynos4 SoC. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- .../devicetree/bindings/phy

Re: [PATCH v4 4/5] ARM: dts: remove chip specific hdmi hpd pin from board

2014-05-14 Thread Rahul Sharma
On 15 May 2014 00:15, Kukjin Kim kgene@samsung.com wrote: On 05/14/14 11:46, Rahul Sharma wrote: From: Rahul Sharmarahul.sha...@samsung.com gpx3-7 is chip specific pin in Exynos5420 for hdmi hotplug. This pin is moved to exynos5420-pinctrl.dts and removed from the board file. Rahul

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-14 Thread Rahul Sharma
,exynos5420-simple-phy; ... }; }; Regards, Rahul Sharma. Otherwise looks good. Best regards, Tomasz ___ dri-devel mailing list dri-de...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-14 Thread Rahul Sharma
Hi Thierry, On 15 May 2014 03:44, Thierry Reding thierry.red...@gmail.com wrote: On Thu, May 15, 2014 at 12:47:21AM +0530, Rahul Sharma wrote: [...] diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt [...] +For samsung

Re: [PATCH v4 1/5] ARM: dts: enable hdmi for exynos5250 based snow board

2014-05-14 Thread Rahul Sharma
Tomasz, On 15 May 2014 01:11, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Rahul, On 14.05.2014 04:45, Rahul Sharma wrote: From: Rahul Sharma rahul.sha...@samsung.com Enable support for HDMI for exynos5250 based Snow board. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- arch

Re: [PATCH v4 2/5] ARM: dts: change to correct compatible string for exynos5420 hdmi

2014-05-14 Thread Rahul Sharma
Thanks Tomasz, Patch which add this compatible in documentation is available at http://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/log/?h=exynos-drm-next Regards, Rahul Sharma On 15 May 2014 01:14, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Rahul, On 14.05.2014 04:45, Rahul

Re: [PATCH v4 3/5] ARM: dts: enable hdmi for exynos5420 based peach-pit board

2014-05-14 Thread Rahul Sharma
On 15 May 2014 01:20, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Rahul, On 14.05.2014 04:46, Rahul Sharma wrote: From: Rahul Sharma rahul.sha...@samsung.com Enable hdmi for exynos5420 based peach-pit board. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- arch/arm/boot/dts

Re: [PATCH v4 4/5] ARM: dts: remove chip specific hdmi hpd pin from board

2014-05-14 Thread Rahul Sharma
On 15 May 2014 01:21, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Rahul, On 14.05.2014 04:46, Rahul Sharma wrote: From: Rahul Sharma rahul.sha...@samsung.com gpx3-7 is chip specific pin in Exynos5420 for hdmi hotplug. This pin is moved to exynos5420-pinctrl.dts and removed from the board

Re: [PATCHv2 1/3] phy: Add exynos-simple-phy driver

2014-05-13 Thread Rahul Sharma
Gentle PING On 7 May 2014 21:03, Tomasz Figa t.f...@samsung.com wrote: [CCing more DT-folks :)] On 07.05.2014 16:19, Rahul Sharma wrote: On 7 May 2014 19:06, Tomasz Stanislawski t.stanisl...@samsung.com wrote: On 05/07/2014 12:38 PM, Rahul Sharma wrote: On 5 May 2014 15:14, Kishon Vijay

[PATCH v4 3/5] ARM: dts: enable hdmi for exynos5420 based peach-pit board

2014-05-13 Thread Rahul Sharma
From: Rahul Sharma rahul.sha...@samsung.com Enable hdmi for exynos5420 based peach-pit board. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- arch/arm/boot/dts/exynos5420-peach-pit.dts | 19 +++ arch/arm/boot/dts/exynos5420-pinctrl.dtsi |7 +++ arch/arm/boot

  1   2   3   4   5   6   7   >