Hi Marek,
> This problem is known for ages, there were number of attempts to add
Yes, I heard of it, too.
> support for deferred probe or solve the problem of deferred UDC driver
> probe, but none got accepted so far:
Then they need to be worked on. AFAIK the rejection is based on
On Fri, Oct 30, 2015 at 03:23:28PM +0100, Marek Szyprowski wrote:
> i2c bus drivers should be registered earlier than typical drivers to let
> important i2c devices (like PMICs/regulators) get registered early
> enough to avoid probe defer of all devices in typical embedded system.
>
>
From: Wolfram Sang <wsa+rene...@sang-engineering.com>
The core may register clients attached to this master which may use
funtionality from the master. So, RuntimePM must be enabled before, otherwise
this will fail. While here, move drvdata, too.
Signed-off-by: Wolfram Sang <wsa+ren
On Sat, Oct 10, 2015 at 03:08:52PM +0900, Krzysztof Kozlowski wrote:
> W dniu 09.10.2015 o 18:39, Wolfram Sang pisze:
> > From: Wolfram Sang <wsa+rene...@sang-engineering.com>
> >
> > The core may register clients attached to this master which may use
> >
From: Wolfram Sang <wsa+rene...@sang-engineering.com>
The core may register clients attached to this master which may use
funtionality from the master. So, RuntimePM must be enabled before, otherwise
this will fail. While here, move drvdata, too.
Signed-off-by: Wolfram Sang <wsa+ren
From: Wolfram Sang <wsa+rene...@sang-engineering.com>
The core may register clients attached to this master which may use
funtionality from the master. So, RuntimePM must be enabled before, otherwise
this will fail. While here, move drvdata, too.
Signed-off-by: Wolfram Sang <wsa+ren
@@ -565,7 +564,7 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c,
unsigned long iicstat)
tmp = ~S3C2410_IICCON_IRQPEND;
writel(tmp, i2c-regs + S3C2410_IICCON);
out:
- return ret;
+ return;
What about removing out: and return as well?
signature.asc
On Thu, Jul 16, 2015 at 10:36:16PM +0200, Laurent Navet wrote:
ret is assigned zero and just used to return. remove it.
Found by using coccinelle.
Signed-off-by: Laurent Navet laurent.na...@gmail.com
Why not make it void?
signature.asc
Description: Digital signature
On Thu, Apr 16, 2015 at 01:05:19PM +0100, Charles Keepax wrote:
Commit 523c5b89640e (i2c: Remove support for legacy PM) removed the PM
ops from the bus type, which causes the pm operations on the s3c2410
adapter device to fail (-ENOSUPP in rpm_callback). The adapter device
doesn't get bound to
On Thu, Apr 16, 2015 at 02:28:02PM +0200, Beata Michalska wrote:
On 04/16/2015 02:05 PM, Charles Keepax wrote:
Commit 523c5b89640e (i2c: Remove support for legacy PM) removed the PM
ops from the bus type, which causes the pm operations on the s3c2410
adapter device to fail (-ENOSUPP in
On Mon, Jan 19, 2015 at 05:03:33PM +0100, Paul Osmialowski wrote:
This patch solves deadlock between clock prepare mutex and regmap mutex
reported
by Tomasz Figa in [1] by implementing solution from [2]: always leave the
clock
of the i2c controller in a prepared state.
[1]
This platform_driver does not need to set an owner, it will be populated by the
driver core.
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
Generated with coccinelle. SmPL file is in the introductory msg. The big
cleanup was pulled in this merge window. This series catches the bits fallen
on
the way :)
Wolfram Sang (28):
ARM: mach-exynos: drop owner assignment from platform_drivers
mips: lantiq: xway: drop owner assignment from platform_drivers
mips: pci: drop owner assignment from platform_drivers
char: ipmi: drop owner assignment from platform_drivers
cpufreq: drop
This platform_driver does not need to set an owner, it will be populated by the
driver core.
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
Generated with coccinelle. SmPL file is in the introductory msg. The big
cleanup was pulled in this merge window. This series catches the bits fallen
and restoring of SYS_I2C_CFG register during
suspend and resume of i2c driver.
CC: Wolfram Sang w...@the-dreams.de
CC: linux-...@vger.kernel.org
Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com
Applied to for-next, thanks!
signature.asc
Description: Digital signature
I usually don't take DTS patches. They should go via arm-soc. Please say
so if there are reasons I should take them.
I CC'ed to you because same patch contains changes in i2c driver.
Yes, those should absolutely go via my I2C tree. You need to make a
seperate patch out of the dts changes
: Wolfram Sang w...@the-dreams.de
CC: Russell King li...@arm.linux.org.uk
CC: devicet...@vger.kernel.org
CC: linux-...@vger.kernel.org
CC: linux-...@vger.kernel.org
Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com
---
.../devicetree/bindings/i2c/i2c-s3c2410.txt|1 +
arch/arm/boot
On Fri, Oct 03, 2014 at 01:57:14PM +0200, Wolfram Sang wrote:
Signed-off-by: Wolfram Sang w...@the-dreams.de
Applied to for-next, thanks!
signature.asc
Description: Digital signature
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
drivers/i2c/busses/i2c-exynos5.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c
index 81e6263cd7da..271533d564ec 100644
--- a/drivers/i2c/busses/i2c
field in the variant struct to distinguish
the hardware.
2. Updates the dt-new compatible in dt-binding documenation
Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
Cc: Wolfram Sang w...@the-dreams.de
Applied to for-next, thanks!
signature.asc
Description: Digital signature
Doug posted a patch [0] to fix the issue you are reporting but it was not
picked. I tested that the patch applies on top of linux-next + the latest
cros_ec cleanups (that includes a patch for this i2c driver and was taken
by Lee. So I think is safe for you take Doug's patch through your tree
to 3. Since we un-wedge the bus immediately after the wedge happens, this
is the
correct fix since only one transfer will fail.
Signed-off-by: Derek Basehore dbaseh...@chromium.org
Reviewed-by: Doug Anderson diand...@chromium.org
Acked-by: Wolfram Sang w...@the-dreams.de
On Fri, Sep 19, 2014 at 10:08:12AM +0200, Sjoerd Simons wrote:
To enable the cros-ec-tunnel driver to be auto-loaded when build as a
module add an of match table (and export it) to match the modalias
information passed on to userspace as the Cros EC MFD driver registers
the MFD subdevices with
Funny timing. I am just reviewing the series from Lee and also stumbled
over modaliases, too...
On Thu, Sep 11, 2014 at 10:19:54AM +0100, Nick Dyer wrote:
On 11/09/14 09:38, Javier Martinez Canillas wrote:
To expand on what Sjoerd already said and just to be sure everyone is on the
same
This is a workaround. It would make sense, however, to add it because we
want to support i2c_board_info structures.
I think it really depends if an IP block can be used on non-DT platforms
(which I think is true for this trackpad) but if a driver is for an IP block
that can only be
On Wed, Jun 25, 2014 at 03:32:03PM +0530, Sachin Kamat wrote:
All Exynos5 platforms have HSI2C controllers and are needed by
various IPs connected to the boards based on these SoCs. Thus
select this by default for Exynos5 platforms.
Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
Cc:
On Fri, Jul 25, 2014 at 05:06:32PM +0530, Sachin Kamat wrote:
On Wed, Jul 16, 2014 at 11:10 PM, Wolfram Sang w...@the-dreams.de wrote:
On Wed, Jun 25, 2014 at 10:55:31AM -0700, Doug Anderson wrote:
Sachin,
On Wed, Jun 25, 2014 at 3:02 AM, Sachin Kamat sachin.ka...@samsung.com
wrote
for this is overkill, yet I don't really mind.
Acked-by: Wolfram Sang w...@the-dreams.de
I assume this goes via MFD, let me know if I should take it.
+
/**
* struct ec_i2c_device - Driver data for I2C tunnel
*
@@ -290,6 +292,7 @@ static int ec_i2c_probe(struct platform_device *pdev)
bus
On Thu, Jun 26, 2014 at 10:44:57AM +0530, Naveen Krishna Chatradhi wrote:
This patch removes an extra read of FIFO_STATUS register in the interrrupt
service routine. Which is read again before the actual use.
Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
Applied to for-next,
On Thu, Jun 26, 2014 at 10:44:58AM +0530, Naveen Krishna Chatradhi wrote:
This patch does the following in exynos5_i2c_message_start() function
1. Fixes an assignment
As, i2c_auto_conf is initialized to '0' at the beginning of the
function and HSI2C_READ_WRITE is defined as (1u 16)
On Wed, Jun 25, 2014 at 09:39:20AM -0700, Doug Anderson wrote:
The original code for the exynos i2c controller registered for the
noirq variants. However during review feedback it was moved to
SIMPLE_DEV_PM_OPS without anyone noticing that it meant we were no
longer actually noirq (despite
On Tue, Jun 24, 2014 at 04:56:54PM -0700, Doug Anderson wrote:
From: Vincent Palatin vpala...@chromium.org
When the wake-up is triggered by the PMIC RTC, the RTC driver is trying
to read the PMIC interrupt status over I2C and fails because the I2C
controller is not resumed yet.
Let's resume
On Wed, Jun 25, 2014 at 10:55:31AM -0700, Doug Anderson wrote:
Sachin,
On Wed, Jun 25, 2014 at 3:02 AM, Sachin Kamat sachin.ka...@samsung.com
wrote:
All Exynos5 platforms have HSI2C controllers and are needed by
various IPs connected to the boards based on these SoCs. Thus
select this
that the behaviour finally
changed now. After another transition period, this flag can go, too.
While we are here, remove the indentation for the array setup because
such things always break after some time.
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
drivers/i2c/busses/i2c-s3c2410.c | 8
1 file
Wolfram Sang (16):
i2c: add debug info when class instantiation was dropped
i2c: i2c-at91: Drop class based scanning to improve bootup time
i2c: i2c-bcm2835: Drop class based scanning to improve bootup time
i2c: i2c-bfin-twi: Drop class based scanning to improve bootup time
i2c: i2c-davinci
+ /* Warn that the adapter lost class based instantiation */
+ if (adapter-class == I2C_CLASS_DEPRECATED) {
+ dev_dbg(adapter-dev,
+ This adapter dropped support for I2C classes and
+ won't auto-detect %s devices anymore. If you need
-by: Wolfram Sang w...@the-dreams.de
signature.asc
Description: Digital signature
...@chromium.org
Signed-off-by: Doug Anderson diand...@chromium.org
Acked-by: Lee Jones lee.jo...@linaro.org
Reviewed-by: Simon Glass s...@chromium.org
For the I2C part:
Acked-by: Wolfram Sang w...@the-dreams.de
signature.asc
Description: Digital signature
On Tue, Jun 03, 2014 at 02:30:22PM +0530, Sachin Kamat wrote:
With multiplatform support enabled for Exynos, class based
instantiation causes a boot time delay due to I2C_CLASS_HWMON
triggered probe. Since class based instantiation has been
deprecated since some time now, remove it for Samsung
The reason for the removal is the boot delay it is causing on Exynos 5250
based boards by throwing the following errors continuously.
[ 55.005300] s3c-i2c 12ce.i2c: cannot get bus (error -110)
[ 59.005300] s3c-i2c 12ce.i2c: cannot get bus (error -110)
[ 63.005300] s3c-i2c
Couldn't it be made configurable with a Kconfig entry? E.g. Enable
deprecated class-based instantiation under Drivers / I2C? Turning it
off could make the code ignore the class field completely.
Technically, yes. But we could also wait another cycle and just be done
with it :)
nodes of respective SoC DT files.
Also handle saving and restoring of SYS_I2C_CFG register during
suspend and resume of i2c driver. This will help in removing soc
specific check from mach-exynos/pm.c.
CC: Rob Herring robh...@kernel.org
CC: Randy Dunlap rdun...@infradead.org
CC: Wolfram Sang w
On Fri, May 09, 2014 at 03:54:25PM +0100, Mark Brown wrote:
On Fri, May 09, 2014 at 08:12:47PM +0530, Naveen Krishna Ch wrote:
On 9 May 2014 19:21, Mark Brown broo...@kernel.org wrote:
On Fri, May 09, 2014 at 05:50:00PM +0530, Naveen Krishna Ch wrote:
DRM related drivers like DP, FIMD,
On Thu, Apr 24, 2014 at 08:35:22PM +0530, Naveen Krishna Chatradhi wrote:
From: Doug Anderson diand...@chromium.org
Since many drivers rely on FETs that live behind this arbitrator, they
can't successfully probe until after the arbitrator comes up. They
ought to handle things properly with
On Mon, Apr 28, 2014 at 02:29:58PM +0530, Naveen Krishna Chatradhi wrote:
HSI2C module on Exynos5260 differs from current modules in
following ways:
1. HSI2C on Exynos5260 has fifo_depth of 16bytes
2. Module needs to be reset as a part of init sequence.
Hence, Following changes are
Kindly, suggest a workable approach for all the subsystems.
Keep this patch out-of-tree? I know that probe ordering causes problems,
and that it needs major efforts. Yet, I understood that adding more and
more subsys_initcall to mainline is not going to help the process unless
essential. Using
looks good, so
Reviewed-by: Wolfram Sang w...@the-dreams.de
I don't mind how it gets upstream. I can take it, but you can also keep
it in this series.
signature.asc
Description: Digital signature
On Mon, May 19, 2014 at 06:22:58PM +0100, Lee Jones wrote:
Code looks good, so
Reviewed-by: Wolfram Sang w...@the-dreams.de
I don't mind how it gets upstream. I can take it, but you can also keep
it in this series.
Let's keep the series together. Are you happy with me just
On Fri, Apr 11, 2014 at 03:19:41PM -0700, Doug Anderson wrote:
From: Olof Johansson o...@lixom.net
Don't unmark the device as suspended until after it's been re-setup.
The main race would be w.r.t. an i2c driver that gets resumed at the same
time (asyncronously), that is allowed to do a
Hi,
just a basic review to keep things rolling...
On the original Samsung ARM Chromebook these devices were on an I2C
bus that was shared between the AP and the EC and arbitrated using
some extranal GPIOs (see i2c-arb-gpio-challenge).
The original arbitration scheme worked well enough but
On Mon, Feb 10, 2014 at 11:03:54AM +0100, Wolfram Sang wrote:
With I2C, class based instantiation means if a master driver has e.g.
I2C_CLASS_HWMON set, all slave drivers with this class will try to probe a
device using an array of possible addresses and some heuristics. That creates
traffic
On Fri, Feb 07, 2014 at 10:12:51AM +0530, Naveen Krishna Chatradhi wrote:
This patch adds a new compatible and uses variant struct to support
HSI2C module on Exynos5260. Updates the Documentation dt bindings.
Also resets the module as an init sequence (Needed by Exynos5260).
Signed-off-by:
On Fri, Feb 07, 2014 at 10:13:15AM +0530, Naveen Krishna Chatradhi wrote:
fifo_depth of the HSI2C is not constant
Exynos5420 and Exynos5250 supports fifo_depth of 64bytes
Exynos5260 supports fifo_depth of 16bytes.
This patch configures the fifo_depth based on HSI2C modules version.
On Fri, Feb 07, 2014 at 02:24:09PM +0530, Naveen Krishna Chatradhi wrote:
From: Simon Glass s...@chromium.org
There is a rather odd feature of the exynos i2c controller that if it
is left enabled, it can lock itself up with the clk line held low.
This makes the bus unusable.
On Sat, Feb 15, 2014 at 04:10:39PM +0100, Wolfram Sang wrote:
On Fri, Feb 07, 2014 at 01:59:55PM +0530, Naveen Krishna Chatradhi wrote:
From: Vincent Palatin vpala...@chromium.org
Avoid adding I2C_CLASS_HWMON and I2C_CLASS_SPD class flags to all
Samsung I2C adapters when the I2C mappings
On Wed, Mar 12, 2014 at 08:27:14PM +0100, Wolfram Sang wrote:
On Fri, Feb 07, 2014 at 02:24:09PM +0530, Naveen Krishna Chatradhi wrote:
From: Simon Glass s...@chromium.org
There is a rather odd feature of the exynos i2c controller that if it
is left enabled, it can lock itself up
On Fri, Feb 07, 2014 at 01:59:55PM +0530, Naveen Krishna Chatradhi wrote:
From: Vincent Palatin vpala...@chromium.org
Avoid adding I2C_CLASS_HWMON and I2C_CLASS_SPD class flags to all
Samsung I2C adapters when the I2C mappings are defined in a device tree.
So the drivers doing an
Warn users that class based instantiation is going away soon in favour
of more robust probing and faster bootup times.
Signed-off-by: Wolfram Sang w...@the-dreams.de
Cc: Ben Dooks ben-li...@fluff.org
Cc: Kukjin Kim kgene@samsung.com
---
This patch is a suggestion. Looking for an ack
adding the new DEPRECATED flag.
The series can also be found here:
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/deprecated_class
Thanks,
Wolfram
Wolfram Sang (17):
Documentation: i2c: describe devicetree method for instantiating
devices
i2c: add deprecation
On Thu, Feb 06, 2014 at 02:50:51PM +0100, Tomasz Figa wrote:
Also, please use correct addresses of DT ML and Wolfram's e-mail
(fixed in this message).
And please don't use In-Reply-To when sending new versions of patches.
The message threading became hard to read here...
signature.asc
On Wed, Jan 15, 2014 at 10:42:42AM +0900, y...@samsung.com wrote:
Note that your email address is wrong here. I also fixed the description
to i2c: s3c2410: fix quirk usage for 64-bit which is more apropriate.
Other than that: Applied to for-next, thanks!
signature.asc
Description: Digital
-cast]
This patch fixes this by converting unsigned int to unsigned long.
Maybe switch to kernel_ulong_t? Since this is used in mod_devicetable.h
all over.
CC: Kukjin Kim kgene@samsung.com
CC: Wolfram Sang w...@the-dreams.de
CC: linux-...@vger.kernel.org
Signed-off-by: Pankaj Dubey
Hi,
On Mon, Nov 11, 2013 at 04:50:20PM +0530, Yuvaraj Kumar C D wrote:
From: Vasanth Ananthan vasanthanant...@gmail.com
This patch adds polling mode support for i2c-s3c2410 driver.The
SATA PHY controller's CMU and TRSV block's are of I2C register
map in exynos5250.These blocks can be
On Tue, Nov 26, 2013 at 09:52:46AM +0530, Naveen Krishna Chatradhi wrote:
For Exynos4 and Exynos5 SoCs from Samsung the i2c clock is based
on a fixed 66 MHz peripheral clock, and therefore is completely
independent of the cpu frequency.
Thus, registering for a CPU freq notifier is very
On Wed, Oct 16, 2013 at 11:00:42AM +0530, Naveen Krishna Chatradhi wrote:
Adds support for High Speed I2C driver found in Exynos5 and
later SoCs from Samsung.
Driver only supports Device Tree method.
Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
Signed-off-by: Taekgyun Ko
-off-by: Wolfram Sang w...@the-dreams.de
---
drivers/spi/spi-s3c64xx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 512b889..3df81c6 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -1633,6
-rc4 and was compile-tested. It is available at
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git
platform_driver_probe_drop
Regards,
Wolfram
Wolfram Sang (9):
i2c: i2c-designware-platdrv: replace platform_driver_probe to support
deferred probing
i2c: i2c-imx: replace
On Tue, Sep 17, 2013 at 11:31:53AM -0500, Kim Phillips wrote:
commit d16933b33914a6dff38a4ecbe8edce44a17898e8 i2c: s3c2410: Move
location of clk_prepare_enable() call in probe function refactored
clk_enable and clk_disable calls yet neglected to remove the
clk_disable_unprepare call in the
On Wed, Aug 21, 2013 at 02:54:37PM +0530, Naveen Krishna Ch wrote:
Adds support for High Speed I2C driver found in Exynos5 and
later SoCs from Samsung.
Highspeed mode is a minor change in the i2c protocol.
Starts with
1. start condition,
2. 8-bit master ID code (1xxx)
3. followed by
On Thu, Aug 22, 2013 at 06:00:14PM +0200, Wolfram Sang wrote:
I2C of helpers used to live in of_i2c.c but experience (from SPI) shows
that it is much cleaner to have this in the core. This also removes a
circular dependency between the helpers and the core, and so we can
finally register child
. So, fix the drivers and documentation, too.
Acked-by: Rob Herring rob.herr...@calxeda.com
Reviewed-by: Felipe Balbi ba...@ti.com
Acked-by: Rafael J. Wysocki rafael.j.wyso...@intel.com
Tested-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
V2-V3
. So, fix the drivers and documentation, too.
Acked-by: Sylwester Nawrocki s.nawro...@amsung.com
Acked-by: Rob Herring rob.herr...@calxeda.com
Reviewed-by: Felipe Balbi ba...@ti.com
Acked-by: Rafael J. Wysocki rafael.j.wyso...@intel.com
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
V1 - V2
. So, fix the drivers and documentation, too.
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
Sigh, hitting the CC threshold on vger again. So resending to the lists only.
BTW this patch is based on -rc4 and was tested on an AT91 board. More tests
very welcome. Thanks!
Documentation/acpi
However this patch fails to apply onto either v3.11-rc4 or v3.11-rc6:
Argh, did not drop the MPC patch before rebasing :( So either pick the
patch i2c: powermac: fix return path on error before, pull the branch
[1], or force me to resend ;)
Thanks!
[1]
On Mon, Aug 19, 2013 at 09:46:04PM +0200, Thierry Reding wrote:
On Mon, Aug 19, 2013 at 07:59:40PM +0200, Wolfram Sang wrote:
[...]
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
[...]
+#if IS_ENABLED(CONFIG_OF)
+static void of_i2c_register_devices(struct i2c_adapter *adap
Once, we fix this problem. i planned to rebase and submit.
Is it okey with you?
Perfectly fine. Thanks for the heads up.
signature.asc
Description: Digital signature
On Mon, Jul 01, 2013 at 12:25:19PM +0200, Tomasz Figa wrote:
Hi Naveen,
Looks mostly good, but see some comments inline.
Ping?
signature.asc
Description: Digital signature
On Wed, Jun 19, 2013 at 04:18:25PM +0530, Naveen Krishna Chatradhi wrote:
Adds support for High Speed I2C driver found in Exynos5 and
later SoCs from Samsung.
Driver only supports Device Tree method.
Changes since v1:
1. Added FIFO functionality
2. Added High speed mode functionality
3.
Hi Naveen,
+Optional properties:
+ - samsung,hs-mode: Mode of operation, High speed or Fast speed mode. If not
+specified, default value is 0.
This was probably overlooked from my last review: Why can't you simply
enable hs-mode when clock-frequency is 1MBit?
+Example:
+
On Tue, May 21, 2013 at 01:38:23AM +0900, Kukjin Kim wrote:
On 05/16/13 20:15, Wolfram Sang wrote:
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sangw...@the-dreams.de
Looks good to me, applied into Samsung
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
arch/arm/plat-samsung/adc.c |5 -
1 file changed, 5 deletions(-)
diff --git a/arch/arm/plat-samsung/adc.c b/arch/arm/plat-samsung
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
drivers/i2c/busses/i2c-s3c2410.c |5 -
drivers/i2c/busses/i2c-sirf.c|6 --
drivers/i2c/busses/i2c-tegra.c |5
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
arch/arm/plat-samsung/adc.c |5 -
1 file changed, 5 deletions(-)
diff --git a/arch/arm/plat-samsung/adc.c b/arch/arm/plat-samsung
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
drivers/spi/spi-bcm63xx.c|8 +---
drivers/spi/spi-ep93xx.c |8 +---
drivers/spi/spi-omap2-mcspi.c|7
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
drivers/i2c/busses/i2c-davinci.c|6 +-
drivers/i2c/busses/i2c-designware-platdrv.c |6 +-
drivers/i2c/busses/i2c
Hi,
+ - Samsung GPIO variant (deprecated):
+- gpios: The order of the gpios should be the following: SDA, SCL.
+ The gpio specifier depends on the gpio controller.
Huh? Why should we support a deprecated method with a new driver?
This was left unanswered. I am curious.
On Fri, Apr 19, 2013 at 05:26:23PM +0530, Yuvaraj Kumar C D wrote:
This patch configure the High speed mode timing register using the
clock speed mentioned in the dts file.Also it configure the MASTER_ID
for High speed i2c transfer.
For i2c high speed transaction, tarnsaction initially starts
Hi,
thanks for the submission.
On Thu, Apr 04, 2013 at 09:52:01PM -0700, Naveen Krishna Chatradhi wrote:
From: Naveen Krishna Chatradhi ch.nav...@samsung.com
Adds support for High Speed I2C driver found in Exynos5 and
later SoCs from Samsung.
This driver currently supports Auto mode.
I don't know if that can happen, but if the block has length 0 (that is,
only consists of a single byte that is read as 0) the is_msglast() test
returns 0 which might be wrong. Maybe even if it cannot regularily
happen handle it in a sane way?
Length of 0 is illegal according to the specs,
On Thu, Apr 11, 2013 at 02:04:50AM +0200, Arnd Bergmann wrote:
No other file in the kernel besides i2c-s3c2410.c uses the current
plat/regs-iic.h, so we can simply move the header file to live in the
same directory as the driver, as a preparation to multiplatform builds.
What about putting
On Tue, Mar 26, 2013 at 07:59:56PM +0530, Prasanna Kumar wrote:
From: Jaemin Yoo jmin@samsung.com
SMBus read and write are supported by the emulation layer of i2c
framework if the controller doesn't have SMBus features.
I2C_M_RECV_LEN flag is used to let i2c drivers know rx length is
+ /* CLK_DIV max is 256 */
+ for (i = 0; i 256; i++) {
+ utemp1 = utemp0 / (i + 1);
+ /* SCLK_L/H max is 256 / 2 */
+ if (utemp1 128) {
I think TSCLK_L and TSCLK_H both can be configured upto 255.Why
limiting it to 128 ?
By
On Thu, Mar 21, 2013 at 03:09:25PM +0100, Heiko Stübner wrote:
The register definitions are only used in the driver itself.
This also removes the last dependency on plat/ includes from the
i2c driver.
Signed-off-by: Heiko Stuebner he...@sntech.de
Acked-by: Kukjin Kim kgene@samsung.com
On Mon, Mar 04, 2013 at 07:12:53PM +0530, Thomas Abraham wrote:
With device core now able to setup the default pin configuration,
the call to devm_pinctrl_get_select_default can be removed. And
the pin configuration code based on the deprecated Samsung specific
gpio bindings is also removed.
I'm not sure anymore ... probably some linux-next. I'll redo them on top of
your (i2c) for-next branch.
Thanks, but please use 3.9-rc3.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Fri, Mar 01, 2013 at 08:57:32AM -0800, Doug Anderson wrote:
The commit: i2c-core: dt: Pick i2c bus number from i2c alias if
present adds support for automatically picking the bus number based
on the alias ID. Remove the now unnecessary code from i2c-pxa that
did the same thing.
On Fri, Mar 01, 2013 at 08:57:31AM -0800, Doug Anderson wrote:
This allows you to get the equivalent functionality of
i2c_add_numbered_adapter() with all data in the device tree and no
special case code in your driver. This is a common device tree
technique.
For quick reference, the FDT
Doug Anderson (2):
i2c-core: dt: Pick i2c bus number from i2c alias if present
i2c: pxa: Use i2c-core to get bus number now
drivers/i2c/busses/i2c-pxa.c | 20
drivers/i2c/i2c-core.c | 54
2 files changed, 49
Hi Kukjin,
(please don't quote the whole patch for those few lines)
Looks good to me on this series:
Acked-by: Kukjin Kim kgene@samsung.com
Hi Wolfram, if you're ok on this, please pick up into your tree with my ack.
Will do, but not for 3.9 anymore. Thanks!
--
To unsubscribe from
Hi,
At the moment perhaps the strongest argument for why this particular
arbitration scheme is needed is that's what the EC (embedded
controller) on the ARM Chromebook uses. There have been several
arguments in-house about whether this was the most ideal way to
structure things, but
1 - 100 of 125 matches
Mail list logo
