Re: [PATCH v2 5/5] ARM: Exynos: Add basic dts file for Samsung Trats board
Hi Kgene,
On Saturday 08 of September 2012 11:47:15 Kukjin Kim wrote:
+ memory {
+ reg = 0x4000 0x2000
+ 0x6000 0x2000;
+ };
Why does this have to be split. Why not have a single entry with the
size as 0x4000?
The memory node corresponds to struct meminfo and each entry (with two
values) makes one struct membank defining a memory bank.
Well...
I've been talking with Kyungmin about this. Originally bootloaders used
to report 4 banks of 256 MiB, but it turned out that real bank
configuration on Trats is 2 banks of 512 MiB.
I think, following should ok here.
memory {
reg = 0x4000 0x4000;
};
This will not boot with CONFIG_SPARSEMEM, unless maximum section size is
increased to 1024MiB.
Probably, the interrupts can be listed when we have pinctrl driver
merged in Samsung tree.
Right.
Note, you can do it on top of samsung tree :-)
OK.
--
Best regards,
Tomasz Figa
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v2 5/5] ARM: Exynos: Add basic dts file for Samsung Trats board
Tomasz Figa wrote:
Hi,
Thanks for reviewing the patch.
On Wednesday 05 of September 2012 09:35:49 Thomas Abraham wrote:
+
+ memory {
+ reg = 0x4000 0x2000
+ 0x6000 0x2000;
+ };
Why does this have to be split. Why not have a single entry with the
size as 0x4000?
The memory node corresponds to struct meminfo and each entry (with two
values) makes one struct membank defining a memory bank.
Well...
I've been talking with Kyungmin about this. Originally bootloaders used to
report 4 banks of 256 MiB, but it turned out that real bank configuration
on Trats is 2 banks of 512 MiB.
I think, following should ok here.
memory {
reg = 0x4000 0x4000;
};
I'm not into memory management internals, so I don't know if this has any
significance, but I defined the node to represent the real configuration
(otherwise I would have probably used 4 banks of 256 MiB and drop the 4th
patch).
+ max8997_pmic@66 {
+ compatible = maxim,max8997-pmic;
+
+ reg = 0x66;
Probably, the interrupts can be listed when we have pinctrl driver
merged in Samsung tree.
Right.
Note, you can do it on top of samsung tree :-)
Thanks.
Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 5/5] ARM: Exynos: Add basic dts file for Samsung Trats board
This commit adds basic device tree for Exynos4210-based Trats board.
Currently it provides support for eMMC over sdhci and MAX8997 PMIC.
Signed-off-by: Tomasz Figa t.f...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
arch/arm/boot/dts/exynos4210-trats.dts | 237 +
arch/arm/mach-exynos/Makefile.boot | 2 +-
2 files changed, 238 insertions(+), 1 deletion(-)
create mode 100644 arch/arm/boot/dts/exynos4210-trats.dts
diff --git a/arch/arm/boot/dts/exynos4210-trats.dts
b/arch/arm/boot/dts/exynos4210-trats.dts
new file mode 100644
index 000..73567b8
--- /dev/null
+++ b/arch/arm/boot/dts/exynos4210-trats.dts
@@ -0,0 +1,237 @@
+/*
+ * Samsung's Exynos4210 based Trats board device tree source
+ *
+ * Copyright (c) 2012 Samsung Electronics Co., Ltd.
+ * http://www.samsung.com
+ *
+ * Device tree source file for Samsung's Trats board which is based on
+ * Samsung's Exynos4210 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+/dts-v1/;
+/include/ exynos4210.dtsi
+
+/ {
+ model = Samsung Trats based on Exynos4210;
+ compatible = samsung,trats, samsung,exynos4210;
+
+ memory {
+ reg = 0x4000 0x2000
+ 0x6000 0x2000;
+ };
+
+ chosen {
+ bootargs = console=ttySAC2,115200N8 root=/dev/mmcblk0p5
rootwait earlyprintk panic=5;
+ };
+
+ vemmc_reg: voltage-regulator@0 {
+ compatible = regulator-fixed;
+ regulator-name = VMEM_VDD_2.8V;
+ regulator-min-microvolt = 280;
+ regulator-max-microvolt = 280;
+ gpio = gpk0 2 1 0 0;
+ enable-active-high;
+ };
+
+ sdhci_emmc: sdhci@1251 {
+ bus-width = 8;
+ non-removable;
+ broken-voltage;
+ gpios = gpk0 0 2 0 3,
+ gpk0 1 2 0 3,
+ gpk0 3 2 2 3,
+ gpk0 4 2 2 3,
+ gpk0 5 2 2 3,
+ gpk0 6 2 2 3,
+ gpk1 3 3 3 3,
+ gpk1 4 3 3 3,
+ gpk1 5 3 3 3,
+ gpk1 6 3 3 3;
+ vmmc-supply = vemmc_reg;
+ status = okay;
+ };
+
+ serial@1380 {
+ status = okay;
+ };
+
+ serial@1381 {
+ status = okay;
+ };
+
+ serial@1382 {
+ status = okay;
+ };
+
+ serial@1383 {
+ status = okay;
+ };
+
+ i2c@138B {
+ samsung,i2c-sda-delay = 100;
+ samsung,i2c-slave-addr = 0x10;
+ samsung,i2c-max-bus-freq = 10;
+ gpios = gpb 6 3 3 0,
+ gpb 7 3 3 0;
+ status = okay;
+
+ max8997_pmic@66 {
+ compatible = maxim,max8997-pmic;
+
+ reg = 0x66;
+
+ max8997,pmic-buck1-uses-gpio-dvs;
+ max8997,pmic-buck2-uses-gpio-dvs;
+ max8997,pmic-buck5-uses-gpio-dvs;
+
+ max8997,pmic-ignore-gpiodvs-side-effect;
+ max8997,pmic-buck125-default-dvs-idx = 0;
+
+ max8997,pmic-buck125-dvs-gpios = gpx0 5 1 0 0,
+gpx0 6 1 0 0,
+gpl0 0 1 0 0;
+
+ max8997,pmic-buck1-dvs-voltage = 135, 130,
+125, 120,
+115, 110,
+100, 95;
+
+ max8997,pmic-buck2-dvs-voltage = 110, 100,
+95, 90,
+110, 100,
+95, 90;
+
+ max8997,pmic-buck5-dvs-voltage = 120, 120,
+120, 120,
+120, 120,
+120, 120;
+
+ regulators {
+ valive_reg: LDO2 {
+regulator-name = VALIVE_1.1V_C210;
+regulator-min-microvolt = 110;
+regulator-max-microvolt = 110;
+regulator-always-on;
+
Re: [PATCH v2 5/5] ARM: Exynos: Add basic dts file for Samsung Trats board
On 4 September 2012 14:20, Tomasz Figa t.f...@samsung.com wrote:
This commit adds basic device tree for Exynos4210-based Trats board.
Currently it provides support for eMMC over sdhci and MAX8997 PMIC.
Signed-off-by: Tomasz Figa t.f...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
arch/arm/boot/dts/exynos4210-trats.dts | 237
+
arch/arm/mach-exynos/Makefile.boot | 2 +-
2 files changed, 238 insertions(+), 1 deletion(-)
create mode 100644 arch/arm/boot/dts/exynos4210-trats.dts
diff --git a/arch/arm/boot/dts/exynos4210-trats.dts
b/arch/arm/boot/dts/exynos4210-trats.dts
new file mode 100644
index 000..73567b8
--- /dev/null
+++ b/arch/arm/boot/dts/exynos4210-trats.dts
@@ -0,0 +1,237 @@
+/*
+ * Samsung's Exynos4210 based Trats board device tree source
+ *
+ * Copyright (c) 2012 Samsung Electronics Co., Ltd.
+ * http://www.samsung.com
+ *
+ * Device tree source file for Samsung's Trats board which is based on
+ * Samsung's Exynos4210 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+/dts-v1/;
+/include/ exynos4210.dtsi
+
+/ {
+ model = Samsung Trats based on Exynos4210;
+ compatible = samsung,trats, samsung,exynos4210;
+
+ memory {
+ reg = 0x4000 0x2000
+ 0x6000 0x2000;
+ };
Why does this have to be split. Why not have a single entry with the
size as 0x4000?
+
+ chosen {
+ bootargs = console=ttySAC2,115200N8 root=/dev/mmcblk0p5
rootwait earlyprintk panic=5;
+ };
+
+ vemmc_reg: voltage-regulator@0 {
+ compatible = regulator-fixed;
+ regulator-name = VMEM_VDD_2.8V;
+ regulator-min-microvolt = 280;
+ regulator-max-microvolt = 280;
+ gpio = gpk0 2 1 0 0;
+ enable-active-high;
+ };
+
+ sdhci_emmc: sdhci@1251 {
+ bus-width = 8;
+ non-removable;
+ broken-voltage;
+ gpios = gpk0 0 2 0 3,
+ gpk0 1 2 0 3,
+ gpk0 3 2 2 3,
+ gpk0 4 2 2 3,
+ gpk0 5 2 2 3,
+ gpk0 6 2 2 3,
+ gpk1 3 3 3 3,
+ gpk1 4 3 3 3,
+ gpk1 5 3 3 3,
+ gpk1 6 3 3 3;
+ vmmc-supply = vemmc_reg;
+ status = okay;
+ };
+
+ serial@1380 {
+ status = okay;
+ };
+
+ serial@1381 {
+ status = okay;
+ };
+
+ serial@1382 {
+ status = okay;
+ };
+
+ serial@1383 {
+ status = okay;
+ };
+
+ i2c@138B {
+ samsung,i2c-sda-delay = 100;
+ samsung,i2c-slave-addr = 0x10;
+ samsung,i2c-max-bus-freq = 10;
+ gpios = gpb 6 3 3 0,
+ gpb 7 3 3 0;
+ status = okay;
+
+ max8997_pmic@66 {
+ compatible = maxim,max8997-pmic;
+
+ reg = 0x66;
Probably, the interrupts can be listed when we have pinctrl driver
merged in Samsung tree.
+
+ max8997,pmic-buck1-uses-gpio-dvs;
+ max8997,pmic-buck2-uses-gpio-dvs;
+ max8997,pmic-buck5-uses-gpio-dvs;
+
+ max8997,pmic-ignore-gpiodvs-side-effect;
+ max8997,pmic-buck125-default-dvs-idx = 0;
+
+ max8997,pmic-buck125-dvs-gpios = gpx0 5 1 0 0,
+gpx0 6 1 0 0,
+gpl0 0 1 0 0;
+
+ max8997,pmic-buck1-dvs-voltage = 135, 130,
+125, 120,
+115, 110,
+100, 95;
+
+ max8997,pmic-buck2-dvs-voltage = 110, 100,
+95, 90,
+110, 100,
+95, 90;
+
+ max8997,pmic-buck5-dvs-voltage = 120, 120,
+120, 120,
+120, 120,
+120, 120;
+
+
Re: [PATCH v2 5/5] ARM: Exynos: Add basic dts file for Samsung Trats board
Hi,
Thanks for reviewing the patch.
On Wednesday 05 of September 2012 09:35:49 Thomas Abraham wrote:
+
+ memory {
+ reg = 0x4000 0x2000
+ 0x6000 0x2000;
+ };
Why does this have to be split. Why not have a single entry with the
size as 0x4000?
The memory node corresponds to struct meminfo and each entry (with two
values) makes one struct membank defining a memory bank.
I've been talking with Kyungmin about this. Originally bootloaders used to
report 4 banks of 256 MiB, but it turned out that real bank configuration
on Trats is 2 banks of 512 MiB.
I'm not into memory management internals, so I don't know if this has any
significance, but I defined the node to represent the real configuration
(otherwise I would have probably used 4 banks of 256 MiB and drop the 4th
patch).
+ max8997_pmic@66 {
+ compatible = maxim,max8997-pmic;
+
+ reg = 0x66;
Probably, the interrupts can be listed when we have pinctrl driver
merged in Samsung tree.
Right.
--
Best regards,
Tomasz Figa
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
