Re: [PATCH v2 1/5] mmc: host: sdhci-s3c: Add broken-voltage DT property for broken voltage quirk

2012-09-19 Thread Tomasz Figa
Hi Chris, On Wednesday 19 of September 2012 01:42:01 Chris Ball wrote: On Tue, Sep 04 2012, Tomasz Figa wrote: Some boards use fixed voltage regulator for vmmc supply (e.g. for eMMC memories). MMC_CAP2_BROKEN_VOLTAGE must be enabled for them to operate correctly. Is there a reason we

Re: [PATCH v2 1/5] mmc: host: sdhci-s3c: Add broken-voltage DT property for broken voltage quirk

2012-09-19 Thread Chris Ball
Hi Tomasz, On Wed, Sep 19 2012, Tomasz Figa wrote: Hi Chris, On Wednesday 19 of September 2012 01:42:01 Chris Ball wrote: On Tue, Sep 04 2012, Tomasz Figa wrote: Some boards use fixed voltage regulator for vmmc supply (e.g. for eMMC memories). MMC_CAP2_BROKEN_VOLTAGE must be enabled for

Re: [PATCH v2 1/5] mmc: host: sdhci-s3c: Add broken-voltage DT property for broken voltage quirk

2012-09-19 Thread Chris Ball
Hi, On Wed, Sep 19 2012, Tomasz Figa wrote: We could just check if the regulator provides the capability to change the voltage. I don't see any direct way of querying the regulator for provided capabilities (correct me if I'm just blind), but calling regulator_count_voltages() on the

Re: [PATCH v2 1/5] mmc: host: sdhci-s3c: Add broken-voltage DT property for broken voltage quirk

2012-09-19 Thread Jaehoon Chung
On 09/19/2012 11:39 PM, Chris Ball wrote: Hi, On Wed, Sep 19 2012, Jaehoon Chung wrote: On Wed, Sep 19 2012, Tomasz Figa wrote: We could just check if the regulator provides the capability to change the voltage. I don't see any direct way of querying the regulator for provided

Re: [PATCH v2 1/5] mmc: host: sdhci-s3c: Add broken-voltage DT property for broken voltage quirk

2012-09-05 Thread Jaehoon Chung
Acked-by: Jaehoon Chung jh80.ch...@samsung.com On 09/04/2012 05:50 PM, Tomasz Figa wrote: Some boards use fixed voltage regulator for vmmc supply (e.g. for eMMC memories). MMC_CAP2_BROKEN_VOLTAGE must be enabled for them to operate correctly. Cc: Ben Dooks ben-li...@fluff.org Cc: Chris

[PATCH v2 1/5] mmc: host: sdhci-s3c: Add broken-voltage DT property for broken voltage quirk

2012-09-04 Thread Tomasz Figa
Some boards use fixed voltage regulator for vmmc supply (e.g. for eMMC memories). MMC_CAP2_BROKEN_VOLTAGE must be enabled for them to operate correctly. Cc: Ben Dooks ben-li...@fluff.org Cc: Chris Ball c...@laptop.org CC: linux-...@vger.kernel.org Signed-off-by: Tomasz Figa t.f...@samsung.com