Re: [PATCH v3 6/6] mfd: cros_ec: Instantiate sub-devices from device tree

2014-09-29 Thread Javier Martinez Canillas
Hello Lee, On 09/25/2014 04:48 PM, Lee Jones wrote: On Thu, 25 Sep 2014, Javier Martinez Canillas wrote: Understood, that's why I dropped this since as explained earlier, it makes more sense to include this change once the cros_ec_dev driver is pushed to upstream. The last version of

Re: [PATCH v3 6/6] mfd: cros_ec: Instantiate sub-devices from device tree

2014-09-26 Thread Lee Jones
On Thu, 25 Sep 2014, Javier Martinez Canillas wrote: On 09/25/2014 04:48 PM, Lee Jones wrote: On Thu, 25 Sep 2014, Javier Martinez Canillas wrote: The last version of the series (v4) I posted a week ago [0], does not include this patch so I hope the series can be picked for 3.18

Re: [PATCH v3 6/6] mfd: cros_ec: Instantiate sub-devices from device tree

2014-09-26 Thread Javier Martinez Canillas
On 09/26/2014 09:21 AM, Lee Jones wrote: On Thu, 25 Sep 2014, Javier Martinez Canillas wrote: Unfortunately this is going to have to wait until v3.19 now, as Linus is closing the -rcs early. I have subsequently applied my last patch to the MFD tree for v3.18. It will be good for these

Re: [PATCH v3 6/6] mfd: cros_ec: Instantiate sub-devices from device tree

2014-09-25 Thread Javier Martinez Canillas
Hello Lee, On 09/19/2014 02:15 AM, Lee Jones wrote: As explained above, DT, non-DT and x86 platforms instantiate the cros-ec-dev cells but DT platforms can define other child nodes. But I can remove the conditional if you want and reintroduce it once cros-ec-dev support is added. Yes,

Re: [PATCH v3 6/6] mfd: cros_ec: Instantiate sub-devices from device tree

2014-09-25 Thread Lee Jones
On Thu, 25 Sep 2014, Javier Martinez Canillas wrote: Hello Lee, On 09/19/2014 02:15 AM, Lee Jones wrote: As explained above, DT, non-DT and x86 platforms instantiate the cros-ec-dev cells but DT platforms can define other child nodes. But I can remove the conditional if you want

Re: [PATCH v3 6/6] mfd: cros_ec: Instantiate sub-devices from device tree

2014-09-25 Thread Javier Martinez Canillas
On 09/25/2014 04:48 PM, Lee Jones wrote: On Thu, 25 Sep 2014, Javier Martinez Canillas wrote: The last version of the series (v4) I posted a week ago [0], does not include this patch so I hope the series can be picked for 3.18 since most of the patches were already acked by you.

Re: [PATCH v3 6/6] mfd: cros_ec: Instantiate sub-devices from device tree

2014-09-18 Thread Javier Martinez Canillas
Hello Lee, On 09/17/2014 06:31 PM, Lee Jones wrote: -static const struct mfd_cell cros_devs[] = { -{ -.name = cros-ec-keyb, -.id = 1, -.of_compatible = google,cros-ec-keyb, -}, -{ -.name = cros-ec-i2c-tunnel, -.id

Re: [PATCH v3 6/6] mfd: cros_ec: Instantiate sub-devices from device tree

2014-09-18 Thread Lee Jones
On Thu, 18 Sep 2014, Javier Martinez Canillas wrote: Hello Lee, On 09/17/2014 06:31 PM, Lee Jones wrote: -static const struct mfd_cell cros_devs[] = { - { - .name = cros-ec-keyb, - .id = 1, - .of_compatible = google,cros-ec-keyb, - }, - { -

Re: [PATCH v3 6/6] mfd: cros_ec: Instantiate sub-devices from device tree

2014-09-17 Thread Lee Jones
On Thu, 11 Sep 2014, Javier Martinez Canillas wrote: From: Todd Broch tbr...@chromium.org If the EC device tree node has sub-nodes, try to instantiate them as MFD sub-devices. We can configure the EC features provided by the board. Signed-off-by: Todd Broch tbr...@chromium.org

[PATCH v3 6/6] mfd: cros_ec: Instantiate sub-devices from device tree

2014-09-11 Thread Javier Martinez Canillas
From: Todd Broch tbr...@chromium.org If the EC device tree node has sub-nodes, try to instantiate them as MFD sub-devices. We can configure the EC features provided by the board. Signed-off-by: Todd Broch tbr...@chromium.org Signed-off-by: Javier Martinez Canillas