RE: [PATCH] ARM: SAMSUNG: Add clk enable/disable of pwm

2011-11-03 Thread Kukjin Kim
Joonyoung Shim wrote: 11/03/2011 10:59 AM, Kukjin Kim 쓴 글: Joonyoung Shim wrote: PWM timers use pclk(timers clk) as parent clk. If this pclk is the disabled state when PWM driver is probed, then it causes wrong read and write operation about registers of PWM. Signed-off-by:

Re: [PATCH] ARM: SAMSUNG: Add clk enable/disable of pwm

2011-11-03 Thread Joonyoung Shim
11/03/2011 04:46 PM, Kukjin Kim 쓴 글: Joonyoung Shim wrote: 11/03/2011 10:59 AM, Kukjin Kim 쓴 글: Joonyoung Shim wrote: PWM timers use pclk(timers clk) as parent clk. If this pclk is the disabled state when PWM driver is probed, then it causes wrong read and write operation about registers of

Re: [PATCH] ARM: SAMSUNG: Add clk enable/disable of pwm

2011-11-03 Thread Kyungmin Park
On 11/3/11, Joonyoung Shim jy0922.s...@samsung.com wrote: 11/03/2011 04:46 PM, Kukjin Kim 쓴 글: Joonyoung Shim wrote: 11/03/2011 10:59 AM, Kukjin Kim 쓴 글: Joonyoung Shim wrote: PWM timers use pclk(timers clk) as parent clk. If this pclk is the disabled state when PWM driver is probed, then it

Re: [PATCH] ARM: SAMSUNG: Add clk enable/disable of pwm

2011-11-03 Thread Kyungmin Park
On 11/3/11, Kyungmin Park kyungmin.p...@samsung.com wrote: On 11/3/11, Joonyoung Shim jy0922.s...@samsung.com wrote: 11/03/2011 04:46 PM, Kukjin Kim 쓴 글: Joonyoung Shim wrote: 11/03/2011 10:59 AM, Kukjin Kim 쓴 글: Joonyoung Shim wrote: PWM timers use pclk(timers clk) as parent clk. If this

RE: [PATCH] ARM: SAMSUNG: Add clk enable/disable of pwm

2011-11-03 Thread Kukjin Kim
Kyungmin Park wrote: On 11/3/11, Kyungmin Park kyungmin.p...@samsung.com wrote: On 11/3/11, Joonyoung Shim jy0922.s...@samsung.com wrote: 11/03/2011 04:46 PM, Kukjin Kim 쓴 글: Joonyoung Shim wrote: 11/03/2011 10:59 AM, Kukjin Kim 쓴 글: Joonyoung Shim wrote: PWM timers use pclk(timers

Re: [PATCH] ARM: SAMSUNG: Add clk enable/disable of pwm

2011-11-03 Thread Russell King - ARM Linux
On Thu, Nov 03, 2011 at 06:08:03PM +0900, Kukjin Kim wrote: diff --git a/arch/arm/plat-samsung/pwm-clock.c b/arch/arm/plat-samsung/pwm-clock.c index a35ff3b..37a159b 100644 --- a/arch/arm/plat-samsung/pwm-clock.c +++ b/arch/arm/plat-samsung/pwm-clock.c @@ -449,6 +449,8 @@ __init void

Re: [PATCH] ARM: SAMSUNG: Add clk enable/disable of pwm

2011-11-03 Thread Kyungmin Park
On 11/3/11, Kukjin Kim kgene@samsung.com wrote: Kyungmin Park wrote: On 11/3/11, Kyungmin Park kyungmin.p...@samsung.com wrote: On 11/3/11, Joonyoung Shim jy0922.s...@samsung.com wrote: 11/03/2011 04:46 PM, Kukjin Kim 쓴 글: Joonyoung Shim wrote: 11/03/2011 10:59 AM, Kukjin Kim 쓴 글:

Re: [PATCH] ARM: SAMSUNG: Add clk enable/disable of pwm

2011-11-03 Thread Joonyoung Shim
11/03/2011 06:08 PM, Kukjin Kim 쓴 글: Kyungmin Park wrote: On 11/3/11, Kyungmin Parkkyungmin.p...@samsung.com wrote: On 11/3/11, Joonyoung Shimjy0922.s...@samsung.com wrote: 11/03/2011 04:46 PM, Kukjin Kim 쓴 글: Joonyoung Shim wrote: 11/03/2011 10:59 AM, Kukjin Kim 쓴 글: Joonyoung Shim

RE: [PATCH] ARM: SAMSUNG: Add clk enable/disable of pwm

2011-11-03 Thread Kukjin Kim
Joonyoung Shim wrote: 11/03/2011 06:08 PM, Kukjin Kim 쓴 글: Kyungmin Park wrote: On 11/3/11, Kyungmin Parkkyungmin.p...@samsung.com wrote: On 11/3/11, Joonyoung Shimjy0922.s...@samsung.com wrote: 11/03/2011 04:46 PM, Kukjin Kim 쓴 글: Joonyoung Shim wrote: 11/03/2011 10:59 AM, Kukjin

RE: [PATCH] ARM: SAMSUNG: Add clk enable/disable of pwm

2011-11-02 Thread Kukjin Kim
Joonyoung Shim wrote: PWM timers use pclk(timers clk) as parent clk. If this pclk is the disabled state when PWM driver is probed, then it causes wrong read and write operation about registers of PWM. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Signed-off-by: Kyungmin Park

Re: [PATCH] ARM: SAMSUNG: Add clk enable/disable of pwm

2011-11-02 Thread Joonyoung Shim
11/03/2011 10:59 AM, Kukjin Kim 쓴 글: Joonyoung Shim wrote: PWM timers use pclk(timers clk) as parent clk. If this pclk is the disabled state when PWM driver is probed, then it causes wrong read and write operation about registers of PWM. Signed-off-by: Joonyoung Shimjy0922.s...@samsung.com