Re: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD

2010-11-12 Thread Paul Mundt
nux-arm-ker...@lists.infradead.org; > > linux-samsung-soc@vger.kernel.org; linux-fb...@vger.kernel.org; ben- > > li...@fluff.org; a...@linux-foundation.org; 'Jonghun Han' > > Subject: Re: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD > > > > On Fri, Nov 12,

RE: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD

2010-11-12 Thread Inki Dae
ger.kernel.org; ben- > li...@fluff.org; a...@linux-foundation.org; 'Jonghun Han' > Subject: Re: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD > > On Fri, Nov 12, 2010 at 06:54:29PM +0900, Inki Dae wrote: > > @@ -1314,13 +1319,22 @@ static int __devinit s3c_fb_probe(stru

Re: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD

2010-11-12 Thread Paul Mundt
On Fri, Nov 12, 2010 at 06:54:29PM +0900, Inki Dae wrote: > @@ -1314,13 +1319,22 @@ static int __devinit s3c_fb_probe(struct > platform_device *pdev) > sfb->pdata = pd; > sfb->variant = fbdrv->variant; > > - sfb->bus_clk = clk_get(dev, "lcd"); > - if (IS_ERR(sfb->bus_clk)) { >

RE: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD

2010-11-12 Thread Inki Dae
Message- > From: linux-fbdev-ow...@vger.kernel.org [mailto:linux-fbdev- > ow...@vger.kernel.org] On Behalf Of Kukjin Kim > Sent: Friday, November 12, 2010 2:26 PM > To: 'Sangbeom Kim'; linux-arm-ker...@lists.infradead.org; linux-samsung- > s...@vger.kernel.org; linux-fb.

RE: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD

2010-11-11 Thread Kukjin Kim
Sangbeom Kim wrote: > > From: Jonghun Han > > This patch adds s3c_fb_driverdata for S5PV310 FIMD0. The clk_type is added > to distinguish clock type in structure s3c_fb_variant and lcd_clk is added > in structure s3c_fb to calculate divider for lcd panel. > FIMD can handles two clocks. The one i

Re: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD

2010-10-25 Thread han jonghun
Hi, Thanks for comment. [snip] >> > >> > I don't think that the driver is the right place to change the parent of >> > the sclk_fimd >> > clock. It should be done in the boot loader or the board startup code. >> > >> >> As you know, there are two clock sources for LCD pixel clock. >> s3c-fb only

RE: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD

2010-10-20 Thread Inki Dae
'Sangbeom Kim'; linux-arm- > ker...@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux- > fb...@vger.kernel.org > Cc: a...@linux-foundation.org; kgene@samsung.com; ben-li...@fluff.org; > kyungmin.p...@samsung.com > Subject: RE: [PATCH 3/4] s3c-fb:

RE: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD

2010-10-20 Thread Jonghun Han
m'; linux-arm-ker...@lists.infradead.org; linux-samsung- > s...@vger.kernel.org; linux-fb...@vger.kernel.org > Cc: 'Jonghun Han'; a...@linux-foundation.org; kgene@samsung.com; ben- > li...@fluff.org; kyungmin.p...@samsung.com > Subject: RE: [PATCH 3/4] s3c-fb: Add su

RE: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD

2010-10-19 Thread Marek Szyprowski
1AFAAVgAzADEAMAAgAEY ASQBNAEQA x-cr-puzzleid: {C4CCB40E-D5C6-4119-AA7C-BBBA7A1503E4} Hello, On Monday, October 18, 2010 2:55 PM Sangbeom Kim wrote: > From: Jonghun Han > > This patch adds s3c_fb_driverdata for S5PV310 FIMD0. The clk_type is added > to distinguish clock type in structur