RE: [PATCH 3/3] ASoC: follow the updated samsung DMA common operations

2012-06-19 Thread Boojin Kim
Mark Brown wrote This patch uses config() function to configure DMA transmit options. Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com It'd be good if we could get all the older Samsung platforms moved over to dmaengine... Thanks for your ack :) And, Our engineer's preparing to

RE: [PATCH 3/3] ASoC: follow the updated samsung DMA common operations

2012-06-19 Thread Kukjin Kim
Boojin Kim wrote: Mark Brown wrote This patch uses config() function to configure DMA transmit options. Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com Thanks for your ack and let me pick this up in Samsung tree. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com,

RE: [PATCH] ARM: S3C64XX: Add IRQ mapping for wm0010 on Cragganmore

2012-06-19 Thread Kukjin Kim
Dimitris Papastamos wrote: Signed-off-by: Dimitris Papastamos d...@opensource.wolfsonmicro.com --- arch/arm/mach-s3c64xx/mach-crag6410-module.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-s3c64xx/mach-crag6410-module.c b/arch/arm/mach-

RE: [PATCH 1/2] ARM: S3C64XX: Add module identification for Balblair Cragganmore module

2012-06-19 Thread Kukjin Kim
Mark Brown wrote: Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- arch/arm/mach-s3c64xx/mach-crag6410-module.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-s3c64xx/mach-crag6410-module.c b/arch/arm/mach- s3c64xx/mach-crag6410-module.c index

RE: [PATCH 2/2] ARM: S3C64XX: Dynamically assign interrupts for CPU PMIC on Cragganmore

2012-06-19 Thread Kukjin Kim
Mark Brown wrote: Now that the WM831x driver uses irq_domain we can happily allow it to assign its own IRQs. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- arch/arm/mach-s3c64xx/include/mach/crag6410.h |3 +-- arch/arm/mach-s3c64xx/mach-crag6410.c |1 -

RE: arch/arm/mach-s3c2410/Kconfig is unsourced

2012-06-19 Thread Kukjin Kim
Paul Bolle wrote: On Tue, 2012-04-24 at 17:05 -0700, Kukjin Kim wrote: Paul Bolle wrote: 0) commit 85fd6d63bf2927b9da7ab1b0d46723bfdb13808c (ARM: S3C2410: move mach-s3c2410/* into mach-s3c24xx/) orphaned arch/arm/mach-s3c2410/Kconfig: currently nothing sources that file in Linus'

RE: [PATCH] ARM: s3c24xx: remove unused header

2012-06-19 Thread Kukjin Kim
Paul Bolle wrote: Since (at least) v2.6.12-rc2 there has been a bast-pmu.h header in the tree. Currently it can be found at arch/arm/mach-s3c24xx/include/mach/bast-pmu.h. It seems that during that entire period nothing included that header and that none of the named constants it provided

RE: [PATCH 1/1] ARM: EXYNOS: Update keypad entries for SMDK4X12

2012-06-19 Thread Kukjin Kim
Sachin Kamat wrote: Keypad entries are updated as per the latest revision of the board. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/mach-exynos/mach-smdk4x12.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git

RE: [PATCH-Resend 2/2] ARM: EXYNOS: Add HSOTG support to SMDK4X12

2012-06-19 Thread Kukjin Kim
Sachin Kamat wrote: S3C-HSOTG support is added to SMDK4212 and SMDK4412 boards. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/mach-exynos/Kconfig |2 ++ arch/arm/mach-exynos/mach-smdk4x12.c |8 2 files changed, 10 insertions(+), 0 deletions(-)

RE: [PATCH 1/1] ARM: S3C24XX: Remove duplicate header file inclusion

2012-06-19 Thread Kukjin Kim
Sachin Kamat wrote: regs-clock.h header file was included twice. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/mach-s3c24xx/common.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-s3c24xx/common.c b/arch/arm/mach-

RE: [PATCH 1/2] serial: samsung: Remove NULL checking for baud clock

2012-06-19 Thread Kukjin Kim
Kyoungil Kim wrote: Kyoungil Kim wrote: I missed following. Russell King suggested: As I said, drivers have no business interpreting anything but IS_ERR(clk) as being an error. They should not make any other assumptions. Suggested-by: Russell King rmk+ker...@arm.linux.org.uk

RE: [PATCH 1/1] ARM: S5PC100: Remove unused variable in dma.c file

2012-06-19 Thread Kukjin Kim
Sachin Kamat wrote: Fixes the following warning: arch/arm/mach-s5pc100/dma.c:36:12: warning: ‘dma_dmamask’ defined but not used [-Wunused-variable] Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/mach-s5pc100/dma.c |2 -- 1 files changed, 0 insertions(+), 2

RE: [PATCH 1/1] ARM: S5P64X0: Remove unused variable in dma.c file

2012-06-19 Thread Kukjin Kim
Sachin Kamat wrote: Fixes the following warning: arch/arm/mach-s5p64x0/dma.c:39:12: warning: ‘dma_dmamask’ defined but not used [-Wunused-variable] Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/mach-s5p64x0/dma.c |2 -- 1 files changed, 0 insertions(+), 2

RE: [PATCH 1/1] ARM: SAMSUNG: Remove description corresponding to a deleted element

2012-06-19 Thread Kukjin Kim
Sachin Kamat wrote: Commit 3c582647a9f84affd5c86e89d548157c62f8d9ca removed the default_win In this case, 8 or 12 digits commit id is enough and please explain the subject like following next time. Commit 3c582647a9f8 (video: s3c-fb: remove 'default_win' element from platform data)...

RE: [PATCH-Resend 1/2] ARM: EXYNOS: Update HSOTG PHY clock setting for Exynos4x12

2012-06-19 Thread Kukjin Kim
Sachin Kamat wrote: Adds clock setting entries for Exynos4212 and Exynos4412 platforms. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/mach-exynos/include/mach/regs-usb-phy.h | 20 ++-- arch/arm/mach-exynos/setup-usb-phy.c | 55 -

RE: [PATCH 1/3] ARM: SAMSUNG: Add config() function in DMA common operations

2012-06-19 Thread Kukjin Kim
Boojin Kim wrote: This patch adds config() that configures DMA transmit option. This function was originally included in request(). But, Some DMA client driver requires to change the configuration after request(). So, This patch picks up it from request(). Signed-off-by: Boojin Kim

RE: [PATCH] ARM: exynos: add UART3 to DEBUG_LL ports

2012-06-19 Thread Kukjin Kim
Olof Johansson wrote: Add support for using UART3 for DEBUG_LL on exynos. Signed-off-by: Olof Johansson o...@lixom.net --- arch/arm/Kconfig.debug| 11 +++ arch/arm/plat-samsung/Kconfig | 1 + 2 files changed, 12 insertions(+) diff --git a/arch/arm/Kconfig.debug

RE: [PATCH] ARM: exynos: enable more platforms in defconfig

2012-06-19 Thread Kukjin Kim
Olof Johansson wrote: Hi Olof, Sorry for late reply on this, I came back from travelling, anyway. This enables the new EXYNOS5 platforms in the defconfig, and enables DT support on EXYNOS4. Yes, agree, it's time to move on new defconfig for supporting DT. While I'm at it, I renamed it

Re: [PATCH-Resend 1/2] ARM: EXYNOS: Update HSOTG PHY clock setting for Exynos4x12

2012-06-19 Thread Sachin Kamat
On 19/06/2012, Kukjin Kim kgene@samsung.com wrote: Sachin Kamat wrote: Adds clock setting entries for Exynos4212 and Exynos4412 platforms. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/mach-exynos/include/mach/regs-usb-phy.h | 20 ++--

Re: [PATCH-Resend 2/2] ARM: EXYNOS: Add HSOTG support to SMDK4X12

2012-06-19 Thread Sachin Kamat
On 19/06/2012, Kukjin Kim kgene@samsung.com wrote: Sachin Kamat wrote: S3C-HSOTG support is added to SMDK4212 and SMDK4412 boards. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/mach-exynos/Kconfig |2 ++ arch/arm/mach-exynos/mach-smdk4x12.c |8

Re: [PATCH 1/1] ARM: SAMSUNG: Remove description corresponding to a deleted element

2012-06-19 Thread Sachin Kamat
On 19/06/2012, Kukjin Kim kgene@samsung.com wrote: Sachin Kamat wrote: Commit 3c582647a9f84affd5c86e89d548157c62f8d9ca removed the default_win In this case, 8 or 12 digits commit id is enough and please explain the subject like following next time. Ok. Commit 3c582647a9f8 (video:

RE: [PATCH] ARM: S3C64XX: Add IRQ mapping for wm0010 on Cragganmore

2012-06-19 Thread Kukjin Kim
Kukjin Kim wrote: Dimitris Papastamos wrote: Signed-off-by: Dimitris Papastamos d...@opensource.wolfsonmicro.com --- arch/arm/mach-s3c64xx/mach-crag6410-module.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-s3c64xx/mach-crag6410-module.c b/arch/arm/mach-

RE: [PATCH v2] ARM: EXYNOS: add FIMD1 support for EXYNOS5

2012-06-19 Thread Kukjin Kim
Jingoo Han wrote: This patch adds platform device s5p_device_fimd1 for EXYNOS FIMD1. EXYNOS has two FIMDs(FIMD0, FIMD1). Some definitions used to enable EXYNOS FIMD1 are added. This patch also adds resource definitions for EXYNOS5 FIMD1. FIMD1 clock and SFR definitions are added.

RE: [PATCH-Resend 1/2] ARM: EXYNOS: Update HSOTG PHY clock setting for Exynos4x12

2012-06-19 Thread Kukjin Kim
Sachin Kamat wrote: On 19/06/2012, Kukjin Kim kgene@samsung.com wrote: Sachin Kamat wrote: Adds clock setting entries for Exynos4212 and Exynos4412 platforms. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/mach-exynos/include/mach/regs-usb-phy.h | 20

RE: [PATCH 1/2] serial: samsung: Remove NULL checking for baud clock

2012-06-19 Thread Kukjin Kim
Kukjin Kim wrote: Kyoungil Kim wrote: Kyoungil Kim wrote: I missed following. Russell King suggested: As I said, drivers have no business interpreting anything but IS_ERR(clk) as being an error. They should not make any other assumptions. Suggested-by: Russell King

RE: [PATCH 2/2] serial: samsung: Fixed wrong comparison for baudclk_rate

2012-06-19 Thread Kukjin Kim
Kyoungil Kim wrote: port-baudclk_rate should be compared to the rate of port-baudclk, because port-baudclk_rate was assigned as the rate of port-baudclk previously. So to check that the current baudclk rate is same as previous rate, the target of comparison sholud be the rate of

RE: [PATCH] serial: samsung: protect NULL dereference of clock name

2012-06-19 Thread Kukjin Kim
Kyoungil Kim wrote: From: KeyYoung Park keyyoung.p...@samsung.com When priting the serial clock source, if clock source name is null, kernel reference NULL point. Signed-off-by: KeyYoung Park keyyoung.p...@samsung.com Signed-off-by: Huisung Kang hs1218.k...@samsung.com Signed-off-by:

[PATCH 1/1] ARM: SAMSUNG: Fix compilation error

2012-06-19 Thread Sachin Kamat
Fixes the following build error: In file included from arch/arm/mach-exynos/include/mach/dma.h:24:0, from arch/arm/plat-samsung/include/plat/dma-ops.h:17, from arch/arm/plat-samsung/include/plat/dma.h:128, from sound/soc/samsung/pcm.c:23:

[PATCH 1/2][Resend] ARM: EXYNOS: Update HSOTG PHY clock setting for Exynos4x12

2012-06-19 Thread Sachin Kamat
Adds clock setting entries for Exynos4212 and Exynos4412 platforms. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- Based on v3.5-for-usb-2 branch of Kukjin's tree --- arch/arm/mach-exynos/include/mach/regs-usb-phy.h | 20 ++-- arch/arm/mach-exynos/setup-usb-phy.c |

[PATCH 2/2][Resend] ARM: EXYNOS: Add HSOTG support to SMDK4X12

2012-06-19 Thread Sachin Kamat
S3C-HSOTG support is added to SMDK4212 and SMDK4412 boards. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- Based on v3.5-for-usb-2 branch of Kukjin's tree --- arch/arm/mach-exynos/Kconfig |2 ++ arch/arm/mach-exynos/mach-smdk4x12.c |7 +++ 2 files changed, 9

RE: [PATCH] ARM: remove unused SPI clock headers

2012-06-19 Thread Kukjin Kim
Paul Bolle wrote: Commit 875a59374cd10200ac24f03877ccd8f73af590cc (ARM: SAMSUNG: Consolidation of SPI platform devices to plat-samsung) deleted all (four) files that included one of the spi-clocks.h headers. It seems it was just an oversight to not remove those headers too. They can safely

RE: [PATCH 3/3] ARM: S5PV210: Add HSOTG support to SMDKV210

2012-06-19 Thread Kukjin Kim
Sachin Kamat wrote: Adds S3C-HSOTG support to SMDKV210 board. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/mach-s5pv210/Kconfig |2 ++ arch/arm/mach-s5pv210/mach-smdkv210.c |8 2 files changed, 10 insertions(+), 0 deletions(-) diff --git

Re: [PATCH 3/3] ARM: S5PV210: Add HSOTG support to SMDKV210

2012-06-19 Thread Sachin Kamat
On 20/06/2012, Kukjin Kim kgene@samsung.com wrote: Sachin Kamat wrote: Adds S3C-HSOTG support to SMDKV210 board. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/mach-s5pv210/Kconfig |2 ++ arch/arm/mach-s5pv210/mach-smdkv210.c |8 2 files