Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-08-11 Thread Ulf Hansson
On 5 August 2014 03:19, Sonny Rao sonny...@chromium.org wrote: This patch changes the fifo reset code to follow the reset procedure outlined in the documentation of Synopsys Mobile storage host databook. Signed-off-by: Sonny Rao sonny...@chromium.org Signed-off-by: Yuvaraj Kumar C D

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-08-07 Thread Jaehoon Chung
Hi, I remembered that this patch was pushed at Ulf's tree. Since dw_mci_idmac_reset() is located into #if CONFIG_MMC_DW_IDMAC, it occurred the compiler error. And it seems that didn't need to use IS_ENABLED() at there. Acked-by: Jaehoon Chung jh80.ch...@samsung.com Best Regards, Jaehoon Chung

RE: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-07-11 Thread Seungwon Jeon
On Fri, July 11, 2014, Sonny Rao wrote: On Thu, Jul 10, 2014 at 5:28 AM, Seungwon Jeon tgih@samsung.com wrote: Hi Sonny, I have missed this patch. You finally choose to take extra interrupt handling. If it is not harm, it's fine. Hi, thanks for coming back to it. Based on my

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-07-11 Thread Sonny Rao
On Fri, Jul 11, 2014 at 3:20 AM, Seungwon Jeon tgih@samsung.com wrote: On Fri, July 11, 2014, Sonny Rao wrote: On Thu, Jul 10, 2014 at 5:28 AM, Seungwon Jeon tgih@samsung.com wrote: Hi Sonny, I have missed this patch. You finally choose to take extra interrupt handling. If it

RE: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-07-10 Thread Seungwon Jeon
Hi Sonny, I have missed this patch. You finally choose to take extra interrupt handling. If it is not harm, it's fine. Please check one thing below. On Tue, June 10, 2014, Sonny Rao wrote: This patch changes the fifo reset code to follow the reset procedure outlined in the documentation of

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-07-10 Thread Sonny Rao
On Thu, Jul 10, 2014 at 5:28 AM, Seungwon Jeon tgih@samsung.com wrote: Hi Sonny, I have missed this patch. You finally choose to take extra interrupt handling. If it is not harm, it's fine. Hi, thanks for coming back to it. Based on my tracing, the interrupt seems to be okay and is

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-06-09 Thread Sonny Rao
On Wed, May 28, 2014 at 10:17 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, Sonny. On 05/29/2014 09:35 AM, Sonny Rao wrote: This patch changes the fifo reset code to follow the reset procedure outlined in the documentation of Synopsys Mobile storage host databook. Signed-off-by: Sonny

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-28 Thread Jaehoon Chung
Hi, Sonny. On 05/29/2014 09:35 AM, Sonny Rao wrote: This patch changes the fifo reset code to follow the reset procedure outlined in the documentation of Synopsys Mobile storage host databook. Signed-off-by: Sonny Rao sonny...@chromium.org Signed-off-by: Yuvaraj Kumar C D

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-13 Thread James Hogan
Hi, On 12/05/14 22:44, Sonny Rao wrote: Doug mentioned that James Hogan might have an answer. James, are there Imgtec SoCs which use dw_mmc and use DMA but don't use the IDMAC? If so, we can add that support into this reset procedure patch. Yes, the Toumaz TZ1090 SoC has the dw_mmc

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-12 Thread Sonny Rao
On Sat, May 10, 2014 at 7:08 AM, Seungwon Jeon tgih@samsung.com wrote: Hi Sonny, Can you separate procedure? Reset all are handled in fifo-reset. And ciu reset is always needed for error handling? Yes according to the document in the Controller/DMA/FIFO Reset Usage section, the

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-12 Thread Sonny Rao
On Fri, May 9, 2014 at 8:36 PM, Sonny Rao sonny...@chromium.org wrote: On Fri, May 9, 2014 at 12:32 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, Sonny. You can discard the my previous some comment. As you mentioned, this reset sequence is recommended at Synopsys TRM. Add the minor

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-12 Thread Sonny Rao
On Mon, May 12, 2014 at 2:44 PM, Sonny Rao sonny...@chromium.org wrote: On Fri, May 9, 2014 at 8:36 PM, Sonny Rao sonny...@chromium.org wrote: On Fri, May 9, 2014 at 12:32 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, Sonny. You can discard the my previous some comment. As you

RE: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-10 Thread Seungwon Jeon
Hi Sonny, Can you separate procedure? Reset all are handled in fifo-reset. And ciu reset is always needed for error handling? Thanks, Seungwon Jeon On Sat, May 10, 2014, Sonny Rao wrote: On Fri, May 9, 2014 at 12:32 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, Sonny. You can

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-09 Thread Jaehoon Chung
Hi, Sonny. You can discard the my previous some comment. As you mentioned, this reset sequence is recommended at Synopsys TRM. Add the minor question. On 05/09/2014 01:27 PM, Jaehoon Chung wrote: Hi, Sonny. I have checked the Synopsys TRM.. On 05/09/2014 10:34 AM, Sonny Rao wrote: On

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-09 Thread Sonny Rao
On Fri, May 9, 2014 at 12:32 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, Sonny. You can discard the my previous some comment. As you mentioned, this reset sequence is recommended at Synopsys TRM. Add the minor question. On 05/09/2014 01:27 PM, Jaehoon Chung wrote: Hi, Sonny. I

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-08 Thread Yuvaraj Kumar
Any comments on this patch? On Wed, Mar 26, 2014 at 5:16 PM, Yuvaraj Kumar C D yuvaraj...@gmail.com wrote: From: Sonny Rao sonny...@chromium.org This patch changes the fifo reset code to follow the reset procedure outlined in the documentation of Synopsys Mobile storage host databook

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-08 Thread Jaehoon Chung
On 05/08/2014 06:40 PM, Yuvaraj Kumar wrote: Any comments on this patch? On Wed, Mar 26, 2014 at 5:16 PM, Yuvaraj Kumar C D yuvaraj...@gmail.com wrote: From: Sonny Rao sonny...@chromium.org This patch changes the fifo reset code to follow the reset procedure outlined in the documentation

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-08 Thread Sonny Rao
On Thu, May 8, 2014 at 6:15 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: On 05/08/2014 06:40 PM, Yuvaraj Kumar wrote: Any comments on this patch? On Wed, Mar 26, 2014 at 5:16 PM, Yuvaraj Kumar C D yuvaraj...@gmail.com wrote: From: Sonny Rao sonny...@chromium.org This patch changes the

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-08 Thread Jaehoon Chung
Hi, Sonny. I have checked the Synopsys TRM.. On 05/09/2014 10:34 AM, Sonny Rao wrote: On Thu, May 8, 2014 at 6:15 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: On 05/08/2014 06:40 PM, Yuvaraj Kumar wrote: Any comments on this patch? On Wed, Mar 26, 2014 at 5:16 PM, Yuvaraj Kumar C D