Re: [PATCH] add bsg queue resize

2007-01-23 Thread Jens Axboe
On Sat, Jan 20 2007, FUJITA Tomonori wrote: This enables bsg to resize the queue depth via SG_SET_COMMAND_Q. bsg_command structures are allocated via mempool because the previous way to use contiguous memory makes it difficult to resize the queue depth when a bsg_device has outstanding

[RFC 2/6] bidi support: request_io_part

2007-01-23 Thread Boaz Harrosh
The patch was probably too big and did not go through the mailing list. I have compressed and attached it, is that OK or must I put it online somewhere? - Extract all I/O members of struct request into a request_io_part member. - Define API to access the I/O part - Adjust block layer

[RFC 2/6] bidi support: request_io_part

2007-01-23 Thread Boaz Harrosh
The patch was probably too big and did not go through the mailing list. I have compressed and attached it, is that OK or must I put it online somewhere? - Extract all I/O members of struct request into a request_io_part member. - Define API to access the I/O part - Adjust block layer

Re: Linux Virtual SCSI HBAs and Virtual disks

2007-01-23 Thread Aboo Valappil
Hi Stefan Richter, Thanks everyone for their advice on this. As per your advice, I did the following when the last user space target serving the scsi_host quits, the queue command will do the following on the new commands coming through. sc-result = DID_NO_CONNECT 16;

Re: Linux Virtual SCSI HBAs and Virtual disks

2007-01-23 Thread Stefan Richter
Aboo Valappil wrote: I implemented a new IOCTL to remove this scsi_host if the user process really needs to. This removal will first finish all the SCSI commands (With the above status results) queued on the scsi_host (If at all) and then remove the scsi_host. Also the module unload

Re: Linux Virtual SCSI HBAs and Virtual disks

2007-01-23 Thread Stefan Richter
Randy Dunlap wrote: Aboo Valappil wrote: The new version is available http://vscsihba.aboo.org/vscsihbav204.gz 404: NOT FOUND .gz - .tgz Besides the tarball, a browsable source tree would be nice for people who just want to take a quick look. -- Stefan Richter -=-=-=== ---= =-===

[PATCH 2/4] ipr: Tolerate not finding PCI-X registers

2007-01-23 Thread Brian King
Don't fail initialization of an adapter if the PCI-X registers cannot be found since it may be a PCI-E adapter. Signed-off-by: Brian King [EMAIL PROTECTED] --- linux-2.6-bjking1/drivers/scsi/ipr.c | 10 ++ 1 files changed, 2 insertions(+), 8 deletions(-) diff -puN

[PATCH 3/4] ipr: PCI error recovery fix

2007-01-23 Thread Brian King
Since the pci_block_user_cfg_access API was modified to track block/unblocks, it was discovered that the ipr driver had a path through its code (in PCI error recovery) which would unblock when not previously blocked. Signed-off-by: Brian King [EMAIL PROTECTED] ---

[PATCH 4/4] ipr: Driver version 2.3.1

2007-01-23 Thread Brian King
Bump driver version to 2.3.1. Signed-off-by: Brian King [EMAIL PROTECTED] --- linux-2.6-bjking1/drivers/scsi/ipr.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/scsi/ipr.h~ipr_driver_version_2_3_1 drivers/scsi/ipr.h ---

[PATCH 1/4] ipr: Remove usage of pci driver data

2007-01-23 Thread Brian King
Since ipr handles dynamic ids, it must handle driver_data not being set, so remove the current usage of driver_data so it can be used for other things in future patches. Signed-off-by: Brian King [EMAIL PROTECTED] --- linux-2.6-bjking1/drivers/scsi/ipr.c | 63

Re: [RFC 3/6] bidi support: bidirectional request

2007-01-23 Thread Benny Halevy
James Bottomley wrote: On Mon, 2007-01-22 at 01:25 +0200, Boaz Harrosh wrote: - Instantiate another request_io_part in request for bidi_read. - Define Implement new API for accessing bidi parts. - API to Build bidi requests and map to sglists. - Define new end_that_request_block() function

Re: [RFC 1/6] bidi support: request dma_data_direction

2007-01-23 Thread Benny Halevy
Muli Ben-Yehuda wrote: On Mon, Jan 22, 2007 at 01:21:28AM +0200, Boaz Harrosh wrote: - Introduce a new enum dma_data_direction data_dir member in struct request. and remove the RW bit from request-cmd_flag Some architecture use 'enum dma_data_direction' and some 'int

Re: [RFC 1/6] bidi support: request dma_data_direction

2007-01-23 Thread Benny Halevy
Douglas Gilbert wrote: Benny Halevy wrote: Douglas Gilbert wrote: Perhaps the right use of DMA_BIRECTIONAL needs to be defined. Could it be used with a XDWRITE(10) SCSI command defined in sbc3r07.pdf at http://www.t10.org ? I suspect using two scatter gather lists would be a better

Re: [RFC 1/6] bidi support: request dma_data_direction

2007-01-23 Thread Muli Ben-Yehuda
On Tue, Jan 23, 2007 at 03:45:00PM +0200, Benny Halevy wrote: +static inline int dma_uni_dir(enum dma_data_direction dir) +{ + return (dir == DMA_TO_DEVICE) || (dir == DMA_FROM_DEVICE) || + (dir == DMA_NONE); +} While this doesn't look very useful. Why is DMA_NONE a

Re: [RFC 1/6] bidi support: request dma_data_direction

2007-01-23 Thread Benny Halevy
Muli Ben-Yehuda wrote: On Tue, Jan 23, 2007 at 03:45:00PM +0200, Benny Halevy wrote: +static inline int dma_uni_dir(enum dma_data_direction dir) +{ + return (dir == DMA_TO_DEVICE) || (dir == DMA_FROM_DEVICE) || + (dir == DMA_NONE); +} While this doesn't look very useful. Why is

[PATCH 0/4] aacraid: Driver updates

2007-01-23 Thread Mark Haverkamp
The following 4 patches contain various updates described in each mail. Patches apply to the scsi-misc-2.6 tree. Makefile |2 aachba.c | 672 - aacraid.h | 46 +++- comminit.c | 14 - commsup.c | 40 --- linit.c|

[PATCH 1/4] aacraid: rework communication support code

2007-01-23 Thread Mark Haverkamp
Received from Mark Salyzyn, Replace all if/else communication transports with a platform function call. This is in recognition of the need to migrate to up-and-coming transports. Currently the Linux driver does not support two available communication transports provided by our products, these

[PATCH 4/4] aacraid: rework packet support code

2007-01-23 Thread Mark Haverkamp
Received from Mark Salyzyn, Replace all if/else packet formations with platform function calls. This is in recognition of the proliferation of read and write packet types, and in the need to migrate to up-and-coming packets for new products. Signed-off-by Mark Haverkamp [EMAIL PROTECTED] ---

Re: Linux Virtual SCSI HBAs and Virtual disks

2007-01-23 Thread Stefan Richter
Aboo Valappil wrote: Stefan Richter wrote: ... - vscsihba enters scsi_remove_host() or scsi_remove_device(), - SCSI core and upper layers do whatever it takes to withdraw from the respective I-T(-L) nexus gracefully (e.g. synchronize cache, unlock drive door...), Does this

Re: [PATCH] add bsg queue resize

2007-01-23 Thread FUJITA Tomonori
From: Jens Axboe [EMAIL PROTECTED] Subject: Re: [PATCH] add bsg queue resize Date: Tue, 23 Jan 2007 16:23:49 +0100 On Tue, Jan 23 2007, Jens Axboe wrote: On Sat, Jan 20 2007, FUJITA Tomonori wrote: This enables bsg to resize the queue depth via SG_SET_COMMAND_Q. bsg_command structures

Re: Linux Virtual SCSI HBAs and Virtual disks

2007-01-23 Thread Douglas Gilbert
Aboo Valappil wrote: Hi Stefan Richter, Thanks everyone for their advice on this. As per your advice, I did the following when the last user space target serving the scsi_host quits, the queue command will do the following on the new commands coming through. sc-result =

Re: [Patch 2/4] aacraid: expanded expose physical device code

2007-01-23 Thread Christoph Hellwig
+ if ((scsicmd-cmnd[0] == INQUIRY) (expose_physicals = 0)) { + u8 b; + u8 b1; + /* We can't expose disk devices because we can't + * tell whether they are the raw container drives +

[patch] scsi: use lock per host instead of per device for shared queue tag host

2007-01-23 Thread Ed Lin
The block layer uses lock to protect request queue. Every scsi device has a unique request queue, and queue lock is the default lock in struct request_queue. This is good for normal cases. But for a host with shared queue tag (e.g. stex controllers), a queue lock per device means the shared queue