[PATCH -net] scsi: fix users of SCSI_FC_ATTRS to depend on NET

2014-09-16 Thread Randy Dunlap
From: Randy Dunlap rdun...@infradead.org There are other kconfig symbols which select SCSI_FC_ATTRS, so they also need to depend on NET to fix kconfig warnings and build errors: warning: (LIBFC SCSI_IBMVFC SCSI_QLA_FC SCSI_LPFC ZFCP SCSI_BFA_FC SCSI_CHELSIO_FCOE FUSION_FC) selects

Re: [PATCH V3 10/16] scsi: ufs: add UFS power management support

2014-09-16 Thread Akinobu Mita
2014-09-10 20:54 GMT+09:00 Dolev Raviv dra...@codeaurora.org: +static int ufshcd_config_vreg_load(struct device *dev, struct ufs_vreg *vreg, + int ua) +{ + int ret = 0; + struct regulator *reg = vreg-reg; + const char *name = vreg-name; +

Re: scsi: add support for a blk-mq based I/O path.

2014-09-16 Thread Daniel Gryniewicz
Hi, Chris. I'm working with the OSD Initiator, which does bi-directional requests, and this commit (d285203 scsi: add support for a blk-mq based I/O path.) causes a use-after free panic for me. The panic itself follows, but the cause is that scsi_end_request() calls blk_finish_request(),

Re: [PATCH -net] scsi: fix users of SCSI_FC_ATTRS to depend on NET

2014-09-16 Thread Steffen Maier
On 09/16/2014 08:35 AM, Randy Dunlap wrote: From: Randy Dunlap rdun...@infradead.org There are other kconfig symbols which select SCSI_FC_ATTRS, so they also need to depend on NET to fix kconfig warnings and build errors: warning: (LIBFC SCSI_IBMVFC SCSI_QLA_FC SCSI_LPFC ZFCP SCSI_BFA_FC

Re: scsi: add support for a blk-mq based I/O path.

2014-09-16 Thread Christoph Hellwig
Hi Daniel, this should also be fixed with my patch scsi: clean up S/G table freeing, can you test if that fixes the issue for you as well? -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH fix for 3.17 0/1] uas: Add no-report-opcodes quirk

2014-09-16 Thread Hans de Goede
Hi Greg, et al, Another day, another uas quirk. Although you may not see it that way, this is actually a good thing :) With the new uas error handling code (which users are testing through a stand-alone version of the uas driver), people are now actually sending me logs with useful error messages

[PATCH fix for 3.17] uas: Add no-report-opcodes quirk

2014-09-16 Thread Hans de Goede
Besides the ASM1051 (*) needing sdev-no_report_opcodes = 1, it turns out that the JMicron JMS567 also needs it to work properly with uas (usb-storage always sets it). Since some of the scsi devs were not to keen on the idea to outrightly set sdev-no_report_opcodes = 1 for all uas devices, so add a

Re: [PATCH -net] scsi: fix users of SCSI_FC_ATTRS to depend on NET

2014-09-16 Thread David Miller
From: Steffen Maier ma...@linux.vnet.ibm.com Date: Tue, 16 Sep 2014 16:56:55 +0200 I think zfcp does not have any (direct) dependency on NET. It looks like SCSI_FC_ATTRS selects SCSI_NETLINK (declaring scsi_nl_sock) and only depends on SCSI but not on NET. SCSI_NETLINK itself only selects

Re: scsi: add support for a blk-mq based I/O path.

2014-09-16 Thread Daniel Gryniewicz
On 09/16/2014 12:19 PM, Christoph Hellwig wrote: Hi Daniel, this should also be fixed with my patch scsi: clean up S/G table freeing, can you test if that fixes the issue for you as well? Yeah, that fixes it, thanks. Daniel -- To unsubscribe from this list: send the line unsubscribe

Re: scsi: add support for a blk-mq based I/O path.

2014-09-16 Thread Christoph Hellwig
On Tue, Sep 16, 2014 at 01:17:55PM -0400, Daniel Gryniewicz wrote: this should also be fixed with my patch scsi: clean up S/G table freeing, can you test if that fixes the issue for you as well? Yeah, that fixes it, thanks. Thanks. Looking at the impact of that I suspect we're better off

Re: scsi: add support for a blk-mq based I/O path.

2014-09-16 Thread Webb Scales
On 9/16/14 10:41 AM, Daniel Gryniewicz wrote: Hi, Chris. I'm working with the OSD Initiator, which does bi-directional requests, and this commit (d285203 scsi: add support for a blk-mq based I/O path.) causes a use-after free panic for me. The panic itself follows, but the cause is that

CentOS 6.5 tgtadm LUN ID set doesn't work

2014-09-16 Thread Gonçalo Rosa
Hello, I did the following procedure: tgtadm –lld iscsi –mode target –op new –tid 1 –targetname iqn.2014-09.local.vclass:tg0 tgtadm –lld iscsi –op new –mode logicalunit –tid 1 –lun 1 –backing-store /dev/sdg tgtadm –lld iscsi –op new –mode logicalunit –tid 1 –lun 2 –backing-store /dev/sdh tgtadm

Re: [PATCH -net] scsi: fix users of SCSI_FC_ATTRS to depend on NET

2014-09-16 Thread David Miller
From: Randy Dunlap rdun...@infradead.org Date: Mon, 15 Sep 2014 23:35:21 -0700 From: Randy Dunlap rdun...@infradead.org There are other kconfig symbols which select SCSI_FC_ATTRS, so they also need to depend on NET to fix kconfig warnings and build errors: warning: (LIBFC SCSI_IBMVFC

Re: [PATCH -net] scsi: fix users of SCSI_FC_ATTRS to depend on NET

2014-09-16 Thread Randy Dunlap
On 09/16/14 13:15, David Miller wrote: From: Randy Dunlap rdun...@infradead.org Date: Mon, 15 Sep 2014 23:35:21 -0700 From: Randy Dunlap rdun...@infradead.org There are other kconfig symbols which select SCSI_FC_ATTRS, so they also need to depend on NET to fix kconfig warnings and build

Re: [PATCH -net] scsi: fix users of SCSI_FC_ATTRS to depend on NET

2014-09-16 Thread David Miller
From: Randy Dunlap rdun...@infradead.org Date: Tue, 16 Sep 2014 13:24:46 -0700 typo: depends on SCSI_FC_ATTRS No, I certainly have no objection and prefer depends over select anyway. Ok, then please send me a patch which fixes things that way. Thanks! -- To unsubscribe

[PATCH v2] scsi: use 'depends' instead of 'select' for SCSI_FC_ATTRS

2014-09-16 Thread Randy Dunlap
From: Randy Dunlap rdun...@infradead.org There are other kconfig symbols which use SCSI_FC_ATTRS. In order to maintain sanity and prevent kconfig warnings, change all of these from using 'select' to using 'depends on' so that proper symbol dependencies will be honored and circular depends

Re: [PATCH v2] scsi: use 'depends' instead of 'select' for SCSI_FC_ATTRS

2014-09-16 Thread David Miller
From: Randy Dunlap rdun...@infradead.org Date: Tue, 16 Sep 2014 13:47:41 -0700 From: Randy Dunlap rdun...@infradead.org There are other kconfig symbols which use SCSI_FC_ATTRS. In order to maintain sanity and prevent kconfig warnings, change all of these from using 'select' to using

[PATCH 13/22] scsi: Replace strnicmp with strncasecmp

2014-09-16 Thread Rasmus Villemoes
The kernel used to contain two functions for length-delimited, case-insensitive string comparison, strnicmp with correct semantics and a slightly buggy strncasecmp. The latter is the POSIX name, so strnicmp was renamed to strncasecmp, and strnicmp made into a wrapper for the new strncasecmp to

Re: [ANNOUNCE] scsi patch queue tree updated

2014-09-16 Thread Christoph Hellwig
On Mon, Sep 15, 2014 at 03:58:18PM -0700, Christoph Hellwig wrote: I've pushed two updates to the core-for-3.17 branch of git://git.infradead.org/users/hch/scsi-queue.git which should go to Linus before the next rc. One is a regression fix for drivers using block layer tagging when

[PATCH] blk-mq: avoid infite recursion with the FUA

2014-09-16 Thread Christoph Hellwig
We should not insert requests into the flush state machine from blk_mq_insert_request. All incoming flush requests come through blk_{m,s}q_make_request and are handled there, while blk_execute_rq_nowait should only be called for BLOCK_PC requests. All other callers deal with requests that

Re: [ANNOUNCE] scsi patch queue tree updated

2014-09-16 Thread James Bottomley
On Tue, 2014-09-16 at 14:37 -0700, Christoph Hellwig wrote: On Mon, Sep 15, 2014 at 03:58:18PM -0700, Christoph Hellwig wrote: I've pushed two updates to the core-for-3.17 branch of git://git.infradead.org/users/hch/scsi-queue.git which should go to Linus before the next rc.

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-09-16 Thread Christoph Hellwig
On Tue, Sep 16, 2014 at 10:42:08AM +0800, Ching Huang wrote: The [PATCH v5 2/2] was depend on [PATCH v4 1/2]. If you skip patch 1/2, then patch 2/2 may cause line number mismatch. How should I do? Please advise. Hi Ching, [PATCH v5 2/2] applied without a problem. Please look at my

Re: [PATCH] blk-mq: avoid infite recursion with the FUA

2014-09-16 Thread Christoph Hellwig
The subject is missing a flag at the end. Feel free to fix it up on commit :) -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html