Re: RFC: struct request cleanups

2015-04-21 Thread Matthew Wilcox
On Fri, Apr 17, 2015 at 10:37:15PM +0200, Christoph Hellwig wrote: The real RFC is the last one which allocates the block_pc specific data separately in the callers instead of bloating every struct request with it. I always hated what we did, but with the upcoming split of nvme into

Re: [PATCH RESEND 6/18] megaraid_sas : Use Block layer tag support for internal command indexing

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 02:33 PM, sumit.sax...@avagotech.com wrote: megaraid_sas driver will use block layer provided tag for indexing internal MPT frames to get any unique MPT frame tied with tag. Each IO request submitted from SCSI mid layer will get associated MPT frame from MPT framepool

Re: [PATCH RESEND 7/18] megaraid_sas : Modify driver's meta data to reflect Avago

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 02:33 PM, sumit.sax...@avagotech.com wrote: This patch will update module parameters and driver name inside SCSI host template to reflect Avago. Signed-off-by: Sumit Saxena sumit.sax...@avagotech.com --- Reviewed-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes

Re: [PATCH RESEND 8/18] megaraid_sas : Add release date and update driver version

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 02:33 PM, sumit.sax...@avagotech.com wrote: This patch will upgrade the driver version and add back the release date and sysfs hook for the same. Some internal applications uses sysfs parameter for release date, so they were broken because of removal of release date from

Re: [PATCH RESEND 2/18] megaraid_sas : Add separate function for refiring MFI commands

2015-04-21 Thread Christoph Hellwig
Nice cleanup. Reviewed-by: Christoph Hellwig h...@lst.de -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: aha1542: rework locking

2015-04-21 Thread Ondrej Zary
On Tuesday 21 April 2015, Dan Carpenter wrote: Hello Ondrej Zary, The patch 1b0224b0ec60: aha1542: rework locking from Feb 6, 2015, leads to the following static checker warning: drivers/scsi/aha1542.c:448 aha1542_queuecommand() error: scheduling with locks held:

Re: [PATCH 1/1] SCSI: add 1024 max sectors black list flag

2015-04-21 Thread Christoph Hellwig
On Mon, Apr 20, 2015 at 10:42:24PM -0500, micha...@cs.wisc.edu wrote: From: Mike Christie micha...@cs.wisc.edu This works around a issue with qnap iscsi targets not handling large IOs very well. :( Looks like the best workaround, so: Reviewed-by: Christoph Hellwig h...@lst.de -- To

RE: [PATCH RESEND 9/18] megaraid_sas : Support for Avago's Single server High Availability product

2015-04-21 Thread Sumit Saxena
-Original Message- From: Tomas Henzl [mailto:the...@redhat.com] Sent: Tuesday, April 21, 2015 5:39 PM To: sumit.sax...@avagotech.com; linux-scsi@vger.kernel.org Cc: martin.peter...@oracle.com; h...@infradead.org; jbottom...@parallels.com; kashyap.de...@avagotech.com Subject: Re: [PATCH

re: aha1542: rework locking

2015-04-21 Thread Dan Carpenter
Hello Ondrej Zary, The patch 1b0224b0ec60: aha1542: rework locking from Feb 6, 2015, leads to the following static checker warning: drivers/scsi/aha1542.c:448 aha1542_queuecommand() error: scheduling with locks held: 'spin_lock:host_lock' drivers/scsi/aha1542.c 400

Re: [PATCH 06/14] lpfc: Add support for RDP ELS command.

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 03:56 PM, James Smart wrote: Add support for RDP ELS command. Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- Reviewed-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes Reinecke zSeries

Re: [PATCH 07/14] lpfc: Correct reporting of vport state on fdisc command failure.

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 03:56 PM, James Smart wrote: Correct reporting of vport state on fdisc command failure. Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- Reviewed-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH] megaraid_sas: use raw_smp_processor_id()

2015-04-21 Thread Hannes Reinecke
On 04/15/2015 06:44 PM, Christoph Hellwig wrote: We only want to steer the I/O completion towards a queue, but don't actually access any per-CPU data, so the raw_ version is fine to use and avoids the warnings when using smp_processor_id(). Signed-off-by: Christoph Hellwig h...@lst.de

Re: [PATCH 01/14] lpfc: The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 03:56 PM, James Smart wrote: The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_hbadisc.c | 2 +- 1 file changed, 1

Re: [PATCH 02/14] lpfc: Correct loss of target discovery after cable swap.

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 03:56 PM, James Smart wrote: Correct loss of target discovery after cable swap. Fix incorrect reference counting Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_hbadisc.c | 4 ++-- 1 file

Re: [PATCH 09/14] lpfc: Fix to remove IRQF_SHARED flag for MSI/MSI-X vectors.

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 03:56 PM, James Smart wrote: Fix to remove IRQF_SHARED flag for MSI/MSI-X vectors. Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- Reviewed-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH 08/14] lpfc: Fix discovery issue when changing from Pt2Pt to Fabric.

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 03:56 PM, James Smart wrote: Fix discovery issue when changing from Pt2Pt to Fabric. Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- Reviewed-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH RESEND 1/18] megaraid_sas : Add separate function for setting up IRQs

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 02:32 PM, sumit.sax...@avagotech.com wrote: This patch will create separate function for setting up IRQs and enable interrupts after adapter's initialization. Signed-off-by: Kashyap Desai kashyap.de...@avagotech.com Signed-off-by: Sumit Saxena sumit.sax...@avagotech.com ---

Re: [PATCH 04/14] lpfc: Correct reference counting of rport

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 03:56 PM, James Smart wrote: Correct reference counting of rport Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- Reviewed-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH 11/14] lpfc: Correct loss of RSCNs during array takeaway/giveback testing.

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 03:56 PM, James Smart wrote: Correct loss of RSCNs during array takeaway/giveback testing. Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- Reviewed-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes

Re: [PATCH 03/14] lpfc: Add support for ELS LCB.

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 03:56 PM, James Smart wrote: Add support for ELS LCB. Also has a little whitespace fixing. Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- Reviewed-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes

Re: [PATCH 10/14] lpfc: Fix crash in vport_delete.

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 03:56 PM, James Smart wrote: Fix crash in vport_delete. We inadvertantly took the path to recreate the vport while in a driver teardown path Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- Reviewed-by: Hannes

Re: [PATCH RESEND 2/18] megaraid_sas : Add separate function for refiring MFI commands

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 02:32 PM, sumit.sax...@avagotech.com wrote: This patch will add separate function for refiring MFI commands in Fusion adapters's OCR code. Signed-off-by: Kashyap Desai kashyap.de...@avagotech.com Signed-off-by: Sumit Saxena sumit.sax...@avagotech.com --- Reviewed-by: Hannes

[PATCH v2 2/3] uas: Add US_FL_MAX_SECTORS_240 flag

2015-04-21 Thread Hans de Goede
The usb-storage driver sets max_sectors = 240 in its scsi-host template, for uas we do not want to do that for all devices, but testing has shown that some devices need it. This commit adds a US_FL_MAX_SECTORS_240 flag for such devices, and implements support for it in uas.c, while at it it also

[PATCH v2 3/3] uas: Set max_sectors_240 quirk for ASM1053 devices

2015-04-21 Thread Hans de Goede
Testing has shown that ASM1053 devices do not work properly with transfers larger than 240 sectors, so set max_sectors to 240 on these. Cc: sta...@vger.kernel.org # 3.16 Reported-by: Steve Bangert sbang...@frontier.com Signed-off-by: Hans de Goede hdego...@redhat.com Tested-by: Steve Bangert

[PATCH v2 1/3] uas: Allow uas_use_uas_driver to return usb-storage flags

2015-04-21 Thread Hans de Goede
uas_use_uas_driver may set some US_FL_foo flags during detection, currently these are stored in a local variable and then throw away, but these may be of interest to the caller, so add an extra parameter to (optionally) return the detected flags, and use this in the uas driver. Cc:

Re: [PATCH 05/14] lpfc: Fix ABORTs WQ selection in terminate_rport_io

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 03:56 PM, James Smart wrote: Fix ABORTs WQ selection in terminate_rport_io Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- Reviewed-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH 12/14] lpfc: Fix incorrect log message reported for empty FCF record.

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 03:56 PM, James Smart wrote: Fix incorrect log message reported for empty FCF record. Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- Reviewed-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH 13/14] lpfc: Change buffer pool empty message to miscellaneous category

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 03:56 PM, James Smart wrote: Change buffer pool empty message to miscellaneous category Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- Reviewed-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH 14/14] lpfc: Update driver version for upstream patch set 10.6.0.1.

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 03:56 PM, James Smart wrote: Update driver version for upstream patch set 10.6.0.1. Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- Reviewed-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH v2 1/3] uas: Allow uas_use_uas_driver to return usb-storage flags

2015-04-21 Thread Alan Stern
On Tue, 21 Apr 2015, Hans de Goede wrote: uas_use_uas_driver may set some US_FL_foo flags during detection, currently these are stored in a local variable and then throw away, but these may be of interest to the caller, so add an extra parameter to (optionally) return the detected flags, and

Re: [PATCH RESEND 8/18] megaraid_sas : Add release date and update driver version

2015-04-21 Thread Tomas Henzl
On 04/20/2015 02:33 PM, sumit.sax...@avagotech.com wrote: This patch will upgrade the driver version and add back the release date and sysfs hook for the same. Some internal applications uses sysfs parameter for release date, so they were broken because of removal of release date from

Re: [PATCH RESEND 7/18] megaraid_sas : Modify driver's meta data to reflect Avago

2015-04-21 Thread Tomas Henzl
On 04/20/2015 02:33 PM, sumit.sax...@avagotech.com wrote: This patch will update module parameters and driver name inside SCSI host template to reflect Avago. Signed-off-by: Sumit Saxena sumit.sax...@avagotech.com Reviewed-by: Tomas Henzl the...@redhat.com Tomas -- To unsubscribe from this

Re: [PATCH RESEND 9/18] megaraid_sas : Support for Avago's Single server High Availability product

2015-04-21 Thread Tomas Henzl
On 04/20/2015 02:33 PM, sumit.sax...@avagotech.com wrote: This patch will add support for Single Server High Availability(SSHA) cluster support. Here is the short decsription of changes done to add support for SSHA- 1) Host will send system's Unique ID based on DMI_PRODUCT_UUID to firmware.

Re: [PATCH 00/20] mpt3sas: driver update

2015-04-21 Thread Christoph Hellwig
On Wed, Apr 08, 2015 at 11:13:04AM +0530, Sreekanth Reddy wrote: Hi Chris, There are no corresponding mpt2sas driver's patches, The last phase for mpt2sas drivers is Phase20 and this phase driver is already exits in the upstream kernel. Also mpt2sas driver is completely in maintains mode

Re: [PATCH RESEND 13/18] megaraid_sas : add endianess conversions for all ones

2015-04-21 Thread Tomas Henzl
On 04/20/2015 02:34 PM, sumit.sax...@avagotech.com wrote: Add noop conversions for all ones to make sparse happy. Signed-off-by: Christoph Hellwig h...@lst.de Reviewed-by: Tomas Henzl the...@redhat.com Tomas -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: [PATCH RESEND 15/18] megaraid_sas : bytewise or should be done on native endian variables

2015-04-21 Thread Tomas Henzl
On 04/20/2015 02:34 PM, sumit.sax...@avagotech.com wrote: Signed-off-by: Christoph Hellwig h...@lst.de Reviewed-by: Tomas Henzl the...@redhat.com Tomas -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo

RE: [PATCH RESEND 6/18] megaraid_sas : Use Block layer tag support for internal command indexing

2015-04-21 Thread Sumit Saxena
-Original Message- From: Christoph Hellwig [mailto:h...@infradead.org] Sent: Tuesday, April 21, 2015 4:12 PM To: sumit.sax...@avagotech.com Cc: linux-scsi@vger.kernel.org; the...@redhat.com; martin.peter...@oracle.com; h...@infradead.org; jbottom...@parallels.com;

Re: [PATCH RESEND 18/18] megaraid_sas : swap whole register in megasas_register_aen

2015-04-21 Thread Tomas Henzl
On 04/20/2015 02:35 PM, sumit.sax...@avagotech.com wrote: Swap the whole 32 bits we read from the hardware instead of swapping just the 16bits we care about in place later. Signed-off-by: Christoph Hellwig h...@lst.de --- drivers/scsi/megaraid/megaraid_sas_base.c |5 +++-- 1 files

Re: [PATCH RESEND 11/18] megaraid_sas : add missing __iomem annotations

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 02:34 PM, sumit.sax...@avagotech.com wrote: Signed-off-by: Christoph Hellwig h...@lst.de --- Reviewed-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX

Re: [PATCH RESEND 1/18] megaraid_sas : Add separate function for setting up IRQs

2015-04-21 Thread Christoph Hellwig
On Mon, Apr 20, 2015 at 06:02:30PM +0530, sumit.sax...@avagotech.com wrote: This patch will create separate function for setting up IRQs and enable interrupts after adapter's initialization. The structure of megasas_setup_irqs clearly suggest it should be two functions: one for the traditional

Re: [PATCH RESEND 17/18] megaraid_sas : fix megasas_fire_cmd_fusion calling convention

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 02:35 PM, sumit.sax...@avagotech.com wrote: The fusion HBAs don't really use the instance template like the other variants, as it branches off at a much higher level. So instead of trying to squeeze megasas_fire_cmd_fusion into the wrong calling convention call it locally with

Re: [PATCH RESEND 18/18] megaraid_sas : swap whole register in megasas_register_aen

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 02:35 PM, sumit.sax...@avagotech.com wrote: Swap the whole 32 bits we read from the hardware instead of swapping just the 16bits we care about in place later. Signed-off-by: Christoph Hellwig h...@lst.de --- drivers/scsi/megaraid/megaraid_sas_base.c |5 +++-- 1 files

Re: [PATCH RESEND 10/18] megaraid_sas : megasas_complete_outstanding_ioctls() can be static

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 02:35 PM, sumit.sax...@avagotech.com wrote: drivers/scsi/megaraid/megaraid_sas_base.c:1701:6: sparse: symbol 'megasas_complete_outstanding_ioctls' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com ---

Re: [PATCH RESEND 6/18] megaraid_sas : Use Block layer tag support for internal command indexing

2015-04-21 Thread Christoph Hellwig
This patch needs to be split up: the return_cmd calling convenion changes should be a pach on it's own, the various new debug printks should be a patch on their own, or better jsut be dropped. Also please drop the BLK_TAG_REFCOUNT/DEBUG code that shouldn't be ina production driver. -- To

Re: aha1542: rework locking

2015-04-21 Thread Dan Carpenter
On Tue, Apr 21, 2015 at 12:39:40PM +0200, Ondrej Zary wrote: Thanks, I missed that as it was already wrong before (since at least when DEF_SCSI_QCMD was introduced). And it worked despite that. If you turn on CONFIG_DEBUG_ATOMIC_SLEEP=y it will generate a warning splat. Otherwise you probably

Re: [PATCH 03/14] lpfc: Add support for ELS LCB.

2015-04-21 Thread Sebastian Herbszt
James Smart wrote: Add support for ELS LCB. Also has a little whitespace fixing. Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc.h | 1 + drivers/scsi/lpfc/lpfc_els.c | 239

Re: [PATCH RESEND 11/18] megaraid_sas : add missing __iomem annotations

2015-04-21 Thread Tomas Henzl
On 04/20/2015 02:34 PM, sumit.sax...@avagotech.com wrote: Signed-off-by: Christoph Hellwig h...@lst.de Reviewed-by: Tomas Henzl the...@redhat.com Tomas -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH RESEND 12/18] megaraid_sas : add endianess annotations

2015-04-21 Thread Tomas Henzl
On 04/20/2015 02:34 PM, sumit.sax...@avagotech.com wrote: This adds endianness annotations to all data structures, and a few variables directly referencing them. Signed-off-by: Christoph Hellwig h...@lst.de Reviewed-by: Tomas Henzl the...@redhat.com Tomas -- To unsubscribe from this list:

Re: [PATCH RESEND 14/18] megaraid_sas : move endianess conversion into caller of megasas_get_seq_num

2015-04-21 Thread Tomas Henzl
On 04/20/2015 02:34 PM, sumit.sax...@avagotech.com wrote: Converting structure fields in place is always a bad idea, and in this case by moving it into the only caller we also only have to do a single byte swap as most fields of this structure are never used. Signed-off-by: Christoph Hellwig

Re: [PATCH RESEND 16/18] megaraid_sas : add missing byte swaps to the sriov code

2015-04-21 Thread Tomas Henzl
On 04/20/2015 02:35 PM, sumit.sax...@avagotech.com wrote: Signed-off-by: Christoph Hellwig h...@lst.de Reviewed-by: Tomas Henzl the...@redhat.com Tomas -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH RESEND 17/18] megaraid_sas : fix megasas_fire_cmd_fusion calling convention

2015-04-21 Thread Tomas Henzl
On 04/20/2015 02:35 PM, sumit.sax...@avagotech.com wrote: The fusion HBAs don't really use the instance template like the other variants, as it branches off at a much higher level. So instead of trying to squeeze megasas_fire_cmd_fusion into the wrong calling convention call it locally with

Re: [PATCH RESEND 10/18] megaraid_sas : megasas_complete_outstanding_ioctls() can be static

2015-04-21 Thread Tomas Henzl
On 04/20/2015 02:35 PM, sumit.sax...@avagotech.com wrote: drivers/scsi/megaraid/megaraid_sas_base.c:1701:6: sparse: symbol 'megasas_complete_outstanding_ioctls' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com Reviewed-by: Tomas Henzl

Re: [PATCH RESEND 18/18] megaraid_sas : swap whole register in megasas_register_aen

2015-04-21 Thread Christoph Hellwig
On Tue, Apr 21, 2015 at 02:33:12PM +0200, Tomas Henzl wrote: On 04/20/2015 02:35 PM, sumit.sax...@avagotech.com wrote: Swap the whole 32 bits we read from the hardware instead of swapping just the 16bits we care about in place later. Signed-off-by: Christoph Hellwig h...@lst.de ---

Re: [PATCH RESEND v2 3/18] megaraid_sas : Add separate functions for building sysPD IOs and non RW LDIOs

2015-04-21 Thread Tomas Henzl
On 04/20/2015 04:21 PM, sumit.sax...@avagotech.com wrote: This patch will create separate functions for sysPD IOs and non Read/Write LDIOs. Signed-off-by: Kashyap Desai kashyap.de...@avagotech.com Signed-off-by: Sumit Saxena sumit.sax...@avagotech.com Reviewed-by: Tomas Henzl

Re: [PATCH 06/14] lpfc: Add support for RDP ELS command.

2015-04-21 Thread Sebastian Herbszt
James Smart wrote: Add support for RDP ELS command. Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc.h | 1 + drivers/scsi/lpfc/lpfc_crtn.h | 2 + drivers/scsi/lpfc/lpfc_els.c | 415

RE: [PATCH RESEND 18/18] megaraid_sas : swap whole register in megasas_register_aen

2015-04-21 Thread Sumit Saxena
-Original Message- From: Christoph Hellwig [mailto:h...@infradead.org] Sent: Tuesday, April 21, 2015 6:07 PM To: Tomas Henzl Cc: sumit.sax...@avagotech.com; linux-scsi@vger.kernel.org; martin.peter...@oracle.com; h...@infradead.org; jbottom...@parallels.com; kashyap.de...@avagotech.com

[PATCH] aha1542: Allocate memory before taking a lock

2015-04-21 Thread Ondrej Zary
The driver currently calls kmalloc with GFP_KERNEL while holding a lock. Fix it by doing the allocation earlier, before taking the lock. Tested on AHA-1542B. Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 23 +++ 1 file changed, 11

RE: [PATCH v3 10/20] lpfc: Fix provide host name and OS name in RSNN-NN FC-GS command

2015-04-21 Thread James Smart
Primarily emulex applications that display san connectivity. There are also some Switch mgmt suites that at least display this information. Not sure how much they act on it. -- james s From: Sebastian Herbszt [herb...@gmx.de] Sent: Tuesday, April 21,

Re: [PATCH 1/3] block: Return error in rescan_partitions if revalidating disk failed

2015-04-21 Thread James Bottomley
On Tue, 2015-03-24 at 18:16 +0800, Fam Zheng wrote: If the disk can't read capacity, we should return an error. I'm not sure I buy this: you need to justify why. For instance removable media return an error in revalidate that causes the medium not present flag to be set ... do we really want to

Re: [PATCH 1/3] block: Return error in rescan_partitions if revalidating disk failed

2015-04-21 Thread Fam Zheng
On Tue, 04/21 19:58, James Bottomley wrote: On Tue, 2015-03-24 at 18:16 +0800, Fam Zheng wrote: If the disk can't read capacity, we should return an error. I'm not sure I buy this: you need to justify why. For instance removable media return an error in revalidate that causes the medium

[PATCH v2 2/4] target: Abandon odd SG mapping for data transfer memory

2015-04-21 Thread Akinobu Mita
sbc_dif_generate() and sbc_dif_verify() assume that each SG element for data transfer memory doesn't straddle the block size boundary. However, when using SG_IO ioctl, we can choose the data transfer memory which doesn't satisfy that alignment requirement. This change detects such cases and

[PATCH v2 4/4] target/file: enable WRITE SAME when protection info is enabled

2015-04-21 Thread Akinobu Mita
Now we can generate correct PI for WRITE SAME command, so it is unnecessary to disallow WRITE SAME when protection info is enabled. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Nicholas Bellinger n...@linux-iscsi.org Cc: Sagi Grimberg sa...@mellanox.com Cc: Martin K. Petersen

[PATCH v2 3/4] target: Fix sbc_dif_generate() and sbc_dif_verify() for WRITE SAME

2015-04-21 Thread Akinobu Mita
For WRITE SAME, data transfer memory only contains a single block but protection information is required for all blocks that are written by the command. This makes sbc_dif_generate() and sbc_dif_verify() work for WRITE_SAME. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Nicholas

[PATCH v2 1/4] target: ensure se_cmd-t_prot_sg is allocated when required

2015-04-21 Thread Akinobu Mita
Even if the device backend is initialized with protection info is enabled, some requests don't have the protection info attached for WRITE SAME command issued by block device helpers, WRITE command with WRPROTECT=0 by SG_IO ioctl, etc. So when TCM loopback fabric module is used, se_cmd-t_prot_sg

[PATCH v2 0/4] target: Fix several problems related to T10-PI support

2015-04-21 Thread Akinobu Mita
This patchset aims to fix several problems related to T10-PI support. These patches can be applied on top of Sagi's [v1] Simlify dif_verify routines and fixup fileio protection information code patchset. * Changes from v1: - Reduce code duplication a bit in target_read_prot_action() - Fix

Re: [PATCH v3 10/20] lpfc: Fix provide host name and OS name in RSNN-NN FC-GS command

2015-04-21 Thread Sebastian Herbszt
James Smart wrote: Fixes those things that parse the result of what data is registered with the fabric. -- james Any particular thing you got on your mind? qla2xxx does not provide this information (yet). Sebastian -- To unsubscribe from this list: send the line unsubscribe linux-scsi in

Re: [PATCH RESEND 4/18] megaraid_sas : Move controller's queue depth calculation in adapter specific function

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 02:33 PM, sumit.sax...@avagotech.com wrote: This patch will move controller's queue depth calculation in adapter specific functions. Signed-off-by: Kashyap Desai kashyap.de...@avagotech.com Signed-off-by: Sumit Saxena sumit.sax...@avagotech.com ---

Re: [PATCH RESEND 12/18] megaraid_sas : add endianess annotations

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 02:34 PM, sumit.sax...@avagotech.com wrote: This adds endianness annotations to all data structures, and a few variables directly referencing them. Signed-off-by: Christoph Hellwig h...@lst.de --- Reviewed-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes

Re: [PATCH RESEND 14/18] megaraid_sas : move endianess conversion into caller of megasas_get_seq_num

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 02:34 PM, sumit.sax...@avagotech.com wrote: Converting structure fields in place is always a bad idea, and in this case by moving it into the only caller we also only have to do a single byte swap as most fields of this structure are never used. Signed-off-by: Christoph Hellwig

Re: [PATCH RESEND 13/18] megaraid_sas : add endianess conversions for all ones

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 02:34 PM, sumit.sax...@avagotech.com wrote: Add noop conversions for all ones to make sparse happy. Signed-off-by: Christoph Hellwig h...@lst.de --- Reviewed-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de

Re: [PATCH RESEND v2 3/18] megaraid_sas : Add separate functions for building sysPD IOs and non RW LDIOs

2015-04-21 Thread Christoph Hellwig
Looks generally good, but the MEGASAS_DEV_INDEX prototype change should be a patch on it's own. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND 9/18] megaraid_sas : Support for Avago's Single server High Availability product

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 02:33 PM, sumit.sax...@avagotech.com wrote: This patch will add support for Single Server High Availability(SSHA) cluster support. Here is the short decsription of changes done to add support for SSHA- 1) Host will send system's Unique ID based on DMI_PRODUCT_UUID to firmware.

RE: [PATCH RESEND 4/18] megaraid_sas : Move controller's queue depth calculation in adapter specific function

2015-04-21 Thread Sumit Saxena
-Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Tuesday, April 21, 2015 3:52 PM To: sumit.sax...@avagotech.com; linux-scsi@vger.kernel.org Cc: the...@redhat.com; martin.peter...@oracle.com; h...@infradead.org; jbottom...@parallels.com; kashyap.de...@avagotech.com

RE: [PATCH RESEND 5/18] megaraid_sas : Enhanced few prints

2015-04-21 Thread Sumit Saxena
-Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Tuesday, April 21, 2015 3:54 PM To: sumit.sax...@avagotech.com; linux-scsi@vger.kernel.org Cc: the...@redhat.com; martin.peter...@oracle.com; h...@infradead.org; jbottom...@parallels.com; kashyap.de...@avagotech.com

Re: [PATCH 4/4] target/file: enable WRITE SAME when protection info is enabled

2015-04-21 Thread Akinobu Mita
2015-04-21 8:36 GMT+09:00 Akinobu Mita akinobu.m...@gmail.com: Now we can generate correct PI for WRITE SAME command, so it is unnecessary to disallow WRITE SAME when protection info is enabled. I noticed that this patch has multiple problems. @@ -381,11 +381,6 @@ fd_execute_write_same(struct

Re: [PATCH RESEND 5/18] megaraid_sas : Enhanced few prints

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 02:33 PM, sumit.sax...@avagotech.com wrote: This patch will update few prints. Signed-off-by: Sumit Saxena sumit.sax...@avagotech.com --- drivers/scsi/megaraid/megaraid_sas_base.c | 49 ++--- 1 files changed, 24 insertions(+), 25 deletions(-)

Re: [PATCH RESEND 16/18] megaraid_sas : add missing byte swaps to the sriov code

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 02:35 PM, sumit.sax...@avagotech.com wrote: Signed-off-by: Christoph Hellwig h...@lst.de --- Reviewed-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX

Re: [PATCH RESEND 15/18] megaraid_sas : bytewise or should be done on native endian variables

2015-04-21 Thread Hannes Reinecke
On 04/20/2015 02:34 PM, sumit.sax...@avagotech.com wrote: Signed-off-by: Christoph Hellwig h...@lst.de --- drivers/scsi/megaraid/megaraid_sas_fusion.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) Reviewed-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes

Re: [PATCH 01/14] lpfc: The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence

2015-04-21 Thread Sebastian Herbszt
James Smart wrote: The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence Signed-off-by: Dick Kennedy dick.kenn...@emulex.com Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_hbadisc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH RESEND 5/18] megaraid_sas : Enhanced few prints

2015-04-21 Thread Hannes Reinecke
On 04/21/2015 01:15 PM, Sumit Saxena wrote: -Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Tuesday, April 21, 2015 3:54 PM To: sumit.sax...@avagotech.com; linux-scsi@vger.kernel.org Cc: the...@redhat.com; martin.peter...@oracle.com; h...@infradead.org;

RE: [PATCH RESEND 1/18] megaraid_sas : Add separate function for setting up IRQs

2015-04-21 Thread Sumit Saxena
-Original Message- From: Christoph Hellwig [mailto:h...@infradead.org] Sent: Tuesday, April 21, 2015 4:04 PM To: sumit.sax...@avagotech.com Cc: linux-scsi@vger.kernel.org; the...@redhat.com; martin.peter...@oracle.com; h...@infradead.org; jbottom...@parallels.com;

[PATCH v3] fusion: remove dead MTRR code

2015-04-21 Thread Luis R. Rodriguez
From: Luis R. Rodriguez mcg...@suse.com If and when this gets enabled the driver could should split up IO memory space properly and that is quite a bit of work. Just remove the uncommented dead MTRR code then. There are a few motivations for this: a) Take advantage of PAT when available b)