Re: [REGRESSION v4.3] scsi_dh: use-after-free when removing scsi device

2015-10-06 Thread Junichi Nomura
On 10/04/15 16:42, Christoph Hellwig wrote: > Any chance you could share your various scripts in some way to that > people doing multipath changes can run them to verify those changes? Hi Christoph, I've refined some pieces of test scripts which could be useful for people and posted here: http:

dm-multipath test scripts

2015-10-06 Thread Junichi Nomura
This is a set of scripts for kernel-side dm-multipath testing. Current set of scripts are stress testing of extreme situation and its coverage is limited. But recently found dm-mpath regressions should be detectable with this. I hope this helps people working on dm-multipath related code as a regre

[PATCH 1/1] scsi: storvsc: Fix a bug in the handling of SRB status flags

2015-10-06 Thread K. Y. Srinivasan
SRB status can have additional information. Mask these out before processing SRB status. This patch was sent as part of a collection of patches more than a year ago. While the rest of the patches in the set were comitted, this patch was not. I woulod like to thank Olaf for noticing that this patc

Re: RFC: reduce CONFIG_SCSI_CONSTANTS impact by 4k

2015-10-06 Thread Julian Calaby
Hi Rasmus, On Wed, Oct 7, 2015 at 2:39 AM, Rasmus Villemoes wrote: > On Tue, Oct 06 2015, Julian Calaby wrote: > >> Hi Rasmus, >> >>> >>> diff --git a/drivers/scsi/constants.c b/drivers/scsi/constants.c >>> index 47aaccd5e68e..ccd34b0481cd 100644 >>> --- a/drivers/scsi/constants.c >>> +++ b/driv

Re: [PATCH -resend 1/1] fcoe: use continue instead of goto+label

2015-10-06 Thread Vasu Dev
On Tue, 2015-10-06 at 14:27 +0200, Jiri Slaby wrote: > There is a label pointing to the start of a while loop and a goto > nested only in the loop. The goto jumps to the label in some cases. > Replace the goto and the label by simple continue. > > Signed-off-by: Jiri Slaby > Cc: Robert Love > Cc

Re: [PATCHv3 1/1] SCSI: update hosts module to use idr index management

2015-10-06 Thread Lee Duncan
On 10/06/2015 12:19 PM, James Bottomley wrote: > On Tue, 2015-10-06 at 12:08 -0700, Lee Duncan wrote: >> Update the SCSI hosts module to use idr to manage >> its host_no index instead of an ATOMIC integer. This >> also allows using idr_find() to look up the SCSI >> host structure given the host num

[PATCH] scsi: advansys: fix big-endian builds

2015-10-06 Thread Arnd Bergmann
Building the advansys driver in a big-endian configuration such as ARM allmodconfig shows a warning: drivers/scsi/advansys.c: In function 'adv_build_req': include/uapi/linux/byteorder/big_endian.h:32:26: warning: large integer implicitly truncated to unsigned type [-Woverflow] #define __cpu_t

Re: [PATCHv3 1/1] SCSI: update hosts module to use idr index management

2015-10-06 Thread James Bottomley
On Tue, 2015-10-06 at 12:08 -0700, Lee Duncan wrote: > Update the SCSI hosts module to use idr to manage > its host_no index instead of an ATOMIC integer. This > also allows using idr_find() to look up the SCSI > host structure given the host number. > > This means that the SCSI host number will n

[PATCHv3 1/1] SCSI: update hosts module to use idr index management

2015-10-06 Thread Lee Duncan
Update the SCSI hosts module to use idr to manage its host_no index instead of an ATOMIC integer. This also allows using idr_find() to look up the SCSI host structure given the host number. This means that the SCSI host number will now be reclaimable. Signed-off-by: Lee Duncan Reviewed-by: Hanne

[PATCHv3 0/1] Update SCSI hosts to use idr for host number mgmt

2015-10-06 Thread Lee Duncan
This patch updates the SCSI hosts module to use the idr index-management routines to manage its host_no index instead of using an ATOMIC integer. This means that host numbers can now be reclaimed and re-used. It also updates the hosts module to use the idr routine idr_find() to lookup hosts based

Re: [PATCHv2 1/1] SCSI: update hosts module to use idr index management

2015-10-06 Thread James Bottomley
On Tue, 2015-10-06 at 10:14 -0700, Lee Duncan wrote: > On 10/06/2015 02:40 AM, Christoph Hellwig wrote: > >> struct Scsi_Host *scsi_host_lookup(unsigned short hostnum) > >> { > >> - struct device *cdev; > >> - struct Scsi_Host *shost = NULL; > >> - > >> - cdev = class_find_device(&shost_class,

Re: [PATCH 00/18] mpt2sas, mpt3sas: Combine mpt2sas and mpt3sas driver code base

2015-10-06 Thread James Bottomley
On Tue, 2015-10-06 at 15:59 +0530, Sreekanth Reddy wrote: > On Tue, Oct 6, 2015 at 3:16 PM, Christoph Hellwig wrote: > > This series seems to miss patch 5 which actually removes the mpt2sas > > driver - it probably was too large for the list. > > [Sreekanth] > > Yes Chris, As this Phase5 size is

Re: [PATCHv2 1/1] SCSI: update hosts module to use idr index management

2015-10-06 Thread Lee Duncan
On 10/06/2015 02:40 AM, Christoph Hellwig wrote: >> struct Scsi_Host *scsi_host_lookup(unsigned short hostnum) >> { >> -struct device *cdev; >> -struct Scsi_Host *shost = NULL; >> - >> -cdev = class_find_device(&shost_class, NULL, &hostnum, >> - __scsi_host

Re: [PATCH 1/1] be2iscsi : Add warning message for unsupported adapter

2015-10-06 Thread Mike Christie
On 07/31/2015 05:20 PM, Ketan Mukadam wrote: > Add a warning message to indicate obsolete/unsupported > BE2 Adapter Family devics > > Signed-off-by: Ketan Mukadam > --- > drivers/scsi/be2iscsi/be_main.c | 2 ++ > drivers/scsi/be2iscsi/be_mgmt.c | 3 ++- > 2 files changed, 4 insertions(+), 1 dele

Re: [PATCH 0/2] be2iscsi : Revert ownership and update MAINTAINER

2015-10-06 Thread Mike Christie
On 07/03/2015 05:42 PM, Ketan Mukadam wrote: > Revert the ownership to Emulex and update the MAINTAINER for be2iscsi > > Ketan Mukadam (2): > MAINTAINERS: Update MAINTAINER list > be2iscsi: Revert ownership to Emulex > > MAINTAINERS | 4 ++-- > drivers/scsi/be2iscsi/Kcon

Re: RFC: reduce CONFIG_SCSI_CONSTANTS impact by 4k

2015-10-06 Thread Rasmus Villemoes
On Tue, Oct 06 2015, Julian Calaby wrote: > Hi Rasmus, > >> >> diff --git a/drivers/scsi/constants.c b/drivers/scsi/constants.c >> index 47aaccd5e68e..ccd34b0481cd 100644 >> --- a/drivers/scsi/constants.c >> +++ b/drivers/scsi/constants.c >> @@ -292,17 +292,31 @@ bool scsi_opcode_sa_name(int opco

Re: [PATCH 2/2] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k

2015-10-06 Thread Rasmus Villemoes
On Mon, Oct 05 2015, Bart Van Assche wrote: > On 10/05/15 02:26, Rasmus Villemoes wrote: >> struct error_info { >> unsigned short code12; /* 0x0302 looks better than 0x03,0x02 */ >> -const char * text; >> +unsigned short size; >> }; > > Had you considered to use the type uint16_

Re: [PATCH 1/2] scsi: move Additional Sense Codes to separate file

2015-10-06 Thread Rasmus Villemoes
On Mon, Oct 05 2015, Bart Van Assche wrote: > On 10/05/15 02:26, Rasmus Villemoes wrote: >> -{0x041A, "Logical unit not ready, start stop unit command in " >> - "progress"}, >> -{0x041B, "Logical unit not ready, sanitize in progress"}, >> -{0x041C, "Logical unit not ready, additio

[PATCH v1] scsi: ufs: add ioctl interface for query request

2015-10-06 Thread Yaniv Gardi
This patch exposes the ioctl interface for UFS driver via SCSI device ioctl interface. As of now UFS driver would provide the ioctl for query interface to connected UFS device. Signed-off-by: Dolev Raviv Signed-off-by: Noa Rubens Signed-off-by: Raviv Shvili Signed-off-by: Gilad Broner Signed-o

Re: [PATCHv2 1/1] SCSI: update hosts module to use idr index management

2015-10-06 Thread Hannes Reinecke
On 10/06/2015 01:01 AM, Lee Duncan wrote: Update the SCSI hosts module to use idr to manage its host_no index instead of an ATOMIC integer. This also allows using idr_find() to look up the SCSI host structure given the host number. This means that the SCSI host number will now be reclaimable. S

Re: [PATCH -resend 1/1] fcoe: use continue instead of goto+label

2015-10-06 Thread Johannes Thumshirn
On Tuesday 06 October 2015 14:27:45 Jiri Slaby wrote: > There is a label pointing to the start of a while loop and a goto > nested only in the loop. The goto jumps to the label in some cases. > Replace the goto and the label by simple continue. > > Signed-off-by: Jiri Slaby > Cc: Robert Love > C

[PATCH -resend 1/1] fcoe: use continue instead of goto+label

2015-10-06 Thread Jiri Slaby
There is a label pointing to the start of a while loop and a goto nested only in the loop. The goto jumps to the label in some cases. Replace the goto and the label by simple continue. Signed-off-by: Jiri Slaby Cc: Robert Love Cc: fcoe-de...@open-fcoe.org --- Sent on: May 5 drivers/scsi/fcoe/f

Re: [PATCH -resend_2 1/1] cxgbi: fix build with EXTRA_CFLAGS

2015-10-06 Thread Johannes Thumshirn
Jiri Slaby writes: > EXTRA_CFLAGS are intended to be used on the command line, not by > Kbuild. In case of cxgbi drivers, use of EXTRA_CFLAGS results in a > compilation failure: > drivers/scsi/cxgbi/cxgb4i/cxgb4i.c:24:21: fatal error: t4_regs.h: No such > file or directory > when building like:

[PATCH -resend_2 1/1] cxgbi: fix build with EXTRA_CFLAGS

2015-10-06 Thread Jiri Slaby
EXTRA_CFLAGS are intended to be used on the command line, not by Kbuild. In case of cxgbi drivers, use of EXTRA_CFLAGS results in a compilation failure: drivers/scsi/cxgbi/cxgb4i/cxgb4i.c:24:21: fatal error: t4_regs.h: No such file or directory when building like: $ make drivers/scsi/cxgbi/ EXTRA_

Re: [PATCH 00/18] mpt2sas, mpt3sas: Combine mpt2sas and mpt3sas driver code base

2015-10-06 Thread Sreekanth Reddy
On Tue, Oct 6, 2015 at 3:16 PM, Christoph Hellwig wrote: > This series seems to miss patch 5 which actually removes the mpt2sas > driver - it probably was too large for the list. [Sreekanth] Yes Chris, As this Phase5 size is 680K, so I think it failed to get into linux-scsi mail list. In this pa

Re: [PATCH 00/18] mpt2sas, mpt3sas: Combine mpt2sas and mpt3sas driver code base

2015-10-06 Thread Christoph Hellwig
This series seems to miss patch 5 which actually removes the mpt2sas driver - it probably was too large for the list. I also don't really like the -DMPT2_SAS thing, but given that diver merges are painful I'd suggest to merge it as-is and then see if we can convert it to build a mpt_common module

Re: [PATCHv2 1/1] SCSI: update hosts module to use idr index management

2015-10-06 Thread Christoph Hellwig
> struct Scsi_Host *scsi_host_lookup(unsigned short hostnum) > { > - struct device *cdev; > - struct Scsi_Host *shost = NULL; > - > - cdev = class_find_device(&shost_class, NULL, &hostnum, > - __scsi_host_match); > - if (cdev) { > - shost =