Re: Testing latest linux-next 4.9 ib_srp and ib_srpt

2016-12-21 Thread Christoph Hellwig
I just got CC'ed to a massive chain of full quotes. If you want an answer from me please write a readable mail, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majo

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

2016-12-21 Thread Dave Chinner
On Wed, Dec 21, 2016 at 09:46:37PM -0800, Linus Torvalds wrote: > On Wed, Dec 21, 2016 at 9:13 PM, Dave Chinner wrote: > > > > There may be deeper issues. I just started running scalability tests > > (e.g. 16-way fsmark create tests) and about a minute in I got a > > directory corruption reported

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

2016-12-21 Thread Christoph Hellwig
On Thu, Dec 22, 2016 at 05:30:46PM +1100, Dave Chinner wrote: > > For "normal" bios the for_each_segment loop iterates over bi_vcnt, > > so it will be ignored anyway. That being said both I and the lists > > got CCed halfway through the thread and I haven't seen the original > > report, so I'm not

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

2016-12-21 Thread Dave Chinner
On Thu, Dec 22, 2016 at 07:18:27AM +0100, Christoph Hellwig wrote: > On Wed, Dec 21, 2016 at 03:19:15PM -0800, Linus Torvalds wrote: > > Looking around a bit, the only even halfway suspicious scatterlist > > initialization thing I see is commit f9d03f96b988 ("block: improve > > handling of the magi

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

2016-12-21 Thread Dave Chinner
On Thu, Dec 22, 2016 at 04:13:22PM +1100, Dave Chinner wrote: > On Wed, Dec 21, 2016 at 04:13:03PM -0800, Chris Leech wrote: > > On Wed, Dec 21, 2016 at 03:19:15PM -0800, Linus Torvalds wrote: > > > Hi, > > > > > > On Wed, Dec 21, 2016 at 2:16 PM, Dave Chinner wrote: > > > > On Fri, Dec 16, 2016

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

2016-12-21 Thread Christoph Hellwig
On Wed, Dec 21, 2016 at 03:19:15PM -0800, Linus Torvalds wrote: > Looking around a bit, the only even halfway suspicious scatterlist > initialization thing I see is commit f9d03f96b988 ("block: improve > handling of the magic discard payload") which used to have a magic > hack wrt !bio->bi_vcnt, an

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

2016-12-21 Thread Linus Torvalds
On Wed, Dec 21, 2016 at 9:13 PM, Dave Chinner wrote: > > There may be deeper issues. I just started running scalability tests > (e.g. 16-way fsmark create tests) and about a minute in I got a > directory corruption reported - something I hadn't seen in the dev > cycle at all. By "in the dev cycle

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

2016-12-21 Thread Dave Chinner
On Wed, Dec 21, 2016 at 04:13:03PM -0800, Chris Leech wrote: > On Wed, Dec 21, 2016 at 03:19:15PM -0800, Linus Torvalds wrote: > > Hi, > > > > On Wed, Dec 21, 2016 at 2:16 PM, Dave Chinner wrote: > > > On Fri, Dec 16, 2016 at 10:59:06AM -0800, Chris Leech wrote: > > >> Thanks Dave, > > >> > > >>

Re: Testing latest linux-next 4.9 ib_srp and ib_srpt

2016-12-21 Thread Laurence Oberman
- Original Message - > From: "Laurence Oberman" > To: "Bart Van Assche" > Cc: linux-r...@vger.kernel.org > Sent: Wednesday, December 21, 2016 1:34:01 AM > Subject: Re: Testing latest linux-next 4.9 ib_srp and ib_srpt > > > > - Original Message - > > From: "Laurence Oberman"

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread George Cherian
Hi Oliver, I will try it out and update you!! Regards, -George On Wednesday 21 December 2016 08:09 PM, Oliver Neukum wrote: On Wed, 2016-12-21 at 18:17 +0530, George Cherian wrote: [ 843.149653] scsi host5: uas_post_reset: alloc streams error -19 after reset That would mean the endpoints

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

2016-12-21 Thread Chris Leech
On Wed, Dec 21, 2016 at 03:19:15PM -0800, Linus Torvalds wrote: > Hi, > > On Wed, Dec 21, 2016 at 2:16 PM, Dave Chinner wrote: > > On Fri, Dec 16, 2016 at 10:59:06AM -0800, Chris Leech wrote: > >> Thanks Dave, > >> > >> I'm hitting a bug at scatterlist.h:140 before I even get any iSCSI > >> modul

Re: iscsi_trx going into D state

2016-12-21 Thread Robert LeBlanc
I hit a new backtrace today, hopefully it adds something. # cat /proc/19659/stack [] iscsit_stop_session+0x1b1/0x1c0 [] iscsi_check_for_session_reinstatement+0x1e2/0x270 [] iscsi_target_check_for_existing_instances+0x30/0x40 [] iscsi_target_do_login+0x138/0x630 [] iscsi_target_start_negotiation+0x

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

2016-12-21 Thread Linus Torvalds
Hi, On Wed, Dec 21, 2016 at 2:16 PM, Dave Chinner wrote: > On Fri, Dec 16, 2016 at 10:59:06AM -0800, Chris Leech wrote: >> Thanks Dave, >> >> I'm hitting a bug at scatterlist.h:140 before I even get any iSCSI >> modules loaded (virtio block) so there's something else going on in the >> current me

Re: [PATCH] scsi: do not requeue requests unaligned with device sector size

2016-12-21 Thread Mauricio Faria de Oliveira
On 12/21/2016 05:50 AM, Christoph Hellwig wrote: > How do you even get an unaligned residual count? Except for SES > processor devices (which will only issue BLOCK_PC commands) this is > not allowed by SPC: > > "The residual count shall be reported in bytes if the peripheral device > type in the

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

2016-12-21 Thread Dave Chinner
On Fri, Dec 16, 2016 at 10:59:06AM -0800, Chris Leech wrote: > Thanks Dave, > > I'm hitting a bug at scatterlist.h:140 before I even get any iSCSI > modules loaded (virtio block) so there's something else going on in the > current merge window. I'll keep an eye on it and make sure there's > nothi

[PATCH v2 08/10] qla2xxx: Reduce exess wait during chip reset

2016-12-21 Thread Himanshu Madhani
From: Quinn Tran Soft reset and Risc reset should take 100uS to complete. This change pad the timeout up to 400uS, which should be plenty. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) d

[PATCH v2 10/10] qla2xxx: Disable Out-of-order processing by default in Firmware

2016-12-21 Thread Himanshu Madhani
From: Quinn Tran Out of order(OOO) processing requires initiator, switch and target to support OOO. In today¹s environment, none of the switches support OOO. OOO requires extra buffer space which affect performance. By turning ON this feature in QLogic's FW, it delays error recovery because drope

[PATCH v2 05/10] qla2xxx: Collect additional information to debug fw dump.

2016-12-21 Thread Himanshu Madhani
From: Quinn Tran Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_mbx.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index 2819ceb..b4386fc

[PATCH v2 09/10] qla2xxx: Fix invalid handle erroneous message.

2016-12-21 Thread Himanshu Madhani
From: Quinn Tran Termination of Immediate Notify IOCB was using wrong IOCB handle. IOCB completion code was unable to find appropriate code path due to wrong handle. Following message is seen in the logs. "Error entry - invalid handle/queue ()." Signed-off-by: Quinn Tran Signed-off-by: Hi

[PATCH v2 07/10] qla2xxx: Terminate exchange if corrputed.

2016-12-21 Thread Himanshu Madhani
From: Quinn Tran Corrupted ATIO is defined as length of fcp_header & fcp_cmd payload is less than 0x38. It's the minimum size for a frame to carry 8..16 bytes SCSI CDB. The exchange will be dropped or terminated if corrupted. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drive

[PATCH v2 06/10] qla2xxx: Fix crash due to null pointer access.

2016-12-21 Thread Himanshu Madhani
From: Quinn Tran This patch fixes crash due to NULL pointer access. Following stack trace will be seen. [1469877.797315] Call Trace: [1469877.799940] [] qla2x00_mem_alloc+0xb09/0x10c0 [qla2xxx] [1469877.806980] [] qla2x00_probe_one+0x86a/0x1b50 [qla2xxx] [1469877.814013] [] ? __pm_runtime_re

[PATCH v2 04/10] qla2xxx: Reset reserved field in firmware options to 0.

2016-12-21 Thread Himanshu Madhani
During NVRAM initialization in target mode, reset reserved fields in firmware options to Zero (BIT 15) Signed-off-by: Himanshu Madhani Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_target.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/dri

[PATCH v2 00/10] qla2xxx: Bug fixes for driver.

2016-12-21 Thread Himanshu Madhani
Hi Christoph, Bart, Here's updated series of bug fixes for target code in the driver. Please consider this for target-pending. Changes from v1 --> v2 o Updated patches to remove braces. o Added description for the patch reqeusted. Thanks, Himanshu Himanshu Madhani (3): qla2xxx: Include ATIO

[PATCH v2 02/10] qla2xxx: Include ATIO queue in firmware dump when in target mode

2016-12-21 Thread Himanshu Madhani
Include ATIO queue for ISP27XX when firmware dump is collected for target mode. Signed-off-by: Himanshu Madhani Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_tmpl.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/dr

[PATCH v2 01/10] qla2xxx: Fix wrong IOCB type assumption.

2016-12-21 Thread Himanshu Madhani
From: Quinn Tran qlt_reset is called with Immedidate Notify IOCB only. Current code wrongly cast it as ATIO IOCB. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/

[PATCH v2 03/10] qla2xxx: Set tcm_qla2xxx version to automatically track qla2xxx version.

2016-12-21 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 4 ++-- drivers/scsi/qla2xxx/tcm_qla2xxx.h | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c inde

[patch 04/10] scsi/bnx2i: Convert to hotplug state machine

2016-12-21 Thread Thomas Gleixner
From: Sebastian Andrzej Siewior Install the callbacks via the state machine. No functional change. This is the minimal fixup so we can remove the hotplug notifier mess completely. The real rework of this driver to use work queues is still stuck in review/testing on the SCSI mailing list. Signe

[patch 03/10] scsi/bnx2fc: Convert to hotplug state machine

2016-12-21 Thread Thomas Gleixner
From: Sebastian Andrzej Siewior Install the callbacks via the state machine. No functional change. This is the minimal fixup so we can remove the hotplug notifier mess completely. The real rework of this driver to use work queues is still stuck in review/testing on the SCSI mailing list. Signe

Re: [PATCH] ibmvscsi: add write memory barrier to CRQ processing

2016-12-21 Thread Tyrel Datwyler
On 12/09/2016 01:20 PM, Benjamin Herrenschmidt wrote: > On Wed, 2016-12-07 at 17:31 -0600, Tyrel Datwyler wrote: >> The first byte of each CRQ entry is used to indicate whether an entry is >> a valid response or free for the VIOS to use. After processing a >> response the driver sets the valid byte

Re: [PATCH] snic: Return error code on memory allocation failure

2016-12-21 Thread Ewan D. Milne
On Wed, 2016-12-21 at 14:45 +0100, Burak Ok wrote: > If a call to mempool_create_slab_pool() in snic_probe() returns NULL, > return -ENOMEM to indicate failure. mempool_creat_slab_pool() only fails if > it cannot allocate memory. > > https://bugzilla.kernel.org/show_bug.cgi?id=189061 > > Reported

Re: [PATCH] snic: Return error code on memory allocation failure

2016-12-21 Thread Narsimhulu Musini (nmusini)
On 21/12/16 7:15 pm, "Burak Ok" wrote: >If a call to mempool_create_slab_pool() in snic_probe() returns NULL, >return -ENOMEM to indicate failure. mempool_creat_slab_pool() only fails >if >it cannot allocate memory. > >https://bugzilla.kernel.org/show_bug.cgi?id=189061 > >Reported-by: bianpan2..

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread Oliver Neukum
On Wed, 2016-12-21 at 18:17 +0530, George Cherian wrote: > [ 843.149653] scsi host5: uas_post_reset: alloc streams error -19 > after > reset That would mean the endpoints are gone. Which is odd. > [ 843.157268] sd 5:0:0:0: [sdb] Synchronizing SCSI cache Could you try the attached patch and do

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread George Cherian
On 12/21/2016 05:12 PM, Oliver Neukum wrote: On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote: Hi Oliver, I was working with this JMicron device and using the uas driver. I am seeing the following 2 issues. 1) On connect I see the following messages. Thanks. Do you want to submit it

Re: [PATCH] scsi: do not requeue requests unaligned with device sector size

2016-12-21 Thread Martin K. Petersen
> "Mauricio" == Mauricio Faria de Oliveira > writes: Mauricio, Mauricio> When a SCSI command (e.g., read operation) is partially Mauricio> completed with good status and residual bytes (i.e., not all Mauricio> the bytes from the specified transfer length were transferred) Mauricio> the

[PATCH] snic: Return error code on memory allocation failure

2016-12-21 Thread Burak Ok
If a call to mempool_create_slab_pool() in snic_probe() returns NULL, return -ENOMEM to indicate failure. mempool_creat_slab_pool() only fails if it cannot allocate memory. https://bugzilla.kernel.org/show_bug.cgi?id=189061 Reported-by: bianpan2...@ruc.edu.cn Signed-off-by: Burak Ok Signed-off-b

Re: [PATCH] scsi: qla4xxx: Use dma_pool_zalloc

2016-12-21 Thread Souptick Joarder
On Wed, Dec 21, 2016 at 5:13 PM, Javali, Nilesh wrote: > > > On 13/12/16, 6:35 PM, "Souptick Joarder" wrote: > >>On Tue, Dec 13, 2016 at 4:11 PM, Javali, Nilesh >> wrote: >>> >>> >>> On 12/12/16, 10:16 AM, "linux-scsi-ow...@vger.kernel.org on behalf of >>> Souptick Joarder" >> jrdr.li...@gmail.co

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread George Cherian
On 12/21/2016 05:50 PM, Hans de Goede wrote: Hi, On 21-12-16 13:07, George Cherian wrote: On 12/21/2016 05:12 PM, Oliver Neukum wrote: On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote: Hi Oliver, I was working with this JMicron device and using the uas driver. I am seeing the foll

[Bug 176951] boot fails unless acpi=off Acer Travelmate X-349

2016-12-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=176951 --- Comment #9 from Martin Goyot --- Can now confirm. Updated Bios, can now run the x64 version. -- You are receiving this mail because: You are watching the assignee of the bug. -- To unsubscribe from this list: send the line "unsubscribe linu

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread Hans de Goede
Hi, On 21-12-16 13:07, George Cherian wrote: On 12/21/2016 05:12 PM, Oliver Neukum wrote: On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote: Hi Oliver, I was working with this JMicron device and using the uas driver. I am seeing the following 2 issues. 1) On connect I see the followi

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread Oliver Neukum
On Wed, 2016-12-21 at 17:37 +0530, George Cherian wrote: > > On 12/21/2016 05:12 PM, Oliver Neukum wrote: > > On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote: > >> Hi Oliver, > >> > >> I was working with this JMicron device and using the uas driver. > >> I am seeing the following 2 issues.

JMS56x not working reliably with uas driver

2016-12-21 Thread George Cherian
Hi Oliver, I was working with this JMicron device and using the uas driver. I am seeing the following 2 issues. 1) On connect I see the following messages. xhci_hcd :00:11.0: ERROR Transfer event for disabled endpoint or incorrect stream ring This was eliminated using the following scisso

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread Oliver Neukum
On Wed, 2016-12-21 at 12:54 +0100, Hans de Goede wrote: > Hi, > > On 21-12-16 12:42, Oliver Neukum wrote: > > On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote: > >> Hi Oliver, > >> > >> I was working with this JMicron device and using the uas driver. > >> I am seeing the following 2 issues.

Re: [PATCH] scsi: qla4xxx: Use dma_pool_zalloc

2016-12-21 Thread Javali, Nilesh
On 13/12/16, 6:35 PM, "Souptick Joarder" wrote: >On Tue, Dec 13, 2016 at 4:11 PM, Javali, Nilesh > wrote: >> >> >> On 12/12/16, 10:16 AM, "linux-scsi-ow...@vger.kernel.org on behalf of >> Souptick Joarder" > jrdr.li...@gmail.com> wrote: >> >>>On Wed, Dec 7, 2016 at 1:53 AM, Souptick Joarder >>

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread Hans de Goede
Hi, On 21-12-16 12:42, Oliver Neukum wrote: On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote: Hi Oliver, I was working with this JMicron device and using the uas driver. I am seeing the following 2 issues. 1) On connect I see the following messages. Thanks. Do you want to submit it t

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread Hans de Goede
Hi, On 21-12-16 12:39, George Cherian wrote: Hi Oliver, I was working with this JMicron device and using the uas driver. I am seeing the following 2 issues. 1) On connect I see the following messages. xhci_hcd :00:11.0: ERROR Transfer event for disabled endpoint or incorrect stream ring

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread Oliver Neukum
On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote: > Hi Oliver, > > I was working with this JMicron device and using the uas driver. > I am seeing the following 2 issues. > > 1) On connect I see the following messages. Thanks. Do you want to submit it to Greg? The patch is fine. > 2) On d

[Bug 176951] boot fails unless acpi=off Acer Travelmate X-349

2016-12-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=176951 Martin Goyot changed: What|Removed |Added CC||mar...@piwany.com --- Comment #8 from Mar

Re: [PATCH] scsi/bfa: use designated initializers

2016-12-21 Thread Christoph Hellwig
On Fri, Dec 16, 2016 at 05:05:15PM -0800, Kees Cook wrote: > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from

Re: [PATCH] scsi: do not requeue requests unaligned with device sector size

2016-12-21 Thread Hannes Reinecke
On 12/21/2016 08:50 AM, Christoph Hellwig wrote: > On Tue, Dec 20, 2016 at 12:02:27AM -0200, Mauricio Faria de Oliveira wrote: >> When a SCSI command (e.g., read operation) is partially completed >> with good status and residual bytes (i.e., not all the bytes from >> the specified transfer length w

Re: [PATCH] set a base index for libsas based ata devices

2016-12-21 Thread Christoph Hellwig
On Tue, Dec 20, 2016 at 10:30:34AM -0800, James Bottomley wrote: > I'd actually disagree with this assertion; it's why tagging (what you > mean by ncq) and queue depth are separate. Queue depth represents the > number of outstanding commands we sent on the wire; however, it often > excludes things