[PATCH v2] scsi: megaraid_sas: fix allocate instance->pd_info twice

fix allocate instance->pd_info twice which was introduced by 96188a89cc6d. Signed-off-by: weiping zhang --- drivers/scsi/megaraid/megaraid_sas_base.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH] sd_zbc: Write unlock zone from sd_uninit_cmnd()

Releasing the write lock of a zone when the write commnand that acquired the lock completes can cause deadlocks with scsi-mq due to potential queue reordering if the lock owning request is requeued and not executed. Since sd_uninit_cmnd() is always called when a request is requeued, call

Re: [PATCH v2 00/13] mpt3sas driver NVMe support:

On Mon, Aug 07, 2017 at 08:45:25AM -0700, James Bottomley wrote: > On Mon, 2017-08-07 at 20:01 +0530, Kashyap Desai wrote: > > > > We have to attempt this use case and see how it behaves. I have not > > tried this, so not sure if things are really bad or just some tuning > > may be helpful. I

Re: [PATCH] scsi: csiostor: fail probe if fw does not support FCoE

Varun, > Fail probe if FCoE capability is not enabled in the firmware. Applied to 4.13/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: megaraid_sas: fix error handle in megasas_probe_one

weiping, > megasas_mgmt_info.max_index has increased by 1 before > megasas_io_attach, if megasas_io_attach return error, then goto > fail_io_attach, megasas_mgmt_info.instance has a wrong index here. So > first reduce max_index and then set that instance to NULL. Applied to 4.13/scsi-fixes,

Re: [PATCH v2 0/4] aic7xxx: fix debugging printks

Michał, > This series aims to clean up printing of card state after a problem > event. Applied patches 1 through 4 to 4.14/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: Undefined behaviour in drivers/scsi/sym53c8xx_2/sym_hipd.c:762:24

On 05.08.2017 00:12, Helge Deller wrote: > On the parisc platform I noticed the UBSAN warning below. > Maybe nr_divisor isn't correctly initialized ? > > [ 18.625415] > > [ 18.726489] UBSAN: Undefined behaviour

Re: [PATCH v2 12/20] lpfc: Limit amount of work processed in IRQ

On 8/7/2017 1:43 AM, Johannes Thumshirn wrote: On Fri, Aug 04, 2017 at 05:47:23PM -0700, James Smart wrote: From: Dick Kennedy Various oops being seen on being in the ISR too long and cpu lockups, when under heavy load. The amount of work being posted off of

Re: [PATCH v2 04/20] lpfc: Fix oops when NVME Target is discovered in a nonNVME environment

On 8/7/2017 1:00 AM, Johannes Thumshirn wrote: On Fri, Aug 04, 2017 at 05:47:15PM -0700, James Smart wrote: From: Dick Kennedy lpfc oops when it discovers a NVME target but is configured for SCSI only operation. Oops is in lpfc_nvme_register_port+0x33/0x300. Why

Re: [PATCH] scsi-mq: Always unprepare before requeuing a request

Bart, > One of the two scsi-mq functions that requeue a request unprepares a > request before requeueing (scsi_io_completion()) but the other > function not (__scsi_queue_insert()). Make sure that a request is > unprepared before requeuing it. Applied to 4.13/scsi-fixes. Thanks much! --

RE: [PATCH] scsi: megaraid_sas: fix error handle in megasas_probe_one

>-Original Message- >From: weiping zhang [mailto:zhangweip...@didichuxing.com] >Sent: Monday, August 07, 2017 10:57 PM >To: kashyap.de...@broadcom.com; sumit.sax...@broadcom.com; >shivasharan.srikanteshw...@broadcom.com >Cc: megaraidlinux@broadcom.com; linux-scsi@vger.kernel.org

[PATCH] scsi: megaraid_sas: fix error handle in megasas_probe_one

megasas_mgmt_info.max_index has increased by 1 before megasas_io_attach, if megasas_io_attach return error, then goto fail_io_attach, megasas_mgmt_info.instance has a wrong index here. So first reduce max_index and then set that instance to NULL. Signed-off-by: weiping zhang

Re: [PATCH] ipr: Fix scsi-mq lockdep issue

Brian, > Fixes the following lockdep warning that can occur when scsi-mq is > enabled with ipr due to ipr calling scsi_unblock_requests from irq > context. The fix is to move the call to scsi_unblock_requests to ipr's > existing workqueue. Applied to 4.13/scsi-fixes. Thank you! -- Martin K.

Re: [PATCH] st: fix blk_get_queue usage

Hannes, > If blk_queue_get() in st_probe fails, disk->queue must not be set to > SDp->request_queue, as that would result in put_disk() dropping a not > taken reference. > > Thus, disk->queue should be set only after a successful > blk_queue_get(). Applied to 4.13/scsi-fixes. Thank you! --

Re: [PATCH 1/1] qla2xxx: Fix system crash while triggering FW dump

Himanshu, > Please apply this patch to 4.13.0-rc4. Without this patch our > capabilty to collect and analyze firmware dump in a customer > enviorment will be greatly affected. Applied to 4.13/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] megaraid_sas: move command counter to correct place

Tomas, > the eh reset function returns success when fw_outstanding equals zero, > that means that the counter shouldn't be decremented when the driver > still owns the command Applied to 4.13/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux Engineering

RE: [PATCH] megaraid_sas: move command counter to correct place

>-Original Message- >From: Tomas Henzl [mailto:the...@redhat.com] >Sent: Friday, July 28, 2017 7:34 PM >To: linux-scsi@vger.kernel.org >Cc: sumit.sax...@broadcom.com; kashyap.de...@broadcom.com >Subject: [PATCH] megaraid_sas: move command counter to correct place > >the eh reset function

Re: [PATCH 00/29] constify scsi pci_device_id.

Johannes, > Ultimately it's up to Martin and James but I don't see a hughe benefit > in having it all in a separate patch. Generally speaking, I prefer driver maintainers to be able to sign off on changes to their code. So I tend to lean towards a per-driver grouping. However, having a

Re: nvmf question - synchronization between target/initiator regarding partitions

Thanks for your feedback Hannes, agreed! Cheers, Guilherme

Re: [PATCH] megaraid_sas: move command counter to correct place

Tomas, > the eh reset function returns success when fw_outstanding equals zero, > that means that the counter shouldn't be decremented > when the driver still owns the command Kashyap? Sumit? -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 00/22] zfcp fixes and cleanups

Hi Benjamin, > here is a series of (important) fixes and some additional cleanups for > the zfcp driver. Our fixes are marked for stable accordingly. > > Patches 01 - 04 are cleanups and external patches (also cleanups) that we > & 13 - 22 had queued for quite some time now > > Patches

Re: [PATCH] MAINTAINERS: Add myself to S390 ZFCP DRIVER as a co-maintainer

Benjamin, > I have been working with Steffen on zFCP for quite a while now and we > decided adding me as a co-maintainer might be a good thing. Applied to 4.14/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [RFC 6/9] scsi: fc: start decoupling fc_block_scsi_eh from scsi_cmnd

Steffen, > Scsi_cmnd is an unsuitable argument for eh_device_reset_handler(), > eh_target_reset_handler(), and eh_host_reset_handler() which do not > have the scope of one single SCSI command. These callbacks tend to > use fc_block_scsi_eh() requiring scsi_cmnd. In order to start > decoupling

Re: [PATCH v2 00/13] mpt3sas driver NVMe support:

On Mon, 2017-08-07 at 20:01 +0530, Kashyap Desai wrote: > > > > -Original Message- > > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com > > ] > > Sent: Monday, August 07, 2017 7:48 PM > > To: Kashyap Desai; Christoph Hellwig; Hannes Reinecke > > Cc: Suganath Prabu

Re: nvmf question - synchronization between target/initiator regarding partitions

On 08/07/2017 03:42 PM, Guilherme G. Piccoli wrote: > We observed that it's possible to perform partition operations in both > nvmf target and initiator block devices, like creating and deleting > partitions. > > But there is no sync mechanism between target and initiator regarding > the

RE: [PATCH v2 00/13] mpt3sas driver NVMe support:

> -Original Message- > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: Monday, August 07, 2017 7:48 PM > To: Kashyap Desai; Christoph Hellwig; Hannes Reinecke > Cc: Suganath Prabu Subramani; martin.peter...@oracle.com; linux- > s...@vger.kernel.org; Sathya

Re: [PATCH v2 00/13] mpt3sas driver NVMe support:

On Mon, 2017-08-07 at 19:26 +0530, Kashyap Desai wrote: > > > > -Original Message- > > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com > > ] > > Sent: Saturday, August 05, 2017 8:12 PM > > To: Christoph Hellwig; Hannes Reinecke > > Cc: Suganath Prabu S;

RE: [PATCH v2 00/13] mpt3sas driver NVMe support:

> -Original Message- > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: Saturday, August 05, 2017 8:12 PM > To: Christoph Hellwig; Hannes Reinecke > Cc: Suganath Prabu S; martin.peter...@oracle.com; linux- > s...@vger.kernel.org; sathya.prak...@broadcom.com; >

nvmf question - synchronization between target/initiator regarding partitions

We observed that it's possible to perform partition operations in both nvmf target and initiator block devices, like creating and deleting partitions. But there is no sync mechanism between target and initiator regarding the partitions operations. After creating a partition on initiator, for

Re: Increased memory usage with scsi-mq

On 07/08/2017 14:27, Richard W.M. Jones wrote: > Also I noticed this code in virtio_scsi.c: > > cmd_per_lun = virtscsi_config_get(vdev, cmd_per_lun) ?: 1; > shost->cmd_per_lun = min_t(u32, cmd_per_lun, shost->can_queue); > > but setting cmd_per_lun (as a qemu virtio-scsi-pci

Re: Increased memory usage with scsi-mq

On Mon, Aug 07, 2017 at 02:11:39PM +0200, Paolo Bonzini wrote: > You could also add a module parameter to the driver, and set it to 64 on > the kernel command line (there is an example in > drivers/scsi/vmw_pvscsi.c of how to do it). [Proviso: I've not tested the performance of difference values,

Re: Increased memory usage with scsi-mq

On 05/08/2017 17:51, Richard W.M. Jones wrote: > On Sat, Aug 05, 2017 at 03:39:54PM +0200, Christoph Hellwig wrote: >> For now can you apply this testing patch to the guest kernel? >> >> diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c >> index 9be211d68b15..0cbe2c882e1c 100644

Re: [PATCH v2 19/20] scsi: lpfc: fix "integer constant too large" error on 32bit archs

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH v2 20/20] lpfc: lpfc version bump 11.4.0.3

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH v2 18/20] lpfc: Add Buffer to Buffer credit recovery support

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH v2 17/20] lpfc: remove console log clutter

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH v2 16/20] lpfc: Fix bad sgl reposting after 2nd adapter reset

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH v2 15/20] lpfc: Fix nvme target failure after 2nd adapter reset

On Fri, Aug 04, 2017 at 05:47:26PM -0700, James Smart wrote: > + > + /* Reestablish the local initiator port. > + * The offline process destroyed the previous lport. > + */ > + if (phba->cfg_enable_fc4_type & LPFC_ENABLE_NVME) { > +

Re: [PATCH v2 14/20] lpfc: Fix relative offset error on large nvmet target ios

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH v2 13/20] lpfc: Fix MRQ > 1 context list handling

On Fri, Aug 04, 2017 at 05:47:24PM -0700, James Smart wrote: > + tgtp = (struct lpfc_nvmet_tgtport *) > + phba->targetport->private; Please don't case void pointers. [...] > + list_splice(_infop->nvmet_ctx_list,

Re: [PATCH] scsi: mpt3sas: Fix memory allocation failure test in 'mpt3sas_base_attach()'

Le 07/08/2017 à 10:25, walter harms a écrit : Am 07.08.2017 00:51, schrieb Christophe JAILLET: In the lines above this test, 8 'kzalloc' are performed, but only 7 results are tested. Add the missing one (i.e. '!ioc->port_enable_cmds.reply'). Signed-off-by: Christophe JAILLET

Re: [PATCH v2 12/20] lpfc: Limit amount of work processed in IRQ

On Fri, Aug 04, 2017 at 05:47:23PM -0700, James Smart wrote: > From: Dick Kennedy > > Various oops being seen on being in the ISR too long and cpu > lockups, when under heavy load. > > The amount of work being posted off of completion queues kept > the ISR running

Re: [PATCH v2 10/20] lpfc: Fix NVME PRLI handling during RSCN

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH v2 09/20] lpfc: Fix crash in lpfc nvmet when fc port is reset

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH v2 08/20] lpfc: Fix duplicate NVME rport entries and namespaces.

On Fri, Aug 04, 2017 at 05:47:19PM -0700, James Smart wrote: > + /* For nvme, swap the nrport. */ > + keep_nrport = new_ndlp->nrport; > + new_ndlp->nrport = ndlp->nrport; > + The above comment did trigger a "Please use the swap() macro" warning in my brain, which isn't applicable

Re: [PATCH] scsi: mpt3sas: Fix memory allocation failure test in 'mpt3sas_base_attach()'

Am 07.08.2017 00:51, schrieb Christophe JAILLET: > In the lines above this test, 8 'kzalloc' are performed, but only 7 results > are tested. > > Add the missing one (i.e. '!ioc->port_enable_cmds.reply'). > > Signed-off-by: Christophe JAILLET > --- >

Re: [PATCH v2 07/20] lpfc: Fix handling of FCP and NVME FC4 types in Pt2Pt topology

On Fri, Aug 04, 2017 at 05:47:18PM -0700, James Smart wrote: > + case LSRJT_CMD_UNSUPPORTED: > + /* lpfc nvmet returns this type of LS_RJT when it > + * receives an FCP PRLI because lpfc nvmet only > + * support NVME. ELS

Re: [PATCH v2 06/20] lpfc: Correct return error codes to align with nvme_fc transport

The change itself is OK, but the Changelog is a bit odd to read, IMHO. Unfortunately I can't come up with a better version either. If you can think of one I'd be very happy. Thanks, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn

Re: [PATCH v2 05/20] lpfc: convert info messages to standard messages

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH v2 04/20] lpfc: Fix oops when NVME Target is discovered in a nonNVME environment

On Fri, Aug 04, 2017 at 05:47:15PM -0700, James Smart wrote: > From: Dick Kennedy > > lpfc oops when it discovers a NVME target but is configured for SCSI > only operation. Oops is in lpfc_nvme_register_port+0x33/0x300. Why does it even call lpfc_nvme_register_rport

Re: [PATCH v2 03/20] lpfc: Fix rediscovery on switch blade pull

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH v2 02/20] lpfc: Fix loop mode target discovery

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH v2 01/20] lpfc: Fix plogi collision that causes illegal state transition

On Fri, Aug 04, 2017 at 05:47:12PM -0700, James Smart wrote: > From: Dick Kennedy > > Message "0271 Illegal State Transition: node" seen in logs, all > luns are unuseable for that target. > > A window exists in the rcv_plogi path where if the state is plogi > issue

Re: [PATCH v2 2/2] lpfc: support nvmet_fc defer_rcv callback

Thanks, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH v2 1/2] nvmet_fc: add defer_req callback for deferment of cmd buffer return

Thanks James, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH] scsi-mq: Always unprepare before requeuing a request

Thanks Bart, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

https://bugzilla.kernel.org/show_bug.cgi?id=196517

Hi! I've also reproduced this issue on this kernel Linux desktop 4.10.0-28-generic #32~16.04.2-Ubuntu SMP Thu Jul 20 10:19:48 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Each one second, my program reads /sys/block/$DEVICE/stat. It substracts previously saved values, then saves

Re: [PATCH 1/2] block: Zoned block device single-threaded submission

Chistoph, On 8/5/17 20:34, Christoph Hellwig wrote: > We'll need a blk-mq version as well, otherwise: NAK. Not that I have not tried, but I do not see how this is possible without in the end making blk-mq/scsi-mq for a ZBC disk work exactly like the sq path, that is adding locks/barriers in many

Re: [PATCH 3/4] scsi: add Mylex RAID controller

On 08/05/2017 01:39 PM, Christoph Hellwig wrote: > Can you use normal linux style for the code instead of copy and > pasting the weird naming and capitalization from the DAC960 driver? > Yes; already planned for v2. But first wanted to get some general feedback (like: is anyone interested in that

Re: [PATCH v06 04/36] uapi scsi/scsi_netlink_fc.h: use __u16, __u32 and __u64 from linux/types.h

On Sun, Aug 06, 2017 at 03:09:21PM -0700, James Bottomley wrote: > On Sun, 2017-08-06 at 23:42 +0300, Mikko Rapeli wrote: > > Hi, > > > > On Sun, Aug 06, 2017 at 11:22:53AM -0700, James Bottomley wrote: > > > > > > On Sun, 2017-08-06 at 18:43 +0200, Mikko Rapeli wrote: > > > > > > > > Fixes

Re: [PATCH] scsi_dh_alua: suppress errors from unsupported devices

On 08/05/2017 01:35 PM, Christoph Hellwig wrote: >> error = scsi_dh_add_device(sdev); >> -if (error) >> -/* >> - * device_handler is optional, so any error can be ignored >> - */ >> -sdev_printk(KERN_INFO, sdev, >> -