Re: [PATCH] bsg referencing bus driver module

2018-04-19 Thread Anatoliy Glagolev
Updated: rebased on recent Linux, cc-ed maintainers per instructions in MAINTAINERS file >From df939b80d02bf37b21efaaef8ede86cfd39b0cb8 Mon Sep 17 00:00:00 2001 From: Anatoliy Glagolev Date: Thu, 19 Apr 2018 15:06:06 -0600 Subject: [PATCH] bsg referencing parent module

[Patch v2] Storvsc: Select channel based on available percentage of ring buffer to write

2018-04-19 Thread Long Li
From: Long Li This is a best effort for estimating on how busy the ring buffer is for that channel, based on available buffer to write in percentage. It is still possible that at the time of actual ring buffer write, the space may not be available due to other processes may

Re: scsi sd driver is not emitting a CHANGE uevent for online disk resizes

2018-04-19 Thread Sara
I see, thank you for the clarification.

Re: [PATCH blktests] scsi/004: add regression test for false BLK_STS_OK with non good SAM status

2018-04-19 Thread Omar Sandoval
On Thu, Apr 19, 2018 at 01:44:41PM -0600, Jens Axboe wrote: > On 4/19/18 1:41 PM, Bart Van Assche wrote: > > On Thu, 2018-04-19 at 12:13 -0700, Omar Sandoval wrote: > >> On Thu, Apr 19, 2018 at 11:53:30AM -0700, Omar Sandoval wrote: > >>> Thanks for the test! Applied. > >> > >> Side note, it's

Re: [PATCH blktests] scsi/004: add regression test for false BLK_STS_OK with non good SAM status

2018-04-19 Thread Jens Axboe
On 4/19/18 1:13 PM, Omar Sandoval wrote: > On Thu, Apr 19, 2018 at 11:53:30AM -0700, Omar Sandoval wrote: >> Thanks for the test! Applied. > > Side note, it's unfortunate that this test takes 180 seconds to run only > because we have to wait for the command timeout. We should be able to > export

Re: [PATCH blktests] scsi/004: add regression test for false BLK_STS_OK with non good SAM status

2018-04-19 Thread Jens Axboe
On 4/19/18 1:41 PM, Bart Van Assche wrote: > On Thu, 2018-04-19 at 12:13 -0700, Omar Sandoval wrote: >> On Thu, Apr 19, 2018 at 11:53:30AM -0700, Omar Sandoval wrote: >>> Thanks for the test! Applied. >> >> Side note, it's unfortunate that this test takes 180 seconds to run only >> because we have

Re: [PATCH blktests] scsi/004: add regression test for false BLK_STS_OK with non good SAM status

2018-04-19 Thread Bart Van Assche
On Thu, 2018-04-19 at 12:13 -0700, Omar Sandoval wrote: > On Thu, Apr 19, 2018 at 11:53:30AM -0700, Omar Sandoval wrote: > > Thanks for the test! Applied. > > Side note, it's unfortunate that this test takes 180 seconds to run only > because we have to wait for the command timeout. We should be

Re: [PATCH blktests] scsi/004: add regression test for false BLK_STS_OK with non good SAM status

2018-04-19 Thread Omar Sandoval
On Thu, Apr 19, 2018 at 11:53:30AM -0700, Omar Sandoval wrote: > Thanks for the test! Applied. Side note, it's unfortunate that this test takes 180 seconds to run only because we have to wait for the command timeout. We should be able to export request_queue->rq_timeout writeable in sysfs. Would

Re: simplify procfs code for seq_file instances

2018-04-19 Thread Alexey Dobriyan
> git://git.infradead.org/users/hch/misc.git proc_create I want to ask if it is time to start using poorman function overloading with _b_c_e(). There are millions of allocation functions for example, all slightly difference, and people will add more. Seeing /proc interfaces doubled like this

Re: [PATCH blktests] scsi/004: add regression test for false BLK_STS_OK with non good SAM status

2018-04-19 Thread Omar Sandoval
On Tue, Apr 17, 2018 at 11:03:37AM +0200, Steffen Maier wrote: > Signed-off-by: Steffen Maier > --- > tests/scsi/004 | 59 > > tests/scsi/004.out |3 ++ > 2 files changed, 62 insertions(+), 0 deletions(-) >

Re: [PATCH 1/1] scsi/ufs: qcom: Don't enable PHY_QCOM_UFS by default

2018-04-19 Thread Vivek Gautam
Hi Bjorn, On 4/18/2018 4:41 AM, Bjorn Andersson wrote: On Mon 09 Apr 23:31 PDT 2018, Vivek Gautam wrote: On 4/10/2018 1:39 AM, Bjorn Andersson wrote: On Mon 09 Apr 10:38 PDT 2018, Vivek Gautam wrote: On 4/9/2018 10:21 PM, Bjorn Andersson wrote: On Mon 09 Apr 06:24 PDT 2018, Vivek Gautam

Re: [PATCH 03/39] proc: introduce proc_create_seq_private

2018-04-19 Thread Alexey Dobriyan
On Thu, Apr 19, 2018 at 02:41:04PM +0200, Christoph Hellwig wrote: > Variant of proc_create_data that directly take a struct seq_operations > --- a/fs/proc/internal.h > +++ b/fs/proc/internal.h > @@ -45,6 +45,7 @@ struct proc_dir_entry { > const struct inode_operations *proc_iops; >

Re: [PATCH 14/39] proc: introduce proc_create_net_single

2018-04-19 Thread Alexey Dobriyan
On Thu, Apr 19, 2018 at 02:41:15PM +0200, Christoph Hellwig wrote: > Variant of proc_create_data that directly take a seq_file show > +struct proc_dir_entry *proc_create_net_single(const char *name, umode_t mode, > + struct proc_dir_entry *parent, > + int (*show)(struct

Re: [PATCH 02/39] proc: introduce proc_create_seq{,_data}

2018-04-19 Thread Alexey Dobriyan
On Thu, Apr 19, 2018 at 02:41:03PM +0200, Christoph Hellwig wrote: > Variants of proc_create{,_data} that directly take a struct seq_operations > argument and drastically reduces the boilerplate code in the callers. > +static int proc_seq_open(struct inode *inode, struct file *file) > +{ > +

Re: [PATCH v2] target/file: add support of direct and async I/O

2018-04-19 Thread Andrei Vagin
Hello Nicholas, What do you think about this patch? Thanks, Andrei On Wed, Mar 21, 2018 at 11:55:02PM -0700, Andrei Vagin wrote: > There are two advantages: > * Direct I/O allows to avoid the write-back cache, so it reduces > affects to other processes in the system. > * Async I/O allows to

[LSF/MM TOPIC] Extended copy

2018-04-19 Thread Bart Van Assche
During a recent discussion about peer-to-peer PCIe transfers it was brought up that it would be desirable to invoke this functionality from user space. One possible approach is to add support for an "extended copy" operation to the block layer and to make it possible to use that functionality from

Re: [PATCH] bsg referencing bus driver module

2018-04-19 Thread Anatoliy Glagolev
+linux-block On Tue, Apr 17, 2018 at 1:05 PM, Anatoliy Glagolev wrote: > Description: bsg_release may crash while decrementing reference to the > parent device with the following stack: > > [16834.636216,07] Call Trace: > ...

Re: [VERY EARLY RFC 00/13] Rework SCSI results handling

2018-04-19 Thread Bart Van Assche
On Thu, 2018-04-19 at 10:10 +0200, Johannes Thumshirn wrote: > On Wed, Apr 18, 2018 at 04:00:43PM +, Bart Van Assche wrote: > > Thank you for having come up with this so quickly. Something I do not > > like about this patch series is that several new very short helper functions > > are

Re: [PATCH 16/39] ipmi: simplify procfs code

2018-04-19 Thread Corey Minyard
On 04/19/2018 07:41 AM, Christoph Hellwig wrote: Use remove_proc_subtree to remove the whole subtree on cleanup instead of a hand rolled list of proc entries, unwind the registration loop into individual calls. Switch to use proc_create_single to further simplify the code. I'm yanking all the

Re: [PATCH 03/39] proc: introduce proc_create_seq_private

2018-04-19 Thread Dan Carpenter
On Thu, Apr 19, 2018 at 02:41:04PM +0200, Christoph Hellwig wrote: > diff --git a/drivers/s390/cio/blacklist.c b/drivers/s390/cio/blacklist.c > index 2a3f874a21d5..ad35cddcf6af 100644 > --- a/drivers/s390/cio/blacklist.c > +++ b/drivers/s390/cio/blacklist.c > @@ -391,28 +391,15 @@ static const

Re: [PATCH 26/39] rtc/proc: switch to proc_create_single_data

2018-04-19 Thread Alexandre Belloni
On 19/04/2018 14:41:27+0200, Christoph Hellwig wrote: > And stop trying to get a reference on the submodule, procfs code deals > with release after and unloaded module and thus removed proc entry. > Are you sure about that? The rtc module is not the one adding the procfs file so I'm not sure how

[PATCH 05/39] ipv{4,6}/udp{,lite}: simplify proc registration

2018-04-19 Thread Christoph Hellwig
Remove a couple indirections to make the code look like most other protocols. Signed-off-by: Christoph Hellwig --- include/net/udp.h | 20 -- net/ipv4/udp.c | 99 +- net/ipv4/udplite.c | 21 +++--- net/ipv6/udp.c | 30

[PATCH 02/39] proc: introduce proc_create_seq{,_data}

2018-04-19 Thread Christoph Hellwig
Variants of proc_create{,_data} that directly take a struct seq_operations argument and drastically reduces the boilerplate code in the callers. All trivial callers converted over. Signed-off-by: Christoph Hellwig --- arch/ia64/hp/common/sba_iommu.c | 15 +-

[PATCH 06/39] ipv{4,6}/tcp: simplify procfs registration

2018-04-19 Thread Christoph Hellwig
Avoid most of the afinfo indirections and just call the proc helpers directly. Signed-off-by: Christoph Hellwig --- include/net/tcp.h | 11 ++ net/ipv4/tcp_ipv4.c | 85 + net/ipv6/tcp_ipv6.c | 27 +- 3 files changed, 53

simplify procfs code for seq_file instances

2018-04-19 Thread Christoph Hellwig
We currently have hundreds of proc files that implement plain, read-only seq_file based interfaces. This series consolidates them using new procfs helpers that take the seq_operations or simple show callback directly. A git tree is available at: git://git.infradead.org/users/hch/misc.git

[PATCH 01/39] net/can: single_open_net needs to be paired with single_release_net

2018-04-19 Thread Christoph Hellwig
Otherwise we will leak a reference to the network namespace. Signed-off-by: Christoph Hellwig --- net/can/bcm.c | 2 +- net/can/proc.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/can/bcm.c b/net/can/bcm.c index ac5e5e34fee3..8073fa14e143 100644

[PATCH 03/39] proc: introduce proc_create_seq_private

2018-04-19 Thread Christoph Hellwig
Variant of proc_create_data that directly take a struct seq_operations argument + a private state size and drastically reduces the boilerplate code in the callers. All trivial callers converted over. Signed-off-by: Christoph Hellwig --- drivers/s390/cio/blacklist.c | 21

[PATCH 08/39] ipv{4,6}/raw: simplify ѕeq_file code

2018-04-19 Thread Christoph Hellwig
Pass the hashtable to the proc private data instead of copying it into the per-file private data. Signed-off-by: Christoph Hellwig --- include/net/raw.h | 4 net/ipv4/raw.c| 36 net/ipv6/raw.c| 6 -- 3 files changed, 16

[PATCH 04/39] proc: introduce proc_create_single{,_data}

2018-04-19 Thread Christoph Hellwig
Variants of proc_create{,_data} that directly take a seq_file show callback and drastically reduces the boilerplate code in the callers. All trivial callers converted over. Signed-off-by: Christoph Hellwig --- arch/arm/kernel/dma.c | 14 +---

[PATCH 07/39] ipv{4,6}/ping: simplify proc file creation

2018-04-19 Thread Christoph Hellwig
Remove the pointless ping_seq_afinfo indirection and make the code look like most other protocols. Signed-off-by: Christoph Hellwig --- include/net/ping.h | 11 -- net/ipv4/ping.c| 50 +- net/ipv6/ping.c| 35

Re: [PATCH 20/39] afs: simplify procfs code

2018-04-19 Thread David Howells
Christoph Hellwig wrote: > Use remove_proc_subtree to remove the whole subtree on cleanup, and > unwind the registration loop into individual calls. Switch to use > proc_create_seq where applicable. Note that this is likely going to clash with my patch to net-namespace all of the

[PATCH 11/39] netfilter/x_tables: simplify ѕeq_file code

2018-04-19 Thread Christoph Hellwig
Just use the address family from the proc private data instead of copying it into per-file data. Signed-off-by: Christoph Hellwig --- net/netfilter/x_tables.c | 39 +++ 1 file changed, 11 insertions(+), 28 deletions(-) diff --git

[PATCH 10/39] net/kcm: simplify proc registration

2018-04-19 Thread Christoph Hellwig
Remove a couple indirections to make the code look like most other protocols. Signed-off-by: Christoph Hellwig --- net/kcm/kcmproc.c | 71 --- 1 file changed, 17 insertions(+), 54 deletions(-) diff --git a/net/kcm/kcmproc.c

[PATCH 14/39] proc: introduce proc_create_net_single

2018-04-19 Thread Christoph Hellwig
Variant of proc_create_data that directly take a seq_file show callback and deals with network namespaces in ->open and ->release. All callers of proc_create + single_open_net converted over, and single_{open,release}_net are removed entirely. Signed-off-by: Christoph Hellwig ---

[PATCH 15/39] acpi/battery: simplify procfs code

2018-04-19 Thread Christoph Hellwig
Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_seq where applicable. Signed-off-by: Christoph Hellwig --- drivers/acpi/battery.c | 121 + 1

[PATCH 13/39] proc: introduce proc_create_net{,_data}

2018-04-19 Thread Christoph Hellwig
Variants of proc_create{,_data} that directly take a struct seq_operations and deal with network namespaces in ->open and ->release. All callers of proc_create + seq_open_net converted over, and seq_{open,release}_net are removed entirely. Signed-off-by: Christoph Hellwig ---

[PATCH 21/39] ext4: simplify procfs code

2018-04-19 Thread Christoph Hellwig
Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_seq where applicable. Signed-off-by: Christoph Hellwig --- fs/ext4/ext4.h| 2 +- fs/ext4/mballoc.c | 29

[PATCH 16/39] ipmi: simplify procfs code

2018-04-19 Thread Christoph Hellwig
Use remove_proc_subtree to remove the whole subtree on cleanup instead of a hand rolled list of proc entries, unwind the registration loop into individual calls. Switch to use proc_create_single to further simplify the code. Signed-off-by: Christoph Hellwig ---

[PATCH 20/39] afs: simplify procfs code

2018-04-19 Thread Christoph Hellwig
Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_seq where applicable. Signed-off-by: Christoph Hellwig --- fs/afs/proc.c | 134 ++ 1

[PATCH 17/39] sgi-gru: simplify procfs code

2018-04-19 Thread Christoph Hellwig
Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_seq where applicable. Signed-off-by: Christoph Hellwig --- drivers/misc/sgi-gru/gruprocfs.c | 81 ++-- 1

[PATCH 19/39] sg: simplify procfs code

2018-04-19 Thread Christoph Hellwig
Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_seq where applicable. Signed-off-by: Christoph Hellwig --- drivers/scsi/sg.c | 124 +- 1

[PATCH 18/39] megaraid: simplify procfs code

2018-04-19 Thread Christoph Hellwig
Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_single. Signed-off-by: Christoph Hellwig --- drivers/scsi/megaraid.c | 140 +++-

[PATCH 22/39] jfs: simplify procfs code

2018-04-19 Thread Christoph Hellwig
Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_seq where applicable. Signed-off-by: Christoph Hellwig --- fs/jfs/jfs_debug.c| 43 ++-

[PATCH 27/39] bonding: switch to proc_create_seq_data

2018-04-19 Thread Christoph Hellwig
And use proc private data directly instead of doing a detour through seq->private. Signed-off-by: Christoph Hellwig --- drivers/net/bonding/bond_procfs.c | 36 ++- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git

[PATCH 26/39] rtc/proc: switch to proc_create_single_data

2018-04-19 Thread Christoph Hellwig
And stop trying to get a reference on the submodule, procfs code deals with release after and unloaded module and thus removed proc entry. Signed-off-by: Christoph Hellwig --- drivers/rtc/rtc-proc.c | 33 ++--- 1 file changed, 2 insertions(+), 31

[PATCH 23/39] staging/rtl8192u: simplify procfs code

2018-04-19 Thread Christoph Hellwig
Unwind the registration loop into individual calls. Switch to use proc_create_single where applicable. Signed-off-by: Christoph Hellwig --- drivers/staging/rtl8192u/r8192U_core.c | 67 ++ 1 file changed, 14 insertions(+), 53 deletions(-) diff --git

[PATCH 24/39] resource: switch to proc_create_seq_data

2018-04-19 Thread Christoph Hellwig
And use the root resource directly from the proc private data. Signed-off-by: Christoph Hellwig --- kernel/resource.c | 43 +-- 1 file changed, 5 insertions(+), 38 deletions(-) diff --git a/kernel/resource.c b/kernel/resource.c index

[PATCH 32/39] bluetooth: switch to proc_create_seq_data

2018-04-19 Thread Christoph Hellwig
And use proc private data directly instead of doing a detour through seq->private and private state. Signed-off-by: Christoph Hellwig --- net/bluetooth/af_bluetooth.c | 40 +--- 1 file changed, 5 insertions(+), 35 deletions(-) diff --git

[PATCH 35/39] isdn: replace ->proc_fops with ->proc_show

2018-04-19 Thread Christoph Hellwig
And switch to proc_create_single_data. Signed-off-by: Christoph Hellwig --- drivers/isdn/capi/kcapi.c | 3 ++- drivers/isdn/gigaset/capi.c| 16 +--- drivers/isdn/hardware/avm/avmcard.h| 4 ++-- drivers/isdn/hardware/avm/b1.c | 17

[PATCH 25/39] drbd: switch to proc_create_single

2018-04-19 Thread Christoph Hellwig
And stop messing with try_module_get on THIS_MODULE, which doesn't make any sense here. Signed-off-by: Christoph Hellwig --- drivers/block/drbd/drbd_int.h | 2 +- drivers/block/drbd/drbd_main.c | 3 ++- drivers/block/drbd/drbd_proc.c | 34 +- 3

[PATCH 37/39] ide: remove ide_driver_proc_write

2018-04-19 Thread Christoph Hellwig
The driver proc file hasn't been writeable for a long time, so this is just dead code. Signed-off-by: Christoph Hellwig --- drivers/ide/ide-proc.c | 46 -- 1 file changed, 46 deletions(-) diff --git a/drivers/ide/ide-proc.c

[PATCH 34/39] atm: switch to proc_create_seq_private

2018-04-19 Thread Christoph Hellwig
And remove proc boilerplate code. Signed-off-by: Christoph Hellwig --- net/atm/proc.c | 72 +- 1 file changed, 13 insertions(+), 59 deletions(-) diff --git a/net/atm/proc.c b/net/atm/proc.c index f272b0f59d82..0b0495a41bbe 100644 ---

[PATCH 36/39] proc: don't detour through seq->private to get the inode

2018-04-19 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- fs/proc/array.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/fs/proc/array.c b/fs/proc/array.c index ae2c807fd719..b34796b562ef 100644 --- a/fs/proc/array.c +++ b/fs/proc/array.c @@ -677,7 +677,7 @@

[PATCH 33/39] atm: simplify procfs code

2018-04-19 Thread Christoph Hellwig
Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_seq where applicable. Signed-off-by: Christoph Hellwig --- net/atm/proc.c | 65 ++ 1

[PATCH 29/39] neigh: switch to proc_create_seq_data

2018-04-19 Thread Christoph Hellwig
And use proc private data directly instead of doing a detour through seq->private. Signed-off-by: Christoph Hellwig --- net/core/neighbour.c | 31 ++- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/net/core/neighbour.c

[PATCH 30/39] netfilter/xt_hashlimit: switch to proc_create_{seq,single}_data

2018-04-19 Thread Christoph Hellwig
And use proc private data directly instead of doing a detour through seq->private. Signed-off-by: Christoph Hellwig --- net/netfilter/xt_hashlimit.c | 92 +++- 1 file changed, 18 insertions(+), 74 deletions(-) diff --git

[PATCH 28/39] hostap: switch to proc_create_{seq,single}_data

2018-04-19 Thread Christoph Hellwig
And use proc private data directly instead of doing a detour through seq->private. Signed-off-by: Christoph Hellwig --- .../net/wireless/intersil/hostap/hostap_ap.c | 70 ++--- .../net/wireless/intersil/hostap/hostap_hw.c | 17 +-- .../wireless/intersil/hostap/hostap_proc.c

[PATCH 39/39] tty: replace ->proc_fops with ->proc_show

2018-04-19 Thread Christoph Hellwig
Just set up the show callback in the tty_operations, and use proc_create_single_data to create the file without additional boilerplace code. Signed-off-by: Christoph Hellwig --- arch/ia64/hp/sim/simserial.c| 15 +-- arch/xtensa/platforms/iss/console.c | 15

[PATCH 38/39] ide: replace ->proc_fops with ->proc_show

2018-04-19 Thread Christoph Hellwig
Just set up the show callback in the tty_operations, and use proc_create_single_data to create the file without additional boilerplace code. Signed-off-by: Christoph Hellwig --- drivers/ide/ide-cd.c | 15 +--- drivers/ide/ide-disk_proc.c | 62 ++--

[PATCH 31/39] netfilter/x_tables: switch to proc_create_seq_private

2018-04-19 Thread Christoph Hellwig
And remove proc boilerplate code. Signed-off-by: Christoph Hellwig --- net/netfilter/x_tables.c | 42 ++-- 1 file changed, 6 insertions(+), 36 deletions(-) diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c index

[PATCH 12/39] net: move seq_file_single_net to

2018-04-19 Thread Christoph Hellwig
This helper deals with single_{open,release}_net internals and thus belongs here. Signed-off-by: Christoph Hellwig --- include/linux/seq_file_net.h | 13 + include/net/ip_vs.h | 12 2 files changed, 13 insertions(+), 12 deletions(-) diff --git

[PATCH 09/39] ipv6/flowlabel: simplify pid namespace lookup

2018-04-19 Thread Christoph Hellwig
The shole seq_file sequence already operates under a single RCU lock pair, so move the pid namespace lookup into it, and stop grabbing a reference and remove all kinds of boilerplate code. Signed-off-by: Christoph Hellwig --- net/ipv6/ip6_flowlabel.c | 28

[Bug 199435] HPSA + P420i resetting logical Direct-Access never complete

2018-04-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=199435 --- Comment #6 from Anthony Hausman (anthonyhaussm...@gmail.com) --- I have a stack trave about the Workqueue: Apr 19 11:22:52 kernel: INFO: task kworker/u129:28:428 blocked for more than 120 seconds. Apr 19 11:22:52 kernel: Tainted: G

Re: [VERY EARLY RFC 00/13] Rework SCSI results handling

2018-04-19 Thread Hannes Reinecke
On Thu, 19 Apr 2018 10:10:41 +0200 Johannes Thumshirn wrote: > On Wed, Apr 18, 2018 at 04:00:43PM +, Bart Van Assche wrote: > > Thank you for having come up with this so quickly. Something I do > > not like about this patch series is that several new very short > > helper

Re: usercopy whitelist woe in scsi_sense_cache

2018-04-19 Thread Paolo Valente
> Il giorno 18 apr 2018, alle ore 16:30, Jens Axboe ha > scritto: > > On 4/18/18 3:08 AM, Paolo Valente wrote: >> >> >>> Il giorno 18 apr 2018, alle ore 00:57, Jens Axboe ha >>> scritto: >>> >>> On 4/17/18 3:48 PM, Jens Axboe wrote: On 4/17/18 3:47

[Bug 199435] HPSA + P420i resetting logical Direct-Access never complete

2018-04-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=199435 --- Comment #5 from Anthony Hausman (anthonyhaussm...@gmail.com) --- Don, I have applied the patch, it actually run and I try to reproduce the problem. I'll inform you about the diagnose. -- You are receiving this mail because: You are the

Re: [PATCH] scsi_debug: replace SDEG_RES_IMMED_MASK with cmnd flag

2018-04-19 Thread Johannes Thumshirn
On Thu, Apr 19, 2018 at 12:42:28AM -0400, Douglas Gilbert wrote: > This patch uses a cleaner method to convey the presence of the IMMED > cdb bit back to the generic delay code in the scsi_debug driver. The > previous method used a temporary mask over the SCSI result value > (a 32 bit integer soon

Re: [VERY EARLY RFC 08/13] treewide: use set_host_byte

2018-04-19 Thread Johannes Thumshirn
On Thu, Apr 19, 2018 at 09:48:56AM +1000, Finn Thain wrote: > Every hunk except the last one looks to be equivalent. Not sure why > the last one is treated differently. That's a bug I'd say. thanks for catching it. > Also, I think using two assignments instead of one is a step backwards. Is >

Re: [VERY EARLY RFC 12/13] reewide: introduce clear_scsi_result() and convert drivers

2018-04-19 Thread Johannes Thumshirn
On Thu, Apr 19, 2018 at 08:15:47AM +0200, Hannes Reinecke wrote: > On Wed, 18 Apr 2018 17:01:15 +0200 > Johannes Thumshirn wrote: > > > Introduce clear_scsi_result() and convert drivers over to use the new > > function. > > > > [ .. ] > > Why not use 'set_scsi_result'

Re: [PATCH v3 1/6] ilog2: create truly constant version for sparse

2018-04-19 Thread Rasmus Villemoes
On 2018-04-18 23:21, Linus Torvalds wrote: > On Wed, Apr 18, 2018 at 1:12 AM, Martin Wilck wrote: >> >> No, it doesn't (gcc 7.3.0). -> https://paste.opensuse.org/27471594 >> It doesn't even warn on an expression like this: >> >> #define SIZE (1<<10) >> static int

Re: [VERY EARLY RFC 00/13] Rework SCSI results handling

2018-04-19 Thread Johannes Thumshirn
On Wed, Apr 18, 2018 at 04:00:43PM +, Bart Van Assche wrote: > Thank you for having come up with this so quickly. Something I do not > like about this patch series is that several new very short helper functions > are introduced, e.g. set_scsi_result(), clear_scsi_result(), to_scsi_result() >

[PATCHv4 3/3] tcmu: add module wide action/reset_netlink support

2018-04-19 Thread xiubli
From: Xiubo Li This patch adds 1 tcmu attr to reset and complete all the blocked netlink waiting threads. It's used when the userspace daemon like tcmu-runner has crashed or forced to shutdown just before the netlink requests be replied to the kernel, then the netlink

[PATCHv4 2/3] target: adjust and export target_for_each_device visible to modules

2018-04-19 Thread xiubli
From: Xiubo Li Make the target_for_each_device could list all the devices not only configured as needed. Signed-off-by: Xiubo Li --- drivers/target/target_core_device.c | 10 +- drivers/target/target_core_internal.h | 2 --

[PATCHv4 0/3] tcmu: allow userspace to reset netlink

2018-04-19 Thread xiubli
From: Xiubo Li Changes since v1(suggested by Mike Christie): v2: - Makes the reset per device. v3: - Remove nl_cmd->complete, use status instead - Fix lock issue - Check if a nl command is even waiting before trying to wake up v4: - Add module wide action support and

[PATCHv4 1/3] target/configfs: add module wide action support

2018-04-19 Thread xiubli
From: Xiubo Li For some case we need some module wide configfs to contol some attributes of the whole transport module. Signed-off-by: Xiubo Li --- drivers/target/target_core_configfs.c | 46 +++

RE: MegaCli fails to communicate with Raid-Controller

2018-04-19 Thread Kashyap Desai
> -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Wednesday, April 18, 2018 10:43 PM > To: volker.schwick...@godaddy.com > Cc: linux-scsi@vger.kernel.org; Kashyap Desai; Sumit Saxena > Subject: Re: MegaCli fails to communicate with Raid-Controller

Re: [VERY EARLY RFC 12/13] reewide: introduce clear_scsi_result() and convert drivers

2018-04-19 Thread Hannes Reinecke
On Wed, 18 Apr 2018 17:01:15 +0200 Johannes Thumshirn wrote: > Introduce clear_scsi_result() and convert drivers over to use the new > function. > [ .. ] Why not use 'set_scsi_result' here? Basically everywhere the usage pattern is clear_scsi_result() set_host_byte() so

Re: [VERY EARLY RFC 01/13] scsi: use host_byte() accessor

2018-04-19 Thread Hannes Reinecke
On Thu, 19 Apr 2018 09:46:30 +1000 (AEST) Finn Thain wrote: > On Wed, 18 Apr 2018, Johannes Thumshirn wrote: > > > --- a/drivers/scsi/dc395x.c > > +++ b/drivers/scsi/dc395x.c > > @@ -3473,7 +3473,7 @@ static void srb_done(struct AdapterCtlBlk > > *acb, struct