On Thu, Apr 19, 2018 at 08:15:47AM +0200, Hannes Reinecke wrote: > On Wed, 18 Apr 2018 17:01:15 +0200 > Johannes Thumshirn <[email protected]> wrote: > > > Introduce clear_scsi_result() and convert drivers over to use the new > > function. > > > > [ .. ] > > Why not use 'set_scsi_result' here? > Basically everywhere the usage pattern is > > clear_scsi_result() > set_host_byte() > > so they can be collapsed into > > set_scsi_result(cmd, 0, host_byte, 0, 0) > > and this helper can be dropped.
Yup, this sounds like a good idea. -- Johannes Thumshirn Storage [email protected] +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
