Re: Recent removal of bsg read/write support

2018-10-03 Thread Dror Levin
CC'ing Greg. On Mon, Sep 3, 2018 at 11:34 AM Dror Levin wrote: > > On Sun, Sep 2, 2018 at 8:55 PM Linus Torvalds > wrote: > > > > On Sun, Sep 2, 2018 at 4:44 AM Richard Weinberger > > wrote: > > > > > > CC'ing relevant people. Otherwise your mail might get lost. > > > > Indeed. > > Sorry for th

[PATCH] scsi: aic7xxx: mark expected switch fall-throughs

2018-10-03 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114961 ("Missing break in switch") Addresses-Coverity-ID: 114962 ("Missing break in switch") Addresses-Coverity-ID: 114963 ("Missing break in switch") Addresses-Cover

[Bug 201313] pm80xx mpi_ssp_completion 1883:SAS Address of IO Failure Drive:

2018-10-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201313 --- Comment #3 from MasterCATZ (masterc...@hotmail.com) --- it might actually be part of this bug https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=740701 -- You are receiving this mail because: You are the assignee for the bug.

[PATCH v8 2/8] scsi: ufs: add a low-level __ufshcd_issue_tm_cmd helper

2018-10-03 Thread Avri Altman
From: Christoph Hellwig Add a helper that takes a utp_task_req_desc and issues it, which will be useful for UFS bsg support. Rewrite ufshcd_issue_tm_cmd0x to use this new helper. Signed-off-by: Christoph Hellwig Tested-by: Avri Altman --- drivers/scsi/ufs/ufshcd.c | 141 -

[PATCH v8 8/8] scsi: ufs-bsg: Add support for uic commands in ufs_bsg_request()

2018-10-03 Thread Avri Altman
Make ufshcd_send_uic_cmd() public for that. Signed-off-by: Avri Altman Reviewed-by: Christoph Hellwig Reviewed-by: Bart Van Assche --- drivers/scsi/ufs/ufs_bsg.c | 11 +++ drivers/scsi/ufs/ufshcd.c| 3 +-- drivers/scsi/ufs/ufshcd.h| 2 ++ include/uapi/scsi/scsi_

[PATCH v8 7/8] scsi: ufs-bsg: Add support for raw upiu in ufs_bsg_request()

2018-10-03 Thread Avri Altman
Do that for the currently supported UPIUs: query, nop out, and task management. We do not support UPIU of type scsi command yet, while we are using the job's request and reply pointers to hold the payload. We will look into it in later patches. We might need to elaborate the raw upiu api for that

[PATCH v8 6/8] scsi: ufs: Add API to execute raw upiu commands

2018-10-03 Thread Avri Altman
The UFS host software uses a combination of a host register set, and Transfer Request Descriptors in system memory to communicate with host controller hardware. In its mmio space, a separate places are assigned to UTP Transfer Request Descriptor ("utrd") list, and to UTP Task Management Request Des

[PATCH v8 5/8] scsi: ufs: Use data structure size in pointer arithmetic

2018-10-03 Thread Avri Altman
Use the structure size in pointer arithmetic's instead of an opaque 32 bytes for the over allocation of descriptors. Signed-off-by: Avri Altman Reviewed-by: Christoph Hellwig --- drivers/scsi/ufs/ufs.h| 2 +- drivers/scsi/ufs/ufshcd.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-

[PATCH v8 3/8] uapi: ufs: Make utp_upiu_req visible to user space

2018-10-03 Thread Avri Altman
in preparation to send UPIU requests via bsg. Signed-off-by: Avri Altman Reviewed-by: Bart Van Assche --- drivers/scsi/ufs/ufs.h | 61 + drivers/scsi/ufs/ufshcd.c| 6 ++-- include/uapi/scsi/scsi_bsg_ufs.h | 74 ++

[PATCH v8 4/8] scsi: ufs: Add ufs-bsg module

2018-10-03 Thread Avri Altman
Add a bsg endpoint that supports UPIUs. For now, just provide an API to allocate and remove ufs-bsg node. We will use this framework to manage ufs devices by sending UPIU transactions. For the time being, implements an empty bsg_request() - will add some more functionality in coming patches. Non

[PATCH v8 1/8] scsi: ufs: cleanup struct utp_task_req_desc

2018-10-03 Thread Avri Altman
From: Christoph Hellwig Remove the pointless task_req_upiu and task_rsp_upiu indirections, which are __le32 arrays always cast to given structures and just add the members directly. Also clean up variables names in use in the callers a bit to make the code more readable. Signed-off-by: Christop

[PATCH v8 0/8] scsi: Add ufs bsg endpoint

2018-10-03 Thread Avri Altman
Here is a proposal to use a bsg endpoint to manage ufs devices. We will do that by adding a bsg device node to the ufs driver, and use it to send UPIU transactions to the ufs device. It will serve as a ufs device management infrastructure, for device configuration, provisioning, testing and valid

[PATCH] scsi: iscsi_tcp: Explicitly cast param in iscsi_sw_tcp_host_get_param

2018-10-03 Thread Nathan Chancellor
Clang warns when one enumerated type is implicitly converted to another. drivers/scsi/iscsi_tcp.c:803:15: warning: implicit conversion from enumeration type 'enum iscsi_host_param' to different enumeration type 'enum iscsi_param' [-Wenum-conversion]

Re: aacraid: latest driver results in Host adapter abort request. / Outstanding commands on (0,0,0,0):

2018-10-03 Thread Stefan Priebe - Profihost AG
Hi Dave, Am 03.10.2018 um 19:32 schrieb dave.carr...@microchip.com: >> Am 27.09.2018 um 12:59 schrieb Emmanuel Florac: >>> Le Wed, 19 Sep 2018 08:10:41 +0200 >>> Stefan Priebe - Profihost AG écrivait: >>> Hello, after upgrading the aacraid driver / kernel from aacraid 50792 to

Re: [PATCH v1] scsi: ufs: add 2 lane support

2018-10-03 Thread Evan Green
Hi, On Wed, Oct 3, 2018 at 11:19 AM Can Guo wrote: > > From: Venkat Gopalakrishnan > > Qcom ufs controller v3.1.0 supports 2 lanes, add support > to configure 2 lanes during phy initialization. I'm reviving this old chestnut, sorry I missed it initially. This description is a little terse, and

Re: [PATCH V14 2/2] scsi: ufs: Add configfs support for UFS provisioning

2018-10-03 Thread Evan Green
On Sun, Sep 23, 2018 at 11:29 PM Sayali Lokhande wrote: > > This patch adds configfs support to provision UFS device at > runtime. This feature can be primarily useful in factory or > assembly line as some devices may be required to be configured > multiple times during initial system development

RE: aacraid: latest driver results in Host adapter abort request. / Outstanding commands on (0,0,0,0):

2018-10-03 Thread Dave.Carroll
> Am 27.09.2018 um 12:59 schrieb Emmanuel Florac: > > Le Wed, 19 Sep 2018 08:10:41 +0200 > > Stefan Priebe - Profihost AG écrivait: > > > >> Hello, > >> > >> after upgrading the aacraid driver / kernel from aacraid 50792 to > >> aacraid 50877. > >> > >> I get aborted comands every night. > >> > >

Re: [PATCH] scsi: mark expected switch fall-throughs

2018-10-03 Thread Gustavo A. R. Silva
On 10/3/18 5:44 PM, don.br...@microchip.com wrote: >

[PATCH] scsi: mark expected switch fall-throughs

2018-10-03 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1195463 ("Missing break in switch") Addresses-Coverity-ID: 1195464 ("Missing break in switch") Addresses-Coverity-ID: 1195465 ("Missing break in switch") Addresses-Co

Re: [PATCH 09/16] scsi: Replace spin_is_locked() with lockdep

2018-10-03 Thread Bart Van Assche
On 10/2/18 10:38 PM, Lance Roy wrote: lockdep_assert_held() is better suited to checking locking requirements, since it won't get confused when someone else holds the lock. This is also a step towards possibly removing spin_is_locked(). Reviewed-by: Bart Van Assche

[Bug 201313] pm80xx mpi_ssp_completion 1883:SAS Address of IO Failure Drive:

2018-10-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201313 --- Comment #2 from MasterCATZ (masterc...@hotmail.com) --- it might be also related to the SEAGATE ST33000650NS as my other drives are HITACHI HUA723030ALA64SA and I used a spare and it formatted with fewer kernel errors, but still did have some