[PATCH 6/17] qla2xxx: Add MBX command routines for ISP24xx support.

2005-07-06 Thread Andrew Vasquez
Add MBX command routines for ISP24xx support. Generalize several routines [qla2x00_load_ram_ext(), qla2x00_execute_fw(), qla2x00_verify_checksum()] to handle larger addressing space. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_def.h |3 drivers/scsi

Re: [PATCH] remove some dead code in qla2xxx

2005-04-22 Thread Andrew Vasquez
ACK. James, please apply - several of my follow-up patches are based off a tree with these changes. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] = drivers/scsi/qla2xxx/qla_dbg.c 1.12 vs edited = --- 1.12/drivers/scsi/qla2xxx/qla_dbg.c 2005-04-13 17:45:53 +02:00 +++ edited/drivers

Re: Removing a disk from the qla2xxx driver.

2005-04-22 Thread Andrew Vasquez
recognition of the device persists throughout the driver's lifetime -- this is not necessary. Hope this helps. Regards, Andrew Vasquez - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: PATCH [6/5] qla2xxx: update version :)

2005-04-22 Thread Andrew Vasquez
On Tue, 19 Apr 2005, Christoph Hellwig wrote: On Wed, Apr 13, 2005 at 02:24:36PM -0700, Andrew Vasquez wrote: Ok, here's the deal -- QLogic's standard 8.01.00 driver contains the following major additions: * support for 4Gb ISPs * FCIP support Btw, any plans to do proper FCIP

Re: PATCH [2/5] qla2xxx: add remote port codes...

2005-04-19 Thread Andrew Vasquez
shouldn't be needed, a simple forward-declaration of struct scsi_transport_template should do it. Ok, makes sense. James, please apply: Make transport-functions structure non-static. Replace #include of scsi_transport.h with a forward declaration. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED

Re: PATCH [2/5] qla2xxx: add remote port codes...

2005-04-19 Thread Andrew Vasquez
On Wed, 13 Apr 2005, Christoph Hellwig wrote: atomic_set(fcport-state, FCS_ONLINE); + if (ha-flags.init_done) + qla2x00_reg_remote_port(ha, fcport); } ... - goto probe_failed; + goto probe_alloc_failed; } + pci_set_drvdata(pdev,

Re: PATCH [6/5] qla2xxx: update version :)

2005-04-15 Thread Andrew Vasquez
On Wed, 13 Apr 2005, Christoph Hellwig wrote: On Wed, Apr 13, 2005 at 01:50:07PM -0700, Andrew Vasquez wrote: Update version. Btw, Documentation/scsi/qla2xxx.revision.notes hasn't been updated for ages. Either scrap it or give it some love, I don't mind too much which of these you

Re: PATCH [4/5] qla2xxx: cleanup DMA mappings...

2005-04-15 Thread Andrew Vasquez
and failure to check return values on the mappings. Make the check for space in the ring buffer happen after the DMA mapping is done since any checks done before the mapping has taken place are bogus. Doug Ledford [EMAIL PROTECTED]. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] drivers/scsi

PATCH [0/5] qla2xxx: remote port rework...

2005-04-13 Thread Andrew Vasquez
operations (via change_queue_depth()). c) additional hardware (ISP) support. d) Additional dusting and scrubbing: unused functions and structures left over from the cleanup. e) firmware loading via request_firmware() infrastructure. f) lock simplification and consolidation. Regards, Andrew

PATCH [2/5] qla2xxx: add remote port codes...

2005-04-13 Thread Andrew Vasquez
Add initial support for FC remote port infrastructure. o Use fc_remote_port...() registration and block/unlock functions. o Consolidate 'attribute' (fc-remote/sysfs) helpers into new qla_attr.c file. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] drivers/scsi/qla2xxx

PATCH [4/5] qla2xxx: cleanup DMA mappings...

2005-04-13 Thread Andrew Vasquez
done before the mapping has taken place are bogus. Doug Ledford [EMAIL PROTECTED]. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] drivers/scsi/qla2xxx/qla_iocb.c | 77 +++- 1 files changed, 38 insertions(+), 39 deletions(-) --- a/drivers/scsi/qla2xxx

PATCH [3/5] qla2xxx: remove lun discovery codes...

2005-04-13 Thread Andrew Vasquez
Remove internal lun discovery routines and support structures. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] drivers/scsi/qla2xxx/qla_attr.c | 51 +- drivers/scsi/qla2xxx/qla_dbg.c|5 drivers/scsi/qla2xxx/qla_def.h| 103 drivers/scsi/qla2xxx/qla_gbl.h| 10

PATCH [5/5] qla2xxx: remove /proc interface

2005-04-13 Thread Andrew Vasquez
Remove /proc support. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] drivers/scsi/qla2xxx/qla_os.c | 254 -- 1 files changed, 254 deletions(-) --- a/drivers/scsi/qla2xxx/qla_os.c 2005-04-13 08:56:07.0 -0700 +++ b/drivers/scsi/qla2xxx

PATCH [6/5] qla2xxx: update version :)

2005-04-13 Thread Andrew Vasquez
Update version. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] drivers/scsi/qla2xxx/qla_version.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) --- a/drivers/scsi/qla2xxx/qla_version.h2005-04-13 08:56:07.0 -0700 +++ b/drivers/scsi/qla2xxx/qla_version.h

Re: Fw: [Bugme-new] [Bug 4473] New: QLogic 2100: SCSI timeouts, device resets, and crashes kernel

2005-04-11 Thread Andrew Vasquez
if this effects the error. To do this just echo 60 /sys/block/sd${N}/device/timeout. Also you can run iostat during your testing to see what you IO times / queue depths look like. Andrew Vasquez may be able to add more info. Greg, The logs seem to indicate some (additional) problems with the ISP

Re: [RFC] adding per scsi-host workqueues for defered processing

2005-03-07 Thread Andrew Vasquez
On Sat, 05 Mar 2005, [EMAIL PROTECTED] wrote: In thinking this through a little further - if the workq is just for the transport, the transport ought to simply create and use the workq. There would be no need to modify the host structure. If we're trying to avoid the potential for several

Re: [2.6 patch] drivers/scsi/qla2xxx/: cleanups

2005-02-28 Thread Andrew Vasquez
; module_param(ql2xdoinitscan, int, S_IRUGO|S_IWUSR); MODULE_PARM_DESC(ql2xdoinitscan, Signal mid-layer to perform scan after driver load: 0 -- no @@ -163,6 +162,8 @@ I'll queue-up these for the next set of patches. Thanks, Andrew Vasquez - To unsubscribe from this list: send

SCSI API generics (was Re: [PATCH] add block/unblock to iscsi class)

2005-02-23 Thread Andrew Vasquez
On Wed, 23 Feb 2005, Mike Christie wrote: The attached patch copies the code from the fc transport class which allows a LLD to block and unblock a device. The block/unblock code is used by the iscsi-sfnet driver in replacement of a internal timer doing the same thing. I understand that

Re: SCSI API generics (was Re: [PATCH] add block/unblock to iscsi class)

2005-02-23 Thread Andrew Vasquez
On Wed, 23 Feb 2005, Mike Christie wrote: Andrew Vasquez wrote: Speaking of which, are there any major objections to the patches proposed here: Add scsi_target_[un]block() and scsi_target_remove() generics http://marc.theaimsgroup.com/?l=linux-scsim=110867050306738w=2 [RFC] adding per

[RFC] adding per scsi-host workqueues for defered processing

2005-02-21 Thread Andrew Vasquez
. */ scsi_queue_work(shost, rport-scan_work); else scsi_target_unblock(rport-dev); Anyway, comments? -- Andrew Vasquez = drivers/scsi/hosts.c 1.107 vs edited = --- 1.107/drivers/scsi/hosts.c 2005-01-18 11:15:06 -08:00 +++ edited/drivers/scsi

Re: [RFC] target code updates to support scanned targets

2005-02-17 Thread Andrew Vasquez
On Wed, 16 Feb 2005, Andrew Vasquez wrote: On Tue, 15 Feb 2005, James Bottomley wrote: Well, how about a different format for this, so there's a scsi_remove_target that takes a generic device (analogous to the scsi_scan_target) except that this time if the device isn't a target, we remove

Re: [RFC] target code updates to support scanned targets

2005-02-16 Thread Andrew Vasquez
On Tue, 15 Feb 2005, James Bottomley wrote: On Tue, 2005-02-15 at 16:53 -0800, Andrew Vasquez wrote: Yes, but the parent needs to know if the starget is actually created. With the fc_rports snapshot I've been working with, I've coded up the following: Why do you need to know if the scan

Re: [PATCH 1/2 scsi-rc-fixes-2.6] Midlayer rework to allow remote port between shost and starget

2005-02-09 Thread Andrew Vasquez
This patch modifies the midlayer for the addition of transport objects to be layered between the scsi_host and the scsi_target. FC will be the first consumer - placing the remote port between the host and the target. These seems to be some reference-counting problems during starget

Re: still BUG's for smp_processor_id() on interrupt

2005-02-08 Thread Andrew Vasquez
, the smp_processor_id() is used only as a heuristic. The attached patch should quash the noise. Thanks. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] = drivers/scsi/qla2xxx/qla_isr.c 1.23 vs edited = --- 1.23/drivers/scsi/qla2xxx/qla_isr.c 2005-02-04 10:24:27 -08:00 +++ edited/drivers/scsi

PATCH [0/3] qla2xxx: new experimental changes...

2005-02-04 Thread Andrew Vasquez
'hardware_lock' and begin using the host-host_lock exclusively. D. additional hardware (ISP) support. E. firmware loading via request_firmware() infrastructure. Regards, Andrew Vasquez QLogic Corporation - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

PATCH [2/3] qla2xxx: add FC remote port support.

2005-02-04 Thread Andrew Vasquez
) helpers into new qla_attr.c file. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] drivers/scsi/qla2xxx/Makefile |2 drivers/scsi/qla2xxx/qla_attr.c | 321 drivers/scsi/qla2xxx/qla_def.h |3 drivers/scsi/qla2xxx/qla_gbl.h | 10 + drivers

Re: PATCH [0/3] qla2xxx: new experimental changes...

2005-02-04 Thread Andrew Vasquez
On Fri, 2005-02-04 at 20:35 +, Christoph Hellwig wrote: patch3 seems to not have made it to the list. I'll resend... From a quick view the first three patches look fine, except for backing out one msleep conversion and the superflous return at the end of qla2xxx_slave_destroy I'll

PATCH [3/3] qla2xxx: remove internal lun discovery...

2005-02-04 Thread Andrew Vasquez
Repost: seems as though first one didn't make it to the list. Remove internal lun discovery routines and support structures. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] drivers/scsi/qla2xxx/qla_dbg.c|5 drivers/scsi/qla2xxx/qla_def.h| 69 drivers/scsi/qla2xxx

PATCH [3/3] qla2xxx: remove internal lun discovery...

2005-02-04 Thread Andrew Vasquez
Remove internal lun discovery routines and support structures. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] drivers/scsi/qla2xxx/qla_dbg.c|5 drivers/scsi/qla2xxx/qla_def.h| 69 drivers/scsi/qla2xxx/qla_gbl.h|6 drivers/scsi/qla2xxx/qla_init.c | 584

Re: PATCH [0/3] qla2xxx: new experimental changes...

2005-02-04 Thread Andrew Vasquez
On Fri, 2005-02-04 at 17:46 -0500, Jeff Garzik wrote: Andrew Vasquez wrote: On Fri, 2005-02-04 at 20:35 +, Christoph Hellwig wrote: patch3 seems to not have made it to the list. I'll resend... Is patch #3 rather large? I still haven't gotten it. No it's actually about

Re: Mid-layer handling of NOT_READY conditions...

2005-01-31 Thread Andrew Vasquez
On Sat, 2005-01-29 at 11:34 -0800, Patrick Mansfield wrote: On Sat, Jan 29, 2005 at 10:44:41AM -0600, James Bottomley wrote: On Fri, 2005-01-28 at 21:46 -0800, Andrew Vasquez wrote: Returning back DID_IMM_RETRY for these 'transport' related conditions would of course help in this issue

RE: Mid-layer handling of NOT_READY conditions...

2005-01-31 Thread Andrew Vasquez
On Mon, 2005-01-31 at 11:56 -0500, [EMAIL PROTECTED] wrote: On Sat, 2005-01-29 at 11:34 -0800, Patrick Mansfield wrote: On Sat, Jan 29, 2005 at 10:44:41AM -0600, James Bottomley wrote: On Fri, 2005-01-28 at 21:46 -0800, Andrew Vasquez wrote: Returning back DID_IMM_RETRY

Re: Mid-layer handling of NOT_READY conditions...

2005-01-31 Thread Andrew Vasquez
) in scsi_check_sense(). Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] scsi_error.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) = drivers/scsi/scsi_error.c 1.86 vs edited = --- 1.86/drivers/scsi/scsi_error.c 2005-01-17 22:54:45 -08:00 +++ edited/drivers

Mid-layer handling of NOT_READY conditions...

2005-01-28 Thread Andrew Vasquez
command queuing internally, a NOT_READY status would cause the lun-queue to be frozen for some period time while the storage settled-down. Would this be an approach to consider? Or should we tackle the problem by addressing the quirky (cmd-retries cmd-allowed) state? Thanks, Andrew Vasquez

Re: Mid-layer handling of NOT_READY conditions...

2005-01-28 Thread Andrew Vasquez
On Fri, 2005-01-28 at 15:24 -0800, Andrew Vasquez wrote: ... There seems to be two problem with this approach: 1. As the storage continues to return NOT_READY, scsi_decide_disposition() blindly increments cmd-retries and checks against cmd-allowed, returning

<    1   2   3