)
> >>
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> >> index 1bb06c5f7716..28dd83a1d9e2 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -9418,10 +9418,6 @@ F:drivers/net/wireless/intersil/orinoco/
> >>
> >> OSD LIBRARY
On 2013-04-17 10:19, Dan Carpenter wrote:
__be32 is already a __bitwise type so we don't need the second __bitwise
here. It causes a Sparse error:
include/scsi/osd_protocol.h:110:26: error: invalid modifier
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
ACK
diff --git
On Wed, Jan 30, 2013 at 10:57 AM, walter harms wha...@bfs.de wrote:
Am 30.01.2013 09:27, schrieb Dan Carpenter:
On Wed, Jan 30, 2013 at 09:15:43AM +0100, walter harms wrote:
Am 30.01.2013 08:06, schrieb Dan Carpenter:
There wasn't any error handling for this kzalloc().
Signed-off-by: Dan
On Wed, Jan 30, 2013 at 9:06 AM, Dan Carpenter dan.carpen...@oracle.com wrote:
There wasn't any error handling for this kzalloc().
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/scsi/osd/osd_initiator.c
b/drivers/scsi/osd/osd_initiator.c
index c06b8e5..d8293f2
On Wed, Jan 30, 2013 at 3:00 PM, walter harms wha...@bfs.de wrote:
Am 30.01.2013 10:51, schrieb Benny Halevy:
On Wed, Jan 30, 2013 at 10:57 AM, walter harms wha...@bfs.de wrote:
Am 30.01.2013 09:27, schrieb Dan Carpenter:
On Wed, Jan 30, 2013 at 09:15:43AM +0100, walter harms wrote:
Am
Pete, the subject says PATCH 1/2 but I didn't see any follow-up message
for PATCH 2/2. Just wondering :)
Benny
On Feb. 26, 2008, 10:27 -0800, Pete Wyckoff [EMAIL PROTECTED] wrote:
This reverts commit a3cd7d9070be417a21905c997ee32d756d999b38.
The original commit breaks iSER reliably, making
Diabolical ;-)
Thanks for the pointer!
Benny
On Feb. 26, 2008, 11:39 -0800, Matthew Wilcox [EMAIL PROTECTED] wrote:
On Tue, Feb 26, 2008 at 11:23:01AM -0800, Benny Halevy wrote:
Pete, the subject says PATCH 1/2 but I didn't see any follow-up message
for PATCH 2/2. Just wondering :)
I think
Seriously, can't you just add a disclaimer to the README file?
In http://lkml.org/lkml/2008/2/9/29, Luben Tuikov made an interesting
point that in many cases illegal refers to a valid value that violates
the specification, so the term invalid may be technically incorrect.
Benny
On Feb. 11,
On Feb. 06, 2008, 14:16 +0200, Bart Van Assche [EMAIL PROTECTED] wrote:
On Feb 5, 2008 6:01 PM, Erez Zilber [EMAIL PROTECTED] wrote:
Using such large values for FirstBurstLength will give you poor
performance numbers for WRITE commands (with iSER). FirstBurstLength
means how much data should
On Jan. 21, 2008, 11:31 +0200, Jens Axboe [EMAIL PROTECTED] wrote:
On Mon, Jan 21 2008, Boaz Harrosh wrote:
On Sun, Jan 20 2008 at 22:59 +0200, James Bottomley [EMAIL PROTECTED]
wrote:
On Sun, 2008-01-20 at 21:01 +0100, Jens Axboe wrote:
On Sun, Jan 20 2008, Jens Axboe wrote:
On Sun, Jan 20
On Jan. 15, 2008, 17:20 +0200, James Bottomley [EMAIL PROTECTED] wrote:
On Tue, 2008-01-15 at 18:23 +0900, FUJITA Tomonori wrote:
This is the second version of
http://marc.info/?l=linux-scsim=119933628210006w=2
I gave up once, but I found that the performance loss is negligible
(within 1%)
On Nov. 01, 2007, 20:40 +0200, Matthew Wilcox [EMAIL PROTECTED] wrote:
On Thu, Nov 01, 2007 at 08:05:06PM +0200, Boaz Harrosh wrote:
@@ -287,8 +287,13 @@ struct request {
/*
* when request is used as a packet command carrier
*/
-unsigned int cmd_len;
+unsigned short
On Oct. 22, 2007, 21:35 +0200, Matthew Wilcox [EMAIL PROTECTED] wrote:
On Mon, Oct 22, 2007 at 09:10:49PM +0200, Boaz Harrosh wrote:
I'm about to finish an RFC patchset for the extended commands.
I have implemented a more aggressive approach than the one
I've been sending for the last year.
On Oct. 18, 2007, 2:47 +0200, Matthew Wilcox [EMAIL PROTECTED] wrote:
On Wed, Oct 17, 2007 at 08:21:15PM +0200, Boaz Harrosh wrote:
- Group all IO members of scsi_cmnd into a scsi_data_buffer
structure.
+struct scsi_data_buffer {
+unsigned length;
+int resid;
+unsigned
On Oct. 18, 2007, 10:06 +0200, Matthew Wilcox [EMAIL PROTECTED] wrote:
On Thu, Oct 18, 2007 at 08:59:58AM +0200, Benny Halevy wrote:
yeah. The sglist pointer shuffle makes sense and so are the field type
changes and coalescing, but the union holding the deprecated fields
of scsi_data_buff
On Sep 27, 2007, 18:46 +0200, FUJITA Tomonori [EMAIL PROTECTED] wrote:
On Fri, 28 Sep 2007 01:38:27 +0900
FUJITA Tomonori [EMAIL PROTECTED] wrote:
This patch is for Jens' block tree (sg chaining branch).
I don't have the hardware but this looks like a bug.
---
From: FUJITA Tomonori
Russell King wrote:
On Mon, Sep 10, 2007 at 10:39:11PM +0300, Boaz Harrosh wrote:
- Use new scsi_eh_prep/restor_cmnd() for synchronous
REQUEST_SENSE invocation.
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
drivers/scsi/arm/fas216.c | 16 +++-
Mike Christie wrote:
Mike Christie wrote:
For drivers like sg and st, do mean the the sg list that is passed to
functions like scsi_execute_async? If we kill that argument, and instead
have sg.c and other scsi_execute_async callers just call blk helpers
like blk_rq_map_user then we would
FUJITA Tomonori wrote:
From: Boaz Harrosh [EMAIL PROTECTED]
Subject: [RFC 7/8] sd.c and sr.c move to scsi_sgtable implementation
Date: Thu, 05 Jul 2007 16:44:04 +0300
- sd and sr would adjust IO size to align on device's block
size. So code needs to change once we move to scsi_sgtable
James Bottomley wrote:
On Tue, 2007-07-24 at 17:01 +0300, Benny Halevy wrote:
FUJITA Tomonori wrote:
I should have said that, was the approach to use separate buffer for
sglists instead of putting the sglists and the parameters in one
buffer completely rejected?
I think that James should
Just wondering, have you tried testing it with our patches to support
long cdb? If not, it would be great if you could try doing that.
A snapshot of them is in
http://www.bhalevy.com/open-osd/download/sgtable_bidi_varlen/
Benny
Hannes Reinecke wrote:
Hannes Reinecke wrote:
Hi James,
this
FUJITA Tomonori wrote:
I should have said that, was the approach to use separate buffer for
sglists instead of putting the sglists and the parameters in one
buffer completely rejected?
I think that James should be asked this question.
My understanding was that he preferred allocating the
Jens Axboe wrote:
On Wed, Jul 18 2007, Boaz Harrosh wrote:
Jens Axboe wrote:
On Wed, Jul 18 2007, Boaz Harrosh wrote:
FUJITA Tomonori wrote:
From: Mike Christie [EMAIL PROTECTED]
Subject: Re: [RFC 4/8] scsi-ml: scsi_sgtable implementation
Date: Thu, 12 Jul 2007 14:09:44 -0500
Boaz Harrosh
FUJITA Tomonori wrote:
From: Boaz Harrosh [EMAIL PROTECTED]
Subject: Re: [PATCH v2] add bidi support for block pc requests
Date: Thu, 17 May 2007 11:49:37 +0300
FUJITA Tomonori wrote:
From: Jens Axboe [EMAIL PROTECTED]
Subject: Re: [PATCH v2] add bidi support for block pc requests
Date:
FUJITA Tomonori wrote:
+#define scsi_for_each_sg(cmd, sg, nseg, __i) \
+ for (__i = 0, sg = scsi_sglist(cmd); __i (nseg); __i++, (sg)++)
+
This feels like a layering violation, why not use for_each_sg()?
+#define scsi_for_each_sg(cmd, sg, nseg, __i) \
FUJITA Tomonori wrote:
From: Benny Halevy [EMAIL PROTECTED]
Subject: Re: [PATCH 1/19] add data buffer accessors
Date: Mon, 14 May 2007 10:57:08 +0300
FUJITA Tomonori wrote:
+#define scsi_for_each_sg(cmd, sg, nseg, __i) \
+ for (__i = 0, sg = scsi_sglist(cmd); __i
Tomo,
Thanks for quickly crafting this patchset.
Please see my comments in-line below.
Putting aside the controversial design issues,
we need to carefully compare our patches against yours
to make sure no functional issues have been overlooked.
Benny
FUJITA Tomonori wrote:
From: FUJITA
Support for scsi variable length CDBs and bidirectional commands
Signed-off-by: Boaz Harrosh bharrosh@panasas.com
Signed-off-by: Benny Halevy bhalevy@panasas.com
//depot/pub/linux/block/scsi_ioctl.c#1 - /home/bharrosh/p4.local/pub/linux/block/scsi_ioctl.c
diff -Nup /tmp/tmp.12171.0 /home
Jens Axboe wrote:
On Mon, Apr 30 2007, Douglas Gilbert wrote:
Jens Axboe wrote:
On Mon, Apr 30 2007, Benny Halevy wrote:
Jens Axboe wrote:
On Sun, Apr 29 2007, James Bottomley wrote:
On Sun, 2007-04-29 at 18:48 +0300, Boaz Harrosh wrote:
FUJITA Tomonori wrote:
From: Boaz Harrosh [EMAIL
James Bottomley wrote:
On Mon, 2007-01-22 at 01:25 +0200, Boaz Harrosh wrote:
- Instantiate another request_io_part in request for bidi_read.
- Define Implement new API for accessing bidi parts.
- API to Build bidi requests and map to sglists.
- Define new end_that_request_block() function
Muli Ben-Yehuda wrote:
On Mon, Jan 22, 2007 at 01:21:28AM +0200, Boaz Harrosh wrote:
- Introduce a new enum dma_data_direction data_dir member in struct request.
and remove the RW bit from request-cmd_flag
Some architecture use 'enum dma_data_direction' and some 'int
Douglas Gilbert wrote:
Benny Halevy wrote:
Douglas Gilbert wrote:
Perhaps the right use of DMA_BIRECTIONAL needs to be
defined.
Could it be used with a XDWRITE(10) SCSI command
defined in sbc3r07.pdf at http://www.t10.org ? I suspect
using two scatter gather lists would be a better
Muli Ben-Yehuda wrote:
On Tue, Jan 23, 2007 at 03:45:00PM +0200, Benny Halevy wrote:
+static inline int dma_uni_dir(enum dma_data_direction dir)
+{
+ return (dir == DMA_TO_DEVICE) || (dir == DMA_FROM_DEVICE) ||
+ (dir == DMA_NONE);
+}
While this doesn't look very useful. Why
Douglas Gilbert wrote:
Boaz Harrosh wrote:
- Introduce a new enum dma_data_direction data_dir member in struct request.
and remove the RW bit from request-cmd_flag
- Add new API to query request direction.
- Adjust existing API and implementation.
- Cleanup wrong use of DMA_BIDIRECTIONAL
34 matches
Mail list logo
