Re: [PATCH v2 3/5] scsi_debug: add Capacity Changed Unit Attention

2014-12-04 Thread Ewan Milne
On Mon, 2014-11-24 at 23:05 -0500, Douglas Gilbert wrote: From: Douglas Gilbert dgilb...@interlog.com Date: Mon, 24 Nov 2014 20:27:51 -0500 Subject: [PATCH 3/5] add Capacity Changed Unit Attention Via sysfs the virtual_gb scsi_debug parameter can be changed while LUs are in use. If that

Re: [PATCH] scsi: remove scsi_driver owner field

2014-11-12 Thread Ewan Milne
On Wed, 2014-11-12 at 18:34 +0100, Christoph Hellwig wrote: The driver core driver structure has grown an owner field and now requires it to be set for all modular drivers. Set it up for all scsi_driver instances and get rid of the now superflous scsi_driver owner field. Signed-off-by:

Re: [RFC] Discard update for 3.19

2014-11-12 Thread Ewan Milne
On Mon, 2014-11-10 at 06:19 -0800, Christoph Hellwig wrote: Looks like there is no real dependency between these patches, so we might take on each through the libata, scsi and block trees. Can I get another review for the sd patch, please? The changes in [PATCH 2/3] sd: Disable

Re: [PATCHv7 00/26] scsi logging update (the boring part)

2014-10-07 Thread Ewan Milne
On Tue, 2014-10-07 at 11:02 +0200, Hannes Reinecke wrote: Hi all, here is not the seventh iteration of my scsi-logging update. The changes to v6 are: - fixup scsi_print_result() to not issue a '(null)' string (noticed by Ewan Milne) - Use matching command names in sd_print_result

Re: [PATCH 21/26] scsi: simplify scsi_log_(send|completion)

2014-10-06 Thread Ewan Milne
Rats. I found another case of (null) appearing in the log messages where I think you really just wanted no text at all to appear. Sorry I didn't find it last time along with the other one... -Ewan On Mon, 2014-10-06 at 11:01 +0200, Hannes Reinecke wrote: Simplify scsi_log_(send|completion) by

RE: [PATCH 04/24] scsi: introduce sdev_prefix_printk()

2014-10-03 Thread Ewan Milne
On Thu, 2014-10-02 at 18:37 +, Elliott, Robert (Server Storage) wrote: -Original Message- From: Hannes Reinecke [mailto:h...@suse.de] ... diff --git a/drivers/scsi/sd.h b/drivers/scsi/sd.h index 4c3ab83..c01dc89 100644 --- a/drivers/scsi/sd.h +++ b/drivers/scsi/sd.h @@

Re: [PATCH 1/2] be2iscsi : Fix kernel panic during reboot/shutdown

2014-10-02 Thread Ewan Milne
On Fri, 2014-09-26 at 15:13 -0400, John Soni Jose wrote: In the reboot/shutdown path, workqueue was destroyed after the adapter resource were freed. The task associated with workqueue was getting executed after resources were freed. This lead to kernel panic. Signed-off-by: John Soni

Re: [PATCH 22/24] scsi: fixup logging messages in scsi_error.c

2014-10-02 Thread Ewan Milne
On Wed, 2014-10-01 at 08:22 +0200, Hannes Reinecke wrote: Use the matching scope for logging messages to allow for better command tracing. Suggested-by: Robert Elliott elli...@hp.com Reviewed-by: Christoph Hellwig h...@lst.de Signed-off-by: Hannes Reinecke h...@suse.de ---

Re: [PATCH 2/2] Drivers: scsi: storvsc: Force discovery of LUNs that may have been removed.

2014-08-29 Thread Ewan Milne
On Thu, 2014-08-28 at 21:42 -0500, Mike Christie wrote: On 08/27/2014 09:31 AM, Hannes Reinecke wrote: On 08/19/2014 07:54 PM, Christoph Hellwig wrote: On Sat, Aug 16, 2014 at 08:09:48PM -0700, K. Y. Srinivasan wrote: The host asks the guest to scan when a LUN is removed or added. The

Re: [PATCH] scsi: fix various kernel-doc problems in scsi_error.c

2014-08-18 Thread Ewan Milne
On Sat, 2014-08-16 at 14:15 -0700, Randy Dunlap wrote: From: Randy Dunlap rdun...@infradead.org Convert spaces to tabs in kernel-doc notation. Correct duplicated (copy-paste) kernel-doc comments that are incorrect. Fix kernel-doc warning: Warning(..//drivers/scsi/scsi_error.c:1647): No

Re: [PATCH] fusion: fix excess parameter kernel-doc warning

2014-08-18 Thread Ewan Milne
On Sat, 2014-08-16 at 14:15 -0700, Randy Dunlap wrote: From: Randy Dunlap rdun...@infradead.org Fix kernel-doc excess parameter warning: Warning(..//drivers/message/fusion/mptbase.c:1411): Excess function parameter 'prod_name' description in 'mpt_get_product_name' Signed-off-by: Randy

Re: [RFC PATCH 03/10] scsi/constants: Cleanup printk message in __scsi_print_command()

2014-08-15 Thread Ewan Milne
On Fri, 2014-08-08 at 11:50 +, Yoshihiro YUNOMAE wrote: All bytes in CDB should be output after linebuf is filled because [%s] CDB: %s\n message is output many times in loop. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Hannes Reinecke h...@suse.de Cc: Doug

Re: [RFC PATCH 04/10] scsi/constants: Cleanup printk message in scsi_dump_sense_buffer()

2014-08-15 Thread Ewan Milne
On Fri, 2014-08-08 at 11:50 +, Yoshihiro YUNOMAE wrote: Unrecognized sense data should be output after linebuf is filled because [%s] Unrecognized sense data (in hex): %s message is output many times in loop. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Hannes

Re: [RFC PATCH 05/10] scsi/trace: Use macros for getting driver byte, host byte, msg byte, and status byte

2014-08-15 Thread Ewan Milne
On Fri, 2014-08-08 at 11:50 +, Yoshihiro YUNOMAE wrote: For getting driver byte, host byte, msg byte, and status byte, macros are implemented in scsi/scsi.h, so we use it. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Hannes Reinecke h...@suse.de Cc: Doug Gilbert

Re: [RFC PATCH 06/10] scsi/sd: Delete extra scsi_show_extd_sense() in sd_print_sense_hdr()

2014-08-15 Thread Ewan Milne
On Fri, 2014-08-08 at 11:50 +, Yoshihiro YUNOMAE wrote: sd_print_sense_hdr() calls scsi_show_extd_sense(), but scsi_print_sense_hdr() also calls scsi_show_extd_sense(). We can get same result, so we delete it. Note: Calling scsi_show_extd_sense() is introduced in fdd8b297.

Re: [PATCH] sg: limit maximum cdb size to 252 bytes

2014-06-26 Thread Ewan Milne
On Wed, 2014-06-25 at 13:05 -0400, Douglas Gilbert wrote: Boaz Harrosh commented on the [PATCH v5] sg: relax 16 byte cdb restriction thread that SCSI variable length commands (which are all SCSI commands greater than 16 bytes long) must themselves be a multiple of 4 bytes long. ChangeLog

Re: [PATCH 1/1] Add defines for new FC port speeds.

2014-06-25 Thread Ewan Milne
On Fri, 2014-06-13 at 16:40 +, Dick Kennedy wrote: These speeds are to support the next generation of FCoE port speeds. Signed-off-by: rkenn...@emulex.com --- drivers/scsi/scsi_transport_fc.c |4 include/scsi/scsi_transport_fc.h |4 2 files changed, 8 insertions(+), 0

Re: [PATCH 2/2] scsi: Do not complete timed-out command

2014-06-19 Thread Ewan Milne
On Tue, 2014-06-17 at 07:53 +0200, Hannes Reinecke wrote: On 06/16/2014 08:23 PM, Ewan Milne wrote: On Fri, 2014-06-13 at 14:01 +0200, Hannes Reinecke wrote: There is a possible race between scsi_times_out() and scsi_done(); the LLDD is only notified about a timed out command by calling

Re: [PATCH 2/2] scsi: Do not complete timed-out command

2014-06-16 Thread Ewan Milne
On Fri, 2014-06-13 at 14:01 +0200, Hannes Reinecke wrote: There is a possible race between scsi_times_out() and scsi_done(); the LLDD is only notified about a timed out command by calling scsi_try_to_abort_command(). Anytime before that the LLDD is free to complete the command via scsi_done().

Re: [PATCH 1/2] scsi_error: set DID_TIME_OUT correctly

2014-06-13 Thread Ewan Milne
On Fri, 2014-06-13 at 14:01 +0200, Hannes Reinecke wrote: Any callbacks in scsi_timeout_out() might return BLK_EH_RESET_TIMER, in which case we should leave the result alone and not set DID_TIME_OUT, as the command didn't actually timeout. Signed-off-by: Hannes Reinecke h...@suse.de ---

Re: [PATCH 2/2] scsi: Handle power-on reset unit attention

2014-06-11 Thread Ewan Milne
On Thu, 2014-06-05 at 09:26 +0200, Hannes Reinecke wrote: As per SAM there is a status precedence, with any sense code 29/XX taking second place just after an ACA ACTIVE status. Additionally, each target might prefer to not queue any unit attention conditions but just report one. Due to the

Re: [PATCH v2] sg: add SG_FLAG_Q_AT_TAIL flag

2014-06-11 Thread Ewan Milne
On Wed, 2014-06-04 at 10:58 -0400, Douglas Gilbert wrote: When the SG_IO ioctl was copied into the block layer and later into the bsg driver, subtle differences emerged. One difference is the way injected commands are queued through the block layer (i.e. this is not SCSI device queueing nor

Re: [PATCH] sd: bad return code of init_sd

2014-06-04 Thread Ewan Milne
On Tue, 2014-06-03 at 23:34 +0200, Clément Calmels wrote: In init_sd function, if kmem_cache_create or mempool_create_slab_pools calls fail, the error will not be correclty reported because class_register previously set the value of err to 0. Signed-off-by: Clément Calmels

Re: [PATCH] sd: Limit transfer length

2014-06-02 Thread Ewan Milne
On Mon, 2014-06-02 at 15:11 -0400, Martin K. Petersen wrote: Until now the per-command transfer length has exclusively been gated by the max_sectors parameter in the scsi_host template. Given that the size of this parameter has been bumped to an unsigned int we have to be careful not to exceed

Re: [PATCHv2 0/5] Support 64-bit LUNs

2014-05-28 Thread Ewan Milne
On Tue, 2014-05-20 at 13:03 +0200, Hannes Reinecke wrote: Hi all, this patchset updates the SCSI stack to support full 64-bit LUNs. The first patch is a simple fix; the next patch updates the sequential scan logic to be compliant with SPC. The third patch addresses a firmware issue with

Re: scsi error handling thread and REQUEST SENSE

2014-05-16 Thread Ewan Milne
On Fri, 2014-05-16 at 19:02 +, Elliott, Robert (Server Storage) wrote: There is an issue with a command timeout followed by a failed abort in the linux SCSI stack. This might explain some odd crashes I've seen, where it looks like a command might have completed *long* after it should have

Re: [PATCH] sd: medium access timeout counter fails to reset

2014-04-14 Thread Ewan Milne
On Thu, 2014-04-10 at 11:08 -0400, David Jeffery wrote: There is an error with the medium access timeout feature of the sd driver. The sdkp-medium_access_timed_out value is reset to zero in sd_done() in the wrong place. Currently it is reset to zero only when a command returns sense data.

Re: [PATCH 1/3] VMW_PVSCSI: Fix pvscsi_abort() function.

2014-03-10 Thread Ewan Milne
to the mid-layer while the mid-layer has already requested the driver to abort that command, in response to which the driver has responded with SUCCESS causing mid-layer to free the command struct. Signed-off-by: Arvind Kumar arvindku...@vmware.com Cc: Ewan Milne emi...@redhat.com This patch

Re: [PATCH] scsi_error: disable eh_deadline if no host_reset_handler is set

2014-01-07 Thread Ewan Milne
On Thu, 2013-12-12 at 12:08 +0100, Hannes Reinecke wrote: When the host template doesn't declare an eh_host_reset_handler the eh_deadline mechanism is pointless and will set the device to offline. So disable eh_deadline if no eh_host_reset_handler is present. Cc: Ewan Milne emi

Re: qla2xxx: automatically rescan removed luns.

2013-11-25 Thread Ewan Milne
On Mon, 2013-11-25 at 15:37 +, Benjamin ESTRABAUD wrote: Hi, Using the qla2xxx driver from Linux 3.10.1 (release), if a LUN from the target side (multiple drives exported over a LIO IBlock qla2xxx export) is removed at the LIO level, the initiator side will not automatically detect

RE: Question on SCSI target scan

2013-11-18 Thread Ewan Milne
On Fri, 2013-11-15 at 23:53 +, Elliott, Robert (Server Storage) wrote: Beware that just because the LUN inventory is the same doesn't mean the logical units are the same. A logical unit at LUN X might have been deleted and another logical unit created and assigned to LUN X, but now

Re: [PATCH] scsi: Add missing sysfs attribute to scsi_device structure

2013-11-18 Thread Ewan Milne
On Mon, 2013-11-18 at 09:45 -0800, James Bottomley wrote: On Mon, 2013-11-18 at 12:10 -0500, Ewan D. Milne wrote: From: Ewan D. Milne emi...@redhat.com This change adds a missing sysfs attribute to scsi_device which is set when a previously scanned device no longer appears in the

Re: [PATCH] scsi: Add missing sysfs attribute to scsi_device structure

2013-11-18 Thread Ewan Milne
On Mon, 2013-11-18 at 10:15 -0800, James Bottomley wrote: On Mon, 2013-11-18 at 12:59 -0500, Ewan Milne wrote: On Mon, 2013-11-18 at 09:45 -0800, James Bottomley wrote: On Mon, 2013-11-18 at 12:10 -0500, Ewan D. Milne wrote: From: Ewan D. Milne emi...@redhat.com This change adds

Re: [PATCH 8/8] scsi_error: Escalate to LUN reset if abort fails

2013-10-23 Thread Ewan Milne
On Wed, 2013-10-23 at 10:51 +0200, Hannes Reinecke wrote: If a command abort fails there is a fair chance that all other aborts will be failing, too. So we should be calling LUN reset directly after the first failed abort and skip aborting the remaining commands. Signed-off-by: Hannes

Re: [PATCH 7/7] scsi: Add 'eh_deadline' to limit SCSI EH runtime

2013-10-17 Thread Ewan Milne
On Wed, 2013-10-16 at 19:22 +, James Bottomley wrote: What about instead: static int scsi_host_eh_past_deadline(struct Scsi_Host *shost, int percent) { if (!shost-last_reset || !shost-eh_deadline) return 0; if (time_before(jiffies,

Re: Drivers: scsi: FLUSH timeout

2013-10-04 Thread Ewan Milne
On Thu, 2013-10-03 at 13:48 -0700, Eric Seppanen wrote: On Thu, Oct 3, 2013 at 5:09 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Wed, 2013-10-02 at 18:29 +, KY Srinivasan wrote: Ideally, I want this to be adjustable like the way we can change the I/O timeout. Since

Re: notify userspace of offline - running transitions

2013-09-24 Thread Ewan Milne
http://marc.info/?l=linux-scsim=133901769900806w=2 Can we reconsider applying patch 4 in Mike's set? The problem still exists, and there was never another solution proposed as far as I can see. (I posted a question about this a while back...) It is a big issue for people who happen to get a

Re: SCSI's heuristics for enabling WRITE SAME still need work [was: dm mpath: disable WRITE SAME if it fails]

2013-09-23 Thread Ewan Milne
On Fri, 2013-09-20 at 18:03 -0400, Martin K. Petersen wrote: ... Only a handful of the very latest and greatest devices support RSOC. The number of devices that support WRITE SAME is orders of magnitude larger. Last I checked I had exactly 1 out of about 100 devices in my lab that supported

Re: [patch] block: fix race between request completion and timeout handling

2013-09-10 Thread Ewan Milne
On Thu, 2013-08-29 at 15:14 -0400, Jeff Moyer wrote: ... RIP: 0010:[8124e424] [8124e424] blk_requeue_request+0x94/0xa0 ... Call Trace: [81362323] __scsi_queue_insert+0xa3/0x150 [8135f393] ? scsi_eh_ready_devs+0x5e3/0x850 [81362a23]

Re: [RFC PATCH] scsi: Add failfast mode to avoid infinite retry loop

2013-08-23 Thread Ewan Milne
On Fri, 2013-08-23 at 06:19 -0700, James Bottomley wrote: On Fri, 2013-08-23 at 18:10 +0900, Eiichi Tsukata wrote: Yes, basically the device should be offlined on error detection. Just offlining the disk is enough when an error occurs on not os-installed system disk. Panic is going too far

Re: [RFC PATCH] scsi: Add failfast mode to avoid infinite retry loop

2013-08-20 Thread Ewan Milne
On Tue, 2013-08-20 at 16:13 +0900, Eiichi Tsukata wrote: (2013/08/19 23:30), James Bottomley wrote: On Mon, 2013-08-19 at 18:39 +0900, Eiichi Tsukata wrote: Hello, This patch adds scsi device failfast mode to avoid infinite retry loop. Currently, scsi error handling in

Re: [PATCH v4 08/10] scsi: Generate uevents on certain unit attention codes

2013-08-09 Thread Ewan Milne
On Thu, 2013-08-08 at 18:15 -0700, James Bottomley wrote: On Thu, 2013-08-08 at 12:08 -0400, Ewan Milne wrote: On Fri, 2013-08-02 at 10:06 -0700, James Bottomley wrote: On Thu, 2013-08-01 at 16:57 -0400, Ewan D. Milne wrote: From: Ewan D. Milne emi...@redhat.com

Re: [PATCH v4 08/10] scsi: Generate uevents on certain unit attention codes

2013-08-08 Thread Ewan Milne
On Fri, 2013-08-02 at 10:06 -0700, James Bottomley wrote: On Thu, 2013-08-01 at 16:57 -0400, Ewan D. Milne wrote: From: Ewan D. Milne emi...@redhat.com Generate a uevent when the following Unit Attention ASC/ASCQ codes are received: 2A/01 MODE PARAMETERS CHANGED 2A/09

Re: [PATCH v3 0/6] [SCSI] Enhanced sense and Unit Attention handling

2013-07-22 Thread Ewan Milne
On Mon, 2013-07-22 at 15:31 +, James Bottomley wrote: Ping on this, please. I have another possible consumer of this infrastructure, when it's ready, which is the SCSI RAID drivers. We've been getting complaints that there's no event we get from them when a RAID system goes from online

Re: [PATCHv2 0/7] Limit overall SCSI EH runtime

2013-07-12 Thread Ewan Milne
On Fri, 2013-07-12 at 13:54 +0800, Ren Mingxin wrote: Hi, Ewan: I'm wondering how do you test, with a special hardware or self-made module?Would you mind pasting your test method() and result? Hi Rex- This was tested in a SAN environment with an EMC Symmetrix and Brocade FC switches. The

Re: [PATCH] [SCSI] sd: fix crash when UA received on DIF enabled device

2013-07-10 Thread Ewan Milne
On Tue, 2012-11-06 at 17:48 -0500, Martin K. Petersen wrote: Ewan == Ewan D Milne emi...@redhat.com writes: Ewan sd_prep_fn will allocate a larger CDB for the command via Ewan mempool_alloc for devices using DIF type 2 protection. This CDB Ewan was being freed in sd_done, which results in

Re: [PATCHv2 0/7] Limit overall SCSI EH runtime

2013-07-10 Thread Ewan Milne
On Mon, 2013-07-01 at 08:50 +0200, Hannes Reinecke wrote: This patchset implements a new 'eh_deadline' attribute to the SCSI host. It will limit the overall SCSI EH runtime by a given timeout. If the timeout is reached all intermediate EH steps will be skipped and host reset will be scheduled

Re: [PATCH 7/7] scsi: Add 'eh_deadline' to limit SCSI EH runtime

2013-06-28 Thread Ewan Milne
On Fri, 2013-06-28 at 09:14 +0200, Hannes Reinecke wrote: @@ -232,6 +272,9 @@ int scsi_eh_scmd_add(struct scsi_cmnd *scmd, int eh_flag) if (scsi_host_set_state(shost, SHOST_CANCEL_RECOVERY)) goto out_unlock; + if (sdev-eh_deadline !shost-last_reset)

Re: [PATCH 7/7] scsi: Add 'eh_deadline' to limit SCSI EH runtime

2013-06-27 Thread Ewan Milne
The eh_deadline changes allow for a significant improvement in multipath failover time. It works very well in our testing. I do have a few corrections, see below: On Mon, 2013-06-10 at 13:11 +0200, Hannes Reinecke wrote: This patchs adds an 'eh_deadline' attribute to the scsi host which limits

Re: [PATCH v3 4/6] [SCSI] Generate uevents for certain Unit Attention codes

2013-06-24 Thread Ewan Milne
On Wed, 2013-06-19 at 18:48 +, James Bottomley wrote: On Wed, 2013-06-19 at 13:42 -0400, Ewan D. Milne wrote: From: Ewan D. Milne emi...@redhat.com Generate a uevent on the scsi_target object when the following Unit Attention ASC/ASCQ code is received: 3F/0E REPORTED LUNS

Re: [PATCH v3 2/6] [SCSI] Rename scsi_evt_xxx to sdev_evt_xxx and scsi_event to sdev_event

2013-06-24 Thread Ewan Milne
On Wed, 2013-06-19 at 18:36 +, James Bottomley wrote: On Wed, 2013-06-19 at 13:42 -0400, Ewan D. Milne wrote: From: Ewan D. Milne emi...@redhat.com The names of the struct and some of the functions for scsi_device events are too generic and do not match the comments in the source.

Re: [PATCH v3 3/6] [SCSI] Add support for scsi_target events

2013-06-19 Thread Ewan Milne
On Wed, 2013-06-19 at 19:54 +0200, Bart Van Assche wrote: On 06/19/13 19:42, Ewan D. Milne wrote: +static void starget_evt_emit(struct scsi_target *starget, +struct starget_event *evt) +{ + int idx = 0; + char *envp[3]; + + switch (evt-evt_type) { +

Re: [PATCH v3 1/6] [SCSI] Add a kernel config option for enhanced Unit Attention support

2013-06-19 Thread Ewan Milne
On Wed, 2013-06-19 at 18:35 +, James Bottomley wrote: On Wed, 2013-06-19 at 13:42 -0400, Ewan D. Milne wrote: From: Ewan D. Milne emi...@redhat.com Added CONFIG_SCSI_ENHANCED_UA kernel config option to enable changes in the SCSI mid-layer which detect and report certain Unit

Re: [PATCH 3/9] scsi: improved eh timeout handler

2013-06-11 Thread Ewan Milne
On Tue, 2013-06-11 at 18:57 +, James Bottomley wrote: On Mon, 2013-06-10 at 01:20 -0700, Christoph Hellwig wrote: On Mon, Jun 10, 2013 at 09:40:52AM +0200, Hannes Reinecke wrote: When a command runs into a timeout we need to send an 'ABORT TASK' TMF. This is typically done by the

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-10 Thread Ewan Milne
On Thu, 2013-05-09 at 23:11 -0400, Martin K. Petersen wrote: Introduce eh_timeout which can be used for error handling purposes. This was previously hardcoded to 10 seconds in the SCSI error handling code. However, for some fast-fail scenarios it is necessary to be able to tune this as it can

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-10 Thread Ewan Milne
On Fri, 2013-05-10 at 16:22 +0300, Baruch Even wrote: On Fri, May 10, 2013 at 3:43 PM, Ewan Milne emi...@redhat.com wrote: On Thu, 2013-05-09 at 23:11 -0400, Martin K. Petersen wrote: Introduce eh_timeout which can be used for error handling purposes. This was previously hardcoded to 10

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-10 Thread Ewan Milne
On Fri, 2013-05-10 at 16:24 +0200, Hannes Reinecke wrote: On 05/10/2013 04:01 PM, Ewan Milne wrote: On Fri, 2013-05-10 at 16:22 +0300, Baruch Even wrote: On Fri, May 10, 2013 at 3:43 PM, Ewan Milne emi...@redhat.com wrote: On Thu, 2013-05-09 at 23:11 -0400, Martin K. Petersen wrote

Re: notify userspace of offline - running transitions

2013-05-06 Thread Ewan Milne
http://marc.info/?l=linux-scsim=133769378525796w=2 Did anything ever happen with this? I don't see that it did. There seems to be a problem with udev processing an event for a device at a time when the device can't be accessed. Mike's original fix was to generate another KOBJ_CHANGE event when

Re: [PATCH v2 0/8] [SCSI] Enhanced sense and Unit Attention handling

2013-04-15 Thread Ewan Milne
On Thu, 2013-04-11 at 16:52 -0500, Jeremy Linton wrote: What happened to this patch? The trail of suggested fixes for the REPORT LUNS DATA HAS CHANGED check condition is getting pretty long. The number of devices (our product included) in the field that have the ability to on the fly

Re: [PATCH v2 0/8] [SCSI] Enhanced sense and Unit Attention handling

2013-04-15 Thread Ewan Milne
On Mon, 2013-04-15 at 11:20 -0500, Jeremy Linton wrote: On 4/15/2013 9:13 AM, Ewan Milne wrote: patch could attempt to clear the check conditions from LUNs that share the I_T. I think the mid-layer will handle that automatically. If check conditions are reported the commands

Re: [PATCH] [SCSI] sd: Do not return success from init_sd if DIF mempool allocation fails

2013-04-05 Thread Ewan Milne
On Thu, 2013-02-14 at 11:36 -0500, Ewan D. Milne wrote: From: Ewan D. Milne emi...@redhat.com init_sd() was returning 0 if sd_cdb_cache or sd_cdb_pool could not be allocated. Return -ENOMEM instead, since the sd_disk_class and the blkdevs will be unregistered if this happens.

RE: [PATCH] scsi_dh_alua: Add module parameter to allow failover to non preferred path without STPG

2013-04-02 Thread Ewan Milne
On Mon, 2013-04-01 at 21:18 +, Stewart, Sean wrote: How about the following? Reworded in a way such that 0 means no and 1 means yes. +static uint optimize_stpg; +module_param(optimize_stpg, uint, S_IRUGO|S_IWUSR); +MODULE_PARM_DESC(optimize_stpg, Allow use of a non-optimized path,

Re: [PATCH] scsi_dh_alua: Add module parameter to allow failover to non preferred path without STPG

2013-04-01 Thread Ewan Milne
On Thu, 2013-03-28 at 22:07 +, Stewart, Sean wrote: +static uint optimize_stpg; +module_param(optimize_stpg, uint, S_IRUGO|S_IWUSR); +MODULE_PARM_DESC(optimize_stpg, Send STPG command for Failover on non-preferred path(0=Yes,1=No). Default is 0.); Could you possibly reword the

Re: [PATCH v2] st: Take additional queue ref in st_probe

2013-03-15 Thread Ewan Milne
On Tue, 2013-03-05 at 10:57 -0500, Joe Lawrence wrote: Changes from v1: Corrected error paths as noted by Ewan Milne and Jan Vesely. Acked-by: Ewan D. Milne emi...@redhat.com These changes were applied to scsi.git, branch misc. This patch fixes a reference count bug in the SCSI tape

Re: [PATCH V3 0/4] Configure number of LUs reported by 'report-luns'

2013-03-07 Thread Ewan Milne
On Thu, 2013-03-07 at 08:38 -0500, Rob Evers wrote: This patch set retrieves the number of LUs available on a target using the report-luns command. The initial size of the report-luns command is 512 entries, as the previous default initial number was. If more LUs than 511 are present on a

Re: [PATCH] st: Take additional queue ref in st_probe

2013-03-04 Thread Ewan Milne
On Mon, 2013-03-04 at 11:14 -0500, Joe Lawrence wrote: These changes were applied to scsi.git, branch misc. This patch fixes a reference count bug in the SCSI tape driver which can be reproduced with the following: * Boot with slub_debug=FZPU, tape drive attached * echo 1 /sys/devices/...

Re: [PATCH] [SCSI] scsi_debug: Do not respond to INQUIRY commands with CHECK CONDITION when sense pending

2013-02-15 Thread Ewan Milne
On Thu, 2013-02-14 at 16:46 -0500, Douglas Gilbert wrote: On 13-02-14 11:36 AM, Ewan D. Milne wrote: From: Ewan D. Milne emi...@redhat.com According to SPC, INQUIRY commands are not supposed to respond with a CHECK CONDITION due to a pending UNIT ATTENTION. This was causing failures

Re: [PATCH RFC 0/9] [SCSI] Enhanced sense and Unit Attention handling

2013-01-31 Thread Ewan Milne
Thanks to everyone for the comments on this patch series. Based upon the feedback, I'll be making the following changes to the patch series before submitting it: - Remove patch 1/9 Detect overflow of sense data buffer - Change name of sdev_evt_thread to sdev_evt_work - Change name of

Re: [PATCH RFC 0/9] [SCSI] Enhanced sense and Unit Attention handling

2013-01-28 Thread Ewan Milne
On Mon, 2013-01-28 at 09:52 -0600, Jeremy Linton wrote: On 1/28/2013 9:44 AM, Bart Van Assche wrote: when using Fibre Channel as transport layer. I'm looking for a solution that also works with other SCSI transports, e.g. iSCSI and SRP. Doesn't iSCSI have a SNS server you can

Re: [PATCH RFC 0/9] [SCSI] Enhanced sense and Unit Attention handling

2013-01-24 Thread Ewan Milne
On Wed, 2013-01-23 at 17:19 -0700, Bart Van Assche wrote: On Fri, Jan 18, 2013 at 9:27 AM, Ewan D. Milne emi...@redhat.com wrote: This patch set adds changes to the SCSI mid-layer, sysfs and scsi_debug to provide enhanced support for Unit Attention conditions, as well as detection of

Re: [PATCH RFC 0/9] [SCSI] Enhanced sense and Unit Attention handling

2013-01-24 Thread Ewan Milne
On Thu, 2013-01-24 at 12:38 +0100, Hannes Reinecke wrote: On 01/24/2013 01:19 AM, Bart Van Assche wrote: On Fri, Jan 18, 2013 at 9:27 AM, Ewan D. Milne emi...@redhat.com wrote: This patch set adds changes to the SCSI mid-layer, sysfs and scsi_debug to provide enhanced support for Unit

Re: [PATCH RFC 0/9] [SCSI] Enhanced sense and Unit Attention handling

2013-01-24 Thread Ewan Milne
On Thu, 2013-01-24 at 16:15 +0100, Hannes Reinecke wrote: On 01/24/2013 04:00 PM, Mike Christie wrote: On 01/24/2013 07:51 AM, Hannes Reinecke wrote: On 01/24/2013 03:38 PM, Bart Van Assche wrote: On Thu, Jan 24, 2013 at 4:38 AM, Hannes Reinecke h...@suse.de wrote: As for AEN, does iSCSI

Re: [PATCH RFC 0/9] [SCSI] Enhanced sense and Unit Attention handling

2013-01-24 Thread Ewan Milne
On Thu, 2013-01-24 at 07:01 -0700, Mike Christie wrote: On 01/24/2013 04:38 AM, Hannes Reinecke wrote: On 01/24/2013 01:19 AM, Bart Van Assche wrote: On Fri, Jan 18, 2013 at 9:27 AM, Ewan D. Milne emi...@redhat.com wrote: This patch set adds changes to the SCSI mid-layer, sysfs and

Re: [PATCH RFC 4/9] [SCSI] Rename scsi_evt_xxx to sdev_evt_xxx and scsi_event to sdev_event

2013-01-23 Thread Ewan Milne
On Tue, 2013-01-22 at 10:38 -0700, Bart Van Assche wrote: On Fri, Jan 18, 2013 at 9:27 AM, Ewan D. Milne emi...@redhat.com wrote: @@ -2206,7 +2206,7 @@ static void scsi_evt_emit(struct scsi_device *sdev, struct scsi_event *evt) * Dispatch queued events to their associated scsi_device

Re: [PATCH RFC 4/9] [SCSI] Rename scsi_evt_xxx to sdev_evt_xxx and scsi_event to sdev_event

2013-01-23 Thread Ewan Milne
On Tue, 2013-01-22 at 10:33 -0700, Bart Van Assche wrote: On Fri, Jan 18, 2013 at 9:27 AM, Ewan D. Milne emi...@redhat.com wrote: @@ -2206,7 +2206,7 @@ static void scsi_evt_emit(struct scsi_device *sdev, struct scsi_event *evt) * Dispatch queued events to their associated

Re: [PATCH RFC 1/9] [SCSI] Detect overflow of sense data buffer

2013-01-23 Thread Ewan Milne
On Wed, 2013-01-23 at 13:06 +, James Bottomley wrote: On Tue, 2013-01-22 at 10:08 -0500, Ewan Milne wrote: On Fri, 2013-01-18 at 16:46 +, James Bottomley wrote: On Fri, 2013-01-18 at 11:27 -0500, Ewan D. Milne wrote: --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi

Re: [PATCH RFC 1/9] [SCSI] Detect overflow of sense data buffer

2013-01-22 Thread Ewan Milne
On Fri, 2013-01-18 at 16:46 +, James Bottomley wrote: On Fri, 2013-01-18 at 11:27 -0500, Ewan D. Milne wrote: --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c @@ -241,6 +241,9 @@ static int scsi_check_sense(struct scsi_cmnd *scmd) if (!

Re: [PATCH RFC 1/9] [SCSI] Detect overflow of sense data buffer

2013-01-22 Thread Ewan Milne
On Mon, 2013-01-21 at 08:26 +0100, Hannes Reinecke wrote: On 01/18/2013 05:46 PM, James Bottomley wrote: On Fri, 2013-01-18 at 11:27 -0500, Ewan D. Milne wrote: --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c @@ -241,6 +241,9 @@ static int scsi_check_sense(struct scsi_cmnd

Re: [PATCH RFC 8/9] [SCSI] Add sense and Unit Attention generation to scsi_debug

2013-01-22 Thread Ewan Milne
On Sat, 2013-01-19 at 13:43 -0500, Douglas Gilbert wrote: On 13-01-18 11:27 AM, Ewan D. Milne wrote: From: Ewan D. Milne emi...@redhat.com Added capability to scsi_debug to generate sense and Unit Attention conditions to exercise the enhanced sense and Unit Attention handling.

Re: Slow writes to SAS drives on LSI mpt2sas HBA

2012-12-03 Thread Ewan Milne
On Mon, 2012-12-03 at 14:48 -0500, Gregory Haskins wrote: Hello, I am experiencing a significant performance issue in write thoughput with SAS devices connected via an LSI 9207-8e (LSISAS2308 based) HBA. SATA devices plugged into the same rig appear to be ok. I first noticed this in

Re: Error handling on FC devices

2012-11-27 Thread Ewan Milne
On Mon, 2012-11-26 at 17:32 -0500, James Smart wrote: Given path switching is somewhat separate from the i/o, would it better to send a notification of a path-fail condition as part of the eh, rather than hinging it on the individual i/o. Yes, the i/o is still in limbo and can't be

<    1   2