Matthew Wilcox wrote:
Replace ASC_DBG{,1,2,3,4,5} with a single variadic macro ASC_DBG. As
suggested by Jeff Garzik, include DRV_NAME and __FUNCTION__ in the output.
Change all callers to no longer include the function name in the string.
Enabling ADVANSYS_DEBUG to test this feature shows
Matthew Wilcox wrote:
asc_board_t was simply a typedef for struct asc_board. ASC_BOARDP()
can be replaced by shost_priv() except in the ASC_STATS* macros which
rely on the cast; add an explicit cast there.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
ACK
-
To unsubscribe from this list:
Matthew Wilcox wrote:
It's always a mistake to have your own index of boards; just use the
scsi host number.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
ACK, though the return; cleanup is large enough to warrant a separate
patch, or at the very least, deserves a mention in the patch
Matthew Wilcox wrote:
The board lock was essentially identical with the host lock.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
ACK, though the s/spin_lock_irqsave/spin_lock/ in the interrupt handler
deserves a mention in the patch description
-
To unsubscribe from this list: send the
Matthew Wilcox wrote:
Convert the call to virt_to_bus() into a call to dma_map_single(). Some
architectures may require different DMA addresses for different devices,
so allocate one overrun buffer per host rather than one for all cards.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
check
Matthew Wilcox wrote:
Replace ASC_VADDR_TO_U32 and ASC_U32_TO_VADDR with an auto-expanding
array that maps pointers to 32-bit IDs and back. One of the uses of
ASC_VADDR_TO_U32 was in error; it should have been using ADV_VADDR_TO_U32.
Also replace the use of virt_to_bus when setting the
Matthew Wilcox wrote:
This rather complex function boiled down to calling virt_to_bus().
Also get rid of some obsolete defines and variables that could never vary.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
ACK
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
Matthew Wilcox wrote:
With the ASC and ADV libraries merged into the driver, there really is
no point in reporting their version numbers, or even trying to maintain
them.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
It would be real nice if those printk's started growing KERN_xx prefixes
Matthew Wilcox wrote:
It was only ever set; never tested, nor cleared.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
ACK
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the
Matthew Wilcox wrote:
The wide and narrow boards share identical handling of the return value,
except for some trivial error messages. Move the handling to the common
end of the function. Also move variable declarations to the arms of
the `if' that they're used in and delete some pointless
Matthew Wilcox wrote:
The driver was saving a scsi_device for each target, but wasn't doing
anything useful with them. Just delete the array.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
ACK
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message
Matthew Wilcox wrote:
On Tue, Oct 02, 2007 at 10:00:18PM -0400, Jeff Garzik wrote:
Matthew Wilcox wrote:
-#define PortAddr unsigned short /* port address size
*/
+#define PortAddr unsigned int /* port address size
*/
#define inp(port)inb(port
Matthew Wilcox wrote:
On Tue, Oct 02, 2007 at 10:28:29PM -0400, Jeff Garzik wrote:
Incorrect. That is highly platform specific, with many using unsigned
long, since the [non-x86] platform is generally pointing to a special
memory region rather than directly using an x86-like instruction
Luben Tuikov wrote:
--- Jeff Garzik [EMAIL PROTECTED] wrote:
Luben Tuikov wrote:
This still does not justify let's generate it in the kernel.
Once an admin specifies to use an alternate WWN provision, the method
used to obtain that WWN is an implementation detail and irrelevant.
But you're
Luben Tuikov wrote:
--- Jeff Garzik [EMAIL PROTECTED] wrote:
Luben Tuikov wrote:
--- Jeff Garzik [EMAIL PROTECTED] wrote:
Luben Tuikov wrote:
This still does not justify let's generate it in the kernel.
Once an admin specifies to use an alternate WWN provision, the method
used to obtain
Luben Tuikov wrote:
--- Jeff Garzik [EMAIL PROTECTED] wrote:
The admin will have the option to auto-generate a WWN, should they so
desire.
What does that mean? auto-generate? By whom?
The admin tells the kernel module to auto-generate a WWN, and the kernel
module happily obliges
Luben Tuikov wrote:
Do you mean:
The admin will have the option to SPECIFY(SET) a WWN, should they so
desire.
OR do you mean:
The admin will have the option to HAVE THE KERNEL auto-generate a WWN,
should they so desire.
Both. It is up to admin policy to decide if they wish to use
David Miller wrote:
From: Jeff Garzik [EMAIL PROTECTED]
Date: Sun, 30 Sep 2007 20:52:45 -0400
David Miller wrote:
It compiles :-) You deleted the only uses of scsi_rbuf_{get,put}()
so you can kill those off too.
Seeing as how they are exact duplicates of libata's
ata_scsi_rbuf_{get,put
Boaz Harrosh wrote:
- Christoph or Jeff will work on the finish up of the BUS hotplug API.
I have looked at code examples elsewhere in the kernel, and Jeff's
master plan sounds very good. But I would hope not to do it myself
as it will take me much longer.
Jeff it sounds like you have
The SSP response DPRINTK in asd_get_response_tasklet() was printing
a hardcoded status result, rather than the status from the SSP
response IU.
Arguably, this should not be a DPRINTK either, since the admin might
want to know about this.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
drivers
James Bottomley wrote:
On Thu, 2007-09-27 at 21:01 -0400, Jeff Garzik wrote:
James Bottomley wrote:
On Wed, 2007-09-26 at 03:35 -0400, Jeff Garzik wrote:
sas_hash_addr() is the spec-defined standard hashing function. Make it
available to drivers that need it.
I'm not opposed in principle
Jeff Garzik wrote:
James Bottomley wrote:
On Thu, 2007-09-27 at 21:01 -0400, Jeff Garzik wrote:
James Bottomley wrote:
On Wed, 2007-09-26 at 03:35 -0400, Jeff Garzik wrote:
sas_hash_addr() is the spec-defined standard hashing function.
Make it
available to drivers that need it.
I'm
Boaz Harrosh wrote:
[8/16] gdth: Remove virt hosts - Christoph Boaz
Here we need an executive decision! The issue is as stated by Christoph:
The virt_ctr option allows to register a new scsi_host for each bus
on the raid controller. This non-default option makes no sense with
Boaz Harrosh wrote:
[11/16] gdth: switch to modern scsi host registration - Christoph
Christoph what is missing from here is the remove of the deprecated
pci_find_device() call. Can I Just use pci_get_device() of the same signature
or do I need to call some other pci_ members after that?
BTW, when reposting the patches of others, its nice to add a From:
header to the very first line of the email body. Andrew does that a
lot, and the git tools are aware of this convention.
Also, hey, if you like our patches, I think you should add your own
Signed-off-by line (assuming/hoping
Christoph Hellwig wrote:
The big problem with the pci_driver conversion is that lack of device
ids in the driver. A few years ago I sent Achim a mail to ask if there's
a definitive list of used PCI ids, but didn't get an answer - maybe
the mail bounced. If we can't get this list we'd have to
The patchset looks pretty good to me, overall.
Thanks for pulling all this stuff together!
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
David Miller wrote:
It compiles :-) You deleted the only uses of scsi_rbuf_{get,put}()
so you can kill those off too.
Seeing as how they are exact duplicates of libata's
ata_scsi_rbuf_{get,put}, I wonder how they got there in the first place
(rather than becoming common code), and I wonder
Muli Ben-Yehuda wrote:
On Fri, Sep 28, 2007 at 04:55:34PM -0700, Darrick J. Wong wrote:
On Thu, Sep 27, 2007 at 10:33:41PM -0400, Jeff Garzik wrote:
Unless I'm missing something, the SMP request goes /to/ the PCI device :)
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
ACK; builds ok and SMP
Eduardo Habkost wrote:
Trying to ioremap() a larger area than pci_resource_len()
may fail (e.g. under Xen). Fixes 3w-9xxx to use pci_resource_len()
as length parameter to ioremap() instead of PAGE_SIZE.
Signed-off-by: Eduardo Habkost [EMAIL PROTECTED]
---
drivers/scsi/3w-9xxx.c | 14
FUJITA Tomonori wrote:
You are right. scsi_debug's pseudo-bus works.
But probabaly, scsi_debug doesn't need to call
blk_queue_max_segment_size now.
Either way works for me. :)
Maybe dev_set_max_seg() is a better name, if people get really picky (I
don't care).
How about
FUJITA Tomonori wrote:
CC'ed Jens, James, and linux-scsi.
On Thu, 27 Sep 2007 03:31:55 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
FUJITA Tomonori wrote:
Yeah, we could nicely handle lld's restrictions (especially with
stacking devices). But iommu code needs only max_segment_size
Is there an accepted way to generate a SAS address, when the adapter
does not supply one (NVRAM invalid or missing, etc.)?
Unless somebody complains, I was just planning to use
get_random_bytes(). But maybe Linux has an IEEE id we can use, to make
the practice a bit more legitimate and avoid
James Smart wrote:
Uh, although this may work very well for small constrained configs, as one
who debugs larger environments (and things always grow or get connected in
ways you don't expect), depending on a random number for uniqueness makes
me very unsettled. Debugging that small-percentage
Matthew Wilcox wrote:
On Thu, Sep 27, 2007 at 09:16:13AM -0500, [EMAIL PROTECTED] wrote:
Unfortunately, it looks like IEEE doesn't have any OID's registered for
Linux or other reserved areas
(http://standards.ieee.org/regauth/oui/oui.txt). However, it does look
like they go in order... so maybe
Michael Reed wrote:
Record the WWN of your SAS / FC port so that if/when it goes missing you
can put it back? Have spares on site?
Linux: not just for million dollar data centers any more :)
(sorry, couldn't resist :))
More seriously, SAS will be making an increasing appearance on
Unless I'm missing something, the SMP request goes /to/ the PCI device :)
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
drivers/scsi/aic94xx/aic94xx_task.c |4 -
2 files changed, 83 insertions(+), 17 deletions(-)
diff --git a/drivers/scsi/aic94xx/aic94xx_task.c
b/drivers/scsi/aic94xx
sas_hash_addr() is the spec-defined standard hashing function. Make it
available to drivers that need it.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
diff --git a/drivers/scsi/libsas/sas_init.c b/drivers/scsi/libsas/sas_init.c
index 9cd5abe..13c3d21 100644
--- a/drivers/scsi/libsas/sas_init.c
FUJITA Tomonori wrote:
This patch moves blk_queue_max_segment_size to scsi_alloc_queue from
llds. It enables scsi_add_host to tells iommu lld's
dma_max_segment_size. If a low-level driver doesn't specify
dma_max_segment_size, scsi-ml uses 65536 (MAX_SEGMENT_SIZE). So there
are not any functional
FUJITA Tomonori wrote:
On Wed, 26 Sep 2007 06:11:45 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
FUJITA Tomonori wrote:
This patch moves blk_queue_max_segment_size to scsi_alloc_queue from
llds. It enables scsi_add_host to tells iommu lld's
dma_max_segment_size. If a low-level driver doesn't
+
drivers/scsi/mvsas.c| 1064 +++
4 files changed, 2111 insertions(+), 0 deletions(-)
create mode 100644 drivers/scsi/broadsas.c
create mode 100644 drivers/scsi/mvsas.c
Jeff Garzik (3):
Add Broadcom 8603 SAS/SATA driver (rough
Moore, Eric wrote:
On Tuesday, September 25, 2007 11:32 AM, James Bottomley wrote:
Youve rejected the error recovery patchs, which is fair enough.
Just the separation ... the actual patch looks OK.
I'll will continue working to separate the error recovery
improvements: into smaller
Michael Reed wrote:
Jeff Garzik wrote:
Moore, Eric wrote:
On Tuesday, September 25, 2007 11:32 AM, James Bottomley wrote:
Youve rejected the error recovery patchs, which is fair enough.
Just the separation ... the actual patch looks OK.
I'll will continue working to separate the error
FUJITA Tomonori wrote:
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index adc9559..694015d 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -342,6 +342,10 @@ struct Scsi_Host *scsi_host_alloc(struct
scsi_host_template *sht, int privsize)
Matthew Wilcox wrote:
On Tue, Sep 25, 2007 at 10:37:33PM -0400, Jeff Garzik wrote:
Are there any const-ness worries for scsi_host_template, or plans for
the future? I do not see any other examples of the host template
members getting modified.
Goodness, Jeff, you haven't looked too hard
James Bottomley wrote:
This whole mess is generated basically because the zero default of the
template should be treated as initiator. How about this, which makes
that manifest?
James
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index adc9559..7e26440 100644
---
An equivalent-transformation change. No functional changes beyond
those necessary to call the new, split-out functions.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index b20c188..f330d34 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers
An equivalent-transformation change. No functional changes beyond those
necessary to call the new function.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index f330d34..840bdf6 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers/scsi
% redundant in modern kernels.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index 840bdf6..a6b5717 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers/scsi/gdth.c
@@ -27,280 +27,8 @@
* along with this kernel; if not, write to the Free Software
between gdth_ctr_count and
gdth_ctr_vcount. The whole virtual-controller stuff needs reviewing
for edge cases.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index a6b5717..b9d1f69 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers/scsi/gdth.c
Use standard laddered-goto error handling approach in three probe-time
functions.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index d7ef159..89ac155 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers/scsi/gdth.c
@@ -3964,13 +3964,11
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index f382664..3f3ef4b 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers/scsi/gdth.c
@@ -3960,7 +3960,7 @@ static int __init gdth_register_virt(struct
scsi_host_template *shtp,
{
struct
They are direct equivalents to {read,write}[bwl].
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index b9d1f69..d7ef159 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers/scsi/gdth.c
@@ -294,13 +294,6 @@ static struct timer_list gdth_timer
James Bottomley wrote:
On the other hand, I think I can find a nice lever to move Marvell with,
so I'll take this on without needing potentially to compromise your
contacts.
FWIW Marvell is moving quite nicely... they are actively providing docs
under NDA, and sometimes sample code (or even
James Bottomley wrote:
On Sat, 2007-07-21 at 16:34 -0400, Jeff Garzik wrote:
This is the rest of the stuff checked into the 'gdth' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git
As noted before, I'm fine with Christoph's gdth work superceding mine,
or whatever
Douglas Gilbert wrote:
Is the lack of SMP support a driver limitation or is it
the silicon?
How about support for wide ports (i.e. when 2 or more HBA
phys are attached to remote phys which have the same SAS
addresses)?
Last question: can the chip run in SCSI target mode?
Just for
James Bottomley wrote:
On Sun, 2007-09-23 at 19:43 -0400, Jeff Garzik wrote:
James Bottomley wrote:
On Sun, 2007-09-23 at 00:04 -0400, Jeff Garzik wrote:
Rather than sitting on this for far too long, I wanted to go ahead and
get this out there. I heard some chips might be trickling out
/scsi/Kconfig| 10 +
drivers/scsi/Makefile |1 +
drivers/scsi/broadsas.c | 997 +++
3 files changed, 1008 insertions(+), 0 deletions(-)
create mode 100644 drivers/scsi/broadsas.c
Jeff Garzik (1):
Add rough draft Broadcom 8603 SAS/SATA
commit a6d5ac6a3a1cfbed2a045928bbadd5285f1df084
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Fri Sep 21 05:07:19 2007 -0400
[libata] SCSI: support INQUIRY page 89h (ATA info page)
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
drivers/ata/libata-scsi.c | 82
commit 8a7a20fb60d9746ec68a876aade1f14c4f2b7b46
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Fri Sep 21 06:23:42 2007 -0400
[libata] Slightly improved no-op REQUEST SENSE, SEND DIAGNOSTIC
A few pedantic apps care about missing or lame mandatory SCSI
commands, so
Alan Cox wrote:
REQUEST SENSE -- as we autosense, R.S. just returns zeroes
SEND DIAGNOSTIC -- our default (no-op) self-test succeeds, all
other requests for testing fail.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
Acked-by: Alan Cox [EMAIL PROTECTED
As per SAT (sans removable devices)...
commit 09d9637c413406cf63f0e1efb364411ac8a9243c
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Fri Sep 21 07:09:36 2007 -0400
[libata] SCSI: simple TEST UNIT READY simulation
It's trivial to ping the device, and that's a much more sane
commit ee67edb0e7701f8ae9114692837a8bbee9f99a35
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Fri Sep 21 07:26:08 2007 -0400
[libata] SCSI: improve FORMAT UNIT; minor code cleanups
* SAT specifies that FORMAT UNIT should be translated into a series
of READ and WRITE commands
commit 14052d9ba16b826e4bc79db4b2b77e451faf0b01
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Fri Sep 21 07:54:49 2007 -0400
[libata] SCSI: clean up R/W recovery mode page
Clear ARRE, we don't do auto-reallocation on reads, just on writes.
Also, hardcode the size
James Bottomley wrote:
On Fri, 2007-09-21 at 05:48 -0400, Jeff Garzik wrote:
commit a6d5ac6a3a1cfbed2a045928bbadd5285f1df084
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Fri Sep 21 05:07:19 2007 -0400
[libata] SCSI: support INQUIRY page 89h (ATA info page)
Signed-off-by: Jeff
James Bottomley wrote:
On Fri, 2007-09-21 at 05:48 -0400, Jeff Garzik wrote:
commit a6d5ac6a3a1cfbed2a045928bbadd5285f1df084
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Fri Sep 21 05:07:19 2007 -0400
[libata] SCSI: support INQUIRY page 89h (ATA info page)
Signed-off-by: Jeff
Ditched ATAPI, fixed a bug, a few clean-ups and fixmes taken care of.
commit a1c69f03a85fe6fa1b7f2f3726dd7205eb68a328
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Fri Sep 21 20:38:03 2007 -0400
[libata] SCSI: support INQUIRY page 89h (ATA info page)
Signed-off-by: Jeff Garzik
Jeff Garzik wrote:
+ memcpy(pbuf[8], ATA , 8);
+ ata_id_string(args-id, pbuf[16], ATA_ID_PROD, 16);
+ ata_id_string(args-id, pbuf[32], ATA_ID_FW_REV, 4);
And I just checked in a fix that changes the above to reflect the SCSI
simulator's vendor/product/version (linux
Boaz Harrosh wrote:
This is a minimal patch needed to remove use of !use_sg
but it is not a complete clean up of the !use_sg paths.
Libata-core still has the qc-flags ATA_QCFLAG_SG
and !qc-n_elem code paths. Perhaps an ata maintainer
would have a go at it.
- TODO:
Bartlomiej Zolnierkiewicz wrote:
On Monday 17 September 2007, James Bottomley wrote:
Realistically (and I hate myself for saying this) libata-pata does
provide a much better alternative for the ATAPI devices. Is it just
time to recognise the inevitable and kill ide-scsi?
Agreed, libata-pata
James Bottomley wrote:
On Mon, 2007-09-17 at 16:57 -0400, Jeff Garzik wrote:
Bartlomiej Zolnierkiewicz wrote:
On Monday 17 September 2007, James Bottomley wrote:
Realistically (and I hate myself for saying this) libata-pata does
provide a much better alternative for the ATAPI devices
James Bottomley wrote:
On Sat, 2007-09-15 at 12:05 -0500, James Bottomley wrote:
On Fri, 2007-09-14 at 10:58 -0700, Gilbert Wu wrote:
Fixed the problem that smartctl -a /dev/some_sata_disk -d ata does
not work on SATA device. ( The smartctl v5.38 does need -d ata
option.)
The aic94xx need
Stefan Richter wrote:
Adrian Bunk wrote:
On Sat, Sep 15, 2007 at 04:11:45PM +0200, Stefan Richter wrote:
Perfect is in the eye of the beholder. You would consequently have to
add such options into all menus which contain scsi low-level providers.
Kconfig is a user interface, so perfect is
Bartlomiej Zolnierkiewicz wrote:
On Saturday 15 September 2007, Adrian Bunk wrote:
On Sat, Sep 15, 2007 at 11:44:59AM -0400, Jeff Garzik wrote:
Stefan Richter wrote:
Adrian Bunk wrote:
On Sat, Sep 15, 2007 at 04:11:45PM +0200, Stefan Richter wrote:
Perfect is in the eye of the beholder
FUJITA Tomonori wrote:
The majority of llds don't set supported_mode in scsi_host_template so
we get:
luce:/sys/class/scsi_host/host0$ cat supported_mode
unknown
It's harmless but it would be better to get:
luce:/sys/class/scsi_host/host0$ cat supported_mode
Initiator
Given that this is the
Stefan Richter wrote:
Signed-off-by: Stefan Richter [EMAIL PROTECTED]
---
Applicable to 2.6.23-rc6 and to scsi-misc.
drivers/scsi/Kconfig | 32
1 file changed, 20 insertions(+), 12 deletions(-)
ACK
-
To unsubscribe from this list: send the line
Gilbert Wu wrote:
Fixed the problem that smartctl -a /dev/some_sata_disk -d ata does
not work on SATA device. ( The smartctl v5.38 does need -d ata
option.)
The aic94xx need to return ATA output register for all ATA commands
except ATA Read/Write commands.
The aic94xx also mark out the DRQ
Gilbert Wu wrote:
Fixed the problem that smartctl -a /dev/some_sata_disk -d ata does
not work on SATA device. ( The smartctl v5.38 does need -d ata
option.)
The aic94xx need to return ATA output register for all ATA commands
except ATA Read/Write commands.
The aic94xx also mark out the DRQ
I would much rather see the !use_sg cleanup in a separate patch series...
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Matthew Wilcox wrote:
Rearrange a lot of the functions in the file to get rid of all the forward
declarations.
What thoughts, if any, have been given to post-patch code arrangement,
besides eliminating prototypes?
This always struck me as a counterproductive exercise when taken by
itself.
Andi Kleen wrote:
I can see where you're coming from, but logically, this is wrong.
There's a huge slew of enterprise machines that only have DVD on SATA.
... and enterprise systems don't really care about a few KB more of code.
In fact you definitely want to have SATA compiled in in case you
Wu, Gilbert wrote:
HI Jeff,
I was thinking the checking READ/WRITE command table is larger than
my current table. This does not cover vendor-specific command.
You can implement the check in a _far_ more optimal manner:
Possibility 1:
static const u8 ata_rw_command_table[256] = {
On Wed, Sep 05, 2007 at 04:04:29PM -0700, Gilbert Wu wrote:
Add new HBA PCI ID (0x416) for ASC58300 which has eight port SAS and
SATA PCI-X 133MHz low profile host bus adapter with two mini SAS 4x
external connectors.
Signed-off-by: Gilbert Wu [EMAIL PROTECTED]
ACK
-
To unsubscribe from
On Wed, Sep 05, 2007 at 03:25:55PM -0700, Gilbert Wu wrote:
Fixed the problem that smartctl -a /dev/some_sata_disk -d ata does not
work on SATA device.
( The smartctl v5.38 does need -d ata option.)
The root cause is the aic94xx driver does not return ATA output register
due to
Satyam Sharma wrote:
drivers/scsi/dc395x.c: In function ‘dc395x_init_one’:
drivers/scsi/dc395x.c:4272: warning: ‘ptr’ may be used uninitialized in this
function
has been verified to be a bogus warning. Let's shut it up.
Signed-off-by: Satyam Sharma [EMAIL PROTECTED]
---
Satyam Sharma wrote:
drivers/scsi/ips.c: In function ‘ips_register_scsi’:
drivers/scsi/ips.c:6869:
warning: ignoring return value of ‘scsi_add_host’, declared with attribute
warn_unused_result
scsi_add_host() is __must_check, so let's check it's return and cleanup
appropriately on errors.
Satyam Sharma wrote:
I'll post the info as a reply to the first mail in this series. I have
fairly recent gcc (4.1.1) and I don't see us dropping support for it in
the next few years.
What's important is not support lifetime, but whether or not the warning
persists through version 4.1.2,
Matthew Wilcox wrote:
[Note: not tested. I have a temporary shortage of machines with 5 volt
PCI slots, and in any case, I think the DAC960 that I have is a V1 card]
Use PCI_DMA_* constants instead of own private definitions
Fall back to 32-bit DMA mask if a 64-bit one fails
Signed-off-by:
Gilbert Wu wrote:
Subject: [PATCH] scsi: Update Aic94xx SAS/SATA Linux open source device
driver to add new PCI ID for HBA ASC58300.
Contribution:
Gilbert Wu [EMAIL PROTECTED]
Patch: apply to aic94xx-sas-2.6.git development tree
Signed-off-by: Gilbert Wu [EMAIL PROTECTED]
Change Log:
Gilbert Wu wrote:
Subject: [PATCH] scsi: Update Aic94xx SAS/SATA Linux open source device
driver to fix smartctl utility problem.
Contribution:
Gilbert Wu [EMAIL PROTECTED]
Change Log:
1. Fixed the problem that smartctl -a /dev/some_sata_disk -d ata
does not work on aic94xx device
Gilbert Wu wrote:
On Fri, 2007-08-31 at 14:15 -0400, Jeff Garzik wrote:
Gilbert Wu wrote:
Subject: [PATCH] scsi: Update Aic94xx SAS/SATA Linux open source device
driver to add new PCI ID for HBA ASC58300.
Contribution:
Gilbert Wu [EMAIL PROTECTED]
Patch: apply to aic94xx-sas-2.6.git
HighPoint Linux Team wrote:
updated patch based on Jeff Garzik's comments.
- check adapter firmware version and use appropriate interface accordingly
- add new PCI device IDs and use PCI_VDEVICE macro
- update driver version string
- remove unused data structures
- remove unnecessary typecasts
HighPoint Linux Team wrote:
+ if (hba-firmware_version 0x0102 || hba-interface_version
0x0102) {
[...]
+ if (hba-firmware_version 0x0102 ||
+ hba-interface_version 0x0102) {
Rather than repeating this test, you should do it once
Jens Axboe wrote:
#for-akpm is usually only in very few -mm release anyway, so it's not
like it would have made much difference. We/you/I need to improve that,
certainly.
Honestly, for bsg, it wasn't much of an issue. We had build problems
when bsg was merged which was unfortunate but got fixed
FUJITA Tomonori wrote:
On Tue, 7 Aug 2007 00:14:29 -0700
Andrew Morton [EMAIL PROTECTED] wrote:
On Mon, 06 Aug 2007 22:55:41 -0500 James Bottomley [EMAIL PROTECTED] wrote:
The real root cause of all of this is that there's no tree I can
persuade all the interested parties to test that
Alan Cox wrote:
I fully agree, and firmly believe that the current stabilisation works
incredibly well for shaking out bugs. My problem is that it doesn't
work for stabilising features. Either we have to get far more people
doing feature integration testing before the merge window, or we have
James Bottomley wrote:
OK ... that's arguable. This one is larger than I like because of the
lpfc bug fix patch ... I accept I need to do a better job getting these
into the merge window via the scsi-misc tree. So I will accept the too
big criticism and try to manage the driver maintainers
James Smart wrote:
However, I take issue with looking at line counts as the sole basis
for what's appropriate or not. It can be argued that some bug fixes may be
larger in scope than others, or patch batching so that the bug fix count is
higher will skew this perception. I also believe that more
James Bottomley wrote:
I'm arguing that a too strict an interpretation of bugfix only post -rc1
will damage feature stabilisation. Please think carefully about this.
If we go out in a released kernel with a problematic user space ABI, we
end up being committed to it forever.
IMO you're going
James Smart wrote:
Jeff Garzik wrote:
The lpfc update was probably the biggest thing, LOC-wise. And even
though that was mostly bug fixes -- and notably NOT 100% fixes -- it
is big enough to warrant integration testing and exposure prior to
mainline. Definitely merge-window-open material
201 - 300 of 499 matches
Mail list logo
