[PATCH] scsi: aacraid: Fix PD performance regression over incorrect qd being set

trying to set queue depth. Reported-by: Steve Best Fixes: 0bcb45fb20c2a ("scsi: aacraid: Add helper function to set queue depth") cc: sta...@vger.kernel.org Signed-off-by: Raghava Aditya Renukunta Reviewed-by: David Carroll --- drivers/scsi/aacraid/aachba.c | 15 +++ 1 fi

RE: [PATCH] aacraid: Insure command thread is not recursively stopped

] 384216a0 7c0802a6 fbe1fff8 f8010010 f821ffd1 7c7f1b78 > 6000 6000 > [ 336.657056] 3940 e87f0838 f95f0838 7c0004ac <7d401828> 314affff > 7d40192d 40c2fff4 > [ 336.663997] -[ end trace 4640cf8d4945ad95 ]- > > So flag when the thread is stopped by setting the thread pointer to NULL. > > Signed-off-by: Dave Carroll <david.carr...@microsemi.com> Reviewed-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com>

[PATCH v2 3/3] scsi: aacraid: Auto detect INTx or MSIx mode during sync cmd processing

During sync command processing if legacy INTx status indicates command is not completed, sample the MSIx register and check if it indicates command completion, set controller MSIx enabled flag. Signed-off-by: Prasad B Munirathnam <prasad.munirath...@microsemi.com> Signed-off-by: Raghava

[PATCH v2 1/3] scsi: aacraid: Implement DropIO sync command

the IOP_RESET. Signed-off-by: Prasad B Munirathnam <prasad.munirath...@microsemi.com> Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: Dave Carroll <david.carr...@microsemi.com> --- Changes in V2: Re based on Linus Master drivers/scsi

[PATCH v2 2/3] scsi: aacraid: Preserve MSIX mode in the OMR register

Preserve the current MSIX mode value in the OMR before rewriting the OMR to initiate the IOP or Soft Reset. Signed-off-by: Prasad B Munirathnam <prasad.munirath...@microsemi.com> Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: Dave Carroll

[PATCH v2 0/3] scsi: aacraid: Multi controller Kdump IOP reset handling

, that induces the fw to drop any pending IO in the fw and making the reset process quicker. Changes in v2: Respun patchset against Linus Master Added Dave Carroll's reviewed-by tags Raghava Aditya Renukunta (3): scsi: aacraid: Implement DropIO sync command scsi: aacraid: Preserve MSIX mode in the OMR

RE: [PATCH 0/3] scsi: aacraid: Multi controller Kdump IOP reset handling

> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Martin K. Petersen > Sent: Tuesday, February 6, 2018 4:21 PM > To: Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com> >

[PATCH 0/3] scsi: aacraid: Multi controller Kdump IOP reset handling

, that induces the fw to drop any pending IO in the fw and making the reset process quicker. Raghava Aditya Renukunta (3): scsi: aacraid: Implement DropIO sync command scsi: aacraid: Preserve MSIX mode in the OMR register scsi: aacraid: Auto detect INTx or MSIx mode during sync cmd processing

[PATCH 1/3] scsi: aacraid: Implement DropIO sync command

the IOP_RESET. Signed-off-by: Prasad B Munirathnam <prasad.munirath...@microsemi.com> Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/aacraid.h | 4 + drivers/scsi/aacraid/src.c | 167 ++

[PATCH 3/3] scsi: aacraid: Auto detect INTx or MSIx mode during sync cmd processing

During sync command processing if legacy INTx status indicates command is not completed, sample the MSIx register and check if it indicates command completion, set controller MSIx enabled flag. Signed-off-by: Prasad B Munirathnam <prasad.munirath...@microsemi.com> Signed-off-by: Raghava

[PATCH 2/3] scsi: aacraid: Preserve MSIX mode in the OMR register

Preserve the current MSIX mode value in the OMR before rewriting the OMR to initiate the IOP or Soft Reset. Signed-off-by: Prasad B Munirathnam <prasad.munirath...@microsemi.com> Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacrai

[PATCH 2/2] scsi: aacraid: Delay for rescan worker needs to be 10 seconds

The delay for the rescan worker needs to 10 seconds, missed the HZ in there. Fixes: a1367e4adee207fe (scsi: aacraid: Reschedule host scan in case of failure) Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/aacraid.h | 2 +- 1 file c

[PATCH 1/2] scsi: aacraid: Get correct lun count

The correct lun count needs to be divided by 24, missed it in the previous patch set. Fixes: 4b00022753550055 (scsi: aacraid: Create helper functions to get lun info) Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/aachba.c | 2 +-

RE: [PATCH][scsi-next] scsi: aacraid: remove redundant setting of variable c

d/aachba.c:943:3: warning: Value stored to 'c' is > never read > > Fixes: f4e8708d3104 ("scsi: aacraid: Fix udev inquiry race condition") > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > --- Reviewed-by :Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com>

RE: [PATCH] aacraid driver oops with dead battery

> load_module+0x2764/0x34a0 > ? kernel_read_file+0x150/0x320 > SyS_finit_module+0x82/0xa0 > do_fast_syscall_32+0xba/0x340 > > Signed-off-by: Meelis Roos <mr...@linux.ee> . Reviewed-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com>

RE: [PATCH v2 22/30] scsi: aacraid: Merge adapter setup with resolve luns

Hi Nikola, > -Original Message- > From: Nikola Pajkovsky [mailto:npajkov...@suse.cz] > Sent: Wednesday, January 3, 2018 2:02 AM > To: Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com> > Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux

[PATCH v2 07/30] scsi: aacraid: Refactor reset_host store function

Refactored the reset_host store function to make consistent across code bases Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/linit.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff

[PATCH v2 05/30] scsi: aacraid: Fix ioctl reset hang

Driver would hang when attempting to send reset from the ioctl interface, since it would wait to retrieve the ioctl mutex at send shutdown. Set adapter shutdown and unlock mutex before sending down reset request. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.

[PATCH v2 21/30] scsi: aacraid: Refactor resolve luns code and scsi functions

or not. Add helper functions to add, remove and put devices based on their fw bus and target number. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: Removed unnecessary check and assignment for bus number drivers/scsi/aacraid/commsup.

[PATCH v2 28/30] scsi: aacraid: Remove unused rescan variable

Remove unused rescan variable. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/aachba.c | 19 +-- drivers/scsi/aacraid/aacraid.h | 6 +++--- drivers/scsi/aacraid/commsup.

[PATCH v2 30/30] scsi: aacraid: Update driver version to 50877

Update driver Version to 50877 Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/aacraid.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h index 4

[PATCH v2 24/30] scsi: aacraid: Use hotplug handling function in place of scsi_scan_host

for safw. For ARC scsi_scan_host will still apply. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/aachba.c | 4 drivers/scsi/aacraid/aacraid.h | 1 + drivers/scsi/aacraid/commsup.c | 18 +++--- d

[PATCH v2 15/30] scsi: aacraid: Create helper functions to get lun info

Created inline function to retrieve lun info for each device from the phy luns structure. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: Use get_unaligned_be32 instead of open ended conversion drivers/scsi/aacraid/aachba.

[PATCH v2 26/30] scsi: aacraid: Fix hang while scanning in eh recovery

Add back the ability to scan for hotplug changes while eh was in progress. Schedule a rescan for a later time in the eh recovery code and wait for eh to complete in the rescan worker. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2

[PATCH v2 19/30] scsi: aacraid: Process hba and container hot plug events in single function

. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/aachba.c | 9 --- drivers/scsi/aacraid/aacraid.h | 3 ++- drivers/scsi/aacraid/commsup.c | 59 -- 3 files chang

[PATCH v2 27/30] scsi: aacraid: Skip schedule rescan in case of kdump

the devices are going to go away anyway. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/commsup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/a

[PATCH v2 18/30] scsi: aacraid: Merge func to get container information

Merge aac_get_containers to setup target function, so that information about all the present devices can be retrieved in one shot. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/aachba.c | 4 driver

[PATCH v2 11/30] scsi: aacraid: Refactor and rename to make mirror existing changes

Rename variables and functions to make bmic identify, report phy luns to make them consistent across code internal existing code bases Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/aachba.c

[PATCH v2 03/30] scsi: aacraid: Fix hang in kdump

org> Reported-by: Douglas Miller <dougm...@linux.vnet.ibm.com> Tested-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> Fixes: a2d0321dd532901e (scsi: aacraid: Reload offlined drives after controller reset) Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.co

[PATCH v2 22/30] scsi: aacraid: Merge adapter setup with resolve luns

The device hotplug events are processed only after retrieving the updated lun information from the fw. Does not make sense to keep them separate. Merge both the hotplug handling and safw adapter setup code into single function. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.ren

[PATCH v2 23/30] scsi: aacraid: Block concurrent hotplug event handling

Currently driver will attempt to process hotplug events concurrently based on the FW interrupt. Protect safw update function with a scan mutex. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/aacraid.h | 1 + d

[PATCH v2 06/30] scsi: aacraid: Allow reset_host sysfs var to recover Panicked Fw

Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/comminit.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/aacraid/comminit.c b/drivers/scsi/aacraid/comminit.c index 1

[PATCH v2 20/30] scsi: aacraid: Added macros to help loop through known buses and targets

Added macros to loop through the MAX SUPPORTED Buses and Targets. This will make the code a bit easier to read. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/aacraid.h | 4 drivers/scsi/aacraid/commsup.

[PATCH v2 01/30] scsi: aacraid: Fix udev inquiry race condition

cation) Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: Replaced kmalloc and memcpy adapter_type_text with kmemdup drivers/scsi/aacraid/aachba.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/

[PATCH v2 17/30] scsi: aacraid: Add helper function to set queue depth

Add helper function to set queue depth from information retrieved from the bmic phy structure. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/aachba.c | 37 - 1 file chang

[PATCH v2 16/30] scsi: aacraid: Save bmic phy information for each phy

Save the bmic information for each phy, so that it can processed in target setup function. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: Removed unused phy_luns variable drivers/scsi/aacraid/aachba.c

[PATCH v2 29/30] scsi: aacraid: Remove AAC_HIDE_DISK check in queue command

to be exposed, this code can be removed. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/aachba.c | 10 -- drivers/scsi/aacraid/aacraid.h | 3 --- 2 files changed, 13 deletions(-) diff --git a/driver

[PATCH v2 25/30] scsi: aacraid: Reschedule host scan in case of failure

will happen on SAFW devices. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: Rename rescan worker to match kernel coding conventions drivers/scsi/aacraid/aacraid.h | 27 ++- drivers/scsi/aacraid/commsup.

[PATCH 00/30] aacraid: Refactor for sas transport and bug fixes

that one) Raghava Aditya Renukunta (30): scsi: aacraid: Fix udev inquiry race condition scsi: aacraid: Do not attempt abort when Fw panicked scsi: aacraid: Fix hang in kdump scsi: aacraid: Do not remove offlined devices scsi: aacraid: Fix ioctl reset hang scsi: aacraid: Allow

[PATCH v2 04/30] scsi: aacraid: Do not remove offlined devices

As part of the recovery process, the drivers removes offline devices ( done by the kernel) and then tries to add them back in the rescan code. Removing the device is like taking a sledgehammer to a nail. Set the device as running if it is marked offline. Signed-off-by: Raghava Aditya Renukunta

[PATCH v2 09/30] scsi: aacraid: Create bmic submission function from bmic identify

safw command submission is duplicated across many functions. Move the safw submission code from bmic identify into its own function for common use Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/aachba.c

[PATCH v2 13/30] scsi: aacraid: Untangle targets setup from report phy luns

Remove function call to process targets from the report phy luns function and make it a function in its own right. This will help understand the flow of the code. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: None drivers/scsi/a

[PATCH v2 08/30] scsi: aacraid: Move code to wait for IO completion to shutdown func

Ideally driver needs to wait for IO to be submitted or responded to before shutdown. Move code to wait for IO completion into shutdown path Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/comminit.

[PATCH v2 14/30] scsi: aacraid: Move function around to match existing code

Move the function to get phy luns information to the top of function to set target information Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/aachba.c | 112 +- 1 file c

[PATCH v2 12/30] scsi: aacraid: Add target setup helper function

Add helper function to setup targets devices and create the base for the upcoming patches Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/aachba.c | 18 +- drivers/scsi/aacraid/aacraid.

[PATCH v2 02/30] scsi: aacraid: Do not attempt abort when Fw panicked

Check if the adapter can receive abort requests, before sending aborts Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: None drivers/scsi/aacraid/linit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/aacraid/lin

[PATCH v2 10/30] scsi: aacraid: Change phy luns function to use common bmic function

Edit function that retrieves phy lun information to use common bmic function Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- Changes in V2: Added missing colon to match kernel coding style drivers/scsi/aacraid/aachba.c

RE: [PATCH 08/29] scsi: aacraid: Move code to wait for IO completion to shutdown func

> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@wdc.com] > Sent: Friday, December 22, 2017 8:27 AM > To: j...@linux.vnet.ibm.com; Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com>; linux-scsi@vger.kernel.org; > martin.peter...

RE: [PATCH 03/29] scsi: aacraid: Fix hang in kdump

> -Original Message- > From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com] > Sent: Friday, December 22, 2017 7:14 AM > To: Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com>; j...@linux.vnet.ibm.com; > martin.peter...@oracle.com; li

RE: [PATCH 00/28] aacraid: Refactor for sas transport and bug fixes

> -Original Message- > From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com] > Sent: Friday, December 22, 2017 7:07 AM > To: Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com>; linux-scsi@vger.kernel.org > Cc: j...@linux.vnet.ibm.com; ma

RE: [PATCH 25/29] scsi: aacraid: Reschedule host scan in case of failure

> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@wdc.com] > Sent: Thursday, December 21, 2017 10:45 AM > To: j...@linux.vnet.ibm.com; Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com>; linux-scsi@vger.kernel.org; > martin.pete

RE: [PATCH 21/29] scsi: aacraid: Refactor resolve luns code and scsi functions

> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@wdc.com] > Sent: Thursday, December 21, 2017 10:43 AM > To: j...@linux.vnet.ibm.com; Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com>; linux-scsi@vger.kernel.org; > martin.pete

RE: [PATCH 14/29] scsi: aacraid: Move function around to match existing code

> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@wdc.com] > Sent: Thursday, December 21, 2017 10:40 AM > To: j...@linux.vnet.ibm.com; Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com>; linux-scsi@vger.kernel.org; > martin.pete

RE: [PATCH 15/29] scsi: aacraid: Create helper functions to get lun info

> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@wdc.com] > Sent: Thursday, December 21, 2017 10:41 AM > To: j...@linux.vnet.ibm.com; Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com>; linux-scsi@vger.kernel.org; > martin.pete

RE: [PATCH 01/29] scsi: aacraid: Fix udev inquiry race condition

> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@wdc.com] > Sent: Thursday, December 21, 2017 9:54 AM > To: j...@linux.vnet.ibm.com; Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com>; linux-scsi@vger.kernel.org; > martin.pete

[PATCH 25/29] scsi: aacraid: Reschedule host scan in case of failure

will happen on SAFW devices. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/aacraid.h | 27 ++- drivers/scsi/aacraid/commsup.c | 14 +- drivers/scsi/aacraid/linit.c | 5 + 3 files changed, 44 inse

[PATCH 29/29] scsi: aacraid: Remove AAC_HIDE_DISK check in queue command

to be exposed, this code can be removed. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/aachba.c | 10 -- drivers/scsi/aacraid/aacraid.h | 3 --- 2 files changed, 13 deletions(-) diff --git a/drivers/scsi/aacraid/aach

[PATCH 23/29] scsi: aacraid: Block concurrent hotplug event handling

Currently driver will attempt to process hotplug events concurrently based on the FW interrupt. Protect safw update function with a scan mutex. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/aacraid.h | 1 + drivers/scsi/a

[PATCH 28/29] scsi: aacraid: Remove unused rescan variable

Remove unused rescan variable. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/aachba.c | 19 +-- drivers/scsi/aacraid/aacraid.h | 6 +++--- drivers/scsi/aacraid/commsup.c | 14 +++--- drivers/scsi/aacraid/l

[PATCH 27/29] scsi: aacraid: Skip schedule rescan in case of kdump

the devices are going to go away anyway. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/commsup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c

[PATCH 24/29] scsi: aacraid: Use hotplug handling function in place of scsi_scan_host

for safw. For ARC scsi_scan_host will still apply. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/aachba.c | 4 drivers/scsi/aacraid/aacraid.h | 1 + drivers/scsi/aacraid/commsup.c | 18 +++--- drivers/scsi/aacraid/l

[PATCH 26/29] scsi: aacraid: Fix hang while scanning in eh recovery

Add back the ability to scan for hotplug changes while eh was in progress. Schedule a rescan for a later time in the eh recovery code and wait for eh to complete in the rescan worker. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/a

[PATCH 20/29] scsi: aacraid: Added macros to help loop through known buses and targets

Added macros to loop through the MAX SUPPORTED Buses and Targets. This will make the code a bit easier to read. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/aacraid.h | 4 drivers/scsi/aacraid/commsup.

[PATCH 22/29] scsi: aacraid: Merge adapter setup with resolve luns

The device hotplug events are processed only after retrieving the updated lun information from the fw. Does not make sense to keep them separate. Merge both the hotplug handling and safw adapter setup code into single function. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.ren

[PATCH 21/29] scsi: aacraid: Refactor resolve luns code and scsi functions

or not. Add helper functions to add, remove and put devices based on their fw bus and target number. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/commsup.c | 75 -- 1 file changed, 58 inse

[PATCH 18/29] scsi: aacraid: Merge func to get container information

Merge aac_get_containers to setup target function, so that information about all the present devices can be retrieved in one shot. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/aachba.c | 4 drivers/scsi/aacraid/commsup.

[PATCH 12/29] scsi: aacraid: Add target setup helper function

Add helper function to setup targets devices and create the base for the upcoming patches Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/aachba.c | 18 +- drivers/scsi/aacraid/aacraid.h | 2 +- drivers/scsi/a

[PATCH 15/29] scsi: aacraid: Create helper functions to get lun info

Created inline function to retrieve lun info for each device from the phy luns structure. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/aachba.c | 59 ++- 1 file changed, 47 insertions(

[PATCH 17/29] scsi: aacraid: Add helper function to set queue depth

Add helper function to set queue depth from information retrieved from the bmic phy structure. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/aachba.c | 37 - 1 file changed, 24 insertions(

[PATCH 19/29] scsi: aacraid: Process hba and container hot plug events in single function

. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/aachba.c | 9 --- drivers/scsi/aacraid/aacraid.h | 3 ++- drivers/scsi/aacraid/commsup.c | 59 -- 3 files changed, 30 insertions(+), 41 del

[PATCH 02/29] scsi: aacraid: Do not attempt abort when Fw panicked

Check if the adapter can receive abort requests, before sending aborts Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/linit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/a

[PATCH 16/29] scsi: aacraid: Save bmic phy information for each phy

Save the bmic information for each phy, so that it can processed in target setup function. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/aachba.c | 87 +++--- drivers/scsi/aacraid/aacraid.h |

[PATCH 10/29] scsi: aacraid: Change phy luns function to use common bmic function

Edit function that retrieves phy lun information to use common bmic function Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/aachba.c | 75 +- drivers/scsi/aacraid/aacraid.h | 2 +- driver

[PATCH 13/29] scsi: aacraid: Untangle targets setup from report phy luns

Remove function call to process targets from the report phy luns function and make it a function in its own right. This will help understand the flow of the code. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/aachba.c

[PATCH 08/29] scsi: aacraid: Move code to wait for IO completion to shutdown func

Ideally driver needs to wait for IO to be submitted or responded to before shutdown. Move code to wait for IO completion into shutdown path Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/comminit.

[PATCH 14/29] scsi: aacraid: Move function around to match existing code

Move the function to get phy luns information to the top of function to set target information Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/aachba.c | 112 +- 1 file changed, 56 insertions(

[PATCH 11/29] scsi: aacraid: Refactor and rename to make mirror existing changes

Rename variables and functions to make bmic identify, report phy luns to make them consistent across code internal existing code bases Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/aachba.c

[PATCH 09/29] scsi: aacraid: Create bmic submission function from bmic identify

safw command submission is duplicated across many functions. Move the safw submission code from bmic identify into its own function for common use Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/aachba.c

[PATCH 07/29] scsi: aacraid: Refactor reset_host store function

Refactored the reset_host store function to make consistent across code bases. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/linit.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/a

[PATCH 03/29] scsi: aacraid: Fix hang in kdump

org> Reported-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> Tested-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> Fixes: a2d0321dd532901e (scsi: aacraid: Reload offlined drives after controller reset) Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@micros

[PATCH 06/29] scsi: aacraid: Allow reset_host sysfs var to recover Panicked Fw

Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/comminit.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/aacraid/comminit.c b/drivers/scsi/aacraid/comminit.c index 1bc623a..9eff246

[PATCH 05/29] scsi: aacraid: Fix ioctl reset hang

Driver would hang when attempting to send reset from the ioctl interface, since it would wait to retrieve the ioctl mutex at send shutdown. Set adapter shutdown and unlock mutex before sending down reset request. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.

[PATCH 04/29] scsi: aacraid: Do not remove offlined devices

As part of the recovery process, the drivers removes offline devices ( done by the kernel) and then tries to add them back in the rescan code. Removing the device is like taking a sledgehammer to a nail. Set the device as running if it is marked offline. Signed-off-by: Raghava Aditya Renukunta

[PATCH 01/29] scsi: aacraid: Fix udev inquiry race condition

cation) Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/aachba.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c index af3e4d3..f2

[PATCH 00/28] aacraid: Refactor for sas transport and bug fixes

and now explicitly add devices retrieved from the fw. - Reschedule scan in driver fails to retrieve lun information from fw. (usually works in a few attempts) - Rescan worker waits for any pending EH recovery before rescanning - Do not trigger rescan worker in kdump kernel Raghava Aditya

RE: Driver version for PMC Adaptec HBA in Linux and from vendor

Hi Paul, > -Original Message- > From: Paul Menzel [mailto:pmen...@molgen.mpg.de] > Sent: Tuesday, December 19, 2017 3:12 PM > To: Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com>; dl-esc-Aacraid Linux Driver > <aacr...@microsemi.com> &g

RE: Driver version for PMC Adaptec HBA in Linux and from vendor

Hi Paul, > -Original Message- > From: Paul Menzel [mailto:pmen...@molgen.mpg.de] > Sent: Saturday, December 16, 2017 1:39 AM > To: Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com>; dl-esc-Aacraid Linux Driver > <aacr...@microsemi.com> &g

RE: [PATCH] scsi: aacraid: fix io drop during the reset

> -Original Message- > From: Prasad B Munirathnam [mailto:prasad.munirath...@microsemi.com] > Sent: Tuesday, December 12, 2017 11:40 AM > To: Prasad Munirathnam <prasad.munirath...@microsemi.com>; Dave > Carroll <david.carr...@microsemi.com>

RE: [PATCH 2/3] scsi: aacraid: Perform initialization reset only once

ve Carroll > <david.carr...@microsemi.com>; Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com>; gpicc...@protonmail.ch > Subject: [PATCH 2/3] scsi: aacraid: Perform initialization reset only once > > EXTERNAL EMAIL > > > Currently the driver accepts two

RE: [PATCH 3/3] scsi: aacraid: Prevent crash in case of free interrupt during scsi EH path

ve Carroll > <david.carr...@microsemi.com>; Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com>; gpicc...@protonmail.ch > Subject: [PATCH 3/3] scsi: aacraid: Prevent crash in case of free interrupt > during scsi EH path > > EXTERNAL EMAIL > > > A

[PATCH] aacraid: Fix controller initialization failure

Fixes: fbd185986eba (aacraid: Fix AIF triggered IOP_RESET) Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> Reviewed-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/comminit.c |8 +--- drivers/scsi/aacraid/linit.c|

RE: [PATCH RESEND] aacraid: Fix 2T+ drives on SmartIOC-2000

inline int aac_supports_2T(struct aac_dev *dev) > +{ > + return (dev->adapter_info.options & AAC_OPT_NEW_COMM_64); > +} > + > char * get_container_type(unsigned type); > extern int numacb; > extern char aac_driver_version[]; > -- > 2.8.4 Reviewed-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com>

RE: [PATCH] aacraid: Fix 2T+ drives on SmartIOC-2000

raid/aacraid.h b/drivers/scsi/aacraid/aacraid.h > index 6981299..998fbad 100644 > --- a/drivers/scsi/aacraid/aacraid.h > +++ b/drivers/scsi/aacraid/aacraid.h > @@ -2701,6 +2701,11 @@ static inline int aac_is_src(struct aac_dev *dev) > return 0; > } > > +static inline int aac_sup

RE: [PATCH 2/3] scsi: aacraid: get rid of one level of indentation

... > return byte_count; > > No other code has changed. > > Signed-off-by: Nikola Pajkovsky <npajkov...@suse.cz> > --- [.] Reviewed-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com>

RE: [PATCH 3/3] scsi: aacraid: report -ENOMEM to upper layer from aac_convert_sgraw2()

w2() kmalloc memory and return -1 on error, which > should be -ENOMEM. However, nobody is checking return value, so with > this change, -ENOMEM is propagated to upper layer. > > Signed-off-by: Nikola Pajkovsky <npajkov...@suse.cz> > --- [.] Reviewed-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com>

RE: [PATCH 1/3] scsi: aacraid: fix indentation errors

nce here. > > Signed-off-by: Nikola Pajkovsky <npajkov...@suse.cz> > --- [.] Reviewed-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com>

[PATCH] aacraid: Fix out of bounds in aac_get_name_resp

esting the FIELD_SIZEOF macro. Fixes: b836439faf04 ("aacraid: 4KB sector support") Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: David Carroll <david.carr...@microsemi.com> Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com>

[PATCH] scsi: Add helper functions to set target ID

and any other changes if required. Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- 0 files changed diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c index 5006a656e16a..a6ef5520cb66 100644 --- a/drivers/scsi/scsi_transport

RE: [PATCH 4/7] aacraid: use aac_tmf_callback for reset fib

.com>; linux-scsi@vger.kernel.org; > Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com>; > Hannes Reinecke <h...@suse.de>; Hannes Reinecke <h...@suse.com> > Subject: [PATCH 4/7] aacraid: use aac_tmf_callback for reset fib > > EXTERNAL EMAIL &

RE: [PATCH 07/47] aacraid: complete all commands during bus reset

bus = aac_logical_to_phys(scmd_channel(cmd)); > + if (bus != cmd_bus) > + continue; > + cid = scmd_id(cmd); > + info = >hba_map[bus][cid]; > + if (bus >=

  1   2   3   4   >