[PATCH] aacraid: correct PERC2/QC and family match quirk list

2007-06-19 Thread Salyzyn, Mark
The Dell PERC2/QC erroneously was listed as having the 31 bit limit quirk on the interface allocations, removing the reference to repair this oversight. Also, the 2 quad pci address (family) match catch-all also retained the 31 bit limit and the 34 SG limit quirks in a paranoid move. Now, many year

[PATCH] aacraid: add sysfs support for driver_version

2007-06-19 Thread Salyzyn, Mark
Adding sysfs support for driver_version. This attached patch is against current scsi-misc-2.6 ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patch attachments. Signed-off-by: Mark Salyzyn <[EMAIL PROTECTED]> drivers/scsi/aacraid/linit.c | 14 ++

RE: [PATCH] aacraid: change srb status busy return

2007-06-19 Thread Salyzyn, Mark
James Bottomley <mailto:[EMAIL PROTECTED]> sez: >On Tue, 2007-06-19 at 11:41 -0400, Salyzyn, Mark wrote: >>It was discovered that if we had a busy status return >>from the Adapter for the SCSI srb command to a physical >>component, that we returned DID_NO_CONNECT r

[PATCH] aacraid: add support for long serial number information

2007-06-19 Thread Salyzyn, Mark
Support displaying long serial number information. Reuse sysfs handler internally as helper. This attached patch is against current scsi-misc-2.6 ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patch attachments. Signed-off-by: Mark Salyzyn <[EMAIL PROTECTED]>

[PATCH] aacraid: change srb status busy return

2007-06-19 Thread Salyzyn, Mark
This patch is more like a spelling correction than a fix. It was discovered that if we had a busy status return from the Adapter for the SCSI srb command to a physical component, that we returned DID_NO_CONNECT rather than what one would expect DID_BUS_BUSY. This attached patch is against current

RE: [PATCH] i2o: convert to use the data buffer accessors

2007-06-13 Thread Salyzyn, Mark
Since Markus removed himself from the maintenance of this driver ... I will offer my ACK if he is truly absent since this driver is apparently primarily in support of the legacy Babylon class of I2O adapters from DPT and Adaptec. Sincerely -- Mark Salyzyn > -Original Message- > From: [EMA

RE: [PATCH] ips: convert to use the data buffer accessors

2007-06-13 Thread Salyzyn, Mark
ACK Sincerely -- Mark Salyzyn > -Original Message- > From: FUJITA Tomonori [mailto:[EMAIL PROTECTED] > Sent: Wednesday, June 13, 2007 10:27 AM > To: [EMAIL PROTECTED] > Cc: linux-scsi@vger.kernel.org; Salyzyn, Mark > Subject: [PATCH] ips: convert to use the data buf

[PATCH] aacraid: add user initiated reset

2007-06-12 Thread Salyzyn, Mark
Add the ability for an application to issue a hardware reset to the adapter via sysfs. Typical uses include restarting the adapter after it has been flashed. Bumped revision number for the driver and added a feature to periodically check the adapter's health (check_interval), update the adapter's c

[PATCH] aacraid: probe related code cleanup

2007-06-11 Thread Salyzyn, Mark
Sundry cleanups: 1) Use kzalloc instead of kmalloc. 2) Make sure probe worked before recalling the SCSI command to finalize processing. 3) _aac_probe_container2 and _aac_probe_container1 return value goes unused, change return to void. 4) Use a lower depth pointer reference to pick up the driver in

[PATCH] aacraid: add SCSI SYNCHONIZE_CACHE range checking.

2007-06-07 Thread Salyzyn, Mark
Customer running an application that issues SYNCHRONIZE_CACHE calls directly noticed the broad stroke of the current implementation in the aacraid driver resulting in multiple applications feeding I/O to the storage causing the issuing application to stall for long periods of time. By only waiting

RE: [2/3] 2.6.22-rc3: known regressions v2

2007-06-01 Thread Salyzyn, Mark
c'd fffd (kexec) > > > References : http://lkml.org/lkml/2007/5/29/491 > > > Submitter : Yinghai Lu <[EMAIL PROTECTED]> > > > Handled-By : Salyzyn, Mark <[EMAIL PROTECTED]> > > > Vivek Goyal <[EMAIL PROTECTED]> > > > Status

RE: [PATCH] aacraid: fix shutdown handler to also disable interrupts.

2007-06-01 Thread Salyzyn, Mark
Yes, this patch makes sure that the Adapter is shut down correctly, and thus when the kexec driver loads, it does not automatically reset the adapter during initialization. This regression was a result of adding code to the driver to detect if the adapter needed a reset as a result of an unclean sh

RE: kexec and aacraid broken

2007-05-31 Thread Salyzyn, Mark
nghai Lu [mailto:[EMAIL PROTECTED] sez: > SUN coguar with 11731 > > On 5/31/07, Salyzyn, Mark <[EMAIL PROTECTED]> wrote: > > > No, still get adapter kernel panic > > > > Which adapter are you using? - To unsubscribe from this list: send the line "unsubscri

RE: [PATCH 15/19] aacraid: convert to use the data buffer accessors

2007-05-31 Thread Salyzyn, Mark
ACK Inspected and compile tested Sincerely -- Mark Salyzyn > -Original Message- > From: FUJITA Tomonori [mailto:[EMAIL PROTECTED] > Sent: Saturday, May 12, 2007 6:06 AM > To: Salyzyn, Mark > Cc: linux-scsi@vger.kernel.org; [EMAIL PROTECTED] > Subject: [PATCH 15/19] a

RE: [PATCH 14/19] aacraid: remove the non-use-sg case

2007-05-31 Thread Salyzyn, Mark
ACK, inspected and compile tested. Sincerely -- Mark Salyzyn > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of FUJITA Tomonori > Sent: Saturday, May 12, 2007 6:06 AM > To: Salyzyn, Mark > Cc: linux-scsi@vger.kernel.org; [EMAIL PR

RE: kexec and aacraid broken

2007-05-31 Thread Salyzyn, Mark
> No, still get adapter kernel panic Which adapter are you using? Sincerely -- Mark Salyzyn - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: kexec and aacraid broken

2007-05-30 Thread Salyzyn, Mark
Yinghai Lu [mailto:[EMAIL PROTECTED] writes: > aacraid_commit_reset.patch is in the mainline already. But aacraid_commit_reset.patch is not in 2.6.22-rc3 (to which you report the issue). Does the aacraid_commit_reset.patch work to resolve this issue all by itself in the kexec'd kernel? Or alternat

[PATCH] aacraid: fix shutdown handler to also disable interrupts.

2007-05-30 Thread Salyzyn, Mark
PROTECTED]> Sincerely -- Mark Salyzyn > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Salyzyn, Mark > Sent: Wednesday, May 30, 2007 10:31 AM > To: [EMAIL PROTECTED] > Cc: Andrew Morton; Yinghai Lu; Eric W. Biederman; Linux >

RE: kexec and aacraid broken

2007-05-30 Thread Salyzyn, Mark
Vivek Goyal [mailto:[EMAIL PROTECTED] writes: > So most likely if we start disabling the interrupts > in .shutdown routine we might skip resetting adapter > on every kexec without any side affects? Not that simple. The .shutdown would need to perform more resource cleanups of the .remove call to p

[PATCH] aacraid: Changeable queue depth

2007-05-30 Thread Salyzyn, Mark
Inspired by Brian King's patch to the ibmvscsi driver. Adds support for a changeable queue depth to the aacraid driver. This attached patch is against current scsi-misc-2.6 ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patch attachments. Signed-off-by: Mark S

RE: kexec and aacraid broken

2007-05-30 Thread Salyzyn, Mark
oyal [mailto:[EMAIL PROTECTED] > Sent: Wednesday, May 30, 2007 9:25 AM > To: Salyzyn, Mark > Cc: Andrew Morton; Yinghai Lu; Eric W. Biederman; Linux > Kernel Mailing List; linux-scsi@vger.kernel.org; Michal Piotrowski > Subject: Re: kexec and aacraid broken > > > On Wed

RE: kexec and aacraid broken

2007-05-30 Thread Salyzyn, Mark
us=0 > > One of the two diffs below, I guess. Please do a `patch -R > -p1' of this > email and retest? > > > > > but can load 2.6.21.3 > > > > Michal, can you please add this to the regression list? > > > > > commit 9e4d4a5d7

Re: [PATCH 4/5] SCSI: add cpu cache flushes after kmapping and modifying a page

2007-05-29 Thread Salyzyn, Mark
What ever became of the following patch? I have enclosed the incremental aacraid version of this patch to permit closure if the following was rejected because of another portion. This attached aacraid specific portion of the patch is against current scsi-misc-2.6. ObligatoryDisclaimer: Please acc

RE: [patch 14/25] SCSI: use irq_handler_t where appropriate

2007-05-24 Thread Salyzyn, Mark
Sincerely -- Mark Salyzyn > -Original Message- > From: James Bottomley [mailto:[EMAIL PROTECTED] > Sent: Thursday, May 24, 2007 10:04 AM > To: Jeff Garzik > Cc: [EMAIL PROTECTED]; linux-scsi@vger.kernel.org; > Salyzyn, Mark; Andrew Vasquez > Subject: Re: [patch 14/25] SCSI: use

RE: [patch 14/25] SCSI: use irq_handler_t where appropriate

2007-05-24 Thread Salyzyn, Mark
: [EMAIL PROTECTED]; linux-scsi@vger.kernel.org; > Salyzyn, Mark; Andrew Vasquez > Subject: Re: [patch 14/25] SCSI: use irq_handler_t where appropriate > > > On Wed, 2007-05-23 at 18:07 -0400, Jeff Garzik wrote: > > [EMAIL PROTECTED] wrote: > > > From: Jeff Garzik <

RE: [PATCH] [scsi] Remove __GFP_DMA

2007-05-24 Thread Salyzyn, Mark
So, is the sequence: p = kmalloc(upsg->sg[i].count,GFP_KERNEL); . . . addr = pci_map_single(dev->pdev, p, upsg->sg[i].count, data_dir); Going to ensure that we have a 31 bit (not 32 bit) physical address? If not, then I reject this patch. We can not consider replacement w

RE: [patch 16/25] drivers/scsi/ips.c: remove kernel 2.4 code

2007-05-24 Thread Salyzyn, Mark
Looks fine, totally inert. Inspected, could see no flaws. Disclaimer: Resisting application to Adaptec version of the sources since we still have to support legacy distributions, will keep synchronized none-the-less. Sincerely -- Mark Salyzyn > -Original Message- > From: [EMAIL PROTECTED

RE: [PATCH] [scsi] Remove __GFP_DMA

2007-05-23 Thread Salyzyn, Mark
The 31 bit limit for some of these cards is a problem, we currently only do __GFP_DMA for bounce buffer sg elements allocated for user supplied references in ioctls. I figure we should be using pci_alloc_consistent calls for these allocations to more accurately acquire memory within the 31 bit lim

RE: [PATCH] Un-remove aacraid devices

2007-05-23 Thread Salyzyn, Mark
] On Behalf Of Salyzyn, Mark Sent: Wednesday, May 23, 2007 1:17 PM To: James Bottomley Cc: Hannes Reinecke; SCSI Mailing List Subject: RE: [PATCH] Un-remove aacraid devices The applications may issue the start of an expansion, but then disappear. The Firmware is responsible for completing the job

RE: [PATCH] Un-remove aacraid devices

2007-05-23 Thread Salyzyn, Mark
7 PM To: Salyzyn, Mark Cc: Hannes Reinecke; SCSI Mailing List Subject: RE: [PATCH] Un-remove aacraid devices On Wed, 2007-05-23 at 12:35 -0400, Salyzyn, Mark wrote: > NAK > > This will break all our management applications, and will not allow us to manipulate the array configurations from

RE: [PATCH] Un-remove aacraid devices

2007-05-23 Thread Salyzyn, Mark
, May 23, 2007 8:51 AM To: Salyzyn, Mark Cc: SCSI Mailing List Subject: [PATCH] Un-remove aacraid devices Hi Mark, for some weird reason the aacraid driver insists on presenting all disks as 'removable' devices. This is gross hackery and causes userspace tools to not identify these device

[PATCH] aacraid: apply commit config for reset_devices flag

2007-05-22 Thread Salyzyn, Mark
nal Message- From: Salyzyn, Mark Sent: Wednesday, May 16, 2007 10:41 AM To: '[EMAIL PROTECTED]' Subject: RE: System does not boot if booted with "reset_devices" Vivek, could you please try the enclosed patch. This patch adds the aacraid.reset_devices flag and when either t

[PATCH] aacraid: add support for FUA

2007-05-18 Thread Salyzyn, Mark
dnesday, February 01, 2006 12:31 PM > To: linux-scsi; James Bottomley > Cc: Salyzyn, Mark > Subject: [PATCH 1/3] aacraid: reduce device probe warnings > > Received from Mark Salyzyn. > > This patch sets up some device quirks surrounding arrays to inform the > scsi layer tha

RE: [PATCH] aacraid: fix panic on short Inquiry

2007-05-16 Thread Salyzyn, Mark
Reject, transfer_len is an unsigned ... modified patch enclosed. Sincerely -- Mark Salyzyn > -Original Message- > From: James Bottomley [mailto:[EMAIL PROTECTED] > Sent: Wednesday, May 16, 2007 9:14 AM > To: Salyzyn, Mark > Cc: linux-scsi > Subject: [PATCH] aacraid:

[PATCH] aacraid: Correct sa platform support. (Was: [Bug 8469] Bad EIP value on pentium3 SMP kernel-2.6.21.1)

2007-05-15 Thread Salyzyn, Mark
5, 2007 1:30 AM > To: Salyzyn, Mark > Subject: Re: [Bug 8469] Bad EIP value on pentium3 SMP kernel-2.6.21.1 > > On Mon, 14 May 2007 22:10:20 -0700 > [EMAIL PROTECTED] wrote: > > > http://bugzilla.kernel.org/show_bug.cgi?id=8469 > > we appear to have a thumbs-up. Please c

[PATCH] aacraid: correct SUN products to README

2007-05-03 Thread Salyzyn, Mark
Correct SUN products in aacraid documentation, preliminary names were changed from internal project to customer product prior to release. ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patches attachments. This attached patch is against current scsi-misc-2.6 S

[PATCH] aacraid: superfluous adapter reset for IBM 8 series ServeRAID controllers

2007-05-01 Thread Salyzyn, Mark
ark Salyzyn > -Original Message- > From: Darrick J. Wong [mailto:[EMAIL PROTECTED] > Sent: Friday, April 27, 2007 5:49 PM > To: Salyzyn, Mark > Cc: linux-scsi@vger.kernel.org; Alexis Bruemmer; Vivek Goyal; > Judith Lebzelter > Subject: Re: [PATCH] aacraid: Initialize

RE: [PATCH] aacraid: fails to initialize after a kexec operation

2007-04-30 Thread Salyzyn, Mark
-- Mark Salyzyn > -Original Message- > From: Vivek Goyal [mailto:[EMAIL PROTECTED] > Sent: Monday, April 30, 2007 5:54 AM > To: Salyzyn, Mark > Cc: James Bottomley; Kexec Mailing List; Judith Lebzelter; > linux-scsi@vger.kernel.org; Darrick J. Wong > Subject: Re: [PATCH]

RE: [PATCH] aacraid: Initialize rx/rkt function pointers before calling them

2007-04-27 Thread Salyzyn, Mark
AIL PROTECTED] > Sent: Friday, April 27, 2007 2:11 PM > To: Salyzyn, Mark > Cc: linux-scsi@vger.kernel.org; Alexis Bruemmer; Vivek Goyal; > Judith Lebzelter > Subject: Re: [PATCH] aacraid: Initialize rx/rkt function > pointers before calling them > > > Salyzyn, Mark w

RE: [PATCH] aacraid: Initialize rx/rkt function pointers before calling them

2007-04-27 Thread Salyzyn, Mark
[mailto:[EMAIL PROTECTED] On Behalf Of Salyzyn, Mark > Sent: Friday, April 27, 2007 8:47 AM > To: Darrick J. Wong; linux-scsi@vger.kernel.org > Cc: Alexis Bruemmer > Subject: RE: [PATCH] aacraid: Initialize rx/rkt function > pointers before calling them > > > Reject, this

RE: [PATCH] aacraid: Initialize rx/rkt function pointers before calling them

2007-04-27 Thread Salyzyn, Mark
nel.org > Cc: Salyzyn, Mark; Alexis Bruemmer > Subject: [PATCH] aacraid: Initialize rx/rkt function pointers > before calling them > > > Commit 8418852d11f0bbaeebeedd4243560d8fdc85410d to scsi-misc > resulted in > the substitution of calls to rx_sync_cmd w

RE: [PATCH] aacraid: fails to initialize after a kexec operation

2007-04-24 Thread Salyzyn, Mark
1847 (I could be mistaken). Sincerely -- Mark Salyzyn > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Vivek Goyal > Sent: Tuesday, April 24, 2007 4:45 AM > To: Salyzyn, Mark > Cc: James Bottomley; Kexec Mailing List; Judith Lebzelter;

RE: [PATCH] aacraid: fails to initialize after a kexec operation

2007-04-23 Thread Salyzyn, Mark
nal Message- > From: Vivek Goyal [mailto:[EMAIL PROTECTED] > Sent: Monday, April 23, 2007 12:12 PM > To: Salyzyn, Mark > Cc: linux-scsi@vger.kernel.org; James Bottomley; Kexec > Mailing List; Judith Lebzelter > Subject: Re: [PATCH] aacraid: fails to initialize after a > ke

[PATCH] aacraid: fails to initialize after a kexec operation

2007-04-23 Thread Salyzyn, Mark
iginal Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Salyzyn, Mark > Sent: Monday, April 23, 2007 9:01 AM > To: [EMAIL PROTECTED]; linux-scsi@vger.kernel.org > Cc: Kexec Mailing List > Subject: RE: AACRAID fails to initialize after an kexec

RE: AACRAID fails to initialize after an kexec operation

2007-04-23 Thread Salyzyn, Mark
amp; 0xff) != 0xff) || reset_devices) && !aac_rx_restart_adapter(dev, 0)) Sincerely -- Mark Salyzyn > -Original Message- > From: Vivek Goyal [mailto:[EMAIL PROTECTED] > Sent: Monday, April 23, 2007 3:49 AM > To: linux-scsi@vger.kernel.org; AACRAID > Cc: Kexec Mailing Lis

[PATCH] aacraid: kzalloc

2007-04-16 Thread Salyzyn, Mark
Inspired somewhat by Vignesh Babu <[EMAIL PROTECTED]> patch to dpt_i2o.c to replace kmalloc/memset sequences with kzalloc, doing the same for the aacraid driver. ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patches. This attached patch is against current scsi

RE: [KJ][PATCH]dpt_i2o.c-kzalloc

2007-04-16 Thread Salyzyn, Mark
Thanks Vignesh. Looks fine to me except I would prefer to drop the first fragment and update it another day, another cleanup. The 64 bit updates may need to be pushed now that the i2o_block driver appears to have no maintainer (Markus pulled, I have not checked with him why). The Adaptec version o

[PATCH] aacraid: 2.6.21-rc6-mm1 aacraid not finding device

2007-04-13 Thread Salyzyn, Mark
orton > Cc: [EMAIL PROTECTED]; Salyzyn, Mark; > [EMAIL PROTECTED]; [EMAIL PROTECTED]; > [EMAIL PROTECTED] > Subject: Re: 2.6.21-rc6-mm1 aacraid not finding device > > > On Sun, 2007-04-08 at 14:35 -0700, Andrew Morton wrote: > > > ftp://ftp.kernel.org/pub/linux

[PATCH] aacraid: Correct SMC products in aacraid.txt

2007-04-04 Thread Salyzyn, Mark
Correct a spelling mistake for the SMC product names (replace 'B' with 'R') in the Documentation/scsi/aacraid.txt file. This is a follow-up to a documentation patch '[PATCH] aacraid: Add SMC and SUN products to README' submitted and accepted to scsi-misc-2.6 on March 27 2007. ObligatoryDisclaimer:

[PATCH] aacraid: [Fastboot] Panics for AACRAIDdriverduring'insmod' for kexec test [take 5]

2007-04-03 Thread Salyzyn, Mark
ets the missing platform function related to this discussion. Signed-off-by: Mark Salyzyn <[EMAIL PROTECTED]> --- Sincerely -- Mark Salyzyn > -Original Message- > From: James Bottomley [mailto:[EMAIL PROTECTED] > Sent: Tuesday, April 03, 2007 12:10 PM > To: Salyzyn, Ma

[PATCH] aacraid: [Fastboot] Panics for AACRAID driverduring'insmod' for kexec test [take 4]

2007-04-03 Thread Salyzyn, Mark
erely -- Mark Salyzyn > -Original Message- > From: James Bottomley [mailto:[EMAIL PROTECTED] > Sent: Tuesday, April 03, 2007 10:52 AM > To: Salyzyn, Mark > Cc: Judith Lebzelter; [EMAIL PROTECTED] > Subject: RE: [PATCH] aacraid: [Fastboot] Panics for AACRAID > driverdur

RE: [PATCH] aacraid: Panics during init time reset (Was: [PATCH] aacraid: [Fastboot] Panics for AACRAID driver during 'insmod' for kexec test)

2007-04-02 Thread Salyzyn, Mark
7 PM > To: Salyzyn, Mark > Cc: Judith Lebzelter; James Bottomley; > linux-scsi@vger.kernel.org; Duane Cox > Subject: Re: [PATCH] aacraid: Panics during init time reset > (Was: [PATCH] aacraid: [Fastboot] Panics for AACRAID driver > during 'insmod' for kexec test) >

RE: [PATCH] aacraid: Panics during init time reset (Was: [PATCH] aacraid: [Fastboot] Panics for AACRAID driver during 'insmod' for kexec test)

2007-04-02 Thread Salyzyn, Mark
int platform function. Later init code will reset it accordingly. Sincerely -- Mark Salyzyn > -Original Message- > From: Judith Lebzelter [mailto:[EMAIL PROTECTED] > Sent: Monday, April 02, 2007 3:44 PM > To: Salyzyn, Mark > Cc: Judith Lebzelter; James Bottomley; > lin

[PATCH] aacraid: Panics during init time reset (Was: [PATCH] aacraid: [Fastboot] Panics for AACRAID driver during 'insmod' for kexec test)

2007-04-02 Thread Salyzyn, Mark
Duane discovered in the scsi-misc-2.6 code that the reset handler could be called without the sync command handler set up resulting in a panic. Judith discovered this issue within minutes and has recently reported it. Here is a fix. IMHO, this needs to be applied immediately regardless of the stat

RE: [PATCH] aacraid: [Fastboot] Panics for AACRAID driver during 'insmod' for kexec test.

2007-03-30 Thread Salyzyn, Mark
Sincerely -- Mark Salyzyn > -Original Message- > From: Judith Lebzelter [mailto:[EMAIL PROTECTED] > Sent: Friday, March 30, 2007 2:38 PM > To: Salyzyn, Mark > Cc: Judith Lebzelter; [EMAIL PROTECTED]; > linux-scsi@vger.kernel.org; fastboot@lists.osdl.org > Subject:

RE: [PATCH] aacraid: [Fastboot] Panics for AACRAID driver during 'insmod' for kexec test.

2007-03-30 Thread Salyzyn, Mark
> -Original Message- > From: Judith Lebzelter [mailto:[EMAIL PROTECTED] > Sent: Friday, March 30, 2007 1:10 PM > To: Salyzyn, Mark > Cc: [EMAIL PROTECTED]; Judith Lebzelter; > linux-scsi@vger.kernel.org; fastboot@lists.osdl.org > Subject: Re: [PATCH] aacraid: [Fastboo

[PATCH] aacraid: [Fastboot] Panics for AACRAID driver during 'insmod' for kexec test.

2007-03-30 Thread Salyzyn, Mark
ed-off-by: Mark Salyzyn <[EMAIL PROTECTED]> --- Sincerely -- Mark Salyzyn > -Original Message- > From: Vivek Goyal [mailto:[EMAIL PROTECTED] > Sent: Friday, March 30, 2007 2:06 AM > To: Salyzyn, Mark > Cc: Judith Lebzelter; linux-scsi@vger.kernel.org; AACRAID; >

RE: [Fastboot] Panics for AACRAID driver during 'insmod' for kexec test.

2007-03-29 Thread Salyzyn, Mark
I have been working on a patch to the driver to do just this, reset the adapter during init if necessary. We want to limit the adapter's reset as it takes time (an additional 45 seconds or longer) for the Firmware to cycle... I will bump the priority of the testing for this patch. Sincerely -- Mar

[PATCH] aacraid: fix print of Firmware Build Date and add TSID

2007-03-28 Thread Salyzyn, Mark
The Adapter build date that is to be printed on instantiation was not displayed as a result of the supplemental adapter information structure not being in sync with the Firmware; the driver took an early test cycle version that had a miss-sized padded region at the head and the structure was not re

[PATCH] aacraid: remove unused or deprecated firmware constants

2007-03-28 Thread Salyzyn, Mark
Just sweeping the floor clean in one spot. Some of these constants have never been used in the driver or in the firmware (and thus are meaningless). Triggered this patch because I discovered one of the unused constants was actually incorrect and figured it was better to clean them out than correct

[PATCH] aacraid: resolve compiler warnings using ptrdiff_t

2007-03-27 Thread Salyzyn, Mark
Unsigned long is not always the same size as a pointer, namely on 32 bit systems with 64 bit address space. Ptrdiff_t is the same size as a pointer in all configurations. By using ptrdiff_t we can mitigate the warning messages on these configurations. There should be no side effects of this patch.

[PATCH] aacraid: Add SMC and SUN products to README

2007-03-27 Thread Salyzyn, Mark
Add SMC and SUN products to aacraid documentation ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patches attachments. This attached patch is against current scsi-misc-2.6 Signed-off-by: Mark Salyzyn <[EMAIL PROTECTED]> --- Sincerely -- Mark Salyzyn aacraid

[PATCH] aacraid: Add likely() and unlikely() Take 2

2007-03-26 Thread Salyzyn, Mark
igned-off-by: Mark Salyzyn <[EMAIL PROTECTED]> --- Sincerely -- Mark Salyzyn > -Original Message- > From: Arjan van de Ven [mailto:[EMAIL PROTECTED] > Sent: Thursday, March 22, 2007 5:24 AM > To: Salyzyn, Mark > Cc: linux-scsi > Subject: Re: [PATCH] aacraid: Add li

[PATCH] aacraid: Add likely() and unlikely()

2007-03-21 Thread Salyzyn, Mark
Add some likely() and unlikely() compiler hints in some of the aacraid hardware interface layers. There should be no operational side effects resulting from this patch and the changes should be mostly benign on x86 platforms. ObligatoryDisclaimer: Please accept my condolences regarding Outlook's h

RE: [PATCH] aacraid: cleanup and version stamp driver

2007-03-21 Thread Salyzyn, Mark
to view the content of the patch. Sincerely -- Mark Salyzyn > -Original Message- > From: Boaz Harrosh [mailto:[EMAIL PROTECTED] > Sent: Wednesday, March 21, 2007 2:50 PM > To: Salyzyn, Mark > Cc: linux-scsi > Subject: Re: [PATCH] aacraid: cleanup and version stamp driv

[PATCH] aacraid: cleanup and version stamp driver

2007-03-21 Thread Salyzyn, Mark
There is some residual cleanup of the last series of patches and the need to bump the revision number to draw the line in the sand. The cmd->SCp.phase is set in the aac_valid_context routine, then set again to the same value following it's return. The cmd->scsi_done is set twice in the aac_queueco

[PATCH] aacraid: check buffer address in aac_internal_transfer

2007-03-21 Thread Salyzyn, Mark
Captured a panic on an older kernel where an application issuing commands via sg was sending requests that lacked a request_buffer, thus the buffer pointer used in aac_internal_transer was NULL. The application was fixed closing the issue, but felt it was advised to immunize the driver against the

RE: aacraid not detecting drives if compiled into kernel

2007-02-26 Thread Salyzyn, Mark
ely -- Mark Salyzyn > -Original Message- > From: pcaldes [mailto:[EMAIL PROTECTED] > Sent: Monday, February 26, 2007 1:52 PM > To: Salyzyn, Mark > Cc: linux-scsi@vger.kernel.org > Subject: Re: aacraid not detecting drives if compiled into kernel > > > Thanx for y

RE: aacraid not detecting drives if compiled into kernel

2007-02-23 Thread Salyzyn, Mark
The driver in RHEL3 is old (1.1.5-2412ish, so not that old), use the Adaptec supplied sources and we will investigate. You can find them in our download section, just pick a 'modern' aac based card and browse for the latest. I believe I fixed the last set of problems associate with compiling the dr

[PATCH] aacraid: Add kernel command line parameter parsing

2007-01-30 Thread Salyzyn, Mark
One shortcoming of the driver relationship with the kernel is that there is no standard means of having the insmod parameters associated with a driver to also be parsed and set by the kernel parameter line. The enclosed patch is a proposal for the aacraid driver to pick up the kernel parameter line

RE: [PATCH] Add VPD support to aacraid

2007-01-25 Thread Salyzyn, Mark
Hannes, I am working the firmware and management software folks to find out how to mine for this information. In your patch, the controller serial number may be helpful, but not necessarily compliant? Besides persistent device id, what else is gained? The controller ensures persistent device id

[PATCH 1/1] aacraid: Product List Update

2006-12-18 Thread Salyzyn, Mark
Update drivers/scsi/aacraid/linit.c and Documentation/scsi/aacraid.txt file with the current list of adapters supported by the aacraid driver. Deprecated a few adapters that never shipped, corrected a few and added new adapters that matched the family code support. No functional changes to the driv

[PATCH] Add ASC-29320LPE ids to aic79xx driver

2006-12-05 Thread Salyzyn, Mark
Simple patch to add the new PCIe version of the 29320 card. Signed-off: Mark Salyzyn <[EMAIL PROTECTED]> ASC-29320LPE.patch Description: ASC-29320LPE.patch

RE: [PATCH] dpt_i2o pci_driver model

2005-09-06 Thread Salyzyn, Mark
Christoph Hellwig writes: > On Fri, Aug 19, 2005 at 11:05:41AM -0400, Salyzyn, Mark wrote: > > The sysinit structure is supposed to be a complete list of all peered > > i2o adapters. The current driver structure issued the sysinit command > > after all adapters were disc

RE: SCSI_OWNER_LOWLEVEL, scsicmd->owner & scsicmd->state visibility in the LLD

2005-08-26 Thread Salyzyn, Mark
- Mark Salyzyn -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Salyzyn, Mark Sent: Thursday, August 25, 2005 4:20 PM To: linux-scsi Subject: SCSI_OWNER_LOWLEVEL, scsicmd->owner & scsicmd->state visibility in the LLD The aacraid driver does not maintain

RE: [PATCH] dpt_i2o pci_driver model

2005-08-19 Thread Salyzyn, Mark
instantiation. Sincerely -- Mark Salyzyn -Original Message- From: Christoph Hellwig [mailto:[EMAIL PROTECTED] Sent: Friday, August 19, 2005 10:59 AM To: Salyzyn, Mark Cc: linux-scsi Subject: Re: [PATCH] dpt_i2o pci_driver model On Wed, Aug 17, 2005 at 01:04:05PM -0400, Salyzyn, Mark wrote

RE: [RFC] embryonic RAID class

2005-08-17 Thread Salyzyn, Mark
Under aac based adapters the build task reports the task number, current array water mark and end of array but not the array number associated with the build task in the AIF events returning from the Firmware. The management applications generally issue a series of enumerations to the devices and t

[PATCH] dpt_i2o pci_driver model

2005-08-17 Thread Salyzyn, Mark
Christoph Hellwig [mailto:[EMAIL PROTECTED] writes: > ... update the driver to use the pci_driver model ... The patch applies to the scsi-misc-2.6 git tree. The moving of adpt_install_hba to the near bottom of the dpt_i2o.c file creates a dirty context diff in that region which is hard to inspect

RE: [PATCH] aacraid 2.6: Fix aacraid probe breakageinscsi-block-2.6.git

2005-08-15 Thread Salyzyn, Mark
cerely -- Mark Salyzyn -Original Message- From: James Bottomley [mailto:[EMAIL PROTECTED] Sent: Monday, August 15, 2005 1:20 PM To: Salyzyn, Mark Cc: Mark Haverkamp; linux-scsi Subject: RE: [PATCH] aacraid 2.6: Fix aacraid probe breakageinscsi-block-2.6.git On Mon, 2005-08-15 at 13:06 -040

RE: [PATCH] aacraid 2.6: Fix aacraid probe breakage inscsi-block-2.6.git

2005-08-15 Thread Salyzyn, Mark
M To: Mark Haverkamp Cc: linux-scsi; Salyzyn, Mark Subject: Re: [PATCH] aacraid 2.6: Fix aacraid probe breakage inscsi-block-2.6.git On Mon, 2005-08-15 at 09:53 -0700, Mark Haverkamp wrote: > This patch fixes the bad assumption of the aacraid driver with use_sg. > I used the 3w- driver fix as

RE: Kernel driver for Adaptec S-ATA 1420SA

2005-08-15 Thread Salyzyn, Mark
Partially true regarding RAID cards. We publish sources for all our processor based RAID cards (dpt_i2o, aacraid). For the HostRAID cards, the RAID stack is in the driver, we publish the binaries for the one-piece drivers. We released a GPL driver for the HostRAID card as a raw driver + Enhanced

RE: remove-single-device removes mounted HDDs (kernel 2.6)

2005-08-12 Thread Salyzyn, Mark
I am of the same mind here regarding the busy check, better to have a coarse or overly paranoid understanding of ref count. But we desire a ref count on the disk (/dev/sda) overall, not on the partition (/dev/sda2) as would typically be mounted. As for using fuser as James had suggested, needing t

RE: remove-single-device removes mounted HDDs (kernel 2.6)

2005-08-11 Thread Salyzyn, Mark
des in the 'Adaptec Branch' of the aacraid driver as one of our OEM added values. Sincerely -- Mark Salyzyn -Original Message- From: James Bottomley [mailto:[EMAIL PROTECTED] Sent: Thursday, August 11, 2005 12:53 PM To: Salyzyn, Mark Cc: Harald Seipp; SCSI Mailing List Subject: RE:

RE: remove-single-device removes mounted HDDs (kernel 2.6)

2005-08-11 Thread Salyzyn, Mark
to:[EMAIL PROTECTED] Sent: Thursday, August 11, 2005 12:08 PM To: Salyzyn, Mark Cc: Harald Seipp; SCSI Mailing List Subject: RE: remove-single-device removes mounted HDDs (kernel 2.6) On Thu, 2005-08-11 at 11:51 -0400, Salyzyn, Mark wrote: > The problem with pushing this policy to the user is t

RE: remove-single-device removes mounted HDDs (kernel 2.6)

2005-08-11 Thread Salyzyn, Mark
The problem with pushing this policy to the user is that software applications have no means to determine that a device is currently in-use. For instance, the net result of pulling a device on a mounted filesystem is an eventual kernel panic. There needs to be a means to reasonably *predict* the b

RE: aacraid probe breaks in scsi-block-2.6.git

2005-08-10 Thread Salyzyn, Mark
Yup, James hit the nail on the head... :-( Sincerely -- Mark Salyzyn -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of James Bottomley Sent: Wednesday, August 10, 2005 1:27 PM To: Mark Haverkamp Cc: linux-scsi Subject: Re: aacraid probe breaks in scsi-block

RE: Adaptec i2o controller

2005-08-09 Thread Salyzyn, Mark
There is an additional 'build fix' patch that Andrew Morton submitted on the kernel list (I have changed out his dpr_i2o with dpt_i2o below though). --- Cc: "Salyzyn, Mark" <[EMAIL PROTECTED]> Cc: James Bottomley <[EM

RE: Adaptec i2o controller

2005-08-09 Thread Salyzyn, Mark
This dpt_i2o patch *plus* the patch Markus submitted yesterday for the i2o driver to the kernel list need to be performed to create the mutual exclusion between the two drivers. Jon, just select one (CONFIG_SCSI_DPT_I2O) or the other (CONFIG_I2O) in your .config Sincerely -- Mark Salyzyn -Or

[PATCH] Bug 4940 Repeatable Kernel Panic on Adaptec 2015S I20 device on bootup

2005-08-08 Thread Salyzyn, Mark
Suitable for both 2.4 and 2.6 version of the driver. Applies to scsi-misc-2.6 git tree. Prevent driver from loading if another driver (i2o) has already claimed the resources associated with the card. Discussion associated with this bug can be referenced at http://bugzilla.kernel.org/show_bug.cgi?i

RE: [PATCH] aacraid: correct use of cmd->timeout field

2005-08-08 Thread Salyzyn, Mark
James' patch is fine! Sincerely -- Mark Salyzyn -Original Message- From: Mark Haverkamp [mailto:[EMAIL PROTECTED] Sent: Friday, August 05, 2005 5:45 PM To: James Bottomley Cc: Salyzyn, Mark; SCSI Mailing List Subject: Re: [PATCH] aacraid: correct use of cmd->timeout field On F

RE: [PATCH 7/7] aacraid: sgraw command support

2005-08-05 Thread Salyzyn, Mark
[mailto:[EMAIL PROTECTED] Sent: Friday, August 05, 2005 10:45 AM To: Mark Haverkamp Cc: Salyzyn, Mark; linux-scsi; James Bottomley Subject: RE: [PATCH 7/7] aacraid: sgraw command support On Fri, 2005-08-05 at 07:24 -0700, Mark Haverkamp wrote: > On Thu, 2005-08-04 at 07:40 -0400, Salyzyn, Mark w

RE: [PATCH 6/7] aacraid: unlock around kfree

2005-08-04 Thread Salyzyn, Mark
ranch, and the guestimate was tweaked in that time to be 100% reliable. Sincerely -- Mark Salyzyn -Original Message- From: Arjan van de Ven [mailto:[EMAIL PROTECTED] Sent: Thursday, August 04, 2005 7:48 AM To: Salyzyn, Mark Cc: linux-scsi; Mark Haverkamp; James Bottomley Subject: RE: [PATC

RE: [PATCH 7/7] aacraid: sgraw command support

2005-08-04 Thread Salyzyn, Mark
ly -- Mark Salyzyn -Original Message- From: Arjan van de Ven [mailto:[EMAIL PROTECTED] Sent: Thursday, August 04, 2005 4:17 AM To: Mark Haverkamp Cc: Salyzyn, Mark; linux-scsi; James Bottomley Subject: Re: [PATCH 7/7] aacraid: sgraw command support On Wed, 2005-08-03 at 15:39 -0700, Mark

RE: [PATCH 6/7] aacraid: unlock around kfree

2005-08-04 Thread Salyzyn, Mark
7:07 PM To: Mark Haverkamp Cc: linux-scsi; Salyzyn, Mark Subject: Re: [PATCH 6/7] aacraid: unlock around kfree On Wed, 2005-08-03 at 15:39 -0700, Mark Haverkamp wrote: > kfree has the possibility of sleeping. It is generally considered poor > manners to hold on to a lock with the possibilit

RE: Location of the SCSI git trees has moved (again, sorry)

2005-08-02 Thread Salyzyn, Mark
James Bottomley sez: > Trees for http pull (or rsync, substituting with rsync://) rsync://www.kernel.org/pub/scm/linux/kernel/git/jejb/ sez: > WARNING: The rsync access method is DEPRECATED and will be REMOVED soon! > rsync: server sent "HTTP/1.0 403 Forbidden" rather than greeting Mark Salyzyn s

RE: PE1800 S-ATA RAID CERC6 with RHEL 3 / 4 ???

2005-07-11 Thread Salyzyn, Mark
One of the problems with this class (2.4.* based 64 bit) is the Software IOMMU. You may have to boot with 'swiotlb=12288' in order to free enough mapping resources for the card. RHEL4/CentOS4 does not have this problem. Sincerely -- Mark Salyzyn -Original Message- From: [EMAIL PROTECTED]

RE: [PATCH] 2.6 aacraid: Fix for controller load based timeouts

2005-07-08 Thread Salyzyn, Mark
iated with using the WD JD drives, which are not compatible with RAID cards because their internal error recovery paths. Sincerely -- Mark Salyzyn -Original Message- From: Ryan Anderson [mailto:[EMAIL PROTECTED] Sent: Friday, July 08, 2005 1:42 PM To: Mark Haverkamp Cc: James Bottomley; Sal

RE: [2.6 patch] drivers/scsi/dpt*: remove version.h dependencies

2005-04-15 Thread Salyzyn, Mark
sage- From: Adrian Bunk [mailto:[EMAIL PROTECTED] Sent: Thursday, April 14, 2005 8:49 PM To: James Bottomley Cc: Andrew Morton; SCSI Mailing List; Linux Kernel; [EMAIL PROTECTED]; Salyzyn, Mark Subject: [2.6 patch] drivers/scsi/dpt*: remove version.h dependencies On Sat, Apr 02, 2005 at 07:49:38AM -

RE: aacraid: kernel NULL pointer dereference

2005-04-13 Thread Salyzyn, Mark
linux-scsi; Salyzyn, Mark Subject: Re: aacraid: kernel NULL pointer dereference On Wed, 2005-04-13 at 18:02 +0200, Ralf Müller wrote: > I currently try to set up a server with an Adaptec 2810SA RAID controller. > While testing the Adaptec command line utility aacraid (actually the > comma

RE: [PATCH] aacraid 2.6: Address sparse warnings

2005-04-08 Thread Salyzyn, Mark
Al Viro sez: > > > +#define LE32_ALL_ONES ((__force __le32)0x) > > I don't like having this in an actual driver. It might make sense to > > either have this in a common header or actually allowing to assign all > > ones to __l32*/__be* variables. Al? > It doesn't make sense, period. Use

<    1   2   3   >