Re: [PATCH 0/3] SCSI device blacklist handling improvements

2017-12-07 Thread Martin K. Petersen
Bart, > Are you perhaps referring to the five __force casts? If so, do you > have a suggestion for avoiding that sparse reports false positive > warnings on the conversions between int and blist_flags_t? The only > approach I can think of to reduce the number of __force casts is to > embed these

Re: [PATCH 0/3] SCSI device blacklist handling improvements

2017-12-07 Thread Bart Van Assche
On Wed, 2017-12-06 at 21:03 -0500, Martin K. Petersen wrote: > > These three patches is what I came up with after having reviewed > > recent changes in the code for handling blacklist flags > > handling. Please consider these patches for kernel v4.16. > > I applied 1 and 3 to 4.16/scsi-queue. I am

Re: [PATCH 0/3] SCSI device blacklist handling improvements

2017-12-06 Thread Martin K. Petersen
Bart, > These three patches is what I came up with after having reviewed > recent changes in the code for handling blacklist flags > handling. Please consider these patches for kernel v4.16. I applied 1 and 3 to 4.16/scsi-queue. I am still not a fan of forcing u32. That's a recipe for disaster w

[PATCH 0/3] SCSI device blacklist handling improvements

2017-12-04 Thread Bart Van Assche
Hello Martin, These three patches is what I came up with after having reviewed recent changes in the code for handling blacklist flags handling. Please consider these patches for kernel v4.16. Note: since patch "Use 'blist_flags_t' for scsi_devinfo flags" is not yet in the 4.16/scsi-queue branch