Re: [PATCH 1/3] scsi: serialize -rescan against -remove

2015-03-16 Thread Paolo Bonzini
On 05/03/2015 14:37, Paolo Bonzini wrote: On 05/03/2015 14:33, Christoph Hellwig wrote: Any chance to get reviews for this series? Also we should at least expedite this first patch into 4.0-rc as it fixes scanning races in virtio_scsi. I reviewed 1 and 3, but I'm not really qualified

Re: [PATCH 1/3] scsi: serialize -rescan against -remove

2015-03-10 Thread Hannes Reinecke
On 02/02/2015 08:01 AM, Christoph Hellwig wrote: Lock the device embedded in the scsi_device to protect against concurrent calls to -remove. Signed-off-by: Christoph Hellwig h...@lst.de Acked-by: Alan Stern st...@rowland.harvard.edu Reviewed-by: Hannes Reinecke h...@suse.de Cheers, Hannes

Re: [PATCH 1/3] scsi: serialize -rescan against -remove

2015-03-05 Thread Christoph Hellwig
Any chance to get reviews for this series? Also we should at least expedite this first patch into 4.0-rc as it fixes scanning races in virtio_scsi. On Mon, Feb 02, 2015 at 02:01:24PM +0100, Christoph Hellwig wrote: Lock the device embedded in the scsi_device to protect against concurrent calls

Re: [PATCH 1/3] scsi: serialize -rescan against -remove

2015-03-05 Thread Paolo Bonzini
On 02/02/2015 14:01, Christoph Hellwig wrote: Lock the device embedded in the scsi_device to protect against concurrent calls to -remove. Signed-off-by: Christoph Hellwig h...@lst.de Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/scsi/scsi_scan.c | 7 +++ 1 file

Re: [PATCH 1/3] scsi: serialize -rescan against -remove

2015-03-05 Thread Paolo Bonzini
On 05/03/2015 14:33, Christoph Hellwig wrote: Any chance to get reviews for this series? Also we should at least expedite this first patch into 4.0-rc as it fixes scanning races in virtio_scsi. I reviewed 1 and 3, but I'm not really qualified for patch 2. Paolo On Mon, Feb 02, 2015 at

Re: [PATCH 1/3] scsi: serialize -rescan against -remove

2015-02-02 Thread Christoph Hellwig
On Fri, Jan 30, 2015 at 10:46:17AM +0100, Paolo Bonzini wrote: Great, we might want to revert that patch in 3.21. Is that fix in any tree yet? Seems like I missed it for the scsi tree at least. So unless you want it for 3.19/stable we might as well ust skip that patch. -- To unsubscribe from

Re: [PATCH 1/3] scsi: serialize -rescan against -remove

2015-02-02 Thread Paolo Bonzini
On 02/02/2015 13:59, Christoph Hellwig wrote: On Fri, Jan 30, 2015 at 10:46:17AM +0100, Paolo Bonzini wrote: Great, we might want to revert that patch in 3.21. Is that fix in any tree yet? Seems like I missed it for the scsi tree at least. So unless you want it for 3.19/stable we might as

[PATCH 1/3] scsi: serialize -rescan against -remove

2015-02-02 Thread Christoph Hellwig
Lock the device embedded in the scsi_device to protect against concurrent calls to -remove. Signed-off-by: Christoph Hellwig h...@lst.de Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/scsi/scsi_scan.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 1/3] scsi: serialize -rescan against -remove

2015-01-30 Thread Paolo Bonzini
On 30/01/2015 02:08, Fam Zheng wrote: On Fri, 01/30 00:11, Paolo Bonzini wrote: On 29/01/2015 00:00, Christoph Hellwig wrote: Lock the device embedded in the scsi_device to protect against concurrent calls to -remove. Signed-off-by: Christoph Hellwig h...@lst.de I wonder if this makes

Re: [PATCH 1/3] scsi: serialize -rescan against -remove

2015-01-29 Thread Alan Stern
On Thu, 29 Jan 2015, Christoph Hellwig wrote: Lock the device embedded in the scsi_device to protect against concurrent calls to -remove. Signed-off-by: Christoph Hellwig h...@lst.de --- drivers/scsi/scsi_scan.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 1/3] scsi: serialize -rescan against -remove

2015-01-29 Thread Paolo Bonzini
On 29/01/2015 00:00, Christoph Hellwig wrote: Lock the device embedded in the scsi_device to protect against concurrent calls to -remove. Signed-off-by: Christoph Hellwig h...@lst.de I wonder if this makes this problem: https://lkml.org/lkml/2015/1/5/9 go away. Paolo ---

Re: [PATCH 1/3] scsi: serialize -rescan against -remove

2015-01-29 Thread Fam Zheng
On Fri, 01/30 00:11, Paolo Bonzini wrote: On 29/01/2015 00:00, Christoph Hellwig wrote: Lock the device embedded in the scsi_device to protect against concurrent calls to -remove. Signed-off-by: Christoph Hellwig h...@lst.de I wonder if this makes this problem:

[PATCH 1/3] scsi: serialize -rescan against -remove

2015-01-28 Thread Christoph Hellwig
Lock the device embedded in the scsi_device to protect against concurrent calls to -remove. Signed-off-by: Christoph Hellwig h...@lst.de --- drivers/scsi/scsi_scan.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c