Re: [PATCH 2/2] Restart list search after unlock in scsi_remove_target

2015-11-16 Thread Christoph Hellwig
Bart, can you resend your patch on top of 4.4-rc1? I think we really need it so we should get it into 4.4 and backport it to -stable. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.k

Re: [PATCH 2/2] Restart list search after unlock in scsi_remove_target

2015-11-05 Thread James Bottomley
On Thu, 2015-11-05 at 08:55 -0800, Dan Williams wrote: > On Wed, Nov 4, 2015 at 2:44 PM, James Bottomley > wrote: > [..] > > The fundamental problem with this is how have the conditions that caused > > us to move away from list restart: > > > > commit bc3f02a795d3b4faa99d37390174be2a75d091bd > > A

Re: [PATCH 2/2] Restart list search after unlock in scsi_remove_target

2015-11-05 Thread Dan Williams
On Wed, Nov 4, 2015 at 2:44 PM, James Bottomley wrote: [..] > The fundamental problem with this is how have the conditions that caused > us to move away from list restart: > > commit bc3f02a795d3b4faa99d37390174be2a75d091bd > Author: Dan Williams > Date: Tue Aug 28 22:12:10 2012 -0700 > > [

Re: [PATCH 2/2] Restart list search after unlock in scsi_remove_target

2015-11-05 Thread Christoph Hellwig
On Wed, Nov 04, 2015 at 02:35:40PM -0800, Bart Van Assche wrote: > (replying to my own e-mail) > > Hello Christoph, > > Is it OK for you if I mention you as author of this e-mail ? I don't care whom this fix is attributed to, but let's get it in: Reviewed-by: Christoph Hellwig or Signed-off-by

Re: [PATCH 2/2] Restart list search after unlock in scsi_remove_target

2015-11-04 Thread Bart Van Assche
On 11/04/2015 02:44 PM, James Bottomley wrote: On Wed, 2015-11-04 at 14:35 -0800, Bart Van Assche wrote: (replying to my own e-mail) Hello Christoph, Is it OK for you if I mention you as author of this e-mail ? Could you just both co-operate, especially since there's not much difference betw

Re: [PATCH 2/2] Restart list search after unlock in scsi_remove_target

2015-11-04 Thread James Bottomley
On Wed, 2015-11-04 at 14:35 -0800, Bart Van Assche wrote: > On 10/30/2015 03:09 PM, Bart Van Assche wrote: > > When dropping a lock while iterating a list we must restart the search > > as other threads could have manipulated the list under us. Without this > > we can get stuck in an endless loop.

Re: [PATCH 2/2] Restart list search after unlock in scsi_remove_target

2015-11-04 Thread Bart Van Assche
On 10/30/2015 03:09 PM, Bart Van Assche wrote: When dropping a lock while iterating a list we must restart the search as other threads could have manipulated the list under us. Without this we can get stuck in an endless loop. This is a slightly modified version of a patch from Christoph Hellwig

[PATCH 2/2] Restart list search after unlock in scsi_remove_target

2015-10-30 Thread Bart Van Assche
When dropping a lock while iterating a list we must restart the search as other threads could have manipulated the list under us. Without this we can get stuck in an endless loop. This is a slightly modified version of a patch from Christoph Hellwig (see also https://www.spinics.net/lists/linux-sc