Re: [PATCH 08/22] qla2xxx: Refactore target code to remove symbol dependency

2017-01-17 Thread Dr. Greg Wettstein
On Dec 16, 12:17am, Christoph Hellwig wrote: } Subject: Re: [PATCH 08/22] qla2xxx: Refactore target code to remove symbol Good morning, I hope the week is going well for everyone. Really late to this thread but am just getting caught d up after the holidays and putting out fires. > On Thu, Dec

Re: [PATCH 08/22] qla2xxx: Refactore target code to remove symbol dependency

2016-12-16 Thread Bart Van Assche
On 12/15/2016 09:50 PM, Tran, Quinn wrote: > Qlogic was asked to support other Target Stack (SCST) using the same > qla2xxx.ko upstream driver. I had mentioned this during the last 2015 > LSF get together. Hopefully, that gives a better context. The > understanding that came away was “Qlogic do

Re: [PATCH 08/22] qla2xxx: Refactore target code to remove symbol dependency

2016-12-16 Thread Christoph Hellwig
On Thu, Dec 15, 2016 at 08:50:39PM +, Tran, Quinn wrote: > Christoph, > > Qlogic was asked to support other Target Stack (SC ST) using the same > qla2xxx.ko upstream driver. I had mentioned this during the last 2015 LSF > get together. Hopefully, that gives a better context. The

Re: [PATCH 08/22] qla2xxx: Refactore target code to remove symbol dependency

2016-12-15 Thread Tran, Quinn
avium.com>, "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org> Subject: Re: [PATCH 08/22] qla2xxx: Refactore target code to remove symbol dependency Resent-From: <quinn.t...@qlogic.com> Hi Christoph, On 12/14/16, 1:18 PM, "Christoph Hellwi

Re: [PATCH 08/22] qla2xxx: Refactore target code to remove symbol dependency

2016-12-15 Thread Madhani, Himanshu
Hi Christoph, On 12/14/16, 1:18 PM, "Christoph Hellwig" wrote: > - the new qla2x00_free_fcport is entirely pointless, please drop > that part of the patch (and even if it wasn't pointless it should > have been a patch on it's own) > - please use struct names and not

Re: [PATCH 08/22] qla2xxx: Refactore target code to remove symbol dependency

2016-12-14 Thread Christoph Hellwig
- the new qla2x00_free_fcport is entirely pointless, please drop that part of the patch (and even if it wasn't pointless it should have been a patch on it's own) - please use struct names and not typedefs for your new structures - pretty much avery single items in your list should be a